Paul [Sun, 17 Dec 2017 11:45:31 +0000 (11:45 +0000)]
for release 3.16.0
Paul [Sun, 17 Dec 2017 11:38:46 +0000 (11:38 +0000)]
update translations
updated by David Medina, Erik P. Olsen, Simon Legner, Tommi A Pirinen,
Páder Rezső, Luigi Votta, UTUMI Hirosi, Petter Adsen, Marcel Pol, Jakub
Jankiewicz, Frederico Goncalves Guimaraes, Mikhail Kurinnoi, Slavko,
Andreas Rönnquist.
new translation: Romanian by Cristian Secară
remove unmaintained Hebrew translation.
Ricardo Mones [Sun, 17 Dec 2017 02:33:58 +0000 (03:33 +0100)]
Update list of TLDs for release
Andrej Kacian [Thu, 14 Dec 2017 22:24:20 +0000 (23:24 +0100)]
Add proper ifdefs around master_passphrase() calls.
Andrej Kacian [Thu, 14 Dec 2017 22:18:50 +0000 (23:18 +0100)]
Fix buffer length handling in GnuTLS password encryption and decryption.
Also zero out one forgotten copy of plaintext password
before freeing it. Oops!
Ricardo Mones [Thu, 14 Dec 2017 12:39:23 +0000 (13:39 +0100)]
Space preview icons equally
Ricardo Mones [Tue, 12 Dec 2017 17:27:23 +0000 (18:27 +0100)]
Fix bug 3935: build from GIT master broken on arch linux
Completes
48f72c22f91fbe0d6e872e89bd4dce9d39090e81 to allow building
with disabled LDAP support.
Ricardo Mones [Tue, 12 Dec 2017 12:30:55 +0000 (13:30 +0100)]
Update lists of authors
Ricardo Mones [Tue, 12 Dec 2017 12:06:36 +0000 (13:06 +0100)]
Update Spanish translation
wwp [Mon, 11 Dec 2017 10:36:04 +0000 (11:36 +0100)]
Update French translation.
Andrej Kacian [Sun, 10 Dec 2017 09:49:02 +0000 (10:49 +0100)]
Fix bug 3931: segfault searching server with master password
Request master passphrase earlier and inhibit search if no master
passphrase is available.
Andrej Kacian [Sun, 10 Dec 2017 09:49:01 +0000 (10:49 +0100)]
Fix bug 3793: segfault when autocompletion asks for master passphrase
This is done by checking early if any ldap server is password-protected,
and asking for master passphrase when compose window appears. If user
cancels the dialog (does not enter the passphrase), we temporarily
disable the password-protected LDAP servers, just for that particular
compose window. We reenable them in compose_destroy().
Andrej Kacian [Sun, 10 Dec 2017 09:49:00 +0000 (10:49 +0100)]
Add public call to get master password
Ricardo Mones [Sun, 10 Dec 2017 01:52:51 +0000 (02:52 +0100)]
Prune gtk_widget_set_size_request calls
Andrej Kacian [Sat, 9 Dec 2017 16:05:59 +0000 (17:05 +0100)]
Copyright year update in plugins' version.rc files.
Andrej Kacian [Sat, 9 Dec 2017 16:05:36 +0000 (17:05 +0100)]
Some FileDescription fixes in plugins' version.rc files.
Thanks to Woody for noticing.
Ricardo Mones [Tue, 5 Dec 2017 00:27:06 +0000 (01:27 +0100)]
Color buttons proportional to font size
Instead of hardcoding a size which doesn't look the same on different
resolutions, use a space;m-space;space label and let GTK+ to compute
the appropriate button size for current font.
Ricardo Mones [Sun, 26 Nov 2017 20:35:50 +0000 (21:35 +0100)]
Adjust spelling preferences widgets
Ricardo Mones [Tue, 5 Dec 2017 21:51:57 +0000 (22:51 +0100)]
Remove list of bugs which are not outstanding
Olaf Hering [Wed, 22 Nov 2017 17:03:15 +0000 (18:03 +0100)]
Set flags of all selected messages before updating view
If a collapsed, unread thread is marked as 'ignore thread' the first
message remains bold in the message list. That happens because
summary_ignore_thread_func calls summary_set_row_marks, which finds
unread children. As a result bold_style is selected.
To fix this it is required to first update the message flags of all
selected messages, before updating the view of all selected messages.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Olaf Hering [Wed, 22 Nov 2017 17:03:14 +0000 (18:03 +0100)]
Remove stale MSG_IS_RETRCPT_PENDING
The bitflag MSG_RETRCPT_PENDING is not defined, the existing flags do not
indicate a typo. Remove this stale macro to avoid confusion.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Ricardo Mones [Sat, 2 Dec 2017 22:44:34 +0000 (23:44 +0100)]
Complete previous patch
Ricardo Mones [Sat, 2 Dec 2017 20:12:39 +0000 (21:12 +0100)]
Make column selector UI like open actions
Set remove button to center column and add border to lists
Michael Gmelin [Sun, 26 Nov 2017 20:09:22 +0000 (21:09 +0100)]
Fix bug #3924: Unbreak sieve host configuration on FreeBSD
Also, adds extra check for config->host
Olaf Hering [Wed, 22 Nov 2017 17:03:16 +0000 (18:03 +0100)]
Fix truncated input widgets in preferences window
With larger UI fontsize some input fields are truncated, the numbers can
not be read properly. Remove the hardcoded width values, let GTK pick a
value.
Andrej Kacian [Fri, 24 Nov 2017 23:42:34 +0000 (00:42 +0100)]
Use statusbar progress meter when opening/refreshing a NNTP folder.
Andrej Kacian [Wed, 22 Nov 2017 23:31:26 +0000 (00:31 +0100)]
Reenable filtering log on Windows, as it is no longer crashy.
It was previously disabled in
83eaf78e3.
Olaf Hering [Wed, 22 Nov 2017 17:03:19 +0000 (18:03 +0100)]
Move pointer usage after pointer check
In procmime_decode_content mimeinfo is dereferenced before cm_return_val_if_fail().
Abhay S. Kushwaha [Thu, 23 Nov 2017 12:37:55 +0000 (18:07 +0530)]
Rssyl: fix Windows build
Ricardo Mones [Mon, 13 Nov 2017 20:11:33 +0000 (21:11 +0100)]
Use entity decoding API in HTML parser
Ricardo Mones [Mon, 13 Nov 2017 19:40:11 +0000 (20:40 +0100)]
Rssyl: use new entity decoding API
Ricardo Mones [Mon, 13 Nov 2017 00:31:44 +0000 (01:31 +0100)]
Complete, normalize and fix table of entities
https://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references
Ricardo Mones [Mon, 6 Nov 2017 22:41:27 +0000 (23:41 +0100)]
Implement HTML entity decoding in one function
Content of symbols table remixed from existing html.c and
rssyl/strutils.c tables.
wwp [Fri, 10 Nov 2017 10:37:38 +0000 (11:37 +0100)]
Yet another string correction.
Andrej Kacian [Thu, 9 Nov 2017 19:31:26 +0000 (20:31 +0100)]
A hopefully better fix for commit
9f1c5fef1 when building with GpgME < 1.7.0.
gpgme_check_version() should only be used during
initialization, according to GpgME doc.
Paul [Thu, 9 Nov 2017 08:48:50 +0000 (08:48 +0000)]
oh-so-minor string correction
Andrej Kacian [Thu, 9 Nov 2017 08:11:35 +0000 (09:11 +0100)]
Fix commit
9f1c5fef1 when building with GpgME < 1.7.0.
Andrej Kacian [Wed, 8 Nov 2017 23:31:27 +0000 (00:31 +0100)]
Show full key/signature fingerprints.
Closes bug 3910 - Displaying of problematic short key IDs for GPG messages
Andrej Kacian [Wed, 8 Nov 2017 22:49:52 +0000 (23:49 +0100)]
Do not limit password/userid newline check to just POP3.
Ricardo Mones [Fri, 3 Nov 2017 16:46:19 +0000 (17:46 +0100)]
Use appropriate array for searching
Ricardo Mones [Mon, 30 Oct 2017 10:00:17 +0000 (11:00 +0100)]
Fix CID
1420437 (OVERFLOW_BEFORE_WIDEN)
Andrej Kacian [Sun, 29 Oct 2017 18:14:26 +0000 (19:14 +0100)]
Use GIO API instead of g_stat() in prefs_themes_file_stats() on Windows.
Andrej Kacian [Sun, 29 Oct 2017 17:40:54 +0000 (18:40 +0100)]
Use GIO API instead of g_stat() in compose_draft() on Windows.
Andrej Kacian [Sun, 29 Oct 2017 17:31:18 +0000 (18:31 +0100)]
Use GIO API instead of g_stat() on Windows in compose_add_attachments() and get_file_size().
Andrej Kacian [Sun, 29 Oct 2017 17:12:12 +0000 (18:12 +0100)]
Use GIO API instead of g_stat() in compose_insert_file() on Windows.
Andrej Kacian [Sat, 28 Oct 2017 15:57:48 +0000 (17:57 +0200)]
Use GIO API instead of g_stat() in mh_is_msg_changed() on Windows.
Andrej Kacian [Sat, 28 Oct 2017 12:49:47 +0000 (14:49 +0200)]
Avoid use of stat() in procheader_parse_file() on Windows.
Since GLib on different Windows versions has different
ideas about sizes of struct stat field sizes and is
inconsistent about it on 64-bit systems, we take advice
from GLib's own gstdio.h, and use GIO API to get file
attributes instead.
This will likely have to be changed for all uses of
stat() or g_stat() elsewhere.
All this to stop Claws Mail showing "1GB" size for all
emails in summaryview on 64-bit Win10.
Andrej Kacian [Sat, 28 Oct 2017 11:58:26 +0000 (13:58 +0200)]
Disallow '?' in filename when saving message part on Windows.
Andrej Kacian [Sat, 28 Oct 2017 11:58:03 +0000 (13:58 +0200)]
Revert "Disallow '?' in filename when saving message part on Windows."
This reverts commit
6e644bd2af1eae46fc9db874fc42e6b9bb89b9c8.
Andrej Kacian [Sat, 28 Oct 2017 11:28:26 +0000 (13:28 +0200)]
Disallow '?' in filename when saving message part on Windows.
Andrej Kacian [Sat, 28 Oct 2017 07:33:15 +0000 (09:33 +0200)]
Updated Fancy's claws.def for the Windows build
Andrej Kacian [Wed, 25 Oct 2017 18:40:41 +0000 (20:40 +0200)]
Fix missing invalid regexp indication in folder preferences.
The entry is supposed to turn red, but it couldn't
because of a logic error.
Andrej Kacian [Wed, 25 Oct 2017 18:28:11 +0000 (20:28 +0200)]
Disallow newline character in POP3 account username or password.
The entries will have red background and preferences
will refuse to be saved, with an alertpanel telling why,
if a newline is found in either of the two entries.
This is only checked for POP3 protocol, as other protocols
encode passwords e.g. in base64, and so will not break
the communication to server by sending the extraneous
newline verbatim.
Andrej Kacian [Wed, 25 Oct 2017 18:11:50 +0000 (20:11 +0200)]
Use subst_char() in fancy_set_defaults().
Andrej Kacian [Mon, 23 Oct 2017 16:57:50 +0000 (18:57 +0200)]
More and better leak fixes after commit
9729bf0e0.
Andrej Kacian [Mon, 23 Oct 2017 16:06:27 +0000 (18:06 +0200)]
Fix memory leaks introduced in recent commit
9729bf0e0.
Andrej Kacian [Mon, 23 Oct 2017 14:16:55 +0000 (16:16 +0200)]
Removed two obsolete statuswindow_* aliases.
Andrej Kacian [Mon, 23 Oct 2017 11:49:15 +0000 (13:49 +0200)]
Fetch XOVER and XHDR data in batches of 5000.
This avoids long stalls, which sometimes confuse libetpan.
It also allows implementing some sort of progressbar in UI.
Andrej Kacian [Sun, 22 Oct 2017 15:27:08 +0000 (17:27 +0200)]
Made Fancy's custom stylesheet pref work on Windows
Andrej Kacian [Sun, 22 Oct 2017 10:39:01 +0000 (12:39 +0200)]
Fancy: Escape the custom stylesheet path for use in URI.
This allows for file/folder names with e.g. space in them.
Paul [Tue, 10 Oct 2017 08:33:23 +0000 (09:33 +0100)]
fix bug 3893, ' Text mode open/copy web links ignores trailing tilde(s)'
Andrej Kacian [Thu, 5 Oct 2017 11:17:49 +0000 (13:17 +0200)]
master_passphrase_is_set() and _is_correct() do not return const bool.
Andrej Kacian [Sat, 1 Jul 2017 10:23:33 +0000 (12:23 +0200)]
Use separate account configuration for OpenPGP and for S/MIME.
This is useful for users who switch between privacy systems.
Based on patch by Thomas Orgis.
Closes bug Bug 3834 - [PATCH] separate account prefs for
S/MIME to be able to specify keys for both PGP and S/MIME
Ricardo Mones [Thu, 21 Sep 2017 08:49:52 +0000 (10:49 +0200)]
Document the new --insert command line option
added in commit
9b17603ded77a56d10e56e80b9647487e25546da
Ricardo Mones [Wed, 20 Sep 2017 20:06:03 +0000 (22:06 +0200)]
Revert "Fix bug #3855: segfault at startup with old profile and IMAP account"
Thanks to commit
c3167bf1a4bf76a75813856d48e9d3c00f6c3849 which allows
to access folder class functions at earlier stages without causing #3855.
This reverts commit
667c9d3eaf0487193cc7873e6d3a63959a03d7f9.
Colin Leroy [Mon, 18 Sep 2017 08:09:52 +0000 (10:09 +0200)]
Fix a possible leak
Colin Leroy [Mon, 18 Sep 2017 08:03:39 +0000 (10:03 +0200)]
Fix double-free of keys
Colin Leroy [Fri, 15 Sep 2017 13:45:46 +0000 (15:45 +0200)]
CLI: Add a --insert option to --compose, allowing to insert files.
Andrej Kacian [Sun, 6 Aug 2017 16:43:43 +0000 (18:43 +0200)]
Handle config_version update separately for accounts.
Instead of loading entire configuration from all the
files in rcdir and doing an update at the end, we
now upgrade each "part" right after we load it.
This is to allow greater flexibility during the time
not all of the configuration is loaded yet, e.g. folders
using correct folderclass functions, based on protocol
of account owning a particular folder.
This is currently affecting clawsrc and accountrc, but
it will be trivial to extend it to other rcdir files
as needed.
Ricardo Mones [Thu, 7 Sep 2017 12:05:36 +0000 (14:05 +0200)]
Update authors' files
Flavio Leitner [Sat, 12 Aug 2017 21:28:23 +0000 (18:28 -0300)]
Fix bug #3881: Keep read thread during update if it is selected.
When new emails arrive, the summary list is updated and the read
threads are removed if the option 'Hide read threads' is checked.
However, if you are reading the last email of a thread, then it
automatically goes to the next email. If the new selected email
happens to be the last read in a thread, then the next update
will do the same even though the user might not have seen that
message yet.
This patch fixes it to keep the thread if a message is selected.
Paul [Tue, 5 Sep 2017 15:08:30 +0000 (16:08 +0100)]
fix bug 3892, 'build fails with enchant-2.1.0'
bumps the minimum required version of enchant to version 1.4.0
Paul [Sat, 2 Sep 2017 09:44:48 +0000 (10:44 +0100)]
fix bug 3852, 'delete header entry button doesn't restore colour'
Paul [Thu, 31 Aug 2017 09:13:28 +0000 (10:13 +0100)]
fix bug 3886, '"About to send mail to 2 recipients" warning when one of them is Reply-To'
wwp [Wed, 30 Aug 2017 09:20:29 +0000 (11:20 +0200)]
Fix wrong 'attach_output' in description of symbols (templates), it's
'attach_program' that works.
wwp [Tue, 29 Aug 2017 12:41:23 +0000 (14:41 +0200)]
Lower the librsvg requirement to 2.39 (works on CentOS7 with
this).
Andrej Kacian [Sat, 26 Aug 2017 08:03:51 +0000 (10:03 +0200)]
Fix typo around libarchive in configure.ac.
Patch by Orbea, Bug 3866 - slibtool causes compile failure
Andrej Kacian [Sat, 26 Aug 2017 08:00:07 +0000 (10:00 +0200)]
Fixed incorrect PERL_LDFLAGS modification with sed.
Patch by Orbea, Bug 3866 - slibtool causes compile failure
Ricardo Mones [Wed, 9 Aug 2017 14:48:38 +0000 (16:48 +0200)]
Fix bug #3855: segfault at startup with old profile and IMAP account
Revert "Remove duplicated code and include".
This reverts commit
300f811f3bbf10455ca55d9b01da6705dd1e07bb.
Andrej Kacian [Fri, 28 Jul 2017 17:55:04 +0000 (19:55 +0200)]
Fix a small memory leak in procmime_get_mime_type().
Andrej Kacian [Fri, 28 Jul 2017 17:50:29 +0000 (19:50 +0200)]
Fix a memory leak in empty subject warning dialog in compose.c.
Andrej Kacian [Fri, 28 Jul 2017 17:46:13 +0000 (19:46 +0200)]
Fix template parsing broken by commit
814b087.
Ricardo Mones [Thu, 27 Jul 2017 08:09:37 +0000 (10:09 +0200)]
Fix D-Bus detection
Andrej Kacian [Mon, 24 Jul 2017 16:26:38 +0000 (18:26 +0200)]
Removed a nonexistent function from addressbook.h.
The function was addressbook_load_completion().
Ricardo Mones [Mon, 24 Jul 2017 07:35:05 +0000 (09:35 +0200)]
Really handle the NULLs, don't scream at them
Ricardo Mones [Sun, 23 Jul 2017 10:38:06 +0000 (12:38 +0200)]
Check for NULLs params within the functions
As assumed in the prefs_themes_done() calls. May fix some strange crash
when exiting Claws Mail in Debian's version 3.14.1-3+b1:
*** Error in `/usr/bin/claws-mail': munmap_chunk(): invalid pointer:
0x00000000026a6f80 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x70bcb)[0x7fa85407cbcb]
/lib/x86_64-linux-gnu/libc.so.6(+0x76f96)[0x7fa854082f96]
/usr/bin/claws-mail(stock_pixmap_themes_list_free+0x28)[0x55a7a8]
/usr/bin/claws-mail(prefs_themes_done+0x3a)[0x5389ba]
/usr/bin/claws-mail[0x449329]
/usr/bin/claws-mail(main+0x2326)[0x44b986]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1)[0x7fa85402c2b1]
/usr/bin/claws-mail(_start+0x2a)[0x44bfda]
Andrej Kacian [Sun, 16 Jul 2017 18:04:57 +0000 (20:04 +0200)]
Avoid one strdup in address_completion_complete_address_in_entry().
Andrej Kacian [Sun, 16 Jul 2017 17:38:12 +0000 (19:38 +0200)]
Fixed a memory leak in address completion.
Andrej Kacian [Sun, 16 Jul 2017 17:31:25 +0000 (19:31 +0200)]
Pgpmime: fix two memory leak in MIME boundary handling.
Andrej Kacian [Sun, 16 Jul 2017 17:22:23 +0000 (19:22 +0200)]
Fixed two memory leaks around procheader_get_one_field().
Andrej Kacian [Sun, 16 Jul 2017 15:53:38 +0000 (17:53 +0200)]
Managesieve: fix memory leak when saving password from account prefs
Ricardo Mones [Sun, 16 Jul 2017 15:38:38 +0000 (17:38 +0200)]
Dedicated icons for toolbar's new privacy buttons
Andrej Kacian [Sun, 16 Jul 2017 15:37:16 +0000 (17:37 +0200)]
Fixed another memory leak in filtering pref dialog.
Andrej Kacian [Sun, 16 Jul 2017 12:39:21 +0000 (14:39 +0200)]
Fixed two tiny memory leaks in filtering pref dialog.
Andrej Kacian [Sun, 16 Jul 2017 10:18:03 +0000 (12:18 +0200)]
Second attempt at fixing the memory leak in matcherrc rule parsing.
This time, we take into account that the memory allocated by
yyparse() uses is sometimes used and freed by another
function higher in the stack.
Andrej Kacian [Thu, 13 Jul 2017 08:31:04 +0000 (10:31 +0200)]
Revert "Fix a memory leak in matcherrc rule parsing."
This reverts commit
2103e3787ab8ef2c8eb43d35292e5c91b5b61237.
Closes bug #3848 - Cannot edit existing filter or processing rules.
Andrej Kacian [Wed, 12 Jul 2017 21:52:06 +0000 (23:52 +0200)]
Fix a memory leak in get_fingerprint().
Andrej Kacian [Wed, 12 Jul 2017 21:47:39 +0000 (23:47 +0200)]
Fixed an uninitialized variable use in check_cert().
Andrej Kacian [Wed, 12 Jul 2017 20:16:00 +0000 (22:16 +0200)]
Fix three small memory leaks in addressbook.
Andrej Kacian [Wed, 12 Jul 2017 18:43:07 +0000 (20:43 +0200)]
Correction of previous commit
6fedb78e7.
We do not want to prematurely close tmpfp handle if
it points to outfp.