Andrej Kacian [Sat, 20 Jun 2015 21:03:50 +0000 (23:03 +0200)]
Allow TLS connections to LDAP on Windows.
The comment no longer applies, TLS seems to work fine for LDAP
connections on Windows. Closes bug #2827 - Feature request: Add
TLS/SSL support for LDAP server access
Andrej Kacian [Sat, 20 Jun 2015 20:38:53 +0000 (22:38 +0200)]
Do not free LDAP error string on Windows.
Fixes bug #2816 - LDAP addressbook search crashes Claws Mail.
Paul [Fri, 19 Jun 2015 18:12:57 +0000 (19:12 +0100)]
fix error on load: 'undefined symbol: response_is_ok'
happened for me with gcc5.
Patch by Charles Lehner.
Andrej Kacian [Fri, 19 Jun 2015 15:33:49 +0000 (17:33 +0200)]
The "mark_as_spam" filtering action does not move message.
The alternative was to rename the action to
"mark_as_spam_and_move_to_spam_folder".
Andrej Kacian [Thu, 18 Jun 2015 21:58:51 +0000 (23:58 +0200)]
Various small fix ups needed for mingw-w64 build.
Andrej Kacian [Thu, 18 Jun 2015 21:39:12 +0000 (23:39 +0200)]
RSSyl: Use our CA certificate bundle on Windows.
Libcurl seems to want a CA cert bundle for any https connection,
even if verification is disabled. On Windows, there is no default
bundle or directory libcurl knows about, so we give it our own,
pointed to by claws_ssl_get_cert_file().
Andrej Kacian [Thu, 18 Jun 2015 21:37:55 +0000 (23:37 +0200)]
RSSyl: If given, set CURLOPT_CAINFO regardless of libcurl version.
Ricardo Mones [Thu, 18 Jun 2015 00:15:12 +0000 (02:15 +0200)]
Remove unchecked realloc which is unnecessary
Ricardo Mones [Thu, 18 Jun 2015 00:13:28 +0000 (02:13 +0200)]
Fix leak on failing realloc
Holger Berndt [Sun, 14 Jun 2015 19:45:16 +0000 (21:45 +0200)]
GData plugin: Support cold-start
Store refresh token, and try to authorize Google access with it on
startup. Interactive authorization is now only the fallback if refreshing
cannot be done or was not successful.
Fixes bug #3432 but requires yet unreleased libgdata, see
https://bugzilla.gnome.org/show_bug.cgi?id=750746
Andrej Kacian [Wed, 17 Jun 2015 11:47:01 +0000 (13:47 +0200)]
RSSyl: Allow giving custom CA cert file to libfeed
Andrej Kacian [Tue, 16 Jun 2015 21:04:24 +0000 (23:04 +0200)]
RSSyl: Free GError from memory where necessary.
Andrej Kacian [Tue, 16 Jun 2015 20:54:36 +0000 (22:54 +0200)]
RSSyl: Use g_mkstemp() instead of mkstemp()
Andrej Kacian [Tue, 16 Jun 2015 20:52:47 +0000 (22:52 +0200)]
RSSyl: Got rid of opendir/readdir/closedir in favour of Glib functions.
Ricardo Mones [Tue, 16 Jun 2015 10:50:36 +0000 (12:50 +0200)]
Remove unnecessary “Use this” for changing theme
Use the standard preferences button “Apply” instead.
Holger Berndt [Sun, 14 Jun 2015 12:42:19 +0000 (14:42 +0200)]
Update sample jhbuildrc file
Holger Berndt [Sun, 14 Jun 2015 12:41:38 +0000 (14:41 +0200)]
Gdata plugin: Remove now obsolete CM_GDATA_CLIENT_ID macro def
Holger Berndt [Sun, 14 Jun 2015 12:40:52 +0000 (14:40 +0200)]
GData plugin: Remove now obsolete password pref
Holger Berndt [Sun, 14 Jun 2015 12:28:20 +0000 (14:28 +0200)]
GData plugin: Switch from ClientLogin to OAuth2
Google has recently removed ClientLogin support.
The switch to OAuth2 fixes bug #3432 and makes the plugin work
again, but with a degraded user experience. The authorization
needs to be redone on every program start. Improving that is
pending on https://bugzilla.gnome.org/show_bug.cgi?id=750746
Holger Berndt [Sun, 14 Jun 2015 09:40:47 +0000 (11:40 +0200)]
GData plugin: Change debug output order during plugin load
Holger Berndt [Sat, 30 May 2015 17:26:35 +0000 (19:26 +0200)]
GData plugin: Drop support for libgdata < 0.9
Andrej Kacian [Sun, 14 Jun 2015 11:34:37 +0000 (13:34 +0200)]
Fancy: updated list of exports from core claws-mail for win32 build.
Colin Leroy [Wed, 10 Jun 2015 09:51:05 +0000 (11:51 +0200)]
Fix english (I think)
Ricardo Mones [Tue, 9 Jun 2015 07:44:16 +0000 (09:44 +0200)]
Add missing page weights on some plugins
Ricardo Mones [Tue, 9 Jun 2015 07:43:35 +0000 (09:43 +0200)]
Libravatar: use accessor for common preferences
Fixes crash on Windows when loading preferences page.
Original patch thanks to Ticho:
http://git.claws-mail.org/?p=claws-win32-installer.git;a=commitdiff;h=
956cf9f8
Andrej Kacian [Sat, 6 Jun 2015 16:24:49 +0000 (18:24 +0200)]
Add a missing include to make commit
f061b67 work on Win32.
Ricardo Mones [Sat, 6 Jun 2015 11:52:23 +0000 (13:52 +0200)]
Fix low probability resource leak
Ricardo Mones [Sat, 6 Jun 2015 01:09:31 +0000 (03:09 +0200)]
And other format warning less
• imap.c:4832:8: warning: format ‘%d’ expects argument of type ‘int’,
but argument 9 has type ‘time_t’ [-Wformat=]
Ricardo Mones [Sat, 6 Jun 2015 00:54:36 +0000 (02:54 +0200)]
Fix a couple of format warnings
• utils.c:5569:3: warning: format '%d' expects argument of type 'int',
but argument 4 has type 'size_t' [-Wformat=]
• utils.c:5569:3: warning: format '%d' expects argument of type 'int',
but argument 5 has type 'gsize' [-Wformat=]
Ricardo Mones [Fri, 5 Jun 2015 17:12:02 +0000 (19:12 +0200)]
Document more accurately --debug option on Windows
Also add specific log file location, update copyright year
and manpage date, and fix all those unescaped hyphens.
Andrej Kacian [Fri, 5 Jun 2015 11:33:32 +0000 (13:33 +0200)]
Use 'GStatBuf' instead of 'struct stat' type where possible.
Andrej Kacian [Thu, 4 Jun 2015 16:33:11 +0000 (18:33 +0200)]
Re-add old method for Expat library detection during configure.
Pkg-config can only find expat from 2.1.0 onwards, but earlier
expat did not install a .pc file for it, so we need to also
check outside of pkg-config.
Andrej Kacian [Sat, 23 May 2015 18:56:35 +0000 (20:56 +0200)]
RSSyl: Reworked item comparing logic, partly based on bug #3429.
Andrej Kacian [Wed, 3 Jun 2015 17:59:06 +0000 (19:59 +0200)]
Pass --export-* flags correctly to the linker, depending on platform.
Andrej Kacian [Sat, 30 May 2015 21:32:17 +0000 (23:32 +0200)]
Use pkg-config to detect Expat library.
Andrej Kacian [Sat, 30 May 2015 17:45:32 +0000 (19:45 +0200)]
RSSyl: Use procheader_date_parse() for RFC3339 date strings.
This allows us to remove the parseISO8601Date() function, and
therefore use of strptime(), which does not exist on all platforms.
Andrej Kacian [Sat, 30 May 2015 17:40:51 +0000 (19:40 +0200)]
Rewrote parsing of RFC3339 datetime strings.
This rewrite supports all allowed separators between date
and time: both uppercase and lowercase 'T', as well as space.
Only thing not yet supported is 'Z' instead of time zone offset,
I will hopefully add that later.
Andrej Kacian [Sat, 30 May 2015 16:33:19 +0000 (18:33 +0200)]
RSSyl: Updated list of symbols needed from claws-mail core.
Needed for building for Windows.
Andrej Kacian [Sat, 30 May 2015 16:32:35 +0000 (18:32 +0200)]
RSSyl: struct dirent doesn't have d_type member on Windows.
Andrej Kacian [Sat, 30 May 2015 16:31:26 +0000 (18:31 +0200)]
RSSyl: Remove unnecessary use of link() in rssyl_add_msgs().
Andrej Kacian [Sat, 30 May 2015 15:36:34 +0000 (17:36 +0200)]
Fix typo in variable name in Windows g_open() implementation.
Ricardo Mones [Thu, 28 May 2015 19:07:30 +0000 (21:07 +0200)]
Fix bug #1941 ‘recursive "mark read all"’
Based on the original patch from Robert David which unfortunately
didn't marked as read the folder currently open on summary view.
Paul [Thu, 28 May 2015 07:56:19 +0000 (08:56 +0100)]
fix last commit
my fault, not a problem with the patch
Paul [Thu, 28 May 2015 07:43:20 +0000 (08:43 +0100)]
Fix LDAP access using TLS protocol
Patch by Darko Koruga.
Andrej Kacian [Wed, 27 May 2015 20:58:27 +0000 (22:58 +0200)]
RSSyl: Fix compilation on OS X.
The enums declared in libfeed's parser*.h files sneaked through
to object built from old_feeds.c file, due to parser.h include.
For some reason, this bothers OS X compiler.
Since these enums were only used in their respective parser*.c file,
I just moved them there.
Andrej Kacian [Thu, 21 May 2015 21:32:00 +0000 (23:32 +0200)]
RSSyl: Leave unread flag on new items regardless of silent_update setting.
Closes bug #2601
Ricardo Mones [Mon, 18 May 2015 19:44:50 +0000 (21:44 +0200)]
Almost switch plugins from strerror to g_strerror
Refusing to modify spamassassin's libspamc.c code to avoid
diverging (more) from original ASF code. It's a pity they
don't provide a shared library for this, or at least for the
message_read/message_filter functions used by the plugin :)
Ricardo Mones [Mon, 18 May 2015 19:22:37 +0000 (21:22 +0200)]
Switch core from strerror to g_strerror
Andrej Kacian [Sun, 17 May 2015 17:13:17 +0000 (19:13 +0200)]
RSSyl: Strip leading and trailing whitespace from XML tag contents.
Ricardo Mones [Sat, 16 May 2015 10:21:07 +0000 (12:21 +0200)]
Update summary view status after "Find all"
In search messages dialog (Edit/Search folder...) pressing "Find all"
left the summary view status empty regardless of the result.
The status of the resulting selection when matching messages are found
is displayed now. If no message is matched it remains empty as before.
Andrej Kacian [Wed, 6 May 2015 22:19:03 +0000 (00:19 +0200)]
RSSyl: use procheader_date_parse() instead of parseRFC822Date().
Ricardo Mones [Mon, 4 May 2015 01:07:50 +0000 (03:07 +0200)]
Fix GLib-GObject-CRITICAL message when printing
Message was: “g_object_ref: assertion 'G_IS_OBJECT (object)' failed”
Ricardo Mones [Wed, 29 Apr 2015 18:28:29 +0000 (20:28 +0200)]
Fix bug #2981 and other two implicit...
...declaration warnings I probably introduced in previous commits:
• notification_prefs.c:1285:2: warning: implicit declaration of function
'filesel_select_file_open' [-Wimplicit-function-declaration]
• rssyl_prefs.c:110:2: warning: implicit declaration of function
'filesel_select_file_open' [-Wimplicit-function-declaration]
• icalderivedproperty.c:374:4: warning: implicit declaration of function
'icalproperty_add_parameters' [-Wimplicit-function-declaration]
;-)
Ricardo Mones [Sat, 25 Apr 2015 18:26:36 +0000 (20:26 +0200)]
Fix 'make dist' for Managesieve plugin
make[5]: Entering directory '/home/mones/hydra/claws-dev/src/plugins/managesieve'
make[5]: *** No rule to make target 'sieve_plugin.h', needed by 'distdir'. Stop.
Ricardo Mones [Sat, 25 Apr 2015 18:26:05 +0000 (20:26 +0200)]
Add author of Managesieve plugin also to About dialog
Andrej Kacian [Sat, 25 Apr 2015 11:29:51 +0000 (13:29 +0200)]
Update AUTHORS and README regarding the Managesieve plugin.
Charles Lehner [Sun, 23 Nov 2014 03:32:35 +0000 (22:32 -0500)]
Add ManageSieve plugin
Charles Lehner [Sun, 16 Nov 2014 22:14:14 +0000 (17:14 -0500)]
Make message_search interface-based
- Factor out compose/messageview checking.
- Make general so other code can use it
Charles Lehner [Sun, 23 Nov 2014 01:44:25 +0000 (20:44 -0500)]
Add callback for session connection result
Ricardo Mones [Sat, 25 Apr 2015 10:51:42 +0000 (12:51 +0200)]
Reuse PLUGINS_URI #define
Ricardo Mones [Wed, 22 Apr 2015 17:58:21 +0000 (19:58 +0200)]
Fix bug #3419 ‘Saving/appending messages to an mbox file violates RFC#4155’
RFC4155 is informative, anyway, this makes message separator headers
conform to qmail mboxrd format: http://qmail.org./man/man5/mbox.html
Original patch thanks to Johan Vromans.
Andrej Kacian [Wed, 22 Apr 2015 16:31:46 +0000 (18:31 +0200)]
Compose window: Fix bug #3421 - Recipients list doesn't scroll when moving with arrow keys.
Ricardo Mones [Tue, 7 Apr 2015 19:56:08 +0000 (21:56 +0200)]
Adjust templates panel of folder properties
Andrej Kacian [Sun, 22 Mar 2015 10:58:50 +0000 (11:58 +0100)]
In mailbox order dialog, set selection mode after the list has been
populated, so that when the first row gets selected by default,
the triggered set_selected() function can correctly set sensitivity
on up/down buttons.
Andrej Kacian [Sun, 22 Mar 2015 10:45:42 +0000 (11:45 +0100)]
Allow single-click to select mailboxes in the mailbox order dialog.
Andrej Kacian [Sat, 21 Mar 2015 17:00:53 +0000 (18:00 +0100)]
Removed unused MBOX_CACHE_DIR from defs.h.
Paul [Sat, 21 Mar 2015 11:19:40 +0000 (11:19 +0000)]
fix bug 3407, 'Pressing the "Date" column header to "sort by date" causes all columns to have a sort arrow.'
It was only apparent when sorting by thread date, not sorting by date.
Holger Berndt [Sun, 15 Mar 2015 20:24:29 +0000 (21:24 +0100)]
Python plugin: Silence parasite glib warnings
Holger Berndt [Sun, 15 Mar 2015 19:55:59 +0000 (20:55 +0100)]
Notification plugin: Remove spurious warning
Holger Berndt [Sun, 15 Mar 2015 18:20:05 +0000 (19:20 +0100)]
GData plugin: Harden against missing fields
Andrej Kacian [Sun, 15 Mar 2015 15:45:20 +0000 (16:45 +0100)]
Change "OpenSSL support" to "TLS support" in a dialog message.
Ricardo Mones [Sat, 7 Mar 2015 00:52:23 +0000 (01:52 +0100)]
Do not link main binary to GPGME libraries
Fixes half of <https://bugs.debian.org/779824>; the other half
was fixed in commit
22e05b492f09ed1d20cd48e1917d1dead0fc248e.
Paul [Thu, 5 Mar 2015 09:09:38 +0000 (09:09 +0000)]
for Python 2.x set encoding to UTF-8
also:
don't mix tabs and spaces (replace tabs)
a syntax fix
several typo fixes
Patch by Daniel Zaoui
Paul [Thu, 5 Mar 2015 08:55:10 +0000 (08:55 +0000)]
fix bug 1769, ' vCalendar timezone glitches'
Patch by Darko Koruga
Ricardo Mones [Wed, 25 Feb 2015 12:50:16 +0000 (13:50 +0100)]
Sync Spanish manual translation
Ricardo Mones [Wed, 25 Feb 2015 12:49:00 +0000 (13:49 +0100)]
Fix bug #3389 ‘document 'F12' shortcut’
Ricardo Mones [Thu, 19 Feb 2015 23:46:31 +0000 (00:46 +0100)]
Fetchinfo: slightly improve prefs, add hints
Ricardo Mones [Thu, 19 Feb 2015 00:19:01 +0000 (01:19 +0100)]
Fix widget spacing in toolbar preferences pages
Ricardo Mones [Wed, 11 Feb 2015 00:08:54 +0000 (01:08 +0100)]
Notification plugin: standardise preferences
Make notification preferences look more like the rest of application:
• Browse button for file selections
• Remove colons from labels
• Label with unit(s) after spinners where appropriate
• Use hints for special values
• Use frames to group related widgets
• Package widgets without tables and use existing macros
Michael Rasmussen [Thu, 5 Feb 2015 00:21:31 +0000 (01:21 +0100)]
Fix bug #3380. Initialize widget before callback handler for 'clicked'
Ricardo Mones [Thu, 29 Jan 2015 20:33:33 +0000 (21:33 +0100)]
Fix bug #3363 “preferences page composition seems weird”
Ricardo Mones [Thu, 29 Jan 2015 01:04:12 +0000 (02:04 +0100)]
Fancy: improve readability and standardise labels
Ricardo Mones [Mon, 26 Jan 2015 23:47:21 +0000 (00:47 +0100)]
Libravatar: more compact prefs, add hint to entry
Paul [Mon, 26 Jan 2015 05:03:29 +0000 (05:03 +0000)]
Mac-Cyrillic menu updates. patch by Anton Butanaev
Ricardo Mones [Sun, 25 Jan 2015 19:03:35 +0000 (20:03 +0100)]
AddressKeeper: improve preferences panel
Ricardo Mones [Thu, 22 Jan 2015 23:54:12 +0000 (00:54 +0100)]
AttachWarner: rearrange checkbox, standardise labels
Ricardo Mones [Sat, 17 Jan 2015 16:31:24 +0000 (17:31 +0100)]
Remove GTK+ checks lower than required version
INSTALL file says 2.16 is required since some time ago, hence
removing these remnants from the glorious days of GTK+2 :)
Paul [Mon, 19 Jan 2015 09:21:52 +0000 (09:21 +0000)]
add support for x-mac-cyrillic encoding.
patch by Anton Butanaev.
Colin Leroy [Wed, 14 Jan 2015 15:46:21 +0000 (16:46 +0100)]
Fix bug #3364, segfault in src/wizard.c: add missing return
Fix bug #3365, segfault in src/prefs_account.c: add missing return
Ricardo Mones [Sat, 15 Nov 2014 11:39:18 +0000 (12:39 +0100)]
Fix bug# 3098: add auth to context and handle error
Ricardo Mones [Sat, 15 Nov 2014 11:38:18 +0000 (12:38 +0100)]
RSSyl: preferences for HTTP auth basic
Ricardo Mones [Sat, 15 Nov 2014 11:30:14 +0000 (12:30 +0100)]
RSSyl: support HTTP basic auth in libfeed
Andrej Kacian [Sat, 3 Jan 2015 02:42:30 +0000 (03:42 +0100)]
Add support for SCRAM-SHA-1 authentication mechanism (via libetpan) to IMAP.
Andrej Kacian [Thu, 8 Jan 2015 21:51:04 +0000 (22:51 +0100)]
RSSyl: Day-of-week name in RFC822 timestamps is optional.
Ricardo Mones [Mon, 5 Jan 2015 09:55:52 +0000 (10:55 +0100)]
Fix bug #1797 “quicksearch could also search the Cc field”
Updated patch by Barry Warsaw <barry@python.org>, thanks!
Andrej Kacian [Thu, 1 Jan 2015 22:36:36 +0000 (23:36 +0100)]
RSSyl: Fix handling of feeds with encodings unknown to expat. Turns out the only thing missing was that HAVE_ICONV macro (from config.h) was not defined in parser.c, so our "unknown encoding" expat handler function did nothing. Fixes bug #3339.
Andrej Kacian [Mon, 22 Dec 2014 18:42:55 +0000 (19:42 +0100)]
Use AC_CHECK_LIB instead of AC_SEARCH_LIBS, to prevent adding -larchive to global LIBS variable. This gets rid of superfluous dynamic link against libarchive in all built executables (claws-mail and plugins).
Colin Leroy [Fri, 19 Dec 2014 15:26:37 +0000 (16:26 +0100)]
Fix bug #3354, "Event cancellation uses incorrect method parameter for Content-Type header"
Colin Leroy [Fri, 19 Dec 2014 15:23:00 +0000 (16:23 +0100)]
Better fix for bug #3349 (almost all the needed code was there :-)
Colin Leroy [Thu, 18 Dec 2014 09:18:48 +0000 (10:18 +0100)]
Merge remote-tracking branch 'jakub-kicinski/for-master'