claws.git
16 months agoMailmbox: fix buffer size
Ricardo Mones [Wed, 25 Jul 2018 17:34:03 +0000 (19:34 +0200)]
Mailmbox: fix buffer size

Should fix the following warnings reported on ML¹:

mailmbox.c: In function ‘claws_mailmbox_expunge_no_lock.part.4’:
mailmbox.c:1260:34: warning: ‘XXXXXX’ directive output may be truncated
writing 6 bytes into a region of size between 1 and 4096
[-Wformat-truncation=]
   snprintf(tmpfile, PATH_MAX, "%sXXXXXX", folder->mb_filename);
                                  ^~~~~~
mailmbox.c:1260:3: note: ‘snprintf’ output between 7 and 4102 bytes into
a destination of size 4096
   snprintf(tmpfile, PATH_MAX, "%sXXXXXX", folder->mb_filename);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

¹ https://lists.claws-mail.org/pipermail/users/2018-July/022270.html

16 months agoWhen switching to/from offline mode, reset override timers.
Andrej Kacian [Sun, 15 Jul 2018 17:35:06 +0000 (19:35 +0200)]
When switching to/from offline mode, reset override timers.

Closes bug #4056: Impossible to disable overriding of offline mode

16 months agoFixed a small memory leak in advsearch_expand_search_string().
Andrej Kacian [Sun, 22 Jul 2018 19:28:32 +0000 (21:28 +0200)]
Fixed a small memory leak in advsearch_expand_search_string().

16 months agoFix auth retry in Managesieve - wrong state variable was being set.
Andrej Kacian [Sun, 22 Jul 2018 19:07:46 +0000 (21:07 +0200)]
Fix auth retry in Managesieve - wrong state variable was being set.

16 months agoRemoved a few obsolete and unused functions.
Andrej Kacian [Sun, 22 Jul 2018 19:06:26 +0000 (21:06 +0200)]
Removed a few obsolete and unused functions.

16 months agoWhen deleting an account, cancel its autocheck timer.
Andrej Kacian [Sun, 22 Jul 2018 16:55:18 +0000 (18:55 +0200)]
When deleting an account, cancel its autocheck timer.

16 months agofix bug 4058, '# in extended search description window should not be translated'
Paul [Fri, 20 Jul 2018 07:26:57 +0000 (08:26 +0100)]
fix bug 4058, '# in extended search description window should not be translated'

16 months agoRSSyl: do not look at modified time when matching deleted items
Andrej Kacian [Tue, 17 Jul 2018 17:21:36 +0000 (19:21 +0200)]
RSSyl: do not look at modified time when matching deleted items

16 months agoRSSyl: Re-add a mistakenly deleted #include.
Andrej Kacian [Mon, 16 Jul 2018 20:20:22 +0000 (22:20 +0200)]
RSSyl: Re-add a mistakenly deleted #include.

16 months agoRemove unneeded debug_print lines.
Andrej Kacian [Sun, 15 Jul 2018 21:43:45 +0000 (23:43 +0200)]
Remove unneeded debug_print lines.

16 months agoSave the account custom signing key ID even if other option than custom is selected.
Andrej Kacian [Sun, 15 Jul 2018 21:42:01 +0000 (23:42 +0200)]
Save the account custom signing key ID even if other option than custom is selected.

16 months agoRSSyl: add more missing checks for offline mode
Andrej Kacian [Sun, 15 Jul 2018 08:25:42 +0000 (10:25 +0200)]
RSSyl: add more missing checks for offline mode

Closes bug #4014 - "Work offline" doesn't seem to affect RSS

16 months agoRSSyl: rework matching deleted items to better handle feeds without id
Andrej Kacian [Sat, 14 Jul 2018 22:31:18 +0000 (00:31 +0200)]
RSSyl: rework matching deleted items to better handle feeds without id

Fixes bug #3971 again.

16 months agoAllow separate autocheck configuration for accounts.
Andrej Kacian [Sun, 17 Jun 2018 13:10:50 +0000 (15:10 +0200)]
Allow separate autocheck configuration for accounts.

Accounts can have their own autocheck intervals, or follow
global interval.

This separates the autocheck configuration from 'Get all'.
config_version is bumped to 3, because meaning of
"receive_at_get_all" in account configuration has changed.

Closes bug #2552: in automatic checking, enable the use of
different time intervals
Closes bug #2837: Detach automatic email checking from 'get all'

16 months agoAdded missing archiver_prefs.h to archive_la_SOURCES.
Andrej Kacian [Fri, 13 Jul 2018 21:27:11 +0000 (23:27 +0200)]
Added missing archiver_prefs.h to archive_la_SOURCES.

16 months agoDo not let plugins install their header files, unless necessary.
Andrej Kacian [Fri, 13 Jul 2018 16:40:40 +0000 (18:40 +0200)]
Do not let plugins install their header files, unless necessary.

The only plugin that needs to do that is pgpcore, as there
could in theory exist an external plugin that depends on it,
and uses symbols from it.

16 months agoFix a condition typo in gtk_cmclist_motion().
Andrej Kacian [Fri, 13 Jul 2018 13:17:58 +0000 (15:17 +0200)]
Fix a condition typo in gtk_cmclist_motion().

17 months agoGet rid of account_list_view_add(), since it was just a useless middleman.
Andrej Kacian [Sun, 8 Jul 2018 14:41:18 +0000 (16:41 +0200)]
Get rid of account_list_view_add(), since it was just a useless middleman.

The logic was pushed down to account_list_store_insert_account_item(),
now we only need to pass PrefsAcount pointer to it.

17 months agoAdd "Show password" checkbox to each Proxy pref page.
Andrej Kacian [Thu, 5 Jul 2018 20:27:44 +0000 (22:27 +0200)]
Add "Show password" checkbox to each Proxy pref page.

17 months agoMore Windows build fixes.
Andrej Kacian [Thu, 5 Jul 2018 07:54:11 +0000 (09:54 +0200)]
More Windows build fixes.

Patch by Abhay S. Kushwaha.

17 months agoCleanup after moving Managesieve passwords to password store.
Andrej Kacian [Sun, 1 Jul 2018 20:07:17 +0000 (22:07 +0200)]
Cleanup after moving Managesieve passwords to password store.

Since the password was moved to password store, there is one
less element in accounts' Managesieve config string. The
"failed reading Sieve config elements" warning should not be
printed if it's just password that's missing.

17 months agoAdded a password store function to check if a password exists.
Andrej Kacian [Sun, 1 Jul 2018 19:56:16 +0000 (21:56 +0200)]
Added a password store function to check if a password exists.

17 months agofix memory leak, and seasoned to suit some tastes
Paul [Fri, 29 Jun 2018 17:06:48 +0000 (18:06 +0100)]
fix memory leak, and seasoned to suit some tastes

17 months agouse TRUE/FALSE instead of 1/0
Paul [Fri, 29 Jun 2018 14:38:33 +0000 (15:38 +0100)]
use TRUE/FALSE instead of 1/0

17 months agowhen a return-receipt request is sent to an unknown addr, make the user choose which...
Paul [Fri, 29 Jun 2018 11:51:24 +0000 (12:51 +0100)]
when a return-receipt request is sent to an unknown addr, make the user choose which acc to send from

17 months agovCalendar: Skip whitespace chars at the beginning of ics stream
Paul [Fri, 29 Jun 2018 11:02:22 +0000 (12:02 +0100)]
vCalendar: Skip whitespace chars at the beginning of ics stream

patch by Avinash Sonawane

17 months agoFix build for Windows, plus some missing symbols in claws.def files.
Andrej Kacian [Tue, 26 Jun 2018 16:21:56 +0000 (18:21 +0200)]
Fix build for Windows, plus some missing symbols in claws.def files.

Patches by Abhay S. Kushwaha.

17 months agoFix some variable type mismatches in ldapsvr_connect() on Windows.
Andrej Kacian [Tue, 26 Jun 2018 16:20:26 +0000 (18:20 +0200)]
Fix some variable type mismatches in ldapsvr_connect() on Windows.

17 months agoGData plugin: Request interactive auth only in case of auth issues
Holger Berndt [Mon, 25 Jun 2018 21:22:26 +0000 (23:22 +0200)]
GData plugin: Request interactive auth only in case of auth issues

At the same time, make (now potentially ignored) errors more visible
in the status bar in the same way as background mail fetching errors
are reported.

Fixes bug #3754
Modified version of the patch by Viacheslav Gagara on that bug report.

17 months agoGData plugin: Only allow one interactive auth session at a time
Holger Berndt [Sun, 24 Jun 2018 14:16:46 +0000 (16:16 +0200)]
GData plugin: Only allow one interactive auth session at a time

17 months agostrip whitespace from subscribed URLs
Paul [Fri, 22 Jun 2018 09:55:02 +0000 (10:55 +0100)]
strip whitespace from subscribed URLs

17 months agofix bug, 'MDN mail-accountname leak'
Paul [Thu, 21 Jun 2018 09:54:11 +0000 (10:54 +0100)]
fix bug, 'MDN mail-accountname leak'

always use whatever is in the To header for the From header when sending
Return Receipts

17 months agoDefault mode URL should be escaped before using it
Ricardo Mones [Tue, 19 Jun 2018 09:12:02 +0000 (11:12 +0200)]
Default mode URL should be escaped before using it

17 months agoFix 'Invalid PrefType for GtkEntry' warning for account proxy_pass.
Andrej Kacian [Sun, 17 Jun 2018 13:19:20 +0000 (15:19 +0200)]
Fix 'Invalid PrefType for GtkEntry' warning for account proxy_pass.

Also remove P_PASSWORD as valid PrefType in prefs_set_data_from_entry().

17 months agoClone also proxy-related prefs in account_clone().
Andrej Kacian [Sun, 17 Jun 2018 11:14:58 +0000 (13:14 +0200)]
Clone also proxy-related prefs in account_clone().

17 months agoInclude Resent-From and Resent-To in Any/All header(s) (in addressbook) matcher rules.
wwp [Tue, 12 Jun 2018 09:27:32 +0000 (11:27 +0200)]
Include Resent-From and Resent-To in Any/All header(s) (in addressbook) matcher rules.

17 months agoClean up and unfold more standard headers (Bcc, Reply-To, Sender,
wwp [Tue, 12 Jun 2018 08:52:12 +0000 (10:52 +0200)]
Clean up and unfold more standard headers (Bcc, Reply-To, Sender,
Resent-From and Resent-To).

17 months agoProperly highlight the whole email address in Resent-From and Resent-To
wwp [Tue, 12 Jun 2018 08:26:38 +0000 (10:26 +0200)]
Properly highlight the whole email address in Resent-From and Resent-To
headers.

17 months agoFix a possible memory leak
Michael Rasmussen [Mon, 11 Jun 2018 20:46:32 +0000 (22:46 +0200)]
Fix a possible memory leak

Signed-off-by: Michael Rasmussen <mir@datanom.net>
17 months agoFix memory corruption introduced in d28d62772.
Andrej Kacian [Mon, 11 Jun 2018 19:17:07 +0000 (21:17 +0200)]
Fix memory corruption introduced in d28d62772.

17 months agoReduce scope of few variables.
wwp [Mon, 11 Jun 2018 17:12:20 +0000 (19:12 +0200)]
Reduce scope of few variables.

18 months agoUpdate copyright in file headers.
wwp [Mon, 11 Jun 2018 11:36:12 +0000 (13:36 +0200)]
Update copyright in file headers.
Make use of GLib API for few file operations.

18 months agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Mon, 11 Jun 2018 11:18:34 +0000 (13:18 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

18 months agoFix CID#1436912: Dereferencing null pointer "msginfo->folder"
Ricardo Mones [Mon, 11 Jun 2018 10:31:29 +0000 (12:31 +0200)]
Fix CID#1436912: Dereferencing null pointer "msginfo->folder"

18 months agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Mon, 11 Jun 2018 09:21:09 +0000 (11:21 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

18 months agotwo small fixes to text in label and tooltip
Paul [Mon, 11 Jun 2018 09:17:31 +0000 (10:17 +0100)]
two small fixes to text in label and tooltip

18 months agomove 'Proxy' page from Other/ to Mail Handling/
Paul [Mon, 11 Jun 2018 09:16:54 +0000 (10:16 +0100)]
move 'Proxy' page from Other/ to Mail Handling/

18 months agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Mon, 11 Jun 2018 09:03:29 +0000 (11:03 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

18 months agoCorrected copyright header in proxy.[ch]
Andrej Kacian [Mon, 11 Jun 2018 08:46:11 +0000 (10:46 +0200)]
Corrected copyright header in proxy.[ch]

18 months agoRemove un-necessary test, msginfo can't be null here, solves CID#1436912.
wwp [Mon, 11 Jun 2018 08:02:37 +0000 (10:02 +0200)]
Remove un-necessary test, msginfo can't be null here, solves CID#1436912.

18 months agoFix use of uninitialized pointer, CID#1436911.
wwp [Mon, 11 Jun 2018 07:32:50 +0000 (09:32 +0200)]
Fix use of uninitialized pointer, CID#1436911.

18 months agoFixed an off-by-one buffer overflow in proxy.c.
Andrej Kacian [Sun, 10 Jun 2018 21:09:18 +0000 (23:09 +0200)]
Fixed an off-by-one buffer overflow in proxy.c.

18 months agoFix up POTFILES.in to match previous commit (d28d62772).
Andrej Kacian [Sun, 10 Jun 2018 13:15:49 +0000 (15:15 +0200)]
Fix up POTFILES.in to match previous commit (d28d62772).

18 months agoAdded SOCKS proxy support.
Andrej Kacian [Fri, 18 May 2018 18:27:52 +0000 (20:27 +0200)]
Added SOCKS proxy support.

Based on UI and network code from LibSylph/Sylpheed, rewritten
to use getaddrinfo(), fixed some small bugs in handling errors.

Added connect wrappers for etpan IMAP and NNTP, as well as for
anything Session-based (POP3, SMTP, Managesieve).

Adds support for global, as well as per-account proxy servers.

Original patch by Charles Lehner <cel at celehner com>, from
bug #2244.

18 months agowhen changing sort_key by clicking column header, preserve sort_type
Paul [Sun, 10 Jun 2018 10:23:51 +0000 (11:23 +0100)]
when changing sort_key by clicking column header, preserve sort_type

18 months agoFix a buffer overflow in password encryption, and allow arbitrary password length.
Andrej Kacian [Sat, 9 Jun 2018 22:38:42 +0000 (00:38 +0200)]
Fix a buffer overflow in password encryption, and allow arbitrary password length.

Fixes bug #4033 - Claws Mail crashes [malloc(): memory
corruption] while trying to save account password greater
than 136 chars

18 months agofix bug where 'sort_type' is lost when changing 'sort_key' from /View/sort
Paul [Sat, 9 Jun 2018 11:12:32 +0000 (12:12 +0100)]
fix bug where 'sort_type' is lost when changing 'sort_key' from /View/sort

the bug was apparent with a descending sort. changing the sort_key
always set it to ascending

18 months agoMake use of all signature separators defined in accounts instead
wwp [Thu, 7 Jun 2018 11:06:58 +0000 (13:06 +0200)]
Make use of all signature separators defined in accounts instead
of just the hardcoded standard one we use.

18 months agoHonor quote_chars from prefs instead of hard-coding "> ".
wwp [Wed, 6 Jun 2018 19:16:21 +0000 (21:16 +0200)]
Honor quote_chars from prefs instead of hard-coding "> ".

18 months agoFix HTML <hX> header handling.
Andrej Kacian [Fri, 1 Jun 2018 06:01:05 +0000 (08:01 +0200)]
Fix HTML <hX> header handling.

Fix one-by-off error in detection of the end tag,
and add an extra newline at the beginning to make
the heading stand out visually.

18 months agoCode cleanup around glib version check (2.28 minimum).
wwp [Mon, 28 May 2018 15:44:59 +0000 (17:44 +0200)]
Code cleanup around glib version check (2.28 minimum).

18 months agoDynamically allocate interface_vtable.
wwp [Mon, 28 May 2018 15:17:05 +0000 (17:17 +0200)]
Dynamically allocate interface_vtable.

18 months agoProperly initialize GDBusInterfaceVTable's private member 'padding' (void*[8]).
wwp [Mon, 28 May 2018 14:45:47 +0000 (16:45 +0200)]
Properly initialize GDBusInterfaceVTable's private member 'padding' (void*[8]).

18 months agoFix warning: missing braces around initializer
Ricardo Mones [Mon, 28 May 2018 12:04:32 +0000 (14:04 +0200)]
Fix warning: missing braces around initializer

18 months agoFix warning: excess elements in struct initializer
Ricardo Mones [Mon, 28 May 2018 12:03:57 +0000 (14:03 +0200)]
Fix warning: excess elements in struct initializer

18 months agofix gcc8 stringop-overflow warning
Paul [Sat, 26 May 2018 10:48:08 +0000 (11:48 +0100)]
fix gcc8 stringop-overflow warning

18 months agofix bug #4023, 'Fix some small issues'
Paul [Sat, 26 May 2018 10:21:19 +0000 (11:21 +0100)]
fix bug #4023, 'Fix some small issues'

* src/common/plugin.c: Remove redundant 'const' qualifier
* src/jpilot.c: Remove redundant parentheses
* src/mbox.c: Likewise
* src/procmsg.c: Use fabs instead of abs for 'double' arg
* src/ textview.c: Declare 'shortcut' only if not GENERIC_UMPC
* src/toolbar.c: Declare 'toolbar_reply_menu_cb()' and
'toolbar_delete_dup_menu_cb' only if not GENERIC_UMPC

Patch by Avinash Sonawane

18 months agoUpdates to the French translation.
wwp [Fri, 25 May 2018 17:01:50 +0000 (19:01 +0200)]
Updates to the French translation.

18 months agoFix missing initializers, taking for reference GLib 2.28 (with support
wwp [Fri, 25 May 2018 07:55:34 +0000 (09:55 +0200)]
Fix missing initializers, taking for reference GLib 2.28 (with support
for up to 2.56) and Python 2.4 (with support for up to 3.6).

18 months agoFix previous commit.
wwp [Thu, 24 May 2018 15:44:38 +0000 (17:44 +0200)]
Fix previous commit.

18 months agoSince we depend on GLib 2.28, make real use of GList/GSList's _free_full
wwp [Thu, 24 May 2018 15:39:03 +0000 (17:39 +0200)]
Since we depend on GLib 2.28, make real use of GList/GSList's _free_full
functions. Remove unused list freeing functions.

18 months agoRevert again support for gdata 0.6.4.
wwp [Thu, 24 May 2018 10:24:05 +0000 (12:24 +0200)]
Revert again support for gdata 0.6.4.

18 months agoupdate UI copyright year
Paul [Wed, 23 May 2018 17:28:55 +0000 (18:28 +0100)]
update UI copyright year

18 months agofix quoting in reply to format=flowed message
Paul [Wed, 23 May 2018 17:10:46 +0000 (18:10 +0100)]
fix quoting in reply to format=flowed message

18 months agoClaws Mail does support gdata 0.6.4.
wwp [Wed, 23 May 2018 06:01:14 +0000 (08:01 +0200)]
Claws Mail does support gdata 0.6.4.

18 months agoUpdate app name in header cartouche and other places, correct
wwp [Tue, 22 May 2018 21:05:29 +0000 (23:05 +0200)]
Update app name in header cartouche and other places, correct
copyrights. Base patch by Abhay S. Kushwaha, with few additions
and slight changes.

18 months agoFix more unchecked return values reported by Coverity:
wwp [Tue, 22 May 2018 17:30:08 +0000 (19:30 +0200)]
Fix more unchecked return values reported by Coverity:
143428214342831434284

18 months agoFix few unchecked return values reported by Coverity:
wwp [Tue, 22 May 2018 17:12:36 +0000 (19:12 +0200)]
Fix few unchecked return values reported by Coverity:
1434187143418914341921434193143419514341961434198143420014342021434203
And few more. Change few silent returns into debug ones (cm_return_if_fail).

18 months agofix syntax error in man page
Paul [Tue, 22 May 2018 10:21:58 +0000 (11:21 +0100)]
fix syntax error in man page

List syntax error. This means .IP, .TP or .RS/.RE markup is garbled.
Common causes include .TP just before a section header, .TP entries
with tags but no bodies, and mandoc lists with no trailing .El.
These confuse doclifter, and may also mess up stricter man-page
browsers like Xman and Rosetta.

Patch by Eric S. Raymond

18 months agoRemove another colon
Ricardo Mones [Wed, 16 May 2018 22:19:24 +0000 (00:19 +0200)]
Remove another colon

18 months agoUpdate lists of contributors
Ricardo Mones [Wed, 16 May 2018 22:15:37 +0000 (00:15 +0200)]
Update lists of contributors

18 months agoFix bug 3895: Port from libnm-util/libnm-glib to libnm
Michael Schwendt [Tue, 13 Mar 2018 20:03:46 +0000 (21:03 +0100)]
Fix bug 3895: Port from libnm-util/libnm-glib to libnm

18 months agowhen using hide_timezone, convert time to UTC
Paul [Wed, 16 May 2018 14:31:03 +0000 (15:31 +0100)]
when using hide_timezone, convert time to UTC

18 months agoforce explicit use of --disable-gnutls if gnutls support is not required
Paul [Tue, 15 May 2018 10:40:52 +0000 (11:40 +0100)]
force explicit use of --disable-gnutls if gnutls support is not required

18 months agorequire nettle, following removal of libcrypt from glibc
Paul [Tue, 15 May 2018 08:59:20 +0000 (09:59 +0100)]
require nettle, following removal of libcrypt from glibc

based on the fedora patch, thanks!

19 months agoRevert last leak fix.
wwp [Wed, 9 May 2018 07:47:02 +0000 (09:47 +0200)]
Revert last leak fix.

19 months agoFix a leak.
wwp [Wed, 9 May 2018 06:50:26 +0000 (08:50 +0200)]
Fix a leak.

19 months agoFix crash in quicksearch keypress handling.
Andrej Kacian [Tue, 8 May 2018 14:54:53 +0000 (16:54 +0200)]
Fix crash in quicksearch keypress handling.

The fourth argument to g_signal_emit_by_name() in this case
is not the signal user data, but a pointer where to store the
return value.

19 months agoForce initialization of buffer (fixes a valgrind case where buf is
wwp [Tue, 8 May 2018 06:54:16 +0000 (08:54 +0200)]
Force initialization of buffer (fixes a valgrind case where buf is
used uninitialized).

19 months agoFix a memory leak in quicksearch code.
wwp [Mon, 7 May 2018 17:00:50 +0000 (19:00 +0200)]
Fix a memory leak in quicksearch code.

19 months agoFix wrong type for layout_mode var in struct.
wwp [Mon, 7 May 2018 11:11:26 +0000 (13:11 +0200)]
Fix wrong type for layout_mode var in struct.

19 months agoMake Claws Mail conservative about color labels: ask for confirmation
wwp [Sun, 6 May 2018 14:02:43 +0000 (16:02 +0200)]
Make Claws Mail conservative about color labels: ask for confirmation
when user clears or override existing color labels to messages.
Confirmation dialog is discardable.

19 months agoUpdate French translation.
wwp [Sun, 6 May 2018 13:48:39 +0000 (15:48 +0200)]
Update French translation.

19 months agoFix warning: ‘struct sockaddr’ declared inside…
Ricardo Mones [Sun, 6 May 2018 09:37:44 +0000 (11:37 +0200)]
Fix warning: ‘struct sockaddr’ declared inside…

By including our utils.h instead of spamassassin homonymous file.

In file included from ../../../src/procmsg.h:32:0,
                 from spamassassin.c:42:
./utils.h:124:47: warning: ‘struct sockaddr’ declared inside parameter list will not be visible outside of this definition or declaration
 int timeout_connect (int sockfd, const struct sockaddr *serv_addr, size_t addrlen);
                                               ^~~~~~~~

19 months agoSave and reuse Actions input/output dialog size.
wwp [Sat, 5 May 2018 21:56:13 +0000 (23:56 +0200)]
Save and reuse Actions input/output dialog size.

19 months agoFix a couple of unused variable warnings
Ricardo Mones [Sat, 5 May 2018 19:59:55 +0000 (21:59 +0200)]
Fix a couple of unused variable warnings

- libspamc.c:491:19: warning: variable ‘family’ set but not used
  (used in a #ifdef block, fix by surrounding by same #ifdef)
- libspamc.c:1911:35: warning: unused variable ‘addrp’
  (used in a commented code block, fix by commenting also declaration)

19 months agoReally ask for confirmation when marking *all* messages as read or
wwp [Sat, 5 May 2018 12:21:53 +0000 (14:21 +0200)]
Really ask for confirmation when marking *all* messages as read or
unread from the message list (as it's done from the folder context
menu). This confirmation dialog is still discardable and still
obeys to the option "Confirm before marking all messages in a folder
as read or unread" in preferences.
A bit of code factorization.

19 months agoFix French translation (unexpected accelerator used in dialog title).
wwp [Sat, 5 May 2018 12:08:18 +0000 (14:08 +0200)]
Fix French translation (unexpected accelerator used in dialog title).

19 months agoSave few warnings around mistyped uses of g_list_length().
wwp [Sat, 5 May 2018 11:46:36 +0000 (13:46 +0200)]
Save few warnings around mistyped uses of g_list_length().

19 months agoCorrect the label of the 'confirm before marking all messages in a
wwp [Sat, 5 May 2018 10:54:29 +0000 (12:54 +0200)]
Correct the label of the 'confirm before marking all messages in a
folder as read' option: it's about marking all as read or UNread.