wwp [Wed, 11 Jan 2017 15:09:08 +0000 (16:09 +0100)]
Quit function if no connection instead of assigning variable that
will be overwriten right after.
Fixes Coverity CID #
1372370.
wwp [Wed, 11 Jan 2017 10:03:56 +0000 (11:03 +0100)]
Rework icon antialiasing to look OK on dark and light themes.
wwp [Wed, 11 Jan 2017 00:56:22 +0000 (01:56 +0100)]
POPPLER_ACTION_MOVIE was not introduced w/ Poppler 0.14.0, but in
a version so old that even my grandma was using it (0.3.0 in fact).
wwp [Wed, 11 Jan 2017 00:31:05 +0000 (01:31 +0100)]
Rework icon antialiasing to look OK on dark and light themes.
wwp [Tue, 10 Jan 2017 15:19:29 +0000 (16:19 +0100)]
Don't #undefine UNIX_PATH_MAX, move #define's up.
wwp [Tue, 10 Jan 2017 14:58:05 +0000 (15:58 +0100)]
Be more clear about what 108 means here towards the Unix socket
path value lenght: rely on UNIX_PATH_MAX and fallback to its common
value '108' in not defined in un.h (caution, on other systems, it could
be 104, etc. down to 92).
wwp [Tue, 10 Jan 2017 13:51:09 +0000 (14:51 +0100)]
Fail if attempting to create a UNIX socket w/ path len >108c.
Add few checks more for socket operations, and reduce few duplicate
initializations.
Saves us warnings and sikves Civerity #
1372360.
wwp [Tue, 10 Jan 2017 09:10:05 +0000 (10:10 +0100)]
Fix Coverity CIDs:
1220259 1364687 (and discarded
1220496) and added more checks for returned
values.
wwp [Tue, 10 Jan 2017 08:59:52 +0000 (09:59 +0100)]
Fix Coverity CIDs:
1220274 and
1220377.
wwp [Tue, 10 Jan 2017 08:36:31 +0000 (09:36 +0100)]
Real fix for Coverity
1372362.
wwp [Tue, 10 Jan 2017 08:31:34 +0000 (09:31 +0100)]
Don't behave as if avail_d was not hardcoded, it is hardcoded
to 7, and do it properly.
Saves us a warning and solves Coverity #
1372366.
wwp [Tue, 10 Jan 2017 08:26:08 +0000 (09:26 +0100)]
Better fix for Coverity #
1220388, use effective indexes and boundaries.
Paul [Mon, 9 Jan 2017 11:37:25 +0000 (11:37 +0000)]
fix typo
wwp [Mon, 9 Jan 2017 10:37:18 +0000 (11:37 +0100)]
Ricardo Mones [Sun, 8 Jan 2017 23:37:04 +0000 (00:37 +0100)]
Attachwarner: fix leaked string
wwp [Fri, 6 Jan 2017 23:46:20 +0000 (00:46 +0100)]
Fix a leak.
wwp [Thu, 5 Jan 2017 17:39:21 +0000 (18:39 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Thu, 5 Jan 2017 17:36:43 +0000 (18:36 +0100)]
Rework antialiasing a bit around toolbar and logo icons, in order
to better fit dark background themes (but still be fine w/ light ones).
wwp [Thu, 5 Jan 2017 09:56:46 +0000 (10:56 +0100)]
Revert parts of 3.14.1-91 (the summary_select_node_no_mard_read func), obviously it's
been accidentally included in that commit and the origin of this modification is still
undetermined.
wwp [Thu, 5 Jan 2017 09:21:50 +0000 (10:21 +0100)]
Fix wrong function definition, declare it before using it, and make it
static.
wwp [Wed, 4 Jan 2017 16:16:09 +0000 (17:16 +0100)]
Fix wrong libarchive version check.
wwp [Wed, 4 Jan 2017 10:32:19 +0000 (11:32 +0100)]
Make the FOO vanish.
wwp [Wed, 4 Jan 2017 10:14:15 +0000 (11:14 +0100)]
Fix marking all as (un)read recursively when the confirmation
dialogue is enabled and the user clicks No: confirmation dialog
was taken into account just for the current folder, subtree was
marked anyway, and this only under certain conditions that I'd
prefer not to list here becau<woosh>
wwp [Wed, 4 Jan 2017 08:13:05 +0000 (09:13 +0100)]
Rename a misnamed function, remove debug statements.
wwp [Tue, 3 Jan 2017 22:36:33 +0000 (23:36 +0100)]
Fix missing array initializers and line everything up.
wwp [Tue, 3 Jan 2017 22:12:02 +0000 (23:12 +0100)]
Fix missing array initializers and line everything up.
wwp [Tue, 3 Jan 2017 21:31:13 +0000 (22:31 +0100)]
Really align array (using whitespaces).
wwp [Tue, 3 Jan 2017 21:20:59 +0000 (22:20 +0100)]
Cosmetic changes: align arrays, remove debug statements.
wwp [Tue, 3 Jan 2017 18:14:10 +0000 (19:14 +0100)]
Archiver plugin update and review:
- updated to support some of the compression formats up to libarchive 3.2.2,
- detect libarchive 2.8+ using pkgconfig,
- use alertpanel API instead of creating gtk dialogs from scratch (with missing
- dialog title, and no clue about what is displayed),
- configure script now makes use of libarchive pkgconfig,
- fixed wrong use of cached page struct info, we do now rely on data set in widgets
to get source folder and target archive filename and sync the page struct info w/ it
when needed,
- renamed gzip/zip to gzip,
- reworked the way archive formats and compression formats lists are displayed (not translatable anymore).
- reformat code a bit.
Holger Berndt [Tue, 3 Jan 2017 10:20:11 +0000 (11:20 +0100)]
GData plugin: Require libgdata at least 0.17.2
Version 0.17.2 is required for auth token save/restore accross restarts.
Without this functionality, the plugin has such bad usability, it's not
worth maintaining. This also fixes the previous compile-error when only
0.17.1 was present.
wwp [Thu, 29 Dec 2016 12:42:46 +0000 (13:42 +0100)]
Fix 'search folder' not working in some cases (it needs a 'clear' click to
work or to manually clear search fields).
Fix provided by Paul, the be(a)st.
Paul [Wed, 28 Dec 2016 12:55:04 +0000 (12:55 +0000)]
make Go to/[Next|Prev] sort order aware
wwp [Tue, 27 Dec 2016 17:06:11 +0000 (18:06 +0100)]
Fix compiler warnings when we test enum-based variables for impossible
<0 values.
wwp [Tue, 27 Dec 2016 17:04:42 +0000 (18:04 +0100)]
Factorize toolbar reset code, and don't compute array sizes using
unsafe calculations.
wwp [Tue, 27 Dec 2016 17:02:55 +0000 (18:02 +0100)]
Fix enum boundaries we check in func_selection_changed (when
changing the internal function assigned to a toolbar item).
Just a theoretical issue here apparently, or we would have had
problems since ages.
wwp [Tue, 27 Dec 2016 16:58:47 +0000 (17:58 +0100)]
More places where printf() and C_() have to be separated.
wwp [Tue, 27 Dec 2016 15:02:27 +0000 (16:02 +0100)]
Line-up arrays (w/ space chars only).
Fix missing array initializers.
wwp [Tue, 27 Dec 2016 14:20:53 +0000 (15:20 +0100)]
Silent up a compiler warning by making the ComposeCallAdvancedAction
enum a real integer-scope ([-1 .. n] instead of [0 .. n]), swallowing
the -1 value check.
wwp [Tue, 27 Dec 2016 14:15:03 +0000 (15:15 +0100)]
Update French translation.
wwp [Tue, 27 Dec 2016 14:11:00 +0000 (15:11 +0100)]
Revert "Revert "Revert g9737584."" (but the fix) by reimplementing
the thing differently: don't mix printf() and C_() as it messes the
compiler up.
Factorize a bit format errors in compose.c.
Make some header names translatable following prefs in the
address keeper plugin.
wwp [Tue, 27 Dec 2016 12:12:22 +0000 (13:12 +0100)]
Fix a leak.
Ricardo Mones [Tue, 27 Dec 2016 12:06:51 +0000 (13:06 +0100)]
Revert "Revert g9737584." and fix it ;)
This reverts commit
834ee304 which was reverting a previous
commit which broke build because of an extra comma. This
reverts the revert and removes the comma.
wwp [Tue, 27 Dec 2016 11:57:37 +0000 (12:57 +0100)]
Revert g9737584.
wwp [Tue, 27 Dec 2016 11:16:56 +0000 (12:16 +0100)]
Add translation context helper text where some %s' are used and
their meaning is not obvious.
Paul [Fri, 23 Dec 2016 11:20:30 +0000 (11:20 +0000)]
removed all useless comments from the end of the po files
wwp [Fri, 23 Dec 2016 10:22:29 +0000 (11:22 +0100)]
Review of the French translation for Xmas:
- huge amount of corrections and changes,
- removed the enormous useless notes chunk.
wwp [Wed, 21 Dec 2016 15:03:15 +0000 (16:03 +0100)]
Update French translation.
wwp [Wed, 21 Dec 2016 15:01:36 +0000 (16:01 +0100)]
Capitalize header names (as everywhere else).
wwp [Wed, 21 Dec 2016 14:52:41 +0000 (15:52 +0100)]
More translatable header names in UI strings.
Ricardo Mones [Wed, 21 Dec 2016 14:12:16 +0000 (15:12 +0100)]
Remove unnecessary commas
They were added by mistake in
f455e02c.
Andrej Kacian [Wed, 21 Dec 2016 12:21:03 +0000 (13:21 +0100)]
Stop left/right keypresses from propagating further in foldersel.
This amends commit
5305715.
Andrej Kacian [Wed, 21 Dec 2016 11:57:47 +0000 (12:57 +0100)]
Moved compose_can_autosave() outside of #ifdef G_OS_UNIX.
wwp [Wed, 21 Dec 2016 09:08:13 +0000 (10:08 +0100)]
Fix wrong string split and list of arguments.
Andrej Kacian [Tue, 20 Dec 2016 22:31:16 +0000 (23:31 +0100)]
Removed an unneeded trailing '\' from Windows' START_TIMING.
Well spotted by Pierre Fortin.
wwp [Tue, 20 Dec 2016 22:01:29 +0000 (23:01 +0100)]
Fix extra arguments to g_strdup_printf (thanks to coverity scan),
add quotes around header names in few dialogs.
wwp [Tue, 20 Dec 2016 10:50:46 +0000 (11:50 +0100)]
Fix untranslatable concatenated strings (i.e. "Default "+"To:"),
normalize few uses of header names in UI.
Andrej Kacian [Mon, 19 Dec 2016 20:30:45 +0000 (21:30 +0100)]
Use left/right keys to collapse/expand rows in foldersel dialog.
Further keypress will move the cursor to parent
or first child, respectively.
Andrej Kacian [Mon, 19 Dec 2016 19:51:21 +0000 (20:51 +0100)]
Allow toplevel folders to be copied.
They are created as regular folders in target mailbox.
Andrej Kacian [Sun, 18 Dec 2016 21:34:44 +0000 (22:34 +0100)]
Do not strip plus sign when drag&drop attaching files.
Closes bug #3742.
Paul [Fri, 16 Dec 2016 10:21:31 +0000 (10:21 +0000)]
fix black on black in From header
wwp [Fri, 16 Dec 2016 08:16:15 +0000 (09:16 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Fri, 16 Dec 2016 08:15:45 +0000 (09:15 +0100)]
Silent up coverity scan.
Ricardo Mones [Thu, 15 Dec 2016 18:57:27 +0000 (19:57 +0100)]
Fix initialization of two pixmaps
wwp [Wed, 14 Dec 2016 10:06:18 +0000 (11:06 +0100)]
Fix possibly broken toolbar_compose.xml by migrating A_SENDL actions names
to A_SEND_LATER. An attempt to rewrite the whole toolbar .xml file was done
when only a part of it was read, leading to toolbar elements loss; the
rewrite of migrated toolbar configs is now done a posteriori.
Also, the renaming/migration magics swallowed the existing one
for A_SYL_ACTIONS.
wwp [Tue, 13 Dec 2016 07:58:23 +0000 (08:58 +0100)]
Updates and hotkey fixes.
wwp [Tue, 13 Dec 2016 07:57:52 +0000 (08:57 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Tue, 13 Dec 2016 07:56:27 +0000 (08:56 +0100)]
Internal API change: split read/unread marking features from functions used
to mark as read/all read using a parameter.
Andrej Kacian [Tue, 13 Dec 2016 00:01:23 +0000 (01:01 +0100)]
Also update authors.h for commit
ea40116.
Andrej Kacian [Mon, 12 Dec 2016 23:57:31 +0000 (00:57 +0100)]
Update AUTHORS file for the previous commit
ea40116.
Andrej Kacian [Mon, 12 Dec 2016 23:55:24 +0000 (00:55 +0100)]
Honor autosave_encrypted preference when using external editor.
Patch by Ashish Gupta <ashmew2@gmail.com>.
wwp [Mon, 12 Dec 2016 18:41:56 +0000 (19:41 +0100)]
Fix table order.
wwp [Mon, 12 Dec 2016 18:28:06 +0000 (19:28 +0100)]
Fix missing items in summaryview's menu declarations.
Paul [Mon, 12 Dec 2016 17:03:23 +0000 (17:03 +0000)]
make list a bit more manageable and remove duplicated items
wwp [Mon, 12 Dec 2016 16:36:05 +0000 (17:36 +0100)]
Fix wrong call to missing *_unread func (we use the *_read() func
w/ FALSE as parameter for that).
Add missing new xpm files to Makefile.am.
wwp [Mon, 12 Dec 2016 14:30:24 +0000 (15:30 +0100)]
Add new actions to main window's toolbar: mark, unmark, lock, unlock,
mark (all) read, mark (all) unread.
Add new xpm icons for these actions (existing ones are small and made
for the message list) as well as for ignorethread and watchthread
actions.
Rename A_SENDL to A_SEND_LATER, we're not that lazy.
wwp [Mon, 12 Dec 2016 14:17:15 +0000 (15:17 +0100)]
Add new mark-all-unread (and recursively when relevant) action to folder
context menu, message list and main window menu.
Paul [Mon, 12 Dec 2016 14:02:28 +0000 (14:02 +0000)]
rename compose_guess_forward_account_from_msginfo() to compose_find_account()
Paul [Mon, 12 Dec 2016 13:58:16 +0000 (13:58 +0000)]
rename compose_entry_mark_default_to() to compose_entry_indicate()
wwp [Mon, 12 Dec 2016 13:24:14 +0000 (14:24 +0100)]
Rename default_to_(bg)color hiddeng pref and variable to default_header_(bg)color.
wwp [Mon, 12 Dec 2016 13:17:43 +0000 (14:17 +0100)]
Fix format, no tabs to align everywhere (at last!).
wwp [Mon, 12 Dec 2016 13:14:37 +0000 (14:14 +0100)]
Remove extra entries, not yet in git.
wwp [Mon, 12 Dec 2016 13:10:04 +0000 (14:10 +0100)]
Fix missing initializers (last field in data struct),
reworked table to a human readable format.
Paul [Mon, 12 Dec 2016 11:39:16 +0000 (11:39 +0000)]
more highlighted of automatically set header entries in Compose window
fix highlighting of multiple addresses set in account prefs
highlight From if not current account
Paul [Mon, 12 Dec 2016 10:17:59 +0000 (10:17 +0000)]
don't remove the To when changing account
Paul [Sun, 11 Dec 2016 17:44:32 +0000 (17:44 +0000)]
some more colouring based on folder prefs override
Paul [Sun, 11 Dec 2016 10:04:30 +0000 (10:04 +0000)]
fix colouring of auto-filled headers
Ricardo Mones [Sat, 10 Dec 2016 12:32:41 +0000 (13:32 +0100)]
Fix bug #3574: Template addressing
Remove artificial limitations to values of email addresses on templates:
these strings are already parsed and split when the template is applied
in compose window.
wwp [Fri, 9 Dec 2016 16:42:46 +0000 (17:42 +0100)]
Make last colors configurable using hidden prefs: tags bg/fg colors in
message view, default-to header field in compose view, and quicksearch
active + error.
wwp [Fri, 9 Dec 2016 15:26:21 +0000 (16:26 +0100)]
Revert "Remove dead code, this changed signal doesn't exist and we've also".
This reverts commit
fe0f832b37541ee1ab7350bc5ab645034d469990.
wwp [Fri, 9 Dec 2016 15:21:29 +0000 (16:21 +0100)]
Remove dead code, this changed signal doesn't exist and we've also
probably removed parts of the highlight-active-account field feature
a while ago.
Ricardo Mones [Tue, 6 Dec 2016 12:17:06 +0000 (13:17 +0100)]
Update authors lists
Ricardo Mones [Tue, 6 Dec 2016 12:07:32 +0000 (13:07 +0100)]
Fix Debian bug #846170: incorrect IMAP UID handling
Patch by Darac Marjal <darac@darac.org.uk>
Andrej Kacian [Fri, 2 Dec 2016 11:48:30 +0000 (12:48 +0100)]
Enable icons of stock GTK buttons on Windows.
Andrej Kacian [Tue, 29 Nov 2016 18:23:14 +0000 (19:23 +0100)]
Fix closing of description window using WM controls.
Closes bug #3740.
Paul [Mon, 28 Nov 2016 12:50:32 +0000 (12:50 +0000)]
on first run, use --alternate-config-dir (if set) on prefs migration
prevents useless creation of ~/.claws-mail directory
Andrej Kacian [Thu, 24 Nov 2016 19:13:10 +0000 (20:13 +0100)]
Fix more compile warnings for Windows in socket.c.
Andrej Kacian [Thu, 24 Nov 2016 19:19:31 +0000 (20:19 +0100)]
Removed unused w32_get_uid_equiv() function.
Andrej Kacian [Thu, 24 Nov 2016 19:05:02 +0000 (20:05 +0100)]
Fix two unused variable warnings in ssl.c for Windows build.
Paul [Wed, 23 Nov 2016 14:06:21 +0000 (14:06 +0000)]
make go to next/previous sort order aware
Paul [Tue, 22 Nov 2016 09:52:06 +0000 (09:52 +0000)]
don't ignore auto-account selection when forwarding on IMAP and NNTP accounts
patch by Blatinox