Andrej Kacian [Sat, 28 Oct 2017 07:33:15 +0000 (09:33 +0200)]
Updated Fancy's claws.def for the Windows build
Andrej Kacian [Wed, 25 Oct 2017 18:40:41 +0000 (20:40 +0200)]
Fix missing invalid regexp indication in folder preferences.
The entry is supposed to turn red, but it couldn't
because of a logic error.
Andrej Kacian [Wed, 25 Oct 2017 18:28:11 +0000 (20:28 +0200)]
Disallow newline character in POP3 account username or password.
The entries will have red background and preferences
will refuse to be saved, with an alertpanel telling why,
if a newline is found in either of the two entries.
This is only checked for POP3 protocol, as other protocols
encode passwords e.g. in base64, and so will not break
the communication to server by sending the extraneous
newline verbatim.
Andrej Kacian [Wed, 25 Oct 2017 18:11:50 +0000 (20:11 +0200)]
Use subst_char() in fancy_set_defaults().
Andrej Kacian [Mon, 23 Oct 2017 16:57:50 +0000 (18:57 +0200)]
More and better leak fixes after commit
9729bf0e0.
Andrej Kacian [Mon, 23 Oct 2017 16:06:27 +0000 (18:06 +0200)]
Fix memory leaks introduced in recent commit
9729bf0e0.
Andrej Kacian [Mon, 23 Oct 2017 14:16:55 +0000 (16:16 +0200)]
Removed two obsolete statuswindow_* aliases.
Andrej Kacian [Mon, 23 Oct 2017 11:49:15 +0000 (13:49 +0200)]
Fetch XOVER and XHDR data in batches of 5000.
This avoids long stalls, which sometimes confuse libetpan.
It also allows implementing some sort of progressbar in UI.
Andrej Kacian [Sun, 22 Oct 2017 15:27:08 +0000 (17:27 +0200)]
Made Fancy's custom stylesheet pref work on Windows
Andrej Kacian [Sun, 22 Oct 2017 10:39:01 +0000 (12:39 +0200)]
Fancy: Escape the custom stylesheet path for use in URI.
This allows for file/folder names with e.g. space in them.
Paul [Tue, 10 Oct 2017 08:33:23 +0000 (09:33 +0100)]
fix bug 3893, ' Text mode open/copy web links ignores trailing tilde(s)'
Andrej Kacian [Thu, 5 Oct 2017 11:17:49 +0000 (13:17 +0200)]
master_passphrase_is_set() and _is_correct() do not return const bool.
Andrej Kacian [Sat, 1 Jul 2017 10:23:33 +0000 (12:23 +0200)]
Use separate account configuration for OpenPGP and for S/MIME.
This is useful for users who switch between privacy systems.
Based on patch by Thomas Orgis.
Closes bug Bug 3834 - [PATCH] separate account prefs for
S/MIME to be able to specify keys for both PGP and S/MIME
Ricardo Mones [Thu, 21 Sep 2017 08:49:52 +0000 (10:49 +0200)]
Document the new --insert command line option
added in commit
9b17603ded77a56d10e56e80b9647487e25546da
Ricardo Mones [Wed, 20 Sep 2017 20:06:03 +0000 (22:06 +0200)]
Revert "Fix bug #3855: segfault at startup with old profile and IMAP account"
Thanks to commit
c3167bf1a4bf76a75813856d48e9d3c00f6c3849 which allows
to access folder class functions at earlier stages without causing #3855.
This reverts commit
667c9d3eaf0487193cc7873e6d3a63959a03d7f9.
Colin Leroy [Mon, 18 Sep 2017 08:09:52 +0000 (10:09 +0200)]
Fix a possible leak
Colin Leroy [Mon, 18 Sep 2017 08:03:39 +0000 (10:03 +0200)]
Fix double-free of keys
Colin Leroy [Fri, 15 Sep 2017 13:45:46 +0000 (15:45 +0200)]
CLI: Add a --insert option to --compose, allowing to insert files.
Andrej Kacian [Sun, 6 Aug 2017 16:43:43 +0000 (18:43 +0200)]
Handle config_version update separately for accounts.
Instead of loading entire configuration from all the
files in rcdir and doing an update at the end, we
now upgrade each "part" right after we load it.
This is to allow greater flexibility during the time
not all of the configuration is loaded yet, e.g. folders
using correct folderclass functions, based on protocol
of account owning a particular folder.
This is currently affecting clawsrc and accountrc, but
it will be trivial to extend it to other rcdir files
as needed.
Ricardo Mones [Thu, 7 Sep 2017 12:05:36 +0000 (14:05 +0200)]
Update authors' files
Flavio Leitner [Sat, 12 Aug 2017 21:28:23 +0000 (18:28 -0300)]
Fix bug #3881: Keep read thread during update if it is selected.
When new emails arrive, the summary list is updated and the read
threads are removed if the option 'Hide read threads' is checked.
However, if you are reading the last email of a thread, then it
automatically goes to the next email. If the new selected email
happens to be the last read in a thread, then the next update
will do the same even though the user might not have seen that
message yet.
This patch fixes it to keep the thread if a message is selected.
Paul [Tue, 5 Sep 2017 15:08:30 +0000 (16:08 +0100)]
fix bug 3892, 'build fails with enchant-2.1.0'
bumps the minimum required version of enchant to version 1.4.0
Paul [Sat, 2 Sep 2017 09:44:48 +0000 (10:44 +0100)]
fix bug 3852, 'delete header entry button doesn't restore colour'
Paul [Thu, 31 Aug 2017 09:13:28 +0000 (10:13 +0100)]
fix bug 3886, '"About to send mail to 2 recipients" warning when one of them is Reply-To'
wwp [Wed, 30 Aug 2017 09:20:29 +0000 (11:20 +0200)]
Fix wrong 'attach_output' in description of symbols (templates), it's
'attach_program' that works.
wwp [Tue, 29 Aug 2017 12:41:23 +0000 (14:41 +0200)]
Lower the librsvg requirement to 2.39 (works on CentOS7 with
this).
Andrej Kacian [Sat, 26 Aug 2017 08:03:51 +0000 (10:03 +0200)]
Fix typo around libarchive in configure.ac.
Patch by Orbea, Bug 3866 - slibtool causes compile failure
Andrej Kacian [Sat, 26 Aug 2017 08:00:07 +0000 (10:00 +0200)]
Fixed incorrect PERL_LDFLAGS modification with sed.
Patch by Orbea, Bug 3866 - slibtool causes compile failure
Ricardo Mones [Wed, 9 Aug 2017 14:48:38 +0000 (16:48 +0200)]
Fix bug #3855: segfault at startup with old profile and IMAP account
Revert "Remove duplicated code and include".
This reverts commit
300f811f3bbf10455ca55d9b01da6705dd1e07bb.
Andrej Kacian [Fri, 28 Jul 2017 17:55:04 +0000 (19:55 +0200)]
Fix a small memory leak in procmime_get_mime_type().
Andrej Kacian [Fri, 28 Jul 2017 17:50:29 +0000 (19:50 +0200)]
Fix a memory leak in empty subject warning dialog in compose.c.
Andrej Kacian [Fri, 28 Jul 2017 17:46:13 +0000 (19:46 +0200)]
Fix template parsing broken by commit
814b087.
Ricardo Mones [Thu, 27 Jul 2017 08:09:37 +0000 (10:09 +0200)]
Fix D-Bus detection
Andrej Kacian [Mon, 24 Jul 2017 16:26:38 +0000 (18:26 +0200)]
Removed a nonexistent function from addressbook.h.
The function was addressbook_load_completion().
Ricardo Mones [Mon, 24 Jul 2017 07:35:05 +0000 (09:35 +0200)]
Really handle the NULLs, don't scream at them
Ricardo Mones [Sun, 23 Jul 2017 10:38:06 +0000 (12:38 +0200)]
Check for NULLs params within the functions
As assumed in the prefs_themes_done() calls. May fix some strange crash
when exiting Claws Mail in Debian's version 3.14.1-3+b1:
*** Error in `/usr/bin/claws-mail': munmap_chunk(): invalid pointer:
0x00000000026a6f80 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x70bcb)[0x7fa85407cbcb]
/lib/x86_64-linux-gnu/libc.so.6(+0x76f96)[0x7fa854082f96]
/usr/bin/claws-mail(stock_pixmap_themes_list_free+0x28)[0x55a7a8]
/usr/bin/claws-mail(prefs_themes_done+0x3a)[0x5389ba]
/usr/bin/claws-mail[0x449329]
/usr/bin/claws-mail(main+0x2326)[0x44b986]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1)[0x7fa85402c2b1]
/usr/bin/claws-mail(_start+0x2a)[0x44bfda]
Andrej Kacian [Sun, 16 Jul 2017 18:04:57 +0000 (20:04 +0200)]
Avoid one strdup in address_completion_complete_address_in_entry().
Andrej Kacian [Sun, 16 Jul 2017 17:38:12 +0000 (19:38 +0200)]
Fixed a memory leak in address completion.
Andrej Kacian [Sun, 16 Jul 2017 17:31:25 +0000 (19:31 +0200)]
Pgpmime: fix two memory leak in MIME boundary handling.
Andrej Kacian [Sun, 16 Jul 2017 17:22:23 +0000 (19:22 +0200)]
Fixed two memory leaks around procheader_get_one_field().
Andrej Kacian [Sun, 16 Jul 2017 15:53:38 +0000 (17:53 +0200)]
Managesieve: fix memory leak when saving password from account prefs
Ricardo Mones [Sun, 16 Jul 2017 15:38:38 +0000 (17:38 +0200)]
Dedicated icons for toolbar's new privacy buttons
Andrej Kacian [Sun, 16 Jul 2017 15:37:16 +0000 (17:37 +0200)]
Fixed another memory leak in filtering pref dialog.
Andrej Kacian [Sun, 16 Jul 2017 12:39:21 +0000 (14:39 +0200)]
Fixed two tiny memory leaks in filtering pref dialog.
Andrej Kacian [Sun, 16 Jul 2017 10:18:03 +0000 (12:18 +0200)]
Second attempt at fixing the memory leak in matcherrc rule parsing.
This time, we take into account that the memory allocated by
yyparse() uses is sometimes used and freed by another
function higher in the stack.
Andrej Kacian [Thu, 13 Jul 2017 08:31:04 +0000 (10:31 +0200)]
Revert "Fix a memory leak in matcherrc rule parsing."
This reverts commit
2103e3787ab8ef2c8eb43d35292e5c91b5b61237.
Closes bug #3848 - Cannot edit existing filter or processing rules.
Andrej Kacian [Wed, 12 Jul 2017 21:52:06 +0000 (23:52 +0200)]
Fix a memory leak in get_fingerprint().
Andrej Kacian [Wed, 12 Jul 2017 21:47:39 +0000 (23:47 +0200)]
Fixed an uninitialized variable use in check_cert().
Andrej Kacian [Wed, 12 Jul 2017 20:16:00 +0000 (22:16 +0200)]
Fix three small memory leaks in addressbook.
Andrej Kacian [Wed, 12 Jul 2017 18:43:07 +0000 (20:43 +0200)]
Correction of previous commit
6fedb78e7.
We do not want to prematurely close tmpfp handle if
it points to outfp.
Andrej Kacian [Wed, 12 Jul 2017 16:48:48 +0000 (18:48 +0200)]
Fix a file descriptor leak in procmime_decode_content().
Closes bug #3266 - procmime.c: FILE leak in specific circumstances
Andrej Kacian [Wed, 12 Jul 2017 11:36:23 +0000 (13:36 +0200)]
Fixed one more memory leak that was missed in
b77707343.
Andrej Kacian [Wed, 12 Jul 2017 11:22:52 +0000 (13:22 +0200)]
Fixed a few memory leaks in LDAP search results handling.
Andrej Kacian [Wed, 12 Jul 2017 09:14:13 +0000 (11:14 +0200)]
Fix a memory leak in compose_write_to_file().
Andrej Kacian [Wed, 12 Jul 2017 08:56:36 +0000 (10:56 +0200)]
Fixed a memory leak in prefs_account_generate_msgid().
Andrej Kacian [Wed, 12 Jul 2017 08:41:33 +0000 (10:41 +0200)]
Fixed a memory leak in folder selection dialog.
Also removed the code block for adjusting folder
name for special folders, since that already
happens in folder_item_get_name().
Andrej Kacian [Wed, 12 Jul 2017 08:34:44 +0000 (10:34 +0200)]
Fix two memory leaks in filtering action dialog widgets.
Andrej Kacian [Wed, 12 Jul 2017 07:47:45 +0000 (09:47 +0200)]
Fix use of uninitialized value in sgpgme_has_secret_key().
Fixes commit
11980bc7a.
Andrej Kacian [Tue, 11 Jul 2017 19:09:24 +0000 (21:09 +0200)]
Fix a few memory leaks when enumerating keys with GpgME.
Also replaced uses of deprecated gpgme_key_release()
with gpgme_key_unref().
Andrej Kacian [Tue, 11 Jul 2017 17:48:57 +0000 (19:48 +0200)]
Fix a memory leak in matcherrc rule parsing.
Andrej Kacian [Tue, 11 Jul 2017 16:37:54 +0000 (18:37 +0200)]
Fix several memory leaks around template parsing.
FLEX-generated quote_fmt_scan_string() allocates a buffer
(and actually returns a pointer to it, although its prototype
in quote_fmt.h says its return value is void), which needs
to be cleaned up afterwards.
Andrej Kacian [Tue, 11 Jul 2017 15:55:11 +0000 (17:55 +0200)]
Fix two memory leaks in Logging prefs page widget packing.
Andrej Kacian [Tue, 11 Jul 2017 15:35:44 +0000 (17:35 +0200)]
Fix a memory leak around buttons in Colors prefs page.
Ricardo Mones [Tue, 11 Jul 2017 08:06:20 +0000 (10:06 +0200)]
Check for NULL buttons also here
Thanks Andrej for the suggestion!
Ricardo Mones [Tue, 11 Jul 2017 07:53:42 +0000 (09:53 +0200)]
Fix initialization of privacy buttons sensitivity
Andrej Kacian [Fri, 7 Jul 2017 13:28:25 +0000 (15:28 +0200)]
Add Sign/Encrypt toggle buttons to Compose toolbar.
Andrej Kacian [Mon, 10 Jul 2017 22:12:22 +0000 (00:12 +0200)]
Fix a typo.
Andrej Kacian [Mon, 10 Jul 2017 16:36:37 +0000 (18:36 +0200)]
Fix uninitialized values in sieve privacy prefs parsing.
This happens if username and/or password fields are empty,
so sscanf() doesn't get to write into our enc_userid and
enc_passwd buffers.
Andrej Kacian [Mon, 10 Jul 2017 16:11:12 +0000 (18:11 +0200)]
Fix two similar memory leaks in pgp and managesieve prefs.
Andrej Kacian [Mon, 10 Jul 2017 16:01:41 +0000 (18:01 +0200)]
Fix a memory leak in the "no imap" account prefs label.
Andrej Kacian [Mon, 10 Jul 2017 15:56:09 +0000 (17:56 +0200)]
Fix two memory leaks around use of privacy_get_system_ids().
Andrej Kacian [Sun, 9 Jul 2017 21:58:45 +0000 (23:58 +0200)]
Fixed a memory leak when checking TLS certificates.
Andrej Kacian [Sun, 9 Jul 2017 21:55:29 +0000 (23:55 +0200)]
Fix a memory leak in libSM use.
Andrej Kacian [Sun, 9 Jul 2017 21:49:03 +0000 (23:49 +0200)]
Fixed a memory leak in GnuTLS password decryption.
Andrej Kacian [Sun, 9 Jul 2017 16:27:20 +0000 (18:27 +0200)]
Fix a long-standing memory leak in account prefs.
All P_STRING type prefs with non-NULL default values
were being leaked due to overly complicated account
config loading, where we would first initialize
a fresh PrefAccount, then load prefs from config, copying
data between the static tmp_ac_prefs and our dynamically
allocated PrefAccount several times.
Instead of adding another round of data copying from/to
tmp_ac_prefs for purpose of free()ing the P_STRING prefs,
this commit changes prefs_account_read_config() into
prefs_account_new_from_config(), a
Existing accounts are now created with simple:
ac_prefs = prefs_account_new_from_config(...);
instead of previous:
ac_prefs = prefs_account_new();
prefs_account_read_from_config(ac_prefs, ...);
The new function sets up contents of tmp_ac_prefs,
and then its contents are only copied to the newly
allocated PrefsAccount once.
Andrej Kacian [Fri, 7 Jul 2017 10:49:22 +0000 (12:49 +0200)]
Correct the use of pthread_create() in several places.
The second argument should be a pointer to pthread_attr_t,
not a numeric constant. Joinable detachstate is also the
default, we don't need to explicitly set it. Lastly, use
"NULL" for null pthread_attr_t pointer, not "0" (this is
just a cosmetic/consistency thing, but still).
Andrej Kacian [Tue, 4 Jul 2017 10:07:02 +0000 (12:07 +0200)]
Andrej Kacian [Mon, 3 Jul 2017 22:07:49 +0000 (00:07 +0200)]
Fix reading past buffer boundary in RSSyl's strreplace.
Ricardo Mones [Mon, 3 Jul 2017 19:55:23 +0000 (21:55 +0200)]
Fix bug #3348 ‘Contact pictures not deleted when contact is deleted’
Based on original patch submitted by Charles Lehner (thanks!)
Andrej Kacian [Mon, 3 Jul 2017 17:33:03 +0000 (19:33 +0200)]
Removed unused widgetfont pref from PrefsCommon.
Andrej Kacian [Mon, 3 Jul 2017 13:50:47 +0000 (15:50 +0200)]
Revert "Add a 'signature.asc' filename for PGP MIME signatures."
This reverts commit
bd6cfc227c3386329ce7baef2aac10788e47c445.
The change causes more problems than it solves, seeing as
it triggers alarms for a lot of antivirus/antispam software.
Andrej Kacian [Sat, 1 Jul 2017 09:39:06 +0000 (11:39 +0200)]
Removed the "Change to..." fake menuitem from spelling dictionaries menu.
Closes bug #3843: Non-functional "Change to…" command in Spelling menu
Andrej Kacian [Wed, 21 Jun 2017 19:04:22 +0000 (21:04 +0200)]
Add a 'signature.asc' filename for PGP MIME signatures.
This requires Content-Disposition MIME header to be set.
We set the disposition to "inline". Closes bug #3836.
Andrej Kacian [Wed, 21 Jun 2017 14:20:20 +0000 (16:20 +0200)]
Improve password_decrypt_gnutls() to handle encrypted strings of any length.
Colin Leroy [Sun, 18 Jun 2017 19:46:58 +0000 (21:46 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 18 Jun 2017 19:46:08 +0000 (21:46 +0200)]
Fix Toggling of preferences leaving empty view
Webkit can't apparently reload when it loaded a string.
Ricardo Mones [Sat, 17 Jun 2017 15:05:55 +0000 (17:05 +0200)]
Fix bug 3822 ‘AttRemover deletes message and fails to create new one when disk is full’
Paul [Fri, 16 Jun 2017 09:05:15 +0000 (10:05 +0100)]
fix building on MAC. fixes bug 3835, 'autogen.sh fails with invalid test on line 33'
fix by Michael Vilain <michael@vilain.com>
Ricardo Mones [Fri, 9 Jun 2017 06:58:07 +0000 (08:58 +0200)]
Use correct variable in printf
A new buf_date was introduced, but the old pointer (buf) still used in
the printf(). Patch by Olivier Brunel.
Andrej Kacian [Mon, 5 Jun 2017 09:40:52 +0000 (11:40 +0200)]
Fix building for Windows after commit
b320c5095.
Colin Leroy [Sat, 3 Jun 2017 19:57:08 +0000 (21:57 +0200)]
Fix Fancy showing a previous email in some cases.
The problem seemed to be due to something returning
"application/x-extension-html" instead of "text/html"
as MIME types for some emails, stopping rendering.
Using _load_string instead of _load_uri fixes it.
Also, remove some outdated conditionals now we require
Webkit 1.1.14, and replace some deprecated callbacks
with the more recent ones.
Ricardo Mones [Thu, 1 Jun 2017 10:27:15 +0000 (12:27 +0200)]
Fix bug #3721 ‘Fails to build in Debian kfreebsd-*’
Andrej Kacian [Wed, 31 May 2017 19:10:19 +0000 (21:10 +0200)]
Only preserve existing Message-ID when reediting a draft.
This is a followup to commit
e22cbed1f.
Closes Bug 3828 - "Re-edit" should not recycle the Message-ID header
Andrej Kacian [Wed, 31 May 2017 18:38:59 +0000 (20:38 +0200)]
Do not try to handle quotes in text attachments.
Closes Bug 3824 - Quotation Folding is wrongly applied to text
attachments.
Andrej Kacian [Fri, 26 May 2017 19:59:01 +0000 (21:59 +0200)]
Use a better shadow type on pluginwindow's "Description" frame.
This makes it look the same as page name frame on top of
the preference dialog.
Andrej Kacian [Fri, 26 May 2017 19:46:37 +0000 (21:46 +0200)]
Add keyboard shortcuts to pluginwindow Load.../Unload buttons.
Paul [Mon, 22 May 2017 16:56:06 +0000 (17:56 +0100)]
add more utf8 listitem characters
patch by H. Merijn Brand
Andrej Kacian [Sun, 21 May 2017 20:00:03 +0000 (22:00 +0200)]
Some forgotten cleanups for previous commit,
70ea2d849.
Andrej Kacian [Sun, 21 May 2017 19:24:01 +0000 (21:24 +0200)]
Hopefully fixed sporadic crashes in Windows native file chooser.
Ricardo Mones [Sun, 21 May 2017 19:15:42 +0000 (21:15 +0200)]
Remove unused struct