claws.git
2 years agoFix CID 1491353: resource leak.
wwp [Thu, 30 Sep 2021 09:03:35 +0000 (11:03 +0200)]
Fix CID 1491353: resource leak.

2 years agoRework a bit the vcal export to file logic.
wwp [Thu, 30 Sep 2021 08:06:46 +0000 (10:06 +0200)]
Rework a bit the vcal export to file logic.

2 years agoFix memory corruption caused by a double free.
wwp [Thu, 30 Sep 2021 07:55:25 +0000 (09:55 +0200)]
Fix memory corruption caused by a double free.

2 years agoFix CID 1491191: use after free.
wwp [Wed, 29 Sep 2021 14:53:08 +0000 (16:53 +0200)]
Fix CID 1491191: use after free.
Reworked a bit variable scopes in multisync_export() in order to avoid such issues.

2 years agoFix CID 1491106, 1491129, 1491163, 1491231, 1491329 and 1491353: resource leaks.
wwp [Wed, 29 Sep 2021 14:45:19 +0000 (16:45 +0200)]
Fix CID 14911061491129149116314912311491329 and 1491353: resource leaks.

2 years agoFix CID 1491162, 1491183, 1491321 and 1491257: resource leaks.
wwp [Wed, 29 Sep 2021 14:17:41 +0000 (16:17 +0200)]
Fix CID 149116214911831491321 and 1491257: resource leaks.

2 years agoFix CID 1491149: resource leak.
wwp [Wed, 29 Sep 2021 14:00:18 +0000 (16:00 +0200)]
Fix CID 1491149: resource leak.

2 years agoFix CID 1491296, 1491368, 1491288 and 1491322: dereference before null check.
wwp [Wed, 29 Sep 2021 10:59:53 +0000 (12:59 +0200)]
Fix CID 149129614913681491288 and 1491322: dereference before null check.

2 years agoFix CID 1491362: dereference after null check.
wwp [Wed, 29 Sep 2021 10:43:22 +0000 (12:43 +0200)]
Fix CID 1491362: dereference after null check.
Fix CID 1491278: (neutral) use after free (but still better to disable callbacks before freeing).

2 years agoFix resource leak: we were never freeing session's config.
wwp [Wed, 29 Sep 2021 10:37:00 +0000 (12:37 +0200)]
Fix resource leak: we were never freeing session's config.

2 years agoFix CID 1491276: resource leak.
wwp [Wed, 29 Sep 2021 10:36:21 +0000 (12:36 +0200)]
Fix CID 1491276: resource leak.

2 years agoFix CID 1491346: resource leak.
wwp [Wed, 29 Sep 2021 10:20:00 +0000 (12:20 +0200)]
Fix CID 1491346: resource leak.

2 years agoFix pgpcore build.
wwp [Tue, 28 Sep 2021 16:42:57 +0000 (18:42 +0200)]
Fix pgpcore build.

2 years agoFix CID 1492251: resource leaks.
wwp [Tue, 28 Sep 2021 15:41:01 +0000 (17:41 +0200)]
Fix CID 1492251: resource leaks.

2 years agoFix CID 1492200 and 1491225: resource leaks.
wwp [Tue, 28 Sep 2021 15:40:39 +0000 (17:40 +0200)]
Fix CID 1492200 and 1491225: resource leaks.

2 years agoFix CID 1492195, 1491196, 1491158 and 1491081: resource leaks.
wwp [Tue, 28 Sep 2021 15:40:12 +0000 (17:40 +0200)]
Fix CID 149219514911961491158 and 1491081: resource leaks.

2 years agoFix CID 1491146: resource leak.
wwp [Tue, 28 Sep 2021 15:16:57 +0000 (17:16 +0200)]
Fix CID 1491146: resource leak.

2 years agoFix CID 1491066: resource leak.
wwp [Tue, 28 Sep 2021 15:13:07 +0000 (17:13 +0200)]
Fix CID 1491066: resource leak.

2 years agoFix CID 1491150: resource leaks.
wwp [Tue, 28 Sep 2021 15:07:13 +0000 (17:07 +0200)]
Fix CID 1491150: resource leaks.

2 years agoFix CID 1492282, 1492283: double free.
wwp [Tue, 28 Sep 2021 14:54:22 +0000 (16:54 +0200)]
Fix CID 14922821492283: double free.

2 years agoFix CID 1492279: resource leak.
wwp [Tue, 28 Sep 2021 14:46:24 +0000 (16:46 +0200)]
Fix CID 1492279: resource leak.

2 years agoFix CID 1491274: resource leak.
wwp [Tue, 28 Sep 2021 14:42:11 +0000 (16:42 +0200)]
Fix CID 1491274: resource leak.

2 years agoFix CID 1491122, 1491118, 1491138, 1491092, 1491098 and 1491340: resource leaks.
wwp [Tue, 28 Sep 2021 13:49:39 +0000 (15:49 +0200)]
Fix CID 14911221491118149113814910921491098 and 1491340: resource leaks.
Fix an extra leaks in opml parsing.
Fix CID 1491366: unchecked return value.

2 years agoFix CID 1491069 and 1491256: resource leaks.
wwp [Tue, 28 Sep 2021 12:45:12 +0000 (14:45 +0200)]
Fix CID 1491069 and 1491256: resource leaks.

2 years agoFix CID 1491076 and 1491352: resource leaks.
wwp [Tue, 28 Sep 2021 12:36:55 +0000 (14:36 +0200)]
Fix CID 1491076 and 1491352: resource leaks.

2 years agoFix CID 1491076 and 1491352: resource leaks.
wwp [Tue, 28 Sep 2021 12:27:11 +0000 (14:27 +0200)]
Fix CID 1491076 and 1491352: resource leaks.

2 years agoFix CID 1491121: resource leak.
wwp [Tue, 28 Sep 2021 12:09:28 +0000 (14:09 +0200)]
Fix CID 1491121: resource leak.

2 years agoRevert fixes for CID 1491185, 1492198, 1491339, 1491307 (resource leaks),
wwp [Mon, 27 Sep 2021 19:34:22 +0000 (21:34 +0200)]
Revert fixes for CID 1491185149219814913391491307 (resource leaks),
need further investigation (probably false positives).

2 years agoFix CID 1491185, 1492198, 1491356, 1491339, 1491307, 1491188, 1491179, 1491107: resou...
wwp [Mon, 27 Sep 2021 19:01:23 +0000 (21:01 +0200)]
Fix CID 14911851492198149135614913391491307149118814911791491107: resource leaks.

2 years agoFix CIS 1491270: resource leak.
wwp [Mon, 27 Sep 2021 18:34:23 +0000 (20:34 +0200)]
Fix CIS 1491270: resource leak.

2 years agoProper fix for CID 1491065 (resource leak).
wwp [Mon, 27 Sep 2021 17:33:15 +0000 (19:33 +0200)]
Proper fix for CID 1491065 (resource leak).

2 years agoFix CID 1492279: resource leak.
wwp [Mon, 27 Sep 2021 16:31:41 +0000 (18:31 +0200)]
Fix CID 1492279: resource leak.

2 years agoFix CID 1491085: (possible) use after free.
wwp [Mon, 27 Sep 2021 16:26:59 +0000 (18:26 +0200)]
Fix CID 1491085: (possible) use after free.

2 years agoFix CID 1491274: resource leak.
wwp [Mon, 27 Sep 2021 16:24:56 +0000 (18:24 +0200)]
Fix CID 1491274: resource leak.

2 years agoFix CID 1491018: resource leak.
wwp [Mon, 27 Sep 2021 16:10:16 +0000 (18:10 +0200)]
Fix CID 1491018: resource leak.

2 years agoFix CID 1491119: use after free.
wwp [Mon, 27 Sep 2021 16:06:01 +0000 (18:06 +0200)]
Fix CID 1491119: use after free.

2 years agoFix CID 1491200, 1491294 and 1491301: resource leaks.
wwp [Mon, 27 Sep 2021 16:03:43 +0000 (18:03 +0200)]
Fix CID 14912001491294 and 1491301: resource leaks.

2 years agoFix CID 1491190: explicit null dereference.
wwp [Mon, 27 Sep 2021 15:57:48 +0000 (17:57 +0200)]
Fix CID 1491190: explicit null dereference.

2 years agoFix CID 1491337, 1491317 and 1491101: resource leak, use after free.
wwp [Sun, 26 Sep 2021 19:43:57 +0000 (21:43 +0200)]
Fix CID 14913371491317 and 1491101: resource leak, use after free.

2 years agoFix CID 1491147 and 1491153: null ptr dereference, resource leak.
wwp [Sun, 26 Sep 2021 19:33:47 +0000 (21:33 +0200)]
Fix CID 1491147 and 1491153: null ptr dereference, resource leak.

2 years agoFix CID 1491065, 1491075 and 1491274: resource leaks
wwp [Sun, 26 Sep 2021 19:26:58 +0000 (21:26 +0200)]
Fix CID 14910651491075 and 1491274: resource leaks

2 years agoFix CID 1491095: resource leak.
wwp [Sun, 26 Sep 2021 19:11:34 +0000 (21:11 +0200)]
Fix CID 1491095: resource leak.

2 years agoFix CID 1491324: use after free.
wwp [Sun, 26 Sep 2021 19:08:14 +0000 (21:08 +0200)]
Fix CID 1491324: use after free.

2 years agoFix CID 1491102: use after free.
wwp [Sun, 26 Sep 2021 19:05:51 +0000 (21:05 +0200)]
Fix CID 1491102: use after free.

2 years agoFix CID 1491134, 1491173: resource leaks.
wwp [Sun, 26 Sep 2021 19:04:34 +0000 (21:04 +0200)]
Fix CID 14911341491173: resource leaks.

2 years agoFix CID 1491116: explicit null dereference,
wwp [Sun, 26 Sep 2021 17:41:22 +0000 (19:41 +0200)]
Fix CID 1491116: explicit null dereference,
make sure folder item identifier is set and further allocations are possible when building a path list.

2 years agoFix CID 1491354: null ptr dereference,
wwp [Sun, 26 Sep 2021 17:30:14 +0000 (19:30 +0200)]
Fix CID 1491354: null ptr dereference,
add warnings in case of unexpected filename encoding conversion or copy failures.

2 years agoFix CID 1491140 (and strange design): free of stack-allocated memory.
wwp [Sun, 26 Sep 2021 17:14:30 +0000 (19:14 +0200)]
Fix CID 1491140 (and strange design): free of stack-allocated memory.

2 years agoFix CID 1491320, 1492199, 1492201: resource leaks.
wwp [Sun, 26 Sep 2021 16:53:49 +0000 (18:53 +0200)]
Fix CID 149132014921991492201: resource leaks.

2 years agoFix CID 1491131 and 1491292: resource leaks.
wwp [Sun, 26 Sep 2021 15:23:11 +0000 (17:23 +0200)]
Fix CID 1491131 and 1491292: resource leaks.

2 years agoFix CID 1391319: resource leak.
wwp [Sun, 26 Sep 2021 15:11:57 +0000 (17:11 +0200)]
Fix CID 1391319: resource leak.

2 years agoFix CID 1491067: resource leak.
wwp [Sun, 26 Sep 2021 15:10:35 +0000 (17:10 +0200)]
Fix CID 1491067: resource leak.

2 years agoFix CID 1491186 resource leaks.
wwp [Sun, 26 Sep 2021 15:08:28 +0000 (17:08 +0200)]
Fix CID 1491186 resource leaks.

2 years agoFix CID 1491264: use after free.
wwp [Sun, 26 Sep 2021 14:55:45 +0000 (16:55 +0200)]
Fix CID 1491264: use after free.

2 years agoFix memory leak
Jonathan Boeing [Fri, 24 Sep 2021 15:21:06 +0000 (08:21 -0700)]
Fix memory leak

2 years agoFix memory leak
Jonathan Boeing [Fri, 24 Sep 2021 11:57:54 +0000 (04:57 -0700)]
Fix memory leak

2 years agoFix memory leak
Jonathan Boeing [Fri, 24 Sep 2021 11:47:46 +0000 (04:47 -0700)]
Fix memory leak

2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Paul [Thu, 23 Sep 2021 17:21:39 +0000 (18:21 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

2 years agosome updates
Paul [Thu, 23 Sep 2021 17:21:16 +0000 (18:21 +0100)]
some updates

2 years agoAdd new RSSyl feed: use any URI found in the clipboard.
wwp [Wed, 22 Sep 2021 11:31:10 +0000 (13:31 +0200)]
Add new RSSyl feed: use any URI found in the clipboard.

2 years agofix dates of latest releases
paul [Tue, 21 Sep 2021 13:35:20 +0000 (14:35 +0100)]
fix dates of latest releases

2 years agoFix missing line continuation
Jonathan Boeing [Mon, 20 Sep 2021 10:38:51 +0000 (03:38 -0700)]
Fix missing line continuation

2 years agoUpdate plugin makefiles for Windows
Jonathan Boeing [Mon, 20 Sep 2021 10:18:44 +0000 (03:18 -0700)]
Update plugin makefiles for Windows

2 years agoUpdate Windows VERSIONINFO resource for plugins
Jonathan Boeing [Mon, 20 Sep 2021 10:17:06 +0000 (03:17 -0700)]
Update Windows VERSIONINFO resource for plugins

2 years agoport pdf viewer plugin to windows
Jonathan Boeing [Mon, 23 Aug 2021 00:04:29 +0000 (17:04 -0700)]
port pdf viewer plugin to windows

2 years agoFix few wrong string lengths when matching URI schemes, add more known
wwp [Fri, 17 Sep 2021 14:55:12 +0000 (16:55 +0200)]
Fix few wrong string lengths when matching URI schemes, add more known
schemes.

2 years agoput the correct config_version in folderitemrc
paul [Fri, 17 Sep 2021 10:46:33 +0000 (11:46 +0100)]
put the correct config_version in folderitemrc

2 years agofix Ingreesh
paul [Fri, 17 Sep 2021 08:08:48 +0000 (09:08 +0100)]
fix Ingreesh

2 years agoonly allow deletion of tags from the Tags Configuration window
paul [Fri, 17 Sep 2021 07:38:44 +0000 (08:38 +0100)]
only allow deletion of tags from the Tags Configuration window

2 years agorework tags
paul [Thu, 16 Sep 2021 15:45:27 +0000 (16:45 +0100)]
rework tags

set correct window title, depending on whether we are configuring the tags, or modifying the tags of the selected message(s); display or don't display the label in the window, depending on the same; improve the English usage; make the 'add' button sensitive, so we don't need the 'tag not set' warning if someone presses Add without setting the tag name; only show the vertidal scrollbar when needed; lots of renaming, e.g. not 'apply_window' but 'tags_window'

2 years agoremove typo semi-colons
Paul [Thu, 16 Sep 2021 15:24:49 +0000 (16:24 +0100)]
remove typo semi-colons

2 years agoBetter (and real) fix for CID 1491141 (resource leak), simplify the
wwp [Thu, 16 Sep 2021 08:06:21 +0000 (10:06 +0200)]
Better (and real) fix for CID 1491141 (resource leak), simplify the
handling of 'value'.

2 years agoUpdate Windows registry code
Jonathan Boeing [Tue, 14 Sep 2021 09:04:45 +0000 (02:04 -0700)]
Update Windows registry code

2 years agoCleanup w32lib.h
Jonathan Boeing [Tue, 14 Sep 2021 06:33:51 +0000 (23:33 -0700)]
Cleanup w32lib.h

2 years agoRemove old windows compatibility code
Jonathan Boeing [Tue, 14 Sep 2021 05:33:00 +0000 (22:33 -0700)]
Remove old windows compatibility code

2 years agoFix CID 1491141, 149246: resource leaks.
wwp [Wed, 15 Sep 2021 22:43:08 +0000 (00:43 +0200)]
Fix CID 1491141, 149246: resource leaks.
Fix CID 1491291: ensure string in buffer is 0-ended.

2 years agoFix CID 1491202, 1491126, 1491156 and 1491142: resource leaks. And
wwp [Wed, 15 Sep 2021 22:18:50 +0000 (00:18 +0200)]
Fix CID 149120214911261491156 and 1491142: resource leaks. And
simplify the copy algorithm a bit (mostly around error checking).

2 years agoFix CID 1491202, 1491126, 1491156 and 1491142: resource leaks. And
wwp [Wed, 15 Sep 2021 22:16:19 +0000 (00:16 +0200)]
Fix CID 149120214911261491156 and 1491142: resource leaks. And
simplify the copy algorithm a bit (mostly around error checking).

2 years agoFix scrolling in a message's attachments bar (scrolling left or right
wwp [Wed, 15 Sep 2021 09:21:51 +0000 (11:21 +0200)]
Fix scrolling in a message's attachments bar (scrolling left or right
were scrolling down).

2 years agoFix CID 1491213: resource leak.
wwp [Tue, 14 Sep 2021 11:57:43 +0000 (13:57 +0200)]
Fix CID 1491213: resource leak.

2 years agoFix time_t format specifier warnings
Jonathan Boeing [Mon, 13 Sep 2021 09:02:18 +0000 (02:02 -0700)]
Fix time_t format specifier warnings

2 years agoFix -Wmaybe-uninitialized warning
Jonathan Boeing [Mon, 13 Sep 2021 08:25:35 +0000 (01:25 -0700)]
Fix -Wmaybe-uninitialized warning

2 years agoFix litehtml warnings
Jonathan Boeing [Mon, 13 Sep 2021 08:19:02 +0000 (01:19 -0700)]
Fix litehtml warnings

2 years agoFix size_t format specifier warnings
Jonathan Boeing [Mon, 13 Sep 2021 07:59:25 +0000 (00:59 -0700)]
Fix size_t format specifier warnings

2 years agoFix missing GTK casts
Jonathan Boeing [Mon, 13 Sep 2021 07:53:29 +0000 (00:53 -0700)]
Fix missing GTK casts

2 years agoGPid is a HANDLE on Windows
Jonathan Boeing [Mon, 13 Sep 2021 07:30:27 +0000 (00:30 -0700)]
GPid is a HANDLE on Windows

2 years agoFix -Wunused-variable warnings
Jonathan Boeing [Mon, 13 Sep 2021 06:56:56 +0000 (23:56 -0700)]
Fix -Wunused-variable warnings

2 years agoFix -Wunused-but-set-variable warnings
Jonathan Boeing [Mon, 13 Sep 2021 06:50:02 +0000 (23:50 -0700)]
Fix -Wunused-but-set-variable warnings

2 years agoAdd glib version check for g_thread_supported
Jonathan Boeing [Mon, 13 Sep 2021 06:23:00 +0000 (23:23 -0700)]
Add glib version check for g_thread_supported

2 years agoRemove unneeded define for litehtml
Jonathan Boeing [Mon, 13 Sep 2021 04:25:07 +0000 (21:25 -0700)]
Remove unneeded define for litehtml

2 years agofix bug 4312, 'litehtml plugin loops (hangup)'
paul [Tue, 3 Aug 2021 11:10:01 +0000 (12:10 +0100)]
fix bug 4312, 'litehtml plugin loops (hangup)'

patch by Frank Mueller

(cherry picked from commit 00d0212ccbcaa608a91c5f3a50639fed98f654c6)

2 years agoAdd updated fix for litehtml os_types.h
Jonathan Boeing [Mon, 13 Sep 2021 04:28:48 +0000 (21:28 -0700)]
Add updated fix for litehtml os_types.h

Original fix from b1bc36d2f7ca19cd61e335561d2a44c421ba9678

2 years agoAdd a getter for litehtml::document's m_over_element member
Andrej Kacian [Wed, 10 Apr 2019 19:12:57 +0000 (21:12 +0200)]
Add a getter for litehtml::document's m_over_element member

This allows us to avoid some expensive GDK calls in
lh_widget::set_cursor().

(cherry picked from commit 7c6693d7085636df23c44d1b40895f0e43c1f166)

2 years agoSync with upstream litehtml
Jonathan Boeing [Mon, 13 Sep 2021 03:40:02 +0000 (20:40 -0700)]
Sync with upstream litehtml

Sync with commit 294780d910607850e91f3a066561bbbce03d1aaf

2 years agoFix messageview_date_format on Windows
Jonathan Boeing [Sun, 12 Sep 2021 10:09:55 +0000 (03:09 -0700)]
Fix messageview_date_format on Windows

Bug 4535 'Setting msgview_date_format=1 does not work'

Call procheader_date_get_localtime() for Windows as well.

Also fix deprecation warning for g_time_zone_new()

2 years agoFix CID 1491213, 1491253, 1491103 and 1491189: resource leaks (if
wwp [Sun, 12 Sep 2021 12:16:03 +0000 (14:16 +0200)]
Fix CID 149121314912531491103 and 1491189: resource leaks (if
g_locale_from_utf8() returns an empty string, still to free).

2 years agoFix CID 141151: coverity scared because we're testing of pointers that can
wwp [Sun, 12 Sep 2021 11:53:05 +0000 (13:53 +0200)]
Fix CID 141151: coverity scared because we're testing of pointers that can
never be null (from gtk_entry_get_text()).

2 years agoFix CID 1491070: resource leak. Use a static GString to feed cmd.mailto
wwp [Sun, 12 Sep 2021 11:40:06 +0000 (13:40 +0200)]
Fix CID 1491070: resource leak. Use a static GString to feed cmd.mailto
instead of a dynamically allocated struct that will never be freed.

2 years agoFix CID 1491332: resource leaks (3).
wwp [Sun, 12 Sep 2021 10:36:34 +0000 (12:36 +0200)]
Fix CID 1491332: resource leaks (3).

2 years agomatch glib allocate and free functions
Jonathan Boeing [Sun, 12 Sep 2021 04:28:13 +0000 (21:28 -0700)]
match glib allocate and free functions

fix allocate/free mismatches and switch to glib functions