Paul [Fri, 29 Jun 2018 17:06:48 +0000 (18:06 +0100)]
fix memory leak, and seasoned to suit some tastes
Paul [Fri, 29 Jun 2018 14:38:33 +0000 (15:38 +0100)]
use TRUE/FALSE instead of 1/0
Paul [Fri, 29 Jun 2018 11:51:24 +0000 (12:51 +0100)]
when a return-receipt request is sent to an unknown addr, make the user choose which acc to send from
Paul [Fri, 29 Jun 2018 11:02:22 +0000 (12:02 +0100)]
vCalendar: Skip whitespace chars at the beginning of ics stream
patch by Avinash Sonawane
Andrej Kacian [Tue, 26 Jun 2018 16:21:56 +0000 (18:21 +0200)]
Fix build for Windows, plus some missing symbols in claws.def files.
Patches by Abhay S. Kushwaha.
Andrej Kacian [Tue, 26 Jun 2018 16:20:26 +0000 (18:20 +0200)]
Fix some variable type mismatches in ldapsvr_connect() on Windows.
Holger Berndt [Mon, 25 Jun 2018 21:22:26 +0000 (23:22 +0200)]
GData plugin: Request interactive auth only in case of auth issues
At the same time, make (now potentially ignored) errors more visible
in the status bar in the same way as background mail fetching errors
are reported.
Fixes bug #3754
Modified version of the patch by Viacheslav Gagara on that bug report.
Holger Berndt [Sun, 24 Jun 2018 14:16:46 +0000 (16:16 +0200)]
GData plugin: Only allow one interactive auth session at a time
Paul [Fri, 22 Jun 2018 09:55:02 +0000 (10:55 +0100)]
strip whitespace from subscribed URLs
Paul [Thu, 21 Jun 2018 09:54:11 +0000 (10:54 +0100)]
fix bug, 'MDN mail-accountname leak'
always use whatever is in the To header for the From header when sending
Return Receipts
Ricardo Mones [Tue, 19 Jun 2018 09:12:02 +0000 (11:12 +0200)]
Default mode URL should be escaped before using it
Andrej Kacian [Sun, 17 Jun 2018 13:19:20 +0000 (15:19 +0200)]
Fix 'Invalid PrefType for GtkEntry' warning for account proxy_pass.
Also remove P_PASSWORD as valid PrefType in prefs_set_data_from_entry().
Andrej Kacian [Sun, 17 Jun 2018 11:14:58 +0000 (13:14 +0200)]
Clone also proxy-related prefs in account_clone().
wwp [Tue, 12 Jun 2018 09:27:32 +0000 (11:27 +0200)]
Include Resent-From and Resent-To in Any/All header(s) (in addressbook) matcher rules.
wwp [Tue, 12 Jun 2018 08:52:12 +0000 (10:52 +0200)]
Clean up and unfold more standard headers (Bcc, Reply-To, Sender,
Resent-From and Resent-To).
wwp [Tue, 12 Jun 2018 08:26:38 +0000 (10:26 +0200)]
Properly highlight the whole email address in Resent-From and Resent-To
headers.
Michael Rasmussen [Mon, 11 Jun 2018 20:46:32 +0000 (22:46 +0200)]
Fix a possible memory leak
Signed-off-by: Michael Rasmussen <mir@datanom.net>
Andrej Kacian [Mon, 11 Jun 2018 19:17:07 +0000 (21:17 +0200)]
Fix memory corruption introduced in
d28d62772.
wwp [Mon, 11 Jun 2018 17:12:20 +0000 (19:12 +0200)]
Reduce scope of few variables.
wwp [Mon, 11 Jun 2018 11:36:12 +0000 (13:36 +0200)]
Update copyright in file headers.
Make use of GLib API for few file operations.
wwp [Mon, 11 Jun 2018 11:18:34 +0000 (13:18 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Ricardo Mones [Mon, 11 Jun 2018 10:31:29 +0000 (12:31 +0200)]
Fix CID#
1436912: Dereferencing null pointer "msginfo->folder"
wwp [Mon, 11 Jun 2018 09:21:09 +0000 (11:21 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Paul [Mon, 11 Jun 2018 09:17:31 +0000 (10:17 +0100)]
two small fixes to text in label and tooltip
Paul [Mon, 11 Jun 2018 09:16:54 +0000 (10:16 +0100)]
move 'Proxy' page from Other/ to Mail Handling/
wwp [Mon, 11 Jun 2018 09:03:29 +0000 (11:03 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Andrej Kacian [Mon, 11 Jun 2018 08:46:11 +0000 (10:46 +0200)]
Corrected copyright header in proxy.[ch]
wwp [Mon, 11 Jun 2018 08:02:37 +0000 (10:02 +0200)]
Remove un-necessary test, msginfo can't be null here, solves CID#
1436912.
wwp [Mon, 11 Jun 2018 07:32:50 +0000 (09:32 +0200)]
Fix use of uninitialized pointer, CID#
1436911.
Andrej Kacian [Sun, 10 Jun 2018 21:09:18 +0000 (23:09 +0200)]
Fixed an off-by-one buffer overflow in proxy.c.
Andrej Kacian [Sun, 10 Jun 2018 13:15:49 +0000 (15:15 +0200)]
Fix up POTFILES.in to match previous commit (
d28d62772).
Andrej Kacian [Fri, 18 May 2018 18:27:52 +0000 (20:27 +0200)]
Added SOCKS proxy support.
Based on UI and network code from LibSylph/Sylpheed, rewritten
to use getaddrinfo(), fixed some small bugs in handling errors.
Added connect wrappers for etpan IMAP and NNTP, as well as for
anything Session-based (POP3, SMTP, Managesieve).
Adds support for global, as well as per-account proxy servers.
Original patch by Charles Lehner <cel at celehner com>, from
bug #2244.
Paul [Sun, 10 Jun 2018 10:23:51 +0000 (11:23 +0100)]
when changing sort_key by clicking column header, preserve sort_type
Andrej Kacian [Sat, 9 Jun 2018 22:38:42 +0000 (00:38 +0200)]
Fix a buffer overflow in password encryption, and allow arbitrary password length.
Fixes bug #4033 - Claws Mail crashes [malloc(): memory
corruption] while trying to save account password greater
than 136 chars
Paul [Sat, 9 Jun 2018 11:12:32 +0000 (12:12 +0100)]
fix bug where 'sort_type' is lost when changing 'sort_key' from /View/sort
the bug was apparent with a descending sort. changing the sort_key
always set it to ascending
wwp [Thu, 7 Jun 2018 11:06:58 +0000 (13:06 +0200)]
Make use of all signature separators defined in accounts instead
of just the hardcoded standard one we use.
wwp [Wed, 6 Jun 2018 19:16:21 +0000 (21:16 +0200)]
Honor quote_chars from prefs instead of hard-coding "> ".
Andrej Kacian [Fri, 1 Jun 2018 06:01:05 +0000 (08:01 +0200)]
Fix HTML <hX> header handling.
Fix one-by-off error in detection of the end tag,
and add an extra newline at the beginning to make
the heading stand out visually.
wwp [Mon, 28 May 2018 15:44:59 +0000 (17:44 +0200)]
Code cleanup around glib version check (2.28 minimum).
wwp [Mon, 28 May 2018 15:17:05 +0000 (17:17 +0200)]
Dynamically allocate interface_vtable.
wwp [Mon, 28 May 2018 14:45:47 +0000 (16:45 +0200)]
Properly initialize GDBusInterfaceVTable's private member 'padding' (void*[8]).
Ricardo Mones [Mon, 28 May 2018 12:04:32 +0000 (14:04 +0200)]
Fix warning: missing braces around initializer
Ricardo Mones [Mon, 28 May 2018 12:03:57 +0000 (14:03 +0200)]
Fix warning: excess elements in struct initializer
Paul [Sat, 26 May 2018 10:48:08 +0000 (11:48 +0100)]
fix gcc8 stringop-overflow warning
Paul [Sat, 26 May 2018 10:21:19 +0000 (11:21 +0100)]
fix bug #4023, 'Fix some small issues'
* src/common/plugin.c: Remove redundant 'const' qualifier
* src/jpilot.c: Remove redundant parentheses
* src/mbox.c: Likewise
* src/procmsg.c: Use fabs instead of abs for 'double' arg
* src/ textview.c: Declare 'shortcut' only if not GENERIC_UMPC
* src/toolbar.c: Declare 'toolbar_reply_menu_cb()' and
'toolbar_delete_dup_menu_cb' only if not GENERIC_UMPC
Patch by Avinash Sonawane
wwp [Fri, 25 May 2018 17:01:50 +0000 (19:01 +0200)]
Updates to the French translation.
wwp [Fri, 25 May 2018 07:55:34 +0000 (09:55 +0200)]
Fix missing initializers, taking for reference GLib 2.28 (with support
for up to 2.56) and Python 2.4 (with support for up to 3.6).
wwp [Thu, 24 May 2018 15:44:38 +0000 (17:44 +0200)]
Fix previous commit.
wwp [Thu, 24 May 2018 15:39:03 +0000 (17:39 +0200)]
Since we depend on GLib 2.28, make real use of GList/GSList's _free_full
functions. Remove unused list freeing functions.
wwp [Thu, 24 May 2018 10:24:05 +0000 (12:24 +0200)]
Revert again support for gdata 0.6.4.
Paul [Wed, 23 May 2018 17:28:55 +0000 (18:28 +0100)]
update UI copyright year
Paul [Wed, 23 May 2018 17:10:46 +0000 (18:10 +0100)]
fix quoting in reply to format=flowed message
wwp [Wed, 23 May 2018 06:01:14 +0000 (08:01 +0200)]
Claws Mail does support gdata 0.6.4.
wwp [Tue, 22 May 2018 21:05:29 +0000 (23:05 +0200)]
Update app name in header cartouche and other places, correct
copyrights. Base patch by Abhay S. Kushwaha, with few additions
and slight changes.
wwp [Tue, 22 May 2018 17:30:08 +0000 (19:30 +0200)]
Fix more unchecked return values reported by Coverity:
1434282,
1434283,
1434284
wwp [Tue, 22 May 2018 17:12:36 +0000 (19:12 +0200)]
Fix few unchecked return values reported by Coverity:
1434187,
1434189,
1434192,
1434193,
1434195,
1434196,
1434198,
1434200,
1434202,
1434203
And few more. Change few silent returns into debug ones (cm_return_if_fail).
Paul [Tue, 22 May 2018 10:21:58 +0000 (11:21 +0100)]
fix syntax error in man page
List syntax error. This means .IP, .TP or .RS/.RE markup is garbled.
Common causes include .TP just before a section header, .TP entries
with tags but no bodies, and mandoc lists with no trailing .El.
These confuse doclifter, and may also mess up stricter man-page
browsers like Xman and Rosetta.
Patch by Eric S. Raymond
Ricardo Mones [Wed, 16 May 2018 22:19:24 +0000 (00:19 +0200)]
Remove another colon
Ricardo Mones [Wed, 16 May 2018 22:15:37 +0000 (00:15 +0200)]
Update lists of contributors
Michael Schwendt [Tue, 13 Mar 2018 20:03:46 +0000 (21:03 +0100)]
Fix bug 3895: Port from libnm-util/libnm-glib to libnm
Paul [Wed, 16 May 2018 14:31:03 +0000 (15:31 +0100)]
when using hide_timezone, convert time to UTC
Paul [Tue, 15 May 2018 10:40:52 +0000 (11:40 +0100)]
force explicit use of --disable-gnutls if gnutls support is not required
Paul [Tue, 15 May 2018 08:59:20 +0000 (09:59 +0100)]
require nettle, following removal of libcrypt from glibc
based on the fedora patch, thanks!
wwp [Wed, 9 May 2018 07:47:02 +0000 (09:47 +0200)]
Revert last leak fix.
wwp [Wed, 9 May 2018 06:50:26 +0000 (08:50 +0200)]
Fix a leak.
Andrej Kacian [Tue, 8 May 2018 14:54:53 +0000 (16:54 +0200)]
Fix crash in quicksearch keypress handling.
The fourth argument to g_signal_emit_by_name() in this case
is not the signal user data, but a pointer where to store the
return value.
wwp [Tue, 8 May 2018 06:54:16 +0000 (08:54 +0200)]
Force initialization of buffer (fixes a valgrind case where buf is
used uninitialized).
wwp [Mon, 7 May 2018 17:00:50 +0000 (19:00 +0200)]
Fix a memory leak in quicksearch code.
wwp [Mon, 7 May 2018 11:11:26 +0000 (13:11 +0200)]
Fix wrong type for layout_mode var in struct.
wwp [Sun, 6 May 2018 14:02:43 +0000 (16:02 +0200)]
Make Claws Mail conservative about color labels: ask for confirmation
when user clears or override existing color labels to messages.
Confirmation dialog is discardable.
wwp [Sun, 6 May 2018 13:48:39 +0000 (15:48 +0200)]
Update French translation.
Ricardo Mones [Sun, 6 May 2018 09:37:44 +0000 (11:37 +0200)]
Fix warning: ‘struct sockaddr’ declared inside…
By including our utils.h instead of spamassassin homonymous file.
In file included from ../../../src/procmsg.h:32:0,
from spamassassin.c:42:
./utils.h:124:47: warning: ‘struct sockaddr’ declared inside parameter list will not be visible outside of this definition or declaration
int timeout_connect (int sockfd, const struct sockaddr *serv_addr, size_t addrlen);
^~~~~~~~
wwp [Sat, 5 May 2018 21:56:13 +0000 (23:56 +0200)]
Save and reuse Actions input/output dialog size.
Ricardo Mones [Sat, 5 May 2018 19:59:55 +0000 (21:59 +0200)]
Fix a couple of unused variable warnings
- libspamc.c:491:19: warning: variable ‘family’ set but not used
(used in a #ifdef block, fix by surrounding by same #ifdef)
- libspamc.c:1911:35: warning: unused variable ‘addrp’
(used in a commented code block, fix by commenting also declaration)
wwp [Sat, 5 May 2018 12:21:53 +0000 (14:21 +0200)]
Really ask for confirmation when marking *all* messages as read or
unread from the message list (as it's done from the folder context
menu). This confirmation dialog is still discardable and still
obeys to the option "Confirm before marking all messages in a folder
as read or unread" in preferences.
A bit of code factorization.
wwp [Sat, 5 May 2018 12:08:18 +0000 (14:08 +0200)]
Fix French translation (unexpected accelerator used in dialog title).
wwp [Sat, 5 May 2018 11:46:36 +0000 (13:46 +0200)]
Save few warnings around mistyped uses of g_list_length().
wwp [Sat, 5 May 2018 10:54:29 +0000 (12:54 +0200)]
Correct the label of the 'confirm before marking all messages in a
folder as read' option: it's about marking all as read or UNread.
wwp [Sat, 5 May 2018 07:35:11 +0000 (09:35 +0200)]
Use a proper CharSet enum value for uninitialized state of static vars,
reindent tables for increasing readability.
wwp [Fri, 4 May 2018 17:11:14 +0000 (19:11 +0200)]
One more fix for GENERIC_UMPC: summary menu entries list differ.
wwp [Fri, 4 May 2018 13:33:24 +0000 (15:33 +0200)]
Fix compilation using GENERIC_UMPC.
wwp [Fri, 4 May 2018 11:35:56 +0000 (13:35 +0200)]
Fix code compilation when configure --enable-generic-umpc code has been used.
wwp [Fri, 4 May 2018 07:04:04 +0000 (09:04 +0200)]
Don't manage account list focus state when closing an account edit window,
when this window has been called from main window's "Preferences for
current account" menu item.
Closes bug #4022: Closing "Account Preferences" window opens "Edit Accounts"
window if "Edit Accounts" window has been opened before at least once.
Andrej Kacian [Thu, 3 May 2018 11:05:46 +0000 (13:05 +0200)]
Fix memory handling around SieveEditorPage.
wwp [Thu, 3 May 2018 08:44:02 +0000 (10:44 +0200)]
Fix some plugins' code indentation.
wwp [Thu, 3 May 2018 08:15:06 +0000 (10:15 +0200)]
Reindent lists and arrays.
Andrej Kacian [Fri, 27 Apr 2018 15:00:37 +0000 (17:00 +0200)]
Ignore the expander "hot spots" in folderview for childless folders.
wwp [Wed, 25 Apr 2018 13:48:12 +0000 (15:48 +0200)]
Fix sensitivity of the main window's 'View/Message part/View as text' entry
according to the selected mime part.
Ricardo Mones [Wed, 25 Apr 2018 13:40:42 +0000 (15:40 +0200)]
Fix array type to match items
Fixes warnings:
• …from log.c:25: /usr/include/glib-2.0/glib/gmacros.h:284:14: warning:
initialization makes pointer from integer without a cast
• log.c:189:29: warning: return makes integer from pointer without a cast
wwp [Mon, 23 Apr 2018 16:50:40 +0000 (18:50 +0200)]
Don't add "Go to last error" to filtering log window's context menu.
wwp [Wed, 18 Apr 2018 16:24:06 +0000 (18:24 +0200)]
Clean-up in comments (The Commit Of The Year).
Andrej Kacian [Wed, 18 Apr 2018 16:19:28 +0000 (18:19 +0200)]
Fix two missed return values in compose_write_to_file() from commit
e9f610a4f.
Thanks to wwp for finding the issue!
Andrej Kacian [Tue, 17 Apr 2018 19:17:34 +0000 (21:17 +0200)]
Fix unwanted IMAP connections on startup caused by processing rules.
The culprit was a combination of folder_item_prefs_clear()
setting item->enable_processing to TRUE even though default
value should be FALSE, and initial_processing() not skipping
over root folders, which do not have this variable later set
to correct default value in xml_to_folder_item().
Closes bug #3993: Claws Mail connects to IMAP server when it should not
Andrej Kacian [Fri, 13 Apr 2018 18:25:37 +0000 (20:25 +0200)]
Fix for
e9f610a4f for the rare cases the privacy system has no error string ready.
Andrej Kacian [Tue, 10 Apr 2018 17:46:01 +0000 (19:46 +0200)]
Rework and simplify how compose_queue() return values are handled
Also closes bug #3960 - Sends unencrypted emails when encryption fails
because we now return from compose_queue() with an error when
that happens, instead of ignoring it.
wwp [Fri, 13 Apr 2018 10:32:47 +0000 (12:32 +0200)]
ClamAV plugin: manage read errors (fixes CID #
1220483).
wwp [Fri, 13 Apr 2018 10:15:24 +0000 (12:15 +0200)]
Fix another leak in smime plugin (CID #
1220437).
wwp [Thu, 12 Apr 2018 19:37:21 +0000 (21:37 +0200)]
Spamassassin plug-in: add support for compression (server must have
compression enabled, local spamc too).
wwp [Thu, 12 Apr 2018 15:35:04 +0000 (17:35 +0200)]
Disable SSLv3 in libspamc.c (patch from Debian spamassassin package).
wwp [Wed, 11 Apr 2018 20:25:55 +0000 (22:25 +0200)]
Fix sensitivity of few preferences widgets of the SA plug-in.