claws.git
7 years agoRemove more line breaks from g_warning()
Ricardo Mones [Fri, 29 Jul 2016 18:21:05 +0000 (20:21 +0200)]
Remove more line breaks from g_warning()

7 years agoFix some debug messages and update headers
Ricardo Mones [Thu, 28 Jul 2016 22:59:11 +0000 (00:59 +0200)]
Fix some debug messages and update headers

7 years agoOnly enable "New Book" context menu entry for internal addressbook.
Andrej Kacian [Thu, 28 Jul 2016 20:57:23 +0000 (22:57 +0200)]
Only enable "New Book" context menu entry for internal addressbook.

It was confusing to have it active on e.g. LDAP server interface,
when it really only adds a new XML addressbook.

Also, do not enable the "New" button when right-clicking the XML
addressbook interface line, as the button doesn't do anything
useful for interfaces.

7 years agoFix sensitivity of "Delete book" menu entries in addressbook.
Andrej Kacian [Thu, 28 Jul 2016 20:54:31 +0000 (22:54 +0200)]
Fix sensitivity of "Delete book" menu entries in addressbook.

Now it's possible to delete a read-only address datasource
via popup menu.

7 years agoRemove also unused struct member
Ricardo Mones [Thu, 28 Jul 2016 11:55:09 +0000 (13:55 +0200)]
Remove also unused struct member

7 years agoRemove the (now unused) master_passphrase_change plugin function.
Andrej Kacian [Thu, 28 Jul 2016 11:12:03 +0000 (13:12 +0200)]
Remove the (now unused) master_passphrase_change plugin function.

7 years agoDo not run config update routine on first run.
Andrej Kacian [Thu, 28 Jul 2016 09:38:32 +0000 (11:38 +0200)]
Do not run config update routine on first run.

The newly created configuration is already up to date.

7 years agoImprove label
Paul [Wed, 27 Jul 2016 21:05:20 +0000 (22:05 +0100)]
Improve label

7 years agoHandle configuration versions from the future
Ricardo Mones [Wed, 27 Jul 2016 14:46:22 +0000 (16:46 +0200)]
Handle configuration versions from the future

7 years agoEmbarrassing typo fix in rssyl_subscribe().
Andrej Kacian [Sat, 23 Jul 2016 21:02:55 +0000 (23:02 +0200)]
Embarrassing typo fix in rssyl_subscribe().

7 years agoAdded working_directory parameter to execute_command_line()
Andrej Kacian [Sat, 23 Jul 2016 20:41:04 +0000 (22:41 +0200)]
Added working_directory parameter to execute_command_line()

It gets passed as a first argument to g_spawn_sync/async.
Mostly NULL, since that's what was passed until now, but
bsfilter plugin on Windows needs to change to installation
directory (startup_dir).

7 years agoUpdated plugins' claws.def files for win32 build.
Andrej Kacian [Sat, 23 Jul 2016 19:40:02 +0000 (21:40 +0200)]
Updated plugins' claws.def files for win32 build.

7 years agoreplace another: "pixel(s)" -> "pixels"
Paul [Sat, 23 Jul 2016 14:20:20 +0000 (15:20 +0100)]
replace another: "pixel(s)" -> "pixels"

7 years agoanother one (see last commit)
Paul [Sat, 23 Jul 2016 14:17:30 +0000 (15:17 +0100)]
another one (see last commit)

7 years agostandardise singlular/plural mix on labels
Paul [Sat, 23 Jul 2016 13:57:07 +0000 (14:57 +0100)]
standardise singlular/plural mix on labels

7 years agoUse current style of preferences for time fields
Ricardo Mones [Sat, 23 Jul 2016 11:09:49 +0000 (13:09 +0200)]
Use current style of preferences for time fields

7 years agoMake label more readable
Ricardo Mones [Sat, 23 Jul 2016 10:13:50 +0000 (12:13 +0200)]
Make label more readable

7 years agoUpdate copyright headers for previous commit
Ricardo Mones [Sat, 23 Jul 2016 01:00:00 +0000 (03:00 +0200)]
Update copyright headers for previous commit

7 years agoFix bug #2176: autochk_interval granularity is low
Ricardo Mones [Sat, 23 Jul 2016 00:59:21 +0000 (02:59 +0200)]
Fix bug #2176: autochk_interval granularity is low

This also fixes Debian bug “Please increase mail auto check period.”
See: https://bugs.debian.org/712758

Former bug wanted sub-minute granularity and latter the opposite: just
check a few times a day, so this allows user to specify also hours and
seconds in addition to existing minutes to address both requests.

Checking range was from 1 minute to 1 hour 40 minutes and now is
extended to a range from 10 seconds to 100 hours minus one second.

Default for new configurations is preserved (10 minutes).

Configuration version is raised to 2 for migrating existing values
from minutes to seconds.

7 years agoRemove last outside gtk_cmclist_freeze/thaw for summaryview&folderview ctrees.
Andrej Kacian [Fri, 22 Jul 2016 18:46:54 +0000 (20:46 +0200)]
Remove last outside gtk_cmclist_freeze/thaw for summaryview&folderview ctrees.

More code maintenance to isolate summaryview and folderview
widgets' internals behind an API.

7 years agoremove unnecessary 'Encoding' frame
Paul [Fri, 22 Jul 2016 17:08:00 +0000 (18:08 +0100)]
remove unnecessary 'Encoding' frame

7 years agoRemove unneeded 'Other' from View/Go to/Other folder...
Paul [Fri, 22 Jul 2016 16:56:20 +0000 (17:56 +0100)]
Remove unneeded 'Other' from View/Go to/Other folder...

7 years agoReorganise send options a bit
Ricardo Mones [Fri, 22 Jul 2016 12:14:37 +0000 (14:14 +0200)]
Reorganise send options a bit

Also remove '(Recommended)' from selector, as that's already
mentioned in the tooltip.

7 years agoFurther improve API isolation of folderview.
Andrej Kacian [Thu, 21 Jul 2016 20:32:37 +0000 (22:32 +0200)]
Further improve API isolation of folderview.

This commit gets rid of all outside access to "opened" and
"selected" struct members, and lot of outside access to
"ctree" member.

Additional work still needed. :)

7 years agoUse folderview_grab_focus() outside of folderview.c.
Andrej Kacian [Thu, 21 Jul 2016 10:12:40 +0000 (12:12 +0200)]
Use folderview_grab_focus() outside of folderview.c.

7 years agoUse folderview_freeze/thaw() functions outside of folderview.c.
Andrej Kacian [Thu, 21 Jul 2016 10:02:30 +0000 (12:02 +0200)]
Use folderview_freeze/thaw() functions outside of folderview.c.

These are modeled after summary_freeze/thaw().

7 years agoMake exit_claws() use folderview API and not reach inside _FolderView struct.
Andrej Kacian [Thu, 21 Jul 2016 09:54:36 +0000 (11:54 +0200)]
Make exit_claws() use folderview API and not reach inside _FolderView struct.

7 years agoRemove unused GtkWidget* argument in stock_pix* functions.
Andrej Kacian [Wed, 20 Jul 2016 21:46:39 +0000 (23:46 +0200)]
Remove unused GtkWidget* argument in stock_pix* functions.

stock_pixmap_widget()
stock_pixmap_widget_with_overlay()
stock_pixbuf_gdk()

7 years agoRestore also size of toolbar arrows
Ricardo Mones [Wed, 20 Jul 2016 17:01:33 +0000 (19:01 +0200)]
Restore also size of toolbar arrows

Thanks Paul for pointing those out!

7 years agoRestore size of toolbar trash button
Ricardo Mones [Wed, 20 Jul 2016 10:16:19 +0000 (12:16 +0200)]
Restore size of toolbar trash button

Default is 24x24 for toolbar buttons but this was unintentionally
shrinked more than a decade ago.

7 years agoFix warning about what directory cannot be open
Ricardo Mones [Wed, 20 Jul 2016 07:13:59 +0000 (09:13 +0200)]
Fix warning about what directory cannot be open

7 years agoFix up previous commit.
Andrej Kacian [Tue, 19 Jul 2016 09:48:17 +0000 (11:48 +0200)]
Fix up previous commit.

Move the update_fonts check earlier, before the last_*font
pointers get modified.

7 years agoDo not repopulate folderview after account prefs save.
Andrej Kacian [Tue, 19 Jul 2016 09:09:22 +0000 (11:09 +0200)]
Do not repopulate folderview after account prefs save.

The only reason to repopulate is if user's chosen fonts
change, and that cannot happen in account prefs.

7 years agoRemove APOP and RPOP also from account prefs.
Andrej Kacian [Mon, 18 Jul 2016 19:23:52 +0000 (21:23 +0200)]
Remove APOP and RPOP also from account prefs.

This fixes up previous commit, 358e811.

7 years agoRemove obsolete A_APOP and A_RPOP account protocols.
Andrej Kacian [Fri, 15 Jul 2016 09:56:22 +0000 (11:56 +0200)]
Remove obsolete A_APOP and A_RPOP account protocols.

CLAWS_CONFIG_VERSION bumped to 1.

7 years agoAdded config versioning.
Andrej Kacian [Thu, 14 Jul 2016 09:55:54 +0000 (11:55 +0200)]
Added config versioning.

This allows us to change meaning of existing preferences,
without losing or mangling user data. Controlled by a common
pref "config_version", which is checked on startup after
reading all configuration. If this version is lower than
what is defined in CLAWS_CONFIG_VERSION, an upgrade is done
incrementally, from one version to the next and to the next,
so that all affected preferences are adjusted.

7 years agoUpdate lists of authors
Ricardo Mones [Thu, 14 Jul 2016 09:59:22 +0000 (11:59 +0200)]
Update lists of authors

7 years agoFix bug #3573: Out of bounds read in macro LBREAK_IF_REQUIRED
Ricardo Mones [Thu, 14 Jul 2016 09:52:43 +0000 (11:52 +0200)]
Fix bug #3573: Out of bounds read in macro LBREAK_IF_REQUIRED

Thanks Hanno Boeck for the patch!

7 years agoWhen generating a PGP keypair, only ask for passphrase with gpg1.
Andrej Kacian [Wed, 13 Jul 2016 19:50:52 +0000 (21:50 +0200)]
When generating a PGP keypair, only ask for passphrase with gpg1.

Also erase all copies of an entered passphrase from memory
when done. Closes bug #3658.

7 years agoSimplify handling of gpg_ask_create_key pref.
Andrej Kacian [Mon, 11 Jul 2016 22:13:21 +0000 (00:13 +0200)]
Simplify handling of gpg_ask_create_key pref.

7 years agoFix filesel dialog with filter for Win32.
Andrej Kacian [Mon, 11 Jul 2016 21:53:34 +0000 (23:53 +0200)]
Fix filesel dialog with filter for Win32.

g_utf8_to_utf16() always stops on first null byte,
so we have to construct the "filter\0filter\0\0"
string for GetOpenFileName() manually.

7 years agoAdded --batch option to manual gpg executable calls.
Andrej Kacian [Sun, 10 Jul 2016 12:57:16 +0000 (14:57 +0200)]
Added --batch option to manual gpg executable calls.

This, together with --no-tty, is to make these calls
really non-interactive, and helps against the calls
hanging on Windows occasionally.

7 years agoMade exporting GPG key to keyserver work on Windows.
Andrej Kacian [Sun, 10 Jul 2016 12:55:48 +0000 (14:55 +0200)]
Made exporting GPG key to keyserver work on Windows.

7 years agoUpdated claws.def file for win32 build of notification plugin.
Andrej Kacian [Thu, 7 Jul 2016 16:24:41 +0000 (18:24 +0200)]
Updated claws.def file for win32 build of notification plugin.

7 years agoSync Spanish manual
Ricardo Mones [Tue, 5 Jul 2016 18:58:26 +0000 (20:58 +0200)]
Sync Spanish manual

7 years agoFix #3653: document plugin path configuration
Ricardo Mones [Tue, 5 Jul 2016 13:01:46 +0000 (15:01 +0200)]
Fix #3653: document plugin path configuration

7 years agoUpdate Spanish manual
Ricardo Mones [Mon, 4 Jul 2016 20:22:56 +0000 (22:22 +0200)]
Update Spanish manual

7 years agoAdd forgotten block delimiters
Ricardo Mones [Mon, 4 Jul 2016 16:45:48 +0000 (18:45 +0200)]
Add forgotten block delimiters

Thanks Paul for noticing!

7 years agofix bug 2518, ' "Reply-All" message from NNTP-account does not contain CC'ed correspo...
Paul [Mon, 4 Jul 2016 14:58:06 +0000 (15:58 +0100)]
fix bug 2518, ' "Reply-All" message from NNTP-account does not contain CC'ed correspondents'

7 years agoinclude Reply-To value when using 'reply to all'
Paul [Mon, 4 Jul 2016 11:21:29 +0000 (12:21 +0100)]
include Reply-To value when using 'reply to all'

7 years agomake 'next_on_delete' hidden pref apply after trashing or moving a msg in addition...
Paul [Mon, 4 Jul 2016 10:02:58 +0000 (11:02 +0100)]
make 'next_on_delete' hidden pref apply after trashing or moving a msg in addition to deleting a msg

fixes bug #3600.
document this hidden pref also

7 years agoWarn on unsuccessful gpgme_set_engine_info calls
Ricardo Mones [Mon, 4 Jul 2016 09:00:35 +0000 (11:00 +0200)]
Warn on unsuccessful gpgme_set_engine_info calls

7 years agomodify 61f7c3c5e to catch another hardcoded gpg call
Paul [Mon, 4 Jul 2016 08:25:46 +0000 (09:25 +0100)]
modify 61f7c3c5e to catch another hardcoded gpg call

7 years agonotification plug-in: skip SMTP-only accounts when building the
wwp [Sun, 3 Jul 2016 08:40:32 +0000 (10:40 +0200)]
notification plug-in: skip SMTP-only accounts when building the
'Get mail from account' menu.

7 years agoRevert "Place dialogs on center of main window."
Pawel Pekala [Sat, 2 Jul 2016 18:12:02 +0000 (20:12 +0200)]
Revert "Place dialogs on center of main window."

This reverts commit cb67730a260a491ae380fd928d8ca673200972b0.

7 years agoPlace dialogs on center of main window. Most window managers place
Pawel Pekala [Sat, 2 Jul 2016 16:05:14 +0000 (18:05 +0200)]
Place dialogs on center of main window. Most window managers place
these dialogs in some weird positions making interacting with
them unwieldy. Windows is biggest offender here putting things
around left top corner of the screen.

7 years agoAdd 'Get mail from account..' to notification plugin's trayicon menu.
wwp [Thu, 30 Jun 2016 10:01:54 +0000 (12:01 +0200)]
Add  'Get mail from account..' to notification plugin's trayicon menu.

7 years agoAllocate quoted-printable output buffer on heap
Charles Lehner [Mon, 27 Jun 2016 17:52:57 +0000 (13:52 -0400)]
Allocate quoted-printable output buffer on heap

7 years agoHandle ical lines longer than 256 bytes
Charles Lehner [Mon, 27 Jun 2016 14:28:41 +0000 (10:28 -0400)]
Handle ical lines longer than 256 bytes

7 years agoIndent html in blockquotes
Charles Lehner [Fri, 24 Jun 2016 22:42:05 +0000 (18:42 -0400)]
Indent html in blockquotes

7 years agoLine break after <dd>
Charles Lehner [Tue, 14 Jun 2016 16:52:54 +0000 (12:52 -0400)]
Line break after <dd>

7 years agoFix bug #3652 “warning: ordered comparison of pointer…”
Ricardo Mones [Thu, 16 Jun 2016 14:28:54 +0000 (16:28 +0200)]
Fix bug #3652 “warning: ordered comparison of pointer…”

7 years agoImplement focused widget saving between iconify/deiconify events in
Pawel Pekala [Thu, 9 Jun 2016 18:59:37 +0000 (20:59 +0200)]
Implement focused widget saving between iconify/deiconify events in
trayicon notification. Without this focus is lost on deiconify and this
can be painful to keyboard users. This is similar to my old work on
trayicon plugin I've done in the past.

7 years agoFix python plugin test for BSD family, dlopen(3) on those
Pawel Pekala [Wed, 8 Jun 2016 20:16:13 +0000 (22:16 +0200)]
Fix python plugin test for BSD family, dlopen(3) on those
systems is part of libc library and linking to nonexistent
libdl will fail.

Tested on FreeBSD 11-Current, Debian 8

7 years agoInstall new script also
Ricardo Mones [Tue, 7 Jun 2016 14:20:20 +0000 (16:20 +0200)]
Install new script also

7 years agoAnd more documentation
Ricardo Mones [Tue, 7 Jun 2016 12:21:58 +0000 (14:21 +0200)]
And more documentation

7 years agoImprove script documentation
Ricardo Mones [Tue, 7 Jun 2016 11:54:29 +0000 (13:54 +0200)]
Improve script documentation

7 years agoFix phrasing, terminology and typos
Ricardo Mones [Tue, 7 Jun 2016 11:18:27 +0000 (13:18 +0200)]
Fix phrasing, terminology and typos

7 years agoAdd new action script for fixing threads
Ricardo Mones [Tue, 7 Jun 2016 10:59:43 +0000 (12:59 +0200)]
Add new action script for fixing threads

Many thanks to H.Merijn Brand for contributing it!

7 years agoUse Unicode, don't restrict ourselves to ASCII
Ricardo Mones [Thu, 2 Jun 2016 09:17:49 +0000 (11:17 +0200)]
Use Unicode, don't restrict ourselves to ASCII

7 years agoIndicate list items in html
Charles Lehner [Thu, 2 Jun 2016 00:37:02 +0000 (20:37 -0400)]
Indicate list items in html

7 years agoFixed calculation of timing.h timer for Windows.
Andrej Kacian [Mon, 30 May 2016 10:26:17 +0000 (12:26 +0200)]
Fixed calculation of timing.h timer for Windows.

7 years agoFix --select CLI option on Windows when selecting a particular message.
Andrej Kacian [Sat, 28 May 2016 17:54:51 +0000 (19:54 +0200)]
Fix --select CLI option on Windows when selecting a particular message.

7 years agoUse PBKDF2 to derive encryption key for passwords.
Andrej Kacian [Tue, 24 May 2016 16:29:37 +0000 (18:29 +0200)]
Use PBKDF2 to derive encryption key for passwords.

...instead of my previous hash-then-xor nonsense.

7 years agofix crash introduced in c7e1e0bbdf72269708a53075a4accecb61ebebe2
Paul [Tue, 24 May 2016 13:20:52 +0000 (14:20 +0100)]
fix crash introduced in c7e1e0bbdf72269708a53075a4accecb61ebebe2

7 years agoMoved getting random bytes into a separate get_random_bytes() function.
Andrej Kacian [Fri, 20 May 2016 09:38:32 +0000 (11:38 +0200)]
Moved getting random bytes into a separate get_random_bytes() function.

7 years agoRemove imap_use_trash account preference.
Andrej Kacian [Thu, 12 May 2016 08:03:39 +0000 (10:03 +0200)]
Remove imap_use_trash account preference.

Disabling this preference made deleting messages behave
incorrectly - they were marked for deletion regardless
of whether "delete" or "move to trash" was used, and
these actions were not executed immediately, regardless
of "immediate_execution" common preference.

7 years agoremove matcherrc.pre_names migration. 10 years later, we'll assume everyone has been...
Paul [Mon, 16 May 2016 16:02:53 +0000 (17:02 +0100)]
remove matcherrc.pre_names migration. 10 years later, we'll assume everyone has been migrated

7 years agoImprove plural handling for "Delete message" dialog.
Andrej Kacian [Fri, 6 May 2016 17:43:16 +0000 (19:43 +0200)]
Improve plural handling for "Delete message" dialog.

7 years agoFix typo in manual
Ricardo Mones [Tue, 3 May 2016 10:50:21 +0000 (12:50 +0200)]
Fix typo in manual

Thanks Charles Curley for noticing

7 years agoMade manual GPG key import work on Windows.
Andrej Kacian [Mon, 2 May 2016 19:29:12 +0000 (21:29 +0200)]
Made manual GPG key import work on Windows.

7 years agoAsk GpgME for path to gpg executable for manual key import.
Andrej Kacian [Mon, 2 May 2016 18:54:19 +0000 (20:54 +0200)]
Ask GpgME for path to gpg executable for manual key import.

7 years agoFix frequently ocurring typos :)
Ricardo Mones [Sun, 1 May 2016 14:56:18 +0000 (16:56 +0200)]
Fix frequently ocurring typos :)

7 years agoFix some typos in perl plugin's manpage
Ricardo Mones [Sun, 1 May 2016 14:51:10 +0000 (16:51 +0200)]
Fix some typos in perl plugin's manpage

7 years agoFix behavior in selecting PGP MIME signature on Windows.
Andrej Kacian [Thu, 28 Apr 2016 10:01:10 +0000 (12:01 +0200)]
Fix behavior in selecting PGP MIME signature on Windows.

With old argument order, gpgme_op_verify() returned "empty signature"
error on Windows, for reasons unknown.

7 years agoUse correct dir separator for "Scanning folder ..." in statusbar.
Andrej Kacian [Tue, 26 Apr 2016 08:21:22 +0000 (10:21 +0200)]
Use correct dir separator for "Scanning folder ..." in statusbar.

7 years agoMore fixes for the Windows native file choosers.
Andrej Kacian [Fri, 22 Apr 2016 18:04:02 +0000 (20:04 +0200)]
More fixes for the Windows native file choosers.

Filter string should be terminated with two nuls.
Save dialog did not show for message parts which have no
attachment name.

7 years agoDisallow folder names ending with a space on Windows.
Andrej Kacian [Fri, 22 Apr 2016 11:31:41 +0000 (13:31 +0200)]
Disallow folder names ending with a space on Windows.

Closes bug #2781.

7 years agoMake Windows native file/dir choosers work with non-ASCII characters.
Andrej Kacian [Fri, 22 Apr 2016 08:05:57 +0000 (10:05 +0200)]
Make Windows native file/dir choosers work with non-ASCII characters.

Also, make the save chooser supply the correct attachment
file name by default, just like the GTK+ one does.

8 years agoFix closing tag placement
Ricardo Mones [Mon, 18 Apr 2016 15:23:52 +0000 (17:23 +0200)]
Fix closing tag placement

Thanks Paul for noticing ;-)

8 years agoFix semantic error
Ricardo Mones [Mon, 18 Apr 2016 12:55:16 +0000 (14:55 +0200)]
Fix semantic error

Thanks Andrej for the quick review!

8 years agoSynchronize Spanish manual
Ricardo Mones [Mon, 18 Apr 2016 12:46:23 +0000 (14:46 +0200)]
Synchronize Spanish manual

8 years agoKeep current order and add the default value
Ricardo Mones [Mon, 18 Apr 2016 12:45:34 +0000 (14:45 +0200)]
Keep current order and add the default value

8 years agoDocument 'master_passphrase_pbkdf2_rounds' hidden preference.
Andrej Kacian [Mon, 18 Apr 2016 12:15:34 +0000 (14:15 +0200)]
Document 'master_passphrase_pbkdf2_rounds' hidden preference.

8 years agoUse native file and folder selection dialogs on Windows.
Andrej Kacian [Sat, 16 Apr 2016 16:04:31 +0000 (18:04 +0200)]
Use native file and folder selection dialogs on Windows.

This is done by compiling in src/gtk/w32_filesel.c instead of
filesel.c on Windows. The Makefile.am logic mirrors the one from
src/common/.

8 years agoShow duration of PBKDF2 computation in debug output.
Andrej Kacian [Mon, 11 Apr 2016 16:30:18 +0000 (18:30 +0200)]
Show duration of PBKDF2 computation in debug output.

8 years agoMake double-click open edit dialog also for addressbook datasources.
Andrej Kacian [Sat, 9 Apr 2016 22:57:15 +0000 (00:57 +0200)]
Make double-click open edit dialog also for addressbook datasources.

For example, LDAP servers.

8 years agoPrevent an unlikely crash during RSSyl feed properties save.
Andrej Kacian [Sat, 9 Apr 2016 16:06:26 +0000 (18:06 +0200)]
Prevent an unlikely crash during RSSyl feed properties save.

This is just to shut Coverity up, I don't think it could
ever crash this way.

8 years agoAddressbook now uses password store for LDAP passwords.
Andrej Kacian [Sat, 9 Apr 2016 16:03:01 +0000 (18:03 +0200)]
Addressbook now uses password store for LDAP passwords.

8 years agoRemove password from passwordstore when deleting a RSSyl feed.
Andrej Kacian [Sat, 9 Apr 2016 13:43:02 +0000 (15:43 +0200)]
Remove password from passwordstore when deleting a RSSyl feed.