Andrej Kacian [Fri, 31 Aug 2018 11:28:16 +0000 (13:28 +0200)]
Add parameter sanity checks to md5_hex_digest() and md5_hex_hmac().
Olivier Brunel [Wed, 27 Dec 2017 20:59:40 +0000 (21:59 +0100)]
Preserve flags & tags when re-editing a message
When re-editing a message, let's preserve its flags (color labels, etc)
and tags. Can be especially useful for those who use such things on queued
messages, and find themselves re-editing messages afterwards but before
actually sending them.
Olivier Brunel [Wed, 27 Dec 2017 20:53:17 +0000 (21:53 +0100)]
action: Keep selection set afterwards
Upon running (filtering) actions, the current selection was lost (due to
refreshing the current folder); Let's restore it.
Olivier Brunel [Wed, 2 Aug 2017 18:48:58 +0000 (20:48 +0200)]
Speed-up searches in References via "x"
Since commit
5c9f9e47 (in 2001!) the header "References" is actually
cached in MsgInfo, so searching it can be substantially faster if "x"
expands to 'references' instead of 'header "References"', much like with
'i' (messageid) or 'I' (inreplyto).
wwp [Thu, 30 Aug 2018 06:29:30 +0000 (08:29 +0200)]
Fix wrong logics leading to writing possibly broken config file,
patch by Olivier Brunel.
Ricardo Mones [Tue, 28 Aug 2018 10:54:43 +0000 (12:54 +0200)]
Restore Fancy entry in README, still in tarball ;)
Thanks Woody for noticing.
Paul [Mon, 27 Aug 2018 17:42:44 +0000 (18:42 +0100)]
fix lintian autotools-pkg-config-macro-not-cross-compilation-safe warning
see
https://lintian.debian.org/tags/autotools-pkg-config-macro-not-cross-compilation-safe.html
Ricardo Mones [Mon, 27 Aug 2018 16:43:08 +0000 (18:43 +0200)]
Update plugins in README
wwp [Sun, 26 Aug 2018 16:01:02 +0000 (18:01 +0200)]
Fix wrong test leading to dead code (and dead func), CID
1438531.
Paul [Sun, 26 Aug 2018 13:36:51 +0000 (14:36 +0100)]
always show the full version on the mainwindow regardless of --enable-maintainer-mode
Paul [Sun, 26 Aug 2018 11:21:52 +0000 (12:21 +0100)]
for release 3.17.1
Andrej Kacian [Sat, 25 Aug 2018 09:00:56 +0000 (11:00 +0200)]
Update vcalendar's claws.def file for Windows build after recent changes.
Thanks to Abhay S. Kushwaha.
Andrej Kacian [Sat, 25 Aug 2018 08:58:49 +0000 (10:58 +0200)]
Improve Left Arrow keypress handling for childless folders in folderview.
Based on patch by Abhay S. Kushwaha.
wwp [Fri, 24 Aug 2018 12:59:13 +0000 (14:59 +0200)]
Optimize (for speed) and factorize code related to marking folders
as read/unread recursively. A bit of code format fixing too.
Andrej Kacian [Fri, 24 Aug 2018 12:38:52 +0000 (14:38 +0200)]
Fix building manual PDF and PS formats when building outside of source dir.
Andrej Kacian [Fri, 24 Aug 2018 12:09:12 +0000 (14:09 +0200)]
Fix various plugins including generated .h files when building outside of source dir.
Andrej Kacian [Fri, 24 Aug 2018 11:48:38 +0000 (13:48 +0200)]
Fix configure version detection when building outside of srcdir.
Colin Leroy [Fri, 24 Aug 2018 11:51:32 +0000 (13:51 +0200)]
Better GUI (with calendar) for date filtering condition.
Colin Leroy [Fri, 24 Aug 2018 09:07:06 +0000 (11:07 +0200)]
Move time selector from vCalendar to gtkutils
Colin Leroy [Fri, 24 Aug 2018 08:17:27 +0000 (10:17 +0200)]
Filtering: simple GUI for date_after/before
Colin Leroy [Fri, 24 Aug 2018 07:58:09 +0000 (09:58 +0200)]
Filtering: add date_before and date_after
Colin Leroy [Thu, 23 Aug 2018 08:51:52 +0000 (10:51 +0200)]
Only handle GTK events when matcher test thread takes more than 0 seconds.
Andrej Kacian [Wed, 22 Aug 2018 13:00:58 +0000 (15:00 +0200)]
Add null pointer checks to pkcs5_pbkdf2().
Andrej Kacian [Tue, 21 Aug 2018 17:52:33 +0000 (19:52 +0200)]
Added null parameter checks in codeconv.c where appropriate.
Andrej Kacian [Tue, 21 Aug 2018 09:53:16 +0000 (11:53 +0200)]
Move the typedef for "u32" from utils.h to md5.h, since it is only used there.
Andrej Kacian [Tue, 21 Aug 2018 09:49:15 +0000 (11:49 +0200)]
Removed an unused #include from libfeed's parser.c.
wwp [Tue, 21 Aug 2018 08:21:11 +0000 (10:21 +0200)]
Fix missing check for a retrieving interval minimum value in
accounts prefs, don't use abbreviated units there and follow
the global prefs style.
wwp [Tue, 21 Aug 2018 08:20:05 +0000 (10:20 +0200)]
Fix wrong time unit shown in offline-override dialog (IMAP), and
while we're at it, use the most appropriate reduced number+unit.
Andrej Kacian [Sat, 18 Aug 2018 12:28:45 +0000 (14:28 +0200)]
Remove unneeded includes from entity.c.
wwp [Sat, 18 Aug 2018 07:56:41 +0000 (09:56 +0200)]
Warn and fail rather than miserably crashing when format string in
faulty.
wwp [Sat, 18 Aug 2018 07:34:09 +0000 (09:34 +0200)]
Fix for Bug 4072: Crash when clicking 'reply' or 'reply with quote'
Wrong '%\n' format causes a crash in g_strdup_printf.
wwp [Thu, 16 Aug 2018 06:45:55 +0000 (08:45 +0200)]
Fix/normalize product name in few places in UI and in several source
files.
wwp [Thu, 16 Aug 2018 06:37:13 +0000 (08:37 +0200)]
Sucesfuly fix typos in LDAP log prints.
Paul [Wed, 15 Aug 2018 17:41:58 +0000 (18:41 +0100)]
for release 3.17.0
Paul [Wed, 15 Aug 2018 15:41:40 +0000 (16:41 +0100)]
translations updates
submitted by David Medina, David Vachulka, Erik P. Olsen, Simon Legner,
Flammie Pirinen, Páder Rezső, Petter Adsen, Marcel Pol, Frederico
Goncalves Guimaraes, Cristian Secară, Mikhail Kurinnoi, Slavko, Andreas
Rönnquist, Numan Demirdöğen, and Mark Chang
Ricardo Mones [Tue, 14 Aug 2018 22:53:29 +0000 (00:53 +0200)]
Update list of TLDs for release
Ricardo Mones [Tue, 14 Aug 2018 22:50:57 +0000 (00:50 +0200)]
Some fixes to Spanish translation
wwp [Tue, 14 Aug 2018 22:02:00 +0000 (00:02 +0200)]
French translation: last fixes and updates.
Ricardo Mones [Tue, 14 Aug 2018 16:32:04 +0000 (18:32 +0200)]
Update Spanish translation
wwp [Tue, 14 Aug 2018 15:58:18 +0000 (17:58 +0200)]
French translation: introduce inclusive modern French forms (I guess we'll get
feedback about this), patch by Colin.
wwp [Tue, 14 Aug 2018 15:33:38 +0000 (17:33 +0200)]
French translation: fix few uses of ID and capitalization.
wwp [Tue, 14 Aug 2018 15:21:57 +0000 (17:21 +0200)]
Fix French translation file.
wwp [Tue, 14 Aug 2018 15:02:24 +0000 (17:02 +0200)]
French translation: few fixes more.
wwp [Tue, 14 Aug 2018 14:25:14 +0000 (16:25 +0200)]
Update French translation (more to come).
Andrej Kacian [Mon, 13 Aug 2018 18:52:45 +0000 (20:52 +0200)]
Fix an embarrassing mistake in rssyl_strreplace().
Closes bug #4068: Claws Mail hangs when getting news from a certain feed
Andrej Kacian [Mon, 13 Aug 2018 18:44:21 +0000 (20:44 +0200)]
Avoid a needless string copy in rssyl_replace_html_stuff().
Andrej Kacian [Mon, 13 Aug 2018 18:38:30 +0000 (20:38 +0200)]
Add <sub> and </sub> to list of HTML tags to remove from feed subjects.
Andrej Kacian [Mon, 13 Aug 2018 18:32:49 +0000 (20:32 +0200)]
Return a copy of the string also when sanity checks fail.
Also, use GLib's g_return functions instead of ifs and
debug_prints.
wwp [Mon, 13 Aug 2018 10:54:08 +0000 (12:54 +0200)]
Fix buffer clash (one already present, one added in
3.16.0-254-gb9c4e27),
leading to broken To value in From column of message list.
Ricardo Mones [Tue, 7 Aug 2018 09:06:39 +0000 (11:06 +0200)]
Some improvements upon translation
Andrej Kacian [Fri, 3 Aug 2018 12:15:47 +0000 (14:15 +0200)]
Fix a memory leak when saving last opened folder on exit.
Andrej Kacian [Fri, 3 Aug 2018 12:07:10 +0000 (14:07 +0200)]
Fix a memory leak in sc_html_parse_tag().
Andrej Kacian [Fri, 3 Aug 2018 12:02:38 +0000 (14:02 +0200)]
Fix a memory leak in summary_set_header().
Andrej Kacian [Fri, 3 Aug 2018 11:40:57 +0000 (13:40 +0200)]
Fixed a memory leak in stock_pixmap_widget_with_overlay().
Andrej Kacian [Fri, 3 Aug 2018 11:22:49 +0000 (13:22 +0200)]
Fix memory leaks in toolbar handling of alternate icons (mail/news, ham/spam).
Andrej Kacian [Fri, 3 Aug 2018 07:45:39 +0000 (09:45 +0200)]
Fix two GTK runtime warnings in Managesieve feed properties dialog.
Andrej Kacian [Fri, 3 Aug 2018 07:24:29 +0000 (09:24 +0200)]
Fix two GTK runtime warnings in RSSyl feed properties dialog.
Andrej Kacian [Sun, 15 Jul 2018 18:49:15 +0000 (20:49 +0200)]
Improve textview keypress handling for scrolling. (PgUp/Down, Space, Backspace)
Ricardo Mones [Wed, 25 Jul 2018 17:34:03 +0000 (19:34 +0200)]
Mailmbox: fix buffer size
Should fix the following warnings reported on ML¹:
mailmbox.c: In function ‘claws_mailmbox_expunge_no_lock.part.4’:
mailmbox.c:1260:34: warning: ‘XXXXXX’ directive output may be truncated
writing 6 bytes into a region of size between 1 and 4096
[-Wformat-truncation=]
snprintf(tmpfile, PATH_MAX, "%sXXXXXX", folder->mb_filename);
^~~~~~
mailmbox.c:1260:3: note: ‘snprintf’ output between 7 and 4102 bytes into
a destination of size 4096
snprintf(tmpfile, PATH_MAX, "%sXXXXXX", folder->mb_filename);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
¹ https://lists.claws-mail.org/pipermail/users/2018-July/022270.html
Andrej Kacian [Sun, 15 Jul 2018 17:35:06 +0000 (19:35 +0200)]
When switching to/from offline mode, reset override timers.
Closes bug #4056: Impossible to disable overriding of offline mode
Andrej Kacian [Sun, 22 Jul 2018 19:28:32 +0000 (21:28 +0200)]
Fixed a small memory leak in advsearch_expand_search_string().
Andrej Kacian [Sun, 22 Jul 2018 19:07:46 +0000 (21:07 +0200)]
Fix auth retry in Managesieve - wrong state variable was being set.
Andrej Kacian [Sun, 22 Jul 2018 19:06:26 +0000 (21:06 +0200)]
Removed a few obsolete and unused functions.
Andrej Kacian [Sun, 22 Jul 2018 16:55:18 +0000 (18:55 +0200)]
When deleting an account, cancel its autocheck timer.
Paul [Fri, 20 Jul 2018 07:26:57 +0000 (08:26 +0100)]
fix bug 4058, '# in extended search description window should not be translated'
Andrej Kacian [Tue, 17 Jul 2018 17:21:36 +0000 (19:21 +0200)]
RSSyl: do not look at modified time when matching deleted items
Andrej Kacian [Mon, 16 Jul 2018 20:20:22 +0000 (22:20 +0200)]
RSSyl: Re-add a mistakenly deleted #include.
Andrej Kacian [Sun, 15 Jul 2018 21:43:45 +0000 (23:43 +0200)]
Remove unneeded debug_print lines.
Andrej Kacian [Sun, 15 Jul 2018 21:42:01 +0000 (23:42 +0200)]
Save the account custom signing key ID even if other option than custom is selected.
Andrej Kacian [Sun, 15 Jul 2018 08:25:42 +0000 (10:25 +0200)]
RSSyl: add more missing checks for offline mode
Closes bug #4014 - "Work offline" doesn't seem to affect RSS
Andrej Kacian [Sat, 14 Jul 2018 22:31:18 +0000 (00:31 +0200)]
RSSyl: rework matching deleted items to better handle feeds without id
Fixes bug #3971 again.
Andrej Kacian [Sun, 17 Jun 2018 13:10:50 +0000 (15:10 +0200)]
Allow separate autocheck configuration for accounts.
Accounts can have their own autocheck intervals, or follow
global interval.
This separates the autocheck configuration from 'Get all'.
config_version is bumped to 3, because meaning of
"receive_at_get_all" in account configuration has changed.
Closes bug #2552: in automatic checking, enable the use of
different time intervals
Closes bug #2837: Detach automatic email checking from 'get all'
Andrej Kacian [Fri, 13 Jul 2018 21:27:11 +0000 (23:27 +0200)]
Added missing archiver_prefs.h to archive_la_SOURCES.
Andrej Kacian [Fri, 13 Jul 2018 16:40:40 +0000 (18:40 +0200)]
Do not let plugins install their header files, unless necessary.
The only plugin that needs to do that is pgpcore, as there
could in theory exist an external plugin that depends on it,
and uses symbols from it.
Andrej Kacian [Fri, 13 Jul 2018 13:17:58 +0000 (15:17 +0200)]
Fix a condition typo in gtk_cmclist_motion().
Andrej Kacian [Sun, 8 Jul 2018 14:41:18 +0000 (16:41 +0200)]
Get rid of account_list_view_add(), since it was just a useless middleman.
The logic was pushed down to account_list_store_insert_account_item(),
now we only need to pass PrefsAcount pointer to it.
Andrej Kacian [Thu, 5 Jul 2018 20:27:44 +0000 (22:27 +0200)]
Add "Show password" checkbox to each Proxy pref page.
Andrej Kacian [Thu, 5 Jul 2018 07:54:11 +0000 (09:54 +0200)]
More Windows build fixes.
Patch by Abhay S. Kushwaha.
Andrej Kacian [Sun, 1 Jul 2018 20:07:17 +0000 (22:07 +0200)]
Cleanup after moving Managesieve passwords to password store.
Since the password was moved to password store, there is one
less element in accounts' Managesieve config string. The
"failed reading Sieve config elements" warning should not be
printed if it's just password that's missing.
Andrej Kacian [Sun, 1 Jul 2018 19:56:16 +0000 (21:56 +0200)]
Added a password store function to check if a password exists.
Paul [Fri, 29 Jun 2018 17:06:48 +0000 (18:06 +0100)]
fix memory leak, and seasoned to suit some tastes
Paul [Fri, 29 Jun 2018 14:38:33 +0000 (15:38 +0100)]
use TRUE/FALSE instead of 1/0
Paul [Fri, 29 Jun 2018 11:51:24 +0000 (12:51 +0100)]
when a return-receipt request is sent to an unknown addr, make the user choose which acc to send from
Paul [Fri, 29 Jun 2018 11:02:22 +0000 (12:02 +0100)]
vCalendar: Skip whitespace chars at the beginning of ics stream
patch by Avinash Sonawane
Andrej Kacian [Tue, 26 Jun 2018 16:21:56 +0000 (18:21 +0200)]
Fix build for Windows, plus some missing symbols in claws.def files.
Patches by Abhay S. Kushwaha.
Andrej Kacian [Tue, 26 Jun 2018 16:20:26 +0000 (18:20 +0200)]
Fix some variable type mismatches in ldapsvr_connect() on Windows.
Holger Berndt [Mon, 25 Jun 2018 21:22:26 +0000 (23:22 +0200)]
GData plugin: Request interactive auth only in case of auth issues
At the same time, make (now potentially ignored) errors more visible
in the status bar in the same way as background mail fetching errors
are reported.
Fixes bug #3754
Modified version of the patch by Viacheslav Gagara on that bug report.
Holger Berndt [Sun, 24 Jun 2018 14:16:46 +0000 (16:16 +0200)]
GData plugin: Only allow one interactive auth session at a time
Paul [Fri, 22 Jun 2018 09:55:02 +0000 (10:55 +0100)]
strip whitespace from subscribed URLs
Paul [Thu, 21 Jun 2018 09:54:11 +0000 (10:54 +0100)]
fix bug, 'MDN mail-accountname leak'
always use whatever is in the To header for the From header when sending
Return Receipts
Ricardo Mones [Tue, 19 Jun 2018 09:12:02 +0000 (11:12 +0200)]
Default mode URL should be escaped before using it
Andrej Kacian [Sun, 17 Jun 2018 13:19:20 +0000 (15:19 +0200)]
Fix 'Invalid PrefType for GtkEntry' warning for account proxy_pass.
Also remove P_PASSWORD as valid PrefType in prefs_set_data_from_entry().
Andrej Kacian [Sun, 17 Jun 2018 11:14:58 +0000 (13:14 +0200)]
Clone also proxy-related prefs in account_clone().
wwp [Tue, 12 Jun 2018 09:27:32 +0000 (11:27 +0200)]
Include Resent-From and Resent-To in Any/All header(s) (in addressbook) matcher rules.
wwp [Tue, 12 Jun 2018 08:52:12 +0000 (10:52 +0200)]
Clean up and unfold more standard headers (Bcc, Reply-To, Sender,
Resent-From and Resent-To).
wwp [Tue, 12 Jun 2018 08:26:38 +0000 (10:26 +0200)]
Properly highlight the whole email address in Resent-From and Resent-To
headers.
Michael Rasmussen [Mon, 11 Jun 2018 20:46:32 +0000 (22:46 +0200)]
Fix a possible memory leak
Signed-off-by: Michael Rasmussen <mir@datanom.net>
Andrej Kacian [Mon, 11 Jun 2018 19:17:07 +0000 (21:17 +0200)]
Fix memory corruption introduced in
d28d62772.
wwp [Mon, 11 Jun 2018 17:12:20 +0000 (19:12 +0200)]
Reduce scope of few variables.
wwp [Mon, 11 Jun 2018 11:36:12 +0000 (13:36 +0200)]
Update copyright in file headers.
Make use of GLib API for few file operations.