claws.git
2 years agoFix get_serverport() in ssl_manager.c to better handle bad filenames.
Andrej Kacian [Sat, 22 Apr 2017 08:34:30 +0000 (10:34 +0200)]
Fix get_serverport() in ssl_manager.c to better handle bad filenames.

2 years agoFancy: simplify open-or-not decision to x,y matching or not
Andrej Kacian [Fri, 21 Apr 2017 23:15:30 +0000 (01:15 +0200)]
Fancy: simplify open-or-not decision to x,y matching or not

Fixes bug #3814:  end of mouse drag or text selection erroneously
activates links

2 years agoFancy: correctly handle when text selection event ends on a link
Andrej Kacian [Fri, 21 Apr 2017 23:04:10 +0000 (01:04 +0200)]
Fancy: correctly handle when text selection event ends on a link

Fixes bug #3813 - "mouse up" activates link even if "mouse down"
occurred outside the link / cannot copy link text

...with a small caveat where this is not implemented for
webkitgtk version  earlier than 1.5.1, because I couldn't find
relevant old enough API documentation.

2 years agoRemove an unused function - cleanup after 680a2ee67.
Andrej Kacian [Fri, 21 Apr 2017 16:02:38 +0000 (18:02 +0200)]
Remove an unused function - cleanup after 680a2ee67.

2 years agoRewrite ssl_manager cert filename parsing to allow for ipv6 addresses.
Andrej Kacian [Fri, 21 Apr 2017 15:57:04 +0000 (17:57 +0200)]
Rewrite ssl_manager cert filename parsing to allow for ipv6 addresses.

2 years agoFix configure logic around tnef_parse plugin.
Andrej Kacian [Wed, 19 Apr 2017 17:20:06 +0000 (19:20 +0200)]
Fix configure logic around tnef_parse plugin.

If the plugin is explicitly enabled, but its dependencies
are missing, error out instead of warning and continuing.

2 years agoFix use after free
Ricardo Mones [Tue, 18 Apr 2017 10:13:33 +0000 (12:13 +0200)]
Fix use after free

2 years agoPromote warn_sending_many_recipients_num from hidden to regular pref.
Andrej Kacian [Sun, 16 Apr 2017 09:53:55 +0000 (11:53 +0200)]
Promote warn_sending_many_recipients_num from hidden to regular pref.

2 years agoFix 'add_to_addressbook' filtering action to correctly add the name.
Andrej Kacian [Sat, 15 Apr 2017 17:41:48 +0000 (19:41 +0200)]
Fix 'add_to_addressbook' filtering action to correctly add the name.

2 years agoFix bug #3808: Replace icaltime_from_timet with icaltime_from_timet_with_zone
Michael Rasmussen [Fri, 14 Apr 2017 10:47:41 +0000 (12:47 +0200)]
Fix bug #3808: Replace icaltime_from_timet with icaltime_from_timet_with_zone

2 years agoAssume direct TLS if SMTP autoconfig finds port 465.
Andrej Kacian [Thu, 13 Apr 2017 07:06:30 +0000 (09:06 +0200)]
Assume direct TLS if SMTP autoconfig finds port 465.

Technically, this is incorrect:
A direct TLS-only SMTP service is against the standards,
and a "_submission._tcp" SRV record should have a port
that has a plaintext+STARTTLS service listening
(RFC 6186, section 3.1).

Port 465 shouldn't even be used for mail submission of
any kind, according to IANA:
(https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=465)

However, everyone ignores that, and port 465 is routinely
used for TLS-only SMTP service, and therefore it is safe to
assume direct TLS instead of STARTTLS.

2 years agoFix a memory leak around password field in editldap.c.
Andrej Kacian [Wed, 12 Apr 2017 15:36:07 +0000 (17:36 +0200)]
Fix a memory leak around password field in editldap.c.

2 years agoAdd "Show password" checkbox next to LDAP server password field.
Andrej Kacian [Tue, 11 Apr 2017 16:10:14 +0000 (18:10 +0200)]
Add "Show password" checkbox next to LDAP server password field.

2 years agoAdd "Show password" checkbox next to password fields in account prefs.
Andrej Kacian [Tue, 11 Apr 2017 15:55:46 +0000 (17:55 +0200)]
Add "Show password" checkbox next to password fields in account prefs.

2 years agoFix GUI not updating after deleting a tag.
Andrej Kacian [Sun, 9 Apr 2017 16:31:52 +0000 (18:31 +0200)]
Fix GUI not updating after deleting a tag.

Fixes bug #3744 - Crash upon deleting tags.

2 years agoFix missing new printer_btn.xpm in `make dist` archive.
wwp [Wed, 5 Apr 2017 06:24:48 +0000 (08:24 +0200)]
Fix missing new printer_btn.xpm in `make dist` archive.

2 years agoAdjust yet another addressbook icon
Ricardo Mones [Mon, 3 Apr 2017 22:34:47 +0000 (00:34 +0200)]
Adjust yet another addressbook icon

2 years agoAdjust addressbook's tree icons
Ricardo Mones [Mon, 3 Apr 2017 22:28:51 +0000 (00:28 +0200)]
Adjust addressbook's tree icons

They were too big for the row height and overflowed into the next.

2 years agoFix copy/paste error, thanks to Coverity (#1403767).
wwp [Mon, 3 Apr 2017 16:12:10 +0000 (18:12 +0200)]
Fix copy/paste error, thanks to Coverity (#1403767).

2 years agoFix missing include for new pixmap file.
wwp [Mon, 3 Apr 2017 10:41:20 +0000 (12:41 +0200)]
Fix missing include for new pixmap file.

2 years agoAdd new print button to pdf view.
wwp [Mon, 3 Apr 2017 10:30:04 +0000 (12:30 +0200)]
Add new print button to pdf view.

2 years agoAdd new print button to pdf view.
wwp [Mon, 3 Apr 2017 10:27:05 +0000 (12:27 +0200)]
Add new print button to pdf view.

2 years agofix bug 3801, 'Broken auto wrapping'
Paul [Sun, 2 Apr 2017 11:24:20 +0000 (12:24 +0100)]
fix bug 3801, 'Broken auto wrapping'

2 years agoold/new version display
Paul [Sun, 2 Apr 2017 09:08:38 +0000 (10:08 +0100)]
old/new version display

2 years agoReally fix bug #3784: Very similar strings in src/gtk/about.c
Ricardo Mones [Fri, 31 Mar 2017 18:06:19 +0000 (20:06 +0200)]
Really fix bug #3784: Very similar strings in src/gtk/about.c

2 years agoAdd missing library to output of --version-full
Ricardo Mones [Fri, 31 Mar 2017 18:05:25 +0000 (20:05 +0200)]
Add missing library to output of --version-full

2 years agoMake sure outgoing messages have a trailing newline.
Andrej Kacian [Thu, 30 Mar 2017 19:12:13 +0000 (21:12 +0200)]
Make sure outgoing messages have a trailing newline.

This fixes a corner case where if the last line of
a message is a quote, its last character doesn't get
displayed when viewing the copy in outbox.

2 years agodefault selection on entering a folder: make first new|unread|marked message sort...
Paul [Thu, 30 Mar 2017 07:07:28 +0000 (08:07 +0100)]
default selection on entering a folder: make first new|unread|marked message sort-order aware

2 years agoRevert "Fix an off-by-one error in textview's quote unfolding."
Andrej Kacian [Wed, 29 Mar 2017 23:56:48 +0000 (01:56 +0200)]
Revert "Fix an off-by-one error in textview's quote unfolding."

This reverts commit 8819febec59e3d5421b0cd4d7882d6524c375bcf.
I refuse to be driven to madness by our textview's colorization.

2 years agoRevert "Fix the other off-by-one bug in textview quoting."
Andrej Kacian [Wed, 29 Mar 2017 23:55:59 +0000 (01:55 +0200)]
Revert "Fix the other off-by-one bug in textview quoting."

This reverts commit 1acb353987cb2a45b6b6802cc48db6f66aac3121.
I refuse to be driven to madness by our textview's colorization.

2 years agoFix the other off-by-one bug in textview quoting.
Andrej Kacian [Wed, 29 Mar 2017 23:04:22 +0000 (01:04 +0200)]
Fix the other off-by-one bug in textview quoting.

There were two complementary off-by-one bugs, each masking
the other one. Commit 8819fe fixed the first one, thus
unmasking this one.

This should also fix the disgusting bug #3797:
"Unfold quoting renders quotes completely confusing".

2 years agoFix bug #3796 format-security warnings in alertpanel_ use
Andreas Bierfert [Wed, 29 Mar 2017 08:03:11 +0000 (10:03 +0200)]
Fix bug #3796 format-security warnings in alertpanel_ use

This patch fixes format-security warnings in alertpanel_ use by passing
"%s" as string and the buffer as va argument if no other va arguments
are present.

2 years agoFix an off-by-one error in textview's quote unfolding.
Andrej Kacian [Mon, 27 Mar 2017 19:02:37 +0000 (21:02 +0200)]
Fix an off-by-one error in textview's quote unfolding.

2 years agoupdate Czech and Slovak translations
Paul [Mon, 27 Mar 2017 15:06:11 +0000 (16:06 +0100)]
update Czech and Slovak translations

2 years agoupdate German translator
Paul [Sun, 26 Mar 2017 10:14:26 +0000 (11:14 +0100)]
update German translator

2 years agofor release 3.15.0 3.15.0
Paul [Sun, 26 Mar 2017 09:56:53 +0000 (10:56 +0100)]
for release 3.15.0

2 years agoupdate German translator and use UTF-8 for this file.
Paul [Sun, 26 Mar 2017 08:59:04 +0000 (09:59 +0100)]
update German translator and use UTF-8 for this file.

2 years agoupdate German translator
Paul [Sun, 26 Mar 2017 08:58:40 +0000 (09:58 +0100)]
update German translator

2 years agoupdate translations
Paul [Sun, 26 Mar 2017 08:58:16 +0000 (09:58 +0100)]
update translations

2 years agoFix file name in manpage
Ricardo Mones [Sun, 26 Mar 2017 00:22:47 +0000 (01:22 +0100)]
Fix file name in manpage

2 years agoUpdate Spanish translation for release
Ricardo Mones [Sat, 25 Mar 2017 23:56:59 +0000 (00:56 +0100)]
Update Spanish translation for release

2 years agoUpdate list of TLDs for release
Ricardo Mones [Sat, 25 Mar 2017 23:56:06 +0000 (00:56 +0100)]
Update list of TLDs for release

2 years agoMake summary_show() open-when-selected behavior more consistent.
Andrej Kacian [Fri, 24 Mar 2017 13:04:13 +0000 (14:04 +0100)]
Make summary_show() open-when-selected behavior more consistent.

Fall back to "on folder open" setting when deciding whether
or not to also open the selected message.

2 years agoFix timezone handling in procheader_date_parse() on Windows.
Andrej Kacian [Fri, 24 Mar 2017 10:11:58 +0000 (11:11 +0100)]
Fix timezone handling in procheader_date_parse() on Windows.

This fixes logic error introduced in 029174b.

2 years agoRemove deprecated entries in fr.po.
wwp [Tue, 21 Mar 2017 10:59:46 +0000 (11:59 +0100)]
Remove deprecated entries in fr.po.

2 years agoUpdate French translation.
wwp [Tue, 21 Mar 2017 10:56:09 +0000 (11:56 +0100)]
Update French translation.

2 years agoFix crash on e-mails with invalid date on Windows.
Andrej Kacian [Mon, 20 Mar 2017 18:52:11 +0000 (19:52 +0100)]
Fix crash on e-mails with invalid date on Windows.

This fixes crashing on dates with out of range numbers,
e.g. "Sun, 19 Mar 2017 27:41:31 +0600".

2 years agoUpdate copyright year
Michael Rasmussen [Sun, 19 Mar 2017 22:06:58 +0000 (23:06 +0100)]
Update copyright year

2 years agoCorrect/update comment.
wwp [Sun, 19 Mar 2017 18:42:04 +0000 (19:42 +0100)]
Correct/update comment.

2 years agoFix bug 3785: custom headers not stored in queued messages (and thus,
wwp [Sun, 19 Mar 2017 11:13:28 +0000 (12:13 +0100)]
Fix bug 3785: custom headers not stored in queued messages (and thus,
not sent).

2 years agoFix bug #3784: Very similar strings in src/gtk/about.c
Ricardo Mones [Sat, 18 Mar 2017 23:25:43 +0000 (00:25 +0100)]
Fix bug #3784: Very similar strings in src/gtk/about.c

And remove also some \n from translatable strings.

2 years agoAdd more granular options on when to open a selected message.
Andrej Kacian [Sat, 18 Mar 2017 20:53:17 +0000 (21:53 +0100)]
Add more granular options on when to open a selected message.

There are now several checkboxes in Display/Summaries page.
The checkbox in folder open selection dialog has been removed,
since that checkbox is among the new ones.

The option "always_show_message_when_selected" is now boolean,
instead of a tri-state.

This commit also removes function summary_display_by_msgnum(),
and its functionality was moved to summary_select_by_msgnum(), which
has a new boolean argument to control whether or not to display the
selected message.

2 years agoUse fix bug #3787 for specifying format as well
Michael Rasmussen [Sat, 18 Mar 2017 19:58:33 +0000 (20:58 +0100)]
Use fix bug #3787 for specifying format as well

2 years agoFix bug #3787. Create tooltip i helper function
Michael Rasmussen [Sat, 18 Mar 2017 19:43:47 +0000 (20:43 +0100)]
Fix bug #3787. Create tooltip i helper function

2 years agoimprove label text
Paul [Sat, 18 Mar 2017 12:21:14 +0000 (12:21 +0000)]
improve label text

2 years agoShow context of foldersel dialog in a label, instead of in a title.
Andrej Kacian [Sat, 18 Mar 2017 11:41:41 +0000 (12:41 +0100)]
Show context of foldersel dialog in a label, instead of in a title.

This is a follow-up commit to bd8213.

2 years agoFix typos, fixes bug 3786: typo in src/mimeview.c.
wwp [Fri, 17 Mar 2017 23:21:50 +0000 (00:21 +0100)]
Fix typos, fixes bug 3786: typo in src/mimeview.c.

2 years agoRequire SVG library version 2.40.5
Ricardo Mones [Thu, 16 Mar 2017 18:52:27 +0000 (19:52 +0100)]
Require SVG library version 2.40.5

Fix bug #3778: Claws-mail core dumps when trying to view a HTML email

2 years agoAllow custom window title for the folder selection dialog.
Andrej Kacian [Thu, 16 Mar 2017 18:14:49 +0000 (19:14 +0100)]
Allow custom window title for the folder selection dialog.

Fixes bug #3582 - Select folder dialogue does not tell what is
selecting for.

2 years agoAdded summary_get_selection_count() function.
Andrej Kacian [Thu, 16 Mar 2017 17:37:30 +0000 (18:37 +0100)]
Added summary_get_selection_count() function.

2 years agoSynchronize Spanish manual
Ricardo Mones [Tue, 14 Mar 2017 18:38:36 +0000 (19:38 +0100)]
Synchronize Spanish manual

2 years agoFix some color names and lists
Ricardo Mones [Tue, 14 Mar 2017 18:34:01 +0000 (19:34 +0100)]
Fix some color names and lists

2 years agoInitialize icaltimetype variables in Vcalendar's feed_fetch().
Andrej Kacian [Mon, 13 Mar 2017 18:03:25 +0000 (19:03 +0100)]
Initialize icaltimetype variables in Vcalendar's feed_fetch().

Also print out debug output if an event has no start or end,
as it can help determine why a malformed event file shows
weird times or duration.

2 years agoRemove obsolete files icaltime_as_local.[ch].
Andrej Kacian [Mon, 13 Mar 2017 17:18:57 +0000 (18:18 +0100)]
Remove obsolete files icaltime_as_local.[ch].

2 years agoadd new hidden prefs for various colours
Paul [Mon, 13 Mar 2017 07:14:36 +0000 (07:14 +0000)]
add new hidden prefs for various colours

2 years agoAdded debug output for failure cases in sgpgme_data_release_and_get_mem()
Andrej Kacian [Wed, 8 Mar 2017 11:07:51 +0000 (12:07 +0100)]
Added debug output for failure cases in sgpgme_data_release_and_get_mem()

2 years agoSynchronize Spanish manual
Ricardo Mones [Sat, 4 Mar 2017 12:06:16 +0000 (13:06 +0100)]
Synchronize Spanish manual

2 years agoCapitalise, punctuate and clean manpage
Ricardo Mones [Sat, 4 Mar 2017 12:04:33 +0000 (13:04 +0100)]
Capitalise, punctuate and clean manpage

2 years agoAdd forgotten file to manpage
Ricardo Mones [Sat, 4 Mar 2017 11:48:25 +0000 (12:48 +0100)]
Add forgotten file to manpage

2 years agoDeclare and use only when needed
Ricardo Mones [Sat, 4 Mar 2017 11:46:21 +0000 (12:46 +0100)]
Declare and use only when needed

2 years agowebkitglobals.h exists since 1.3.10, not 1.3.13.
Andrej Kacian [Fri, 3 Mar 2017 23:45:18 +0000 (00:45 +0100)]
webkitglobals.h exists since 1.3.10, not 1.3.13.

Patch by Olaf Hering <olaf at aepfle.de>

2 years agoAdd support for date-only variant of ISO8601 timestamp format.
Andrej Kacian [Fri, 3 Mar 2017 23:12:29 +0000 (00:12 +0100)]
Add support for date-only variant of ISO8601 timestamp format.

Fixes bug #3777 - Weird news dates for some RSS feeds

2 years agoFix option item and update dates
Ricardo Mones [Fri, 3 Mar 2017 14:08:26 +0000 (15:08 +0100)]
Fix option item and update dates

2 years agoRemove unused variable
Ricardo Mones [Thu, 2 Mar 2017 15:36:33 +0000 (16:36 +0100)]
Remove unused variable

prefs_actions.c:594:12: warning: unused variable ‘action_nb’

2 years agofix using building with --disable-deprecated
Paul [Thu, 2 Mar 2017 14:54:34 +0000 (14:54 +0000)]
fix using building with --disable-deprecated

If --disable-deprecated is specified it will set GTK_CFLAGS.
Later the pkgconfig check for GTK_CFLAGS will be skipped because the
variable is already set. As a result essential CLFAGS from gtk+-2.0 will
be missing in global CFLAGS and compilation fails.

Solution is to check for the configure flag after pkgconfig.

Thanks to Olaf Hering <olaf@aepfle.de>

2 years agoReduce translators' work by merging almost-duplicated strings
wwp [Wed, 1 Mar 2017 15:52:34 +0000 (16:52 +0100)]
Reduce translators' work by merging almost-duplicated strings
(reported by Pader Rezso).

2 years agofix disabling prefs_common.warn_sending_many_recipients_num by unchecking the 'show...
Paul [Wed, 1 Mar 2017 13:13:24 +0000 (13:13 +0000)]
fix disabling prefs_common.warn_sending_many_recipients_num by unchecking the 'show this msg again' checkbox in the dialogue

2 years agoMake 'Save all...' report more accurate
Ricardo Mones [Wed, 1 Mar 2017 09:45:49 +0000 (10:45 +0100)]
Make 'Save all...' report more accurate

Thanks Woody for nitpicking.

2 years agobump copyright year
Paul [Wed, 1 Mar 2017 08:02:03 +0000 (08:02 +0000)]
bump copyright year

2 years agoDocument hidden pref 'warn_sending_many_recipients_num'
Ricardo Mones [Mon, 27 Feb 2017 23:00:26 +0000 (00:00 +0100)]
Document hidden pref 'warn_sending_many_recipients_num'

2 years agoSimplify hidden prefs for too many recipients
Ricardo Mones [Mon, 27 Feb 2017 22:59:19 +0000 (23:59 +0100)]
Simplify hidden prefs for too many recipients

2 years agoFix bug #3775, wrong plural form string.
wwp [Mon, 27 Feb 2017 12:36:58 +0000 (13:36 +0100)]
Fix bug #3775, wrong plural form string.

2 years agoFix memory leak
Olivier Brunel [Sat, 25 Feb 2017 20:06:21 +0000 (21:06 +0100)]
Fix memory leak

Signed-off-by: Olivier Brunel <jjk@jjacky.com>
2 years agoRemove duplicated code and include
Ricardo Mones [Sat, 25 Feb 2017 12:14:35 +0000 (13:14 +0100)]
Remove duplicated code and include

2 years agoReplace verbosity boolean flag with a bitfield of flags.
Andrej Kacian [Sat, 25 Feb 2017 10:43:26 +0000 (11:43 +0100)]
Replace verbosity boolean flag with a bitfield of flags.

Currently, there are two - whether or not to show error dialogs
and whether or not to show a feed rename dialog after subscribing.

We use same enum typedef for subscribing and fetching/updating
for consistency, the second flag only has effect in rssyl_subscribe().

2 years agoRemove rssyl_feed_subscribe_new(), it was redundant.
Andrej Kacian [Sat, 25 Feb 2017 10:32:52 +0000 (11:32 +0100)]
Remove rssyl_feed_subscribe_new(), it was redundant.

rssyl_subscribe() is almost identical, so it is used instead.
Some minor usability issues that arise from this change will
be fixed in next commit(s).

2 years agoFix bug #3741: Deleting an account doesn't delete imapcache
Ricardo Mones [Tue, 21 Feb 2017 18:05:19 +0000 (19:05 +0100)]
Fix bug #3741: Deleting an account doesn't delete imapcache

Based on initial patch by Paul and in exchange of a reviewed
patch for 3582 ;-)

2 years agoRemove internal libytnef and require an external one instead.
Andrej Kacian [Wed, 22 Feb 2017 09:26:09 +0000 (10:26 +0100)]
Remove internal libytnef and require an external one instead.

3 years agoDo not hardcode resolv.conf location
Ricardo Mones [Thu, 16 Feb 2017 21:57:37 +0000 (22:57 +0100)]
Do not hardcode resolv.conf location

3 years agouse xdg-open as default mime_open_command
Paul [Thu, 16 Feb 2017 13:49:00 +0000 (13:49 +0000)]
use xdg-open as default mime_open_command

3 years agoFix 'Apply' when changing scaling options only
Ricardo Mones [Wed, 15 Feb 2017 23:40:46 +0000 (00:40 +0100)]
Fix 'Apply' when changing scaling options only

3 years agoRemove spurious comment
Ricardo Mones [Tue, 14 Feb 2017 00:00:56 +0000 (01:00 +0100)]
Remove spurious comment

3 years agoMigrate icon filename stored in toolbar XML files
Ricardo Mones [Mon, 13 Feb 2017 23:58:59 +0000 (00:58 +0100)]
Migrate icon filename stored in toolbar XML files

Thanks Paul for the hint.
Completes commit 50bd87f2e13a9dbdb2a1a449823ff16ae87239f8.

3 years agoFix impossible action duplication: don't check for duplicate action name
wwp [Mon, 13 Feb 2017 17:55:28 +0000 (18:55 +0100)]
Fix impossible action duplication: don't check for duplicate action name
when saving/duplicating (we're not doing this elsewhere and I don't see
the point in doing it here).

3 years agoadd Bcc to default headers in drop-down
Paul [Mon, 13 Feb 2017 15:20:53 +0000 (15:20 +0000)]
add Bcc to default headers in drop-down

3 years agoFix pixmap name to reflect what it really does
Ricardo Mones [Sat, 11 Feb 2017 15:47:50 +0000 (16:47 +0100)]
Fix pixmap name to reflect what it really does

Will break your themes, nothing a mv cannot fix ;-)

3 years agoFix wrong return value type.
wwp [Wed, 8 Feb 2017 22:33:38 +0000 (23:33 +0100)]
Fix wrong return value type.

3 years agoSet same size as its companions (new and unread)
Ricardo Mones [Wed, 8 Feb 2017 19:22:14 +0000 (20:22 +0100)]
Set same size as its companions (new and unread)

3 years agoFix included header
Ricardo Mones [Tue, 7 Feb 2017 20:07:16 +0000 (21:07 +0100)]
Fix included header

Error message was:
stock_pixmap.c:26:26: fatal error: librsvg/rsvg.h: No such file or directory

Thanks Paul for reporting!

3 years agoUser interface for SVG preferences
Ricardo Mones [Mon, 6 Feb 2017 23:56:29 +0000 (00:56 +0100)]
User interface for SVG preferences