Ricardo Mones [Sun, 16 Feb 2014 18:21:54 +0000 (19:21 +0100)]
Use new internal plugin for rendering avatars
Updates and simplifies rendering logic in header pane,
message view and text view and when adding pictures to
address book.
Ricardo Mones [Sat, 15 Feb 2014 19:40:43 +0000 (20:40 +0100)]
New hooklist for rendering avatars and some utils
• Create and destroy hooklist parameter structs
• Initialization function to install default handler
Ricardo Mones [Wed, 12 Feb 2014 22:56:32 +0000 (23:56 +0100)]
New hooklist to collect avatar data from headers
Also:
• Refactorize X-Face/Face capture as an internal plugin.
• Add hidden preference ‘enable_avatars’ to control the internal
capture/render process, and which allows disabling it by external
plugins for example.
Paul [Wed, 19 Feb 2014 15:57:40 +0000 (15:57 +0000)]
add dist-z to AUTOMAKE_OPTIONS
Ricardo Mones [Wed, 19 Feb 2014 00:36:37 +0000 (01:36 +0100)]
Remove some X-Face cruft and check after realloc
Paul [Mon, 17 Feb 2014 13:25:29 +0000 (13:25 +0000)]
indicate when there are messages in Drafts
Andrej Kacian [Sun, 16 Feb 2014 12:37:19 +0000 (13:37 +0100)]
Removed unused "block_cursor" preference from prefs_common.
Ricardo Mones [Wed, 12 Feb 2014 22:22:37 +0000 (23:22 +0100)]
Remove unneeded arguments of xface_get_from_header
Ricardo Mones [Tue, 11 Feb 2014 00:17:29 +0000 (01:17 +0100)]
Support any number of avatars per message
Adapt xface/face handling to the new structure
Ricardo Mones [Tue, 11 Feb 2014 00:14:45 +0000 (01:14 +0100)]
New slist_copy_deep utility
And refactoring to use it where currently needed.
Implementation uses glib's version if possible (glib > 2.34).
Paul [Wed, 5 Feb 2014 09:09:20 +0000 (09:09 +0000)]
combine xmailer/xnewsreader header options into one, using generic term "user agent"
Paul [Wed, 5 Feb 2014 08:28:28 +0000 (08:28 +0000)]
add hidden prefs to choose old or new style addr and folder matching
Paul [Mon, 3 Feb 2014 14:03:17 +0000 (14:03 +0000)]
implement RFE bug 3053, 'Can't add "replace signature" to the toolbar'
Paul [Mon, 3 Feb 2014 13:16:00 +0000 (13:16 +0000)]
add option 'Generate X-Newsreader header' for NNTP accounts and complete the 'Generate X-Mailer header' option
Paul [Mon, 3 Feb 2014 11:48:22 +0000 (11:48 +0000)]
LIBOVERLAY_SCROLLBAR=0, thanks Ticho!!
Ricardo Mones [Thu, 30 Jan 2014 09:34:19 +0000 (10:34 +0100)]
Fix memory leak
Paul [Wed, 29 Jan 2014 13:37:46 +0000 (13:37 +0000)]
add Esperanto translation. submitted by Sian Mountbatten
Holger Berndt [Sun, 26 Jan 2014 12:14:21 +0000 (13:14 +0100)]
Python plugin: Also check for _PyGtk_API being a PyCapsule
Seems like Arch Linux patched pygtk to wrap into a PyCapsule instead
of a PyCObject.
Thanks to Drew Ferguson for reporting.
Ricardo Mones [Tue, 21 Jan 2014 11:46:23 +0000 (12:46 +0100)]
Fix bug #3964 "headers in wrong order -- file src/common/ssl.c"
Also cleans "ssl.c:36:1: warning: 'gcry_threads_pthread' defined but not used"
Ricardo Mones [Mon, 13 Jan 2014 20:19:35 +0000 (21:19 +0100)]
Update manpage
• Add missing USER environment variable and sort all variables
alphabetically while at it
• Update team list to match AUTHORS file and compact list of past
team members
• Other cosmetic changes to improve readability
Colin Leroy [Sat, 28 Dec 2013 18:16:37 +0000 (19:16 +0100)]
Fix bug #2875, "SMTP session disconnects before recieving multi-line
error message".
Colin Leroy [Sat, 28 Dec 2013 17:31:22 +0000 (18:31 +0100)]
Fix bug #2991, "POP3 sessions duplicated" on race conditions. Patch by
Paul Rolland.
Colin Leroy [Sat, 28 Dec 2013 17:15:31 +0000 (18:15 +0100)]
Fix bug #3020, "Use theme doesn't change some icons until restart"
Colin Leroy [Sat, 28 Dec 2013 17:10:26 +0000 (18:10 +0100)]
Add Palmer Dabbelt to Authors
Colin Leroy [Sat, 28 Dec 2013 17:08:38 +0000 (18:08 +0100)]
Fix bug #3040, "Handle revoked GPG private keys". Patch by Palmer Dabbelt.
Colin Leroy [Sat, 28 Dec 2013 16:40:12 +0000 (17:40 +0100)]
Fix bug #3038, "Select A Folder incorrectly matches on number
in parentheses". Match on FolderItem's name instead of displayed
string.
Colin Leroy [Fri, 20 Dec 2013 10:53:18 +0000 (11:53 +0100)]
Add preference to allow disabling automatic drafting of encrypted
messages.
Ricardo Mones [Mon, 16 Dec 2013 01:21:59 +0000 (02:21 +0100)]
Fix parsing universal time zone in mailmbox
Detected thanks to the ‘-Wlogical-op’ gcc flag.
Paul [Sat, 14 Dec 2013 11:20:24 +0000 (11:20 +0000)]
fix typo
Paul [Sat, 14 Dec 2013 10:12:55 +0000 (10:12 +0000)]
3.9.3 unleashed
Paul [Sat, 14 Dec 2013 08:37:32 +0000 (08:37 +0000)]
update translations
cs: David Vachulka
de: Thomas Bellmann
es: Ricarddo Mones
fr: Colin Leroy
he: Genghis Khan
nl: Marcel Pol
pt_BR: Frederico Goncalves Guimaraes
sk: Slavko
sv: Andreas Rönnquist
Pawel Pekala [Fri, 13 Dec 2013 20:54:28 +0000 (21:54 +0100)]
Revert last commit
Pawel Pekala [Fri, 13 Dec 2013 19:58:41 +0000 (20:58 +0100)]
Fix python check for systems with dlopen(3) in libc (BSD family)
Andrej Kacian [Thu, 12 Dec 2013 17:18:23 +0000 (18:18 +0100)]
In compose window, allow address completion to match any part of address, not just beginning.
Andrej Kacian [Thu, 12 Dec 2013 11:17:59 +0000 (12:17 +0100)]
In folder select dialog, allow type-search to match any part of folder names, not just beginning.
Colin Leroy [Sun, 8 Dec 2013 09:32:48 +0000 (10:32 +0100)]
Fix assertion (port != NULL) in password_get() for
POP3 sessions, where the password is retrieved prior
to the session being connected.
Colin Leroy [Thu, 5 Dec 2013 11:05:24 +0000 (12:05 +0100)]
Better fix for bug #3009; conv_filename_to_utf8() converts strings
in local filename encoding to UTF-8 even if local filename encoding
is UTF-8, leading to double UTF-8 encoding.
Ricardo Mones [Thu, 5 Dec 2013 10:00:29 +0000 (11:00 +0100)]
Fix bug #3009 ‘"Rebuild folder tree" causes SIGSEGV if a directory name isn't valid utf-8’
Based on initial patch submitted by Fabian Keil <fk@fabiankeil.de>
Paul [Tue, 3 Dec 2013 12:16:59 +0000 (12:16 +0000)]
update the Plugins window label to link to 'more inforamtion' rather than 'more plugins', since all plugins are built-in now
Paul [Tue, 3 Dec 2013 11:22:22 +0000 (11:22 +0000)]
fix sensitivity and state of 'hide read threads'
This fixes this problem:
'Thread View' is set and 'Hide read threads' is set.
Unset 'Thread View', 'hide read threads' is greyed out but still set,
and 'hide read messages' is greyed out also.
With this fix, when 'Thread View' is unset, 'hide read threads' is
automatically unset too, thus 'hide read messages' is selectable.
Ricardo Mones [Tue, 26 Nov 2013 08:13:26 +0000 (09:13 +0100)]
Fix poppler required version accordingly
Set to 0.12 (released in 2009) and required for version check macros.
Anyway we were using defines only present in 0.14 without checking...
Ricardo Mones [Mon, 25 Nov 2013 19:22:00 +0000 (20:22 +0100)]
Clean poppler_viewer.c switch warnings
Cleans:
• poppler_viewer.c:827:3: warning: enumeration value
'POPPLER_ACTION_NONE' not handled in switch
• poppler_viewer.c:827:3: warning: enumeration value
'POPPLER_ACTION_RENDITION' not handled in switch
• poppler_viewer.c:827:3: warning: enumeration value
'POPPLER_ACTION_OCG_STATE' not handled in switch
• poppler_viewer.c:827:3: warning: enumeration value
'POPPLER_ACTION_JAVASCRIPT' not handled in switch
Ricardo Mones [Mon, 25 Nov 2013 19:20:00 +0000 (20:20 +0100)]
Clean ‘newmail.c:132: warning: `sys_errlist' is deprecated’
Ricardo Mones [Sun, 17 Nov 2013 18:56:24 +0000 (19:56 +0100)]
Clean ‘warning: variable 'self' set but not used’
From:
• gtk-hotkey-key-file-registry.c:87:28
• gtk-hotkey-key-file-registry.c:116:29
• gtk-hotkey-key-file-registry.c:134:28
• gtk-hotkey-key-file-registry.c:214:28
• gtk-hotkey-key-file-registry.c:321:28
• gtk-hotkey-key-file-registry.c:458:28
Ricardo Mones [Sun, 17 Nov 2013 18:15:21 +0000 (19:15 +0100)]
Clean mailmbox plugin warnings
Cleans:
• plugin_gtk.c:312:9: warning: variable 'old_path' set but not used
• plugin_gtk.c:397:9: warning: variable 'old_path' set but not used
• mailimf_write.c:636:16: warning: variable 'next_word' set but not used
• mailimf_write.c:635:16: warning: variable 'word_end' set but not used
• mailmbox.c:519:10: warning: variable 'fixed_size' set but not used
• mailmbox.c:610:10: warning: variable 'maxuid' set but not used
• mailmbox_folder.c:162:36: warning: assignment from incompatible pointer type
• mailmbox_folder.c:872:5: warning: 'r' may be used uninitialized in this function
Ricardo Mones [Sun, 17 Nov 2013 17:23:52 +0000 (18:23 +0100)]
Clean clamd plugin warning
Cleans: ‘clamd-plugin.c:494:30: warning: argument to 'sizeof' in 'memset'
call is the same pointer type 'struct response *' as the destination;
expected 'response' or an explicit length’ (gcc 4.8)
Ricardo Mones [Sat, 16 Nov 2013 20:10:11 +0000 (21:10 +0100)]
Clean ‘perl_plugin.c:993:8: warning: unused variable 'tag_id'’
Ricardo Mones [Sat, 16 Nov 2013 19:32:12 +0000 (20:32 +0100)]
Clean all ‘… warning: "_POSIX_C_SOURCE" redefined’
According documentation¹: “Since Python may define some pre-processor
definitions which affect the standard headers on some systems, you must
include Python.h before any standard headers are included.”
¹http://docs.python.org/2/c-api/intro.html#includes
Ricardo Mones [Sat, 16 Nov 2013 18:39:54 +0000 (19:39 +0100)]
Clean spam_report warnings
Cleans:
• spam_report.c:196:11: warning: variable 'res' set but not used
• spam_report.c:361:15: warning: variable 'summaryview' set but not used
Ricardo Mones [Sat, 16 Nov 2013 18:23:04 +0000 (19:23 +0100)]
Clean ytnef.c warnings
Cleans:
• ytnef.c:505:13: warning: format '%i' expects argument of type 'int', but argument 2 has type 'long int'
• ytnef.c:506:13: warning: format '%i' expects argument of type 'int', but argument 2 has type 'long int'
• ytnef.c:511:13: warning: format '%i' expects argument of type 'int', but argument 2 has type 'long int'
• ytnef.c:512:13: warning: format '%i' expects argument of type 'int', but argument 2 has type 'long int'
• ytnef.c:375:9: warning: variable 'offset' set but not used
• ytnef.c:1185:52: warning: variable 'crc32' set but not used
• ytnef.c:1185:27: warning: variable 'uncompressedSize' set but not used
• ytnef.c:1185:11: warning: variable 'compressedSize' set but not used
• ytnef.c:1360:52: warning: variable 'crc32' set but not used
Ricardo Mones [Sat, 16 Nov 2013 16:59:48 +0000 (17:59 +0100)]
Clean ‘geolocation_plugin.c:260:23: warning: initialization discards 'const' qualifier from pointer target type’
Ricardo Mones [Sat, 16 Nov 2013 15:15:19 +0000 (16:15 +0100)]
Clean fancy warnings
Cleans:
• fancy_viewer.c:441:3: warning: format '%d' expects argument of
type 'int', but argument 2 has type 'size_t'
• fancy_prefs.c:164:9: warning: passing argument 1 of 'gtk_list_store_set'
from incompatible pointer type
• fancy_prefs.c:167:9: warning: passing argument 1 of 'gtk_list_store_set'
from incompatible pointer type
Ricardo Mones [Sat, 16 Nov 2013 15:02:45 +0000 (16:02 +0100)]
Clean att_remover warnings
Cleans:
• att_remover.c:503:16: warning: variable 'path' set but not used
• att_remover.c:534:15: warning: variable 'summaryview' set but not used
Ricardo Mones [Fri, 15 Nov 2013 22:51:56 +0000 (23:51 +0100)]
Clean address_keeper const-ness warnings
Cleans:
• address_keeper.c:103:16: warning: assignment discards
'const' qualifier from pointer target type
• address_keeper_prefs.c:239:38: warning: assignment discards
'const' qualifier from pointer target type
Ricardo Mones [Fri, 15 Nov 2013 21:39:54 +0000 (22:39 +0100)]
Clean args const-ness in cm_menu_set_sensitive_full
Cleans:
• mainwindow.c:3227:3: warning: passing argument 2 of
‘cm_menu_set_sensitive_full’ discards ‘const’ qualifier
from pointer target type
• summaryview.c:1796:3: warning: passing argument 2 of
‘cm_menu_set_sensitive_full’ discards ‘const’ qualifier
from pointer target type
Ricardo Mones [Fri, 15 Nov 2013 21:27:29 +0000 (22:27 +0100)]
Clean ‘account.c:1866:2: warning: comparison between pointer and integer’
Paul [Fri, 8 Nov 2013 13:54:29 +0000 (13:54 +0000)]
make the frame label more accurate
Paul [Thu, 7 Nov 2013 06:48:26 +0000 (06:48 +0000)]
fix off-by-one count
Ricardo Mones [Mon, 4 Nov 2013 23:56:11 +0000 (00:56 +0100)]
Fix bug #2964 'Lack of escaping of nested double-quotes in To: header'
Additionally double quotes are also escaped in other relevant headers.
Ricardo Mones [Mon, 4 Nov 2013 23:55:10 +0000 (00:55 +0100)]
New utils function escape_internal_quotes
Searchs for all quotation characters within a string, creating
(only if required) a copy with the quotation characters escaped.
Colin Leroy [Sat, 2 Nov 2013 08:14:56 +0000 (09:14 +0100)]
Fix bug #3011, "crash when using %f Action on two or more uncached
(IMAP) messages". Thanks Paul for the idea!
Paul [Sat, 2 Nov 2013 07:44:09 +0000 (07:44 +0000)]
implement enhancement bug 3026, 'replace short by long IDs in dialogue(s) of gpg related plugin(s)'
Colin Leroy [Fri, 1 Nov 2013 17:49:37 +0000 (18:49 +0100)]
Don't check versions (does not seem to have any adverse effects,
and fixes buildbot)
Paul [Fri, 1 Nov 2013 10:03:53 +0000 (10:03 +0000)]
add 'Replace Signature' menu item
Paul [Tue, 29 Oct 2013 10:15:50 +0000 (10:15 +0000)]
be less brutal: don't remove all spaces, just remove spaces at the end of the string
Ricardo Mones [Mon, 28 Oct 2013 09:52:52 +0000 (10:52 +0100)]
Quote all specials in name as defined on RFC
See http://tools.ietf.org/html/rfc5322#section-3.2.3
Ricardo Mones [Mon, 28 Oct 2013 08:39:35 +0000 (09:39 +0100)]
Fix segfault for addresses without name part
Thanks Paul for reporting on irc ;-)
Ricardo Mones [Fri, 25 Oct 2013 12:09:00 +0000 (14:09 +0200)]
Fix bug #2210, but not on Address Book
Bug report is titled 'Display name with invalid addresses not quoted
when inserted from address book', but the real problem is not the AB.
AB doesn't care about the address format or validity, the problem is
sending those addresses to the SMTP server, which, as seen in the wild¹,
might care.
Fix quotes all addresses which need quoting just before writting the
message to the queue folder.
¹http://lists.claws-mail.org/pipermail/users/2013-October/007485.html
Colin Leroy [Thu, 24 Oct 2013 19:49:19 +0000 (21:49 +0200)]
Fix useless call to gpg_err_code for sig->validity
Paul [Wed, 23 Oct 2013 13:38:32 +0000 (14:38 +0100)]
fix bug 3021, 'Icon key_pgp_signed always shows as the default, never the themed version'
Paul [Fri, 18 Oct 2013 11:31:31 +0000 (12:31 +0100)]
ooops! I forgot the brackets in the last commit. d'oh!
Paul [Fri, 18 Oct 2013 11:25:23 +0000 (12:25 +0100)]
before parsing the values, remove whitespace from Content-Type, Content-Transfer-Encoding, and Content-Disposition header values
this fixes broken mailers, e.g. yahoo groups. see http://tools.ietf.org/html/rfc2045#section-6
Paul [Thu, 10 Oct 2013 12:26:12 +0000 (13:26 +0100)]
fallback to 'localhost' rather than 'unknown' as some SMTP servers reject 'EHLO unknown', e.g. gmx and web.de. Thanks to Hanno Meyer-Thurow.
Paul [Wed, 2 Oct 2013 11:24:52 +0000 (12:24 +0100)]
fix bug 2940, 'Extended search dialog too small for content in polish l10n'
Colin Leroy [Sun, 29 Sep 2013 09:04:43 +0000 (11:04 +0200)]
Understand webcals:// as https://.
Colin Leroy [Sun, 29 Sep 2013 09:02:56 +0000 (11:02 +0200)]
Fix bug #3004, "claws picks wrong mime type for attachments"
Use first match for each extension
Michael Rasmussen [Sat, 14 Sep 2013 13:51:33 +0000 (15:51 +0200)]
Updated Team list to be in sync with section=community on the web
Added Marco Villegas for patch resolving bug 3002
Michael Rasmussen [Sat, 14 Sep 2013 12:07:15 +0000 (14:07 +0200)]
Fix bug 3002 'undefined reference to check_file_integrity'.
Patch provided by Marco Villegas.
Paul [Fri, 30 Aug 2013 07:12:59 +0000 (08:12 +0100)]
add option to disable the 'Subject is empty' warning dialogue
Paul [Wed, 28 Aug 2013 07:00:29 +0000 (08:00 +0100)]
revert part of last commit
bug 2989 remains fixed in as much as the segfault is prevented
Paul [Wed, 28 Aug 2013 05:27:58 +0000 (06:27 +0100)]
fix bug 2989, 'Segfault at startup because of corrupted folderlist.xml'
Paul [Tue, 27 Aug 2013 08:45:42 +0000 (09:45 +0100)]
fix bug 2979, 'claws fails to load (empty) folderlist.xml and shows account wizard'
Paul [Wed, 21 Aug 2013 06:55:37 +0000 (07:55 +0100)]
no need to do ifdef HAVE_CONFIG_H twice
Holger Berndt [Tue, 20 Aug 2013 20:03:46 +0000 (22:03 +0200)]
Python plugin: Folder: Fix deprecation warning
Holger Berndt [Tue, 20 Aug 2013 19:30:50 +0000 (21:30 +0200)]
Python plugin: Folder: Let path return the absolute path
Holger Berndt [Mon, 19 Aug 2013 22:13:20 +0000 (00:13 +0200)]
Python plugin: Example: Make recursive-mark-as-read also work on mailbox
Holger Berndt [Mon, 19 Aug 2013 22:08:13 +0000 (00:08 +0200)]
Python plugin: Folder: Add message counts as read-only properties
Holger Berndt [Sun, 18 Aug 2013 22:52:39 +0000 (00:52 +0200)]
Python plugin: Make it possible to select a mailbox in folderview
Holger Berndt [Sun, 18 Aug 2013 21:49:20 +0000 (23:49 +0200)]
Python plugin: Mailbox: Add type checking function
Holger Berndt [Sun, 11 Aug 2013 23:00:44 +0000 (01:00 +0200)]
Python plugin: Make it possible to get folder tree from a Mailbox
Holger Berndt [Sat, 10 Aug 2013 13:09:19 +0000 (15:09 +0200)]
Python pluging: Folder: Add accessor to Mailbox object
Holger Berndt [Sat, 10 Aug 2013 12:56:28 +0000 (14:56 +0200)]
Python plugin: Add Mailbox type
Holger Berndt [Sat, 10 Aug 2013 12:28:01 +0000 (14:28 +0200)]
Python plugin: Folder: Return None for folders without an id
Paul [Sat, 17 Aug 2013 08:19:30 +0000 (09:19 +0100)]
fix bug 2995, 'closing extended quick search information panel triggers window focus bug'
Paul [Thu, 15 Aug 2013 06:06:57 +0000 (07:06 +0100)]
make "Present main window" translatable
Ricardo Mones [Wed, 14 Aug 2013 15:19:55 +0000 (17:19 +0200)]
Fix remaining cases of bug #2923
Patch thanks to Dominic Hargreaves <dom@earth.li>
on http://bugs.debian.org/708004
Ricardo Mones [Wed, 14 Aug 2013 15:15:12 +0000 (17:15 +0200)]
Fix typo
Paul [Wed, 14 Aug 2013 07:51:16 +0000 (08:51 +0100)]
fix bug 2986, 'Down and Delete buttons have same hotkey in filtering config' and then some
Paul [Wed, 14 Aug 2013 06:57:53 +0000 (07:57 +0100)]
fix bug 2994, 'translating folder name'
Holger Berndt [Thu, 8 Aug 2013 21:32:11 +0000 (23:32 +0200)]
Python plugin: MessageInfo: Create Python objects for members on the fly