claws.git
2 years agofix bug where creating a new folder wth inheriting properties doesn't write processin...
Paul [Sun, 18 Nov 2018 17:23:35 +0000 (17:23 +0000)]
fix bug where creating a new folder wth inheriting properties doesn't write processinf rules

after copying folder with 'inherit properties from parent folder' set,
the processing rules are (initially) present in the processing rules
dialogue, but are not actually written. So on a restart they are 'lost'.

This is probably the actual bug 4121, ' Moving a subfolder in another
folder erases  its processing rules', rather than the description given.

2 years agoImplement batch message removal for RSSyl.
Andrej Kacian [Sat, 17 Nov 2018 19:48:44 +0000 (20:48 +0100)]
Implement batch message removal for RSSyl.

This allows further optimization of how often the
.deleted file is read and written.

2 years agoUse black as default value for folder_color folder pref.
Andrej Kacian [Fri, 16 Nov 2018 21:17:48 +0000 (22:17 +0100)]
Use black as default value for folder_color folder pref.

2 years agoAdded some basic unit tests for unmime_header().
Andrej Kacian [Fri, 16 Nov 2018 19:50:53 +0000 (20:50 +0100)]
Added some basic unit tests for unmime_header().

2 years agoAdded NULL parameter check for unmime_header().
Andrej Kacian [Fri, 16 Nov 2018 19:50:32 +0000 (20:50 +0100)]
Added NULL parameter check for unmime_header().

2 years agomatch the wording of the /View menu
Paul [Fri, 16 Nov 2018 09:49:51 +0000 (09:49 +0000)]
match the wording of the /View menu

2 years agoFix bug #4120, "New cert files are created in $HOME instead of in ~/.claws-mail...
Colin Leroy [Thu, 15 Nov 2018 09:56:23 +0000 (10:56 +0100)]
Fix bug #4120, "New cert files are created in $HOME instead  of in ~/.claws-mail/certs"

2 years agoSanitize filenames for saved TLS certificates.
Andrej Kacian [Thu, 15 Nov 2018 07:31:33 +0000 (08:31 +0100)]
Sanitize filenames for saved TLS certificates.

Fixes using unsafe_ssl_certs pref on Windows, as that
includes certificate fingerprint in the filename.
Fingerprints contain colons, and those are not allowed
in filenames on Windows.

2 years agoFix WEXITSTATUS build error on Win32.
Andrej Kacian [Wed, 14 Nov 2018 20:21:51 +0000 (21:21 +0100)]
Fix WEXITSTATUS build error on Win32.

Also add glib.h include in file-utils.c, so that
G_OS_WIN32 ifdefs actually work.

2 years agomove 'msg selection when entering a folder" button to Message List page
Paul [Wed, 14 Nov 2018 06:20:21 +0000 (06:20 +0000)]
move 'msg selection when entering a folder" button to Message List page

... and some English modifications

2 years agoFurther optimize .deleted file reading in RSSyl.
Andrej Kacian [Tue, 13 Nov 2018 22:31:37 +0000 (23:31 +0100)]
Further optimize .deleted file reading in RSSyl.

When updating a feed, only read the file once at the
beginning, instead of reading and rereading it for
every parsed feed item.

2 years agoUse much less disk IO when working with .deleted files in RSSyl.
Andrej Kacian [Tue, 13 Nov 2018 20:41:04 +0000 (21:41 +0100)]
Use much less disk IO when working with .deleted files in RSSyl.

2 years agoRestored a mistakenly removed ifdef.
Andrej Kacian [Mon, 12 Nov 2018 20:23:38 +0000 (21:23 +0100)]
Restored a mistakenly removed ifdef.

2 years agocontiunue the fix for check-at-startup, eade694613c19ffe747ccb77466070e474e3f968
Paul [Sat, 10 Nov 2018 19:42:27 +0000 (19:42 +0000)]
contiunue the fix for check-at-startup, eade694613c19ffe747ccb77466070e474e3f968

The commit eade694613c19ffe747ccb77466070e474e3f968 fixed the case where
'check at startup' completely failed if user did no periodic auto-check.

This commit fixes the double-check at start-up (main.c) and the receive
dialogue being shown, contrary to option for showing the receive
dialogue.

2 years agorearrange /Display/Summaries/Message list (some more)
Paul [Fri, 9 Nov 2018 13:53:05 +0000 (13:53 +0000)]
rearrange /Display/Summaries/Message list (some more)

2 years agoupdate en_GB.po
Paul [Fri, 9 Nov 2018 11:48:49 +0000 (11:48 +0000)]
update en_GB.po

2 years agoDisplay/Summaries/... re-arrange some items
Paul [Fri, 9 Nov 2018 11:26:22 +0000 (11:26 +0000)]
Display/Summaries/... re-arrange some items

2 years agorework Display/Summaries
Paul [Fri, 9 Nov 2018 11:09:06 +0000 (11:09 +0000)]
rework Display/Summaries

spilt the page into 3 notebook pages.
rearrange some options.
add some options for new folder defaults

2 years agomodify label text
Paul [Thu, 8 Nov 2018 19:39:24 +0000 (19:39 +0000)]
modify label text

2 years agofix check for mail at start-up
Paul [Thu, 8 Nov 2018 18:42:43 +0000 (18:42 +0000)]
fix check for mail at start-up

2 years agoremove all gtk3 conditionals
Paul [Wed, 7 Nov 2018 11:46:34 +0000 (11:46 +0000)]
remove all gtk3 conditionals

2 years agoremove --enable-gtk3 configure flag
Paul [Wed, 7 Nov 2018 11:07:17 +0000 (11:07 +0000)]
remove --enable-gtk3 configure flag

2 years agodrop redundant md5 fingerprint; more clearly indicate expired sigs
Paul [Wed, 7 Nov 2018 10:33:06 +0000 (10:33 +0000)]
drop redundant md5 fingerprint; more clearly indicate expired sigs

2 years agoimplement RFE 3810, 'SSL certificate manager: add Signature Status and Expiration'
Paul [Wed, 7 Nov 2018 10:04:37 +0000 (10:04 +0000)]
implement RFE 3810, 'SSL certificate manager: add Signature Status and Expiration'

Add Status and Expiry columns to certificate list, use bold text to
indicate expired certs and failed signatures, and also append
' (expired)' to status where appropriate.

Thanks to Andrej for optimisation in
ssl_manager_list_view_insert_cert().

2 years agofix bug 4114, 'autogen.sh: Fix argument quoting'
Paul [Tue, 6 Nov 2018 06:15:38 +0000 (06:15 +0000)]
fix bug 4114, 'autogen.sh: Fix argument quoting'

patch by Berhard <rep.dot.nop@gmail.com>

2 years agofix bug 4115 'autogen: avoid unwarranted re-configure'
Paul [Tue, 6 Nov 2018 06:14:37 +0000 (06:14 +0000)]
fix bug 4115 'autogen: avoid unwarranted re-configure'

patch by Bernhard <rep.dot.nop@gmail.com>

2 years agoMake sure all users of GtkCMCList do not blindly assume that a button-press-event...
Andrej Kacian [Mon, 5 Nov 2018 23:05:17 +0000 (00:05 +0100)]
Make sure all users of GtkCMCList do not blindly assume that a button-press-event happens inside of the tree view.

If clicking on the header row, the event's x,y coordinates
were pointing to a different spot than what the event handler
code expected, since those coordinates are relative to the
relevant GDK window, and header row has its own. Calls to
gtk_cmclist_get_selection_info() or gtk_sctree_is_hot_spot()
in such cases therefore returned bogus info.

This fixes things like folderview expanding/collapsing
selected folder when double-clicking its header column, or
selecting first row when single-clicking it.

2 years agoUse same integer type for color folder item prefs like everyone else.
Andrej Kacian [Mon, 5 Nov 2018 19:33:07 +0000 (20:33 +0100)]
Use same integer type for color folder item prefs like everyone else.

2 years agoSave folder color as P_COLOR in folderitemrc.
Andrej Kacian [Mon, 5 Nov 2018 19:31:53 +0000 (20:31 +0100)]
Save folder color as P_COLOR in folderitemrc.

The code to handle backward compatibility (color as int)
is already there.

2 years agoAdd config_version to folder item prefs.
Andrej Kacian [Mon, 5 Nov 2018 10:49:21 +0000 (11:49 +0100)]
Add config_version to folder item prefs.

Also some minor code comment and debug output tweaks.

2 years agoFix build on FreeBSD, sys/wait.h is needed for WEXITSTATUS macro
User Corn [Thu, 1 Nov 2018 23:18:48 +0000 (00:18 +0100)]
Fix build on FreeBSD, sys/wait.h is needed for WEXITSTATUS macro

2 years agofix annoyance where your current reading is disturbed when a new msg is filtered...
Paul [Mon, 29 Oct 2018 17:31:51 +0000 (17:31 +0000)]
fix annoyance where your current reading is disturbed when a new msg is filtered into the current folder

2 years agofix for smtp-only accounts when global pref for save sent msg is set
Paul [Mon, 29 Oct 2018 09:03:04 +0000 (09:03 +0000)]
fix for smtp-only accounts when global pref for save sent msg is set

2 years agorevert g45500aa, it breaks stuff
Paul [Mon, 29 Oct 2018 09:01:16 +0000 (09:01 +0000)]
revert g45500aa, it breaks stuff

2 years agoHandle compose "Save Message to" checkbox state in compose_set_save_to() only.
Andrej Kacian [Sun, 28 Oct 2018 20:58:31 +0000 (21:58 +0100)]
Handle compose "Save Message to" checkbox state in compose_set_save_to() only.

Fixes bug #4107 - Sent messages do not appear in "Sent" folder...

2 years agoonly show warning about privacy system 'none' on replies to signed or encrypted msgs
Paul [Fri, 26 Oct 2018 12:38:19 +0000 (13:38 +0100)]
only show warning about privacy system 'none' on replies to signed or encrypted msgs

2 years agoadd error checking on account prefs Advanced page
Paul [Thu, 25 Oct 2018 16:09:16 +0000 (17:09 +0100)]
add error checking on account prefs Advanced page

2 years agoalways use folder pref for save msg location if set
Paul [Thu, 25 Oct 2018 16:08:21 +0000 (17:08 +0100)]
always use folder pref for save msg location if set

2 years agoallow account pref and folder pref to override global pref for saving sent msgs
Paul [Thu, 25 Oct 2018 16:07:19 +0000 (17:07 +0100)]
allow account pref and folder pref to override global pref for saving sent msgs

2 years agoless haste
Paul [Thu, 25 Oct 2018 09:56:44 +0000 (10:56 +0100)]
less haste

2 years agoremove wrongly pushed change in bfc95529975d50e8cda7a85b439aab23f2021c53
Paul [Thu, 25 Oct 2018 09:55:30 +0000 (10:55 +0100)]
remove wrongly pushed change in bfc95529975d50e8cda7a85b439aab23f2021c53

2 years agodon't leave the user in limbo when privacy system is 'none' and auto signing/encrypti...
Paul [Thu, 25 Oct 2018 09:36:54 +0000 (10:36 +0100)]
don't leave the user in limbo when privacy system is 'none' and auto signing/encrypting is set

2 years agoPack account prefs' checkbtn_crosspost into correct hbox, rather than leaving it...
Andrej Kacian [Wed, 24 Oct 2018 15:23:14 +0000 (17:23 +0200)]
Pack account prefs' checkbtn_crosspost into correct hbox, rather than leaving it unused.

2 years agoDo not use gtk_cmctree_set_line_style(), since it does nothing.
Andrej Kacian [Wed, 24 Oct 2018 15:20:10 +0000 (17:20 +0200)]
Do not use gtk_cmctree_set_line_style(), since it does nothing.

2 years agoRemoved deprecated g_type_class_add_private() call in ClawsSpellEntry.
Andrej Kacian [Tue, 23 Oct 2018 18:51:06 +0000 (20:51 +0200)]
Removed deprecated g_type_class_add_private() call in ClawsSpellEntry.

2 years agoUse GTK private struct feature correctly in ClawsSpellEntry.
Andrej Kacian [Tue, 23 Oct 2018 18:46:32 +0000 (20:46 +0200)]
Use GTK private struct feature correctly in ClawsSpellEntry.

g_type_class_add_private() takes care of adding,
initializing and cleaning it up, there is no need
to add another copy of it and manage it manually.

2 years agoRemoved deprecated g_type_class_add_private() call in GtkSHRuler.
Andrej Kacian [Tue, 23 Oct 2018 18:30:49 +0000 (20:30 +0200)]
Removed deprecated g_type_class_add_private() call in GtkSHRuler.

2 years agoRework debug output in passwd_store_set() to be less confusing.
Andrej Kacian [Fri, 19 Oct 2018 21:36:40 +0000 (23:36 +0200)]
Rework debug output in passwd_store_set() to be less confusing.

2 years agoWhen deleting an account, delete its password store block, instead of just NULLing...
Andrej Kacian [Fri, 19 Oct 2018 21:22:20 +0000 (23:22 +0200)]
When deleting an account, delete its password store block, instead of just NULLing the block's entries hash table.

2 years agoFix translation for octet-stream view
Ricardo Mones [Fri, 19 Oct 2018 11:58:11 +0000 (13:58 +0200)]
Fix translation for octet-stream view

2 years agoRewrap fr manual for lisibility
Colin Leroy [Thu, 18 Oct 2018 12:13:58 +0000 (14:13 +0200)]
Rewrap fr manual for lisibility

2 years agoFix crash in dangling message search.
Colin Leroy [Wed, 17 Oct 2018 07:26:26 +0000 (09:26 +0200)]
Fix crash in dangling message search.

2 years agoDo not redraw focus of GtkCMCList if the row is unchanged in move_focus_row();
Andrej Kacian [Tue, 16 Oct 2018 16:18:40 +0000 (18:18 +0200)]
Do not redraw focus of GtkCMCList if the row is unchanged in move_focus_row();

2 years agoIn summary_key_pressed(), do not try to reopen the same message if cursor does not...
Andrej Kacian [Tue, 16 Oct 2018 16:16:02 +0000 (18:16 +0200)]
In summary_key_pressed(), do not try to reopen the same message if cursor does not change.

2 years agoFix an off-by-one error in summary_key_pressed().
Andrej Kacian [Tue, 16 Oct 2018 16:12:05 +0000 (18:12 +0200)]
Fix an off-by-one error in summary_key_pressed().

2 years agofix bug (rfe) 4102, 'Show SHA-256 fingerprint in certificate verification popup'
Paul [Tue, 16 Oct 2018 09:10:03 +0000 (10:10 +0100)]
fix bug (rfe) 4102, 'Show SHA-256 fingerprint in certificate verification popup'

2 years agofix invalid cast runtime warning
Paul [Tue, 16 Oct 2018 06:38:19 +0000 (07:38 +0100)]
fix invalid cast runtime warning

2 years agoPDF Viewer: handle Ctrl+scroll for zooming
Colin Leroy [Mon, 15 Oct 2018 19:15:05 +0000 (21:15 +0200)]
PDF Viewer: handle Ctrl+scroll for zooming

2 years agoFancy: fix left-click on links not opening in browser.
Colin Leroy [Mon, 15 Oct 2018 08:39:21 +0000 (10:39 +0200)]
Fancy: fix left-click on links not opening in browser.

2 years agoMake the "Saving sent message..." debug prints more interesting.
Colin Leroy [Thu, 11 Oct 2018 14:06:39 +0000 (16:06 +0200)]
Make the "Saving sent message..." debug prints more interesting.

2 years agoRevert all memory-based tmpfile I/O, it comes with too much drawbacks
Colin Leroy [Wed, 10 Oct 2018 12:34:34 +0000 (14:34 +0200)]
Revert all memory-based tmpfile I/O, it comes with too much drawbacks
(like having to know the filesize before writing to it)

2 years agoFix wording, thanks wwp
Colin Leroy [Wed, 10 Oct 2018 08:37:23 +0000 (10:37 +0200)]
Fix wording, thanks wwp

2 years agostr_open_as_stream() doesn't need a real file either.
Colin Leroy [Wed, 10 Oct 2018 08:22:09 +0000 (10:22 +0200)]
str_open_as_stream() doesn't need a real file either.

2 years agoComment the my_tmpfile_with_len() function.
Colin Leroy [Wed, 10 Oct 2018 08:09:11 +0000 (10:09 +0200)]
Comment the my_tmpfile_with_len() function.

2 years agoFix in-memory temporary file length
Colin Leroy [Wed, 10 Oct 2018 07:59:10 +0000 (09:59 +0200)]
Fix in-memory temporary file length

2 years agoUpdate textviewer.pl
Ricardo Mones [Mon, 8 Oct 2018 13:51:15 +0000 (15:51 +0200)]
Update textviewer.pl

Patch by H.Merijn Brand

2 years agoUpdate thread tools
Ricardo Mones [Mon, 8 Oct 2018 13:49:29 +0000 (15:49 +0200)]
Update thread tools

Patch by H.Merijn Brand

2 years ago...and one more forgotten NULL check.
Andrej Kacian [Mon, 8 Oct 2018 11:31:31 +0000 (13:31 +0200)]
...and one more forgotten NULL check.

2 years agoAdded some NULL checks in passwordstore.c to avoid potential crash.
Andrej Kacian [Mon, 8 Oct 2018 11:29:21 +0000 (13:29 +0200)]
Added some NULL checks in passwordstore.c to avoid potential crash.

2 years agoFix unit tests building, broken after the file-utils addition.
Andrej Kacian [Mon, 8 Oct 2018 08:34:08 +0000 (10:34 +0200)]
Fix unit tests building, broken after the file-utils addition.

2 years agoFix file-utils related compiler warnings in crash.c.
Andrej Kacian [Mon, 8 Oct 2018 08:33:26 +0000 (10:33 +0200)]
Fix file-utils related compiler warnings in crash.c.

2 years agoFix hang on IMAP - the log file is accessed by multiple threads
Colin Leroy [Sun, 7 Oct 2018 19:31:37 +0000 (21:31 +0200)]
Fix hang on IMAP - the log file is accessed by multiple threads

2 years agoMake safe_fclose static now that it can be
Colin Leroy [Sun, 7 Oct 2018 18:41:20 +0000 (20:41 +0200)]
Make safe_fclose static now that it can be

2 years agoMerge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 18:26:50 +0000 (20:26 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws

2 years agoImprove debug output in passwd_store_set().
Andrej Kacian [Sun, 7 Oct 2018 17:16:15 +0000 (19:16 +0200)]
Improve debug output in passwd_store_set().

2 years agoFix performance loss on certain file I/O that doesn't need
Colin Leroy [Sun, 7 Oct 2018 13:40:38 +0000 (15:40 +0200)]
Fix performance loss on certain file I/O that doesn't need
to be safe

2 years agoAdd a memory-backed my_tmpfile() implementation.
Colin Leroy [Sun, 7 Oct 2018 13:32:38 +0000 (15:32 +0200)]
Add a memory-backed my_tmpfile() implementation.

2 years agoRename claws_io to file-utils, and move file-related functions
Colin Leroy [Sun, 7 Oct 2018 12:46:02 +0000 (14:46 +0200)]
Rename claws_io to file-utils, and move file-related functions
from utils.c to file-utils.c

2 years agoMerge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 12:16:04 +0000 (14:16 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws

2 years agoWrap file I/O to claws_* to benefit from custom locking when
Colin Leroy [Sun, 7 Oct 2018 12:12:29 +0000 (14:12 +0200)]
Wrap file I/O to claws_* to benefit from custom locking when
available. Gains about 33% on I/O bound tasks.

2 years agoFix CID 1439996 and remove unnecessary comparison
Ricardo Mones [Sun, 7 Oct 2018 11:27:30 +0000 (13:27 +0200)]
Fix CID 1439996 and remove unnecessary comparison

2 years agoMerge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 09:11:29 +0000 (11:11 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws

2 years agoHey I'm married :)
Colin Leroy [Sun, 7 Oct 2018 09:11:06 +0000 (11:11 +0200)]
Hey I'm married :)

2 years agoDon't ignore required file
Ricardo Mones [Sat, 6 Oct 2018 14:38:23 +0000 (16:38 +0200)]
Don't ignore required file

2 years agoClean more rubbish
Ricardo Mones [Sat, 6 Oct 2018 12:32:30 +0000 (14:32 +0200)]
Clean more rubbish

2 years agoRemove old files that shouldn't be there
Colin Leroy [Sat, 6 Oct 2018 11:33:07 +0000 (13:33 +0200)]
Remove old files that shouldn't be there

2 years agoFix indent, sorry.
Colin Leroy [Sat, 6 Oct 2018 11:04:16 +0000 (13:04 +0200)]
Fix indent, sorry.

2 years agoFix build
Colin Leroy [Sat, 6 Oct 2018 11:00:00 +0000 (13:00 +0200)]
Fix build

2 years agoUse a memory-based FILE pointer when we can; speeds up search.
Colin Leroy [Sat, 6 Oct 2018 10:48:01 +0000 (12:48 +0200)]
Use a memory-based FILE pointer when we can; speeds up search.

2 years agoDon't bother parsing headers when we want to skip them
Colin Leroy [Sat, 6 Oct 2018 10:46:48 +0000 (12:46 +0200)]
Don't bother parsing headers when we want to skip them
Speeds up body-only search

2 years agoFix big leak on mimeinfo freeing
Colin Leroy [Sat, 6 Oct 2018 10:43:31 +0000 (12:43 +0200)]
Fix big leak on mimeinfo freeing

2 years agoHalve the time spent manipulating case in case-insensitive searches
Colin Leroy [Sat, 6 Oct 2018 09:26:53 +0000 (11:26 +0200)]
Halve the time spent manipulating case in case-insensitive searches

2 years agoImplement safe_fclose() so we can respect the "Metadata handling"
Colin Leroy [Fri, 5 Oct 2018 21:01:46 +0000 (23:01 +0200)]
Implement safe_fclose() so we can respect the "Metadata handling"
preference for every data file we write into.

2 years agoDo not use trim_string() in RSSyl's rename folder dialog.
Andrej Kacian [Thu, 4 Oct 2018 18:25:53 +0000 (20:25 +0200)]
Do not use trim_string() in RSSyl's rename folder dialog.

2 years agoSimplify comparison
Ricardo Mones [Thu, 4 Oct 2018 13:49:07 +0000 (15:49 +0200)]
Simplify comparison

and keep Coverity happy.

2 years agoDisallow zero-length entity
Ricardo Mones [Thu, 4 Oct 2018 08:49:32 +0000 (10:49 +0200)]
Disallow zero-length entity

2 years agoFix CID 1439871 and validate Unicode char strictly
Ricardo Mones [Thu, 4 Oct 2018 08:30:12 +0000 (10:30 +0200)]
Fix CID 1439871 and validate Unicode char strictly

2 years agoMake entity_decode() handle invalid input better.
Andrej Kacian [Wed, 3 Oct 2018 16:27:39 +0000 (18:27 +0200)]
Make entity_decode() handle invalid input better.

2 years agoFix Reply from mainwindow menu and toolbar when mainwindow's
Colin Leroy [Wed, 3 Oct 2018 07:15:30 +0000 (09:15 +0200)]
Fix Reply from mainwindow menu and toolbar when mainwindow's
messageview is hidden.

2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Colin Leroy [Tue, 2 Oct 2018 14:34:17 +0000 (16:34 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws