Paul [Tue, 25 Oct 2016 10:15:39 +0000 (11:15 +0100)]
more 'SSL' to 'SSL/TLS'
Paul [Tue, 25 Oct 2016 10:15:02 +0000 (11:15 +0100)]
more 'SSL' to 'SSL/TLS'
Paul [Tue, 25 Oct 2016 09:36:35 +0000 (10:36 +0100)]
rename SSL to SSL/TLS
Using just 'TLS' is ambiguous. Sometimes it refers to encrypted
connection with TLSv1.0/1.1/1.2, sometimes it refers to STARTTLS
command. So be more specific about what is what.
Patch by Christian Hesse, with some modifications
Paul [Tue, 25 Oct 2016 09:13:53 +0000 (10:13 +0100)]
make /View/Go to/... respect the always_show_msg option, and refactor a bit
wwp [Sat, 22 Oct 2016 12:56:58 +0000 (14:56 +0200)]
While we're at it, fix typos like prefered occurences in variable names.
Ricardo Mones [Sat, 22 Oct 2016 10:57:49 +0000 (12:57 +0200)]
Fix typo (thanks lintian.d.o!)
Ricardo Mones [Mon, 17 Oct 2016 22:13:24 +0000 (00:13 +0200)]
Fix resource leak and missing return
Ricardo Mones [Mon, 17 Oct 2016 12:09:25 +0000 (14:09 +0200)]
Libravatar: refactor image retrieval
And use a synchronous thread for fetching, in preparation
of a future asynchronous fetching. Thanks Andrej for the
ideas.
Pawel Pekala [Tue, 11 Oct 2016 20:47:51 +0000 (22:47 +0200)]
Don't check for encrypt() on FreeBSD, it's not required to build.
Recently on 12-CURRENT this function was removed completly making
configure script fail.
Andrej Kacian [Tue, 11 Oct 2016 12:16:05 +0000 (14:16 +0200)]
Fix typo from commit
63e19c6.
Andrej Kacian [Tue, 11 Oct 2016 11:04:36 +0000 (13:04 +0200)]
Fix wrong argument order in Windows file choosers.
Andrej Kacian [Mon, 10 Oct 2016 18:32:09 +0000 (20:32 +0200)]
Change mention of "mydomain.com" to "example.org".
Fixes bug #3712.
Andrej Kacian [Mon, 10 Oct 2016 18:08:49 +0000 (20:08 +0200)]
Improve plural handling of a file insert string.
Fixes bug #3711.
Ricardo Mones [Wed, 5 Oct 2016 07:51:31 +0000 (09:51 +0200)]
Fix bug #3705: active account Mail Address corrupted…
…when address in Message-ID is used
Ricardo Mones [Tue, 4 Oct 2016 13:29:57 +0000 (15:29 +0200)]
Fix a couple of typos
Ricardo Mones [Mon, 3 Oct 2016 13:54:01 +0000 (15:54 +0200)]
Fix #3014: The icon for folder drafts with hide…
…read messages is the same as when not hidden
Fix disables hiding thread/messages options in draft folders,
hence hrm mode icons are not required for them. Values already
set for these options in draft folders are also ignored.
Many thanks to Andrej and Paul for their feedback on this one.
Andrej Kacian [Sun, 2 Oct 2016 17:04:57 +0000 (19:04 +0200)]
Removed a superfluous debug_print() call.
Andrej Kacian [Sat, 1 Oct 2016 22:11:56 +0000 (00:11 +0200)]
Remove useless code from
e22cbed.
References header was already being honored in drafts.
Andrej Kacian [Sat, 1 Oct 2016 21:41:19 +0000 (23:41 +0200)]
Do not add Message-ID for draft, unless it already has one.
We now add a Message-ID header only when queuing a message,
and we honor existing Message-ID and References headers in
drafts, if there are any.
Paul [Sat, 1 Oct 2016 19:28:39 +0000 (20:28 +0100)]
fix pixmap
fixes "initialization from incompatible pointer type" warning
Andrej Kacian [Sat, 1 Oct 2016 15:55:10 +0000 (17:55 +0200)]
Fix some harmless compiler warnings.
Some variables in notification_popup.c were peeking
out of their ifdefs, and I forgot to remove an
unused variable in vcal_meeting_gtk.c in my commit
8d93e8c.
Andrej Kacian [Sat, 1 Oct 2016 14:22:44 +0000 (16:22 +0200)]
Make Message-ID string generation less confusing.
Instead of having to prepare one part, then second
part in advance and pass them to generate_msgid()
which does its own voodoo with them, we now just pass
a pointer to PrefsAccount to
prefs_account_generate_msgid(), and it does all of it
on its own, returning pointer to a newly allocated
string.
Holger Berndt [Thu, 29 Sep 2016 20:21:02 +0000 (22:21 +0200)]
Notification plugin: Port from libindicate to unity/messaging menu
This is a slightly modified version of the patch from Sebastien Noel,
fixes bug #2665
Holger Berndt [Wed, 28 Sep 2016 20:44:00 +0000 (22:44 +0200)]
GData plugin: Refresh auth token periodically
Fixes bug #3638
Holger Berndt [Wed, 28 Sep 2016 20:22:27 +0000 (22:22 +0200)]
GData plugin: Make global data static
Ricardo Mones [Wed, 28 Sep 2016 22:23:20 +0000 (00:23 +0200)]
Use a spinbutton for port number also in clamd
Default value is now 0 instead of an empty string.
Ricardo Mones [Wed, 28 Sep 2016 22:12:37 +0000 (00:12 +0200)]
Use hours/minutes UI for vcalendar alert time
Holger Berndt [Wed, 28 Sep 2016 10:57:12 +0000 (12:57 +0200)]
GData plugin: Unify indent accross file
Paul [Mon, 26 Sep 2016 09:59:43 +0000 (10:59 +0100)]
add hidden pref 'reqrite_first_from'
'0' or '1'. This works around a limitation of some servers with
'overly-liberal parsers'. When this is turned on and the Content-
Transfer-Encoding is set to 8bit or 7bit, in a message body starting
with 'From ' the 'From ' will become '=46rom ' and the
Content-Transfer-Encoding will be changed to Quoted-Printable. When it
is turned off no such modification will be made but it is very likely
that an MTA will convert the 'From ' to '>From '. See RFC 4155 for
further details. Default value is '1', turned on.
Andrej Kacian [Sun, 25 Sep 2016 14:22:16 +0000 (16:22 +0200)]
Change home directory fallback to "C:\Claws-mail" on Windows.
It is unlikely ever to be used, since CSIDL_APPDATA special
folder is guaranteed to be defined, but still...
Andrej Kacian [Sat, 24 Sep 2016 22:19:50 +0000 (00:19 +0200)]
Fix absolute path detection in mh_create_tree() on Windows.
Ricardo Mones [Fri, 23 Sep 2016 07:33:10 +0000 (09:33 +0200)]
Enable keeping old items by default
Be more conservative towards feed data to avoid unwanted and
unrecoverable loss of items.
Users which don't want to store old items can easily disable
this in feed preferences and also remove obsolete items with
the “Trim” button.
wwp [Fri, 23 Sep 2016 07:26:47 +0000 (09:26 +0200)]
Use Delete button instead of Remove (tooltips and other places already
talk about deletion) in prefs dialogs. Reassign some keyboard hotkeys
accordingly, 'e' for Delete.
wwp [Fri, 23 Sep 2016 07:25:14 +0000 (09:25 +0200)]
Normalize Webcal name capitalization everywhere (instead of WebCal, webCal,
webcal). Rephrase a bit a confirmation dialog to talk about subscription
instead of folder.
Andrej Kacian [Thu, 22 Sep 2016 12:02:09 +0000 (14:02 +0200)]
Better handle NULL path arguments in w32_filesel.c
Fixes bug #3697.
Ricardo Mones [Tue, 20 Sep 2016 17:27:26 +0000 (19:27 +0200)]
Remove unused function
Ricardo Mones [Tue, 20 Sep 2016 17:25:41 +0000 (19:25 +0200)]
Do not abuse macro for debugging
Andrej Kacian [Sun, 18 Sep 2016 08:46:58 +0000 (10:46 +0200)]
Fix using client TLS certificates for GnuTLS 3.0 and up.
3.0 introduced new API for setting client certificates,
gnutls_certificate_set_retrieve_function2().
This fixes bug #3684.
Andrej Kacian [Sat, 17 Sep 2016 21:46:21 +0000 (23:46 +0200)]
Remove an unused, mistyped ifdef in imap.c.
Ricardo Mones [Fri, 16 Sep 2016 17:54:10 +0000 (19:54 +0200)]
Remove useless workaround
The problem is still happening with it, see bug #3511
Ricardo Mones [Wed, 14 Sep 2016 18:30:49 +0000 (20:30 +0200)]
Remove (obsolete) FSF address from welcome mail
Andrej Kacian [Wed, 14 Sep 2016 07:55:28 +0000 (09:55 +0200)]
Removed unused macro from prefs.c.
Andrej Kacian [Tue, 13 Sep 2016 09:53:17 +0000 (11:53 +0200)]
Yet more vcalendar varargs functions fixed for issue described in
d20742e.
Andrej Kacian [Tue, 13 Sep 2016 09:45:22 +0000 (11:45 +0200)]
More fixes for vcalendar crash on 64-bit arch.
Same issue as in commit
d20742e, different place.
This should be the last one, though.
Ricardo Mones [Mon, 12 Sep 2016 22:15:37 +0000 (00:15 +0200)]
Fix another two strangely sized buttons
Ricardo Mones [Mon, 12 Sep 2016 15:23:18 +0000 (17:23 +0200)]
Fix potential segfault
Syslog message was:
[
5473572.496127] claws-mail[24080]: segfault at 22 ip
00000000005704ce sp
00007ffdf1dfcea0 error 4 in
claws-mail[400000+34a000]
$ addr2line -e /…/claws-mail
00000000005704ce
/…/src/textview.c:837
More details on: http://stackoverflow.com/questions/
2179403
Ricardo Mones [Mon, 12 Sep 2016 10:22:49 +0000 (12:22 +0200)]
Adjust to our toolbar button size of 24x24
Andrej Kacian [Sun, 11 Sep 2016 08:15:41 +0000 (10:15 +0200)]
Fix an impossible crash to shut Coverity up.
Andrej Kacian [Sat, 10 Sep 2016 18:19:16 +0000 (20:19 +0200)]
Fix a memory leak in rssyl_update_comments().
Andrej Kacian [Sat, 10 Sep 2016 10:43:12 +0000 (12:43 +0200)]
Do not ignore CFLAGS environment variable in configure.
Andrej Kacian [Sat, 10 Sep 2016 07:28:04 +0000 (09:28 +0200)]
A fix for commit
b274c72.
Whatever FeedItem's ->data is pointing to is being
freed in feed_item_free() already.
Andrej Kacian [Fri, 9 Sep 2016 23:32:47 +0000 (01:32 +0200)]
Fix a memory leak when setting summaryview and folderview fonts.
Andrej Kacian [Fri, 9 Sep 2016 23:09:13 +0000 (01:09 +0200)]
Fixed two memory leaks when creating folderitems.
The Folderitem's "node" member is set to a new empty
GNode in folder_item_new(), but is later set to
another newly allocated GNode.
This commit removes the extra allocation in one case
(folder_new()), and gets rid of the original GNode
in another case, where avoiding the second allocation
is impossible without completely rewriting the recursive
folderitem appending in folder_get_from_xml().
Andrej Kacian [Fri, 9 Sep 2016 22:07:01 +0000 (00:07 +0200)]
Fix memory leak when freeing RSSyl's FeedItem struct.
Andrej Kacian [Fri, 9 Sep 2016 21:43:51 +0000 (23:43 +0200)]
Fix memory leak in password store reading.
Andrej Kacian [Fri, 9 Sep 2016 21:11:52 +0000 (23:11 +0200)]
Fix a memory leak in folder_register_class().
Ricardo Mones [Fri, 9 Sep 2016 19:27:35 +0000 (21:27 +0200)]
Fix potential out-of-bounds read
Ricardo Mones [Wed, 7 Sep 2016 12:08:55 +0000 (14:08 +0200)]
Do not reuse pixmaps for theme icons
Otherwise theme authors may have a hard time finding why an
icon is not themed despite having provided replacements for
all existing xpm files.
Ricardo Mones [Mon, 5 Sep 2016 22:53:24 +0000 (00:53 +0200)]
Remove another unused pixmap
Ricardo Mones [Mon, 5 Sep 2016 07:27:11 +0000 (09:27 +0200)]
Remove unused pixmap
Not used in theme and it wasn't a Claws Mail icon but other
ancient thingy… :)
Ricardo Mones [Mon, 5 Sep 2016 07:21:40 +0000 (09:21 +0200)]
Normalise theme icon names which were different
Ricardo Mones [Fri, 2 Sep 2016 23:20:17 +0000 (01:20 +0200)]
Remove unused declaration
Ricardo Mones [Fri, 2 Sep 2016 23:18:56 +0000 (01:18 +0200)]
Add warning icon to warning message
Refactor warning creation code into a single function.
Andrej Kacian [Fri, 2 Sep 2016 09:22:50 +0000 (11:22 +0200)]
Be more strict about minimum DH prime size for TLS connections.
Since GnuTLS 3.1.7, this minimum size is dictated by the
priority string, and current (GnuTLS 3.3.0) "safe-enough"
value is 1008 bits. We set this minimum size explicitly
for older GnuTLS versions.
Users who are affected by this (their servers use DH prime
smaller than 1008 bits can override this by using priority
string starting with the keyword "LEGACY". This keyword
only works with GnuTLS 3.3.0 or newer, however.
Paul [Fri, 2 Sep 2016 07:21:42 +0000 (08:21 +0100)]
fix `make dist`
wwp [Thu, 1 Sep 2016 22:40:27 +0000 (00:40 +0200)]
Templates: add a way to attach a file, 'attach_output' or 'A', file whose absolute path+filename
is the output of a command-line (it s a mix of 'attach' and 'program'). The first line of the
command-line output is taken into account, trailing newline being stripped down.
Like 'attach', if the filename is not found or not accessible, CM will raise an error. Like
'program', if the command-line fails, no error raises but the standard output of CM shows it.
Ricardo Mones [Thu, 1 Sep 2016 17:40:31 +0000 (19:40 +0200)]
Fix bug #2918: Notification Popup icon is hardcoded
Also fixes last part of bug #3437 by removing the call to deprecated
function gdk_pixbuf_new_from_inline and not using a raw pixmap.
Ricardo Mones [Thu, 1 Sep 2016 17:39:46 +0000 (19:39 +0200)]
Add 64x64 icon version to stock pixmaps
Icon data purloined from last patch of #3437 by Christian Hesse.
Ricardo Mones [Thu, 1 Sep 2016 10:20:02 +0000 (12:20 +0200)]
Forgot to adjust default window size
Ricardo Mones [Wed, 31 Aug 2016 18:48:13 +0000 (20:48 +0200)]
Improve icon legend appearance a bit
Remove extra space and replace scrolled window with a frame.
Colin Leroy [Wed, 31 Aug 2016 15:11:24 +0000 (17:11 +0200)]
Fix a few Coverity issues
Colin Leroy [Wed, 31 Aug 2016 14:47:50 +0000 (16:47 +0200)]
Remove useless code
Colin Leroy [Wed, 31 Aug 2016 14:44:40 +0000 (16:44 +0200)]
Remove useless code
Paul [Wed, 31 Aug 2016 11:37:03 +0000 (12:37 +0100)]
use file name for WebCal subscription folder name
also remove the string length limit, which broke saving folder
properties
Ricardo Mones [Wed, 31 Aug 2016 11:17:25 +0000 (13:17 +0200)]
Better alignment for icon legend columns
Reverts most of
c0abccd31d42122216e3d25341394cd85d949d9b.
Paul [Tue, 30 Aug 2016 15:07:05 +0000 (16:07 +0100)]
fix `make dist`
Paul [Tue, 30 Aug 2016 14:54:25 +0000 (15:54 +0100)]
place icons in 2 columns
Paul [Tue, 30 Aug 2016 11:37:11 +0000 (12:37 +0100)]
remove icons that will never be displayed
Paul [Tue, 30 Aug 2016 10:54:42 +0000 (11:54 +0100)]
fix capitalisation
Paul [Tue, 30 Aug 2016 10:26:45 +0000 (11:26 +0100)]
add 'noselect' and 'subs-only' folder icons
Paul [Tue, 30 Aug 2016 10:22:12 +0000 (11:22 +0100)]
fix non-resizeable Icon Legend dialogue
Paul [Tue, 30 Aug 2016 10:01:59 +0000 (11:01 +0100)]
implement the 4-state icons for 'noselect' folders
Andrej Kacian [Tue, 30 Aug 2016 08:03:06 +0000 (10:03 +0200)]
Fix NULL pointer dereference in LDAP lookup code.
Fixes bug #3027.
Andrej Kacian [Sun, 28 Aug 2016 20:42:10 +0000 (22:42 +0200)]
Fix crash on Windows when doing a LDAP search.
Andrej Kacian [Sun, 28 Aug 2016 18:11:03 +0000 (20:11 +0200)]
Make filesel API more consistent.
One of the functions, filesel_select_multiple_files_open(),
was missing the path parameter.
Andrej Kacian [Sat, 27 Aug 2016 18:41:08 +0000 (20:41 +0200)]
Refactor gtk/w32_filesel.c for better code reuse.
Andrej Kacian [Sat, 27 Aug 2016 17:51:14 +0000 (19:51 +0200)]
Allow multiple file selection in Windows native file chooser.
Paul [Sat, 27 Aug 2016 07:49:19 +0000 (08:49 +0100)]
indicate IMAP mailboxes which show subs only with a green folder
Paul [Fri, 26 Aug 2016 13:55:44 +0000 (14:55 +0100)]
Add OpenBSD CA cert path.
From Edd Barrett via Daniel Jakots
Paul [Fri, 26 Aug 2016 07:51:10 +0000 (08:51 +0100)]
maintain alphabetical ordering
Paul [Fri, 26 Aug 2016 07:39:41 +0000 (08:39 +0100)]
update location of addrbook sub-folder in address conversion scripts
Ricardo Mones [Thu, 25 Aug 2016 10:27:01 +0000 (12:27 +0200)]
Synchronize Spanish manual
Andrej Kacian [Thu, 25 Aug 2016 08:46:34 +0000 (10:46 +0200)]
Always set GnuTLS priority string.
Closes bug #3680.
Andrej Kacian [Wed, 24 Aug 2016 11:52:23 +0000 (13:52 +0200)]
Handle password loading more safely in prefs_account.c
Inspired by patch in bug #3678.
Andrej Kacian [Wed, 24 Aug 2016 11:39:33 +0000 (13:39 +0200)]
Do a basic check for widget validity in CLAWS_SET_TIP().
Inspired by patch in bug #3678.
Ricardo Mones [Wed, 24 Aug 2016 10:14:28 +0000 (12:14 +0200)]
Fix bug #3515: Ctrl-Shift-X opens multiple external editors
This a known GTK+ bug (passing keypresses of disabled menus) or
a mising feature (not providing a way to disable also keypresses).
See https://bugzilla.gnome.org/show_bug.cgi?id=656158
Andrej Kacian [Tue, 23 Aug 2016 22:08:40 +0000 (00:08 +0200)]
Fix crash in vcalendar passwords handling on prefs save.
Andrej Kacian [Tue, 23 Aug 2016 15:55:38 +0000 (17:55 +0200)]
Fix previous commit
b88c772, use correct preprocessor directive.
Andrej Kacian [Tue, 23 Aug 2016 15:47:24 +0000 (17:47 +0200)]
Do not explicitly disable SSLv3 if GnuTLS does it already.
Starting with GnuTLS 3.4.0, SSL 3.0 is no longer
included in the default priorities list.
Ricardo Mones [Mon, 22 Aug 2016 17:07:36 +0000 (19:07 +0200)]
Document the new hidden preference 'hide_timezone'