claws.git
23 months agoUpdate French translation.
wwp [Sun, 6 May 2018 13:48:39 +0000 (15:48 +0200)]
Update French translation.

23 months agoFix warning: ‘struct sockaddr’ declared inside…
Ricardo Mones [Sun, 6 May 2018 09:37:44 +0000 (11:37 +0200)]
Fix warning: ‘struct sockaddr’ declared inside…

By including our utils.h instead of spamassassin homonymous file.

In file included from ../../../src/procmsg.h:32:0,
                 from spamassassin.c:42:
./utils.h:124:47: warning: ‘struct sockaddr’ declared inside parameter list will not be visible outside of this definition or declaration
 int timeout_connect (int sockfd, const struct sockaddr *serv_addr, size_t addrlen);
                                               ^~~~~~~~

23 months agoSave and reuse Actions input/output dialog size.
wwp [Sat, 5 May 2018 21:56:13 +0000 (23:56 +0200)]
Save and reuse Actions input/output dialog size.

23 months agoFix a couple of unused variable warnings
Ricardo Mones [Sat, 5 May 2018 19:59:55 +0000 (21:59 +0200)]
Fix a couple of unused variable warnings

- libspamc.c:491:19: warning: variable ‘family’ set but not used
  (used in a #ifdef block, fix by surrounding by same #ifdef)
- libspamc.c:1911:35: warning: unused variable ‘addrp’
  (used in a commented code block, fix by commenting also declaration)

23 months agoReally ask for confirmation when marking *all* messages as read or
wwp [Sat, 5 May 2018 12:21:53 +0000 (14:21 +0200)]
Really ask for confirmation when marking *all* messages as read or
unread from the message list (as it's done from the folder context
menu). This confirmation dialog is still discardable and still
obeys to the option "Confirm before marking all messages in a folder
as read or unread" in preferences.
A bit of code factorization.

23 months agoFix French translation (unexpected accelerator used in dialog title).
wwp [Sat, 5 May 2018 12:08:18 +0000 (14:08 +0200)]
Fix French translation (unexpected accelerator used in dialog title).

23 months agoSave few warnings around mistyped uses of g_list_length().
wwp [Sat, 5 May 2018 11:46:36 +0000 (13:46 +0200)]
Save few warnings around mistyped uses of g_list_length().

23 months agoCorrect the label of the 'confirm before marking all messages in a
wwp [Sat, 5 May 2018 10:54:29 +0000 (12:54 +0200)]
Correct the label of the 'confirm before marking all messages in a
folder as read' option: it's about marking all as read or UNread.

23 months agoUse a proper CharSet enum value for uninitialized state of static vars,
wwp [Sat, 5 May 2018 07:35:11 +0000 (09:35 +0200)]
Use a proper CharSet enum value for uninitialized state of static vars,
reindent tables for increasing readability.

23 months agoOne more fix for GENERIC_UMPC: summary menu entries list differ.
wwp [Fri, 4 May 2018 17:11:14 +0000 (19:11 +0200)]
One more fix for GENERIC_UMPC: summary menu entries list differ.

23 months agoFix compilation using GENERIC_UMPC.
wwp [Fri, 4 May 2018 13:33:24 +0000 (15:33 +0200)]
Fix compilation using GENERIC_UMPC.

23 months agoFix code compilation when configure --enable-generic-umpc code has been used.
wwp [Fri, 4 May 2018 11:35:56 +0000 (13:35 +0200)]
Fix code compilation when configure --enable-generic-umpc code has been used.

23 months agoDon't manage account list focus state when closing an account edit window,
wwp [Fri, 4 May 2018 07:04:04 +0000 (09:04 +0200)]
Don't manage account list focus state when closing an account edit window,
when this window has been called from main window's "Preferences for
current account" menu item.
Closes bug #4022: Closing "Account Preferences" window opens "Edit Accounts"
window if "Edit Accounts" window has been opened before at least once.

23 months agoFix memory handling around SieveEditorPage.
Andrej Kacian [Thu, 3 May 2018 11:05:46 +0000 (13:05 +0200)]
Fix memory handling around SieveEditorPage.

23 months agoFix some plugins' code indentation.
wwp [Thu, 3 May 2018 08:44:02 +0000 (10:44 +0200)]
Fix some plugins' code indentation.

23 months agoReindent lists and arrays.
wwp [Thu, 3 May 2018 08:15:06 +0000 (10:15 +0200)]
Reindent lists and arrays.

23 months agoIgnore the expander "hot spots" in folderview for childless folders.
Andrej Kacian [Fri, 27 Apr 2018 15:00:37 +0000 (17:00 +0200)]
Ignore the expander "hot spots" in folderview for childless folders.

23 months agoFix sensitivity of the main window's 'View/Message part/View as text' entry
wwp [Wed, 25 Apr 2018 13:48:12 +0000 (15:48 +0200)]
Fix sensitivity of the main window's 'View/Message part/View as text' entry
according to the selected mime part.

23 months agoFix array type to match items
Ricardo Mones [Wed, 25 Apr 2018 13:40:42 +0000 (15:40 +0200)]
Fix array type to match items

Fixes warnings:
• …from log.c:25: /usr/include/glib-2.0/glib/gmacros.h:284:14: warning:
  initialization makes pointer from integer without a cast
• log.c:189:29: warning: return makes integer from pointer without a cast

23 months agoDon't add "Go to last error" to filtering log window's context menu.
wwp [Mon, 23 Apr 2018 16:50:40 +0000 (18:50 +0200)]
Don't add "Go to last error" to filtering log window's context menu.

23 months agoClean-up in comments (The Commit Of The Year).
wwp [Wed, 18 Apr 2018 16:24:06 +0000 (18:24 +0200)]
Clean-up in comments (The Commit Of The Year).

23 months agoFix two missed return values in compose_write_to_file() from commit e9f610a4f.
Andrej Kacian [Wed, 18 Apr 2018 16:19:28 +0000 (18:19 +0200)]
Fix two missed return values in compose_write_to_file() from commit e9f610a4f.

Thanks to wwp for finding the issue!

23 months agoFix unwanted IMAP connections on startup caused by processing rules.
Andrej Kacian [Tue, 17 Apr 2018 19:17:34 +0000 (21:17 +0200)]
Fix unwanted IMAP connections on startup caused by processing rules.

The culprit was a combination of folder_item_prefs_clear()
setting item->enable_processing to TRUE even though default
value should be FALSE, and initial_processing() not skipping
over root folders, which do not have this variable later set
to correct default value in xml_to_folder_item().

Closes bug #3993: Claws Mail connects to IMAP server when it should not

23 months agoFix for e9f610a4f for the rare cases the privacy system has no error string ready.
Andrej Kacian [Fri, 13 Apr 2018 18:25:37 +0000 (20:25 +0200)]
Fix for e9f610a4f for the rare cases the privacy system has no error string ready.

23 months agoRework and simplify how compose_queue() return values are handled
Andrej Kacian [Tue, 10 Apr 2018 17:46:01 +0000 (19:46 +0200)]
Rework and simplify how compose_queue() return values are handled

Also closes bug #3960 - Sends unencrypted emails when encryption fails
because we now return from compose_queue() with an error when
that happens, instead of ignoring it.

23 months agoClamAV plugin: manage read errors (fixes CID #1220483).
wwp [Fri, 13 Apr 2018 10:32:47 +0000 (12:32 +0200)]
ClamAV plugin: manage read errors (fixes CID #1220483).

23 months agoFix another leak in smime plugin (CID #1220437).
wwp [Fri, 13 Apr 2018 10:15:24 +0000 (12:15 +0200)]
Fix another leak in smime plugin (CID #1220437).

23 months agoSpamassassin plug-in: add support for compression (server must have
wwp [Thu, 12 Apr 2018 19:37:21 +0000 (21:37 +0200)]
Spamassassin plug-in: add support for compression (server must have
compression enabled, local spamc too).

23 months agoDisable SSLv3 in libspamc.c (patch from Debian spamassassin package).
wwp [Thu, 12 Apr 2018 15:35:04 +0000 (17:35 +0200)]
Disable SSLv3 in libspamc.c (patch from Debian spamassassin package).

23 months agoFix sensitivity of few preferences widgets of the SA plug-in.
wwp [Wed, 11 Apr 2018 20:25:55 +0000 (22:25 +0200)]
Fix sensitivity of few preferences widgets of the SA plug-in.

23 months agoAdd NOTICE file to EXTRA_DIST.
wwp [Wed, 11 Apr 2018 17:23:21 +0000 (19:23 +0200)]
Add NOTICE file to EXTRA_DIST.

23 months agoAdd SpamAssassin's NOTICE file.
wwp [Wed, 11 Apr 2018 17:22:54 +0000 (19:22 +0200)]
Add SpamAssassin's NOTICE file.

23 months agoSA plugin: better way to make sure Unix sockets are not used in Windows,
wwp [Wed, 11 Apr 2018 17:19:50 +0000 (19:19 +0200)]
SA plugin: better way to make sure Unix sockets are not used in Windows,
from a config coming from Unix: do it when loading the configs, not
when handling the plug-in preferences in GUI.

23 months agofix bug 3978, '"From" column displays both name and email address for Outbox'
Paul [Wed, 11 Apr 2018 14:45:55 +0000 (15:45 +0100)]
fix bug 3978, '"From" column displays both name and email address for Outbox'

23 months agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Wed, 11 Apr 2018 10:19:11 +0000 (12:19 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

23 months agoUse G_OS_WIN32, the glib-proper way to check for WIN32.
wwp [Wed, 11 Apr 2018 10:18:26 +0000 (12:18 +0200)]
Use G_OS_WIN32, the glib-proper way to check for WIN32.

23 months agoSpamassassin plugin in Windows: don't allow Unix socket transport
wwp [Wed, 11 Apr 2018 10:16:03 +0000 (12:16 +0200)]
Spamassassin plugin in Windows: don't allow Unix socket transport
mode (and switch to TCP if the config says Unix socket).

23 months agofix display of Key ID
Paul [Wed, 11 Apr 2018 10:06:29 +0000 (11:06 +0100)]
fix display of Key ID

23 months agoUpdated Apache SpamAssassin code (libspam.[ch], utils.[ch]) from 3.0.x
wwp [Wed, 11 Apr 2018 08:54:47 +0000 (10:54 +0200)]
Updated Apache SpamAssassin code (libspam.[ch], utils.[ch]) from 3.0.x
to 3.4.1.

23 months agoFix a leak, CID #1220437.
wwp [Wed, 11 Apr 2018 07:40:05 +0000 (09:40 +0200)]
Fix a leak, CID #1220437.

23 months agoFix indentation, silents up CID #1434201.
wwp [Wed, 11 Apr 2018 07:32:53 +0000 (09:32 +0200)]
Fix indentation, silents up CID #1434201.

23 months agoFix wrong use of pointer-to-array as an array, CID #1434191.
wwp [Wed, 11 Apr 2018 06:57:32 +0000 (08:57 +0200)]
Fix wrong use of pointer-to-array as an array, CID #1434191.

23 months agoFix buffer overrun, always writing at buffer size + 1.
wwp [Wed, 11 Apr 2018 06:40:57 +0000 (08:40 +0200)]
Fix buffer overrun, always writing at buffer size + 1.
Fixes CID #1434188.

23 months agoFix CID #1434197, mismatch and unneeded display of unavailable folder class
wwp [Wed, 11 Apr 2018 06:30:13 +0000 (08:30 +0200)]
Fix CID #1434197, mismatch and unneeded display of unavailable folder class
in warning.

23 months agoAdd missing src/addrmerge.h file from 3.16.0-107-gf25722a.
wwp [Tue, 10 Apr 2018 07:44:20 +0000 (09:44 +0200)]
Add missing src/addrmerge.h file from 3.16.0-107-gf25722a.

23 months agoCheck for enchant-2 (necessary since enchant 2.1.3).
wwp [Tue, 10 Apr 2018 07:26:21 +0000 (09:26 +0200)]
Check for enchant-2 (necessary since enchant 2.1.3).

23 months agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Paul [Tue, 10 Apr 2018 07:14:21 +0000 (08:14 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

23 months agoAdd a basic contact merging feature to the address book, thanks to
wwp [Mon, 9 Apr 2018 22:23:14 +0000 (00:23 +0200)]
Add a basic contact merging feature to the address book, thanks to
Charles Lehner <cel@celehner.com>.
Closes bug 3346: Contact merging

2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Paul [Sun, 8 Apr 2018 18:32:04 +0000 (19:32 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

2 years agoaddritem_person_get_picture() now returns something useful: a copy
wwp [Sun, 8 Apr 2018 15:03:50 +0000 (17:03 +0200)]
addritem_person_get_picture() now returns something useful: a copy
of the addritem's picture full path (still to be free'd by the caller),
instead of a copy of the addritem's UID string.

2 years agoaddritem+person_get_picture now returns something useful: a copy
wwp [Sun, 8 Apr 2018 15:03:50 +0000 (17:03 +0200)]
addritem+person_get_picture now returns something useful: a copy
of the addritem's picture full path (still to be free'd by the caller),
instead of a copy of the addritem's UID string.

2 years agoRemove the empty progress bar that may remain in status bar after
wwp [Wed, 4 Apr 2018 08:27:01 +0000 (10:27 +0200)]
Remove the empty progress bar that may remain in status bar after
pop3 incorporation (if account is configured to leave messages
on server).
Closes bug 3985: an empty progress bar remains after POP mail check completes

2 years agoreplace deprecated 'NONE' token
Paul [Tue, 3 Apr 2018 09:27:56 +0000 (10:27 +0100)]
replace deprecated 'NONE' token

2 years agoFix broken templates attachments due to commit 814b087,
wwp [Tue, 3 Apr 2018 08:17:58 +0000 (10:17 +0200)]
Fix broken templates attachments due to commit 814b087,
which clears template internals (including attachments list)
wherever template contains any field to apply (To/Subject/etc.)
and before attachments could be processed. Simply process
attachments before attachments list may be cleared by fields
processing. Ideally we should change quote_fmt_reset_vartable()
or its uses in compose.c at least.

2 years agoFix broken build using GTK3
Michael Rasmussen [Fri, 30 Mar 2018 09:47:56 +0000 (11:47 +0200)]
Fix broken build using GTK3

Signed-off-by: Michael Rasmussen <mir@datanom.net>
2 years agoChange how main window's keyboard accelerators are bypassed when quicksearch has...
Andrej Kacian [Fri, 9 Mar 2018 18:24:44 +0000 (19:24 +0100)]
Change how main window's keyboard accelerators are bypassed when quicksearch has focus.

Instead of artificially forwarding the keypress to quicksearch
(only when Shift is pressed), we emit a new "key-press-event"
signal directly to the quicksearch entry, and block the original
signal before it reaches the accelerator handling.

Closes bug #3984: Copy-paste in find/filter field works incorrectly

2 years agoAttachment remover: notify the user about what has been done when processing
wwp [Wed, 28 Mar 2018 21:06:15 +0000 (23:06 +0200)]
Attachment remover: notify the user about what has been done when processing
multiple selections.

2 years agoAdapt identical behaviour to native address book. See commit 47e0437b8b
Michael Rasmussen [Wed, 28 Mar 2018 11:06:26 +0000 (13:06 +0200)]
Adapt identical behaviour to native address book. See commit 47e0437b8b

Signed-off-by: Michael Rasmussen <mir@datanom.net>
2 years agoFix broken build from commit 47e0437b8b
Michael Rasmussen [Wed, 28 Mar 2018 11:04:48 +0000 (13:04 +0200)]
Fix broken build from commit 47e0437b8b

Signed-off-by: Michael Rasmussen <mir@datanom.net>
2 years agoRemove key and free attribute value only if they are valid,
wwp [Mon, 26 Mar 2018 12:01:26 +0000 (14:01 +0200)]
Remove key and free attribute value only if they are valid,
clears CID 1220202.

2 years agoFixed hook_id declarations to be gulong instead of guint.
wwp [Mon, 19 Mar 2018 10:03:09 +0000 (11:03 +0100)]
Fixed hook_id declarations to be gulong instead of guint.
Made statusbar's hook_id static.
Rework hook_id magic value, now 0 instead of -1, and use a define (HOOK_NONE)
everywhere instead of 0. Any hook_id must be initialized to HOOK_NONE.
Hook_id that get invalidated or reset get the same HOOK_NONE value.

2 years agoDon't compute charset unless necessary (vcalviewer_get_uid_from_mimeinfo()),
wwp [Sat, 17 Mar 2018 20:53:20 +0000 (21:53 +0100)]
Don't compute charset unless necessary (vcalviewer_get_uid_from_mimeinfo()),
don't compute charset at all when not used (vcalviewer_get_request_values(),
vcalviewer_get_reply_values(), de facto solves CID 1372373), possible remnants
of an old implementation that I couldn't even found in log.

2 years agoFix possible access to uninitilized folder pointer (CID 1402515),
wwp [Sat, 17 Mar 2018 20:28:00 +0000 (21:28 +0100)]
Fix possible access to uninitilized folder pointer (CID 1402515),
add a warning if vcal folder's not found.

2 years agoSave us 35 warnings about hooks_register_hook() return checks.
wwp [Sat, 17 Mar 2018 19:18:22 +0000 (20:18 +0100)]
Save us 35 warnings about hooks_register_hook() return checks.

2 years agoFew optimizations: avoid strlen when string length is known (read()>0 return);
wwp [Sat, 17 Mar 2018 19:02:48 +0000 (20:02 +0100)]
Few optimizations: avoid strlen when string length is known (read()>0 return);
end string at real end of string instead of at buffer boundary and
be sure we print 0-terminated string (clamd_stream_scan());
clamd_verify_email: discover a strange multi-line response, be sure we
print 0-terminated string (CID 1220483), debug_print all response lines.

2 years agoFix wrong malloc of clamd_socket struct, CID 1220477.
wwp [Sat, 17 Mar 2018 18:34:05 +0000 (19:34 +0100)]
Fix wrong malloc of clamd_socket struct, CID 1220477.

2 years agoHandle IMAP search failure instead of ignoring it.
Andrej Kacian [Wed, 14 Mar 2018 20:35:05 +0000 (21:35 +0100)]
Handle IMAP search failure instead of ignoring it.

Error out on protocol error during search, disconnect
the IMAP session, and display an error dialog about it.

Closes bug 3986 - IMAP quick search using non-ASCII
characters creates an infinite loop

2 years agoClear statusbar's progressbar in case of NNTP xhdr/xover failure.
wwp [Wed, 14 Mar 2018 10:22:47 +0000 (11:22 +0100)]
Clear statusbar's progressbar in case of NNTP xhdr/xover failure.

2 years agoApply the attribute list fix from 8017810c4 also when handling LDAP contacts.
Andrej Kacian [Sat, 10 Mar 2018 11:40:13 +0000 (12:40 +0100)]
Apply the attribute list fix from 8017810c4 also when handling LDAP contacts.

2 years agoFix two crashes caused by bad GtkListStore management in editaddress.c.
Andrej Kacian [Sat, 10 Mar 2018 10:59:11 +0000 (11:59 +0100)]
Fix two crashes caused by bad GtkListStore management in editaddress.c.

2 years agoFix use of uninitialized variable in addressbook edit person dialog.
Andrej Kacian [Mon, 5 Mar 2018 09:33:57 +0000 (10:33 +0100)]
Fix use of uninitialized variable in addressbook edit person dialog.

2 years agoMake LDAP use log_print instead of log_message for uninteresting stuff.
Andrej Kacian [Sat, 3 Mar 2018 17:05:52 +0000 (18:05 +0100)]
Make LDAP use log_print instead of log_message for uninteresting stuff.

This makes it less noisy on the console without --debug if
everything works OK.

2 years agoReplace GtkSCTree in addressbook_foldersel.c with GtkTreeView.
Andrej Kacian [Sat, 3 Mar 2018 16:37:06 +0000 (17:37 +0100)]
Replace GtkSCTree in addressbook_foldersel.c with GtkTreeView.

2 years agoReplace both GtkCMCLists in Edit Person dialog With GtkTreeView.
Andrej Kacian [Sat, 3 Mar 2018 09:28:23 +0000 (10:28 +0100)]
Replace both GtkCMCLists in Edit Person dialog With GtkTreeView.

One for email list, one for attribute list.

2 years agoFix potential crashes in gtkut_tree_view_get_selected_pointer().
Andrej Kacian [Sat, 3 Mar 2018 09:27:56 +0000 (10:27 +0100)]
Fix potential crashes in gtkut_tree_view_get_selected_pointer().

2 years agoRemove unused struct member in SummaryView
Ricardo Mones [Wed, 28 Feb 2018 23:23:15 +0000 (00:23 +0100)]
Remove unused struct member in SummaryView

In the end it wasn't a very important color… ;-)

2 years agoFix a dumb double-free on Windows.
Andrej Kacian [Wed, 28 Feb 2018 18:43:43 +0000 (19:43 +0100)]
Fix a dumb double-free on Windows.

Closes bug 3957: Claws-Mail 64bit crashes when saving a draft

2 years agoFix license version in Address Keeper plugin
Ricardo Mones [Tue, 27 Feb 2018 23:52:50 +0000 (00:52 +0100)]
Fix license version in Address Keeper plugin

2 years agoUpdate uses of gtkut_tree_view_get_selected_pointer().
Andrej Kacian [Tue, 27 Feb 2018 19:24:06 +0000 (20:24 +0100)]
Update uses of gtkut_tree_view_get_selected_pointer().

2 years agoMake the gtkut_tree_view_get_selected_pointer() more versatile.
Andrej Kacian [Tue, 27 Feb 2018 19:19:37 +0000 (20:19 +0100)]
Make the gtkut_tree_view_get_selected_pointer() more versatile.

It can now be used also for non-trivial use cases, where
the caller needs to further work with the model and/or
selection, or if a string value needs to be read from the
model.

2 years agoAdd gtkut_tree_view_get_selected_pointer() helper function.
Andrej Kacian [Sun, 25 Feb 2018 19:40:38 +0000 (20:40 +0100)]
Add gtkut_tree_view_get_selected_pointer() helper function.

It's meant for the simple cases when you just want to get
a pointer out of a treeview's selected row and you're not
going to do anything with the view, nor the model.

2 years agoFix summary_select_all when there is nothing selected.
Andrej Kacian [Mon, 26 Feb 2018 21:06:27 +0000 (22:06 +0100)]
Fix summary_select_all when there is nothing selected.

Due to how GtkCMCList works, we first need to focus and
select a row.
Fixes bug #3973, ''select all' in summaryview does not
automatically focus the summaryview'

2 years agoRevert "fix bug 3973, ''select all' in summaryview does not automatically focus the...
Andrej Kacian [Mon, 26 Feb 2018 21:06:02 +0000 (22:06 +0100)]
Revert "fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'"

This reverts commit a3e48bd6e7e62dedfef8ddedbeeb90400b5234b3.
That commit introduced slowness when selecting all rows.

2 years agoReplace GtkCMCList in browseldap.c with GtkTreeView.
Andrej Kacian [Sun, 25 Feb 2018 15:18:41 +0000 (16:18 +0100)]
Replace GtkCMCList in browseldap.c with GtkTreeView.

2 years agofix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'
Paul [Sun, 25 Feb 2018 13:18:40 +0000 (13:18 +0000)]
fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'

The problem is apparent when 'default selection on entering a folder' is
set to 'none' and the first user action on entering the folder is
'select all'. This visually selected all the messages but summaryview
did not have the focus, so any actions performed on that list would
fail.

Removed summary_select_all(), which didn't quite do as advertised and
instead use gtk_cmclist_select_all() which selects and focuses.

2 years agoMerge needless three gtk_tree_model_get() calls into one.
Andrej Kacian [Sat, 24 Feb 2018 22:35:26 +0000 (23:35 +0100)]
Merge needless three gtk_tree_model_get() calls into one.

2 years agoFix memory leaks from results of gtk_tree_model_get().
Andrej Kacian [Sat, 24 Feb 2018 22:27:35 +0000 (23:27 +0100)]
Fix memory leaks from results of gtk_tree_model_get().

G_TYPE_STRING values need to be freed, G_TYPE_PIXBUF
(or anything else derived from GObject) needs to be
unreferenced. This was forgotten in some places.

2 years agoUnreference GtkTreeModel pointers after they've been added to a tree view.
Andrej Kacian [Sat, 24 Feb 2018 21:30:51 +0000 (22:30 +0100)]
Unreference GtkTreeModel pointers after they've been added to a tree view.

This was forgotten in only a few cases.

2 years agoReplace GtkCMCList in editldap_basedn.c with GtkTreeView.
Andrej Kacian [Sat, 24 Feb 2018 21:14:25 +0000 (22:14 +0100)]
Replace GtkCMCList in editldap_basedn.c with GtkTreeView.

2 years agoReplace GtkCMCTree in addressadd.c with GtkTreeView.
Andrej Kacian [Sat, 24 Feb 2018 19:26:20 +0000 (20:26 +0100)]
Replace GtkCMCTree in addressadd.c with GtkTreeView.

2 years agoRSSyl: fix deleted item checking when modified or published time is missing
Andrej Kacian [Fri, 23 Feb 2018 21:27:35 +0000 (22:27 +0100)]
RSSyl: fix deleted item checking when modified or published time is missing

Fixes bug #3971.

2 years agoReplace GtkCMCList in pgpcore select-keys.c with GtkTreeView.
Andrej Kacian [Mon, 19 Feb 2018 22:22:11 +0000 (23:22 +0100)]
Replace GtkCMCList in pgpcore select-keys.c with GtkTreeView.

While we're at it, activating a row now finishes the
selection dialog without having to press the Select button.

2 years agoReplace GtkCMCList in LDIF import dialog with GtkTreeView.
Andrej Kacian [Sun, 18 Feb 2018 21:25:43 +0000 (22:25 +0100)]
Replace GtkCMCList in LDIF import dialog with GtkTreeView.

2 years agoReplace GtkCMCList in addrgather dialog with GtkTreeView.
Andrej Kacian [Sat, 17 Feb 2018 17:23:48 +0000 (18:23 +0100)]
Replace GtkCMCList in addrgather dialog with GtkTreeView.

2 years agoReplace GtkCMCList in folder sort dialog with GtkTreeView.
Andrej Kacian [Sat, 17 Feb 2018 16:49:08 +0000 (17:49 +0100)]
Replace GtkCMCList in folder sort dialog with GtkTreeView.

2 years agoUse color buttons' macro also here
Ricardo Mones [Fri, 16 Feb 2018 21:50:13 +0000 (22:50 +0100)]
Use color buttons' macro also here

2 years agoAdd support for the iso-8859-8-i encoding
Andrej Kacian [Wed, 14 Feb 2018 22:03:17 +0000 (23:03 +0100)]
Add support for the iso-8859-8-i encoding

Support this encoding by aliasing it to iso-8859-8.

2 years agoMake GtkCMCList/Tree use "text", not "fg" rc property for text color.
Andrej Kacian [Tue, 13 Feb 2018 22:50:15 +0000 (23:50 +0100)]
Make GtkCMCList/Tree use "text", not "fg" rc property for text color.

Closes bug #3880.

2 years agoCast to GSourceFunc instead of deprecated GtkFunction when using g_timeout_add().
Andrej Kacian [Fri, 9 Feb 2018 20:19:31 +0000 (21:19 +0100)]
Cast to GSourceFunc instead of deprecated GtkFunction when using g_timeout_add().

Also correct return type of fancy_show_mimepart_prepare()
callback function.

2 years agoUpdate few occurrences to the new alertpanel() API (and by the way,
wwp [Fri, 9 Feb 2018 21:36:41 +0000 (22:36 +0100)]
Update few occurrences to the new alertpanel() API (and by the way,
solve a leaking button_label strinc allocation).