Ricardo Mones [Mon, 23 Jan 2017 22:48:18 +0000 (23:48 +0100)]
Better error handling and feedback for save all attachments
wwp [Mon, 23 Jan 2017 19:52:13 +0000 (20:52 +0100)]
Update French translation.
wwp [Sat, 21 Jan 2017 22:51:31 +0000 (23:51 +0100)]
No need to test what g_malloc returns, as if it fails, it stops the
program.
wwp [Sat, 21 Jan 2017 14:12:43 +0000 (15:12 +0100)]
Always show a notice dialog after delete-dupes, even if nothing has
been deleted. Make a better notice when it's about marking as delete
(for later deletion when execute is done). Always say we're deleting
dupes, in status bar.
Fix toolbar item sensibility even though if it's not perfect since
the whole button dropdown menu can't be accessed if current folder
can't be searched for dupes.
wwp [Sat, 21 Jan 2017 11:58:50 +0000 (12:58 +0100)]
Show attachments total size in compose window's relevant tab (only counts
attachments size, not encoding or body part, it is not the email
total size).
wwp [Fri, 20 Jan 2017 22:18:56 +0000 (23:18 +0100)]
Main window's toolbar delete dupes button is now a dropdown, allowing
both duplication in selected folder and in all folders. Clicking the
button still raises the deletion in selected (current) folder.
wwp [Fri, 20 Jan 2017 17:02:09 +0000 (18:02 +0100)]
Update func name in g_warning message (_full() may matter since
this _func() function is also called directly).
wwp [Fri, 20 Jan 2017 09:48:08 +0000 (10:48 +0100)]
Normalize rfc822 date handling by using decent buffer sizes everywhere (128,
which is way more than what RFC822 says: 37 max) and specific buffers.
wwp [Thu, 19 Jan 2017 15:39:28 +0000 (16:39 +0100)]
More work on default pixmaps theme, few details in corners to get
icons look nicer on dark and light backgrounds.
wwp [Thu, 19 Jan 2017 13:49:06 +0000 (14:49 +0100)]
Add "Delete duplicates" (delete duplicated messages in current folder) to
the main window's toolbar, including a brand new (not so shining) icon.
wwp [Thu, 19 Jan 2017 13:26:06 +0000 (14:26 +0100)]
Fix a memory leak.
wwp [Wed, 18 Jan 2017 20:55:02 +0000 (21:55 +0100)]
Make few edit fields wider in matcher dialog, better suit their
use (addressbook name, command-line, etc.).
wwp [Wed, 18 Jan 2017 20:48:50 +0000 (21:48 +0100)]
Fix bug 3762, 'redirect fails'
by removing an check added at
3.14.1.39-g989b3a3, thought I was hardening
sanity checks and I changed the logics, making it fail while in normal
situation. Removed few more extraneous checks.
wwp [Tue, 17 Jan 2017 21:44:30 +0000 (22:44 +0100)]
Improvements and fixes in the folder search: prevent changes in
criterias while the search is performing (disable appropriate widgets).
Better disabling/enabling of widgets when changing search modes or
state.
Discard current cached search when switching from/to advanced
search or changing the case sensitivity or changing the matching
any/all mode.
Ricardo Mones [Tue, 17 Jan 2017 13:10:06 +0000 (14:10 +0100)]
Partially revert "Spanish translation: fix headers to be shown in UI"
This reverts the wrong bits in commit
4ac7eb950e352aa10da1e362fda72f1a918f1241
wwp [Tue, 17 Jan 2017 12:41:52 +0000 (13:41 +0100)]
Fix bug 3251, 'A translated In-Reply-To header is sent translated'
by making sure we're always storing untranslated headers.
Optimize and sanitize a bit the code around it, too.
wwp [Tue, 17 Jan 2017 12:39:01 +0000 (13:39 +0100)]
Fix more header names in French.
Ricardo Mones [Tue, 17 Jan 2017 12:12:20 +0000 (13:12 +0100)]
Spanish translation: fix headers to be shown in UI
Also leave X- headers untranslated.
Ricardo Mones [Tue, 17 Jan 2017 10:09:16 +0000 (11:09 +0100)]
Better English (thanks Paul for reference)
Ricardo Mones [Mon, 16 Jan 2017 23:59:27 +0000 (00:59 +0100)]
Update quicksearch info to cope with rfe 2260…
…until it's really fixable, if ever.
wwp [Mon, 16 Jan 2017 22:19:43 +0000 (23:19 +0100)]
Update French translation and fix translated header names (no space).
wwp [Mon, 16 Jan 2017 17:29:15 +0000 (18:29 +0100)]
Fix Coverity CIDs #
1398812, #
1398813, #
1398814.
Will convert compose_convert_header needs for fixed buffers later.
wwp [Mon, 16 Jan 2017 15:35:13 +0000 (16:35 +0100)]
Fix bug 3571, 'recipient list lost and truncated'
by replacing lots of fixed-size buffers with dynamically
allocated ones.
Also enforce checks by adding or fixing few sanity tests,
fix returned value of some functions in some tricky cases.
wwp [Mon, 16 Jan 2017 11:57:36 +0000 (12:57 +0100)]
Fix g4850949 (use correct API calls).
wwp [Mon, 16 Jan 2017 10:54:24 +0000 (11:54 +0100)]
Fix yet another average leak in matcher.c when parsing headers (valgrind).
Paul [Mon, 16 Jan 2017 10:30:17 +0000 (10:30 +0000)]
fix bug 3734, 'undefined symbol error with flex-2.6.2'
Patch by Ashish Gupta
wwp [Mon, 16 Jan 2017 10:03:35 +0000 (11:03 +0100)]
Fix another (not so big but still common) leak, thanks to valgrind.
wwp [Mon, 16 Jan 2017 09:33:05 +0000 (10:33 +0100)]
Fix big leaks (thanks to valgrind) in filtering/matching by headers,
saved (lots of) megabytes here.
wwp [Sat, 14 Jan 2017 07:37:04 +0000 (08:37 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Sat, 14 Jan 2017 07:34:57 +0000 (08:34 +0100)]
Revert part of
3.14.1-128-g498b61c, fixing Coverity CID #
1398594.
Instead of really fixing the wrong call to g_strdup_printf, I prefer
not touching libical code, we'll see later what to do w/ it.
Michael Rasmussen [Fri, 13 Jan 2017 21:41:08 +0000 (22:41 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Michael Rasmussen [Fri, 13 Jan 2017 21:39:10 +0000 (22:39 +0100)]
Fix bug #3673. Patch provided by Perry E. Metzger
Michael Rasmussen [Fri, 13 Jan 2017 21:39:10 +0000 (22:39 +0100)]
Fix build on OSX. Patch provided by Perry E. Metzger
wwp [Fri, 13 Jan 2017 08:19:41 +0000 (09:19 +0100)]
Prefer dynamically allocated buffers to fixed-size ones, use the same
wwp [Fri, 13 Jan 2017 07:46:13 +0000 (08:46 +0100)]
Don't dump more than 100 char in g_warnings about missing HTML tags errors
while parsing, unless --debug mode is set.
wwp [Fri, 13 Jan 2017 07:45:16 +0000 (08:45 +0100)]
Revert ga0fbaac (3.14.1-88) as it gets things worse in folder search,
waiting for a proper fix.
wwp [Thu, 12 Jan 2017 16:26:30 +0000 (17:26 +0100)]
Warn when sending to more than N recipients. This features obeys
to a couple of hidden prefs:
warn_sending_many_recipients (TRUE/FALSE)
warn_sending_many_recipients_num (1-1000)
wwp [Thu, 12 Jan 2017 15:31:10 +0000 (16:31 +0100)]
Add context missing info to few system call errors (mostly:
file operations).
wwp [Thu, 12 Jan 2017 09:06:22 +0000 (10:06 +0100)]
Remove dead code, fixing Coverity CID #
1398568.
wwp [Wed, 11 Jan 2017 22:19:22 +0000 (23:19 +0100)]
Rework logics, remove dead code. Solves Coverity CID #
1220297.
wwp [Wed, 11 Jan 2017 21:41:28 +0000 (22:41 +0100)]
Kill dead code, fixing Coverity CID #
1220511.
wwp [Wed, 11 Jan 2017 15:38:31 +0000 (16:38 +0100)]
Remove accidentally added xpm file.
wwp [Wed, 11 Jan 2017 15:35:05 +0000 (16:35 +0100)]
Add deallocation call.
wwp [Wed, 11 Jan 2017 15:09:08 +0000 (16:09 +0100)]
Quit function if no connection instead of assigning variable that
will be overwriten right after.
Fixes Coverity CID #
1372370.
wwp [Wed, 11 Jan 2017 10:03:56 +0000 (11:03 +0100)]
Rework icon antialiasing to look OK on dark and light themes.
wwp [Wed, 11 Jan 2017 00:56:22 +0000 (01:56 +0100)]
POPPLER_ACTION_MOVIE was not introduced w/ Poppler 0.14.0, but in
a version so old that even my grandma was using it (0.3.0 in fact).
wwp [Wed, 11 Jan 2017 00:31:05 +0000 (01:31 +0100)]
Rework icon antialiasing to look OK on dark and light themes.
wwp [Tue, 10 Jan 2017 15:19:29 +0000 (16:19 +0100)]
Don't #undefine UNIX_PATH_MAX, move #define's up.
wwp [Tue, 10 Jan 2017 14:58:05 +0000 (15:58 +0100)]
Be more clear about what 108 means here towards the Unix socket
path value lenght: rely on UNIX_PATH_MAX and fallback to its common
value '108' in not defined in un.h (caution, on other systems, it could
be 104, etc. down to 92).
wwp [Tue, 10 Jan 2017 13:51:09 +0000 (14:51 +0100)]
Fail if attempting to create a UNIX socket w/ path len >108c.
Add few checks more for socket operations, and reduce few duplicate
initializations.
Saves us warnings and sikves Civerity #
1372360.
wwp [Tue, 10 Jan 2017 09:10:05 +0000 (10:10 +0100)]
Fix Coverity CIDs:
1220259 1364687 (and discarded
1220496) and added more checks for returned
values.
wwp [Tue, 10 Jan 2017 08:59:52 +0000 (09:59 +0100)]
Fix Coverity CIDs:
1220274 and
1220377.
wwp [Tue, 10 Jan 2017 08:36:31 +0000 (09:36 +0100)]
Real fix for Coverity
1372362.
wwp [Tue, 10 Jan 2017 08:31:34 +0000 (09:31 +0100)]
Don't behave as if avail_d was not hardcoded, it is hardcoded
to 7, and do it properly.
Saves us a warning and solves Coverity #
1372366.
wwp [Tue, 10 Jan 2017 08:26:08 +0000 (09:26 +0100)]
Better fix for Coverity #
1220388, use effective indexes and boundaries.
Paul [Mon, 9 Jan 2017 11:37:25 +0000 (11:37 +0000)]
fix typo
wwp [Mon, 9 Jan 2017 10:37:18 +0000 (11:37 +0100)]
Ricardo Mones [Sun, 8 Jan 2017 23:37:04 +0000 (00:37 +0100)]
Attachwarner: fix leaked string
wwp [Fri, 6 Jan 2017 23:46:20 +0000 (00:46 +0100)]
Fix a leak.
wwp [Thu, 5 Jan 2017 17:39:21 +0000 (18:39 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Thu, 5 Jan 2017 17:36:43 +0000 (18:36 +0100)]
Rework antialiasing a bit around toolbar and logo icons, in order
to better fit dark background themes (but still be fine w/ light ones).
wwp [Thu, 5 Jan 2017 09:56:46 +0000 (10:56 +0100)]
Revert parts of 3.14.1-91 (the summary_select_node_no_mard_read func), obviously it's
been accidentally included in that commit and the origin of this modification is still
undetermined.
wwp [Thu, 5 Jan 2017 09:21:50 +0000 (10:21 +0100)]
Fix wrong function definition, declare it before using it, and make it
static.
wwp [Wed, 4 Jan 2017 16:16:09 +0000 (17:16 +0100)]
Fix wrong libarchive version check.
wwp [Wed, 4 Jan 2017 10:32:19 +0000 (11:32 +0100)]
Make the FOO vanish.
wwp [Wed, 4 Jan 2017 10:14:15 +0000 (11:14 +0100)]
Fix marking all as (un)read recursively when the confirmation
dialogue is enabled and the user clicks No: confirmation dialog
was taken into account just for the current folder, subtree was
marked anyway, and this only under certain conditions that I'd
prefer not to list here becau<woosh>
wwp [Wed, 4 Jan 2017 08:13:05 +0000 (09:13 +0100)]
Rename a misnamed function, remove debug statements.
wwp [Tue, 3 Jan 2017 22:36:33 +0000 (23:36 +0100)]
Fix missing array initializers and line everything up.
wwp [Tue, 3 Jan 2017 22:12:02 +0000 (23:12 +0100)]
Fix missing array initializers and line everything up.
wwp [Tue, 3 Jan 2017 21:31:13 +0000 (22:31 +0100)]
Really align array (using whitespaces).
wwp [Tue, 3 Jan 2017 21:20:59 +0000 (22:20 +0100)]
Cosmetic changes: align arrays, remove debug statements.
wwp [Tue, 3 Jan 2017 18:14:10 +0000 (19:14 +0100)]
Archiver plugin update and review:
- updated to support some of the compression formats up to libarchive 3.2.2,
- detect libarchive 2.8+ using pkgconfig,
- use alertpanel API instead of creating gtk dialogs from scratch (with missing
- dialog title, and no clue about what is displayed),
- configure script now makes use of libarchive pkgconfig,
- fixed wrong use of cached page struct info, we do now rely on data set in widgets
to get source folder and target archive filename and sync the page struct info w/ it
when needed,
- renamed gzip/zip to gzip,
- reworked the way archive formats and compression formats lists are displayed (not translatable anymore).
- reformat code a bit.
Holger Berndt [Tue, 3 Jan 2017 10:20:11 +0000 (11:20 +0100)]
GData plugin: Require libgdata at least 0.17.2
Version 0.17.2 is required for auth token save/restore accross restarts.
Without this functionality, the plugin has such bad usability, it's not
worth maintaining. This also fixes the previous compile-error when only
0.17.1 was present.
wwp [Thu, 29 Dec 2016 12:42:46 +0000 (13:42 +0100)]
Fix 'search folder' not working in some cases (it needs a 'clear' click to
work or to manually clear search fields).
Fix provided by Paul, the be(a)st.
Paul [Wed, 28 Dec 2016 12:55:04 +0000 (12:55 +0000)]
make Go to/[Next|Prev] sort order aware
wwp [Tue, 27 Dec 2016 17:06:11 +0000 (18:06 +0100)]
Fix compiler warnings when we test enum-based variables for impossible
<0 values.
wwp [Tue, 27 Dec 2016 17:04:42 +0000 (18:04 +0100)]
Factorize toolbar reset code, and don't compute array sizes using
unsafe calculations.
wwp [Tue, 27 Dec 2016 17:02:55 +0000 (18:02 +0100)]
Fix enum boundaries we check in func_selection_changed (when
changing the internal function assigned to a toolbar item).
Just a theoretical issue here apparently, or we would have had
problems since ages.
wwp [Tue, 27 Dec 2016 16:58:47 +0000 (17:58 +0100)]
More places where printf() and C_() have to be separated.
wwp [Tue, 27 Dec 2016 15:02:27 +0000 (16:02 +0100)]
Line-up arrays (w/ space chars only).
Fix missing array initializers.
wwp [Tue, 27 Dec 2016 14:20:53 +0000 (15:20 +0100)]
Silent up a compiler warning by making the ComposeCallAdvancedAction
enum a real integer-scope ([-1 .. n] instead of [0 .. n]), swallowing
the -1 value check.
wwp [Tue, 27 Dec 2016 14:15:03 +0000 (15:15 +0100)]
Update French translation.
wwp [Tue, 27 Dec 2016 14:11:00 +0000 (15:11 +0100)]
Revert "Revert "Revert g9737584."" (but the fix) by reimplementing
the thing differently: don't mix printf() and C_() as it messes the
compiler up.
Factorize a bit format errors in compose.c.
Make some header names translatable following prefs in the
address keeper plugin.
wwp [Tue, 27 Dec 2016 12:12:22 +0000 (13:12 +0100)]
Fix a leak.
Ricardo Mones [Tue, 27 Dec 2016 12:06:51 +0000 (13:06 +0100)]
Revert "Revert g9737584." and fix it ;)
This reverts commit
834ee304 which was reverting a previous
commit which broke build because of an extra comma. This
reverts the revert and removes the comma.
wwp [Tue, 27 Dec 2016 11:57:37 +0000 (12:57 +0100)]
Revert g9737584.
wwp [Tue, 27 Dec 2016 11:16:56 +0000 (12:16 +0100)]
Add translation context helper text where some %s' are used and
their meaning is not obvious.
Paul [Fri, 23 Dec 2016 11:20:30 +0000 (11:20 +0000)]
removed all useless comments from the end of the po files
wwp [Fri, 23 Dec 2016 10:22:29 +0000 (11:22 +0100)]
Review of the French translation for Xmas:
- huge amount of corrections and changes,
- removed the enormous useless notes chunk.
wwp [Wed, 21 Dec 2016 15:03:15 +0000 (16:03 +0100)]
Update French translation.
wwp [Wed, 21 Dec 2016 15:01:36 +0000 (16:01 +0100)]
Capitalize header names (as everywhere else).
wwp [Wed, 21 Dec 2016 14:52:41 +0000 (15:52 +0100)]
More translatable header names in UI strings.
Ricardo Mones [Wed, 21 Dec 2016 14:12:16 +0000 (15:12 +0100)]
Remove unnecessary commas
They were added by mistake in
f455e02c.
Andrej Kacian [Wed, 21 Dec 2016 12:21:03 +0000 (13:21 +0100)]
Stop left/right keypresses from propagating further in foldersel.
This amends commit
5305715.
Andrej Kacian [Wed, 21 Dec 2016 11:57:47 +0000 (12:57 +0100)]
Moved compose_can_autosave() outside of #ifdef G_OS_UNIX.
wwp [Wed, 21 Dec 2016 09:08:13 +0000 (10:08 +0100)]
Fix wrong string split and list of arguments.
Andrej Kacian [Tue, 20 Dec 2016 22:31:16 +0000 (23:31 +0100)]
Removed an unneeded trailing '\' from Windows' START_TIMING.
Well spotted by Pierre Fortin.
wwp [Tue, 20 Dec 2016 22:01:29 +0000 (23:01 +0100)]
Fix extra arguments to g_strdup_printf (thanks to coverity scan),
add quotes around header names in few dialogs.
wwp [Tue, 20 Dec 2016 10:50:46 +0000 (11:50 +0100)]
Fix untranslatable concatenated strings (i.e. "Default "+"To:"),
normalize few uses of header names in UI.
Andrej Kacian [Mon, 19 Dec 2016 20:30:45 +0000 (21:30 +0100)]
Use left/right keys to collapse/expand rows in foldersel dialog.
Further keypress will move the cursor to parent
or first child, respectively.