Jakub Kicinski [Fri, 12 Dec 2014 08:48:57 +0000 (09:48 +0100)]
Synchronize mailimap deletion against async operations
Right now main thread can free mailimap while its background thread
is still performing operations on it. Fix it by moving deletion to
the worker thread and making sure nobody uses stale pointers.
Jakub Kicinski [Fri, 12 Dec 2014 08:17:34 +0000 (09:17 +0100)]
Swap return value and argument of imap_threaded_capability()
imap_threaded_capability() is the only imap_threaded_*() function
which does not return status, instead status is written to a pointer
passed as argument and function returns retrieved capabilities. To
unify behaviour of all imap_threaded_*() functions make it return
status and pass capabilities through an out argument.
Paul [Tue, 9 Dec 2014 10:46:49 +0000 (10:46 +0000)]
when cancelling a msg written with an external editor, get rid of the draft copy. thanks to Darko Koruga.
Andrej Kacian [Tue, 9 Dec 2014 09:14:40 +0000 (10:14 +0100)]
Compose window: Change Subject mnemonic from 's' to 'u', since 's' is already used by Spelling menu.
Andrej Kacian [Mon, 8 Dec 2014 22:08:29 +0000 (23:08 +0100)]
Compose window: sender address line gets its own label with a mnemonic, similar to Subject line.
Andrej Kacian [Sun, 7 Dec 2014 22:31:41 +0000 (23:31 +0100)]
Properly allocate buffer in conv_encode_header_full() for quoted-printable encoding. Closes bug #3338, reported by Michael Hughes.
Andrej Kacian [Sun, 7 Dec 2014 21:33:26 +0000 (22:33 +0100)]
Compose window: activating the GtkEntry with sender address activates the account selection combobox. Closes bug #3345, reported by Barry Warsaw.
Ricardo Mones [Thu, 4 Dec 2014 15:02:57 +0000 (16:02 +0100)]
Fix crash opening folder (Debian bug #771737)
See https://bugs.debian.org/771737 for details.
Ricardo Mones [Sat, 29 Nov 2014 21:53:33 +0000 (22:53 +0100)]
Fix possible buffer overflow (CVE 2010-5109)
Patch by Petr Písař <ppisar@redhat.com>
RedHat bug: https://bugzilla.redhat.com/show_bug.cgi?id=831322
Debian bug: https://bugs.debian.org/771360
Andrej Kacian [Thu, 27 Nov 2014 02:23:46 +0000 (03:23 +0100)]
RSSyl: Fix argument order for strstr() in Atom parser.
Andrej Kacian [Thu, 27 Nov 2014 02:22:17 +0000 (03:22 +0100)]
RSSyl: Ignore rel="..." feed link in Atom parser.
Andrej Kacian [Thu, 27 Nov 2014 01:12:42 +0000 (02:12 +0100)]
RSSyl: Do not run html entity replacement on URL and item id strings when adding an item.
Andrej Kacian [Thu, 27 Nov 2014 01:12:06 +0000 (02:12 +0100)]
RSSyl: Fix allocated buffer size in previous commit to include space for terminating null byte; Fix minor logic bug.
Andrej Kacian [Thu, 27 Nov 2014 00:00:11 +0000 (01:00 +0100)]
RSSyl: Wrote more robust replacing of HTML character references. We now handle decimal references (Ӓ), in addition to few selected named references.
Ricardo Mones [Mon, 24 Nov 2014 00:43:10 +0000 (01:43 +0100)]
Bug #2577 → improve focus rectangle removal in summaryview
Patch by Andreas Rönnquist, thanks!
Andrej Kacian [Mon, 24 Nov 2014 00:09:52 +0000 (01:09 +0100)]
RSSyl: fix crash introduced by previous commit
Andrej Kacian [Sun, 23 Nov 2014 21:20:37 +0000 (22:20 +0100)]
RSSyl: Convert relative URLs in Atom entries to absolute URLs, using feed's <link> tag, if possible.
Ricardo Mones [Mon, 17 Nov 2014 20:28:28 +0000 (21:28 +0100)]
Fix address out of bounds crash while decoding mails
For reference last stack frame:
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff1e820ca in ?? () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt full
No symbol table info available.
encoded_str=0x7fffffff23e6 "=?UTF-8?B?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>", addr_field=1) at unmime.c:135
decoded_text = 0xffffffffcdd6a0c0 <Address 0xffffffffcdd6a0c0 out of bounds>
quote_p = 0x0
len = 5
p = 0x7fffffff23e6 "=?UTF-8?B?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>"
eword_begin_p = 0x7fffffff23e6 "=?UTF-8?B?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>"
encoding_begin_p = 0x7fffffff23ed "?B?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>"
text_begin_p = 0x7fffffff23ef "?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>"
eword_end_p = 0x7fffffff2404 "?= <david@tilapin.org>"
charset = "UTF-8", '\000' <repeats 19 times>, "\001\000\000\000\000\000\000"
encoding = 66 'B'
conv_str = 0x7fffcdd6a730 "\003"
outbuf = 0xe45380
out_str = 0x7fffcdd60e50 "E1Xq7ru-0002EK-Ro@franck.debian.org"
out_len = 13
in_quote = 0
Colin Leroy [Mon, 17 Nov 2014 14:13:12 +0000 (15:13 +0100)]
* Add a warning in case the length of the string isn't the length of
the decoded base64 content.
* Base64-encoded crypt results of the passwords can contain \0, so
treat them as binary.
Colin Leroy [Mon, 17 Nov 2014 13:47:15 +0000 (14:47 +0100)]
Add a wrapper function to decode base64, returning a null-terminated string.
Colin Leroy [Mon, 17 Nov 2014 08:24:58 +0000 (09:24 +0100)]
Fix use after free
Colin Leroy [Sun, 16 Nov 2014 13:25:12 +0000 (14:25 +0100)]
Fix double free
Andrej Kacian [Sat, 15 Nov 2014 20:40:09 +0000 (21:40 +0100)]
Remove double-free in SMTP AUTH PLAIN handling code.
Andrej Kacian [Sat, 15 Nov 2014 20:37:39 +0000 (21:37 +0100)]
Get rid of a forgotten debug_print().
Andrej Kacian [Sat, 15 Nov 2014 20:11:36 +0000 (21:11 +0100)]
Fix SMTP LOGIN auth method.
Michael Rasmussen [Sat, 15 Nov 2014 19:37:20 +0000 (20:37 +0100)]
fix a couple of memory leaks
Andrej Kacian [Sat, 15 Nov 2014 11:22:03 +0000 (12:22 +0100)]
Use GLib's implementation of Base64 instead of our own.
Michael Rasmussen [Fri, 14 Nov 2014 23:41:21 +0000 (00:41 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Michael Rasmussen [Fri, 14 Nov 2014 23:40:48 +0000 (00:40 +0100)]
remove unused code relating to old unsupported version of libarchive
Andrej Kacian [Fri, 7 Nov 2014 18:11:34 +0000 (19:11 +0100)]
Bogofilter: In addition to deleting or saving a spam message, allow third option, where such message is only marked as spam, but is let through for user to handle it further (perhaps via filtering rules).
Andrej Kacian [Mon, 10 Nov 2014 20:44:19 +0000 (21:44 +0100)]
Increase allowed range for age matcher condition widget. 10000 should be enough for everyone.
Ricardo Mones [Tue, 4 Nov 2014 15:48:06 +0000 (16:48 +0100)]
Fix bug #3321 → revert "Remove unreachable code"
This reverts commit
8090f02e4d5c41be4325f0a13d6b0d98ca03684b.
Many thanks to Andreas Rönnquist for the enlightenment!
Andrej Kacian [Sun, 2 Nov 2014 12:22:02 +0000 (13:22 +0100)]
Revert "RSSyl: Lose the .deleted file on folder move for now" - it will work now, after last commit
This reverts commit
f59759b1ba4e3f02cd87450761da89059d645684.
Andrej Kacian [Sat, 1 Nov 2014 10:27:41 +0000 (11:27 +0100)]
When copying a folder, copy its metadata before copying contents.
wwp [Fri, 31 Oct 2014 10:17:29 +0000 (11:17 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Fri, 31 Oct 2014 10:04:24 +0000 (11:04 +0100)]
Fix compat with libarchive 2.8.x (killed by
3.10.1-85-ga5e54ec).
Paul [Fri, 31 Oct 2014 09:23:24 +0000 (09:23 +0000)]
better implementation of
420e8349978b7c927a80f1a5dd63fd737526feed. thanks to Ticho for the push.
Paul [Thu, 30 Oct 2014 18:52:28 +0000 (18:52 +0000)]
update sf.net project link
Paul [Thu, 30 Oct 2014 18:21:13 +0000 (18:21 +0000)]
implement RFE 3314, 'user can't see validity of gpg signatures' [SIC]
also a little reformatting of similar strings
Ricardo Mones [Tue, 28 Oct 2014 16:34:28 +0000 (17:34 +0100)]
Fix bug #3211 ‘Fails to build in Debian hurd-i386’
Ricardo Mones [Tue, 28 Oct 2014 16:20:23 +0000 (17:20 +0100)]
Recover desktop file installation
Ricardo Mones [Tue, 28 Oct 2014 15:59:16 +0000 (16:59 +0100)]
Fix categories and recover keywords in desktop file
Paul [Tue, 28 Oct 2014 11:16:45 +0000 (11:16 +0000)]
build libindicate support with indicate 0.6 and indicate 0.7
Paul [Mon, 27 Oct 2014 18:54:50 +0000 (18:54 +0000)]
in preparation for release 3.11.1
Paul [Mon, 27 Oct 2014 18:05:08 +0000 (18:05 +0000)]
add Norwegian Bokmål translation, submiited by Eyolf Østrem
Paul [Mon, 27 Oct 2014 17:29:02 +0000 (17:29 +0000)]
remove all traces of intltool, and hence don't install appdata, because it's broken (yes, still!)
Paul [Mon, 27 Oct 2014 17:21:34 +0000 (17:21 +0000)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Conflicts:
po/bg.po
Paul [Mon, 27 Oct 2014 17:19:44 +0000 (17:19 +0000)]
fix fatal error
Andrej Kacian [Fri, 24 Oct 2014 22:57:43 +0000 (00:57 +0200)]
RSSyl: Allow use of .netrc by libcurl. Bug/enhancement #3309, by Vincent Pelletier
Ricardo Mones [Thu, 23 Oct 2014 18:47:18 +0000 (20:47 +0200)]
Fix format for translated desktop keywords
Andrej Kacian [Thu, 23 Oct 2014 16:38:56 +0000 (18:38 +0200)]
RSSyl: Fix memory leak caused by last commit.
Andrej Kacian [Thu, 23 Oct 2014 16:33:42 +0000 (18:33 +0200)]
RSSyl: start using folder cache
Ricardo Mones [Thu, 23 Oct 2014 07:56:19 +0000 (09:56 +0200)]
Free newly created strings from g_markup_printf_escaped
Fixes also build with hardening flags:
• rssyl_update_feed.c:124:6: error: format not a string literal and no
format arguments [-Werror=format-security]
• rssyl_update_feed.c:135:8: error: format not a string literal and no
format arguments [-Werror=format-security]
• rssyl_update_feed.c:222:6: error: format not a string literal and no
format arguments [-Werror=format-security]
Andrej Kacian [Wed, 22 Oct 2014 15:04:56 +0000 (17:04 +0200)]
Use gnutls_priority override for STARTTLS as well.
Andrej Kacian [Tue, 21 Oct 2014 17:47:38 +0000 (19:47 +0200)]
Use gnutls_priority override also for POP3 connections.
Andrej Kacian [Tue, 21 Oct 2014 15:08:27 +0000 (17:08 +0200)]
RSSyl: fix markup escaping in one more alertpanel_error in rssyl_update_feed()
Paul [Tue, 21 Oct 2014 10:55:42 +0000 (11:55 +0100)]
fix bug 3306, 'HTML tag </b> is not always rendered in error dialog'
Paul [Tue, 21 Oct 2014 10:14:53 +0000 (11:14 +0100)]
use standard hyphen-less "Claws Mail" in user-facing strings. Thanks to Thomas Bellmann.
Paul [Tue, 21 Oct 2014 10:10:34 +0000 (11:10 +0100)]
fix some missing whitespace, and standardise the placement of the whitespace. thanks to Thomas Bellmann.
Paul [Tue, 21 Oct 2014 09:53:14 +0000 (10:53 +0100)]
some improvement to appdata summaries
Paul [Mon, 20 Oct 2014 19:26:22 +0000 (20:26 +0100)]
fix `make dist`
Paul [Mon, 20 Oct 2014 19:06:29 +0000 (20:06 +0100)]
3.11.0 unleashed!
Andrej Kacian [Mon, 20 Oct 2014 19:00:57 +0000 (21:00 +0200)]
RSSyl: when user chooses a different folder name for a newly subscribed feed, store the official title, so that it doesn't revert back after first feed update.
Paul [Mon, 20 Oct 2014 18:46:19 +0000 (19:46 +0100)]
updated translations
submitted by Yasen Pramatarov, Thomas Bellmann, Sian Mountbatten, Ricardo Mones Lastra,
Flammie Pirinen, "Genghis Khan", Mindaugas, Marcel Pol, Frederico Goncalves Guimaraes,
Slavko, and Andreas Rönnquist
Paul [Mon, 20 Oct 2014 18:39:15 +0000 (19:39 +0100)]
fix building with --disable-nls
Paul [Mon, 20 Oct 2014 16:49:03 +0000 (17:49 +0100)]
you don't get into AUTHORS just for suggesting an idea, and that's all that the contribution is now
Paul [Mon, 20 Oct 2014 16:43:46 +0000 (17:43 +0100)]
fix `make dist`
Andrej Kacian [Sun, 19 Oct 2014 01:54:04 +0000 (03:54 +0200)]
RSSyl: Lose the .deleted file on folder move for now
Andrej Kacian [Sat, 18 Oct 2014 11:55:38 +0000 (13:55 +0200)]
RSSyl: Copy RFolderItem private data properly.
Andrej Kacian [Sat, 18 Oct 2014 11:18:17 +0000 (13:18 +0200)]
Revert "RSSyl: Just copy all of the custom folderlist xml tags in copy_private_data via folder_item_{get,set}_xml class functions, instead of handling feed properties one by one."
This reverts commit
dc8728ee3222dbe49cdac81e6dc72b2ba206a046.
Colin Leroy [Thu, 16 Oct 2014 12:35:46 +0000 (14:35 +0200)]
Disable SSL3.0 entirely as a Poodle fix.
Andrej Kacian [Sun, 12 Oct 2014 20:09:46 +0000 (22:09 +0200)]
RSSyl: Just copy all of the custom folderlist xml tags in copy_private_data via folder_item_{get,set}_xml class functions, instead of handling feed properties one by one.
Ricardo Mones [Sun, 5 Oct 2014 20:25:51 +0000 (22:25 +0200)]
Libravatar: allow reduced timeout for network requests
Based on original patch from Christian Hesse, thanks!
Ricardo Mones [Sat, 20 Sep 2014 10:41:28 +0000 (12:41 +0200)]
Remove unreachable code
Since this is within the switch case where selection_mode is
GTK_SELECTION_BROWSE the if is always executed and the else
path is never taken.
Paul [Sun, 28 Sep 2014 09:44:31 +0000 (10:44 +0100)]
re: last commit - of course, one debug_print() will do
Paul [Sun, 28 Sep 2014 09:29:56 +0000 (10:29 +0100)]
add more debug_prints in relation to bug 3049
Ricardo Mones [Tue, 23 Sep 2014 11:58:18 +0000 (13:58 +0200)]
Fix typos reported on irc (thanks!)
Ricardo Mones [Tue, 9 Sep 2014 23:15:37 +0000 (01:15 +0200)]
Improve thread-safety in NNTP
Ricardo Mones [Thu, 18 Sep 2014 08:35:22 +0000 (10:35 +0200)]
Fix bug 3285 ‘modify tbird2claws.py to handle subdirectory’
Andrej Kacian [Sun, 14 Sep 2014 03:24:07 +0000 (05:24 +0200)]
RSSyl: Do not use g_strsplit_set() to get the ID from message file, since the ID itself can contain < or > characters. Should fix bug #3282.
Ricardo Mones [Sat, 13 Sep 2014 09:06:15 +0000 (11:06 +0200)]
Add forgotten author of @^^ patch (and others)
Paul [Fri, 12 Sep 2014 06:12:44 +0000 (07:12 +0100)]
fix bug 3265, 'procmime.c: unbalanced flockfile() / funlockfile()'
Patch by Timo Teräs
Ricardo Mones [Wed, 10 Sep 2014 21:37:11 +0000 (23:37 +0200)]
Add new quicksearch for header's content only
• The new “H S” filter searches for mail that contains string S in
the content of any non-internal header.
Based on patches¹² by H.Merijn Brand <h.m.brand@xs4all.nl>, with some
reversion, refactoring, minor improvements and fixed typos.
¹ http://lists.claws-mail.org/pipermail/devel/2014-August/001257.html
² http://lists.claws-mail.org/pipermail/devel/2014-August/001258.html
Ricardo Mones [Mon, 8 Sep 2014 23:07:33 +0000 (01:07 +0200)]
Fancy: disallow editing for empty stylesheets
Paul [Fri, 5 Sep 2014 08:24:39 +0000 (09:24 +0100)]
disallow editing any account (even current account) when at least one compose window is open
wwp [Wed, 3 Sep 2014 11:37:50 +0000 (13:37 +0200)]
Fix a typo.
Paul [Wed, 3 Sep 2014 10:49:17 +0000 (11:49 +0100)]
add Reply-To to template config
Paul [Wed, 3 Sep 2014 07:12:20 +0000 (08:12 +0100)]
fix msg display when utf8_instead_of_locale_for_broken_mail is turned off and you use a UTF-8 locale
Paul [Thu, 28 Aug 2014 09:55:41 +0000 (10:55 +0100)]
Don't differentiate the protocols used when using direct SSL/TLS versus STARTTLS
Patch by Alessandro Di Federico
Andrej Kacian [Wed, 20 Aug 2014 11:02:24 +0000 (13:02 +0200)]
When changing focus in folderview, make sure the newly focused folder is visible first.
Ricardo Mones [Wed, 13 Aug 2014 21:27:14 +0000 (23:27 +0200)]
Improve translation (Debian bug #757929)
Ricardo Mones [Tue, 19 Aug 2014 15:17:30 +0000 (17:17 +0200)]
Fix bug #3246 ‘attachment open: "remember this" ignored if ~/.mailcap does not exist’
Add also a warning if intermediate file cannot be created.
Holger Berndt [Thu, 14 Aug 2014 21:41:00 +0000 (23:41 +0200)]
Python plugin: Make 'account' property of ComposeWindow read/write
Andrej Kacian [Wed, 13 Aug 2014 20:32:01 +0000 (22:32 +0200)]
RSSyl: fix OPML import creating incorrect folder hierarchy
Holger Berndt [Tue, 12 Aug 2014 21:13:52 +0000 (23:13 +0200)]
Python plugin: Add flag attributes to MessageInfo object
Paul [Tue, 5 Aug 2014 06:20:59 +0000 (07:20 +0100)]
fix building without gnuTLS support
Michael Rasmussen [Sat, 2 Aug 2014 13:38:58 +0000 (15:38 +0200)]
Fix to apply to new behavior of foldersel_set_tree. See
247a452
Michael Rasmussen [Sat, 2 Aug 2014 13:37:01 +0000 (15:37 +0200)]
If cur_folder is not NULL then the folder tree will have cur_folder as root
Paul [Sat, 2 Aug 2014 08:06:17 +0000 (09:06 +0100)]
implement RFE 3239, 'Remove "Content-Disposition: attachment" from PGP/MIME signed messages'
modified version of the patch submitted by tdajd@6paq.com
Colin Leroy [Fri, 1 Aug 2014 15:15:26 +0000 (17:15 +0200)]
Fix missing fclose(), thanks to Kevin Day