Andrej Kacian [Fri, 7 Jul 2017 13:28:25 +0000 (15:28 +0200)]
Add Sign/Encrypt toggle buttons to Compose toolbar.
Andrej Kacian [Mon, 10 Jul 2017 22:12:22 +0000 (00:12 +0200)]
Fix a typo.
Andrej Kacian [Mon, 10 Jul 2017 16:36:37 +0000 (18:36 +0200)]
Fix uninitialized values in sieve privacy prefs parsing.
This happens if username and/or password fields are empty,
so sscanf() doesn't get to write into our enc_userid and
enc_passwd buffers.
Andrej Kacian [Mon, 10 Jul 2017 16:11:12 +0000 (18:11 +0200)]
Fix two similar memory leaks in pgp and managesieve prefs.
Andrej Kacian [Mon, 10 Jul 2017 16:01:41 +0000 (18:01 +0200)]
Fix a memory leak in the "no imap" account prefs label.
Andrej Kacian [Mon, 10 Jul 2017 15:56:09 +0000 (17:56 +0200)]
Fix two memory leaks around use of privacy_get_system_ids().
Andrej Kacian [Sun, 9 Jul 2017 21:58:45 +0000 (23:58 +0200)]
Fixed a memory leak when checking TLS certificates.
Andrej Kacian [Sun, 9 Jul 2017 21:55:29 +0000 (23:55 +0200)]
Fix a memory leak in libSM use.
Andrej Kacian [Sun, 9 Jul 2017 21:49:03 +0000 (23:49 +0200)]
Fixed a memory leak in GnuTLS password decryption.
Andrej Kacian [Sun, 9 Jul 2017 16:27:20 +0000 (18:27 +0200)]
Fix a long-standing memory leak in account prefs.
All P_STRING type prefs with non-NULL default values
were being leaked due to overly complicated account
config loading, where we would first initialize
a fresh PrefAccount, then load prefs from config, copying
data between the static tmp_ac_prefs and our dynamically
allocated PrefAccount several times.
Instead of adding another round of data copying from/to
tmp_ac_prefs for purpose of free()ing the P_STRING prefs,
this commit changes prefs_account_read_config() into
prefs_account_new_from_config(), a
Existing accounts are now created with simple:
ac_prefs = prefs_account_new_from_config(...);
instead of previous:
ac_prefs = prefs_account_new();
prefs_account_read_from_config(ac_prefs, ...);
The new function sets up contents of tmp_ac_prefs,
and then its contents are only copied to the newly
allocated PrefsAccount once.
Andrej Kacian [Fri, 7 Jul 2017 10:49:22 +0000 (12:49 +0200)]
Correct the use of pthread_create() in several places.
The second argument should be a pointer to pthread_attr_t,
not a numeric constant. Joinable detachstate is also the
default, we don't need to explicitly set it. Lastly, use
"NULL" for null pthread_attr_t pointer, not "0" (this is
just a cosmetic/consistency thing, but still).
Andrej Kacian [Tue, 4 Jul 2017 10:07:02 +0000 (12:07 +0200)]
Andrej Kacian [Mon, 3 Jul 2017 22:07:49 +0000 (00:07 +0200)]
Fix reading past buffer boundary in RSSyl's strreplace.
Ricardo Mones [Mon, 3 Jul 2017 19:55:23 +0000 (21:55 +0200)]
Fix bug #3348 ‘Contact pictures not deleted when contact is deleted’
Based on original patch submitted by Charles Lehner (thanks!)
Andrej Kacian [Mon, 3 Jul 2017 17:33:03 +0000 (19:33 +0200)]
Removed unused widgetfont pref from PrefsCommon.
Andrej Kacian [Mon, 3 Jul 2017 13:50:47 +0000 (15:50 +0200)]
Revert "Add a 'signature.asc' filename for PGP MIME signatures."
This reverts commit
bd6cfc227c3386329ce7baef2aac10788e47c445.
The change causes more problems than it solves, seeing as
it triggers alarms for a lot of antivirus/antispam software.
Andrej Kacian [Sat, 1 Jul 2017 09:39:06 +0000 (11:39 +0200)]
Removed the "Change to..." fake menuitem from spelling dictionaries menu.
Closes bug #3843: Non-functional "Change to…" command in Spelling menu
Andrej Kacian [Wed, 21 Jun 2017 19:04:22 +0000 (21:04 +0200)]
Add a 'signature.asc' filename for PGP MIME signatures.
This requires Content-Disposition MIME header to be set.
We set the disposition to "inline". Closes bug #3836.
Andrej Kacian [Wed, 21 Jun 2017 14:20:20 +0000 (16:20 +0200)]
Improve password_decrypt_gnutls() to handle encrypted strings of any length.
Colin Leroy [Sun, 18 Jun 2017 19:46:58 +0000 (21:46 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 18 Jun 2017 19:46:08 +0000 (21:46 +0200)]
Fix Toggling of preferences leaving empty view
Webkit can't apparently reload when it loaded a string.
Ricardo Mones [Sat, 17 Jun 2017 15:05:55 +0000 (17:05 +0200)]
Fix bug 3822 ‘AttRemover deletes message and fails to create new one when disk is full’
Paul [Fri, 16 Jun 2017 09:05:15 +0000 (10:05 +0100)]
fix building on MAC. fixes bug 3835, 'autogen.sh fails with invalid test on line 33'
fix by Michael Vilain <michael@vilain.com>
Ricardo Mones [Fri, 9 Jun 2017 06:58:07 +0000 (08:58 +0200)]
Use correct variable in printf
A new buf_date was introduced, but the old pointer (buf) still used in
the printf(). Patch by Olivier Brunel.
Andrej Kacian [Mon, 5 Jun 2017 09:40:52 +0000 (11:40 +0200)]
Fix building for Windows after commit
b320c5095.
Colin Leroy [Sat, 3 Jun 2017 19:57:08 +0000 (21:57 +0200)]
Fix Fancy showing a previous email in some cases.
The problem seemed to be due to something returning
"application/x-extension-html" instead of "text/html"
as MIME types for some emails, stopping rendering.
Using _load_string instead of _load_uri fixes it.
Also, remove some outdated conditionals now we require
Webkit 1.1.14, and replace some deprecated callbacks
with the more recent ones.
Ricardo Mones [Thu, 1 Jun 2017 10:27:15 +0000 (12:27 +0200)]
Fix bug #3721 ‘Fails to build in Debian kfreebsd-*’
Andrej Kacian [Wed, 31 May 2017 19:10:19 +0000 (21:10 +0200)]
Only preserve existing Message-ID when reediting a draft.
This is a followup to commit
e22cbed1f.
Closes Bug 3828 - "Re-edit" should not recycle the Message-ID header
Andrej Kacian [Wed, 31 May 2017 18:38:59 +0000 (20:38 +0200)]
Do not try to handle quotes in text attachments.
Closes Bug 3824 - Quotation Folding is wrongly applied to text
attachments.
Andrej Kacian [Fri, 26 May 2017 19:59:01 +0000 (21:59 +0200)]
Use a better shadow type on pluginwindow's "Description" frame.
This makes it look the same as page name frame on top of
the preference dialog.
Andrej Kacian [Fri, 26 May 2017 19:46:37 +0000 (21:46 +0200)]
Add keyboard shortcuts to pluginwindow Load.../Unload buttons.
Paul [Mon, 22 May 2017 16:56:06 +0000 (17:56 +0100)]
add more utf8 listitem characters
patch by H. Merijn Brand
Andrej Kacian [Sun, 21 May 2017 20:00:03 +0000 (22:00 +0200)]
Some forgotten cleanups for previous commit,
70ea2d849.
Andrej Kacian [Sun, 21 May 2017 19:24:01 +0000 (21:24 +0200)]
Hopefully fixed sporadic crashes in Windows native file chooser.
Ricardo Mones [Sun, 21 May 2017 19:15:42 +0000 (21:15 +0200)]
Remove unused struct
Paul [Sun, 21 May 2017 18:12:51 +0000 (19:12 +0100)]
fix Resent-Date value
Andrej Kacian [Mon, 15 May 2017 20:22:13 +0000 (22:22 +0200)]
RSSyl: Stop earlier when an invalid feed is encountered.
This fixes a bug where feeds get renamed to "Untitled feed"
if their URL starts serving e.g. a HTML document instead
of proper content.
Ricardo Mones [Sun, 14 May 2017 10:06:21 +0000 (12:06 +0200)]
Fix little mess introduced two pushes ago
In commit
6dfe487100b64f7e5ece4c874d7e8c2b72369e4a
Andreas Bierfert [Wed, 29 Mar 2017 07:54:27 +0000 (09:54 +0200)]
Fix bug #3795 ‘typo in utils comparison’
Fix a typo in utils.c which causes a wrong comparison.
Ricardo Mones [Sun, 14 May 2017 09:45:19 +0000 (11:45 +0200)]
Remove one unused and one unnecessary macros
Andrej Kacian [Fri, 12 May 2017 16:20:14 +0000 (18:20 +0200)]
Fix incorrect labels in folder selection dialog
When custom label for folder selection were introduced (in
bd8213fe) a
few ones were wrongly set, specifically ones when copying/moving folders
were talking about copying/moving message(s) instead.
Patch by Olivier Brunel.
Andrej Kacian [Mon, 8 May 2017 13:03:28 +0000 (15:03 +0200)]
Show, hide and set sensitivity of basic page 'Show password' checkbox as appropriate
Andrej Kacian [Sun, 7 May 2017 23:09:53 +0000 (01:09 +0200)]
Fix crash in mailimf_group_parse() in mailmbox plugin.
Fix based on upstream fix:
https://github.com/dinhviethoa/libetpan/commit/1fe8fb
Fixes our bug #3821:
Potential security issue with libetpan code in mailmbox plugin
Ricardo Mones [Thu, 4 May 2017 22:20:39 +0000 (00:20 +0200)]
Fix bug #3819 “Duplicate definition of global pygtk symbols”
Patch by Hanno Boeck (thanks! :)
Ricardo Mones [Wed, 3 May 2017 11:03:57 +0000 (13:03 +0200)]
Add a simple bash completion helper
Andrej Kacian [Sat, 29 Apr 2017 12:35:01 +0000 (14:35 +0200)]
Include more details in doc/src/password_encryption.txt.
Andrej Kacian [Fri, 28 Apr 2017 11:38:54 +0000 (13:38 +0200)]
Use g_strndup() instead of strndup() for better portability.
Fix by Abhay S. Kushwaha.
Ricardo Mones [Thu, 27 Apr 2017 22:31:17 +0000 (00:31 +0200)]
Initialize variable (CID
1405467)
Andrej Kacian [Mon, 24 Apr 2017 16:59:10 +0000 (18:59 +0200)]
Fix crash in sieve manager window when no account has sieve enabled.
The GtkComboBox gets destroyed in such case, but the 'Refresh'
button handler didn't check for that.
Andrej Kacian [Mon, 24 Apr 2017 05:42:27 +0000 (07:42 +0200)]
A fix for a fix in
ea866a633.
Ricardo Mones [Sun, 23 Apr 2017 23:51:48 +0000 (01:51 +0200)]
Unify summaryview icon sizes
There was variety of sizes for the summaryview icons, which have been
moved to a common 12x12 size while keeping the same appearance for
internal theme. This change will allow SVG themes to generate equally
sized icons for summaryview.
Andrej Kacian [Sun, 23 Apr 2017 18:16:58 +0000 (20:16 +0200)]
Fix build for webkitgtk versions between 1.5.1 and 1.9.3.
Andrej Kacian [Sun, 23 Apr 2017 08:33:19 +0000 (10:33 +0200)]
Remove vertical padding from rows in folder selection dialog treeview.
Andrej Kacian [Sat, 22 Apr 2017 11:04:57 +0000 (13:04 +0200)]
Fix building against older webkitgtk versions.
Andrej Kacian [Sat, 22 Apr 2017 08:34:30 +0000 (10:34 +0200)]
Fix get_serverport() in ssl_manager.c to better handle bad filenames.
Andrej Kacian [Fri, 21 Apr 2017 23:15:30 +0000 (01:15 +0200)]
Fancy: simplify open-or-not decision to x,y matching or not
Fixes bug #3814: end of mouse drag or text selection erroneously
activates links
Andrej Kacian [Fri, 21 Apr 2017 23:04:10 +0000 (01:04 +0200)]
Fancy: correctly handle when text selection event ends on a link
Fixes bug #3813 - "mouse up" activates link even if "mouse down"
occurred outside the link / cannot copy link text
...with a small caveat where this is not implemented for
webkitgtk version earlier than 1.5.1, because I couldn't find
relevant old enough API documentation.
Andrej Kacian [Fri, 21 Apr 2017 16:02:38 +0000 (18:02 +0200)]
Remove an unused function - cleanup after
680a2ee67.
Andrej Kacian [Fri, 21 Apr 2017 15:57:04 +0000 (17:57 +0200)]
Rewrite ssl_manager cert filename parsing to allow for ipv6 addresses.
Andrej Kacian [Wed, 19 Apr 2017 17:20:06 +0000 (19:20 +0200)]
Fix configure logic around tnef_parse plugin.
If the plugin is explicitly enabled, but its dependencies
are missing, error out instead of warning and continuing.
Ricardo Mones [Tue, 18 Apr 2017 10:13:33 +0000 (12:13 +0200)]
Fix use after free
Andrej Kacian [Sun, 16 Apr 2017 09:53:55 +0000 (11:53 +0200)]
Promote warn_sending_many_recipients_num from hidden to regular pref.
Andrej Kacian [Sat, 15 Apr 2017 17:41:48 +0000 (19:41 +0200)]
Fix 'add_to_addressbook' filtering action to correctly add the name.
Michael Rasmussen [Fri, 14 Apr 2017 10:47:41 +0000 (12:47 +0200)]
Fix bug #3808: Replace icaltime_from_timet with icaltime_from_timet_with_zone
Andrej Kacian [Thu, 13 Apr 2017 07:06:30 +0000 (09:06 +0200)]
Assume direct TLS if SMTP autoconfig finds port 465.
Technically, this is incorrect:
A direct TLS-only SMTP service is against the standards,
and a "_submission._tcp" SRV record should have a port
that has a plaintext+STARTTLS service listening
(RFC 6186, section 3.1).
Port 465 shouldn't even be used for mail submission of
any kind, according to IANA:
(https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=465)
However, everyone ignores that, and port 465 is routinely
used for TLS-only SMTP service, and therefore it is safe to
assume direct TLS instead of STARTTLS.
Andrej Kacian [Wed, 12 Apr 2017 15:36:07 +0000 (17:36 +0200)]
Fix a memory leak around password field in editldap.c.
Andrej Kacian [Tue, 11 Apr 2017 16:10:14 +0000 (18:10 +0200)]
Add "Show password" checkbox next to LDAP server password field.
Andrej Kacian [Tue, 11 Apr 2017 15:55:46 +0000 (17:55 +0200)]
Add "Show password" checkbox next to password fields in account prefs.
Andrej Kacian [Sun, 9 Apr 2017 16:31:52 +0000 (18:31 +0200)]
Fix GUI not updating after deleting a tag.
Fixes bug #3744 - Crash upon deleting tags.
wwp [Wed, 5 Apr 2017 06:24:48 +0000 (08:24 +0200)]
Fix missing new printer_btn.xpm in `make dist` archive.
Ricardo Mones [Mon, 3 Apr 2017 22:34:47 +0000 (00:34 +0200)]
Adjust yet another addressbook icon
Ricardo Mones [Mon, 3 Apr 2017 22:28:51 +0000 (00:28 +0200)]
Adjust addressbook's tree icons
They were too big for the row height and overflowed into the next.
wwp [Mon, 3 Apr 2017 16:12:10 +0000 (18:12 +0200)]
Fix copy/paste error, thanks to Coverity (#
1403767).
wwp [Mon, 3 Apr 2017 10:41:20 +0000 (12:41 +0200)]
Fix missing include for new pixmap file.
wwp [Mon, 3 Apr 2017 10:30:04 +0000 (12:30 +0200)]
Add new print button to pdf view.
wwp [Mon, 3 Apr 2017 10:27:05 +0000 (12:27 +0200)]
Add new print button to pdf view.
Paul [Sun, 2 Apr 2017 11:24:20 +0000 (12:24 +0100)]
fix bug 3801, 'Broken auto wrapping'
Paul [Sun, 2 Apr 2017 09:08:38 +0000 (10:08 +0100)]
old/new version display
Ricardo Mones [Fri, 31 Mar 2017 18:06:19 +0000 (20:06 +0200)]
Really fix bug #3784: Very similar strings in src/gtk/about.c
Ricardo Mones [Fri, 31 Mar 2017 18:05:25 +0000 (20:05 +0200)]
Add missing library to output of --version-full
Andrej Kacian [Thu, 30 Mar 2017 19:12:13 +0000 (21:12 +0200)]
Make sure outgoing messages have a trailing newline.
This fixes a corner case where if the last line of
a message is a quote, its last character doesn't get
displayed when viewing the copy in outbox.
Paul [Thu, 30 Mar 2017 07:07:28 +0000 (08:07 +0100)]
default selection on entering a folder: make first new|unread|marked message sort-order aware
Andrej Kacian [Wed, 29 Mar 2017 23:56:48 +0000 (01:56 +0200)]
Revert "Fix an off-by-one error in textview's quote unfolding."
This reverts commit
8819febec59e3d5421b0cd4d7882d6524c375bcf.
I refuse to be driven to madness by our textview's colorization.
Andrej Kacian [Wed, 29 Mar 2017 23:55:59 +0000 (01:55 +0200)]
Revert "Fix the other off-by-one bug in textview quoting."
This reverts commit
1acb353987cb2a45b6b6802cc48db6f66aac3121.
I refuse to be driven to madness by our textview's colorization.
Andrej Kacian [Wed, 29 Mar 2017 23:04:22 +0000 (01:04 +0200)]
Fix the other off-by-one bug in textview quoting.
There were two complementary off-by-one bugs, each masking
the other one. Commit 8819fe fixed the first one, thus
unmasking this one.
This should also fix the disgusting bug #3797:
"Unfold quoting renders quotes completely confusing".
Andreas Bierfert [Wed, 29 Mar 2017 08:03:11 +0000 (10:03 +0200)]
Fix bug #3796 format-security warnings in alertpanel_ use
This patch fixes format-security warnings in alertpanel_ use by passing
"%s" as string and the buffer as va argument if no other va arguments
are present.
Andrej Kacian [Mon, 27 Mar 2017 19:02:37 +0000 (21:02 +0200)]
Fix an off-by-one error in textview's quote unfolding.
Paul [Mon, 27 Mar 2017 15:06:11 +0000 (16:06 +0100)]
update Czech and Slovak translations
Paul [Sun, 26 Mar 2017 10:14:26 +0000 (11:14 +0100)]
update German translator
Paul [Sun, 26 Mar 2017 09:56:53 +0000 (10:56 +0100)]
for release 3.15.0
Paul [Sun, 26 Mar 2017 08:59:04 +0000 (09:59 +0100)]
update German translator and use UTF-8 for this file.
Paul [Sun, 26 Mar 2017 08:58:40 +0000 (09:58 +0100)]
update German translator
Paul [Sun, 26 Mar 2017 08:58:16 +0000 (09:58 +0100)]
update translations
Ricardo Mones [Sun, 26 Mar 2017 00:22:47 +0000 (01:22 +0100)]
Fix file name in manpage
Ricardo Mones [Sat, 25 Mar 2017 23:56:59 +0000 (00:56 +0100)]
Update Spanish translation for release
Ricardo Mones [Sat, 25 Mar 2017 23:56:06 +0000 (00:56 +0100)]
Update list of TLDs for release
Andrej Kacian [Fri, 24 Mar 2017 13:04:13 +0000 (14:04 +0100)]
Make summary_show() open-when-selected behavior more consistent.
Fall back to "on folder open" setting when deciding whether
or not to also open the selected message.
Andrej Kacian [Fri, 24 Mar 2017 10:11:58 +0000 (11:11 +0100)]
Fix timezone handling in procheader_date_parse() on Windows.
This fixes logic error introduced in
029174b.
wwp [Tue, 21 Mar 2017 10:59:46 +0000 (11:59 +0100)]
Remove deprecated entries in fr.po.
wwp [Tue, 21 Mar 2017 10:56:09 +0000 (11:56 +0100)]
Update French translation.