claws.git
2 years agoCode cleanup around glib version check (2.28 minimum).
wwp [Mon, 28 May 2018 15:44:59 +0000 (17:44 +0200)]
Code cleanup around glib version check (2.28 minimum).

2 years agoDynamically allocate interface_vtable.
wwp [Mon, 28 May 2018 15:17:05 +0000 (17:17 +0200)]
Dynamically allocate interface_vtable.

2 years agoProperly initialize GDBusInterfaceVTable's private member 'padding' (void*[8]).
wwp [Mon, 28 May 2018 14:45:47 +0000 (16:45 +0200)]
Properly initialize GDBusInterfaceVTable's private member 'padding' (void*[8]).

2 years agoFix warning: missing braces around initializer
Ricardo Mones [Mon, 28 May 2018 12:04:32 +0000 (14:04 +0200)]
Fix warning: missing braces around initializer

2 years agoFix warning: excess elements in struct initializer
Ricardo Mones [Mon, 28 May 2018 12:03:57 +0000 (14:03 +0200)]
Fix warning: excess elements in struct initializer

2 years agofix gcc8 stringop-overflow warning
Paul [Sat, 26 May 2018 10:48:08 +0000 (11:48 +0100)]
fix gcc8 stringop-overflow warning

2 years agofix bug #4023, 'Fix some small issues'
Paul [Sat, 26 May 2018 10:21:19 +0000 (11:21 +0100)]
fix bug #4023, 'Fix some small issues'

* src/common/plugin.c: Remove redundant 'const' qualifier
* src/jpilot.c: Remove redundant parentheses
* src/mbox.c: Likewise
* src/procmsg.c: Use fabs instead of abs for 'double' arg
* src/ textview.c: Declare 'shortcut' only if not GENERIC_UMPC
* src/toolbar.c: Declare 'toolbar_reply_menu_cb()' and
'toolbar_delete_dup_menu_cb' only if not GENERIC_UMPC

Patch by Avinash Sonawane

2 years agoUpdates to the French translation.
wwp [Fri, 25 May 2018 17:01:50 +0000 (19:01 +0200)]
Updates to the French translation.

2 years agoFix missing initializers, taking for reference GLib 2.28 (with support
wwp [Fri, 25 May 2018 07:55:34 +0000 (09:55 +0200)]
Fix missing initializers, taking for reference GLib 2.28 (with support
for up to 2.56) and Python 2.4 (with support for up to 3.6).

2 years agoFix previous commit.
wwp [Thu, 24 May 2018 15:44:38 +0000 (17:44 +0200)]
Fix previous commit.

2 years agoSince we depend on GLib 2.28, make real use of GList/GSList's _free_full
wwp [Thu, 24 May 2018 15:39:03 +0000 (17:39 +0200)]
Since we depend on GLib 2.28, make real use of GList/GSList's _free_full
functions. Remove unused list freeing functions.

2 years agoRevert again support for gdata 0.6.4.
wwp [Thu, 24 May 2018 10:24:05 +0000 (12:24 +0200)]
Revert again support for gdata 0.6.4.

2 years agoupdate UI copyright year
Paul [Wed, 23 May 2018 17:28:55 +0000 (18:28 +0100)]
update UI copyright year

2 years agofix quoting in reply to format=flowed message
Paul [Wed, 23 May 2018 17:10:46 +0000 (18:10 +0100)]
fix quoting in reply to format=flowed message

2 years agoClaws Mail does support gdata 0.6.4.
wwp [Wed, 23 May 2018 06:01:14 +0000 (08:01 +0200)]
Claws Mail does support gdata 0.6.4.

2 years agoUpdate app name in header cartouche and other places, correct
wwp [Tue, 22 May 2018 21:05:29 +0000 (23:05 +0200)]
Update app name in header cartouche and other places, correct
copyrights. Base patch by Abhay S. Kushwaha, with few additions
and slight changes.

2 years agoFix more unchecked return values reported by Coverity:
wwp [Tue, 22 May 2018 17:30:08 +0000 (19:30 +0200)]
Fix more unchecked return values reported by Coverity:
143428214342831434284

2 years agoFix few unchecked return values reported by Coverity:
wwp [Tue, 22 May 2018 17:12:36 +0000 (19:12 +0200)]
Fix few unchecked return values reported by Coverity:
1434187143418914341921434193143419514341961434198143420014342021434203
And few more. Change few silent returns into debug ones (cm_return_if_fail).

2 years agofix syntax error in man page
Paul [Tue, 22 May 2018 10:21:58 +0000 (11:21 +0100)]
fix syntax error in man page

List syntax error. This means .IP, .TP or .RS/.RE markup is garbled.
Common causes include .TP just before a section header, .TP entries
with tags but no bodies, and mandoc lists with no trailing .El.
These confuse doclifter, and may also mess up stricter man-page
browsers like Xman and Rosetta.

Patch by Eric S. Raymond

2 years agoRemove another colon
Ricardo Mones [Wed, 16 May 2018 22:19:24 +0000 (00:19 +0200)]
Remove another colon

2 years agoUpdate lists of contributors
Ricardo Mones [Wed, 16 May 2018 22:15:37 +0000 (00:15 +0200)]
Update lists of contributors

2 years agoFix bug 3895: Port from libnm-util/libnm-glib to libnm
Michael Schwendt [Tue, 13 Mar 2018 20:03:46 +0000 (21:03 +0100)]
Fix bug 3895: Port from libnm-util/libnm-glib to libnm

2 years agowhen using hide_timezone, convert time to UTC
Paul [Wed, 16 May 2018 14:31:03 +0000 (15:31 +0100)]
when using hide_timezone, convert time to UTC

2 years agoforce explicit use of --disable-gnutls if gnutls support is not required
Paul [Tue, 15 May 2018 10:40:52 +0000 (11:40 +0100)]
force explicit use of --disable-gnutls if gnutls support is not required

2 years agorequire nettle, following removal of libcrypt from glibc
Paul [Tue, 15 May 2018 08:59:20 +0000 (09:59 +0100)]
require nettle, following removal of libcrypt from glibc

based on the fedora patch, thanks!

2 years agoRevert last leak fix.
wwp [Wed, 9 May 2018 07:47:02 +0000 (09:47 +0200)]
Revert last leak fix.

2 years agoFix a leak.
wwp [Wed, 9 May 2018 06:50:26 +0000 (08:50 +0200)]
Fix a leak.

2 years agoFix crash in quicksearch keypress handling.
Andrej Kacian [Tue, 8 May 2018 14:54:53 +0000 (16:54 +0200)]
Fix crash in quicksearch keypress handling.

The fourth argument to g_signal_emit_by_name() in this case
is not the signal user data, but a pointer where to store the
return value.

2 years agoForce initialization of buffer (fixes a valgrind case where buf is
wwp [Tue, 8 May 2018 06:54:16 +0000 (08:54 +0200)]
Force initialization of buffer (fixes a valgrind case where buf is
used uninitialized).

2 years agoFix a memory leak in quicksearch code.
wwp [Mon, 7 May 2018 17:00:50 +0000 (19:00 +0200)]
Fix a memory leak in quicksearch code.

2 years agoFix wrong type for layout_mode var in struct.
wwp [Mon, 7 May 2018 11:11:26 +0000 (13:11 +0200)]
Fix wrong type for layout_mode var in struct.

2 years agoMake Claws Mail conservative about color labels: ask for confirmation
wwp [Sun, 6 May 2018 14:02:43 +0000 (16:02 +0200)]
Make Claws Mail conservative about color labels: ask for confirmation
when user clears or override existing color labels to messages.
Confirmation dialog is discardable.

2 years agoUpdate French translation.
wwp [Sun, 6 May 2018 13:48:39 +0000 (15:48 +0200)]
Update French translation.

2 years agoFix warning: ‘struct sockaddr’ declared inside…
Ricardo Mones [Sun, 6 May 2018 09:37:44 +0000 (11:37 +0200)]
Fix warning: ‘struct sockaddr’ declared inside…

By including our utils.h instead of spamassassin homonymous file.

In file included from ../../../src/procmsg.h:32:0,
                 from spamassassin.c:42:
./utils.h:124:47: warning: ‘struct sockaddr’ declared inside parameter list will not be visible outside of this definition or declaration
 int timeout_connect (int sockfd, const struct sockaddr *serv_addr, size_t addrlen);
                                               ^~~~~~~~

2 years agoSave and reuse Actions input/output dialog size.
wwp [Sat, 5 May 2018 21:56:13 +0000 (23:56 +0200)]
Save and reuse Actions input/output dialog size.

2 years agoFix a couple of unused variable warnings
Ricardo Mones [Sat, 5 May 2018 19:59:55 +0000 (21:59 +0200)]
Fix a couple of unused variable warnings

- libspamc.c:491:19: warning: variable ‘family’ set but not used
  (used in a #ifdef block, fix by surrounding by same #ifdef)
- libspamc.c:1911:35: warning: unused variable ‘addrp’
  (used in a commented code block, fix by commenting also declaration)

2 years agoReally ask for confirmation when marking *all* messages as read or
wwp [Sat, 5 May 2018 12:21:53 +0000 (14:21 +0200)]
Really ask for confirmation when marking *all* messages as read or
unread from the message list (as it's done from the folder context
menu). This confirmation dialog is still discardable and still
obeys to the option "Confirm before marking all messages in a folder
as read or unread" in preferences.
A bit of code factorization.

2 years agoFix French translation (unexpected accelerator used in dialog title).
wwp [Sat, 5 May 2018 12:08:18 +0000 (14:08 +0200)]
Fix French translation (unexpected accelerator used in dialog title).

2 years agoSave few warnings around mistyped uses of g_list_length().
wwp [Sat, 5 May 2018 11:46:36 +0000 (13:46 +0200)]
Save few warnings around mistyped uses of g_list_length().

2 years agoCorrect the label of the 'confirm before marking all messages in a
wwp [Sat, 5 May 2018 10:54:29 +0000 (12:54 +0200)]
Correct the label of the 'confirm before marking all messages in a
folder as read' option: it's about marking all as read or UNread.

2 years agoUse a proper CharSet enum value for uninitialized state of static vars,
wwp [Sat, 5 May 2018 07:35:11 +0000 (09:35 +0200)]
Use a proper CharSet enum value for uninitialized state of static vars,
reindent tables for increasing readability.

2 years agoOne more fix for GENERIC_UMPC: summary menu entries list differ.
wwp [Fri, 4 May 2018 17:11:14 +0000 (19:11 +0200)]
One more fix for GENERIC_UMPC: summary menu entries list differ.

2 years agoFix compilation using GENERIC_UMPC.
wwp [Fri, 4 May 2018 13:33:24 +0000 (15:33 +0200)]
Fix compilation using GENERIC_UMPC.

2 years agoFix code compilation when configure --enable-generic-umpc code has been used.
wwp [Fri, 4 May 2018 11:35:56 +0000 (13:35 +0200)]
Fix code compilation when configure --enable-generic-umpc code has been used.

2 years agoDon't manage account list focus state when closing an account edit window,
wwp [Fri, 4 May 2018 07:04:04 +0000 (09:04 +0200)]
Don't manage account list focus state when closing an account edit window,
when this window has been called from main window's "Preferences for
current account" menu item.
Closes bug #4022: Closing "Account Preferences" window opens "Edit Accounts"
window if "Edit Accounts" window has been opened before at least once.

2 years agoFix memory handling around SieveEditorPage.
Andrej Kacian [Thu, 3 May 2018 11:05:46 +0000 (13:05 +0200)]
Fix memory handling around SieveEditorPage.

2 years agoFix some plugins' code indentation.
wwp [Thu, 3 May 2018 08:44:02 +0000 (10:44 +0200)]
Fix some plugins' code indentation.

2 years agoReindent lists and arrays.
wwp [Thu, 3 May 2018 08:15:06 +0000 (10:15 +0200)]
Reindent lists and arrays.

2 years agoIgnore the expander "hot spots" in folderview for childless folders.
Andrej Kacian [Fri, 27 Apr 2018 15:00:37 +0000 (17:00 +0200)]
Ignore the expander "hot spots" in folderview for childless folders.

2 years agoFix sensitivity of the main window's 'View/Message part/View as text' entry
wwp [Wed, 25 Apr 2018 13:48:12 +0000 (15:48 +0200)]
Fix sensitivity of the main window's 'View/Message part/View as text' entry
according to the selected mime part.

2 years agoFix array type to match items
Ricardo Mones [Wed, 25 Apr 2018 13:40:42 +0000 (15:40 +0200)]
Fix array type to match items

Fixes warnings:
• …from log.c:25: /usr/include/glib-2.0/glib/gmacros.h:284:14: warning:
  initialization makes pointer from integer without a cast
• log.c:189:29: warning: return makes integer from pointer without a cast

2 years agoDon't add "Go to last error" to filtering log window's context menu.
wwp [Mon, 23 Apr 2018 16:50:40 +0000 (18:50 +0200)]
Don't add "Go to last error" to filtering log window's context menu.

2 years agoClean-up in comments (The Commit Of The Year).
wwp [Wed, 18 Apr 2018 16:24:06 +0000 (18:24 +0200)]
Clean-up in comments (The Commit Of The Year).

2 years agoFix two missed return values in compose_write_to_file() from commit e9f610a4f.
Andrej Kacian [Wed, 18 Apr 2018 16:19:28 +0000 (18:19 +0200)]
Fix two missed return values in compose_write_to_file() from commit e9f610a4f.

Thanks to wwp for finding the issue!

2 years agoFix unwanted IMAP connections on startup caused by processing rules.
Andrej Kacian [Tue, 17 Apr 2018 19:17:34 +0000 (21:17 +0200)]
Fix unwanted IMAP connections on startup caused by processing rules.

The culprit was a combination of folder_item_prefs_clear()
setting item->enable_processing to TRUE even though default
value should be FALSE, and initial_processing() not skipping
over root folders, which do not have this variable later set
to correct default value in xml_to_folder_item().

Closes bug #3993: Claws Mail connects to IMAP server when it should not

2 years agoFix for e9f610a4f for the rare cases the privacy system has no error string ready.
Andrej Kacian [Fri, 13 Apr 2018 18:25:37 +0000 (20:25 +0200)]
Fix for e9f610a4f for the rare cases the privacy system has no error string ready.

2 years agoRework and simplify how compose_queue() return values are handled
Andrej Kacian [Tue, 10 Apr 2018 17:46:01 +0000 (19:46 +0200)]
Rework and simplify how compose_queue() return values are handled

Also closes bug #3960 - Sends unencrypted emails when encryption fails
because we now return from compose_queue() with an error when
that happens, instead of ignoring it.

2 years agoClamAV plugin: manage read errors (fixes CID #1220483).
wwp [Fri, 13 Apr 2018 10:32:47 +0000 (12:32 +0200)]
ClamAV plugin: manage read errors (fixes CID #1220483).

2 years agoFix another leak in smime plugin (CID #1220437).
wwp [Fri, 13 Apr 2018 10:15:24 +0000 (12:15 +0200)]
Fix another leak in smime plugin (CID #1220437).

2 years agoSpamassassin plug-in: add support for compression (server must have
wwp [Thu, 12 Apr 2018 19:37:21 +0000 (21:37 +0200)]
Spamassassin plug-in: add support for compression (server must have
compression enabled, local spamc too).

2 years agoDisable SSLv3 in libspamc.c (patch from Debian spamassassin package).
wwp [Thu, 12 Apr 2018 15:35:04 +0000 (17:35 +0200)]
Disable SSLv3 in libspamc.c (patch from Debian spamassassin package).

2 years agoFix sensitivity of few preferences widgets of the SA plug-in.
wwp [Wed, 11 Apr 2018 20:25:55 +0000 (22:25 +0200)]
Fix sensitivity of few preferences widgets of the SA plug-in.

2 years agoAdd NOTICE file to EXTRA_DIST.
wwp [Wed, 11 Apr 2018 17:23:21 +0000 (19:23 +0200)]
Add NOTICE file to EXTRA_DIST.

2 years agoAdd SpamAssassin's NOTICE file.
wwp [Wed, 11 Apr 2018 17:22:54 +0000 (19:22 +0200)]
Add SpamAssassin's NOTICE file.

2 years agoSA plugin: better way to make sure Unix sockets are not used in Windows,
wwp [Wed, 11 Apr 2018 17:19:50 +0000 (19:19 +0200)]
SA plugin: better way to make sure Unix sockets are not used in Windows,
from a config coming from Unix: do it when loading the configs, not
when handling the plug-in preferences in GUI.

2 years agofix bug 3978, '"From" column displays both name and email address for Outbox'
Paul [Wed, 11 Apr 2018 14:45:55 +0000 (15:45 +0100)]
fix bug 3978, '"From" column displays both name and email address for Outbox'

2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
wwp [Wed, 11 Apr 2018 10:19:11 +0000 (12:19 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

2 years agoUse G_OS_WIN32, the glib-proper way to check for WIN32.
wwp [Wed, 11 Apr 2018 10:18:26 +0000 (12:18 +0200)]
Use G_OS_WIN32, the glib-proper way to check for WIN32.

2 years agoSpamassassin plugin in Windows: don't allow Unix socket transport
wwp [Wed, 11 Apr 2018 10:16:03 +0000 (12:16 +0200)]
Spamassassin plugin in Windows: don't allow Unix socket transport
mode (and switch to TCP if the config says Unix socket).

2 years agofix display of Key ID
Paul [Wed, 11 Apr 2018 10:06:29 +0000 (11:06 +0100)]
fix display of Key ID

2 years agoUpdated Apache SpamAssassin code (libspam.[ch], utils.[ch]) from 3.0.x
wwp [Wed, 11 Apr 2018 08:54:47 +0000 (10:54 +0200)]
Updated Apache SpamAssassin code (libspam.[ch], utils.[ch]) from 3.0.x
to 3.4.1.

2 years agoFix a leak, CID #1220437.
wwp [Wed, 11 Apr 2018 07:40:05 +0000 (09:40 +0200)]
Fix a leak, CID #1220437.

2 years agoFix indentation, silents up CID #1434201.
wwp [Wed, 11 Apr 2018 07:32:53 +0000 (09:32 +0200)]
Fix indentation, silents up CID #1434201.

2 years agoFix wrong use of pointer-to-array as an array, CID #1434191.
wwp [Wed, 11 Apr 2018 06:57:32 +0000 (08:57 +0200)]
Fix wrong use of pointer-to-array as an array, CID #1434191.

2 years agoFix buffer overrun, always writing at buffer size + 1.
wwp [Wed, 11 Apr 2018 06:40:57 +0000 (08:40 +0200)]
Fix buffer overrun, always writing at buffer size + 1.
Fixes CID #1434188.

2 years agoFix CID #1434197, mismatch and unneeded display of unavailable folder class
wwp [Wed, 11 Apr 2018 06:30:13 +0000 (08:30 +0200)]
Fix CID #1434197, mismatch and unneeded display of unavailable folder class
in warning.

2 years agoAdd missing src/addrmerge.h file from 3.16.0-107-gf25722a.
wwp [Tue, 10 Apr 2018 07:44:20 +0000 (09:44 +0200)]
Add missing src/addrmerge.h file from 3.16.0-107-gf25722a.

2 years agoCheck for enchant-2 (necessary since enchant 2.1.3).
wwp [Tue, 10 Apr 2018 07:26:21 +0000 (09:26 +0200)]
Check for enchant-2 (necessary since enchant 2.1.3).

2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Paul [Tue, 10 Apr 2018 07:14:21 +0000 (08:14 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

2 years agoAdd a basic contact merging feature to the address book, thanks to
wwp [Mon, 9 Apr 2018 22:23:14 +0000 (00:23 +0200)]
Add a basic contact merging feature to the address book, thanks to
Charles Lehner <cel@celehner.com>.
Closes bug 3346: Contact merging

2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Paul [Sun, 8 Apr 2018 18:32:04 +0000 (19:32 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

2 years agoaddritem_person_get_picture() now returns something useful: a copy
wwp [Sun, 8 Apr 2018 15:03:50 +0000 (17:03 +0200)]
addritem_person_get_picture() now returns something useful: a copy
of the addritem's picture full path (still to be free'd by the caller),
instead of a copy of the addritem's UID string.

2 years agoaddritem+person_get_picture now returns something useful: a copy
wwp [Sun, 8 Apr 2018 15:03:50 +0000 (17:03 +0200)]
addritem+person_get_picture now returns something useful: a copy
of the addritem's picture full path (still to be free'd by the caller),
instead of a copy of the addritem's UID string.

2 years agoRemove the empty progress bar that may remain in status bar after
wwp [Wed, 4 Apr 2018 08:27:01 +0000 (10:27 +0200)]
Remove the empty progress bar that may remain in status bar after
pop3 incorporation (if account is configured to leave messages
on server).
Closes bug 3985: an empty progress bar remains after POP mail check completes

2 years agoreplace deprecated 'NONE' token
Paul [Tue, 3 Apr 2018 09:27:56 +0000 (10:27 +0100)]
replace deprecated 'NONE' token

2 years agoFix broken templates attachments due to commit 814b087,
wwp [Tue, 3 Apr 2018 08:17:58 +0000 (10:17 +0200)]
Fix broken templates attachments due to commit 814b087,
which clears template internals (including attachments list)
wherever template contains any field to apply (To/Subject/etc.)
and before attachments could be processed. Simply process
attachments before attachments list may be cleared by fields
processing. Ideally we should change quote_fmt_reset_vartable()
or its uses in compose.c at least.

2 years agoFix broken build using GTK3
Michael Rasmussen [Fri, 30 Mar 2018 09:47:56 +0000 (11:47 +0200)]
Fix broken build using GTK3

Signed-off-by: Michael Rasmussen <mir@datanom.net>
2 years agoChange how main window's keyboard accelerators are bypassed when quicksearch has...
Andrej Kacian [Fri, 9 Mar 2018 18:24:44 +0000 (19:24 +0100)]
Change how main window's keyboard accelerators are bypassed when quicksearch has focus.

Instead of artificially forwarding the keypress to quicksearch
(only when Shift is pressed), we emit a new "key-press-event"
signal directly to the quicksearch entry, and block the original
signal before it reaches the accelerator handling.

Closes bug #3984: Copy-paste in find/filter field works incorrectly

2 years agoAttachment remover: notify the user about what has been done when processing
wwp [Wed, 28 Mar 2018 21:06:15 +0000 (23:06 +0200)]
Attachment remover: notify the user about what has been done when processing
multiple selections.

2 years agoAdapt identical behaviour to native address book. See commit 47e0437b8b
Michael Rasmussen [Wed, 28 Mar 2018 11:06:26 +0000 (13:06 +0200)]
Adapt identical behaviour to native address book. See commit 47e0437b8b

Signed-off-by: Michael Rasmussen <mir@datanom.net>
2 years agoFix broken build from commit 47e0437b8b
Michael Rasmussen [Wed, 28 Mar 2018 11:04:48 +0000 (13:04 +0200)]
Fix broken build from commit 47e0437b8b

Signed-off-by: Michael Rasmussen <mir@datanom.net>
2 years agoRemove key and free attribute value only if they are valid,
wwp [Mon, 26 Mar 2018 12:01:26 +0000 (14:01 +0200)]
Remove key and free attribute value only if they are valid,
clears CID 1220202.

2 years agoFixed hook_id declarations to be gulong instead of guint.
wwp [Mon, 19 Mar 2018 10:03:09 +0000 (11:03 +0100)]
Fixed hook_id declarations to be gulong instead of guint.
Made statusbar's hook_id static.
Rework hook_id magic value, now 0 instead of -1, and use a define (HOOK_NONE)
everywhere instead of 0. Any hook_id must be initialized to HOOK_NONE.
Hook_id that get invalidated or reset get the same HOOK_NONE value.

2 years agoDon't compute charset unless necessary (vcalviewer_get_uid_from_mimeinfo()),
wwp [Sat, 17 Mar 2018 20:53:20 +0000 (21:53 +0100)]
Don't compute charset unless necessary (vcalviewer_get_uid_from_mimeinfo()),
don't compute charset at all when not used (vcalviewer_get_request_values(),
vcalviewer_get_reply_values(), de facto solves CID 1372373), possible remnants
of an old implementation that I couldn't even found in log.

2 years agoFix possible access to uninitilized folder pointer (CID 1402515),
wwp [Sat, 17 Mar 2018 20:28:00 +0000 (21:28 +0100)]
Fix possible access to uninitilized folder pointer (CID 1402515),
add a warning if vcal folder's not found.

2 years agoSave us 35 warnings about hooks_register_hook() return checks.
wwp [Sat, 17 Mar 2018 19:18:22 +0000 (20:18 +0100)]
Save us 35 warnings about hooks_register_hook() return checks.

2 years agoFew optimizations: avoid strlen when string length is known (read()>0 return);
wwp [Sat, 17 Mar 2018 19:02:48 +0000 (20:02 +0100)]
Few optimizations: avoid strlen when string length is known (read()>0 return);
end string at real end of string instead of at buffer boundary and
be sure we print 0-terminated string (clamd_stream_scan());
clamd_verify_email: discover a strange multi-line response, be sure we
print 0-terminated string (CID 1220483), debug_print all response lines.

2 years agoFix wrong malloc of clamd_socket struct, CID 1220477.
wwp [Sat, 17 Mar 2018 18:34:05 +0000 (19:34 +0100)]
Fix wrong malloc of clamd_socket struct, CID 1220477.

2 years agoHandle IMAP search failure instead of ignoring it.
Andrej Kacian [Wed, 14 Mar 2018 20:35:05 +0000 (21:35 +0100)]
Handle IMAP search failure instead of ignoring it.

Error out on protocol error during search, disconnect
the IMAP session, and display an error dialog about it.

Closes bug 3986 - IMAP quick search using non-ASCII
characters creates an infinite loop

2 years agoClear statusbar's progressbar in case of NNTP xhdr/xover failure.
wwp [Wed, 14 Mar 2018 10:22:47 +0000 (11:22 +0100)]
Clear statusbar's progressbar in case of NNTP xhdr/xover failure.