Ricardo Mones [Tue, 6 Feb 2018 23:45:42 +0000 (00:45 +0100)]
Fix ‘GtkLabel {aka struct _GtkLabel}’ has no member named ‘label’
Andrej Kacian [Tue, 6 Feb 2018 21:53:31 +0000 (22:53 +0100)]
Force -DGTK_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE in GTK_CFLAGS.
Andrej Kacian [Tue, 6 Feb 2018 21:45:18 +0000 (22:45 +0100)]
Remove direct GTK struct member access from pdf_viewer plugin.
Andrej Kacian [Tue, 6 Feb 2018 21:07:47 +0000 (22:07 +0100)]
Remove the last offender against -DGTK_DISABLE_SINGLE_INCLUDES
Andrej Kacian [Tue, 6 Feb 2018 20:27:18 +0000 (21:27 +0100)]
Get rid of final direct GTK struct member access from ClawsSpellEntry.
We have to track preedit_length internally, because this
bit of GtkEntry is not available anymore.
Andrej Kacian [Tue, 6 Feb 2018 20:05:25 +0000 (21:05 +0100)]
ClawsSpellEntry does not need to implement GtkEditable
We're "subclassing" GtkEntry, which already implements it.
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:32 +0000 (20:12 +0100)]
Replace gtk_style_unref()
gtk_style_unref() is a remnant from gtk+1 and the compatibility function
in gtk+2 is gone in gtk+3, use g_object_unref() instead.
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:31 +0000 (20:12 +0100)]
Add missing header to acpi_notifier
When building against gtk+3 the compiler complains about implicit
function declaration, so include the required header for using the
gtk_cmoption_menu.
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:29 +0000 (20:12 +0100)]
Drop no longer used gtk+2 utility functions
With requiring gtk+2 >=2.24 the following functions are obsolete:
gtkut_widget_set_mapped
gtkut_widget_set_realized
gtkut_widget_set_can_default
gtkut_widget_set_receives_default
gtkut_widget_set_can_focus
gtkut_widget_set_has_window
Replace all occurrences with the underlying function.
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:28 +0000 (20:12 +0100)]
Drop ifdefs for old gtk+2
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:27 +0000 (20:12 +0100)]
Require gtk+ >= 2.24
gtk+-2.24.0 was released 2011-01-30 and has seen over 30 maintenance
releases since. Drop support for gtk+2 < 2.24 to ease porting to gtk+3
and to cleanup existing compatibility code for old gtk+2 releases.
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Andrej Kacian [Tue, 6 Feb 2018 13:25:01 +0000 (14:25 +0100)]
A few instances of combobox manipulation still used the old API.
Patch by Ralph Sennhauser.
Andrej Kacian [Tue, 6 Feb 2018 10:19:21 +0000 (11:19 +0100)]
Removed almost all direct GTK struct member accesses.
Use accessor functions instead.
The few remaining offenders are in spell_entry.c, which
will require some rework.
Andrej Kacian [Mon, 5 Feb 2018 22:59:38 +0000 (23:59 +0100)]
Replaced some deprecated GTK+ API calls in gtkaspell.c.
Ricardo Mones [Mon, 5 Feb 2018 20:44:15 +0000 (21:44 +0100)]
Fix some copyright headers
Ricardo Mones [Mon, 5 Feb 2018 20:15:42 +0000 (21:15 +0100)]
Refactor colors handling with more arrays
This also makes possible to add more colors easily.
Ricardo Mones [Mon, 5 Feb 2018 20:12:55 +0000 (21:12 +0100)]
Move all colors into an array
Andrej Kacian [Wed, 31 Jan 2018 18:57:07 +0000 (19:57 +0100)]
RSSyl: Handle 404 and other fetch failures better.
Ricardo Mones [Mon, 22 Jan 2018 23:24:36 +0000 (00:24 +0100)]
Move syntax help after entry
Ricardo Mones [Mon, 22 Jan 2018 22:45:20 +0000 (23:45 +0100)]
Remove more unnecessary colons in labels
Ricardo Mones [Mon, 22 Jan 2018 22:16:03 +0000 (23:16 +0100)]
Use spacing more uniformly on themes prefs
Also remove colons from labels (not used in other places), and align
them to the right, to be visually consistent with other preference
pages.
Ricardo Mones [Sun, 21 Jan 2018 09:34:52 +0000 (10:34 +0100)]
Fix wrong article in translated string
Andrej Kacian [Sat, 20 Jan 2018 13:36:38 +0000 (14:36 +0100)]
Do not consider missing passwordstorerc file as error.
Just continue with empty password store.
Ricardo Mones [Sat, 20 Jan 2018 13:10:39 +0000 (14:10 +0100)]
Prune more gtk_widget_set_size_request calls
Andrej Kacian [Fri, 19 Jan 2018 18:16:44 +0000 (19:16 +0100)]
Handle password store config_version update without the global gint variable.
Andrej Kacian [Fri, 19 Jan 2018 18:02:59 +0000 (19:02 +0100)]
Handle failed/aborted folderlist config_version update in main.c
Andrej Kacian [Fri, 19 Jan 2018 17:56:52 +0000 (18:56 +0100)]
Implement config_version in folderlist.xml.
Ricardo Mones [Fri, 19 Jan 2018 11:53:26 +0000 (12:53 +0100)]
No need to set window's position twice
It's already set on line 200 :-)
Andrej Kacian [Thu, 18 Jan 2018 20:53:18 +0000 (21:53 +0100)]
Implement config_version in passwordstorerc.
Andrej Kacian [Thu, 18 Jan 2018 20:13:46 +0000 (21:13 +0100)]
Do not consider "mark_as_spam" as a final action, since it does not move the marked message.
Fixes Bug 3919 - manual filtering does not move spam
Paul [Thu, 18 Jan 2018 11:05:18 +0000 (11:05 +0000)]
fix bug where actionsrc was not updated after mailbox name change
Ricardo Mones [Sun, 14 Jan 2018 15:26:44 +0000 (16:26 +0100)]
Add "Go to last error" to log window context menu
This functionality was already implemented, this only makes it
available to the user through a new menu option.
Paul [Tue, 9 Jan 2018 12:33:05 +0000 (12:33 +0000)]
fix bug 3947, 'Build break with --disable-libsm --enable-crash-dialog'
Ricardo Mones [Sun, 7 Jan 2018 18:47:29 +0000 (19:47 +0100)]
Use network log for LDAP operations output
Also add some error checking and improve debug output
Pawel Pekala [Fri, 5 Jan 2018 21:05:41 +0000 (22:05 +0100)]
Fix typos and errors in polish translation
Ricardo Mones [Thu, 28 Dec 2017 00:24:34 +0000 (01:24 +0100)]
Fix some translated strings
Paul [Wed, 20 Dec 2017 16:28:14 +0000 (16:28 +0000)]
a couple late translation update
from David Vachulka and Mark Chang
Andrej Kacian [Wed, 20 Dec 2017 09:45:24 +0000 (10:45 +0100)]
Fix missing GError initialization in compose_draft().
Paul [Tue, 19 Dec 2017 11:40:33 +0000 (11:40 +0000)]
extend 'default selection when entering a folder'
Renamed 'first ...' to 'oldest ...', and added 'newest ...' in GUI
Ricardo Mones [Mon, 18 Dec 2017 20:20:25 +0000 (21:20 +0100)]
Fix Bug 3936: LDAP StartTLS does not work for addressbooks
Paul [Mon, 18 Dec 2017 14:44:22 +0000 (14:44 +0000)]
bump minimum glib requirement to 2.28
Ricardo Mones [Mon, 18 Dec 2017 11:02:14 +0000 (12:02 +0100)]
Fix bug 3921: Follow-up to #3764. Cleanup gitignore
Thanks Flo for the patch, but sed -i '/libical\/libical/d' .gitignore
was faster than applying the patch itself ;-)
Paul [Sun, 17 Dec 2017 11:45:31 +0000 (11:45 +0000)]
for release 3.16.0
Paul [Sun, 17 Dec 2017 11:38:46 +0000 (11:38 +0000)]
update translations
updated by David Medina, Erik P. Olsen, Simon Legner, Tommi A Pirinen,
Páder Rezső, Luigi Votta, UTUMI Hirosi, Petter Adsen, Marcel Pol, Jakub
Jankiewicz, Frederico Goncalves Guimaraes, Mikhail Kurinnoi, Slavko,
Andreas Rönnquist.
new translation: Romanian by Cristian Secară
remove unmaintained Hebrew translation.
Ricardo Mones [Sun, 17 Dec 2017 02:33:58 +0000 (03:33 +0100)]
Update list of TLDs for release
Andrej Kacian [Thu, 14 Dec 2017 22:24:20 +0000 (23:24 +0100)]
Add proper ifdefs around master_passphrase() calls.
Andrej Kacian [Thu, 14 Dec 2017 22:18:50 +0000 (23:18 +0100)]
Fix buffer length handling in GnuTLS password encryption and decryption.
Also zero out one forgotten copy of plaintext password
before freeing it. Oops!
Ricardo Mones [Thu, 14 Dec 2017 12:39:23 +0000 (13:39 +0100)]
Space preview icons equally
Ricardo Mones [Tue, 12 Dec 2017 17:27:23 +0000 (18:27 +0100)]
Fix bug 3935: build from GIT master broken on arch linux
Completes
48f72c22f91fbe0d6e872e89bd4dce9d39090e81 to allow building
with disabled LDAP support.
Ricardo Mones [Tue, 12 Dec 2017 12:30:55 +0000 (13:30 +0100)]
Update lists of authors
Ricardo Mones [Tue, 12 Dec 2017 12:06:36 +0000 (13:06 +0100)]
Update Spanish translation
wwp [Mon, 11 Dec 2017 10:36:04 +0000 (11:36 +0100)]
Update French translation.
Andrej Kacian [Sun, 10 Dec 2017 09:49:02 +0000 (10:49 +0100)]
Fix bug 3931: segfault searching server with master password
Request master passphrase earlier and inhibit search if no master
passphrase is available.
Andrej Kacian [Sun, 10 Dec 2017 09:49:01 +0000 (10:49 +0100)]
Fix bug 3793: segfault when autocompletion asks for master passphrase
This is done by checking early if any ldap server is password-protected,
and asking for master passphrase when compose window appears. If user
cancels the dialog (does not enter the passphrase), we temporarily
disable the password-protected LDAP servers, just for that particular
compose window. We reenable them in compose_destroy().
Andrej Kacian [Sun, 10 Dec 2017 09:49:00 +0000 (10:49 +0100)]
Add public call to get master password
Ricardo Mones [Sun, 10 Dec 2017 01:52:51 +0000 (02:52 +0100)]
Prune gtk_widget_set_size_request calls
Andrej Kacian [Sat, 9 Dec 2017 16:05:59 +0000 (17:05 +0100)]
Copyright year update in plugins' version.rc files.
Andrej Kacian [Sat, 9 Dec 2017 16:05:36 +0000 (17:05 +0100)]
Some FileDescription fixes in plugins' version.rc files.
Thanks to Woody for noticing.
Ricardo Mones [Tue, 5 Dec 2017 00:27:06 +0000 (01:27 +0100)]
Color buttons proportional to font size
Instead of hardcoding a size which doesn't look the same on different
resolutions, use a space;m-space;space label and let GTK+ to compute
the appropriate button size for current font.
Ricardo Mones [Sun, 26 Nov 2017 20:35:50 +0000 (21:35 +0100)]
Adjust spelling preferences widgets
Ricardo Mones [Tue, 5 Dec 2017 21:51:57 +0000 (22:51 +0100)]
Remove list of bugs which are not outstanding
Olaf Hering [Wed, 22 Nov 2017 17:03:15 +0000 (18:03 +0100)]
Set flags of all selected messages before updating view
If a collapsed, unread thread is marked as 'ignore thread' the first
message remains bold in the message list. That happens because
summary_ignore_thread_func calls summary_set_row_marks, which finds
unread children. As a result bold_style is selected.
To fix this it is required to first update the message flags of all
selected messages, before updating the view of all selected messages.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Olaf Hering [Wed, 22 Nov 2017 17:03:14 +0000 (18:03 +0100)]
Remove stale MSG_IS_RETRCPT_PENDING
The bitflag MSG_RETRCPT_PENDING is not defined, the existing flags do not
indicate a typo. Remove this stale macro to avoid confusion.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Ricardo Mones [Sat, 2 Dec 2017 22:44:34 +0000 (23:44 +0100)]
Complete previous patch
Ricardo Mones [Sat, 2 Dec 2017 20:12:39 +0000 (21:12 +0100)]
Make column selector UI like open actions
Set remove button to center column and add border to lists
Michael Gmelin [Sun, 26 Nov 2017 20:09:22 +0000 (21:09 +0100)]
Fix bug #3924: Unbreak sieve host configuration on FreeBSD
Also, adds extra check for config->host
Olaf Hering [Wed, 22 Nov 2017 17:03:16 +0000 (18:03 +0100)]
Fix truncated input widgets in preferences window
With larger UI fontsize some input fields are truncated, the numbers can
not be read properly. Remove the hardcoded width values, let GTK pick a
value.
Andrej Kacian [Fri, 24 Nov 2017 23:42:34 +0000 (00:42 +0100)]
Use statusbar progress meter when opening/refreshing a NNTP folder.
Andrej Kacian [Wed, 22 Nov 2017 23:31:26 +0000 (00:31 +0100)]
Reenable filtering log on Windows, as it is no longer crashy.
It was previously disabled in
83eaf78e3.
Olaf Hering [Wed, 22 Nov 2017 17:03:19 +0000 (18:03 +0100)]
Move pointer usage after pointer check
In procmime_decode_content mimeinfo is dereferenced before cm_return_val_if_fail().
Abhay S. Kushwaha [Thu, 23 Nov 2017 12:37:55 +0000 (18:07 +0530)]
Rssyl: fix Windows build
Ricardo Mones [Mon, 13 Nov 2017 20:11:33 +0000 (21:11 +0100)]
Use entity decoding API in HTML parser
Ricardo Mones [Mon, 13 Nov 2017 19:40:11 +0000 (20:40 +0100)]
Rssyl: use new entity decoding API
Ricardo Mones [Mon, 13 Nov 2017 00:31:44 +0000 (01:31 +0100)]
Complete, normalize and fix table of entities
https://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references
Ricardo Mones [Mon, 6 Nov 2017 22:41:27 +0000 (23:41 +0100)]
Implement HTML entity decoding in one function
Content of symbols table remixed from existing html.c and
rssyl/strutils.c tables.
wwp [Fri, 10 Nov 2017 10:37:38 +0000 (11:37 +0100)]
Yet another string correction.
Andrej Kacian [Thu, 9 Nov 2017 19:31:26 +0000 (20:31 +0100)]
A hopefully better fix for commit
9f1c5fef1 when building with GpgME < 1.7.0.
gpgme_check_version() should only be used during
initialization, according to GpgME doc.
Paul [Thu, 9 Nov 2017 08:48:50 +0000 (08:48 +0000)]
oh-so-minor string correction
Andrej Kacian [Thu, 9 Nov 2017 08:11:35 +0000 (09:11 +0100)]
Fix commit
9f1c5fef1 when building with GpgME < 1.7.0.
Andrej Kacian [Wed, 8 Nov 2017 23:31:27 +0000 (00:31 +0100)]
Show full key/signature fingerprints.
Closes bug 3910 - Displaying of problematic short key IDs for GPG messages
Andrej Kacian [Wed, 8 Nov 2017 22:49:52 +0000 (23:49 +0100)]
Do not limit password/userid newline check to just POP3.
Ricardo Mones [Fri, 3 Nov 2017 16:46:19 +0000 (17:46 +0100)]
Use appropriate array for searching
Ricardo Mones [Mon, 30 Oct 2017 10:00:17 +0000 (11:00 +0100)]
Fix CID
1420437 (OVERFLOW_BEFORE_WIDEN)
Andrej Kacian [Sun, 29 Oct 2017 18:14:26 +0000 (19:14 +0100)]
Use GIO API instead of g_stat() in prefs_themes_file_stats() on Windows.
Andrej Kacian [Sun, 29 Oct 2017 17:40:54 +0000 (18:40 +0100)]
Use GIO API instead of g_stat() in compose_draft() on Windows.
Andrej Kacian [Sun, 29 Oct 2017 17:31:18 +0000 (18:31 +0100)]
Use GIO API instead of g_stat() on Windows in compose_add_attachments() and get_file_size().
Andrej Kacian [Sun, 29 Oct 2017 17:12:12 +0000 (18:12 +0100)]
Use GIO API instead of g_stat() in compose_insert_file() on Windows.
Andrej Kacian [Sat, 28 Oct 2017 15:57:48 +0000 (17:57 +0200)]
Use GIO API instead of g_stat() in mh_is_msg_changed() on Windows.
Andrej Kacian [Sat, 28 Oct 2017 12:49:47 +0000 (14:49 +0200)]
Avoid use of stat() in procheader_parse_file() on Windows.
Since GLib on different Windows versions has different
ideas about sizes of struct stat field sizes and is
inconsistent about it on 64-bit systems, we take advice
from GLib's own gstdio.h, and use GIO API to get file
attributes instead.
This will likely have to be changed for all uses of
stat() or g_stat() elsewhere.
All this to stop Claws Mail showing "1GB" size for all
emails in summaryview on 64-bit Win10.
Andrej Kacian [Sat, 28 Oct 2017 11:58:26 +0000 (13:58 +0200)]
Disallow '?' in filename when saving message part on Windows.
Andrej Kacian [Sat, 28 Oct 2017 11:58:03 +0000 (13:58 +0200)]
Revert "Disallow '?' in filename when saving message part on Windows."
This reverts commit
6e644bd2af1eae46fc9db874fc42e6b9bb89b9c8.
Andrej Kacian [Sat, 28 Oct 2017 11:28:26 +0000 (13:28 +0200)]
Disallow '?' in filename when saving message part on Windows.
Andrej Kacian [Sat, 28 Oct 2017 07:33:15 +0000 (09:33 +0200)]
Updated Fancy's claws.def for the Windows build
Andrej Kacian [Wed, 25 Oct 2017 18:40:41 +0000 (20:40 +0200)]
Fix missing invalid regexp indication in folder preferences.
The entry is supposed to turn red, but it couldn't
because of a logic error.
Andrej Kacian [Wed, 25 Oct 2017 18:28:11 +0000 (20:28 +0200)]
Disallow newline character in POP3 account username or password.
The entries will have red background and preferences
will refuse to be saved, with an alertpanel telling why,
if a newline is found in either of the two entries.
This is only checked for POP3 protocol, as other protocols
encode passwords e.g. in base64, and so will not break
the communication to server by sending the extraneous
newline verbatim.
Andrej Kacian [Wed, 25 Oct 2017 18:11:50 +0000 (20:11 +0200)]
Use subst_char() in fancy_set_defaults().
Andrej Kacian [Mon, 23 Oct 2017 16:57:50 +0000 (18:57 +0200)]
More and better leak fixes after commit
9729bf0e0.
Andrej Kacian [Mon, 23 Oct 2017 16:06:27 +0000 (18:06 +0200)]
Fix memory leaks introduced in recent commit
9729bf0e0.
Andrej Kacian [Mon, 23 Oct 2017 14:16:55 +0000 (16:16 +0200)]
Removed two obsolete statuswindow_* aliases.
Andrej Kacian [Mon, 23 Oct 2017 11:49:15 +0000 (13:49 +0200)]
Fetch XOVER and XHDR data in batches of 5000.
This avoids long stalls, which sometimes confuse libetpan.
It also allows implementing some sort of progressbar in UI.