Andrej Kacian [Tue, 24 May 2016 16:29:37 +0000 (18:29 +0200)]
Use PBKDF2 to derive encryption key for passwords.
...instead of my previous hash-then-xor nonsense.
Paul [Tue, 24 May 2016 13:20:52 +0000 (14:20 +0100)]
Andrej Kacian [Fri, 20 May 2016 09:38:32 +0000 (11:38 +0200)]
Moved getting random bytes into a separate get_random_bytes() function.
Andrej Kacian [Thu, 12 May 2016 08:03:39 +0000 (10:03 +0200)]
Remove imap_use_trash account preference.
Disabling this preference made deleting messages behave
incorrectly - they were marked for deletion regardless
of whether "delete" or "move to trash" was used, and
these actions were not executed immediately, regardless
of "immediate_execution" common preference.
Paul [Mon, 16 May 2016 16:02:53 +0000 (17:02 +0100)]
remove matcherrc.pre_names migration. 10 years later, we'll assume everyone has been migrated
Andrej Kacian [Fri, 6 May 2016 17:43:16 +0000 (19:43 +0200)]
Improve plural handling for "Delete message" dialog.
Ricardo Mones [Tue, 3 May 2016 10:50:21 +0000 (12:50 +0200)]
Fix typo in manual
Thanks Charles Curley for noticing
Andrej Kacian [Mon, 2 May 2016 19:29:12 +0000 (21:29 +0200)]
Made manual GPG key import work on Windows.
Andrej Kacian [Mon, 2 May 2016 18:54:19 +0000 (20:54 +0200)]
Ask GpgME for path to gpg executable for manual key import.
Ricardo Mones [Sun, 1 May 2016 14:56:18 +0000 (16:56 +0200)]
Fix frequently ocurring typos :)
Ricardo Mones [Sun, 1 May 2016 14:51:10 +0000 (16:51 +0200)]
Fix some typos in perl plugin's manpage
Andrej Kacian [Thu, 28 Apr 2016 10:01:10 +0000 (12:01 +0200)]
Fix behavior in selecting PGP MIME signature on Windows.
With old argument order, gpgme_op_verify() returned "empty signature"
error on Windows, for reasons unknown.
Andrej Kacian [Tue, 26 Apr 2016 08:21:22 +0000 (10:21 +0200)]
Use correct dir separator for "Scanning folder ..." in statusbar.
Andrej Kacian [Fri, 22 Apr 2016 18:04:02 +0000 (20:04 +0200)]
More fixes for the Windows native file choosers.
Filter string should be terminated with two nuls.
Save dialog did not show for message parts which have no
attachment name.
Andrej Kacian [Fri, 22 Apr 2016 11:31:41 +0000 (13:31 +0200)]
Disallow folder names ending with a space on Windows.
Closes bug #2781.
Andrej Kacian [Fri, 22 Apr 2016 08:05:57 +0000 (10:05 +0200)]
Make Windows native file/dir choosers work with non-ASCII characters.
Also, make the save chooser supply the correct attachment
file name by default, just like the GTK+ one does.
Ricardo Mones [Mon, 18 Apr 2016 15:23:52 +0000 (17:23 +0200)]
Fix closing tag placement
Thanks Paul for noticing ;-)
Ricardo Mones [Mon, 18 Apr 2016 12:55:16 +0000 (14:55 +0200)]
Fix semantic error
Thanks Andrej for the quick review!
Ricardo Mones [Mon, 18 Apr 2016 12:46:23 +0000 (14:46 +0200)]
Synchronize Spanish manual
Ricardo Mones [Mon, 18 Apr 2016 12:45:34 +0000 (14:45 +0200)]
Keep current order and add the default value
Andrej Kacian [Mon, 18 Apr 2016 12:15:34 +0000 (14:15 +0200)]
Document 'master_passphrase_pbkdf2_rounds' hidden preference.
Andrej Kacian [Sat, 16 Apr 2016 16:04:31 +0000 (18:04 +0200)]
Use native file and folder selection dialogs on Windows.
This is done by compiling in src/gtk/w32_filesel.c instead of
filesel.c on Windows. The Makefile.am logic mirrors the one from
src/common/.
Andrej Kacian [Mon, 11 Apr 2016 16:30:18 +0000 (18:30 +0200)]
Show duration of PBKDF2 computation in debug output.
Andrej Kacian [Sat, 9 Apr 2016 22:57:15 +0000 (00:57 +0200)]
Make double-click open edit dialog also for addressbook datasources.
For example, LDAP servers.
Andrej Kacian [Sat, 9 Apr 2016 16:06:26 +0000 (18:06 +0200)]
Prevent an unlikely crash during RSSyl feed properties save.
This is just to shut Coverity up, I don't think it could
ever crash this way.
Andrej Kacian [Sat, 9 Apr 2016 16:03:01 +0000 (18:03 +0200)]
Addressbook now uses password store for LDAP passwords.
Andrej Kacian [Sat, 9 Apr 2016 13:43:02 +0000 (15:43 +0200)]
Remove password from passwordstore when deleting a RSSyl feed.
Andrej Kacian [Sat, 9 Apr 2016 13:28:06 +0000 (15:28 +0200)]
Update passwordstore if RSSyl feed's URL gets changed.
Andrej Kacian [Sat, 9 Apr 2016 13:21:13 +0000 (15:21 +0200)]
Fix crash on deleting password from passwordstore.
Andrej Kacian [Sat, 9 Apr 2016 10:01:54 +0000 (12:01 +0200)]
Remove obsolete comment in RSSyl's OPML import.
Andrej Kacian [Sat, 9 Apr 2016 08:57:48 +0000 (10:57 +0200)]
Fix parsing logic in RSSyl OPML import.
Possibly closes bug #3623.
Andrej Kacian [Fri, 8 Apr 2016 12:50:45 +0000 (14:50 +0200)]
Close PRNG source after reading our PBKDF2 salt from it.
Andrej Kacian [Thu, 7 Apr 2016 12:56:48 +0000 (14:56 +0200)]
Use PBKDF2 with HMAC-SHA1 for master passphrase in clawsrc.
The 64 bytes long key derivation is stored in 'master_passphrase'
pref, together with number of rounds used in its computation.
Introducing also two new common prefs:
master_passphrase_salt - holds a randomly generated 64 bytes
for use as salt with PBKDF2. Base64-encoded.
master_passphrase_pbkdf2_rounds - number of rounds (or
iterations) for next passphrase key derivation
The latter can be tweaked by user in case they want to use more
or less rounds, e.g. if they're running on weaker hardware and
KD with default number of rounds takes too long.
Andrej Kacian [Thu, 7 Apr 2016 12:49:37 +0000 (14:49 +0200)]
Added PBKDF2 implementation, copied from OpenBSD.
Andrej Kacian [Wed, 6 Apr 2016 12:53:57 +0000 (14:53 +0200)]
Update plugins' claws.def filess for Windows build.
Andrej Kacian [Wed, 6 Apr 2016 12:53:37 +0000 (14:53 +0200)]
Remove unneeded plugin_master_passphrase_change().
Holger Berndt [Tue, 5 Apr 2016 19:16:04 +0000 (21:16 +0200)]
Python plugin: Add set_header_list() function for ComposeWindow objects
Paul [Sun, 3 Apr 2016 10:22:43 +0000 (11:22 +0100)]
pay attention there!
Paul [Sun, 3 Apr 2016 10:21:14 +0000 (11:21 +0100)]
a handful of documentation updates
Andrej Kacian [Sat, 2 Apr 2016 15:07:35 +0000 (17:07 +0200)]
RSSyl: zero out password variables after migration to password store
Andrej Kacian [Sat, 2 Apr 2016 15:00:43 +0000 (17:00 +0200)]
Make RSSyl plugin use the password store.
Andrej Kacian [Sat, 2 Apr 2016 13:57:50 +0000 (15:57 +0200)]
Move RSSyl plugin name to a macro.
Ricardo Mones [Sat, 2 Apr 2016 13:41:04 +0000 (15:41 +0200)]
Fix some odd debug outputs
Andrej Kacian [Sat, 2 Apr 2016 11:58:48 +0000 (13:58 +0200)]
Require GnuTLS version 3.0 for password encryption.
wwp [Fri, 1 Apr 2016 11:49:26 +0000 (13:49 +0200)]
Make use of GNUTLS_CFLAGS to compile.
Colin Leroy [Thu, 31 Mar 2016 17:55:49 +0000 (19:55 +0200)]
Fix cast issue
Andrej Kacian [Thu, 31 Mar 2016 13:18:40 +0000 (15:18 +0200)]
Migrate GData plugin refresh token to password store correctly.
Andrej Kacian [Wed, 30 Mar 2016 21:02:14 +0000 (23:02 +0200)]
Migrate SpamReport passwords to password store correctly.
Andrej Kacian [Wed, 30 Mar 2016 20:59:09 +0000 (22:59 +0200)]
Make vCalendar plugin use the password store.
Andrej Kacian [Wed, 30 Mar 2016 16:21:08 +0000 (18:21 +0200)]
Rewrite unfold_line() to handle UTF8 line breaks.
This closes bug #3629 - Invalid subject can distort
message list view
Colin Leroy [Sun, 27 Mar 2016 22:00:41 +0000 (00:00 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Ricardo Mones [Fri, 25 Mar 2016 18:26:33 +0000 (19:26 +0100)]
Fix bug #3628: Typo in zh_TW.po
Patch by rypervenche <sub@ryper.org> (thanks!)
Andrej Kacian [Fri, 25 Mar 2016 11:15:23 +0000 (12:15 +0100)]
Fix incorporation dialog focus with master passphrase dialog.
Ricardo Mones [Fri, 25 Mar 2016 00:23:18 +0000 (01:23 +0100)]
Remove dead code when the #ifndef is true
Andrej Kacian [Thu, 24 Mar 2016 20:40:39 +0000 (21:40 +0100)]
Set empty block->entries to NULL in passwd_store_delete_block().
Andrej Kacian [Thu, 24 Mar 2016 19:39:26 +0000 (20:39 +0100)]
Empty account block in password store when deleting an account.
This effectively deletes it, as empty password blocks are
not saved to disk.
Andrej Kacian [Thu, 24 Mar 2016 07:43:58 +0000 (08:43 +0100)]
Fix crash in rare corner case in password en/decryption.
Andrej Kacian [Wed, 23 Mar 2016 16:13:43 +0000 (17:13 +0100)]
Use a hardcoded IV length in password encryption.
...since we can't count on having GnuTLS new enough to have
gnutls_cipher_get_iv_size().
Andrej Kacian [Wed, 23 Mar 2016 14:17:04 +0000 (15:17 +0100)]
Use SHA-256 for master_passphrase_hash, since SHA-512 is too new.
Andrej Kacian [Tue, 22 Mar 2016 12:23:41 +0000 (13:23 +0100)]
Make gnutls password encryption the default if gnutls is available.
Andrej Kacian [Sat, 19 Mar 2016 21:28:23 +0000 (22:28 +0100)]
Write passwordstore into file also after account passwords migration.
Andrej Kacian [Sat, 19 Mar 2016 20:07:41 +0000 (21:07 +0100)]
Treat storing empty password same as storing NULL password.
(That means delete the password. This simplifies handling
scenario where user had a password set, but wants to delete
it by leaving corresponding GtkEntry empty.)
Andrej Kacian [Sat, 19 Mar 2016 19:50:04 +0000 (20:50 +0100)]
Write passwordstore into file more often, not just at exit.
Andrej Kacian [Sat, 19 Mar 2016 19:44:21 +0000 (20:44 +0100)]
Make SpamReport plugin use the password store.
Andrej Kacian [Sat, 19 Mar 2016 19:14:40 +0000 (20:14 +0100)]
Removed a forgotten debug line.
Andrej Kacian [Sat, 19 Mar 2016 19:00:57 +0000 (20:00 +0100)]
Do not create password block when deleting a password from store.
Andrej Kacian [Sat, 19 Mar 2016 18:54:40 +0000 (19:54 +0100)]
Fix crash when unloading GData plugin when it's not configured.
Andrej Kacian [Sat, 19 Mar 2016 17:10:02 +0000 (18:10 +0100)]
Make GData plugin use the password store.
Untested, as I have no Google accounts to test with.
Andrej Kacian [Sat, 19 Mar 2016 10:15:21 +0000 (11:15 +0100)]
Update manual regarding new show/hide menu shortcut.
Andrej Kacian [Sat, 19 Mar 2016 10:09:18 +0000 (11:09 +0100)]
Change default show/hide shortcut to Ctrl+F12.
Andrej Kacian [Mon, 14 Mar 2016 19:46:59 +0000 (20:46 +0100)]
Use account ID instead of name in passwordstorerc.
Charles Lehner [Mon, 14 Mar 2016 04:55:49 +0000 (00:55 -0400)]
Migrate managesieve to passwordstore
Colin Leroy [Thu, 3 Mar 2016 20:14:59 +0000 (21:14 +0100)]
Fix unitialised access
Andrej Kacian [Thu, 3 Mar 2016 10:17:41 +0000 (11:17 +0100)]
"Master password" is now called "master passphrase".
This is to help diferentiate between passwords coming from
accounts, plugins, etc., and the master passphrase used in
an AES encryption key for encrypting these passwords.
Andrej Kacian [Wed, 2 Mar 2016 12:59:35 +0000 (13:59 +0100)]
Make POP3 use password store too.
Andrej Kacian [Wed, 2 Mar 2016 12:36:29 +0000 (13:36 +0100)]
Fix previous fix ;-)
Andrej Kacian [Wed, 2 Mar 2016 06:35:25 +0000 (07:35 +0100)]
Fix a Coverity warning caused by previous commits.
Andrej Kacian [Tue, 1 Mar 2016 20:11:09 +0000 (21:11 +0100)]
Fix SMTP password use with password store.
Andrej Kacian [Sun, 28 Feb 2016 22:42:56 +0000 (23:42 +0100)]
Make accounts use new password store for their passwords.
Andrej Kacian [Thu, 18 Feb 2016 21:25:55 +0000 (22:25 +0100)]
Implement a password store.
Andrej Kacian [Tue, 1 Mar 2016 18:44:25 +0000 (19:44 +0100)]
Upon master password change, ask for old password immediately.
Paul [Thu, 25 Feb 2016 08:22:02 +0000 (08:22 +0000)]
fix typos in function name
Paul [Wed, 24 Feb 2016 20:19:08 +0000 (20:19 +0000)]
remove the whole unncessary if block, completing the last commit
Paul [Wed, 24 Feb 2016 20:02:46 +0000 (20:02 +0000)]
remove spurious single quotes in mailcap_get_command_in_file()
Paul [Wed, 24 Feb 2016 12:45:22 +0000 (12:45 +0000)]
add missing include
Andrej Kacian [Sat, 20 Feb 2016 11:07:01 +0000 (12:07 +0100)]
Add warning about missing LOGIN SASL plugin for IMAP.
Paul [Sat, 20 Feb 2016 10:10:21 +0000 (10:10 +0000)]
prevent always selecting html part in multipart/alternative
this bug was introduced in
4745b80528426498b9e4f61d0f1a812e94ce1a6e
Andrej Kacian [Fri, 19 Feb 2016 23:27:47 +0000 (00:27 +0100)]
Made the gnutls password encryption work on Win32.
Andrej Kacian [Fri, 19 Feb 2016 23:27:24 +0000 (00:27 +0100)]
Revert "Made the gnutls password encryption work on Win32."
This reverts commit
18ccbd586fec890cab70ce34c94c580d69fffdd0.
I committed more than I expected, files in po/ snuck in, sorry!
Andrej Kacian [Fri, 19 Feb 2016 23:21:40 +0000 (00:21 +0100)]
Made the gnutls password encryption work on Win32.
Andrej Kacian [Fri, 19 Feb 2016 22:18:28 +0000 (23:18 +0100)]
Fix a compile error on Win32.
Ricardo Mones [Fri, 19 Feb 2016 18:24:09 +0000 (19:24 +0100)]
Add scroll to SSL certificates list
Avoids window growing out of screen height when there's a large
amount of certificates on the list.
Ricardo Mones [Fri, 19 Feb 2016 18:23:00 +0000 (19:23 +0100)]
Fix leak on error and error reporting
Ricardo Mones [Fri, 19 Feb 2016 18:21:50 +0000 (19:21 +0100)]
Fix a couple of typos
Ricardo Mones [Fri, 19 Feb 2016 18:15:12 +0000 (19:15 +0100)]
Fix bug #2604: Add support for -geometry
And document it too :-)
Ricardo Mones [Fri, 19 Feb 2016 18:03:15 +0000 (19:03 +0100)]
Fix bug #3578: Strings around MAILIMAP_ERROR…
…could use some whitespace fixes. Patch by Andreas Rönnquist (thanks!).
Ricardo Mones [Fri, 19 Feb 2016 17:58:34 +0000 (18:58 +0100)]
Fix bug #3581: sys:1: Warning: Source ID # was…
…not found when attempting to remove it, and remove unused logic.
Ricardo Mones [Fri, 19 Feb 2016 17:50:04 +0000 (18:50 +0100)]
Fix bug #3028: Claws doesn't select html part if attachments present
Make HTML part search recursive maintaining current functionality:
• display first HTML part
• promotion of calendar attachments (if vCalendar is available)
• not promoting HTML attachments
Andrej Kacian [Fri, 19 Feb 2016 16:52:50 +0000 (17:52 +0100)]
Implement real LOGIN auth method for IMAP.
The "old LOGIN" was in fact just a basic plaintext login method,
using: "LOGIN username password", not the SASL LOGIN method.
Andrej Kacian [Fri, 19 Feb 2016 16:13:08 +0000 (17:13 +0100)]
Enable SASL PLAIN auth mechanism for IMAP accounts.