Andrej Kacian [Sat, 30 May 2015 17:45:32 +0000 (19:45 +0200)]
RSSyl: Use procheader_date_parse() for RFC3339 date strings.
This allows us to remove the parseISO8601Date() function, and
therefore use of strptime(), which does not exist on all platforms.
Andrej Kacian [Sat, 30 May 2015 17:40:51 +0000 (19:40 +0200)]
Rewrote parsing of RFC3339 datetime strings.
This rewrite supports all allowed separators between date
and time: both uppercase and lowercase 'T', as well as space.
Only thing not yet supported is 'Z' instead of time zone offset,
I will hopefully add that later.
Andrej Kacian [Sat, 30 May 2015 16:33:19 +0000 (18:33 +0200)]
RSSyl: Updated list of symbols needed from claws-mail core.
Needed for building for Windows.
Andrej Kacian [Sat, 30 May 2015 16:32:35 +0000 (18:32 +0200)]
RSSyl: struct dirent doesn't have d_type member on Windows.
Andrej Kacian [Sat, 30 May 2015 16:31:26 +0000 (18:31 +0200)]
RSSyl: Remove unnecessary use of link() in rssyl_add_msgs().
Andrej Kacian [Sat, 30 May 2015 15:36:34 +0000 (17:36 +0200)]
Fix typo in variable name in Windows g_open() implementation.
Ricardo Mones [Thu, 28 May 2015 19:07:30 +0000 (21:07 +0200)]
Fix bug #1941 ‘recursive "mark read all"’
Based on the original patch from Robert David which unfortunately
didn't marked as read the folder currently open on summary view.
Paul [Thu, 28 May 2015 07:56:19 +0000 (08:56 +0100)]
fix last commit
my fault, not a problem with the patch
Paul [Thu, 28 May 2015 07:43:20 +0000 (08:43 +0100)]
Fix LDAP access using TLS protocol
Patch by Darko Koruga.
Andrej Kacian [Wed, 27 May 2015 20:58:27 +0000 (22:58 +0200)]
RSSyl: Fix compilation on OS X.
The enums declared in libfeed's parser*.h files sneaked through
to object built from old_feeds.c file, due to parser.h include.
For some reason, this bothers OS X compiler.
Since these enums were only used in their respective parser*.c file,
I just moved them there.
Andrej Kacian [Thu, 21 May 2015 21:32:00 +0000 (23:32 +0200)]
RSSyl: Leave unread flag on new items regardless of silent_update setting.
Closes bug #2601
Ricardo Mones [Mon, 18 May 2015 19:44:50 +0000 (21:44 +0200)]
Almost switch plugins from strerror to g_strerror
Refusing to modify spamassassin's libspamc.c code to avoid
diverging (more) from original ASF code. It's a pity they
don't provide a shared library for this, or at least for the
message_read/message_filter functions used by the plugin :)
Ricardo Mones [Mon, 18 May 2015 19:22:37 +0000 (21:22 +0200)]
Switch core from strerror to g_strerror
Andrej Kacian [Sun, 17 May 2015 17:13:17 +0000 (19:13 +0200)]
RSSyl: Strip leading and trailing whitespace from XML tag contents.
Ricardo Mones [Sat, 16 May 2015 10:21:07 +0000 (12:21 +0200)]
Update summary view status after "Find all"
In search messages dialog (Edit/Search folder...) pressing "Find all"
left the summary view status empty regardless of the result.
The status of the resulting selection when matching messages are found
is displayed now. If no message is matched it remains empty as before.
Andrej Kacian [Wed, 6 May 2015 22:19:03 +0000 (00:19 +0200)]
RSSyl: use procheader_date_parse() instead of parseRFC822Date().
Ricardo Mones [Mon, 4 May 2015 01:07:50 +0000 (03:07 +0200)]
Fix GLib-GObject-CRITICAL message when printing
Message was: “g_object_ref: assertion 'G_IS_OBJECT (object)' failed”
Ricardo Mones [Wed, 29 Apr 2015 18:28:29 +0000 (20:28 +0200)]
Fix bug #2981 and other two implicit...
...declaration warnings I probably introduced in previous commits:
• notification_prefs.c:1285:2: warning: implicit declaration of function
'filesel_select_file_open' [-Wimplicit-function-declaration]
• rssyl_prefs.c:110:2: warning: implicit declaration of function
'filesel_select_file_open' [-Wimplicit-function-declaration]
• icalderivedproperty.c:374:4: warning: implicit declaration of function
'icalproperty_add_parameters' [-Wimplicit-function-declaration]
;-)
Ricardo Mones [Sat, 25 Apr 2015 18:26:36 +0000 (20:26 +0200)]
Fix 'make dist' for Managesieve plugin
make[5]: Entering directory '/home/mones/hydra/claws-dev/src/plugins/managesieve'
make[5]: *** No rule to make target 'sieve_plugin.h', needed by 'distdir'. Stop.
Ricardo Mones [Sat, 25 Apr 2015 18:26:05 +0000 (20:26 +0200)]
Add author of Managesieve plugin also to About dialog
Andrej Kacian [Sat, 25 Apr 2015 11:29:51 +0000 (13:29 +0200)]
Update AUTHORS and README regarding the Managesieve plugin.
Charles Lehner [Sun, 23 Nov 2014 03:32:35 +0000 (22:32 -0500)]
Add ManageSieve plugin
Charles Lehner [Sun, 16 Nov 2014 22:14:14 +0000 (17:14 -0500)]
Make message_search interface-based
- Factor out compose/messageview checking.
- Make general so other code can use it
Charles Lehner [Sun, 23 Nov 2014 01:44:25 +0000 (20:44 -0500)]
Add callback for session connection result
Ricardo Mones [Sat, 25 Apr 2015 10:51:42 +0000 (12:51 +0200)]
Reuse PLUGINS_URI #define
Ricardo Mones [Wed, 22 Apr 2015 17:58:21 +0000 (19:58 +0200)]
Fix bug #3419 ‘Saving/appending messages to an mbox file violates RFC#4155’
RFC4155 is informative, anyway, this makes message separator headers
conform to qmail mboxrd format: http://qmail.org./man/man5/mbox.html
Original patch thanks to Johan Vromans.
Andrej Kacian [Wed, 22 Apr 2015 16:31:46 +0000 (18:31 +0200)]
Compose window: Fix bug #3421 - Recipients list doesn't scroll when moving with arrow keys.
Ricardo Mones [Tue, 7 Apr 2015 19:56:08 +0000 (21:56 +0200)]
Adjust templates panel of folder properties
Andrej Kacian [Sun, 22 Mar 2015 10:58:50 +0000 (11:58 +0100)]
In mailbox order dialog, set selection mode after the list has been
populated, so that when the first row gets selected by default,
the triggered set_selected() function can correctly set sensitivity
on up/down buttons.
Andrej Kacian [Sun, 22 Mar 2015 10:45:42 +0000 (11:45 +0100)]
Allow single-click to select mailboxes in the mailbox order dialog.
Andrej Kacian [Sat, 21 Mar 2015 17:00:53 +0000 (18:00 +0100)]
Removed unused MBOX_CACHE_DIR from defs.h.
Paul [Sat, 21 Mar 2015 11:19:40 +0000 (11:19 +0000)]
fix bug 3407, 'Pressing the "Date" column header to "sort by date" causes all columns to have a sort arrow.'
It was only apparent when sorting by thread date, not sorting by date.
Holger Berndt [Sun, 15 Mar 2015 20:24:29 +0000 (21:24 +0100)]
Python plugin: Silence parasite glib warnings
Holger Berndt [Sun, 15 Mar 2015 19:55:59 +0000 (20:55 +0100)]
Notification plugin: Remove spurious warning
Holger Berndt [Sun, 15 Mar 2015 18:20:05 +0000 (19:20 +0100)]
GData plugin: Harden against missing fields
Andrej Kacian [Sun, 15 Mar 2015 15:45:20 +0000 (16:45 +0100)]
Change "OpenSSL support" to "TLS support" in a dialog message.
Ricardo Mones [Sat, 7 Mar 2015 00:52:23 +0000 (01:52 +0100)]
Do not link main binary to GPGME libraries
Fixes half of <https://bugs.debian.org/779824>; the other half
was fixed in commit
22e05b492f09ed1d20cd48e1917d1dead0fc248e.
Paul [Thu, 5 Mar 2015 09:09:38 +0000 (09:09 +0000)]
for Python 2.x set encoding to UTF-8
also:
don't mix tabs and spaces (replace tabs)
a syntax fix
several typo fixes
Patch by Daniel Zaoui
Paul [Thu, 5 Mar 2015 08:55:10 +0000 (08:55 +0000)]
fix bug 1769, ' vCalendar timezone glitches'
Patch by Darko Koruga
Ricardo Mones [Wed, 25 Feb 2015 12:50:16 +0000 (13:50 +0100)]
Sync Spanish manual translation
Ricardo Mones [Wed, 25 Feb 2015 12:49:00 +0000 (13:49 +0100)]
Fix bug #3389 ‘document 'F12' shortcut’
Ricardo Mones [Thu, 19 Feb 2015 23:46:31 +0000 (00:46 +0100)]
Fetchinfo: slightly improve prefs, add hints
Ricardo Mones [Thu, 19 Feb 2015 00:19:01 +0000 (01:19 +0100)]
Fix widget spacing in toolbar preferences pages
Ricardo Mones [Wed, 11 Feb 2015 00:08:54 +0000 (01:08 +0100)]
Notification plugin: standardise preferences
Make notification preferences look more like the rest of application:
• Browse button for file selections
• Remove colons from labels
• Label with unit(s) after spinners where appropriate
• Use hints for special values
• Use frames to group related widgets
• Package widgets without tables and use existing macros
Michael Rasmussen [Thu, 5 Feb 2015 00:21:31 +0000 (01:21 +0100)]
Fix bug #3380. Initialize widget before callback handler for 'clicked'
Ricardo Mones [Thu, 29 Jan 2015 20:33:33 +0000 (21:33 +0100)]
Fix bug #3363 “preferences page composition seems weird”
Ricardo Mones [Thu, 29 Jan 2015 01:04:12 +0000 (02:04 +0100)]
Fancy: improve readability and standardise labels
Ricardo Mones [Mon, 26 Jan 2015 23:47:21 +0000 (00:47 +0100)]
Libravatar: more compact prefs, add hint to entry
Paul [Mon, 26 Jan 2015 05:03:29 +0000 (05:03 +0000)]
Mac-Cyrillic menu updates. patch by Anton Butanaev
Ricardo Mones [Sun, 25 Jan 2015 19:03:35 +0000 (20:03 +0100)]
AddressKeeper: improve preferences panel
Ricardo Mones [Thu, 22 Jan 2015 23:54:12 +0000 (00:54 +0100)]
AttachWarner: rearrange checkbox, standardise labels
Ricardo Mones [Sat, 17 Jan 2015 16:31:24 +0000 (17:31 +0100)]
Remove GTK+ checks lower than required version
INSTALL file says 2.16 is required since some time ago, hence
removing these remnants from the glorious days of GTK+2 :)
Paul [Mon, 19 Jan 2015 09:21:52 +0000 (09:21 +0000)]
add support for x-mac-cyrillic encoding.
patch by Anton Butanaev.
Colin Leroy [Wed, 14 Jan 2015 15:46:21 +0000 (16:46 +0100)]
Fix bug #3364, segfault in src/wizard.c: add missing return
Fix bug #3365, segfault in src/prefs_account.c: add missing return
Ricardo Mones [Sat, 15 Nov 2014 11:39:18 +0000 (12:39 +0100)]
Fix bug# 3098: add auth to context and handle error
Ricardo Mones [Sat, 15 Nov 2014 11:38:18 +0000 (12:38 +0100)]
RSSyl: preferences for HTTP auth basic
Ricardo Mones [Sat, 15 Nov 2014 11:30:14 +0000 (12:30 +0100)]
RSSyl: support HTTP basic auth in libfeed
Andrej Kacian [Sat, 3 Jan 2015 02:42:30 +0000 (03:42 +0100)]
Add support for SCRAM-SHA-1 authentication mechanism (via libetpan) to IMAP.
Andrej Kacian [Thu, 8 Jan 2015 21:51:04 +0000 (22:51 +0100)]
RSSyl: Day-of-week name in RFC822 timestamps is optional.
Ricardo Mones [Mon, 5 Jan 2015 09:55:52 +0000 (10:55 +0100)]
Fix bug #1797 “quicksearch could also search the Cc field”
Updated patch by Barry Warsaw <barry@python.org>, thanks!
Andrej Kacian [Thu, 1 Jan 2015 22:36:36 +0000 (23:36 +0100)]
RSSyl: Fix handling of feeds with encodings unknown to expat. Turns out the only thing missing was that HAVE_ICONV macro (from config.h) was not defined in parser.c, so our "unknown encoding" expat handler function did nothing. Fixes bug #3339.
Andrej Kacian [Mon, 22 Dec 2014 18:42:55 +0000 (19:42 +0100)]
Use AC_CHECK_LIB instead of AC_SEARCH_LIBS, to prevent adding -larchive to global LIBS variable. This gets rid of superfluous dynamic link against libarchive in all built executables (claws-mail and plugins).
Colin Leroy [Fri, 19 Dec 2014 15:26:37 +0000 (16:26 +0100)]
Fix bug #3354, "Event cancellation uses incorrect method parameter for Content-Type header"
Colin Leroy [Fri, 19 Dec 2014 15:23:00 +0000 (16:23 +0100)]
Better fix for bug #3349 (almost all the needed code was there :-)
Colin Leroy [Thu, 18 Dec 2014 09:18:48 +0000 (10:18 +0100)]
Merge remote-tracking branch 'jakub-kicinski/for-master'
Ricardo Mones [Wed, 17 Dec 2014 15:45:12 +0000 (16:45 +0100)]
Improve feedback to user when bug #3349
Paul [Mon, 15 Dec 2014 21:42:25 +0000 (21:42 +0000)]
fix bug 3351, 'Two problems when re-sending a file with an attachment' (really one problem, though)
Jakub Kicinski [Fri, 12 Dec 2014 09:00:51 +0000 (10:00 +0100)]
Use memset to initialize struct etpan_thread_op
also remove duplicated zeroing.
Jakub Kicinski [Fri, 12 Dec 2014 08:48:57 +0000 (09:48 +0100)]
Synchronize mailimap deletion against async operations
Right now main thread can free mailimap while its background thread
is still performing operations on it. Fix it by moving deletion to
the worker thread and making sure nobody uses stale pointers.
Jakub Kicinski [Fri, 12 Dec 2014 08:17:34 +0000 (09:17 +0100)]
Swap return value and argument of imap_threaded_capability()
imap_threaded_capability() is the only imap_threaded_*() function
which does not return status, instead status is written to a pointer
passed as argument and function returns retrieved capabilities. To
unify behaviour of all imap_threaded_*() functions make it return
status and pass capabilities through an out argument.
Paul [Tue, 9 Dec 2014 10:46:49 +0000 (10:46 +0000)]
when cancelling a msg written with an external editor, get rid of the draft copy. thanks to Darko Koruga.
Andrej Kacian [Tue, 9 Dec 2014 09:14:40 +0000 (10:14 +0100)]
Compose window: Change Subject mnemonic from 's' to 'u', since 's' is already used by Spelling menu.
Andrej Kacian [Mon, 8 Dec 2014 22:08:29 +0000 (23:08 +0100)]
Compose window: sender address line gets its own label with a mnemonic, similar to Subject line.
Andrej Kacian [Sun, 7 Dec 2014 22:31:41 +0000 (23:31 +0100)]
Properly allocate buffer in conv_encode_header_full() for quoted-printable encoding. Closes bug #3338, reported by Michael Hughes.
Andrej Kacian [Sun, 7 Dec 2014 21:33:26 +0000 (22:33 +0100)]
Compose window: activating the GtkEntry with sender address activates the account selection combobox. Closes bug #3345, reported by Barry Warsaw.
Ricardo Mones [Thu, 4 Dec 2014 15:02:57 +0000 (16:02 +0100)]
Fix crash opening folder (Debian bug #771737)
See https://bugs.debian.org/771737 for details.
Ricardo Mones [Sat, 29 Nov 2014 21:53:33 +0000 (22:53 +0100)]
Fix possible buffer overflow (CVE 2010-5109)
Patch by Petr Písař <ppisar@redhat.com>
RedHat bug: https://bugzilla.redhat.com/show_bug.cgi?id=831322
Debian bug: https://bugs.debian.org/771360
Andrej Kacian [Thu, 27 Nov 2014 02:23:46 +0000 (03:23 +0100)]
RSSyl: Fix argument order for strstr() in Atom parser.
Andrej Kacian [Thu, 27 Nov 2014 02:22:17 +0000 (03:22 +0100)]
RSSyl: Ignore rel="..." feed link in Atom parser.
Andrej Kacian [Thu, 27 Nov 2014 01:12:42 +0000 (02:12 +0100)]
RSSyl: Do not run html entity replacement on URL and item id strings when adding an item.
Andrej Kacian [Thu, 27 Nov 2014 01:12:06 +0000 (02:12 +0100)]
RSSyl: Fix allocated buffer size in previous commit to include space for terminating null byte; Fix minor logic bug.
Andrej Kacian [Thu, 27 Nov 2014 00:00:11 +0000 (01:00 +0100)]
RSSyl: Wrote more robust replacing of HTML character references. We now handle decimal references (Ӓ), in addition to few selected named references.
Ricardo Mones [Mon, 24 Nov 2014 00:43:10 +0000 (01:43 +0100)]
Bug #2577 → improve focus rectangle removal in summaryview
Patch by Andreas Rönnquist, thanks!
Andrej Kacian [Mon, 24 Nov 2014 00:09:52 +0000 (01:09 +0100)]
RSSyl: fix crash introduced by previous commit
Andrej Kacian [Sun, 23 Nov 2014 21:20:37 +0000 (22:20 +0100)]
RSSyl: Convert relative URLs in Atom entries to absolute URLs, using feed's <link> tag, if possible.
Ricardo Mones [Mon, 17 Nov 2014 20:28:28 +0000 (21:28 +0100)]
Fix address out of bounds crash while decoding mails
For reference last stack frame:
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff1e820ca in ?? () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt full
No symbol table info available.
encoded_str=0x7fffffff23e6 "=?UTF-8?B?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>", addr_field=1) at unmime.c:135
decoded_text = 0xffffffffcdd6a0c0 <Address 0xffffffffcdd6a0c0 out of bounds>
quote_p = 0x0
len = 5
p = 0x7fffffff23e6 "=?UTF-8?B?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>"
eword_begin_p = 0x7fffffff23e6 "=?UTF-8?B?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>"
encoding_begin_p = 0x7fffffff23ed "?B?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>"
text_begin_p = 0x7fffffff23ef "?RGF2aWQgUHLDqXZvdA==?= <david@tilapin.org>"
eword_end_p = 0x7fffffff2404 "?= <david@tilapin.org>"
charset = "UTF-8", '\000' <repeats 19 times>, "\001\000\000\000\000\000\000"
encoding = 66 'B'
conv_str = 0x7fffcdd6a730 "\003"
outbuf = 0xe45380
out_str = 0x7fffcdd60e50 "E1Xq7ru-0002EK-Ro@franck.debian.org"
out_len = 13
in_quote = 0
Colin Leroy [Mon, 17 Nov 2014 14:13:12 +0000 (15:13 +0100)]
* Add a warning in case the length of the string isn't the length of
the decoded base64 content.
* Base64-encoded crypt results of the passwords can contain \0, so
treat them as binary.
Colin Leroy [Mon, 17 Nov 2014 13:47:15 +0000 (14:47 +0100)]
Add a wrapper function to decode base64, returning a null-terminated string.
Colin Leroy [Mon, 17 Nov 2014 08:24:58 +0000 (09:24 +0100)]
Fix use after free
Colin Leroy [Sun, 16 Nov 2014 13:25:12 +0000 (14:25 +0100)]
Fix double free
Andrej Kacian [Sat, 15 Nov 2014 20:40:09 +0000 (21:40 +0100)]
Remove double-free in SMTP AUTH PLAIN handling code.
Andrej Kacian [Sat, 15 Nov 2014 20:37:39 +0000 (21:37 +0100)]
Get rid of a forgotten debug_print().
Andrej Kacian [Sat, 15 Nov 2014 20:11:36 +0000 (21:11 +0100)]
Fix SMTP LOGIN auth method.
Michael Rasmussen [Sat, 15 Nov 2014 19:37:20 +0000 (20:37 +0100)]
fix a couple of memory leaks
Andrej Kacian [Sat, 15 Nov 2014 11:22:03 +0000 (12:22 +0100)]
Use GLib's implementation of Base64 instead of our own.
Michael Rasmussen [Fri, 14 Nov 2014 23:41:21 +0000 (00:41 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Michael Rasmussen [Fri, 14 Nov 2014 23:40:48 +0000 (00:40 +0100)]
remove unused code relating to old unsupported version of libarchive
Andrej Kacian [Fri, 7 Nov 2014 18:11:34 +0000 (19:11 +0100)]
Bogofilter: In addition to deleting or saving a spam message, allow third option, where such message is only marked as spam, but is let through for user to handle it further (perhaps via filtering rules).
Andrej Kacian [Mon, 10 Nov 2014 20:44:19 +0000 (21:44 +0100)]
Increase allowed range for age matcher condition widget. 10000 should be enough for everyone.
Ricardo Mones [Tue, 4 Nov 2014 15:48:06 +0000 (16:48 +0100)]
Fix bug #3321 → revert "Remove unreachable code"
This reverts commit
8090f02e4d5c41be4325f0a13d6b0d98ca03684b.
Many thanks to Andreas Rönnquist for the enlightenment!