claws.git
7 years agoRevert "Fix the other off-by-one bug in textview quoting."
Andrej Kacian [Wed, 29 Mar 2017 23:55:59 +0000 (01:55 +0200)]
Revert "Fix the other off-by-one bug in textview quoting."

This reverts commit 1acb353987cb2a45b6b6802cc48db6f66aac3121.
I refuse to be driven to madness by our textview's colorization.

7 years agoFix the other off-by-one bug in textview quoting.
Andrej Kacian [Wed, 29 Mar 2017 23:04:22 +0000 (01:04 +0200)]
Fix the other off-by-one bug in textview quoting.

There were two complementary off-by-one bugs, each masking
the other one. Commit 8819fe fixed the first one, thus
unmasking this one.

This should also fix the disgusting bug #3797:
"Unfold quoting renders quotes completely confusing".

7 years agoFix bug #3796 format-security warnings in alertpanel_ use
Andreas Bierfert [Wed, 29 Mar 2017 08:03:11 +0000 (10:03 +0200)]
Fix bug #3796 format-security warnings in alertpanel_ use

This patch fixes format-security warnings in alertpanel_ use by passing
"%s" as string and the buffer as va argument if no other va arguments
are present.

7 years agoFix an off-by-one error in textview's quote unfolding.
Andrej Kacian [Mon, 27 Mar 2017 19:02:37 +0000 (21:02 +0200)]
Fix an off-by-one error in textview's quote unfolding.

7 years agoupdate Czech and Slovak translations
Paul [Mon, 27 Mar 2017 15:06:11 +0000 (16:06 +0100)]
update Czech and Slovak translations

7 years agoupdate German translator
Paul [Sun, 26 Mar 2017 10:14:26 +0000 (11:14 +0100)]
update German translator

7 years agofor release 3.15.0 3.15.0
Paul [Sun, 26 Mar 2017 09:56:53 +0000 (10:56 +0100)]
for release 3.15.0

7 years agoupdate German translator and use UTF-8 for this file.
Paul [Sun, 26 Mar 2017 08:59:04 +0000 (09:59 +0100)]
update German translator and use UTF-8 for this file.

7 years agoupdate German translator
Paul [Sun, 26 Mar 2017 08:58:40 +0000 (09:58 +0100)]
update German translator

7 years agoupdate translations
Paul [Sun, 26 Mar 2017 08:58:16 +0000 (09:58 +0100)]
update translations

7 years agoFix file name in manpage
Ricardo Mones [Sun, 26 Mar 2017 00:22:47 +0000 (01:22 +0100)]
Fix file name in manpage

7 years agoUpdate Spanish translation for release
Ricardo Mones [Sat, 25 Mar 2017 23:56:59 +0000 (00:56 +0100)]
Update Spanish translation for release

7 years agoUpdate list of TLDs for release
Ricardo Mones [Sat, 25 Mar 2017 23:56:06 +0000 (00:56 +0100)]
Update list of TLDs for release

7 years agoMake summary_show() open-when-selected behavior more consistent.
Andrej Kacian [Fri, 24 Mar 2017 13:04:13 +0000 (14:04 +0100)]
Make summary_show() open-when-selected behavior more consistent.

Fall back to "on folder open" setting when deciding whether
or not to also open the selected message.

7 years agoFix timezone handling in procheader_date_parse() on Windows.
Andrej Kacian [Fri, 24 Mar 2017 10:11:58 +0000 (11:11 +0100)]
Fix timezone handling in procheader_date_parse() on Windows.

This fixes logic error introduced in 029174b.

7 years agoRemove deprecated entries in fr.po.
wwp [Tue, 21 Mar 2017 10:59:46 +0000 (11:59 +0100)]
Remove deprecated entries in fr.po.

7 years agoUpdate French translation.
wwp [Tue, 21 Mar 2017 10:56:09 +0000 (11:56 +0100)]
Update French translation.

7 years agoFix crash on e-mails with invalid date on Windows.
Andrej Kacian [Mon, 20 Mar 2017 18:52:11 +0000 (19:52 +0100)]
Fix crash on e-mails with invalid date on Windows.

This fixes crashing on dates with out of range numbers,
e.g. "Sun, 19 Mar 2017 27:41:31 +0600".

7 years agoUpdate copyright year
Michael Rasmussen [Sun, 19 Mar 2017 22:06:58 +0000 (23:06 +0100)]
Update copyright year

7 years agoCorrect/update comment.
wwp [Sun, 19 Mar 2017 18:42:04 +0000 (19:42 +0100)]
Correct/update comment.

7 years agoFix bug 3785: custom headers not stored in queued messages (and thus,
wwp [Sun, 19 Mar 2017 11:13:28 +0000 (12:13 +0100)]
Fix bug 3785: custom headers not stored in queued messages (and thus,
not sent).

7 years agoFix bug #3784: Very similar strings in src/gtk/about.c
Ricardo Mones [Sat, 18 Mar 2017 23:25:43 +0000 (00:25 +0100)]
Fix bug #3784: Very similar strings in src/gtk/about.c

And remove also some \n from translatable strings.

7 years agoAdd more granular options on when to open a selected message.
Andrej Kacian [Sat, 18 Mar 2017 20:53:17 +0000 (21:53 +0100)]
Add more granular options on when to open a selected message.

There are now several checkboxes in Display/Summaries page.
The checkbox in folder open selection dialog has been removed,
since that checkbox is among the new ones.

The option "always_show_message_when_selected" is now boolean,
instead of a tri-state.

This commit also removes function summary_display_by_msgnum(),
and its functionality was moved to summary_select_by_msgnum(), which
has a new boolean argument to control whether or not to display the
selected message.

7 years agoUse fix bug #3787 for specifying format as well
Michael Rasmussen [Sat, 18 Mar 2017 19:58:33 +0000 (20:58 +0100)]
Use fix bug #3787 for specifying format as well

7 years agoFix bug #3787. Create tooltip i helper function
Michael Rasmussen [Sat, 18 Mar 2017 19:43:47 +0000 (20:43 +0100)]
Fix bug #3787. Create tooltip i helper function

7 years agoimprove label text
Paul [Sat, 18 Mar 2017 12:21:14 +0000 (12:21 +0000)]
improve label text

7 years agoShow context of foldersel dialog in a label, instead of in a title.
Andrej Kacian [Sat, 18 Mar 2017 11:41:41 +0000 (12:41 +0100)]
Show context of foldersel dialog in a label, instead of in a title.

This is a follow-up commit to bd8213.

7 years agoFix typos, fixes bug 3786: typo in src/mimeview.c.
wwp [Fri, 17 Mar 2017 23:21:50 +0000 (00:21 +0100)]
Fix typos, fixes bug 3786: typo in src/mimeview.c.

7 years agoRequire SVG library version 2.40.5
Ricardo Mones [Thu, 16 Mar 2017 18:52:27 +0000 (19:52 +0100)]
Require SVG library version 2.40.5

Fix bug #3778: Claws-mail core dumps when trying to view a HTML email

7 years agoAllow custom window title for the folder selection dialog.
Andrej Kacian [Thu, 16 Mar 2017 18:14:49 +0000 (19:14 +0100)]
Allow custom window title for the folder selection dialog.

Fixes bug #3582 - Select folder dialogue does not tell what is
selecting for.

7 years agoAdded summary_get_selection_count() function.
Andrej Kacian [Thu, 16 Mar 2017 17:37:30 +0000 (18:37 +0100)]
Added summary_get_selection_count() function.

7 years agoSynchronize Spanish manual
Ricardo Mones [Tue, 14 Mar 2017 18:38:36 +0000 (19:38 +0100)]
Synchronize Spanish manual

7 years agoFix some color names and lists
Ricardo Mones [Tue, 14 Mar 2017 18:34:01 +0000 (19:34 +0100)]
Fix some color names and lists

7 years agoInitialize icaltimetype variables in Vcalendar's feed_fetch().
Andrej Kacian [Mon, 13 Mar 2017 18:03:25 +0000 (19:03 +0100)]
Initialize icaltimetype variables in Vcalendar's feed_fetch().

Also print out debug output if an event has no start or end,
as it can help determine why a malformed event file shows
weird times or duration.

7 years agoRemove obsolete files icaltime_as_local.[ch].
Andrej Kacian [Mon, 13 Mar 2017 17:18:57 +0000 (18:18 +0100)]
Remove obsolete files icaltime_as_local.[ch].

7 years agoadd new hidden prefs for various colours
Paul [Mon, 13 Mar 2017 07:14:36 +0000 (07:14 +0000)]
add new hidden prefs for various colours

7 years agoAdded debug output for failure cases in sgpgme_data_release_and_get_mem()
Andrej Kacian [Wed, 8 Mar 2017 11:07:51 +0000 (12:07 +0100)]
Added debug output for failure cases in sgpgme_data_release_and_get_mem()

7 years agoSynchronize Spanish manual
Ricardo Mones [Sat, 4 Mar 2017 12:06:16 +0000 (13:06 +0100)]
Synchronize Spanish manual

7 years agoCapitalise, punctuate and clean manpage
Ricardo Mones [Sat, 4 Mar 2017 12:04:33 +0000 (13:04 +0100)]
Capitalise, punctuate and clean manpage

7 years agoAdd forgotten file to manpage
Ricardo Mones [Sat, 4 Mar 2017 11:48:25 +0000 (12:48 +0100)]
Add forgotten file to manpage

7 years agoDeclare and use only when needed
Ricardo Mones [Sat, 4 Mar 2017 11:46:21 +0000 (12:46 +0100)]
Declare and use only when needed

7 years agowebkitglobals.h exists since 1.3.10, not 1.3.13.
Andrej Kacian [Fri, 3 Mar 2017 23:45:18 +0000 (00:45 +0100)]
webkitglobals.h exists since 1.3.10, not 1.3.13.

Patch by Olaf Hering <olaf at aepfle.de>

7 years agoAdd support for date-only variant of ISO8601 timestamp format.
Andrej Kacian [Fri, 3 Mar 2017 23:12:29 +0000 (00:12 +0100)]
Add support for date-only variant of ISO8601 timestamp format.

Fixes bug #3777 - Weird news dates for some RSS feeds

7 years agoFix option item and update dates
Ricardo Mones [Fri, 3 Mar 2017 14:08:26 +0000 (15:08 +0100)]
Fix option item and update dates

7 years agoRemove unused variable
Ricardo Mones [Thu, 2 Mar 2017 15:36:33 +0000 (16:36 +0100)]
Remove unused variable

prefs_actions.c:594:12: warning: unused variable ‘action_nb’

7 years agofix using building with --disable-deprecated
Paul [Thu, 2 Mar 2017 14:54:34 +0000 (14:54 +0000)]
fix using building with --disable-deprecated

If --disable-deprecated is specified it will set GTK_CFLAGS.
Later the pkgconfig check for GTK_CFLAGS will be skipped because the
variable is already set. As a result essential CLFAGS from gtk+-2.0 will
be missing in global CFLAGS and compilation fails.

Solution is to check for the configure flag after pkgconfig.

Thanks to Olaf Hering <olaf@aepfle.de>

7 years agoReduce translators' work by merging almost-duplicated strings
wwp [Wed, 1 Mar 2017 15:52:34 +0000 (16:52 +0100)]
Reduce translators' work by merging almost-duplicated strings
(reported by Pader Rezso).

7 years agofix disabling prefs_common.warn_sending_many_recipients_num by unchecking the 'show...
Paul [Wed, 1 Mar 2017 13:13:24 +0000 (13:13 +0000)]
fix disabling prefs_common.warn_sending_many_recipients_num by unchecking the 'show this msg again' checkbox in the dialogue

7 years agoMake 'Save all...' report more accurate
Ricardo Mones [Wed, 1 Mar 2017 09:45:49 +0000 (10:45 +0100)]
Make 'Save all...' report more accurate

Thanks Woody for nitpicking.

7 years agobump copyright year
Paul [Wed, 1 Mar 2017 08:02:03 +0000 (08:02 +0000)]
bump copyright year

7 years agoDocument hidden pref 'warn_sending_many_recipients_num'
Ricardo Mones [Mon, 27 Feb 2017 23:00:26 +0000 (00:00 +0100)]
Document hidden pref 'warn_sending_many_recipients_num'

7 years agoSimplify hidden prefs for too many recipients
Ricardo Mones [Mon, 27 Feb 2017 22:59:19 +0000 (23:59 +0100)]
Simplify hidden prefs for too many recipients

7 years agoFix bug #3775, wrong plural form string.
wwp [Mon, 27 Feb 2017 12:36:58 +0000 (13:36 +0100)]
Fix bug #3775, wrong plural form string.

7 years agoFix memory leak
Olivier Brunel [Sat, 25 Feb 2017 20:06:21 +0000 (21:06 +0100)]
Fix memory leak

Signed-off-by: Olivier Brunel <jjk@jjacky.com>
7 years agoRemove duplicated code and include
Ricardo Mones [Sat, 25 Feb 2017 12:14:35 +0000 (13:14 +0100)]
Remove duplicated code and include

7 years agoReplace verbosity boolean flag with a bitfield of flags.
Andrej Kacian [Sat, 25 Feb 2017 10:43:26 +0000 (11:43 +0100)]
Replace verbosity boolean flag with a bitfield of flags.

Currently, there are two - whether or not to show error dialogs
and whether or not to show a feed rename dialog after subscribing.

We use same enum typedef for subscribing and fetching/updating
for consistency, the second flag only has effect in rssyl_subscribe().

7 years agoRemove rssyl_feed_subscribe_new(), it was redundant.
Andrej Kacian [Sat, 25 Feb 2017 10:32:52 +0000 (11:32 +0100)]
Remove rssyl_feed_subscribe_new(), it was redundant.

rssyl_subscribe() is almost identical, so it is used instead.
Some minor usability issues that arise from this change will
be fixed in next commit(s).

7 years agoFix bug #3741: Deleting an account doesn't delete imapcache
Ricardo Mones [Tue, 21 Feb 2017 18:05:19 +0000 (19:05 +0100)]
Fix bug #3741: Deleting an account doesn't delete imapcache

Based on initial patch by Paul and in exchange of a reviewed
patch for 3582 ;-)

7 years agoRemove internal libytnef and require an external one instead.
Andrej Kacian [Wed, 22 Feb 2017 09:26:09 +0000 (10:26 +0100)]
Remove internal libytnef and require an external one instead.

7 years agoDo not hardcode resolv.conf location
Ricardo Mones [Thu, 16 Feb 2017 21:57:37 +0000 (22:57 +0100)]
Do not hardcode resolv.conf location

7 years agouse xdg-open as default mime_open_command
Paul [Thu, 16 Feb 2017 13:49:00 +0000 (13:49 +0000)]
use xdg-open as default mime_open_command

7 years agoFix 'Apply' when changing scaling options only
Ricardo Mones [Wed, 15 Feb 2017 23:40:46 +0000 (00:40 +0100)]
Fix 'Apply' when changing scaling options only

7 years agoRemove spurious comment
Ricardo Mones [Tue, 14 Feb 2017 00:00:56 +0000 (01:00 +0100)]
Remove spurious comment

7 years agoMigrate icon filename stored in toolbar XML files
Ricardo Mones [Mon, 13 Feb 2017 23:58:59 +0000 (00:58 +0100)]
Migrate icon filename stored in toolbar XML files

Thanks Paul for the hint.
Completes commit 50bd87f2e13a9dbdb2a1a449823ff16ae87239f8.

7 years agoFix impossible action duplication: don't check for duplicate action name
wwp [Mon, 13 Feb 2017 17:55:28 +0000 (18:55 +0100)]
Fix impossible action duplication: don't check for duplicate action name
when saving/duplicating (we're not doing this elsewhere and I don't see
the point in doing it here).

7 years agoadd Bcc to default headers in drop-down
Paul [Mon, 13 Feb 2017 15:20:53 +0000 (15:20 +0000)]
add Bcc to default headers in drop-down

7 years agoFix pixmap name to reflect what it really does
Ricardo Mones [Sat, 11 Feb 2017 15:47:50 +0000 (16:47 +0100)]
Fix pixmap name to reflect what it really does

Will break your themes, nothing a mv cannot fix ;-)

7 years agoFix wrong return value type.
wwp [Wed, 8 Feb 2017 22:33:38 +0000 (23:33 +0100)]
Fix wrong return value type.

7 years agoSet same size as its companions (new and unread)
Ricardo Mones [Wed, 8 Feb 2017 19:22:14 +0000 (20:22 +0100)]
Set same size as its companions (new and unread)

7 years agoFix included header
Ricardo Mones [Tue, 7 Feb 2017 20:07:16 +0000 (21:07 +0100)]
Fix included header

Error message was:
stock_pixmap.c:26:26: fatal error: librsvg/rsvg.h: No such file or directory

Thanks Paul for reporting!

7 years agoUser interface for SVG preferences
Ricardo Mones [Mon, 6 Feb 2017 23:56:29 +0000 (00:56 +0100)]
User interface for SVG preferences

7 years agoAdd SVG icon scaling/rendering preferences
Ricardo Mones [Tue, 31 Jan 2017 23:27:19 +0000 (00:27 +0100)]
Add SVG icon scaling/rendering preferences

• 'enable_alpha_svg' to use alpha channel when rendering
• 'enable_pixmap_scaling' to bypass SVG's own natural size
• 'pixmap_scaling_auto' to compute a PPI or use a user defined value
• 'pixmap_scaling_ppi' to set a user defined value for PPI

7 years agoRender SVG scaled to default icon size
Ricardo Mones [Mon, 30 Jan 2017 22:22:20 +0000 (23:22 +0100)]
Render SVG scaled to default icon size

Default icon sizes are parsed from icon data, which is suboptimal
since these sizes can be known at compile time.

7 years agoLoad SVG files the deprecated way
Ricardo Mones [Sat, 28 Jan 2017 20:29:30 +0000 (21:29 +0100)]
Load SVG files the deprecated way

7 years agoConfigure SVG library
Ricardo Mones [Fri, 27 Jan 2017 22:41:15 +0000 (23:41 +0100)]
Configure SVG library

• New feature flag HAVE_SVG, enabled by default if dependencies
  are available (librsvg-2.0 >= 2.36.0).
• New item in About window's Features tab for librSVG.

7 years agoRemove generated file
Ricardo Mones [Mon, 6 Feb 2017 14:14:40 +0000 (15:14 +0100)]
Remove generated file

and ignore it properly :-)

7 years agoA bit more room for alertpanel messages
Ricardo Mones [Mon, 6 Feb 2017 13:24:57 +0000 (14:24 +0100)]
A bit more room for alertpanel messages

And same room for all of them. The current sizes were so small that
a somewhat large list of failed-to-load plugins appeared truncated
in the warning message.

7 years agoremove unused variable
Paul [Sun, 5 Feb 2017 08:46:24 +0000 (08:46 +0000)]
remove unused variable

7 years agono tranlslation needed here
Paul [Sun, 5 Feb 2017 08:38:57 +0000 (08:38 +0000)]
no tranlslation needed here

7 years agoFix build when using alternate addressbook
Michael Rasmussen [Sun, 5 Feb 2017 00:13:03 +0000 (01:13 +0100)]
Fix build when using alternate addressbook

7 years agoMake --disable-dillo-plugin actually do something.
Andrej Kacian [Sat, 4 Feb 2017 17:31:45 +0000 (18:31 +0100)]
Make --disable-dillo-plugin actually do something.

7 years agoUnify display of event times in vCalendar's mimeviewer on Windows and Unix.
Andrej Kacian [Sat, 4 Feb 2017 16:35:20 +0000 (17:35 +0100)]
Unify display of event times in vCalendar's mimeviewer on Windows and Unix.

We now use g_date_time_format() on both. Also, display
timezone abbreviation (%Z) instead of offset (%z) in the
strings.

7 years agoHandle timezones correctly in vCalendar.
Andrej Kacian [Sat, 4 Feb 2017 16:33:07 +0000 (17:33 +0100)]
Handle timezones correctly in vCalendar.

We convert DTSTART and DTEND to UTC as soon as possible,
using the VTIMEZONE info. The convert_to_utc() function
should be able to handle several timezone definitions and
events using those several different timezones in one ical
file, picking the correct one for converting each event.

7 years agoUse PLUGIN_NAME macro instead of "vCalendar" string literal internally.
Andrej Kacian [Sat, 4 Feb 2017 13:18:03 +0000 (14:18 +0100)]
Use PLUGIN_NAME macro instead of "vCalendar" string literal internally.

7 years agoOops! forgot one themeable icon in pdf_viewer
Ricardo Mones [Sat, 4 Feb 2017 11:55:21 +0000 (12:55 +0100)]
Oops! forgot one themeable icon in pdf_viewer

Completes commit 89d34855ea0a9213c0ab133cc0a7a0511086ad64.

7 years agoMake a relative signature_path relative to home directory.
Andrej Kacian [Fri, 3 Feb 2017 18:03:19 +0000 (19:03 +0100)]
Make a relative signature_path relative to home directory.

This applies only if corresponding signature_type is SIG_FILE.

7 years agoMoved found_in_addressbook() from plugins to core.
Andrej Kacian [Fri, 3 Feb 2017 16:48:02 +0000 (17:48 +0100)]
Moved found_in_addressbook() from plugins to core.

Four identical copies of the same functions removed
from four plugins and put into addr_compl.[ch].

7 years agoMake all headers abide by config and features
Ricardo Mones [Fri, 3 Feb 2017 11:56:31 +0000 (12:56 +0100)]
Make all headers abide by config and features

7 years agoRe-introducing the Dillo plugin. Tested against Dillo 3.0.4.1/3.0.5.
wwp [Thu, 2 Feb 2017 17:06:27 +0000 (18:06 +0100)]
Re-introducing the Dillo plugin. Tested against Dillo 3.0.4.1/3.0.5.

7 years agoRemove obsolete font prefs
Ricardo Mones [Tue, 31 Jan 2017 19:02:51 +0000 (20:02 +0100)]
Remove obsolete font prefs

7 years agoGeneralise theme extension handling
Ricardo Mones [Mon, 30 Jan 2017 23:11:47 +0000 (00:11 +0100)]
Generalise theme extension handling

7 years agovCalendar plugin: use external libical
Paul [Fri, 27 Jan 2017 15:56:47 +0000 (15:56 +0000)]
vCalendar plugin: use external libical

closes bug #3764
patch by flo.xfce@gmx-topmail.de

7 years agosensitise trayicon's 'get mail' and 'exit'
Paul [Fri, 27 Jan 2017 15:40:27 +0000 (15:40 +0000)]
sensitise trayicon's 'get mail' and 'exit'

patch by Olivier Brunel

7 years agoadd shadow to rule list (like everywhere else)
Paul [Fri, 27 Jan 2017 15:37:06 +0000 (15:37 +0000)]
add shadow to rule list (like everywhere else)

patch by Olivier Brunel

7 years agowhen renaming folder, only update summaryview folder name if the current folder is...
Paul [Fri, 27 Jan 2017 15:32:11 +0000 (15:32 +0000)]
when renaming folder, only update summaryview folder name if the current folder is being renamed

patch by Olivier Brunel

7 years agoFix typos and a wrong switch expression (coverity CID #1399549).
wwp [Tue, 24 Jan 2017 06:41:39 +0000 (07:41 +0100)]
Fix typos and a wrong switch expression (coverity CID #1399549).

7 years agoBetter error handling and feedback for save all attachments
Ricardo Mones [Mon, 23 Jan 2017 22:48:18 +0000 (23:48 +0100)]
Better error handling and feedback for save all attachments

7 years agoUpdate French translation.
wwp [Mon, 23 Jan 2017 19:52:13 +0000 (20:52 +0100)]
Update French translation.

7 years agoNo need to test what g_malloc returns, as if it fails, it stops the
wwp [Sat, 21 Jan 2017 22:51:31 +0000 (23:51 +0100)]
No need to test what g_malloc returns, as if it fails, it stops the
program.

7 years agoAlways show a notice dialog after delete-dupes, even if nothing has
wwp [Sat, 21 Jan 2017 14:12:43 +0000 (15:12 +0100)]
Always show a notice dialog after delete-dupes, even if nothing has
been deleted. Make a better notice when it's about marking as delete
(for later deletion when execute is done). Always say we're deleting
dupes, in status bar.
Fix toolbar item sensibility even though if it's not perfect since
the whole button dropdown menu can't be accessed if current folder
can't be searched for dupes.