claws.git
4 years agofix annoyance where your current reading is disturbed when a new msg is filtered...
Paul [Mon, 29 Oct 2018 17:31:51 +0000 (17:31 +0000)]
fix annoyance where your current reading is disturbed when a new msg is filtered into the current folder

4 years agofix for smtp-only accounts when global pref for save sent msg is set
Paul [Mon, 29 Oct 2018 09:03:04 +0000 (09:03 +0000)]
fix for smtp-only accounts when global pref for save sent msg is set

4 years agorevert g45500aa, it breaks stuff
Paul [Mon, 29 Oct 2018 09:01:16 +0000 (09:01 +0000)]
revert g45500aa, it breaks stuff

4 years agoHandle compose "Save Message to" checkbox state in compose_set_save_to() only.
Andrej Kacian [Sun, 28 Oct 2018 20:58:31 +0000 (21:58 +0100)]
Handle compose "Save Message to" checkbox state in compose_set_save_to() only.

Fixes bug #4107 - Sent messages do not appear in "Sent" folder...

4 years agoonly show warning about privacy system 'none' on replies to signed or encrypted msgs
Paul [Fri, 26 Oct 2018 12:38:19 +0000 (13:38 +0100)]
only show warning about privacy system 'none' on replies to signed or encrypted msgs

4 years agoadd error checking on account prefs Advanced page
Paul [Thu, 25 Oct 2018 16:09:16 +0000 (17:09 +0100)]
add error checking on account prefs Advanced page

4 years agoalways use folder pref for save msg location if set
Paul [Thu, 25 Oct 2018 16:08:21 +0000 (17:08 +0100)]
always use folder pref for save msg location if set

4 years agoallow account pref and folder pref to override global pref for saving sent msgs
Paul [Thu, 25 Oct 2018 16:07:19 +0000 (17:07 +0100)]
allow account pref and folder pref to override global pref for saving sent msgs

4 years agoless haste
Paul [Thu, 25 Oct 2018 09:56:44 +0000 (10:56 +0100)]
less haste

4 years agoremove wrongly pushed change in bfc95529975d50e8cda7a85b439aab23f2021c53
Paul [Thu, 25 Oct 2018 09:55:30 +0000 (10:55 +0100)]
remove wrongly pushed change in bfc95529975d50e8cda7a85b439aab23f2021c53

4 years agodon't leave the user in limbo when privacy system is 'none' and auto signing/encrypti...
Paul [Thu, 25 Oct 2018 09:36:54 +0000 (10:36 +0100)]
don't leave the user in limbo when privacy system is 'none' and auto signing/encrypting is set

4 years agoPack account prefs' checkbtn_crosspost into correct hbox, rather than leaving it...
Andrej Kacian [Wed, 24 Oct 2018 15:23:14 +0000 (17:23 +0200)]
Pack account prefs' checkbtn_crosspost into correct hbox, rather than leaving it unused.

4 years agoDo not use gtk_cmctree_set_line_style(), since it does nothing.
Andrej Kacian [Wed, 24 Oct 2018 15:20:10 +0000 (17:20 +0200)]
Do not use gtk_cmctree_set_line_style(), since it does nothing.

4 years agoRemoved deprecated g_type_class_add_private() call in ClawsSpellEntry.
Andrej Kacian [Tue, 23 Oct 2018 18:51:06 +0000 (20:51 +0200)]
Removed deprecated g_type_class_add_private() call in ClawsSpellEntry.

4 years agoUse GTK private struct feature correctly in ClawsSpellEntry.
Andrej Kacian [Tue, 23 Oct 2018 18:46:32 +0000 (20:46 +0200)]
Use GTK private struct feature correctly in ClawsSpellEntry.

g_type_class_add_private() takes care of adding,
initializing and cleaning it up, there is no need
to add another copy of it and manage it manually.

4 years agoRemoved deprecated g_type_class_add_private() call in GtkSHRuler.
Andrej Kacian [Tue, 23 Oct 2018 18:30:49 +0000 (20:30 +0200)]
Removed deprecated g_type_class_add_private() call in GtkSHRuler.

4 years agoRework debug output in passwd_store_set() to be less confusing.
Andrej Kacian [Fri, 19 Oct 2018 21:36:40 +0000 (23:36 +0200)]
Rework debug output in passwd_store_set() to be less confusing.

4 years agoWhen deleting an account, delete its password store block, instead of just NULLing...
Andrej Kacian [Fri, 19 Oct 2018 21:22:20 +0000 (23:22 +0200)]
When deleting an account, delete its password store block, instead of just NULLing the block's entries hash table.

4 years agoFix translation for octet-stream view
Ricardo Mones [Fri, 19 Oct 2018 11:58:11 +0000 (13:58 +0200)]
Fix translation for octet-stream view

4 years agoRewrap fr manual for lisibility
Colin Leroy [Thu, 18 Oct 2018 12:13:58 +0000 (14:13 +0200)]
Rewrap fr manual for lisibility

4 years agoFix crash in dangling message search.
Colin Leroy [Wed, 17 Oct 2018 07:26:26 +0000 (09:26 +0200)]
Fix crash in dangling message search.

4 years agoDo not redraw focus of GtkCMCList if the row is unchanged in move_focus_row();
Andrej Kacian [Tue, 16 Oct 2018 16:18:40 +0000 (18:18 +0200)]
Do not redraw focus of GtkCMCList if the row is unchanged in move_focus_row();

4 years agoIn summary_key_pressed(), do not try to reopen the same message if cursor does not...
Andrej Kacian [Tue, 16 Oct 2018 16:16:02 +0000 (18:16 +0200)]
In summary_key_pressed(), do not try to reopen the same message if cursor does not change.

4 years agoFix an off-by-one error in summary_key_pressed().
Andrej Kacian [Tue, 16 Oct 2018 16:12:05 +0000 (18:12 +0200)]
Fix an off-by-one error in summary_key_pressed().

4 years agofix bug (rfe) 4102, 'Show SHA-256 fingerprint in certificate verification popup'
Paul [Tue, 16 Oct 2018 09:10:03 +0000 (10:10 +0100)]
fix bug (rfe) 4102, 'Show SHA-256 fingerprint in certificate verification popup'

4 years agofix invalid cast runtime warning
Paul [Tue, 16 Oct 2018 06:38:19 +0000 (07:38 +0100)]
fix invalid cast runtime warning

4 years agoPDF Viewer: handle Ctrl+scroll for zooming
Colin Leroy [Mon, 15 Oct 2018 19:15:05 +0000 (21:15 +0200)]
PDF Viewer: handle Ctrl+scroll for zooming

4 years agoFancy: fix left-click on links not opening in browser.
Colin Leroy [Mon, 15 Oct 2018 08:39:21 +0000 (10:39 +0200)]
Fancy: fix left-click on links not opening in browser.

4 years agoMake the "Saving sent message..." debug prints more interesting.
Colin Leroy [Thu, 11 Oct 2018 14:06:39 +0000 (16:06 +0200)]
Make the "Saving sent message..." debug prints more interesting.

4 years agoRevert all memory-based tmpfile I/O, it comes with too much drawbacks
Colin Leroy [Wed, 10 Oct 2018 12:34:34 +0000 (14:34 +0200)]
Revert all memory-based tmpfile I/O, it comes with too much drawbacks
(like having to know the filesize before writing to it)

4 years agoFix wording, thanks wwp
Colin Leroy [Wed, 10 Oct 2018 08:37:23 +0000 (10:37 +0200)]
Fix wording, thanks wwp

4 years agostr_open_as_stream() doesn't need a real file either.
Colin Leroy [Wed, 10 Oct 2018 08:22:09 +0000 (10:22 +0200)]
str_open_as_stream() doesn't need a real file either.

4 years agoComment the my_tmpfile_with_len() function.
Colin Leroy [Wed, 10 Oct 2018 08:09:11 +0000 (10:09 +0200)]
Comment the my_tmpfile_with_len() function.

4 years agoFix in-memory temporary file length
Colin Leroy [Wed, 10 Oct 2018 07:59:10 +0000 (09:59 +0200)]
Fix in-memory temporary file length

4 years agoUpdate textviewer.pl
Ricardo Mones [Mon, 8 Oct 2018 13:51:15 +0000 (15:51 +0200)]
Update textviewer.pl

Patch by H.Merijn Brand

4 years agoUpdate thread tools
Ricardo Mones [Mon, 8 Oct 2018 13:49:29 +0000 (15:49 +0200)]
Update thread tools

Patch by H.Merijn Brand

4 years ago...and one more forgotten NULL check.
Andrej Kacian [Mon, 8 Oct 2018 11:31:31 +0000 (13:31 +0200)]
...and one more forgotten NULL check.

4 years agoAdded some NULL checks in passwordstore.c to avoid potential crash.
Andrej Kacian [Mon, 8 Oct 2018 11:29:21 +0000 (13:29 +0200)]
Added some NULL checks in passwordstore.c to avoid potential crash.

4 years agoFix unit tests building, broken after the file-utils addition.
Andrej Kacian [Mon, 8 Oct 2018 08:34:08 +0000 (10:34 +0200)]
Fix unit tests building, broken after the file-utils addition.

4 years agoFix file-utils related compiler warnings in crash.c.
Andrej Kacian [Mon, 8 Oct 2018 08:33:26 +0000 (10:33 +0200)]
Fix file-utils related compiler warnings in crash.c.

4 years agoFix hang on IMAP - the log file is accessed by multiple threads
Colin Leroy [Sun, 7 Oct 2018 19:31:37 +0000 (21:31 +0200)]
Fix hang on IMAP - the log file is accessed by multiple threads

4 years agoMake safe_fclose static now that it can be
Colin Leroy [Sun, 7 Oct 2018 18:41:20 +0000 (20:41 +0200)]
Make safe_fclose static now that it can be

4 years agoMerge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 18:26:50 +0000 (20:26 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws

4 years agoImprove debug output in passwd_store_set().
Andrej Kacian [Sun, 7 Oct 2018 17:16:15 +0000 (19:16 +0200)]
Improve debug output in passwd_store_set().

4 years agoFix performance loss on certain file I/O that doesn't need
Colin Leroy [Sun, 7 Oct 2018 13:40:38 +0000 (15:40 +0200)]
Fix performance loss on certain file I/O that doesn't need
to be safe

4 years agoAdd a memory-backed my_tmpfile() implementation.
Colin Leroy [Sun, 7 Oct 2018 13:32:38 +0000 (15:32 +0200)]
Add a memory-backed my_tmpfile() implementation.

4 years agoRename claws_io to file-utils, and move file-related functions
Colin Leroy [Sun, 7 Oct 2018 12:46:02 +0000 (14:46 +0200)]
Rename claws_io to file-utils, and move file-related functions
from utils.c to file-utils.c

4 years agoMerge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 12:16:04 +0000 (14:16 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws

4 years agoWrap file I/O to claws_* to benefit from custom locking when
Colin Leroy [Sun, 7 Oct 2018 12:12:29 +0000 (14:12 +0200)]
Wrap file I/O to claws_* to benefit from custom locking when
available. Gains about 33% on I/O bound tasks.

4 years agoFix CID 1439996 and remove unnecessary comparison
Ricardo Mones [Sun, 7 Oct 2018 11:27:30 +0000 (13:27 +0200)]
Fix CID 1439996 and remove unnecessary comparison

4 years agoMerge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 09:11:29 +0000 (11:11 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws

4 years agoHey I'm married :)
Colin Leroy [Sun, 7 Oct 2018 09:11:06 +0000 (11:11 +0200)]
Hey I'm married :)

4 years agoDon't ignore required file
Ricardo Mones [Sat, 6 Oct 2018 14:38:23 +0000 (16:38 +0200)]
Don't ignore required file

4 years agoClean more rubbish
Ricardo Mones [Sat, 6 Oct 2018 12:32:30 +0000 (14:32 +0200)]
Clean more rubbish

4 years agoRemove old files that shouldn't be there
Colin Leroy [Sat, 6 Oct 2018 11:33:07 +0000 (13:33 +0200)]
Remove old files that shouldn't be there

4 years agoFix indent, sorry.
Colin Leroy [Sat, 6 Oct 2018 11:04:16 +0000 (13:04 +0200)]
Fix indent, sorry.

4 years agoFix build
Colin Leroy [Sat, 6 Oct 2018 11:00:00 +0000 (13:00 +0200)]
Fix build

4 years agoUse a memory-based FILE pointer when we can; speeds up search.
Colin Leroy [Sat, 6 Oct 2018 10:48:01 +0000 (12:48 +0200)]
Use a memory-based FILE pointer when we can; speeds up search.

4 years agoDon't bother parsing headers when we want to skip them
Colin Leroy [Sat, 6 Oct 2018 10:46:48 +0000 (12:46 +0200)]
Don't bother parsing headers when we want to skip them
Speeds up body-only search

4 years agoFix big leak on mimeinfo freeing
Colin Leroy [Sat, 6 Oct 2018 10:43:31 +0000 (12:43 +0200)]
Fix big leak on mimeinfo freeing

4 years agoHalve the time spent manipulating case in case-insensitive searches
Colin Leroy [Sat, 6 Oct 2018 09:26:53 +0000 (11:26 +0200)]
Halve the time spent manipulating case in case-insensitive searches

4 years agoImplement safe_fclose() so we can respect the "Metadata handling"
Colin Leroy [Fri, 5 Oct 2018 21:01:46 +0000 (23:01 +0200)]
Implement safe_fclose() so we can respect the "Metadata handling"
preference for every data file we write into.

4 years agoDo not use trim_string() in RSSyl's rename folder dialog.
Andrej Kacian [Thu, 4 Oct 2018 18:25:53 +0000 (20:25 +0200)]
Do not use trim_string() in RSSyl's rename folder dialog.

4 years agoSimplify comparison
Ricardo Mones [Thu, 4 Oct 2018 13:49:07 +0000 (15:49 +0200)]
Simplify comparison

and keep Coverity happy.

4 years agoDisallow zero-length entity
Ricardo Mones [Thu, 4 Oct 2018 08:49:32 +0000 (10:49 +0200)]
Disallow zero-length entity

4 years agoFix CID 1439871 and validate Unicode char strictly
Ricardo Mones [Thu, 4 Oct 2018 08:30:12 +0000 (10:30 +0200)]
Fix CID 1439871 and validate Unicode char strictly

4 years agoMake entity_decode() handle invalid input better.
Andrej Kacian [Wed, 3 Oct 2018 16:27:39 +0000 (18:27 +0200)]
Make entity_decode() handle invalid input better.

4 years agoFix Reply from mainwindow menu and toolbar when mainwindow's
Colin Leroy [Wed, 3 Oct 2018 07:15:30 +0000 (09:15 +0200)]
Fix Reply from mainwindow menu and toolbar when mainwindow's
messageview is hidden.

4 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Colin Leroy [Tue, 2 Oct 2018 14:34:17 +0000 (16:34 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

4 years agoFix Coverity #1372351
Colin Leroy [Tue, 2 Oct 2018 14:27:41 +0000 (16:27 +0200)]
Fix Coverity #1372351

4 years agoFix build warning
Colin Leroy [Tue, 2 Oct 2018 14:27:27 +0000 (16:27 +0200)]
Fix build warning

4 years agoFix Coverity #1220388
Colin Leroy [Tue, 2 Oct 2018 14:21:16 +0000 (16:21 +0200)]
Fix Coverity #1220388

4 years agoFix Coverity #1220444
Colin Leroy [Tue, 2 Oct 2018 14:16:57 +0000 (16:16 +0200)]
Fix Coverity #1220444

4 years agoRemove Webkit version check ifdefs, since we depend on a new enough version.
Andrej Kacian [Tue, 2 Oct 2018 12:18:52 +0000 (14:18 +0200)]
Remove Webkit version check ifdefs, since we depend on a new enough version.

4 years agoDon't try to be too clever and remove superuser_p()
Ricardo Mones [Mon, 1 Oct 2018 21:58:24 +0000 (23:58 +0200)]
Don't try to be too clever and remove superuser_p()

Being root doesn't really tell much about filesystem permissions. Now it
simply ask user what to do and does it as requested. If things go wrong
errors will be catched anyway.

4 years agoFix possible resource leak
Colin Leroy [Fri, 28 Sep 2018 14:55:24 +0000 (16:55 +0200)]
Fix possible resource leak

4 years agoFix implicit declaration of g_close()
Colin Leroy [Fri, 28 Sep 2018 13:26:59 +0000 (15:26 +0200)]
Fix implicit declaration of g_close()

4 years agoAdd a few ignores
Colin Leroy [Fri, 28 Sep 2018 12:17:24 +0000 (14:17 +0200)]
Add a few ignores

4 years agoFix build on Debian 7
Colin Leroy [Fri, 28 Sep 2018 12:17:11 +0000 (14:17 +0200)]
Fix build on Debian 7

4 years agoFix Coverity warning (unsafe fscanf)
Colin Leroy [Fri, 28 Sep 2018 11:20:26 +0000 (13:20 +0200)]
Fix Coverity warning (unsafe fscanf)

4 years agoFix bug #3889, "Address and quoted message inconsistent in reply"
Colin Leroy [Fri, 28 Sep 2018 08:33:20 +0000 (10:33 +0200)]
Fix bug #3889, "Address and quoted message inconsistent in reply"
* Fix right-click replying to messages in summaryview
* Fix corner-case when selected and opened messages are different,
  and one of them is to a mailing-list.

4 years agoFix possible null-dereference (thanks Coverity)
Colin Leroy [Fri, 28 Sep 2018 08:29:27 +0000 (10:29 +0200)]
Fix possible null-dereference (thanks Coverity)

4 years agoFix Quicksearch eating keypresses it didn't handle.
Colin Leroy [Thu, 27 Sep 2018 06:55:10 +0000 (08:55 +0200)]
Fix Quicksearch eating keypresses it didn't handle.

4 years agoAdd a NULL check in summary_select_by_msg_list when selecting tree nodes.
Andrej Kacian [Sun, 23 Sep 2018 14:44:45 +0000 (16:44 +0200)]
Add a NULL check in summary_select_by_msg_list when selecting tree nodes.

This fixes an assertion failure when executing an action
which moves selected messages to a different folder. We
obviously cannot select previously selected messages if
they're not in current folder anymore.

4 years agoQuicksearch: expand extended symbols on "Edit", patch by Olivier Brunel.
wwp [Thu, 20 Sep 2018 20:16:33 +0000 (22:16 +0200)]
Quicksearch: expand extended symbols on "Edit", patch by Olivier Brunel.

4 years agoFix protocol part of some more URLs
Paul [Thu, 20 Sep 2018 09:00:47 +0000 (10:00 +0100)]
Fix protocol part of some more URLs

4 years agoFix protocol part of some URLs
Ricardo Mones [Wed, 19 Sep 2018 22:53:52 +0000 (00:53 +0200)]
Fix protocol part of some URLs

4 years agoSet missing pubdate/moddate in RSSyl items to the other one, if available.
Andrej Kacian [Tue, 18 Sep 2018 17:29:12 +0000 (19:29 +0200)]
Set missing pubdate/moddate in RSSyl items to the other one, if available.

4 years agoThe pubDate timestamp in RSS2.0 sets date_published.
Andrej Kacian [Tue, 18 Sep 2018 17:28:28 +0000 (19:28 +0200)]
The pubDate timestamp in RSS2.0 sets date_published.

4 years agoRemove dead code
Ricardo Mones [Wed, 12 Sep 2018 14:59:24 +0000 (16:59 +0200)]
Remove dead code

4 years agoRemove unused macro G_STRING_APPEND_ENCODED_URI.
Andrej Kacian [Tue, 11 Sep 2018 15:48:57 +0000 (17:48 +0200)]
Remove unused macro G_STRING_APPEND_ENCODED_URI.

4 years agofix warning dialogue when a re-edited draft compose window is closed after a send...
Paul [Mon, 10 Sep 2018 12:30:05 +0000 (13:30 +0100)]
fix warning dialogue when a re-edited draft compose window is closed after a send failure

prevents unexpected loss of drafted message

4 years agoRestore the hovering-over-link callback in Fancy viewer.
Andrej Kacian [Fri, 7 Sep 2018 20:19:43 +0000 (22:19 +0200)]
Restore the hovering-over-link callback in Fancy viewer.

We still need it to display the hovered-over link in statusbar.

4 years agoAdd new folder options: enable/disable per-folder signing and
wwp [Fri, 7 Sep 2018 06:05:22 +0000 (08:05 +0200)]
Add new folder options: enable/disable per-folder signing and
encrypting (by default: obey to applicable account preference).

4 years agoFix dangling pointer in proxy password handling.
Andrej Kacian [Thu, 6 Sep 2018 21:31:16 +0000 (23:31 +0200)]
Fix dangling pointer in proxy password handling.

Initialize proxy_info.proxy_pass to NULL, and reset it
back to NULL after use.

4 years agoShow correct address:port in SOCKS5 proxy connection failure message.
Andrej Kacian [Thu, 6 Sep 2018 21:13:41 +0000 (23:13 +0200)]
Show correct address:port in SOCKS5 proxy connection failure message.

The address and port contained in the server response
are what the proxy server has bound locally for the
connection, not the destination address and port.

4 years agoHandle corrupted decrypted passwords gracefully.
Andrej Kacian [Thu, 6 Sep 2018 20:11:05 +0000 (22:11 +0200)]
Handle corrupted decrypted passwords gracefully.

Check whether the decrypted password is a valid UTF-8
string, and return an empty string if not, instead of
returning garbage, probably not NULL-terminated data,
and causing problems down the road.

4 years agoAvoid an unnecessary string copy in xml_attr_new_int().
Andrej Kacian [Thu, 6 Sep 2018 16:43:35 +0000 (18:43 +0200)]
Avoid an unnecessary string copy in xml_attr_new_int().

4 years agoRename activate_privacy_system() to compose_activate_privacy_system().
wwp [Thu, 6 Sep 2018 14:21:15 +0000 (16:21 +0200)]
Rename activate_privacy_system() to compose_activate_privacy_system().

4 years agoBump up minimum required webkitgtk version to 1.10.0.
Andrej Kacian [Wed, 5 Sep 2018 16:35:47 +0000 (18:35 +0200)]
Bump up minimum required webkitgtk version to 1.10.0.

That's when WebKitWebView's "context-menu" signal was
added, we start using it in 288d3a708.