Andrej Kacian [Sat, 23 Jul 2016 21:02:55 +0000 (23:02 +0200)]
Embarrassing typo fix in rssyl_subscribe().
Andrej Kacian [Sat, 23 Jul 2016 20:41:04 +0000 (22:41 +0200)]
Added working_directory parameter to execute_command_line()
It gets passed as a first argument to g_spawn_sync/async.
Mostly NULL, since that's what was passed until now, but
bsfilter plugin on Windows needs to change to installation
directory (startup_dir).
Andrej Kacian [Sat, 23 Jul 2016 19:40:02 +0000 (21:40 +0200)]
Updated plugins' claws.def files for win32 build.
Paul [Sat, 23 Jul 2016 14:20:20 +0000 (15:20 +0100)]
replace another: "pixel(s)" -> "pixels"
Paul [Sat, 23 Jul 2016 14:17:30 +0000 (15:17 +0100)]
another one (see last commit)
Paul [Sat, 23 Jul 2016 13:57:07 +0000 (14:57 +0100)]
standardise singlular/plural mix on labels
Ricardo Mones [Sat, 23 Jul 2016 11:09:49 +0000 (13:09 +0200)]
Use current style of preferences for time fields
Ricardo Mones [Sat, 23 Jul 2016 10:13:50 +0000 (12:13 +0200)]
Make label more readable
Ricardo Mones [Sat, 23 Jul 2016 01:00:00 +0000 (03:00 +0200)]
Update copyright headers for previous commit
Ricardo Mones [Sat, 23 Jul 2016 00:59:21 +0000 (02:59 +0200)]
Fix bug #2176: autochk_interval granularity is low
This also fixes Debian bug “Please increase mail auto check period.”
See: https://bugs.debian.org/712758
Former bug wanted sub-minute granularity and latter the opposite: just
check a few times a day, so this allows user to specify also hours and
seconds in addition to existing minutes to address both requests.
Checking range was from 1 minute to 1 hour 40 minutes and now is
extended to a range from 10 seconds to 100 hours minus one second.
Default for new configurations is preserved (10 minutes).
Configuration version is raised to 2 for migrating existing values
from minutes to seconds.
Andrej Kacian [Fri, 22 Jul 2016 18:46:54 +0000 (20:46 +0200)]
Remove last outside gtk_cmclist_freeze/thaw for summaryview&folderview ctrees.
More code maintenance to isolate summaryview and folderview
widgets' internals behind an API.
Paul [Fri, 22 Jul 2016 17:08:00 +0000 (18:08 +0100)]
remove unnecessary 'Encoding' frame
Paul [Fri, 22 Jul 2016 16:56:20 +0000 (17:56 +0100)]
Remove unneeded 'Other' from View/Go to/Other folder...
Ricardo Mones [Fri, 22 Jul 2016 12:14:37 +0000 (14:14 +0200)]
Reorganise send options a bit
Also remove '(Recommended)' from selector, as that's already
mentioned in the tooltip.
Andrej Kacian [Thu, 21 Jul 2016 20:32:37 +0000 (22:32 +0200)]
Further improve API isolation of folderview.
This commit gets rid of all outside access to "opened" and
"selected" struct members, and lot of outside access to
"ctree" member.
Additional work still needed. :)
Andrej Kacian [Thu, 21 Jul 2016 10:12:40 +0000 (12:12 +0200)]
Use folderview_grab_focus() outside of folderview.c.
Andrej Kacian [Thu, 21 Jul 2016 10:02:30 +0000 (12:02 +0200)]
Use folderview_freeze/thaw() functions outside of folderview.c.
These are modeled after summary_freeze/thaw().
Andrej Kacian [Thu, 21 Jul 2016 09:54:36 +0000 (11:54 +0200)]
Make exit_claws() use folderview API and not reach inside _FolderView struct.
Andrej Kacian [Wed, 20 Jul 2016 21:46:39 +0000 (23:46 +0200)]
Remove unused GtkWidget* argument in stock_pix* functions.
stock_pixmap_widget()
stock_pixmap_widget_with_overlay()
stock_pixbuf_gdk()
Ricardo Mones [Wed, 20 Jul 2016 17:01:33 +0000 (19:01 +0200)]
Restore also size of toolbar arrows
Thanks Paul for pointing those out!
Ricardo Mones [Wed, 20 Jul 2016 10:16:19 +0000 (12:16 +0200)]
Restore size of toolbar trash button
Default is 24x24 for toolbar buttons but this was unintentionally
shrinked more than a decade ago.
Ricardo Mones [Wed, 20 Jul 2016 07:13:59 +0000 (09:13 +0200)]
Fix warning about what directory cannot be open
Andrej Kacian [Tue, 19 Jul 2016 09:48:17 +0000 (11:48 +0200)]
Fix up previous commit.
Move the update_fonts check earlier, before the last_*font
pointers get modified.
Andrej Kacian [Tue, 19 Jul 2016 09:09:22 +0000 (11:09 +0200)]
Do not repopulate folderview after account prefs save.
The only reason to repopulate is if user's chosen fonts
change, and that cannot happen in account prefs.
Andrej Kacian [Mon, 18 Jul 2016 19:23:52 +0000 (21:23 +0200)]
Remove APOP and RPOP also from account prefs.
This fixes up previous commit,
358e811.
Andrej Kacian [Fri, 15 Jul 2016 09:56:22 +0000 (11:56 +0200)]
Remove obsolete A_APOP and A_RPOP account protocols.
CLAWS_CONFIG_VERSION bumped to 1.
Andrej Kacian [Thu, 14 Jul 2016 09:55:54 +0000 (11:55 +0200)]
Added config versioning.
This allows us to change meaning of existing preferences,
without losing or mangling user data. Controlled by a common
pref "config_version", which is checked on startup after
reading all configuration. If this version is lower than
what is defined in CLAWS_CONFIG_VERSION, an upgrade is done
incrementally, from one version to the next and to the next,
so that all affected preferences are adjusted.
Ricardo Mones [Thu, 14 Jul 2016 09:59:22 +0000 (11:59 +0200)]
Update lists of authors
Ricardo Mones [Thu, 14 Jul 2016 09:52:43 +0000 (11:52 +0200)]
Fix bug #3573: Out of bounds read in macro LBREAK_IF_REQUIRED
Thanks Hanno Boeck for the patch!
Andrej Kacian [Wed, 13 Jul 2016 19:50:52 +0000 (21:50 +0200)]
When generating a PGP keypair, only ask for passphrase with gpg1.
Also erase all copies of an entered passphrase from memory
when done. Closes bug #3658.
Andrej Kacian [Mon, 11 Jul 2016 22:13:21 +0000 (00:13 +0200)]
Simplify handling of gpg_ask_create_key pref.
Andrej Kacian [Mon, 11 Jul 2016 21:53:34 +0000 (23:53 +0200)]
Fix filesel dialog with filter for Win32.
g_utf8_to_utf16() always stops on first null byte,
so we have to construct the "filter\0filter\0\0"
string for GetOpenFileName() manually.
Andrej Kacian [Sun, 10 Jul 2016 12:57:16 +0000 (14:57 +0200)]
Added --batch option to manual gpg executable calls.
This, together with --no-tty, is to make these calls
really non-interactive, and helps against the calls
hanging on Windows occasionally.
Andrej Kacian [Sun, 10 Jul 2016 12:55:48 +0000 (14:55 +0200)]
Made exporting GPG key to keyserver work on Windows.
Andrej Kacian [Thu, 7 Jul 2016 16:24:41 +0000 (18:24 +0200)]
Updated claws.def file for win32 build of notification plugin.
Ricardo Mones [Tue, 5 Jul 2016 18:58:26 +0000 (20:58 +0200)]
Sync Spanish manual
Ricardo Mones [Tue, 5 Jul 2016 13:01:46 +0000 (15:01 +0200)]
Fix #3653: document plugin path configuration
Ricardo Mones [Mon, 4 Jul 2016 20:22:56 +0000 (22:22 +0200)]
Update Spanish manual
Ricardo Mones [Mon, 4 Jul 2016 16:45:48 +0000 (18:45 +0200)]
Add forgotten block delimiters
Thanks Paul for noticing!
Paul [Mon, 4 Jul 2016 14:58:06 +0000 (15:58 +0100)]
fix bug 2518, ' "Reply-All" message from NNTP-account does not contain CC'ed correspondents'
Paul [Mon, 4 Jul 2016 11:21:29 +0000 (12:21 +0100)]
include Reply-To value when using 'reply to all'
Paul [Mon, 4 Jul 2016 10:02:58 +0000 (11:02 +0100)]
make 'next_on_delete' hidden pref apply after trashing or moving a msg in addition to deleting a msg
fixes bug #3600.
document this hidden pref also
Ricardo Mones [Mon, 4 Jul 2016 09:00:35 +0000 (11:00 +0200)]
Warn on unsuccessful gpgme_set_engine_info calls
Paul [Mon, 4 Jul 2016 08:25:46 +0000 (09:25 +0100)]
modify
61f7c3c5e to catch another hardcoded gpg call
wwp [Sun, 3 Jul 2016 08:40:32 +0000 (10:40 +0200)]
notification plug-in: skip SMTP-only accounts when building the
'Get mail from account' menu.
Pawel Pekala [Sat, 2 Jul 2016 18:12:02 +0000 (20:12 +0200)]
Revert "Place dialogs on center of main window."
This reverts commit
cb67730a260a491ae380fd928d8ca673200972b0.
Pawel Pekala [Sat, 2 Jul 2016 16:05:14 +0000 (18:05 +0200)]
Place dialogs on center of main window. Most window managers place
these dialogs in some weird positions making interacting with
them unwieldy. Windows is biggest offender here putting things
around left top corner of the screen.
wwp [Thu, 30 Jun 2016 10:01:54 +0000 (12:01 +0200)]
Add 'Get mail from account..' to notification plugin's trayicon menu.
Charles Lehner [Mon, 27 Jun 2016 17:52:57 +0000 (13:52 -0400)]
Allocate quoted-printable output buffer on heap
Charles Lehner [Mon, 27 Jun 2016 14:28:41 +0000 (10:28 -0400)]
Handle ical lines longer than 256 bytes
Charles Lehner [Fri, 24 Jun 2016 22:42:05 +0000 (18:42 -0400)]
Indent html in blockquotes
Charles Lehner [Tue, 14 Jun 2016 16:52:54 +0000 (12:52 -0400)]
Line break after <dd>
Ricardo Mones [Thu, 16 Jun 2016 14:28:54 +0000 (16:28 +0200)]
Fix bug #3652 “warning: ordered comparison of pointer…”
Pawel Pekala [Thu, 9 Jun 2016 18:59:37 +0000 (20:59 +0200)]
Implement focused widget saving between iconify/deiconify events in
trayicon notification. Without this focus is lost on deiconify and this
can be painful to keyboard users. This is similar to my old work on
trayicon plugin I've done in the past.
Pawel Pekala [Wed, 8 Jun 2016 20:16:13 +0000 (22:16 +0200)]
Fix python plugin test for BSD family, dlopen(3) on those
systems is part of libc library and linking to nonexistent
libdl will fail.
Tested on FreeBSD 11-Current, Debian 8
Ricardo Mones [Tue, 7 Jun 2016 14:20:20 +0000 (16:20 +0200)]
Install new script also
Ricardo Mones [Tue, 7 Jun 2016 12:21:58 +0000 (14:21 +0200)]
And more documentation
Ricardo Mones [Tue, 7 Jun 2016 11:54:29 +0000 (13:54 +0200)]
Improve script documentation
Ricardo Mones [Tue, 7 Jun 2016 11:18:27 +0000 (13:18 +0200)]
Fix phrasing, terminology and typos
Ricardo Mones [Tue, 7 Jun 2016 10:59:43 +0000 (12:59 +0200)]
Add new action script for fixing threads
Many thanks to H.Merijn Brand for contributing it!
Ricardo Mones [Thu, 2 Jun 2016 09:17:49 +0000 (11:17 +0200)]
Use Unicode, don't restrict ourselves to ASCII
Charles Lehner [Thu, 2 Jun 2016 00:37:02 +0000 (20:37 -0400)]
Indicate list items in html
Andrej Kacian [Mon, 30 May 2016 10:26:17 +0000 (12:26 +0200)]
Fixed calculation of timing.h timer for Windows.
Andrej Kacian [Sat, 28 May 2016 17:54:51 +0000 (19:54 +0200)]
Fix --select CLI option on Windows when selecting a particular message.
Andrej Kacian [Tue, 24 May 2016 16:29:37 +0000 (18:29 +0200)]
Use PBKDF2 to derive encryption key for passwords.
...instead of my previous hash-then-xor nonsense.
Paul [Tue, 24 May 2016 13:20:52 +0000 (14:20 +0100)]
Andrej Kacian [Fri, 20 May 2016 09:38:32 +0000 (11:38 +0200)]
Moved getting random bytes into a separate get_random_bytes() function.
Andrej Kacian [Thu, 12 May 2016 08:03:39 +0000 (10:03 +0200)]
Remove imap_use_trash account preference.
Disabling this preference made deleting messages behave
incorrectly - they were marked for deletion regardless
of whether "delete" or "move to trash" was used, and
these actions were not executed immediately, regardless
of "immediate_execution" common preference.
Paul [Mon, 16 May 2016 16:02:53 +0000 (17:02 +0100)]
remove matcherrc.pre_names migration. 10 years later, we'll assume everyone has been migrated
Andrej Kacian [Fri, 6 May 2016 17:43:16 +0000 (19:43 +0200)]
Improve plural handling for "Delete message" dialog.
Ricardo Mones [Tue, 3 May 2016 10:50:21 +0000 (12:50 +0200)]
Fix typo in manual
Thanks Charles Curley for noticing
Andrej Kacian [Mon, 2 May 2016 19:29:12 +0000 (21:29 +0200)]
Made manual GPG key import work on Windows.
Andrej Kacian [Mon, 2 May 2016 18:54:19 +0000 (20:54 +0200)]
Ask GpgME for path to gpg executable for manual key import.
Ricardo Mones [Sun, 1 May 2016 14:56:18 +0000 (16:56 +0200)]
Fix frequently ocurring typos :)
Ricardo Mones [Sun, 1 May 2016 14:51:10 +0000 (16:51 +0200)]
Fix some typos in perl plugin's manpage
Andrej Kacian [Thu, 28 Apr 2016 10:01:10 +0000 (12:01 +0200)]
Fix behavior in selecting PGP MIME signature on Windows.
With old argument order, gpgme_op_verify() returned "empty signature"
error on Windows, for reasons unknown.
Andrej Kacian [Tue, 26 Apr 2016 08:21:22 +0000 (10:21 +0200)]
Use correct dir separator for "Scanning folder ..." in statusbar.
Andrej Kacian [Fri, 22 Apr 2016 18:04:02 +0000 (20:04 +0200)]
More fixes for the Windows native file choosers.
Filter string should be terminated with two nuls.
Save dialog did not show for message parts which have no
attachment name.
Andrej Kacian [Fri, 22 Apr 2016 11:31:41 +0000 (13:31 +0200)]
Disallow folder names ending with a space on Windows.
Closes bug #2781.
Andrej Kacian [Fri, 22 Apr 2016 08:05:57 +0000 (10:05 +0200)]
Make Windows native file/dir choosers work with non-ASCII characters.
Also, make the save chooser supply the correct attachment
file name by default, just like the GTK+ one does.
Ricardo Mones [Mon, 18 Apr 2016 15:23:52 +0000 (17:23 +0200)]
Fix closing tag placement
Thanks Paul for noticing ;-)
Ricardo Mones [Mon, 18 Apr 2016 12:55:16 +0000 (14:55 +0200)]
Fix semantic error
Thanks Andrej for the quick review!
Ricardo Mones [Mon, 18 Apr 2016 12:46:23 +0000 (14:46 +0200)]
Synchronize Spanish manual
Ricardo Mones [Mon, 18 Apr 2016 12:45:34 +0000 (14:45 +0200)]
Keep current order and add the default value
Andrej Kacian [Mon, 18 Apr 2016 12:15:34 +0000 (14:15 +0200)]
Document 'master_passphrase_pbkdf2_rounds' hidden preference.
Andrej Kacian [Sat, 16 Apr 2016 16:04:31 +0000 (18:04 +0200)]
Use native file and folder selection dialogs on Windows.
This is done by compiling in src/gtk/w32_filesel.c instead of
filesel.c on Windows. The Makefile.am logic mirrors the one from
src/common/.
Andrej Kacian [Mon, 11 Apr 2016 16:30:18 +0000 (18:30 +0200)]
Show duration of PBKDF2 computation in debug output.
Andrej Kacian [Sat, 9 Apr 2016 22:57:15 +0000 (00:57 +0200)]
Make double-click open edit dialog also for addressbook datasources.
For example, LDAP servers.
Andrej Kacian [Sat, 9 Apr 2016 16:06:26 +0000 (18:06 +0200)]
Prevent an unlikely crash during RSSyl feed properties save.
This is just to shut Coverity up, I don't think it could
ever crash this way.
Andrej Kacian [Sat, 9 Apr 2016 16:03:01 +0000 (18:03 +0200)]
Addressbook now uses password store for LDAP passwords.
Andrej Kacian [Sat, 9 Apr 2016 13:43:02 +0000 (15:43 +0200)]
Remove password from passwordstore when deleting a RSSyl feed.
Andrej Kacian [Sat, 9 Apr 2016 13:28:06 +0000 (15:28 +0200)]
Update passwordstore if RSSyl feed's URL gets changed.
Andrej Kacian [Sat, 9 Apr 2016 13:21:13 +0000 (15:21 +0200)]
Fix crash on deleting password from passwordstore.
Andrej Kacian [Sat, 9 Apr 2016 10:01:54 +0000 (12:01 +0200)]
Remove obsolete comment in RSSyl's OPML import.
Andrej Kacian [Sat, 9 Apr 2016 08:57:48 +0000 (10:57 +0200)]
Fix parsing logic in RSSyl OPML import.
Possibly closes bug #3623.
Andrej Kacian [Fri, 8 Apr 2016 12:50:45 +0000 (14:50 +0200)]
Close PRNG source after reading our PBKDF2 salt from it.
Andrej Kacian [Thu, 7 Apr 2016 12:56:48 +0000 (14:56 +0200)]
Use PBKDF2 with HMAC-SHA1 for master passphrase in clawsrc.
The 64 bytes long key derivation is stored in 'master_passphrase'
pref, together with number of rounds used in its computation.
Introducing also two new common prefs:
master_passphrase_salt - holds a randomly generated 64 bytes
for use as salt with PBKDF2. Base64-encoded.
master_passphrase_pbkdf2_rounds - number of rounds (or
iterations) for next passphrase key derivation
The latter can be tweaked by user in case they want to use more
or less rounds, e.g. if they're running on weaker hardware and
KD with default number of rounds takes too long.
Andrej Kacian [Thu, 7 Apr 2016 12:49:37 +0000 (14:49 +0200)]
Added PBKDF2 implementation, copied from OpenBSD.
Andrej Kacian [Wed, 6 Apr 2016 12:53:57 +0000 (14:53 +0200)]
Update plugins' claws.def filess for Windows build.
Andrej Kacian [Wed, 6 Apr 2016 12:53:37 +0000 (14:53 +0200)]
Remove unneeded plugin_master_passphrase_change().