claws.git
2 years agoMake the gtkut_tree_view_get_selected_pointer() more versatile.
Andrej Kacian [Tue, 27 Feb 2018 19:19:37 +0000 (20:19 +0100)]
Make the gtkut_tree_view_get_selected_pointer() more versatile.

It can now be used also for non-trivial use cases, where
the caller needs to further work with the model and/or
selection, or if a string value needs to be read from the
model.

2 years agoAdd gtkut_tree_view_get_selected_pointer() helper function.
Andrej Kacian [Sun, 25 Feb 2018 19:40:38 +0000 (20:40 +0100)]
Add gtkut_tree_view_get_selected_pointer() helper function.

It's meant for the simple cases when you just want to get
a pointer out of a treeview's selected row and you're not
going to do anything with the view, nor the model.

2 years agoFix summary_select_all when there is nothing selected.
Andrej Kacian [Mon, 26 Feb 2018 21:06:27 +0000 (22:06 +0100)]
Fix summary_select_all when there is nothing selected.

Due to how GtkCMCList works, we first need to focus and
select a row.
Fixes bug #3973, ''select all' in summaryview does not
automatically focus the summaryview'

2 years agoRevert "fix bug 3973, ''select all' in summaryview does not automatically focus the...
Andrej Kacian [Mon, 26 Feb 2018 21:06:02 +0000 (22:06 +0100)]
Revert "fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'"

This reverts commit a3e48bd6e7e62dedfef8ddedbeeb90400b5234b3.
That commit introduced slowness when selecting all rows.

2 years agoReplace GtkCMCList in browseldap.c with GtkTreeView.
Andrej Kacian [Sun, 25 Feb 2018 15:18:41 +0000 (16:18 +0100)]
Replace GtkCMCList in browseldap.c with GtkTreeView.

2 years agofix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'
Paul [Sun, 25 Feb 2018 13:18:40 +0000 (13:18 +0000)]
fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'

The problem is apparent when 'default selection on entering a folder' is
set to 'none' and the first user action on entering the folder is
'select all'. This visually selected all the messages but summaryview
did not have the focus, so any actions performed on that list would
fail.

Removed summary_select_all(), which didn't quite do as advertised and
instead use gtk_cmclist_select_all() which selects and focuses.

2 years agoMerge needless three gtk_tree_model_get() calls into one.
Andrej Kacian [Sat, 24 Feb 2018 22:35:26 +0000 (23:35 +0100)]
Merge needless three gtk_tree_model_get() calls into one.

2 years agoFix memory leaks from results of gtk_tree_model_get().
Andrej Kacian [Sat, 24 Feb 2018 22:27:35 +0000 (23:27 +0100)]
Fix memory leaks from results of gtk_tree_model_get().

G_TYPE_STRING values need to be freed, G_TYPE_PIXBUF
(or anything else derived from GObject) needs to be
unreferenced. This was forgotten in some places.

2 years agoUnreference GtkTreeModel pointers after they've been added to a tree view.
Andrej Kacian [Sat, 24 Feb 2018 21:30:51 +0000 (22:30 +0100)]
Unreference GtkTreeModel pointers after they've been added to a tree view.

This was forgotten in only a few cases.

2 years agoReplace GtkCMCList in editldap_basedn.c with GtkTreeView.
Andrej Kacian [Sat, 24 Feb 2018 21:14:25 +0000 (22:14 +0100)]
Replace GtkCMCList in editldap_basedn.c with GtkTreeView.

2 years agoReplace GtkCMCTree in addressadd.c with GtkTreeView.
Andrej Kacian [Sat, 24 Feb 2018 19:26:20 +0000 (20:26 +0100)]
Replace GtkCMCTree in addressadd.c with GtkTreeView.

2 years agoRSSyl: fix deleted item checking when modified or published time is missing
Andrej Kacian [Fri, 23 Feb 2018 21:27:35 +0000 (22:27 +0100)]
RSSyl: fix deleted item checking when modified or published time is missing

Fixes bug #3971.

2 years agoReplace GtkCMCList in pgpcore select-keys.c with GtkTreeView.
Andrej Kacian [Mon, 19 Feb 2018 22:22:11 +0000 (23:22 +0100)]
Replace GtkCMCList in pgpcore select-keys.c with GtkTreeView.

While we're at it, activating a row now finishes the
selection dialog without having to press the Select button.

2 years agoReplace GtkCMCList in LDIF import dialog with GtkTreeView.
Andrej Kacian [Sun, 18 Feb 2018 21:25:43 +0000 (22:25 +0100)]
Replace GtkCMCList in LDIF import dialog with GtkTreeView.

2 years agoReplace GtkCMCList in addrgather dialog with GtkTreeView.
Andrej Kacian [Sat, 17 Feb 2018 17:23:48 +0000 (18:23 +0100)]
Replace GtkCMCList in addrgather dialog with GtkTreeView.

2 years agoReplace GtkCMCList in folder sort dialog with GtkTreeView.
Andrej Kacian [Sat, 17 Feb 2018 16:49:08 +0000 (17:49 +0100)]
Replace GtkCMCList in folder sort dialog with GtkTreeView.

2 years agoUse color buttons' macro also here
Ricardo Mones [Fri, 16 Feb 2018 21:50:13 +0000 (22:50 +0100)]
Use color buttons' macro also here

2 years agoAdd support for the iso-8859-8-i encoding
Andrej Kacian [Wed, 14 Feb 2018 22:03:17 +0000 (23:03 +0100)]
Add support for the iso-8859-8-i encoding

Support this encoding by aliasing it to iso-8859-8.

2 years agoMake GtkCMCList/Tree use "text", not "fg" rc property for text color.
Andrej Kacian [Tue, 13 Feb 2018 22:50:15 +0000 (23:50 +0100)]
Make GtkCMCList/Tree use "text", not "fg" rc property for text color.

Closes bug #3880.

2 years agoCast to GSourceFunc instead of deprecated GtkFunction when using g_timeout_add().
Andrej Kacian [Fri, 9 Feb 2018 20:19:31 +0000 (21:19 +0100)]
Cast to GSourceFunc instead of deprecated GtkFunction when using g_timeout_add().

Also correct return type of fancy_show_mimepart_prepare()
callback function.

2 years agoUpdate few occurrences to the new alertpanel() API (and by the way,
wwp [Fri, 9 Feb 2018 21:36:41 +0000 (22:36 +0100)]
Update few occurrences to the new alertpanel() API (and by the way,
solve a leaking button_label strinc allocation).

2 years agoMigrate from deprecated GtkTooltips to GtkTooltip in clamd plugin.
Andrej Kacian [Fri, 9 Feb 2018 20:18:29 +0000 (21:18 +0100)]
Migrate from deprecated GtkTooltips to GtkTooltip in clamd plugin.

2 years agoFix few forgotten GDK_ to GDK_KEY_ renames in plugins.
Andrej Kacian [Fri, 9 Feb 2018 20:15:01 +0000 (21:15 +0100)]
Fix few forgotten GDK_ to GDK_KEY_ renames in plugins.

2 years agoForgotten changes in commit 09301b6e73e4af1b03b6f19d340dd909cf527bcc
Michael Rasmussen [Fri, 9 Feb 2018 19:46:54 +0000 (20:46 +0100)]
Forgotten changes in commit 09301b6e73e4af1b03b6f19d340dd909cf527bcc

Signed-off-by: Michael Rasmussen <mir@datanom.net>
2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Michael Rasmussen [Fri, 9 Feb 2018 19:40:26 +0000 (20:40 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

2 years agoDo not put enchant's CFLAGS into main CFLAGS make variable.
Andrej Kacian [Fri, 9 Feb 2018 19:21:41 +0000 (20:21 +0100)]
Do not put enchant's CFLAGS into main CFLAGS make variable.

Handle its CFLAGS just like all other libraries'.

2 years agoRework of alertpanel default button focus handling.
Andrej Kacian [Fri, 9 Feb 2018 13:44:30 +0000 (14:44 +0100)]
Rework of alertpanel default button focus handling.

Instead of using "+" prefix with button labels and/or
the default_value parameter, we introduce "focus"
parameter, which will point to first, second or third
button.

Advantages:
- we got rid of the "+" prefix, which won't work with GTK3
  with GTK3
- instead of having two ways to indicate which button
  should have focus, which can be in conflict, and
  are not very straightforward, there is just one,
  arguably more intuitive
- some small memory leaks fixed along the way
  (using g_strconcat() directly as function argument)

2 years agoFix ‘GtkWidget {aka struct _GtkWidget}’ has no member named ‘style’
Ricardo Mones [Thu, 8 Feb 2018 08:41:51 +0000 (09:41 +0100)]
Fix ‘GtkWidget {aka struct _GtkWidget}’ has no member named ‘style’

Thanks to Abhay S. Kushwaha for reporting!

2 years agoFix ‘GtkLabel {aka struct _GtkLabel}’ has no member named ‘label’
Ricardo Mones [Tue, 6 Feb 2018 23:45:42 +0000 (00:45 +0100)]
Fix ‘GtkLabel {aka struct _GtkLabel}’ has no member named ‘label’

2 years agoForce -DGTK_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE in GTK_CFLAGS.
Andrej Kacian [Tue, 6 Feb 2018 21:53:31 +0000 (22:53 +0100)]
Force -DGTK_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE in GTK_CFLAGS.

2 years agoRemove direct GTK struct member access from pdf_viewer plugin.
Andrej Kacian [Tue, 6 Feb 2018 21:45:18 +0000 (22:45 +0100)]
Remove direct GTK struct member access from pdf_viewer plugin.

2 years agoRemove the last offender against -DGTK_DISABLE_SINGLE_INCLUDES
Andrej Kacian [Tue, 6 Feb 2018 21:07:47 +0000 (22:07 +0100)]
Remove the last offender against -DGTK_DISABLE_SINGLE_INCLUDES

2 years agoGet rid of final direct GTK struct member access from ClawsSpellEntry.
Andrej Kacian [Tue, 6 Feb 2018 20:27:18 +0000 (21:27 +0100)]
Get rid of final direct GTK struct member access from ClawsSpellEntry.

We have to track preedit_length internally, because this
bit of GtkEntry is not available anymore.

2 years agoClawsSpellEntry does not need to implement GtkEditable
Andrej Kacian [Tue, 6 Feb 2018 20:05:25 +0000 (21:05 +0100)]
ClawsSpellEntry does not need to implement GtkEditable

We're "subclassing" GtkEntry, which already implements it.

2 years agoReplace gtk_style_unref()
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:32 +0000 (20:12 +0100)]
Replace gtk_style_unref()

gtk_style_unref() is a remnant from gtk+1 and the compatibility function
in gtk+2 is gone in gtk+3, use g_object_unref() instead.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoAdd missing header to acpi_notifier
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:31 +0000 (20:12 +0100)]
Add missing header to acpi_notifier

When building against gtk+3 the compiler complains about implicit
function declaration, so include the required header for using the
gtk_cmoption_menu.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoDrop no longer used gtk+2 utility functions
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:29 +0000 (20:12 +0100)]
Drop no longer used gtk+2 utility functions

With requiring gtk+2 >=2.24 the following functions are obsolete:
  gtkut_widget_set_mapped
  gtkut_widget_set_realized
  gtkut_widget_set_can_default
  gtkut_widget_set_receives_default
  gtkut_widget_set_can_focus
  gtkut_widget_set_has_window

Replace all occurrences with the underlying function.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoDrop ifdefs for old gtk+2
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:28 +0000 (20:12 +0100)]
Drop ifdefs for old gtk+2

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoRequire gtk+ >= 2.24
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:27 +0000 (20:12 +0100)]
Require gtk+ >= 2.24

gtk+-2.24.0 was released 2011-01-30 and has seen over 30 maintenance
releases since. Drop support for gtk+2 < 2.24 to ease porting to gtk+3
and to cleanup existing compatibility code for old gtk+2 releases.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoA few instances of combobox manipulation still used the old API.
Andrej Kacian [Tue, 6 Feb 2018 13:25:01 +0000 (14:25 +0100)]
A few instances of combobox manipulation still used the old API.

Patch by Ralph Sennhauser.

2 years agoRemoved almost all direct GTK struct member accesses.
Andrej Kacian [Tue, 6 Feb 2018 10:19:21 +0000 (11:19 +0100)]
Removed almost all direct GTK struct member accesses.

Use accessor functions instead.

The few remaining offenders are in spell_entry.c, which
will require some rework.

2 years agoReplaced some deprecated GTK+ API calls in gtkaspell.c.
Andrej Kacian [Mon, 5 Feb 2018 22:59:38 +0000 (23:59 +0100)]
Replaced some deprecated GTK+ API calls in gtkaspell.c.

2 years agoFix some copyright headers
Ricardo Mones [Mon, 5 Feb 2018 20:44:15 +0000 (21:44 +0100)]
Fix some copyright headers

2 years agoRefactor colors handling with more arrays
Ricardo Mones [Mon, 5 Feb 2018 20:15:42 +0000 (21:15 +0100)]
Refactor colors handling with more arrays

This also makes possible to add more colors easily.

2 years agoMove all colors into an array
Ricardo Mones [Mon, 5 Feb 2018 20:12:55 +0000 (21:12 +0100)]
Move all colors into an array

2 years agoRSSyl: Handle 404 and other fetch failures better.
Andrej Kacian [Wed, 31 Jan 2018 18:57:07 +0000 (19:57 +0100)]
RSSyl: Handle 404 and other fetch failures better.

2 years agoMove syntax help after entry
Ricardo Mones [Mon, 22 Jan 2018 23:24:36 +0000 (00:24 +0100)]
Move syntax help after entry

2 years agoRemove more unnecessary colons in labels
Ricardo Mones [Mon, 22 Jan 2018 22:45:20 +0000 (23:45 +0100)]
Remove more unnecessary colons in labels

2 years agoUse spacing more uniformly on themes prefs
Ricardo Mones [Mon, 22 Jan 2018 22:16:03 +0000 (23:16 +0100)]
Use spacing more uniformly on themes prefs

Also remove colons from labels (not used in other places), and align
them to the right, to be visually consistent with other preference
pages.

2 years agoFix wrong article in translated string
Ricardo Mones [Sun, 21 Jan 2018 09:34:52 +0000 (10:34 +0100)]
Fix wrong article in translated string

2 years agoDo not consider missing passwordstorerc file as error.
Andrej Kacian [Sat, 20 Jan 2018 13:36:38 +0000 (14:36 +0100)]
Do not consider missing passwordstorerc file as error.

Just continue with empty password store.

2 years agoPrune more gtk_widget_set_size_request calls
Ricardo Mones [Sat, 20 Jan 2018 13:10:39 +0000 (14:10 +0100)]
Prune more gtk_widget_set_size_request calls

2 years agoHandle password store config_version update without the global gint variable.
Andrej Kacian [Fri, 19 Jan 2018 18:16:44 +0000 (19:16 +0100)]
Handle password store config_version update without the global gint variable.

2 years agoHandle failed/aborted folderlist config_version update in main.c
Andrej Kacian [Fri, 19 Jan 2018 18:02:59 +0000 (19:02 +0100)]
Handle failed/aborted folderlist config_version update in main.c

2 years agoImplement config_version in folderlist.xml.
Andrej Kacian [Fri, 19 Jan 2018 17:56:52 +0000 (18:56 +0100)]
Implement config_version in folderlist.xml.

2 years agoNo need to set window's position twice
Ricardo Mones [Fri, 19 Jan 2018 11:53:26 +0000 (12:53 +0100)]
No need to set window's position twice

It's already set on line 200 :-)

2 years agoImplement config_version in passwordstorerc.
Andrej Kacian [Thu, 18 Jan 2018 20:53:18 +0000 (21:53 +0100)]
Implement config_version in passwordstorerc.

2 years agoDo not consider "mark_as_spam" as a final action, since it does not move the marked...
Andrej Kacian [Thu, 18 Jan 2018 20:13:46 +0000 (21:13 +0100)]
Do not consider "mark_as_spam" as a final action, since it does not move the marked message.

Fixes Bug 3919 - manual filtering does not move spam

2 years agofix bug where actionsrc was not updated after mailbox name change
Paul [Thu, 18 Jan 2018 11:05:18 +0000 (11:05 +0000)]
fix bug where actionsrc was not updated after mailbox name change

2 years agoAdd "Go to last error" to log window context menu
Ricardo Mones [Sun, 14 Jan 2018 15:26:44 +0000 (16:26 +0100)]
Add "Go to last error" to log window context menu

This functionality was already implemented, this only makes it
available to the user through a new menu option.

2 years agofix bug 3947, 'Build break with --disable-libsm --enable-crash-dialog'
Paul [Tue, 9 Jan 2018 12:33:05 +0000 (12:33 +0000)]
fix bug 3947, 'Build break with --disable-libsm --enable-crash-dialog'

2 years agoUse network log for LDAP operations output
Ricardo Mones [Sun, 7 Jan 2018 18:47:29 +0000 (19:47 +0100)]
Use network log for LDAP operations output

Also add some error checking and improve debug output

2 years agoFix typos and errors in polish translation
Pawel Pekala [Fri, 5 Jan 2018 21:05:41 +0000 (22:05 +0100)]
Fix typos and errors in polish translation

2 years agoFix some translated strings
Ricardo Mones [Thu, 28 Dec 2017 00:24:34 +0000 (01:24 +0100)]
Fix some translated strings

2 years agoa couple late translation update
Paul [Wed, 20 Dec 2017 16:28:14 +0000 (16:28 +0000)]
a couple late translation update

from David Vachulka and Mark Chang

2 years agoFix missing GError initialization in compose_draft().
Andrej Kacian [Wed, 20 Dec 2017 09:45:24 +0000 (10:45 +0100)]
Fix missing GError initialization in compose_draft().

2 years agoextend 'default selection when entering a folder'
Paul [Tue, 19 Dec 2017 11:40:33 +0000 (11:40 +0000)]
extend 'default selection when entering a folder'

Renamed 'first ...' to 'oldest ...', and added 'newest ...' in GUI

2 years agoFix Bug 3936: LDAP StartTLS does not work for addressbooks
Ricardo Mones [Mon, 18 Dec 2017 20:20:25 +0000 (21:20 +0100)]
Fix Bug 3936: LDAP StartTLS does not work for addressbooks

2 years agobump minimum glib requirement to 2.28
Paul [Mon, 18 Dec 2017 14:44:22 +0000 (14:44 +0000)]
bump minimum glib requirement to 2.28

2 years agoFix bug 3921: Follow-up to #3764. Cleanup gitignore
Ricardo Mones [Mon, 18 Dec 2017 11:02:14 +0000 (12:02 +0100)]
Fix bug 3921: Follow-up to #3764. Cleanup gitignore

Thanks Flo for the patch, but sed -i '/libical\/libical/d' .gitignore
was faster than applying the patch itself ;-)

2 years agofor release 3.16.0 3.16.0
Paul [Sun, 17 Dec 2017 11:45:31 +0000 (11:45 +0000)]
for release 3.16.0

2 years agoupdate translations
Paul [Sun, 17 Dec 2017 11:38:46 +0000 (11:38 +0000)]
update translations

updated by David Medina, Erik P. Olsen, Simon Legner, Tommi A Pirinen,
Páder Rezső, Luigi Votta, UTUMI Hirosi, Petter Adsen, Marcel Pol, Jakub
Jankiewicz, Frederico Goncalves Guimaraes, Mikhail Kurinnoi, Slavko,
Andreas Rönnquist.

new translation: Romanian by Cristian Secară

remove unmaintained Hebrew translation.

2 years agoUpdate list of TLDs for release
Ricardo Mones [Sun, 17 Dec 2017 02:33:58 +0000 (03:33 +0100)]
Update list of TLDs for release

2 years agoAdd proper ifdefs around master_passphrase() calls.
Andrej Kacian [Thu, 14 Dec 2017 22:24:20 +0000 (23:24 +0100)]
Add proper ifdefs around master_passphrase() calls.

2 years agoFix buffer length handling in GnuTLS password encryption and decryption.
Andrej Kacian [Thu, 14 Dec 2017 22:18:50 +0000 (23:18 +0100)]
Fix buffer length handling in GnuTLS password encryption and decryption.

Also zero out one forgotten copy of plaintext password
before freeing it. Oops!

2 years agoSpace preview icons equally
Ricardo Mones [Thu, 14 Dec 2017 12:39:23 +0000 (13:39 +0100)]
Space preview icons equally

2 years agoFix bug 3935: build from GIT master broken on arch linux
Ricardo Mones [Tue, 12 Dec 2017 17:27:23 +0000 (18:27 +0100)]
Fix bug 3935: build from GIT master broken on arch linux

Completes 48f72c22f91fbe0d6e872e89bd4dce9d39090e81 to allow building
with disabled LDAP support.

2 years agoUpdate lists of authors
Ricardo Mones [Tue, 12 Dec 2017 12:30:55 +0000 (13:30 +0100)]
Update lists of authors

2 years agoUpdate Spanish translation
Ricardo Mones [Tue, 12 Dec 2017 12:06:36 +0000 (13:06 +0100)]
Update Spanish translation

2 years agoUpdate French translation.
wwp [Mon, 11 Dec 2017 10:36:04 +0000 (11:36 +0100)]
Update French translation.

2 years agoFix bug 3931: segfault searching server with master password
Andrej Kacian [Sun, 10 Dec 2017 09:49:02 +0000 (10:49 +0100)]
Fix bug 3931: segfault searching server with master password

Request master passphrase earlier and inhibit search if no master
passphrase is available.

2 years agoFix bug 3793: segfault when autocompletion asks for master passphrase
Andrej Kacian [Sun, 10 Dec 2017 09:49:01 +0000 (10:49 +0100)]
Fix bug 3793: segfault when autocompletion asks for master passphrase

This is done by checking early if any ldap server is password-protected,
and asking for master passphrase when compose window appears.  If user
cancels the dialog (does not enter the passphrase), we temporarily
disable the password-protected LDAP servers, just for that particular
compose window. We reenable them in compose_destroy().

2 years agoAdd public call to get master password
Andrej Kacian [Sun, 10 Dec 2017 09:49:00 +0000 (10:49 +0100)]
Add public call to get master password

2 years agoPrune gtk_widget_set_size_request calls
Ricardo Mones [Sun, 10 Dec 2017 01:52:51 +0000 (02:52 +0100)]
Prune gtk_widget_set_size_request calls

2 years agoCopyright year update in plugins' version.rc files.
Andrej Kacian [Sat, 9 Dec 2017 16:05:59 +0000 (17:05 +0100)]
Copyright year update in plugins' version.rc files.

2 years agoSome FileDescription fixes in plugins' version.rc files.
Andrej Kacian [Sat, 9 Dec 2017 16:05:36 +0000 (17:05 +0100)]
Some FileDescription fixes in plugins' version.rc files.

Thanks to Woody for noticing.

2 years agoColor buttons proportional to font size
Ricardo Mones [Tue, 5 Dec 2017 00:27:06 +0000 (01:27 +0100)]
Color buttons proportional to font size

Instead of hardcoding a size which doesn't look the same on different
resolutions, use a space;m-space;space label and let GTK+ to compute
the appropriate button size for current font.

2 years agoAdjust spelling preferences widgets
Ricardo Mones [Sun, 26 Nov 2017 20:35:50 +0000 (21:35 +0100)]
Adjust spelling preferences widgets

2 years agoRemove list of bugs which are not outstanding
Ricardo Mones [Tue, 5 Dec 2017 21:51:57 +0000 (22:51 +0100)]
Remove list of bugs which are not outstanding

2 years agoSet flags of all selected messages before updating view
Olaf Hering [Wed, 22 Nov 2017 17:03:15 +0000 (18:03 +0100)]
Set flags of all selected messages before updating view

If a collapsed, unread thread is marked as 'ignore thread' the first
message remains bold in the message list. That happens because
summary_ignore_thread_func calls summary_set_row_marks, which finds
unread children. As a result bold_style is selected.

To fix this it is required to first update the message flags of all
selected messages, before updating the view of all selected messages.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
2 years agoRemove stale MSG_IS_RETRCPT_PENDING
Olaf Hering [Wed, 22 Nov 2017 17:03:14 +0000 (18:03 +0100)]
Remove stale MSG_IS_RETRCPT_PENDING

The bitflag MSG_RETRCPT_PENDING is not defined, the existing flags do not
indicate a typo. Remove this stale macro to avoid confusion.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
2 years agoComplete previous patch
Ricardo Mones [Sat, 2 Dec 2017 22:44:34 +0000 (23:44 +0100)]
Complete previous patch

2 years agoMake column selector UI like open actions
Ricardo Mones [Sat, 2 Dec 2017 20:12:39 +0000 (21:12 +0100)]
Make column selector UI like open actions

Set remove button to center column and add border to lists

2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Michael Rasmussen [Mon, 27 Nov 2017 21:51:59 +0000 (22:51 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

2 years agoFix bug #3924: Unbreak sieve host configuration on FreeBSD
Michael Gmelin [Sun, 26 Nov 2017 20:09:22 +0000 (21:09 +0100)]
Fix bug #3924: Unbreak sieve host configuration on FreeBSD

Also, adds extra check for config->host

2 years agoFix truncated input widgets in preferences window
Olaf Hering [Wed, 22 Nov 2017 17:03:16 +0000 (18:03 +0100)]
Fix truncated input widgets in preferences window

With larger UI fontsize some input fields are truncated, the numbers can
not be read properly. Remove the hardcoded width values, let GTK pick a
value.

2 years agoUse statusbar progress meter when opening/refreshing a NNTP folder.
Andrej Kacian [Fri, 24 Nov 2017 23:42:34 +0000 (00:42 +0100)]
Use statusbar progress meter when opening/refreshing a NNTP folder.

2 years agoReenable filtering log on Windows, as it is no longer crashy.
Andrej Kacian [Wed, 22 Nov 2017 23:31:26 +0000 (00:31 +0100)]
Reenable filtering log on Windows, as it is no longer crashy.

It was previously disabled in 83eaf78e3.

2 years agoMove pointer usage after pointer check
Olaf Hering [Wed, 22 Nov 2017 17:03:19 +0000 (18:03 +0100)]
Move pointer usage after pointer check

In procmime_decode_content mimeinfo is dereferenced before cm_return_val_if_fail().

2 years agoRssyl: fix Windows build
Abhay S. Kushwaha [Thu, 23 Nov 2017 12:37:55 +0000 (18:07 +0530)]
Rssyl: fix Windows build