Andrej Kacian [Sat, 17 Sep 2016 21:46:21 +0000 (23:46 +0200)]
Remove an unused, mistyped ifdef in imap.c.
Ricardo Mones [Fri, 16 Sep 2016 17:54:10 +0000 (19:54 +0200)]
Remove useless workaround
The problem is still happening with it, see bug #3511
Ricardo Mones [Wed, 14 Sep 2016 18:30:49 +0000 (20:30 +0200)]
Remove (obsolete) FSF address from welcome mail
Andrej Kacian [Wed, 14 Sep 2016 07:55:28 +0000 (09:55 +0200)]
Removed unused macro from prefs.c.
Andrej Kacian [Tue, 13 Sep 2016 09:53:17 +0000 (11:53 +0200)]
Yet more vcalendar varargs functions fixed for issue described in
d20742e.
Andrej Kacian [Tue, 13 Sep 2016 09:45:22 +0000 (11:45 +0200)]
More fixes for vcalendar crash on 64-bit arch.
Same issue as in commit
d20742e, different place.
This should be the last one, though.
Ricardo Mones [Mon, 12 Sep 2016 22:15:37 +0000 (00:15 +0200)]
Fix another two strangely sized buttons
Ricardo Mones [Mon, 12 Sep 2016 15:23:18 +0000 (17:23 +0200)]
Fix potential segfault
Syslog message was:
[
5473572.496127] claws-mail[24080]: segfault at 22 ip
00000000005704ce sp
00007ffdf1dfcea0 error 4 in
claws-mail[400000+34a000]
$ addr2line -e /…/claws-mail
00000000005704ce
/…/src/textview.c:837
More details on: http://stackoverflow.com/questions/
2179403
Ricardo Mones [Mon, 12 Sep 2016 10:22:49 +0000 (12:22 +0200)]
Adjust to our toolbar button size of 24x24
Andrej Kacian [Sun, 11 Sep 2016 08:15:41 +0000 (10:15 +0200)]
Fix an impossible crash to shut Coverity up.
Andrej Kacian [Sat, 10 Sep 2016 18:19:16 +0000 (20:19 +0200)]
Fix a memory leak in rssyl_update_comments().
Andrej Kacian [Sat, 10 Sep 2016 10:43:12 +0000 (12:43 +0200)]
Do not ignore CFLAGS environment variable in configure.
Andrej Kacian [Sat, 10 Sep 2016 07:28:04 +0000 (09:28 +0200)]
A fix for commit
b274c72.
Whatever FeedItem's ->data is pointing to is being
freed in feed_item_free() already.
Andrej Kacian [Fri, 9 Sep 2016 23:32:47 +0000 (01:32 +0200)]
Fix a memory leak when setting summaryview and folderview fonts.
Andrej Kacian [Fri, 9 Sep 2016 23:09:13 +0000 (01:09 +0200)]
Fixed two memory leaks when creating folderitems.
The Folderitem's "node" member is set to a new empty
GNode in folder_item_new(), but is later set to
another newly allocated GNode.
This commit removes the extra allocation in one case
(folder_new()), and gets rid of the original GNode
in another case, where avoiding the second allocation
is impossible without completely rewriting the recursive
folderitem appending in folder_get_from_xml().
Andrej Kacian [Fri, 9 Sep 2016 22:07:01 +0000 (00:07 +0200)]
Fix memory leak when freeing RSSyl's FeedItem struct.
Andrej Kacian [Fri, 9 Sep 2016 21:43:51 +0000 (23:43 +0200)]
Fix memory leak in password store reading.
Andrej Kacian [Fri, 9 Sep 2016 21:11:52 +0000 (23:11 +0200)]
Fix a memory leak in folder_register_class().
Ricardo Mones [Fri, 9 Sep 2016 19:27:35 +0000 (21:27 +0200)]
Fix potential out-of-bounds read
Ricardo Mones [Wed, 7 Sep 2016 12:08:55 +0000 (14:08 +0200)]
Do not reuse pixmaps for theme icons
Otherwise theme authors may have a hard time finding why an
icon is not themed despite having provided replacements for
all existing xpm files.
Ricardo Mones [Mon, 5 Sep 2016 22:53:24 +0000 (00:53 +0200)]
Remove another unused pixmap
Ricardo Mones [Mon, 5 Sep 2016 07:27:11 +0000 (09:27 +0200)]
Remove unused pixmap
Not used in theme and it wasn't a Claws Mail icon but other
ancient thingy… :)
Ricardo Mones [Mon, 5 Sep 2016 07:21:40 +0000 (09:21 +0200)]
Normalise theme icon names which were different
Ricardo Mones [Fri, 2 Sep 2016 23:20:17 +0000 (01:20 +0200)]
Remove unused declaration
Ricardo Mones [Fri, 2 Sep 2016 23:18:56 +0000 (01:18 +0200)]
Add warning icon to warning message
Refactor warning creation code into a single function.
Andrej Kacian [Fri, 2 Sep 2016 09:22:50 +0000 (11:22 +0200)]
Be more strict about minimum DH prime size for TLS connections.
Since GnuTLS 3.1.7, this minimum size is dictated by the
priority string, and current (GnuTLS 3.3.0) "safe-enough"
value is 1008 bits. We set this minimum size explicitly
for older GnuTLS versions.
Users who are affected by this (their servers use DH prime
smaller than 1008 bits can override this by using priority
string starting with the keyword "LEGACY". This keyword
only works with GnuTLS 3.3.0 or newer, however.
Paul [Fri, 2 Sep 2016 07:21:42 +0000 (08:21 +0100)]
fix `make dist`
wwp [Thu, 1 Sep 2016 22:40:27 +0000 (00:40 +0200)]
Templates: add a way to attach a file, 'attach_output' or 'A', file whose absolute path+filename
is the output of a command-line (it s a mix of 'attach' and 'program'). The first line of the
command-line output is taken into account, trailing newline being stripped down.
Like 'attach', if the filename is not found or not accessible, CM will raise an error. Like
'program', if the command-line fails, no error raises but the standard output of CM shows it.
Ricardo Mones [Thu, 1 Sep 2016 17:40:31 +0000 (19:40 +0200)]
Fix bug #2918: Notification Popup icon is hardcoded
Also fixes last part of bug #3437 by removing the call to deprecated
function gdk_pixbuf_new_from_inline and not using a raw pixmap.
Ricardo Mones [Thu, 1 Sep 2016 17:39:46 +0000 (19:39 +0200)]
Add 64x64 icon version to stock pixmaps
Icon data purloined from last patch of #3437 by Christian Hesse.
Ricardo Mones [Thu, 1 Sep 2016 10:20:02 +0000 (12:20 +0200)]
Forgot to adjust default window size
Ricardo Mones [Wed, 31 Aug 2016 18:48:13 +0000 (20:48 +0200)]
Improve icon legend appearance a bit
Remove extra space and replace scrolled window with a frame.
Colin Leroy [Wed, 31 Aug 2016 15:11:24 +0000 (17:11 +0200)]
Fix a few Coverity issues
Colin Leroy [Wed, 31 Aug 2016 14:47:50 +0000 (16:47 +0200)]
Remove useless code
Colin Leroy [Wed, 31 Aug 2016 14:44:40 +0000 (16:44 +0200)]
Remove useless code
Paul [Wed, 31 Aug 2016 11:37:03 +0000 (12:37 +0100)]
use file name for WebCal subscription folder name
also remove the string length limit, which broke saving folder
properties
Ricardo Mones [Wed, 31 Aug 2016 11:17:25 +0000 (13:17 +0200)]
Better alignment for icon legend columns
Reverts most of
c0abccd31d42122216e3d25341394cd85d949d9b.
Paul [Tue, 30 Aug 2016 15:07:05 +0000 (16:07 +0100)]
fix `make dist`
Paul [Tue, 30 Aug 2016 14:54:25 +0000 (15:54 +0100)]
place icons in 2 columns
Paul [Tue, 30 Aug 2016 11:37:11 +0000 (12:37 +0100)]
remove icons that will never be displayed
Paul [Tue, 30 Aug 2016 10:54:42 +0000 (11:54 +0100)]
fix capitalisation
Paul [Tue, 30 Aug 2016 10:26:45 +0000 (11:26 +0100)]
add 'noselect' and 'subs-only' folder icons
Paul [Tue, 30 Aug 2016 10:22:12 +0000 (11:22 +0100)]
fix non-resizeable Icon Legend dialogue
Paul [Tue, 30 Aug 2016 10:01:59 +0000 (11:01 +0100)]
implement the 4-state icons for 'noselect' folders
Andrej Kacian [Tue, 30 Aug 2016 08:03:06 +0000 (10:03 +0200)]
Fix NULL pointer dereference in LDAP lookup code.
Fixes bug #3027.
Andrej Kacian [Sun, 28 Aug 2016 20:42:10 +0000 (22:42 +0200)]
Fix crash on Windows when doing a LDAP search.
Andrej Kacian [Sun, 28 Aug 2016 18:11:03 +0000 (20:11 +0200)]
Make filesel API more consistent.
One of the functions, filesel_select_multiple_files_open(),
was missing the path parameter.
Andrej Kacian [Sat, 27 Aug 2016 18:41:08 +0000 (20:41 +0200)]
Refactor gtk/w32_filesel.c for better code reuse.
Andrej Kacian [Sat, 27 Aug 2016 17:51:14 +0000 (19:51 +0200)]
Allow multiple file selection in Windows native file chooser.
Paul [Sat, 27 Aug 2016 07:49:19 +0000 (08:49 +0100)]
indicate IMAP mailboxes which show subs only with a green folder
Paul [Fri, 26 Aug 2016 13:55:44 +0000 (14:55 +0100)]
Add OpenBSD CA cert path.
From Edd Barrett via Daniel Jakots
Paul [Fri, 26 Aug 2016 07:51:10 +0000 (08:51 +0100)]
maintain alphabetical ordering
Paul [Fri, 26 Aug 2016 07:39:41 +0000 (08:39 +0100)]
update location of addrbook sub-folder in address conversion scripts
Ricardo Mones [Thu, 25 Aug 2016 10:27:01 +0000 (12:27 +0200)]
Synchronize Spanish manual
Andrej Kacian [Thu, 25 Aug 2016 08:46:34 +0000 (10:46 +0200)]
Always set GnuTLS priority string.
Closes bug #3680.
Andrej Kacian [Wed, 24 Aug 2016 11:52:23 +0000 (13:52 +0200)]
Handle password loading more safely in prefs_account.c
Inspired by patch in bug #3678.
Andrej Kacian [Wed, 24 Aug 2016 11:39:33 +0000 (13:39 +0200)]
Do a basic check for widget validity in CLAWS_SET_TIP().
Inspired by patch in bug #3678.
Ricardo Mones [Wed, 24 Aug 2016 10:14:28 +0000 (12:14 +0200)]
Fix bug #3515: Ctrl-Shift-X opens multiple external editors
This a known GTK+ bug (passing keypresses of disabled menus) or
a mising feature (not providing a way to disable also keypresses).
See https://bugzilla.gnome.org/show_bug.cgi?id=656158
Andrej Kacian [Tue, 23 Aug 2016 22:08:40 +0000 (00:08 +0200)]
Fix crash in vcalendar passwords handling on prefs save.
Andrej Kacian [Tue, 23 Aug 2016 15:55:38 +0000 (17:55 +0200)]
Fix previous commit
b88c772, use correct preprocessor directive.
Andrej Kacian [Tue, 23 Aug 2016 15:47:24 +0000 (17:47 +0200)]
Do not explicitly disable SSLv3 if GnuTLS does it already.
Starting with GnuTLS 3.4.0, SSL 3.0 is no longer
included in the default priorities list.
Ricardo Mones [Mon, 22 Aug 2016 17:07:36 +0000 (19:07 +0200)]
Document the new hidden preference 'hide_timezone'
Ricardo Mones [Mon, 22 Aug 2016 17:02:47 +0000 (19:02 +0200)]
Fix bug #2975: Implement setting -0000 timezone to hide sender localtime
This adds a new hidden preference, namely 'hide_timezone', that
sets the timezone of date fields sent over the network to the
unknown timezone value as specified in RFC 5322 §3.3.
Default value is false (i.e., send available timezone information).
Andrej Kacian [Sun, 21 Aug 2016 20:59:42 +0000 (22:59 +0200)]
Deduplicate string for plugins' block prefix in clawsrc.
Andrej Kacian [Sun, 21 Aug 2016 19:36:12 +0000 (21:36 +0200)]
Fix NULL pointer dereference in Atom parser.
Closes bug #3676.
Andrej Kacian [Sun, 21 Aug 2016 14:58:22 +0000 (16:58 +0200)]
Fix crash when an Atom feed's opening tag doesn't have xmlns attribute.
Closes bug #3675.
Andrej Kacian [Fri, 19 Aug 2016 16:50:53 +0000 (18:50 +0200)]
More fixes for parsing dates in vcalendar on Windows.
...this time without all the i18n updates.
Andrej Kacian [Fri, 19 Aug 2016 16:48:33 +0000 (18:48 +0200)]
Revert "More fixes for parsing dates in vcalendar on Windows."
This reverts commit
dc7438b9a2eb1e6f55bf1780310ddcc06160baa2.
Oops, I did it again...
Andrej Kacian [Fri, 19 Aug 2016 13:38:02 +0000 (15:38 +0200)]
More fixes for parsing dates in vcalendar on Windows.
Andrej Kacian [Thu, 18 Aug 2016 23:44:39 +0000 (01:44 +0200)]
More support for pre-Epoch dates for Windows.
get_rfc822_date_from_time_t() (vcalendar)
procheader_date_parse() (core)
Andrej Kacian [Thu, 18 Aug 2016 21:40:16 +0000 (23:40 +0200)]
Removed fork() prototype from w32lib.h.
fork() is builtin in mingw.
Andrej Kacian [Thu, 18 Aug 2016 18:39:30 +0000 (20:39 +0200)]
Set correct LDFLAGS for OS X.
Commit also simplifies LDFLAGS for Windows,
moving them from src/Makefile.am to configure.ac.
Closes bug #3665.
Andrej Kacian [Thu, 18 Aug 2016 14:11:41 +0000 (16:11 +0200)]
Avoid usage of deprecated bcopy/bzero in pbkdf2 routine.
Andrej Kacian [Thu, 18 Aug 2016 13:54:16 +0000 (15:54 +0200)]
Few miscellaneous fixes for RSSyl.
Mostly for compiler warnings on win64.
Andrej Kacian [Thu, 18 Aug 2016 13:07:40 +0000 (15:07 +0200)]
Use GDateTime instead of mktime() in vcalendar's libical.
On several places, libical relies on mktime()'s undefined
behavior for dates before the Epoch - on Linux, it returns
minus number of seconds *until* epoch for such dates.
On Windows, mktime() returns -1, which leads to code around
it crashing, since there are almost no error checks in libical.
We circumvent this by doing the needed conversions via glib's
GDateTime instead where needed.
Ricardo Mones [Wed, 17 Aug 2016 07:57:39 +0000 (09:57 +0200)]
Fix regression: show simple text/calendar with plugin
Handling the base case where the MIME part being looked up
is directly passed as function parameter was missing.
Andrej Kacian [Tue, 16 Aug 2016 22:32:12 +0000 (00:32 +0200)]
Fix a crash on IMAP login when using a password plugin.
Fixes bug #3667.
Andrej Kacian [Mon, 15 Aug 2016 11:32:41 +0000 (13:32 +0200)]
Fix potential crash in vcalendar's icalcomponent_vanew() on 64-bit archs.
We need to pass the terminating zero cast to void*,
because size of void* is 8 bytes, while size of a
literal 0 just 4 bytes. The arguments are retrieved
as void*, so without this void* cast, we're taking
four extra bytes belonging to whatever data is
stored in memory directly after our four-byte zero.
Paul [Thu, 11 Aug 2016 11:33:44 +0000 (12:33 +0100)]
add missing semi-colon
spotted and patched by Ralf Bormann <ralf.bormann@cs.uni-dortmund.de>
Paul [Thu, 11 Aug 2016 06:47:35 +0000 (07:47 +0100)]
update ru.po
submitted by Mikhail Kurinnoi
Ricardo Mones [Wed, 10 Aug 2016 23:27:55 +0000 (01:27 +0200)]
Fix bug #3666: Typos in Turkish translation
X-Patch-Thanks-To: rypervenche <sub@ryper.org>
Andrej Kacian [Tue, 9 Aug 2016 21:38:32 +0000 (23:38 +0200)]
Fix a potential bug in vcalendar's libical.
Some compilers seem to understand this construction as an empty
for() cycle, followed by an unrelated block enclosed in braces.
We make sure the compiler does what we want by putting the
opening brace at the same line as for().
Ricardo Mones [Sun, 7 Aug 2016 19:09:19 +0000 (21:09 +0200)]
Fix typo
Paul [Sun, 7 Aug 2016 11:06:55 +0000 (12:06 +0100)]
List the current Catalan translator rather than the previous one.
Apologies, David!
Paul [Sun, 7 Aug 2016 08:06:41 +0000 (09:06 +0100)]
for 3.14.0 release
Paul [Sun, 7 Aug 2016 08:05:16 +0000 (09:05 +0100)]
update/add/disable translations
Updated:
[ca] Carles Tubio Terrón <c@rles-tub.io>
[cs] David Vachulka <david@konstrukce-
cad.com>
[de] Thomas Bellmann <ThomasBellmann@gmx.net>
[fi] Flammie Pirinen <flammie@iki.fi>
[fr] Tristan Chabredier <wwp@claws-mail.org>
[hu] Pader Rezso <rezso@rezso.net>
[it] Luigi Votta <luigi.vtt@gmail.com>
[nb] Petter Adsen <petter@synth.no>
[nl] Marcel Pol <mpol@gmx.net>
[pt_BR] Frederico Goncalves Guimaraes
<frederico@teia.bio.br>
[ru] Mikhail Kurinnoi <viewizard@viewizard.com>
[sk] Slavko <slavino@slavino.sk>
[sv] Andreas Rönnquist <gusnan@openmailbox.org>
[tr] Numan Demirdö?en <if.gnu.linux@gmail.com>
[zh_TW] Mark Chang <mark.cyj@gmail.com>
Added:
[da] Erik P. Olsen <epodata@gmail.com>
[id_ID] MSulchan Darmawan <bleketux@gmail.com>
Unmaintained:
[lt] Mindaugas Baranauskas <embar@super.lt>
Ricardo Mones [Sat, 6 Aug 2016 23:32:17 +0000 (01:32 +0200)]
Update list of TLDs for release
Ricardo Mones [Sat, 6 Aug 2016 23:30:16 +0000 (01:30 +0200)]
Update Spanish translation for release
Andrej Kacian [Sat, 6 Aug 2016 19:33:13 +0000 (21:33 +0200)]
Fix filesel_select_file_open_folder() for Win32.
The starting folder needs to be set via the dialog callback
function, as passing it as pidlRoot merely "chroots" us in
the starting folder, so the dialog can't see anything above it.
Paul [Fri, 5 Aug 2016 18:23:42 +0000 (19:23 +0100)]
add Turkish translation to claws-mail.desktop
Ricardo Mones [Fri, 5 Aug 2016 15:54:32 +0000 (17:54 +0200)]
Add passwords file to manpage
Paul [Mon, 1 Aug 2016 20:39:15 +0000 (21:39 +0100)]
fix typo
Andrej Kacian [Mon, 1 Aug 2016 19:07:59 +0000 (21:07 +0200)]
Removed SessionMsgType enum and its use, since it is useless.
The only user was session_send_msg(), which did nothing
with its SessionMsgType parameter.
Andrej Kacian [Mon, 1 Aug 2016 15:56:16 +0000 (17:56 +0200)]
Set correct config_version after first-run wizard finishes.
Patch by Christian Hesse <mail at eworm de>.
Andrej Kacian [Mon, 1 Aug 2016 07:13:47 +0000 (09:13 +0200)]
Added recently added source files to POTFILES.in.
Andrej Kacian [Sun, 31 Jul 2016 12:02:15 +0000 (14:02 +0200)]
Remove an obsolete comment in password.c.
Ricardo Mones [Fri, 29 Jul 2016 18:21:05 +0000 (20:21 +0200)]
Remove more line breaks from g_warning()
Ricardo Mones [Thu, 28 Jul 2016 22:59:11 +0000 (00:59 +0200)]
Fix some debug messages and update headers
Andrej Kacian [Thu, 28 Jul 2016 20:57:23 +0000 (22:57 +0200)]
Only enable "New Book" context menu entry for internal addressbook.
It was confusing to have it active on e.g. LDAP server interface,
when it really only adds a new XML addressbook.
Also, do not enable the "New" button when right-clicking the XML
addressbook interface line, as the button doesn't do anything
useful for interfaces.
Andrej Kacian [Thu, 28 Jul 2016 20:54:31 +0000 (22:54 +0200)]
Fix sensitivity of "Delete book" menu entries in addressbook.
Now it's possible to delete a read-only address datasource
via popup menu.