Paul [Fri, 9 Nov 2018 11:09:06 +0000 (11:09 +0000)]
rework Display/Summaries
spilt the page into 3 notebook pages.
rearrange some options.
add some options for new folder defaults
Paul [Thu, 8 Nov 2018 19:39:24 +0000 (19:39 +0000)]
modify label text
Paul [Thu, 8 Nov 2018 18:42:43 +0000 (18:42 +0000)]
fix check for mail at start-up
Paul [Wed, 7 Nov 2018 11:46:34 +0000 (11:46 +0000)]
remove all gtk3 conditionals
Paul [Wed, 7 Nov 2018 11:07:17 +0000 (11:07 +0000)]
remove --enable-gtk3 configure flag
Paul [Wed, 7 Nov 2018 10:33:06 +0000 (10:33 +0000)]
drop redundant md5 fingerprint; more clearly indicate expired sigs
Paul [Wed, 7 Nov 2018 10:04:37 +0000 (10:04 +0000)]
implement RFE 3810, 'SSL certificate manager: add Signature Status and Expiration'
Add Status and Expiry columns to certificate list, use bold text to
indicate expired certs and failed signatures, and also append
' (expired)' to status where appropriate.
Thanks to Andrej for optimisation in
ssl_manager_list_view_insert_cert().
Paul [Tue, 6 Nov 2018 06:15:38 +0000 (06:15 +0000)]
fix bug 4114, 'autogen.sh: Fix argument quoting'
patch by Berhard <rep.dot.nop@gmail.com>
Paul [Tue, 6 Nov 2018 06:14:37 +0000 (06:14 +0000)]
fix bug 4115 'autogen: avoid unwarranted re-configure'
patch by Bernhard <rep.dot.nop@gmail.com>
Andrej Kacian [Mon, 5 Nov 2018 23:05:17 +0000 (00:05 +0100)]
Make sure all users of GtkCMCList do not blindly assume that a button-press-event happens inside of the tree view.
If clicking on the header row, the event's x,y coordinates
were pointing to a different spot than what the event handler
code expected, since those coordinates are relative to the
relevant GDK window, and header row has its own. Calls to
gtk_cmclist_get_selection_info() or gtk_sctree_is_hot_spot()
in such cases therefore returned bogus info.
This fixes things like folderview expanding/collapsing
selected folder when double-clicking its header column, or
selecting first row when single-clicking it.
Andrej Kacian [Mon, 5 Nov 2018 19:33:07 +0000 (20:33 +0100)]
Use same integer type for color folder item prefs like everyone else.
Andrej Kacian [Mon, 5 Nov 2018 19:31:53 +0000 (20:31 +0100)]
Save folder color as P_COLOR in folderitemrc.
The code to handle backward compatibility (color as int)
is already there.
Andrej Kacian [Mon, 5 Nov 2018 10:49:21 +0000 (11:49 +0100)]
Add config_version to folder item prefs.
Also some minor code comment and debug output tweaks.
User Corn [Thu, 1 Nov 2018 23:18:48 +0000 (00:18 +0100)]
Fix build on FreeBSD, sys/wait.h is needed for WEXITSTATUS macro
Paul [Mon, 29 Oct 2018 17:31:51 +0000 (17:31 +0000)]
fix annoyance where your current reading is disturbed when a new msg is filtered into the current folder
Paul [Mon, 29 Oct 2018 09:03:04 +0000 (09:03 +0000)]
fix for smtp-only accounts when global pref for save sent msg is set
Paul [Mon, 29 Oct 2018 09:01:16 +0000 (09:01 +0000)]
revert g45500aa, it breaks stuff
Andrej Kacian [Sun, 28 Oct 2018 20:58:31 +0000 (21:58 +0100)]
Handle compose "Save Message to" checkbox state in compose_set_save_to() only.
Fixes bug #4107 - Sent messages do not appear in "Sent" folder...
Paul [Fri, 26 Oct 2018 12:38:19 +0000 (13:38 +0100)]
only show warning about privacy system 'none' on replies to signed or encrypted msgs
Paul [Thu, 25 Oct 2018 16:09:16 +0000 (17:09 +0100)]
add error checking on account prefs Advanced page
Paul [Thu, 25 Oct 2018 16:08:21 +0000 (17:08 +0100)]
always use folder pref for save msg location if set
Paul [Thu, 25 Oct 2018 16:07:19 +0000 (17:07 +0100)]
allow account pref and folder pref to override global pref for saving sent msgs
Paul [Thu, 25 Oct 2018 09:56:44 +0000 (10:56 +0100)]
less haste
Paul [Thu, 25 Oct 2018 09:55:30 +0000 (10:55 +0100)]
Paul [Thu, 25 Oct 2018 09:36:54 +0000 (10:36 +0100)]
don't leave the user in limbo when privacy system is 'none' and auto signing/encrypting is set
Andrej Kacian [Wed, 24 Oct 2018 15:23:14 +0000 (17:23 +0200)]
Pack account prefs' checkbtn_crosspost into correct hbox, rather than leaving it unused.
Andrej Kacian [Wed, 24 Oct 2018 15:20:10 +0000 (17:20 +0200)]
Do not use gtk_cmctree_set_line_style(), since it does nothing.
Andrej Kacian [Tue, 23 Oct 2018 18:51:06 +0000 (20:51 +0200)]
Removed deprecated g_type_class_add_private() call in ClawsSpellEntry.
Andrej Kacian [Tue, 23 Oct 2018 18:46:32 +0000 (20:46 +0200)]
Use GTK private struct feature correctly in ClawsSpellEntry.
g_type_class_add_private() takes care of adding,
initializing and cleaning it up, there is no need
to add another copy of it and manage it manually.
Andrej Kacian [Tue, 23 Oct 2018 18:30:49 +0000 (20:30 +0200)]
Removed deprecated g_type_class_add_private() call in GtkSHRuler.
Andrej Kacian [Fri, 19 Oct 2018 21:36:40 +0000 (23:36 +0200)]
Rework debug output in passwd_store_set() to be less confusing.
Andrej Kacian [Fri, 19 Oct 2018 21:22:20 +0000 (23:22 +0200)]
When deleting an account, delete its password store block, instead of just NULLing the block's entries hash table.
Ricardo Mones [Fri, 19 Oct 2018 11:58:11 +0000 (13:58 +0200)]
Fix translation for octet-stream view
Colin Leroy [Thu, 18 Oct 2018 12:13:58 +0000 (14:13 +0200)]
Rewrap fr manual for lisibility
Colin Leroy [Wed, 17 Oct 2018 07:26:26 +0000 (09:26 +0200)]
Fix crash in dangling message search.
Andrej Kacian [Tue, 16 Oct 2018 16:18:40 +0000 (18:18 +0200)]
Do not redraw focus of GtkCMCList if the row is unchanged in move_focus_row();
Andrej Kacian [Tue, 16 Oct 2018 16:16:02 +0000 (18:16 +0200)]
In summary_key_pressed(), do not try to reopen the same message if cursor does not change.
Andrej Kacian [Tue, 16 Oct 2018 16:12:05 +0000 (18:12 +0200)]
Fix an off-by-one error in summary_key_pressed().
Paul [Tue, 16 Oct 2018 09:10:03 +0000 (10:10 +0100)]
fix bug (rfe) 4102, 'Show SHA-256 fingerprint in certificate verification popup'
Paul [Tue, 16 Oct 2018 06:38:19 +0000 (07:38 +0100)]
fix invalid cast runtime warning
Colin Leroy [Mon, 15 Oct 2018 19:15:05 +0000 (21:15 +0200)]
PDF Viewer: handle Ctrl+scroll for zooming
Colin Leroy [Mon, 15 Oct 2018 08:39:21 +0000 (10:39 +0200)]
Fancy: fix left-click on links not opening in browser.
Colin Leroy [Thu, 11 Oct 2018 14:06:39 +0000 (16:06 +0200)]
Make the "Saving sent message..." debug prints more interesting.
Colin Leroy [Wed, 10 Oct 2018 12:34:34 +0000 (14:34 +0200)]
Revert all memory-based tmpfile I/O, it comes with too much drawbacks
(like having to know the filesize before writing to it)
Colin Leroy [Wed, 10 Oct 2018 08:37:23 +0000 (10:37 +0200)]
Fix wording, thanks wwp
Colin Leroy [Wed, 10 Oct 2018 08:22:09 +0000 (10:22 +0200)]
str_open_as_stream() doesn't need a real file either.
Colin Leroy [Wed, 10 Oct 2018 08:09:11 +0000 (10:09 +0200)]
Comment the my_tmpfile_with_len() function.
Colin Leroy [Wed, 10 Oct 2018 07:59:10 +0000 (09:59 +0200)]
Fix in-memory temporary file length
Ricardo Mones [Mon, 8 Oct 2018 13:51:15 +0000 (15:51 +0200)]
Update textviewer.pl
Patch by H.Merijn Brand
Ricardo Mones [Mon, 8 Oct 2018 13:49:29 +0000 (15:49 +0200)]
Update thread tools
Patch by H.Merijn Brand
Andrej Kacian [Mon, 8 Oct 2018 11:31:31 +0000 (13:31 +0200)]
...and one more forgotten NULL check.
Andrej Kacian [Mon, 8 Oct 2018 11:29:21 +0000 (13:29 +0200)]
Added some NULL checks in passwordstore.c to avoid potential crash.
Andrej Kacian [Mon, 8 Oct 2018 08:34:08 +0000 (10:34 +0200)]
Fix unit tests building, broken after the file-utils addition.
Andrej Kacian [Mon, 8 Oct 2018 08:33:26 +0000 (10:33 +0200)]
Fix file-utils related compiler warnings in crash.c.
Colin Leroy [Sun, 7 Oct 2018 19:31:37 +0000 (21:31 +0200)]
Fix hang on IMAP - the log file is accessed by multiple threads
Colin Leroy [Sun, 7 Oct 2018 18:41:20 +0000 (20:41 +0200)]
Make safe_fclose static now that it can be
Colin Leroy [Sun, 7 Oct 2018 18:26:50 +0000 (20:26 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Andrej Kacian [Sun, 7 Oct 2018 17:16:15 +0000 (19:16 +0200)]
Improve debug output in passwd_store_set().
Colin Leroy [Sun, 7 Oct 2018 13:40:38 +0000 (15:40 +0200)]
Fix performance loss on certain file I/O that doesn't need
to be safe
Colin Leroy [Sun, 7 Oct 2018 13:32:38 +0000 (15:32 +0200)]
Add a memory-backed my_tmpfile() implementation.
Colin Leroy [Sun, 7 Oct 2018 12:46:02 +0000 (14:46 +0200)]
Rename claws_io to file-utils, and move file-related functions
from utils.c to file-utils.c
Colin Leroy [Sun, 7 Oct 2018 12:16:04 +0000 (14:16 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 12:12:29 +0000 (14:12 +0200)]
Wrap file I/O to claws_* to benefit from custom locking when
available. Gains about 33% on I/O bound tasks.
Ricardo Mones [Sun, 7 Oct 2018 11:27:30 +0000 (13:27 +0200)]
Fix CID
1439996 and remove unnecessary comparison
Colin Leroy [Sun, 7 Oct 2018 09:11:29 +0000 (11:11 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 09:11:06 +0000 (11:11 +0200)]
Hey I'm married :)
Ricardo Mones [Sat, 6 Oct 2018 14:38:23 +0000 (16:38 +0200)]
Don't ignore required file
Ricardo Mones [Sat, 6 Oct 2018 12:32:30 +0000 (14:32 +0200)]
Clean more rubbish
Colin Leroy [Sat, 6 Oct 2018 11:33:07 +0000 (13:33 +0200)]
Remove old files that shouldn't be there
Colin Leroy [Sat, 6 Oct 2018 11:04:16 +0000 (13:04 +0200)]
Fix indent, sorry.
Colin Leroy [Sat, 6 Oct 2018 11:00:00 +0000 (13:00 +0200)]
Fix build
Colin Leroy [Sat, 6 Oct 2018 10:48:01 +0000 (12:48 +0200)]
Use a memory-based FILE pointer when we can; speeds up search.
Colin Leroy [Sat, 6 Oct 2018 10:46:48 +0000 (12:46 +0200)]
Don't bother parsing headers when we want to skip them
Speeds up body-only search
Colin Leroy [Sat, 6 Oct 2018 10:43:31 +0000 (12:43 +0200)]
Fix big leak on mimeinfo freeing
Colin Leroy [Sat, 6 Oct 2018 09:26:53 +0000 (11:26 +0200)]
Halve the time spent manipulating case in case-insensitive searches
Colin Leroy [Fri, 5 Oct 2018 21:01:46 +0000 (23:01 +0200)]
Implement safe_fclose() so we can respect the "Metadata handling"
preference for every data file we write into.
Andrej Kacian [Thu, 4 Oct 2018 18:25:53 +0000 (20:25 +0200)]
Do not use trim_string() in RSSyl's rename folder dialog.
Ricardo Mones [Thu, 4 Oct 2018 13:49:07 +0000 (15:49 +0200)]
Simplify comparison
and keep Coverity happy.
Ricardo Mones [Thu, 4 Oct 2018 08:49:32 +0000 (10:49 +0200)]
Disallow zero-length entity
Ricardo Mones [Thu, 4 Oct 2018 08:30:12 +0000 (10:30 +0200)]
Fix CID
1439871 and validate Unicode char strictly
Andrej Kacian [Wed, 3 Oct 2018 16:27:39 +0000 (18:27 +0200)]
Make entity_decode() handle invalid input better.
Colin Leroy [Wed, 3 Oct 2018 07:15:30 +0000 (09:15 +0200)]
Fix Reply from mainwindow menu and toolbar when mainwindow's
messageview is hidden.
Colin Leroy [Tue, 2 Oct 2018 14:34:17 +0000 (16:34 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Colin Leroy [Tue, 2 Oct 2018 14:27:41 +0000 (16:27 +0200)]
Colin Leroy [Tue, 2 Oct 2018 14:27:27 +0000 (16:27 +0200)]
Fix build warning
Colin Leroy [Tue, 2 Oct 2018 14:21:16 +0000 (16:21 +0200)]
Colin Leroy [Tue, 2 Oct 2018 14:16:57 +0000 (16:16 +0200)]
Andrej Kacian [Tue, 2 Oct 2018 12:18:52 +0000 (14:18 +0200)]
Remove Webkit version check ifdefs, since we depend on a new enough version.
Ricardo Mones [Mon, 1 Oct 2018 21:58:24 +0000 (23:58 +0200)]
Don't try to be too clever and remove superuser_p()
Being root doesn't really tell much about filesystem permissions. Now it
simply ask user what to do and does it as requested. If things go wrong
errors will be catched anyway.
Colin Leroy [Fri, 28 Sep 2018 14:55:24 +0000 (16:55 +0200)]
Fix possible resource leak
Colin Leroy [Fri, 28 Sep 2018 13:26:59 +0000 (15:26 +0200)]
Fix implicit declaration of g_close()
Colin Leroy [Fri, 28 Sep 2018 12:17:24 +0000 (14:17 +0200)]
Add a few ignores
Colin Leroy [Fri, 28 Sep 2018 12:17:11 +0000 (14:17 +0200)]
Fix build on Debian 7
Colin Leroy [Fri, 28 Sep 2018 11:20:26 +0000 (13:20 +0200)]
Fix Coverity warning (unsafe fscanf)
Colin Leroy [Fri, 28 Sep 2018 08:33:20 +0000 (10:33 +0200)]
Fix bug #3889, "Address and quoted message inconsistent in reply"
* Fix right-click replying to messages in summaryview
* Fix corner-case when selected and opened messages are different,
and one of them is to a mailing-list.
Colin Leroy [Fri, 28 Sep 2018 08:29:27 +0000 (10:29 +0200)]
Fix possible null-dereference (thanks Coverity)
Colin Leroy [Thu, 27 Sep 2018 06:55:10 +0000 (08:55 +0200)]
Fix Quicksearch eating keypresses it didn't handle.
Andrej Kacian [Sun, 23 Sep 2018 14:44:45 +0000 (16:44 +0200)]
Add a NULL check in summary_select_by_msg_list when selecting tree nodes.
This fixes an assertion failure when executing an action
which moves selected messages to a different folder. We
obviously cannot select previously selected messages if
they're not in current folder anymore.
wwp [Thu, 20 Sep 2018 20:16:33 +0000 (22:16 +0200)]
Quicksearch: expand extended symbols on "Edit", patch by Olivier Brunel.
Paul [Thu, 20 Sep 2018 09:00:47 +0000 (10:00 +0100)]
Fix protocol part of some more URLs