Colin Leroy [Sun, 7 Oct 2018 18:41:20 +0000 (20:41 +0200)]
Make safe_fclose static now that it can be
Colin Leroy [Sun, 7 Oct 2018 18:26:50 +0000 (20:26 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Andrej Kacian [Sun, 7 Oct 2018 17:16:15 +0000 (19:16 +0200)]
Improve debug output in passwd_store_set().
Colin Leroy [Sun, 7 Oct 2018 13:40:38 +0000 (15:40 +0200)]
Fix performance loss on certain file I/O that doesn't need
to be safe
Colin Leroy [Sun, 7 Oct 2018 13:32:38 +0000 (15:32 +0200)]
Add a memory-backed my_tmpfile() implementation.
Colin Leroy [Sun, 7 Oct 2018 12:46:02 +0000 (14:46 +0200)]
Rename claws_io to file-utils, and move file-related functions
from utils.c to file-utils.c
Colin Leroy [Sun, 7 Oct 2018 12:16:04 +0000 (14:16 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 12:12:29 +0000 (14:12 +0200)]
Wrap file I/O to claws_* to benefit from custom locking when
available. Gains about 33% on I/O bound tasks.
Ricardo Mones [Sun, 7 Oct 2018 11:27:30 +0000 (13:27 +0200)]
Fix CID
1439996 and remove unnecessary comparison
Colin Leroy [Sun, 7 Oct 2018 09:11:29 +0000 (11:11 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 09:11:06 +0000 (11:11 +0200)]
Hey I'm married :)
Ricardo Mones [Sat, 6 Oct 2018 14:38:23 +0000 (16:38 +0200)]
Don't ignore required file
Ricardo Mones [Sat, 6 Oct 2018 12:32:30 +0000 (14:32 +0200)]
Clean more rubbish
Colin Leroy [Sat, 6 Oct 2018 11:33:07 +0000 (13:33 +0200)]
Remove old files that shouldn't be there
Colin Leroy [Sat, 6 Oct 2018 11:04:16 +0000 (13:04 +0200)]
Fix indent, sorry.
Colin Leroy [Sat, 6 Oct 2018 11:00:00 +0000 (13:00 +0200)]
Fix build
Colin Leroy [Sat, 6 Oct 2018 10:48:01 +0000 (12:48 +0200)]
Use a memory-based FILE pointer when we can; speeds up search.
Colin Leroy [Sat, 6 Oct 2018 10:46:48 +0000 (12:46 +0200)]
Don't bother parsing headers when we want to skip them
Speeds up body-only search
Colin Leroy [Sat, 6 Oct 2018 10:43:31 +0000 (12:43 +0200)]
Fix big leak on mimeinfo freeing
Colin Leroy [Sat, 6 Oct 2018 09:26:53 +0000 (11:26 +0200)]
Halve the time spent manipulating case in case-insensitive searches
Colin Leroy [Fri, 5 Oct 2018 21:01:46 +0000 (23:01 +0200)]
Implement safe_fclose() so we can respect the "Metadata handling"
preference for every data file we write into.
Andrej Kacian [Thu, 4 Oct 2018 18:25:53 +0000 (20:25 +0200)]
Do not use trim_string() in RSSyl's rename folder dialog.
Ricardo Mones [Thu, 4 Oct 2018 13:49:07 +0000 (15:49 +0200)]
Simplify comparison
and keep Coverity happy.
Ricardo Mones [Thu, 4 Oct 2018 08:49:32 +0000 (10:49 +0200)]
Disallow zero-length entity
Ricardo Mones [Thu, 4 Oct 2018 08:30:12 +0000 (10:30 +0200)]
Fix CID
1439871 and validate Unicode char strictly
Andrej Kacian [Wed, 3 Oct 2018 16:27:39 +0000 (18:27 +0200)]
Make entity_decode() handle invalid input better.
Colin Leroy [Wed, 3 Oct 2018 07:15:30 +0000 (09:15 +0200)]
Fix Reply from mainwindow menu and toolbar when mainwindow's
messageview is hidden.
Colin Leroy [Tue, 2 Oct 2018 14:34:17 +0000 (16:34 +0200)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Colin Leroy [Tue, 2 Oct 2018 14:27:41 +0000 (16:27 +0200)]
Colin Leroy [Tue, 2 Oct 2018 14:27:27 +0000 (16:27 +0200)]
Fix build warning
Colin Leroy [Tue, 2 Oct 2018 14:21:16 +0000 (16:21 +0200)]
Colin Leroy [Tue, 2 Oct 2018 14:16:57 +0000 (16:16 +0200)]
Andrej Kacian [Tue, 2 Oct 2018 12:18:52 +0000 (14:18 +0200)]
Remove Webkit version check ifdefs, since we depend on a new enough version.
Ricardo Mones [Mon, 1 Oct 2018 21:58:24 +0000 (23:58 +0200)]
Don't try to be too clever and remove superuser_p()
Being root doesn't really tell much about filesystem permissions. Now it
simply ask user what to do and does it as requested. If things go wrong
errors will be catched anyway.
Colin Leroy [Fri, 28 Sep 2018 14:55:24 +0000 (16:55 +0200)]
Fix possible resource leak
Colin Leroy [Fri, 28 Sep 2018 13:26:59 +0000 (15:26 +0200)]
Fix implicit declaration of g_close()
Colin Leroy [Fri, 28 Sep 2018 12:17:24 +0000 (14:17 +0200)]
Add a few ignores
Colin Leroy [Fri, 28 Sep 2018 12:17:11 +0000 (14:17 +0200)]
Fix build on Debian 7
Colin Leroy [Fri, 28 Sep 2018 11:20:26 +0000 (13:20 +0200)]
Fix Coverity warning (unsafe fscanf)
Colin Leroy [Fri, 28 Sep 2018 08:33:20 +0000 (10:33 +0200)]
Fix bug #3889, "Address and quoted message inconsistent in reply"
* Fix right-click replying to messages in summaryview
* Fix corner-case when selected and opened messages are different,
and one of them is to a mailing-list.
Colin Leroy [Fri, 28 Sep 2018 08:29:27 +0000 (10:29 +0200)]
Fix possible null-dereference (thanks Coverity)
Colin Leroy [Thu, 27 Sep 2018 06:55:10 +0000 (08:55 +0200)]
Fix Quicksearch eating keypresses it didn't handle.
Andrej Kacian [Sun, 23 Sep 2018 14:44:45 +0000 (16:44 +0200)]
Add a NULL check in summary_select_by_msg_list when selecting tree nodes.
This fixes an assertion failure when executing an action
which moves selected messages to a different folder. We
obviously cannot select previously selected messages if
they're not in current folder anymore.
wwp [Thu, 20 Sep 2018 20:16:33 +0000 (22:16 +0200)]
Quicksearch: expand extended symbols on "Edit", patch by Olivier Brunel.
Paul [Thu, 20 Sep 2018 09:00:47 +0000 (10:00 +0100)]
Fix protocol part of some more URLs
Ricardo Mones [Wed, 19 Sep 2018 22:53:52 +0000 (00:53 +0200)]
Fix protocol part of some URLs
Andrej Kacian [Tue, 18 Sep 2018 17:29:12 +0000 (19:29 +0200)]
Set missing pubdate/moddate in RSSyl items to the other one, if available.
Andrej Kacian [Tue, 18 Sep 2018 17:28:28 +0000 (19:28 +0200)]
The pubDate timestamp in RSS2.0 sets date_published.
Ricardo Mones [Wed, 12 Sep 2018 14:59:24 +0000 (16:59 +0200)]
Remove dead code
Andrej Kacian [Tue, 11 Sep 2018 15:48:57 +0000 (17:48 +0200)]
Remove unused macro G_STRING_APPEND_ENCODED_URI.
Paul [Mon, 10 Sep 2018 12:30:05 +0000 (13:30 +0100)]
fix warning dialogue when a re-edited draft compose window is closed after a send failure
prevents unexpected loss of drafted message
Andrej Kacian [Fri, 7 Sep 2018 20:19:43 +0000 (22:19 +0200)]
Restore the hovering-over-link callback in Fancy viewer.
We still need it to display the hovered-over link in statusbar.
wwp [Fri, 7 Sep 2018 06:05:22 +0000 (08:05 +0200)]
Add new folder options: enable/disable per-folder signing and
encrypting (by default: obey to applicable account preference).
Andrej Kacian [Thu, 6 Sep 2018 21:31:16 +0000 (23:31 +0200)]
Fix dangling pointer in proxy password handling.
Initialize proxy_info.proxy_pass to NULL, and reset it
back to NULL after use.
Andrej Kacian [Thu, 6 Sep 2018 21:13:41 +0000 (23:13 +0200)]
Show correct address:port in SOCKS5 proxy connection failure message.
The address and port contained in the server response
are what the proxy server has bound locally for the
connection, not the destination address and port.
Andrej Kacian [Thu, 6 Sep 2018 20:11:05 +0000 (22:11 +0200)]
Handle corrupted decrypted passwords gracefully.
Check whether the decrypted password is a valid UTF-8
string, and return an empty string if not, instead of
returning garbage, probably not NULL-terminated data,
and causing problems down the road.
Andrej Kacian [Thu, 6 Sep 2018 16:43:35 +0000 (18:43 +0200)]
Avoid an unnecessary string copy in xml_attr_new_int().
wwp [Thu, 6 Sep 2018 14:21:15 +0000 (16:21 +0200)]
Rename activate_privacy_system() to compose_activate_privacy_system().
Andrej Kacian [Wed, 5 Sep 2018 16:35:47 +0000 (18:35 +0200)]
Bump up minimum required webkitgtk version to 1.10.0.
That's when WebKitWebView's "context-menu" signal was
added, we start using it in
288d3a708.
Andrej Kacian [Wed, 5 Sep 2018 15:32:17 +0000 (17:32 +0200)]
Fix links not being opened in browser when Fancy menu is opened with a keyboard.
Andrej Kacian [Tue, 4 Sep 2018 22:17:59 +0000 (00:17 +0200)]
Remove unused string copy from procmsg_msg_exist().
wwp [Mon, 3 Sep 2018 10:17:12 +0000 (12:17 +0200)]
Fix capitalization of a one Web[cC]al occurrence.
Ricardo Mones [Fri, 31 Aug 2018 18:36:54 +0000 (20:36 +0200)]
Fix bug #3418 ‘Building on a Cross Compiling toolchain doesn't work’
The bug is really fixed in commit
8eee2fd5ddb9d24d8f58bf88afdea8ca67daaea5
This only adds a slight modification of the remaining portion of the
patch checking the macro itself, from the original attached to the bug
by ridai.govinda@gmail.com.
Andrej Kacian [Fri, 31 Aug 2018 12:39:41 +0000 (14:39 +0200)]
Updated INSTALL file.
Updated required GTK+ version, and removed the outdated
list of configure options. The existing reference to --help
should suffice there.
Andrej Kacian [Fri, 31 Aug 2018 11:48:30 +0000 (13:48 +0200)]
Added unit test framework, and some initial unit tests.
Andrej Kacian [Fri, 31 Aug 2018 11:43:59 +0000 (13:43 +0200)]
md5.c doesn't need to include entire utils.h.
Andrej Kacian [Fri, 31 Aug 2018 11:39:04 +0000 (13:39 +0200)]
Moved codeconv.[ch] and unmime.[ch] to common/ subdir.
That's where they belong. This also clears up a few ugly
cases of other files in common including "../codeconv.h".
Andrej Kacian [Fri, 31 Aug 2018 11:29:48 +0000 (13:29 +0200)]
Decouple codeconv.c from prefs_common.
Andrej Kacian [Fri, 31 Aug 2018 11:28:16 +0000 (13:28 +0200)]
Add parameter sanity checks to md5_hex_digest() and md5_hex_hmac().
Olivier Brunel [Wed, 27 Dec 2017 20:59:40 +0000 (21:59 +0100)]
Preserve flags & tags when re-editing a message
When re-editing a message, let's preserve its flags (color labels, etc)
and tags. Can be especially useful for those who use such things on queued
messages, and find themselves re-editing messages afterwards but before
actually sending them.
Olivier Brunel [Wed, 27 Dec 2017 20:53:17 +0000 (21:53 +0100)]
action: Keep selection set afterwards
Upon running (filtering) actions, the current selection was lost (due to
refreshing the current folder); Let's restore it.
Olivier Brunel [Wed, 2 Aug 2017 18:48:58 +0000 (20:48 +0200)]
Speed-up searches in References via "x"
Since commit
5c9f9e47 (in 2001!) the header "References" is actually
cached in MsgInfo, so searching it can be substantially faster if "x"
expands to 'references' instead of 'header "References"', much like with
'i' (messageid) or 'I' (inreplyto).
wwp [Thu, 30 Aug 2018 06:29:30 +0000 (08:29 +0200)]
Fix wrong logics leading to writing possibly broken config file,
patch by Olivier Brunel.
Ricardo Mones [Tue, 28 Aug 2018 10:54:43 +0000 (12:54 +0200)]
Restore Fancy entry in README, still in tarball ;)
Thanks Woody for noticing.
Paul [Mon, 27 Aug 2018 17:42:44 +0000 (18:42 +0100)]
fix lintian autotools-pkg-config-macro-not-cross-compilation-safe warning
see
https://lintian.debian.org/tags/autotools-pkg-config-macro-not-cross-compilation-safe.html
Ricardo Mones [Mon, 27 Aug 2018 16:43:08 +0000 (18:43 +0200)]
Update plugins in README
wwp [Sun, 26 Aug 2018 16:01:02 +0000 (18:01 +0200)]
Fix wrong test leading to dead code (and dead func), CID
1438531.
Paul [Sun, 26 Aug 2018 13:36:51 +0000 (14:36 +0100)]
always show the full version on the mainwindow regardless of --enable-maintainer-mode
Paul [Sun, 26 Aug 2018 11:21:52 +0000 (12:21 +0100)]
for release 3.17.1
Andrej Kacian [Sat, 25 Aug 2018 09:00:56 +0000 (11:00 +0200)]
Update vcalendar's claws.def file for Windows build after recent changes.
Thanks to Abhay S. Kushwaha.
Andrej Kacian [Sat, 25 Aug 2018 08:58:49 +0000 (10:58 +0200)]
Improve Left Arrow keypress handling for childless folders in folderview.
Based on patch by Abhay S. Kushwaha.
wwp [Fri, 24 Aug 2018 12:59:13 +0000 (14:59 +0200)]
Optimize (for speed) and factorize code related to marking folders
as read/unread recursively. A bit of code format fixing too.
Andrej Kacian [Fri, 24 Aug 2018 12:38:52 +0000 (14:38 +0200)]
Fix building manual PDF and PS formats when building outside of source dir.
Andrej Kacian [Fri, 24 Aug 2018 12:09:12 +0000 (14:09 +0200)]
Fix various plugins including generated .h files when building outside of source dir.
Andrej Kacian [Fri, 24 Aug 2018 11:48:38 +0000 (13:48 +0200)]
Fix configure version detection when building outside of srcdir.
Colin Leroy [Fri, 24 Aug 2018 11:51:32 +0000 (13:51 +0200)]
Better GUI (with calendar) for date filtering condition.
Colin Leroy [Fri, 24 Aug 2018 09:07:06 +0000 (11:07 +0200)]
Move time selector from vCalendar to gtkutils
Colin Leroy [Fri, 24 Aug 2018 08:17:27 +0000 (10:17 +0200)]
Filtering: simple GUI for date_after/before
Colin Leroy [Fri, 24 Aug 2018 07:58:09 +0000 (09:58 +0200)]
Filtering: add date_before and date_after
Colin Leroy [Thu, 23 Aug 2018 08:51:52 +0000 (10:51 +0200)]
Only handle GTK events when matcher test thread takes more than 0 seconds.
Andrej Kacian [Wed, 22 Aug 2018 13:00:58 +0000 (15:00 +0200)]
Add null pointer checks to pkcs5_pbkdf2().
Andrej Kacian [Tue, 21 Aug 2018 17:52:33 +0000 (19:52 +0200)]
Added null parameter checks in codeconv.c where appropriate.
Andrej Kacian [Tue, 21 Aug 2018 09:53:16 +0000 (11:53 +0200)]
Move the typedef for "u32" from utils.h to md5.h, since it is only used there.
Andrej Kacian [Tue, 21 Aug 2018 09:49:15 +0000 (11:49 +0200)]
Removed an unused #include from libfeed's parser.c.
wwp [Tue, 21 Aug 2018 08:21:11 +0000 (10:21 +0200)]
Fix missing check for a retrieving interval minimum value in
accounts prefs, don't use abbreviated units there and follow
the global prefs style.
wwp [Tue, 21 Aug 2018 08:20:05 +0000 (10:20 +0200)]
Fix wrong time unit shown in offline-override dialog (IMAP), and
while we're at it, use the most appropriate reduced number+unit.
Andrej Kacian [Sat, 18 Aug 2018 12:28:45 +0000 (14:28 +0200)]
Remove unneeded includes from entity.c.
wwp [Sat, 18 Aug 2018 07:56:41 +0000 (09:56 +0200)]
Warn and fail rather than miserably crashing when format string in
faulty.
wwp [Sat, 18 Aug 2018 07:34:09 +0000 (09:34 +0200)]
Fix for Bug 4072: Crash when clicking 'reply' or 'reply with quote'
Wrong '%\n' format causes a crash in g_strdup_printf.
wwp [Thu, 16 Aug 2018 06:45:55 +0000 (08:45 +0200)]
Fix/normalize product name in few places in UI and in several source
files.