Paul [Sun, 2 Dec 2018 11:29:48 +0000 (11:29 +0000)]
these never were directories even before renaming
Paul [Sun, 2 Dec 2018 11:15:11 +0000 (11:15 +0000)]
fix bug 4132, '"Mark all as (un)read" dialog appears when acting on 1 message only'
Andrej Kacian [Sat, 1 Dec 2018 09:38:29 +0000 (10:38 +0100)]
Added header popup menu to folderview.
Andrej Kacian [Sat, 1 Dec 2018 09:32:00 +0000 (10:32 +0100)]
Create "/Menus" in mainwindow's UI manager in mainwindow.c, not in summaryview.c.
Andrej Kacian [Sat, 1 Dec 2018 09:06:51 +0000 (10:06 +0100)]
Added MainWin* parameter to folderview_create().
Andrej Kacian [Thu, 29 Nov 2018 18:20:19 +0000 (19:20 +0100)]
Modernized and simplified plugin's GtkHotkeyInfo class implementation.
All this so that we can get rid of deprecated
g_type_class_add_private().
Andrej Kacian [Thu, 29 Nov 2018 17:40:41 +0000 (18:40 +0100)]
Remove file gtk/gdkkeysyms-new.h, since we now require new enough GTK+ version.
Andrej Kacian [Thu, 29 Nov 2018 17:30:21 +0000 (18:30 +0100)]
Sourcewindow doesn't need explicit handling of Ctrl+A, GtkTextView already interprets it as "select all".
Andrej Kacian [Thu, 29 Nov 2018 17:18:30 +0000 (18:18 +0100)]
Fix improper GTK API usage in sourceview's "select all".
GtkTextView does not implement GtkEditable interface.
Andrej Kacian [Sun, 25 Nov 2018 14:20:58 +0000 (15:20 +0100)]
Added header popup menu to summaryview, with two menuitems.
Also added "Lock column headers" to prefs dialog.
Sorting lock pref implementation by Paul.
Andrej Kacian [Thu, 29 Nov 2018 16:50:26 +0000 (17:50 +0100)]
Added PACK_HSPACER macro to prefs_gtk.h
Andrej Kacian [Wed, 28 Nov 2018 21:33:23 +0000 (22:33 +0100)]
Fix a memory leak in folderview_update_node().
Paul [Mon, 26 Nov 2018 09:41:38 +0000 (09:41 +0000)]
be more informative in 'Add mailbox' dialogue
Andrej Kacian [Sat, 24 Nov 2018 22:14:26 +0000 (23:14 +0100)]
Mailmbox: fix buffer overflow in mailimf_get_message_id().
The compiler warning was:
mailimf_types_helper.c: In function ‘mailimf_get_message_id’:
mailimf_types_helper.c:1270:51: warning: ‘%s’ directive output may be truncated writing up to 511 bytes into a region of size between 463 and 500 [-Wformat-truncation=]
snprintf(id, MAX_MESSAGE_ID, "etPan.%llx.%lx.%x@%s",
^~
(long long)now, value, getpid(), name);
~~~~
mailimf_types_helper.c:1270:3: note: ‘snprintf’ output between 13 and 561 bytes into a destination of size 512
snprintf(id, MAX_MESSAGE_ID, "etPan.%llx.%lx.%x@%s",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(long long)now, value, getpid(), name);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Andrej Kacian [Sat, 24 Nov 2018 22:04:52 +0000 (23:04 +0100)]
Finish buffer overflow fix attempted in
e025cbc3b.
Andrej Kacian [Sat, 24 Nov 2018 21:37:11 +0000 (22:37 +0100)]
Removed deprecated g_type_class_add_private() call in ParasitePythonShell.
Paul [Fri, 23 Nov 2018 11:39:29 +0000 (11:39 +0000)]
fix engrish
Paul [Fri, 23 Nov 2018 07:17:23 +0000 (07:17 +0000)]
fix lost processing rules when renaming folder
Andrej Kacian [Mon, 19 Nov 2018 10:23:35 +0000 (11:23 +0100)]
xml_parse_file() fails without assertion warning if xml_open_file() returns NULL.
This is not a programmer mistake, therefore an assertion
warning is not a good idea. xml_open_file() already shows
an assertion warning if necessary.
Paul [Sun, 18 Nov 2018 18:39:22 +0000 (18:39 +0000)]
mention inherited processing rules also, as this is what happens
Paul [Sun, 18 Nov 2018 17:23:35 +0000 (17:23 +0000)]
fix bug where creating a new folder wth inheriting properties doesn't write processinf rules
after copying folder with 'inherit properties from parent folder' set,
the processing rules are (initially) present in the processing rules
dialogue, but are not actually written. So on a restart they are 'lost'.
This is probably the actual bug 4121, ' Moving a subfolder in another
folder erases its processing rules', rather than the description given.
Andrej Kacian [Sat, 17 Nov 2018 19:48:44 +0000 (20:48 +0100)]
Implement batch message removal for RSSyl.
This allows further optimization of how often the
.deleted file is read and written.
Andrej Kacian [Fri, 16 Nov 2018 21:17:48 +0000 (22:17 +0100)]
Use black as default value for folder_color folder pref.
Andrej Kacian [Fri, 16 Nov 2018 19:50:53 +0000 (20:50 +0100)]
Added some basic unit tests for unmime_header().
Andrej Kacian [Fri, 16 Nov 2018 19:50:32 +0000 (20:50 +0100)]
Added NULL parameter check for unmime_header().
Paul [Fri, 16 Nov 2018 09:49:51 +0000 (09:49 +0000)]
match the wording of the /View menu
Colin Leroy [Thu, 15 Nov 2018 09:56:23 +0000 (10:56 +0100)]
Fix bug #4120, "New cert files are created in $HOME instead of in ~/.claws-mail/certs"
Andrej Kacian [Thu, 15 Nov 2018 07:31:33 +0000 (08:31 +0100)]
Sanitize filenames for saved TLS certificates.
Fixes using unsafe_ssl_certs pref on Windows, as that
includes certificate fingerprint in the filename.
Fingerprints contain colons, and those are not allowed
in filenames on Windows.
Andrej Kacian [Wed, 14 Nov 2018 20:21:51 +0000 (21:21 +0100)]
Fix WEXITSTATUS build error on Win32.
Also add glib.h include in file-utils.c, so that
G_OS_WIN32 ifdefs actually work.
Paul [Wed, 14 Nov 2018 06:20:21 +0000 (06:20 +0000)]
move 'msg selection when entering a folder" button to Message List page
... and some English modifications
Andrej Kacian [Tue, 13 Nov 2018 22:31:37 +0000 (23:31 +0100)]
Further optimize .deleted file reading in RSSyl.
When updating a feed, only read the file once at the
beginning, instead of reading and rereading it for
every parsed feed item.
Andrej Kacian [Tue, 13 Nov 2018 20:41:04 +0000 (21:41 +0100)]
Use much less disk IO when working with .deleted files in RSSyl.
Andrej Kacian [Mon, 12 Nov 2018 20:23:38 +0000 (21:23 +0100)]
Restored a mistakenly removed ifdef.
Paul [Sat, 10 Nov 2018 19:42:27 +0000 (19:42 +0000)]
contiunue the fix for check-at-startup,
eade694613c19ffe747ccb77466070e474e3f968
The commit
eade694613c19ffe747ccb77466070e474e3f968 fixed the case where
'check at startup' completely failed if user did no periodic auto-check.
This commit fixes the double-check at start-up (main.c) and the receive
dialogue being shown, contrary to option for showing the receive
dialogue.
Paul [Fri, 9 Nov 2018 13:53:05 +0000 (13:53 +0000)]
rearrange /Display/Summaries/Message list (some more)
Paul [Fri, 9 Nov 2018 11:48:49 +0000 (11:48 +0000)]
update en_GB.po
Paul [Fri, 9 Nov 2018 11:26:22 +0000 (11:26 +0000)]
Display/Summaries/... re-arrange some items
Paul [Fri, 9 Nov 2018 11:09:06 +0000 (11:09 +0000)]
rework Display/Summaries
spilt the page into 3 notebook pages.
rearrange some options.
add some options for new folder defaults
Paul [Thu, 8 Nov 2018 19:39:24 +0000 (19:39 +0000)]
modify label text
Paul [Thu, 8 Nov 2018 18:42:43 +0000 (18:42 +0000)]
fix check for mail at start-up
Paul [Wed, 7 Nov 2018 11:46:34 +0000 (11:46 +0000)]
remove all gtk3 conditionals
Paul [Wed, 7 Nov 2018 11:07:17 +0000 (11:07 +0000)]
remove --enable-gtk3 configure flag
Paul [Wed, 7 Nov 2018 10:33:06 +0000 (10:33 +0000)]
drop redundant md5 fingerprint; more clearly indicate expired sigs
Paul [Wed, 7 Nov 2018 10:04:37 +0000 (10:04 +0000)]
implement RFE 3810, 'SSL certificate manager: add Signature Status and Expiration'
Add Status and Expiry columns to certificate list, use bold text to
indicate expired certs and failed signatures, and also append
' (expired)' to status where appropriate.
Thanks to Andrej for optimisation in
ssl_manager_list_view_insert_cert().
Paul [Tue, 6 Nov 2018 06:15:38 +0000 (06:15 +0000)]
fix bug 4114, 'autogen.sh: Fix argument quoting'
patch by Berhard <rep.dot.nop@gmail.com>
Paul [Tue, 6 Nov 2018 06:14:37 +0000 (06:14 +0000)]
fix bug 4115 'autogen: avoid unwarranted re-configure'
patch by Bernhard <rep.dot.nop@gmail.com>
Andrej Kacian [Mon, 5 Nov 2018 23:05:17 +0000 (00:05 +0100)]
Make sure all users of GtkCMCList do not blindly assume that a button-press-event happens inside of the tree view.
If clicking on the header row, the event's x,y coordinates
were pointing to a different spot than what the event handler
code expected, since those coordinates are relative to the
relevant GDK window, and header row has its own. Calls to
gtk_cmclist_get_selection_info() or gtk_sctree_is_hot_spot()
in such cases therefore returned bogus info.
This fixes things like folderview expanding/collapsing
selected folder when double-clicking its header column, or
selecting first row when single-clicking it.
Andrej Kacian [Mon, 5 Nov 2018 19:33:07 +0000 (20:33 +0100)]
Use same integer type for color folder item prefs like everyone else.
Andrej Kacian [Mon, 5 Nov 2018 19:31:53 +0000 (20:31 +0100)]
Save folder color as P_COLOR in folderitemrc.
The code to handle backward compatibility (color as int)
is already there.
Andrej Kacian [Mon, 5 Nov 2018 10:49:21 +0000 (11:49 +0100)]
Add config_version to folder item prefs.
Also some minor code comment and debug output tweaks.
User Corn [Thu, 1 Nov 2018 23:18:48 +0000 (00:18 +0100)]
Fix build on FreeBSD, sys/wait.h is needed for WEXITSTATUS macro
Paul [Mon, 29 Oct 2018 17:31:51 +0000 (17:31 +0000)]
fix annoyance where your current reading is disturbed when a new msg is filtered into the current folder
Paul [Mon, 29 Oct 2018 09:03:04 +0000 (09:03 +0000)]
fix for smtp-only accounts when global pref for save sent msg is set
Paul [Mon, 29 Oct 2018 09:01:16 +0000 (09:01 +0000)]
revert g45500aa, it breaks stuff
Andrej Kacian [Sun, 28 Oct 2018 20:58:31 +0000 (21:58 +0100)]
Handle compose "Save Message to" checkbox state in compose_set_save_to() only.
Fixes bug #4107 - Sent messages do not appear in "Sent" folder...
Paul [Fri, 26 Oct 2018 12:38:19 +0000 (13:38 +0100)]
only show warning about privacy system 'none' on replies to signed or encrypted msgs
Paul [Thu, 25 Oct 2018 16:09:16 +0000 (17:09 +0100)]
add error checking on account prefs Advanced page
Paul [Thu, 25 Oct 2018 16:08:21 +0000 (17:08 +0100)]
always use folder pref for save msg location if set
Paul [Thu, 25 Oct 2018 16:07:19 +0000 (17:07 +0100)]
allow account pref and folder pref to override global pref for saving sent msgs
Paul [Thu, 25 Oct 2018 09:56:44 +0000 (10:56 +0100)]
less haste
Paul [Thu, 25 Oct 2018 09:55:30 +0000 (10:55 +0100)]
Paul [Thu, 25 Oct 2018 09:36:54 +0000 (10:36 +0100)]
don't leave the user in limbo when privacy system is 'none' and auto signing/encrypting is set
Andrej Kacian [Wed, 24 Oct 2018 15:23:14 +0000 (17:23 +0200)]
Pack account prefs' checkbtn_crosspost into correct hbox, rather than leaving it unused.
Andrej Kacian [Wed, 24 Oct 2018 15:20:10 +0000 (17:20 +0200)]
Do not use gtk_cmctree_set_line_style(), since it does nothing.
Andrej Kacian [Tue, 23 Oct 2018 18:51:06 +0000 (20:51 +0200)]
Removed deprecated g_type_class_add_private() call in ClawsSpellEntry.
Andrej Kacian [Tue, 23 Oct 2018 18:46:32 +0000 (20:46 +0200)]
Use GTK private struct feature correctly in ClawsSpellEntry.
g_type_class_add_private() takes care of adding,
initializing and cleaning it up, there is no need
to add another copy of it and manage it manually.
Andrej Kacian [Tue, 23 Oct 2018 18:30:49 +0000 (20:30 +0200)]
Removed deprecated g_type_class_add_private() call in GtkSHRuler.
Andrej Kacian [Fri, 19 Oct 2018 21:36:40 +0000 (23:36 +0200)]
Rework debug output in passwd_store_set() to be less confusing.
Andrej Kacian [Fri, 19 Oct 2018 21:22:20 +0000 (23:22 +0200)]
When deleting an account, delete its password store block, instead of just NULLing the block's entries hash table.
Ricardo Mones [Fri, 19 Oct 2018 11:58:11 +0000 (13:58 +0200)]
Fix translation for octet-stream view
Colin Leroy [Thu, 18 Oct 2018 12:13:58 +0000 (14:13 +0200)]
Rewrap fr manual for lisibility
Colin Leroy [Wed, 17 Oct 2018 07:26:26 +0000 (09:26 +0200)]
Fix crash in dangling message search.
Andrej Kacian [Tue, 16 Oct 2018 16:18:40 +0000 (18:18 +0200)]
Do not redraw focus of GtkCMCList if the row is unchanged in move_focus_row();
Andrej Kacian [Tue, 16 Oct 2018 16:16:02 +0000 (18:16 +0200)]
In summary_key_pressed(), do not try to reopen the same message if cursor does not change.
Andrej Kacian [Tue, 16 Oct 2018 16:12:05 +0000 (18:12 +0200)]
Fix an off-by-one error in summary_key_pressed().
Paul [Tue, 16 Oct 2018 09:10:03 +0000 (10:10 +0100)]
fix bug (rfe) 4102, 'Show SHA-256 fingerprint in certificate verification popup'
Paul [Tue, 16 Oct 2018 06:38:19 +0000 (07:38 +0100)]
fix invalid cast runtime warning
Colin Leroy [Mon, 15 Oct 2018 19:15:05 +0000 (21:15 +0200)]
PDF Viewer: handle Ctrl+scroll for zooming
Colin Leroy [Mon, 15 Oct 2018 08:39:21 +0000 (10:39 +0200)]
Fancy: fix left-click on links not opening in browser.
Colin Leroy [Thu, 11 Oct 2018 14:06:39 +0000 (16:06 +0200)]
Make the "Saving sent message..." debug prints more interesting.
Colin Leroy [Wed, 10 Oct 2018 12:34:34 +0000 (14:34 +0200)]
Revert all memory-based tmpfile I/O, it comes with too much drawbacks
(like having to know the filesize before writing to it)
Colin Leroy [Wed, 10 Oct 2018 08:37:23 +0000 (10:37 +0200)]
Fix wording, thanks wwp
Colin Leroy [Wed, 10 Oct 2018 08:22:09 +0000 (10:22 +0200)]
str_open_as_stream() doesn't need a real file either.
Colin Leroy [Wed, 10 Oct 2018 08:09:11 +0000 (10:09 +0200)]
Comment the my_tmpfile_with_len() function.
Colin Leroy [Wed, 10 Oct 2018 07:59:10 +0000 (09:59 +0200)]
Fix in-memory temporary file length
Ricardo Mones [Mon, 8 Oct 2018 13:51:15 +0000 (15:51 +0200)]
Update textviewer.pl
Patch by H.Merijn Brand
Ricardo Mones [Mon, 8 Oct 2018 13:49:29 +0000 (15:49 +0200)]
Update thread tools
Patch by H.Merijn Brand
Andrej Kacian [Mon, 8 Oct 2018 11:31:31 +0000 (13:31 +0200)]
...and one more forgotten NULL check.
Andrej Kacian [Mon, 8 Oct 2018 11:29:21 +0000 (13:29 +0200)]
Added some NULL checks in passwordstore.c to avoid potential crash.
Andrej Kacian [Mon, 8 Oct 2018 08:34:08 +0000 (10:34 +0200)]
Fix unit tests building, broken after the file-utils addition.
Andrej Kacian [Mon, 8 Oct 2018 08:33:26 +0000 (10:33 +0200)]
Fix file-utils related compiler warnings in crash.c.
Colin Leroy [Sun, 7 Oct 2018 19:31:37 +0000 (21:31 +0200)]
Fix hang on IMAP - the log file is accessed by multiple threads
Colin Leroy [Sun, 7 Oct 2018 18:41:20 +0000 (20:41 +0200)]
Make safe_fclose static now that it can be
Colin Leroy [Sun, 7 Oct 2018 18:26:50 +0000 (20:26 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Andrej Kacian [Sun, 7 Oct 2018 17:16:15 +0000 (19:16 +0200)]
Improve debug output in passwd_store_set().
Colin Leroy [Sun, 7 Oct 2018 13:40:38 +0000 (15:40 +0200)]
Fix performance loss on certain file I/O that doesn't need
to be safe
Colin Leroy [Sun, 7 Oct 2018 13:32:38 +0000 (15:32 +0200)]
Add a memory-backed my_tmpfile() implementation.
Colin Leroy [Sun, 7 Oct 2018 12:46:02 +0000 (14:46 +0200)]
Rename claws_io to file-utils, and move file-related functions
from utils.c to file-utils.c
Colin Leroy [Sun, 7 Oct 2018 12:16:04 +0000 (14:16 +0200)]
Merge branch 'master' of ssh://git.claws-mail.org/home/git/claws
Colin Leroy [Sun, 7 Oct 2018 12:12:29 +0000 (14:12 +0200)]
Wrap file I/O to claws_* to benefit from custom locking when
available. Gains about 33% on I/O bound tasks.