claws.git
22 months agoFix indentation, silents up CID #1434201.
wwp [Wed, 11 Apr 2018 07:32:53 +0000 (09:32 +0200)]
Fix indentation, silents up CID #1434201.

22 months agoFix wrong use of pointer-to-array as an array, CID #1434191.
wwp [Wed, 11 Apr 2018 06:57:32 +0000 (08:57 +0200)]
Fix wrong use of pointer-to-array as an array, CID #1434191.

22 months agoFix buffer overrun, always writing at buffer size + 1.
wwp [Wed, 11 Apr 2018 06:40:57 +0000 (08:40 +0200)]
Fix buffer overrun, always writing at buffer size + 1.
Fixes CID #1434188.

22 months agoFix CID #1434197, mismatch and unneeded display of unavailable folder class
wwp [Wed, 11 Apr 2018 06:30:13 +0000 (08:30 +0200)]
Fix CID #1434197, mismatch and unneeded display of unavailable folder class
in warning.

22 months agoAdd missing src/addrmerge.h file from 3.16.0-107-gf25722a.
wwp [Tue, 10 Apr 2018 07:44:20 +0000 (09:44 +0200)]
Add missing src/addrmerge.h file from 3.16.0-107-gf25722a.

22 months agoCheck for enchant-2 (necessary since enchant 2.1.3).
wwp [Tue, 10 Apr 2018 07:26:21 +0000 (09:26 +0200)]
Check for enchant-2 (necessary since enchant 2.1.3).

22 months agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Paul [Tue, 10 Apr 2018 07:14:21 +0000 (08:14 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

22 months agoAdd a basic contact merging feature to the address book, thanks to
wwp [Mon, 9 Apr 2018 22:23:14 +0000 (00:23 +0200)]
Add a basic contact merging feature to the address book, thanks to
Charles Lehner <cel@celehner.com>.
Closes bug 3346: Contact merging

22 months agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Paul [Sun, 8 Apr 2018 18:32:04 +0000 (19:32 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

22 months agoaddritem_person_get_picture() now returns something useful: a copy
wwp [Sun, 8 Apr 2018 15:03:50 +0000 (17:03 +0200)]
addritem_person_get_picture() now returns something useful: a copy
of the addritem's picture full path (still to be free'd by the caller),
instead of a copy of the addritem's UID string.

22 months agoaddritem+person_get_picture now returns something useful: a copy
wwp [Sun, 8 Apr 2018 15:03:50 +0000 (17:03 +0200)]
addritem+person_get_picture now returns something useful: a copy
of the addritem's picture full path (still to be free'd by the caller),
instead of a copy of the addritem's UID string.

22 months agoRemove the empty progress bar that may remain in status bar after
wwp [Wed, 4 Apr 2018 08:27:01 +0000 (10:27 +0200)]
Remove the empty progress bar that may remain in status bar after
pop3 incorporation (if account is configured to leave messages
on server).
Closes bug 3985: an empty progress bar remains after POP mail check completes

22 months agoreplace deprecated 'NONE' token
Paul [Tue, 3 Apr 2018 09:27:56 +0000 (10:27 +0100)]
replace deprecated 'NONE' token

22 months agoFix broken templates attachments due to commit 814b087,
wwp [Tue, 3 Apr 2018 08:17:58 +0000 (10:17 +0200)]
Fix broken templates attachments due to commit 814b087,
which clears template internals (including attachments list)
wherever template contains any field to apply (To/Subject/etc.)
and before attachments could be processed. Simply process
attachments before attachments list may be cleared by fields
processing. Ideally we should change quote_fmt_reset_vartable()
or its uses in compose.c at least.

22 months agoFix broken build using GTK3
Michael Rasmussen [Fri, 30 Mar 2018 09:47:56 +0000 (11:47 +0200)]
Fix broken build using GTK3

Signed-off-by: Michael Rasmussen <mir@datanom.net>
22 months agoChange how main window's keyboard accelerators are bypassed when quicksearch has...
Andrej Kacian [Fri, 9 Mar 2018 18:24:44 +0000 (19:24 +0100)]
Change how main window's keyboard accelerators are bypassed when quicksearch has focus.

Instead of artificially forwarding the keypress to quicksearch
(only when Shift is pressed), we emit a new "key-press-event"
signal directly to the quicksearch entry, and block the original
signal before it reaches the accelerator handling.

Closes bug #3984: Copy-paste in find/filter field works incorrectly

22 months agoAttachment remover: notify the user about what has been done when processing
wwp [Wed, 28 Mar 2018 21:06:15 +0000 (23:06 +0200)]
Attachment remover: notify the user about what has been done when processing
multiple selections.

22 months agoAdapt identical behaviour to native address book. See commit 47e0437b8b
Michael Rasmussen [Wed, 28 Mar 2018 11:06:26 +0000 (13:06 +0200)]
Adapt identical behaviour to native address book. See commit 47e0437b8b

Signed-off-by: Michael Rasmussen <mir@datanom.net>
22 months agoFix broken build from commit 47e0437b8b
Michael Rasmussen [Wed, 28 Mar 2018 11:04:48 +0000 (13:04 +0200)]
Fix broken build from commit 47e0437b8b

Signed-off-by: Michael Rasmussen <mir@datanom.net>
22 months agoRemove key and free attribute value only if they are valid,
wwp [Mon, 26 Mar 2018 12:01:26 +0000 (14:01 +0200)]
Remove key and free attribute value only if they are valid,
clears CID 1220202.

23 months agoFixed hook_id declarations to be gulong instead of guint.
wwp [Mon, 19 Mar 2018 10:03:09 +0000 (11:03 +0100)]
Fixed hook_id declarations to be gulong instead of guint.
Made statusbar's hook_id static.
Rework hook_id magic value, now 0 instead of -1, and use a define (HOOK_NONE)
everywhere instead of 0. Any hook_id must be initialized to HOOK_NONE.
Hook_id that get invalidated or reset get the same HOOK_NONE value.

23 months agoDon't compute charset unless necessary (vcalviewer_get_uid_from_mimeinfo()),
wwp [Sat, 17 Mar 2018 20:53:20 +0000 (21:53 +0100)]
Don't compute charset unless necessary (vcalviewer_get_uid_from_mimeinfo()),
don't compute charset at all when not used (vcalviewer_get_request_values(),
vcalviewer_get_reply_values(), de facto solves CID 1372373), possible remnants
of an old implementation that I couldn't even found in log.

23 months agoFix possible access to uninitilized folder pointer (CID 1402515),
wwp [Sat, 17 Mar 2018 20:28:00 +0000 (21:28 +0100)]
Fix possible access to uninitilized folder pointer (CID 1402515),
add a warning if vcal folder's not found.

23 months agoSave us 35 warnings about hooks_register_hook() return checks.
wwp [Sat, 17 Mar 2018 19:18:22 +0000 (20:18 +0100)]
Save us 35 warnings about hooks_register_hook() return checks.

23 months agoFew optimizations: avoid strlen when string length is known (read()>0 return);
wwp [Sat, 17 Mar 2018 19:02:48 +0000 (20:02 +0100)]
Few optimizations: avoid strlen when string length is known (read()>0 return);
end string at real end of string instead of at buffer boundary and
be sure we print 0-terminated string (clamd_stream_scan());
clamd_verify_email: discover a strange multi-line response, be sure we
print 0-terminated string (CID 1220483), debug_print all response lines.

23 months agoFix wrong malloc of clamd_socket struct, CID 1220477.
wwp [Sat, 17 Mar 2018 18:34:05 +0000 (19:34 +0100)]
Fix wrong malloc of clamd_socket struct, CID 1220477.

23 months agoHandle IMAP search failure instead of ignoring it.
Andrej Kacian [Wed, 14 Mar 2018 20:35:05 +0000 (21:35 +0100)]
Handle IMAP search failure instead of ignoring it.

Error out on protocol error during search, disconnect
the IMAP session, and display an error dialog about it.

Closes bug 3986 - IMAP quick search using non-ASCII
characters creates an infinite loop

23 months agoClear statusbar's progressbar in case of NNTP xhdr/xover failure.
wwp [Wed, 14 Mar 2018 10:22:47 +0000 (11:22 +0100)]
Clear statusbar's progressbar in case of NNTP xhdr/xover failure.

23 months agoApply the attribute list fix from 8017810c4 also when handling LDAP contacts.
Andrej Kacian [Sat, 10 Mar 2018 11:40:13 +0000 (12:40 +0100)]
Apply the attribute list fix from 8017810c4 also when handling LDAP contacts.

23 months agoFix two crashes caused by bad GtkListStore management in editaddress.c.
Andrej Kacian [Sat, 10 Mar 2018 10:59:11 +0000 (11:59 +0100)]
Fix two crashes caused by bad GtkListStore management in editaddress.c.

23 months agoFix use of uninitialized variable in addressbook edit person dialog.
Andrej Kacian [Mon, 5 Mar 2018 09:33:57 +0000 (10:33 +0100)]
Fix use of uninitialized variable in addressbook edit person dialog.

23 months agoMake LDAP use log_print instead of log_message for uninteresting stuff.
Andrej Kacian [Sat, 3 Mar 2018 17:05:52 +0000 (18:05 +0100)]
Make LDAP use log_print instead of log_message for uninteresting stuff.

This makes it less noisy on the console without --debug if
everything works OK.

23 months agoReplace GtkSCTree in addressbook_foldersel.c with GtkTreeView.
Andrej Kacian [Sat, 3 Mar 2018 16:37:06 +0000 (17:37 +0100)]
Replace GtkSCTree in addressbook_foldersel.c with GtkTreeView.

23 months agoReplace both GtkCMCLists in Edit Person dialog With GtkTreeView.
Andrej Kacian [Sat, 3 Mar 2018 09:28:23 +0000 (10:28 +0100)]
Replace both GtkCMCLists in Edit Person dialog With GtkTreeView.

One for email list, one for attribute list.

23 months agoFix potential crashes in gtkut_tree_view_get_selected_pointer().
Andrej Kacian [Sat, 3 Mar 2018 09:27:56 +0000 (10:27 +0100)]
Fix potential crashes in gtkut_tree_view_get_selected_pointer().

23 months agoRemove unused struct member in SummaryView
Ricardo Mones [Wed, 28 Feb 2018 23:23:15 +0000 (00:23 +0100)]
Remove unused struct member in SummaryView

In the end it wasn't a very important color… ;-)

23 months agoFix a dumb double-free on Windows.
Andrej Kacian [Wed, 28 Feb 2018 18:43:43 +0000 (19:43 +0100)]
Fix a dumb double-free on Windows.

Closes bug 3957: Claws-Mail 64bit crashes when saving a draft

23 months agoFix license version in Address Keeper plugin
Ricardo Mones [Tue, 27 Feb 2018 23:52:50 +0000 (00:52 +0100)]
Fix license version in Address Keeper plugin

23 months agoUpdate uses of gtkut_tree_view_get_selected_pointer().
Andrej Kacian [Tue, 27 Feb 2018 19:24:06 +0000 (20:24 +0100)]
Update uses of gtkut_tree_view_get_selected_pointer().

23 months agoMake the gtkut_tree_view_get_selected_pointer() more versatile.
Andrej Kacian [Tue, 27 Feb 2018 19:19:37 +0000 (20:19 +0100)]
Make the gtkut_tree_view_get_selected_pointer() more versatile.

It can now be used also for non-trivial use cases, where
the caller needs to further work with the model and/or
selection, or if a string value needs to be read from the
model.

23 months agoAdd gtkut_tree_view_get_selected_pointer() helper function.
Andrej Kacian [Sun, 25 Feb 2018 19:40:38 +0000 (20:40 +0100)]
Add gtkut_tree_view_get_selected_pointer() helper function.

It's meant for the simple cases when you just want to get
a pointer out of a treeview's selected row and you're not
going to do anything with the view, nor the model.

23 months agoFix summary_select_all when there is nothing selected.
Andrej Kacian [Mon, 26 Feb 2018 21:06:27 +0000 (22:06 +0100)]
Fix summary_select_all when there is nothing selected.

Due to how GtkCMCList works, we first need to focus and
select a row.
Fixes bug #3973, ''select all' in summaryview does not
automatically focus the summaryview'

23 months agoRevert "fix bug 3973, ''select all' in summaryview does not automatically focus the...
Andrej Kacian [Mon, 26 Feb 2018 21:06:02 +0000 (22:06 +0100)]
Revert "fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'"

This reverts commit a3e48bd6e7e62dedfef8ddedbeeb90400b5234b3.
That commit introduced slowness when selecting all rows.

23 months agoReplace GtkCMCList in browseldap.c with GtkTreeView.
Andrej Kacian [Sun, 25 Feb 2018 15:18:41 +0000 (16:18 +0100)]
Replace GtkCMCList in browseldap.c with GtkTreeView.

23 months agofix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'
Paul [Sun, 25 Feb 2018 13:18:40 +0000 (13:18 +0000)]
fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'

The problem is apparent when 'default selection on entering a folder' is
set to 'none' and the first user action on entering the folder is
'select all'. This visually selected all the messages but summaryview
did not have the focus, so any actions performed on that list would
fail.

Removed summary_select_all(), which didn't quite do as advertised and
instead use gtk_cmclist_select_all() which selects and focuses.

23 months agoMerge needless three gtk_tree_model_get() calls into one.
Andrej Kacian [Sat, 24 Feb 2018 22:35:26 +0000 (23:35 +0100)]
Merge needless three gtk_tree_model_get() calls into one.

23 months agoFix memory leaks from results of gtk_tree_model_get().
Andrej Kacian [Sat, 24 Feb 2018 22:27:35 +0000 (23:27 +0100)]
Fix memory leaks from results of gtk_tree_model_get().

G_TYPE_STRING values need to be freed, G_TYPE_PIXBUF
(or anything else derived from GObject) needs to be
unreferenced. This was forgotten in some places.

23 months agoUnreference GtkTreeModel pointers after they've been added to a tree view.
Andrej Kacian [Sat, 24 Feb 2018 21:30:51 +0000 (22:30 +0100)]
Unreference GtkTreeModel pointers after they've been added to a tree view.

This was forgotten in only a few cases.

23 months agoReplace GtkCMCList in editldap_basedn.c with GtkTreeView.
Andrej Kacian [Sat, 24 Feb 2018 21:14:25 +0000 (22:14 +0100)]
Replace GtkCMCList in editldap_basedn.c with GtkTreeView.

23 months agoReplace GtkCMCTree in addressadd.c with GtkTreeView.
Andrej Kacian [Sat, 24 Feb 2018 19:26:20 +0000 (20:26 +0100)]
Replace GtkCMCTree in addressadd.c with GtkTreeView.

23 months agoRSSyl: fix deleted item checking when modified or published time is missing
Andrej Kacian [Fri, 23 Feb 2018 21:27:35 +0000 (22:27 +0100)]
RSSyl: fix deleted item checking when modified or published time is missing

Fixes bug #3971.

23 months agoReplace GtkCMCList in pgpcore select-keys.c with GtkTreeView.
Andrej Kacian [Mon, 19 Feb 2018 22:22:11 +0000 (23:22 +0100)]
Replace GtkCMCList in pgpcore select-keys.c with GtkTreeView.

While we're at it, activating a row now finishes the
selection dialog without having to press the Select button.

23 months agoReplace GtkCMCList in LDIF import dialog with GtkTreeView.
Andrej Kacian [Sun, 18 Feb 2018 21:25:43 +0000 (22:25 +0100)]
Replace GtkCMCList in LDIF import dialog with GtkTreeView.

2 years agoReplace GtkCMCList in addrgather dialog with GtkTreeView.
Andrej Kacian [Sat, 17 Feb 2018 17:23:48 +0000 (18:23 +0100)]
Replace GtkCMCList in addrgather dialog with GtkTreeView.

2 years agoReplace GtkCMCList in folder sort dialog with GtkTreeView.
Andrej Kacian [Sat, 17 Feb 2018 16:49:08 +0000 (17:49 +0100)]
Replace GtkCMCList in folder sort dialog with GtkTreeView.

2 years agoUse color buttons' macro also here
Ricardo Mones [Fri, 16 Feb 2018 21:50:13 +0000 (22:50 +0100)]
Use color buttons' macro also here

2 years agoAdd support for the iso-8859-8-i encoding
Andrej Kacian [Wed, 14 Feb 2018 22:03:17 +0000 (23:03 +0100)]
Add support for the iso-8859-8-i encoding

Support this encoding by aliasing it to iso-8859-8.

2 years agoMake GtkCMCList/Tree use "text", not "fg" rc property for text color.
Andrej Kacian [Tue, 13 Feb 2018 22:50:15 +0000 (23:50 +0100)]
Make GtkCMCList/Tree use "text", not "fg" rc property for text color.

Closes bug #3880.

2 years agoCast to GSourceFunc instead of deprecated GtkFunction when using g_timeout_add().
Andrej Kacian [Fri, 9 Feb 2018 20:19:31 +0000 (21:19 +0100)]
Cast to GSourceFunc instead of deprecated GtkFunction when using g_timeout_add().

Also correct return type of fancy_show_mimepart_prepare()
callback function.

2 years agoUpdate few occurrences to the new alertpanel() API (and by the way,
wwp [Fri, 9 Feb 2018 21:36:41 +0000 (22:36 +0100)]
Update few occurrences to the new alertpanel() API (and by the way,
solve a leaking button_label strinc allocation).

2 years agoMigrate from deprecated GtkTooltips to GtkTooltip in clamd plugin.
Andrej Kacian [Fri, 9 Feb 2018 20:18:29 +0000 (21:18 +0100)]
Migrate from deprecated GtkTooltips to GtkTooltip in clamd plugin.

2 years agoFix few forgotten GDK_ to GDK_KEY_ renames in plugins.
Andrej Kacian [Fri, 9 Feb 2018 20:15:01 +0000 (21:15 +0100)]
Fix few forgotten GDK_ to GDK_KEY_ renames in plugins.

2 years agoForgotten changes in commit 09301b6e73e4af1b03b6f19d340dd909cf527bcc
Michael Rasmussen [Fri, 9 Feb 2018 19:46:54 +0000 (20:46 +0100)]
Forgotten changes in commit 09301b6e73e4af1b03b6f19d340dd909cf527bcc

Signed-off-by: Michael Rasmussen <mir@datanom.net>
2 years agoMerge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
Michael Rasmussen [Fri, 9 Feb 2018 19:40:26 +0000 (20:40 +0100)]
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws

2 years agoDo not put enchant's CFLAGS into main CFLAGS make variable.
Andrej Kacian [Fri, 9 Feb 2018 19:21:41 +0000 (20:21 +0100)]
Do not put enchant's CFLAGS into main CFLAGS make variable.

Handle its CFLAGS just like all other libraries'.

2 years agoRework of alertpanel default button focus handling.
Andrej Kacian [Fri, 9 Feb 2018 13:44:30 +0000 (14:44 +0100)]
Rework of alertpanel default button focus handling.

Instead of using "+" prefix with button labels and/or
the default_value parameter, we introduce "focus"
parameter, which will point to first, second or third
button.

Advantages:
- we got rid of the "+" prefix, which won't work with GTK3
  with GTK3
- instead of having two ways to indicate which button
  should have focus, which can be in conflict, and
  are not very straightforward, there is just one,
  arguably more intuitive
- some small memory leaks fixed along the way
  (using g_strconcat() directly as function argument)

2 years agoFix ‘GtkWidget {aka struct _GtkWidget}’ has no member named ‘style’
Ricardo Mones [Thu, 8 Feb 2018 08:41:51 +0000 (09:41 +0100)]
Fix ‘GtkWidget {aka struct _GtkWidget}’ has no member named ‘style’

Thanks to Abhay S. Kushwaha for reporting!

2 years agoFix ‘GtkLabel {aka struct _GtkLabel}’ has no member named ‘label’
Ricardo Mones [Tue, 6 Feb 2018 23:45:42 +0000 (00:45 +0100)]
Fix ‘GtkLabel {aka struct _GtkLabel}’ has no member named ‘label’

2 years agoForce -DGTK_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE in GTK_CFLAGS.
Andrej Kacian [Tue, 6 Feb 2018 21:53:31 +0000 (22:53 +0100)]
Force -DGTK_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE in GTK_CFLAGS.

2 years agoRemove direct GTK struct member access from pdf_viewer plugin.
Andrej Kacian [Tue, 6 Feb 2018 21:45:18 +0000 (22:45 +0100)]
Remove direct GTK struct member access from pdf_viewer plugin.

2 years agoRemove the last offender against -DGTK_DISABLE_SINGLE_INCLUDES
Andrej Kacian [Tue, 6 Feb 2018 21:07:47 +0000 (22:07 +0100)]
Remove the last offender against -DGTK_DISABLE_SINGLE_INCLUDES

2 years agoGet rid of final direct GTK struct member access from ClawsSpellEntry.
Andrej Kacian [Tue, 6 Feb 2018 20:27:18 +0000 (21:27 +0100)]
Get rid of final direct GTK struct member access from ClawsSpellEntry.

We have to track preedit_length internally, because this
bit of GtkEntry is not available anymore.

2 years agoClawsSpellEntry does not need to implement GtkEditable
Andrej Kacian [Tue, 6 Feb 2018 20:05:25 +0000 (21:05 +0100)]
ClawsSpellEntry does not need to implement GtkEditable

We're "subclassing" GtkEntry, which already implements it.

2 years agoReplace gtk_style_unref()
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:32 +0000 (20:12 +0100)]
Replace gtk_style_unref()

gtk_style_unref() is a remnant from gtk+1 and the compatibility function
in gtk+2 is gone in gtk+3, use g_object_unref() instead.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoAdd missing header to acpi_notifier
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:31 +0000 (20:12 +0100)]
Add missing header to acpi_notifier

When building against gtk+3 the compiler complains about implicit
function declaration, so include the required header for using the
gtk_cmoption_menu.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoDrop no longer used gtk+2 utility functions
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:29 +0000 (20:12 +0100)]
Drop no longer used gtk+2 utility functions

With requiring gtk+2 >=2.24 the following functions are obsolete:
  gtkut_widget_set_mapped
  gtkut_widget_set_realized
  gtkut_widget_set_can_default
  gtkut_widget_set_receives_default
  gtkut_widget_set_can_focus
  gtkut_widget_set_has_window

Replace all occurrences with the underlying function.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoDrop ifdefs for old gtk+2
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:28 +0000 (20:12 +0100)]
Drop ifdefs for old gtk+2

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoRequire gtk+ >= 2.24
Ralph Sennhauser [Wed, 8 Nov 2017 19:12:27 +0000 (20:12 +0100)]
Require gtk+ >= 2.24

gtk+-2.24.0 was released 2011-01-30 and has seen over 30 maintenance
releases since. Drop support for gtk+2 < 2.24 to ease porting to gtk+3
and to cleanup existing compatibility code for old gtk+2 releases.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2 years agoA few instances of combobox manipulation still used the old API.
Andrej Kacian [Tue, 6 Feb 2018 13:25:01 +0000 (14:25 +0100)]
A few instances of combobox manipulation still used the old API.

Patch by Ralph Sennhauser.

2 years agoRemoved almost all direct GTK struct member accesses.
Andrej Kacian [Tue, 6 Feb 2018 10:19:21 +0000 (11:19 +0100)]
Removed almost all direct GTK struct member accesses.

Use accessor functions instead.

The few remaining offenders are in spell_entry.c, which
will require some rework.

2 years agoReplaced some deprecated GTK+ API calls in gtkaspell.c.
Andrej Kacian [Mon, 5 Feb 2018 22:59:38 +0000 (23:59 +0100)]
Replaced some deprecated GTK+ API calls in gtkaspell.c.

2 years agoFix some copyright headers
Ricardo Mones [Mon, 5 Feb 2018 20:44:15 +0000 (21:44 +0100)]
Fix some copyright headers

2 years agoRefactor colors handling with more arrays
Ricardo Mones [Mon, 5 Feb 2018 20:15:42 +0000 (21:15 +0100)]
Refactor colors handling with more arrays

This also makes possible to add more colors easily.

2 years agoMove all colors into an array
Ricardo Mones [Mon, 5 Feb 2018 20:12:55 +0000 (21:12 +0100)]
Move all colors into an array

2 years agoRSSyl: Handle 404 and other fetch failures better.
Andrej Kacian [Wed, 31 Jan 2018 18:57:07 +0000 (19:57 +0100)]
RSSyl: Handle 404 and other fetch failures better.

2 years agoMove syntax help after entry
Ricardo Mones [Mon, 22 Jan 2018 23:24:36 +0000 (00:24 +0100)]
Move syntax help after entry

2 years agoRemove more unnecessary colons in labels
Ricardo Mones [Mon, 22 Jan 2018 22:45:20 +0000 (23:45 +0100)]
Remove more unnecessary colons in labels

2 years agoUse spacing more uniformly on themes prefs
Ricardo Mones [Mon, 22 Jan 2018 22:16:03 +0000 (23:16 +0100)]
Use spacing more uniformly on themes prefs

Also remove colons from labels (not used in other places), and align
them to the right, to be visually consistent with other preference
pages.

2 years agoFix wrong article in translated string
Ricardo Mones [Sun, 21 Jan 2018 09:34:52 +0000 (10:34 +0100)]
Fix wrong article in translated string

2 years agoDo not consider missing passwordstorerc file as error.
Andrej Kacian [Sat, 20 Jan 2018 13:36:38 +0000 (14:36 +0100)]
Do not consider missing passwordstorerc file as error.

Just continue with empty password store.

2 years agoPrune more gtk_widget_set_size_request calls
Ricardo Mones [Sat, 20 Jan 2018 13:10:39 +0000 (14:10 +0100)]
Prune more gtk_widget_set_size_request calls

2 years agoHandle password store config_version update without the global gint variable.
Andrej Kacian [Fri, 19 Jan 2018 18:16:44 +0000 (19:16 +0100)]
Handle password store config_version update without the global gint variable.

2 years agoHandle failed/aborted folderlist config_version update in main.c
Andrej Kacian [Fri, 19 Jan 2018 18:02:59 +0000 (19:02 +0100)]
Handle failed/aborted folderlist config_version update in main.c

2 years agoImplement config_version in folderlist.xml.
Andrej Kacian [Fri, 19 Jan 2018 17:56:52 +0000 (18:56 +0100)]
Implement config_version in folderlist.xml.

2 years agoNo need to set window's position twice
Ricardo Mones [Fri, 19 Jan 2018 11:53:26 +0000 (12:53 +0100)]
No need to set window's position twice

It's already set on line 200 :-)

2 years agoImplement config_version in passwordstorerc.
Andrej Kacian [Thu, 18 Jan 2018 20:53:18 +0000 (21:53 +0100)]
Implement config_version in passwordstorerc.

2 years agoDo not consider "mark_as_spam" as a final action, since it does not move the marked...
Andrej Kacian [Thu, 18 Jan 2018 20:13:46 +0000 (21:13 +0100)]
Do not consider "mark_as_spam" as a final action, since it does not move the marked message.

Fixes Bug 3919 - manual filtering does not move spam

2 years agofix bug where actionsrc was not updated after mailbox name change
Paul [Thu, 18 Jan 2018 11:05:18 +0000 (11:05 +0000)]
fix bug where actionsrc was not updated after mailbox name change

2 years agoAdd "Go to last error" to log window context menu
Ricardo Mones [Sun, 14 Jan 2018 15:26:44 +0000 (16:26 +0100)]
Add "Go to last error" to log window context menu

This functionality was already implemented, this only makes it
available to the user through a new menu option.

2 years agofix bug 3947, 'Build break with --disable-libsm --enable-crash-dialog'
Paul [Tue, 9 Jan 2018 12:33:05 +0000 (12:33 +0000)]
fix bug 3947, 'Build break with --disable-libsm --enable-crash-dialog'