Fix bug #3796 format-security warnings in alertpanel_ use

This patch fixes format-security warnings in alertpanel_ use by passing
"%s" as string and the buffer as va argument if no other va arguments
are present.

diff --git a/src/compose.c b/src/compose.c
index 4a29775d4c257da93882fca6938a1cf0ccf2a716..b7a7f76489369b8498f0f88bc7dafa50ef295944 100644 (file)
--- a/src/compose.c
+++ b/src/compose.c
@@ -8792,7 +8792,7 @@ static void compose_template_apply_fields_error(const gchar *header)
        tr = g_strdup(C_("'%s' stands for a header name",
                                  "Template '%s' format error."));
        text = g_strdup_printf(tr, prefs_common_translated_header_name(header));
-       alertpanel_error(text);
+       alertpanel_error("%s", text);
 
        g_free(text);
        g_free(tr);

diff --git a/src/mimeview.c b/src/mimeview.c
index 305b5e57950bafbc10e56073a62b64fd0958fa4e..3ffdd180d098fc025e29825e830afbdeb15443fc 100644 (file)
--- a/src/mimeview.c
+++ b/src/mimeview.c
@@ -1879,7 +1879,7 @@ static void mimeview_save_all_info(gint errors, gint total)
                                        "%d files saved successfully.",
                                        total),
                                total);
-               alertpanel_notice(msg);
+               alertpanel_notice("%s", msg);
                g_free(msg);
        } else {
                gchar *msg1 = g_strdup_printf(
@@ -1892,7 +1892,7 @@ static void mimeview_save_all_info(gint errors, gint total)
                                        "%s, %d files failed.",
                                        errors),
                                msg1, errors);
-               alertpanel_warning(msg2);
+               alertpanel_warning("%s", msg2);
                g_free(msg2);
                g_free(msg1);
        }

diff --git a/src/plugins/archive/archiver_gtk.c b/src/plugins/archive/archiver_gtk.c
index 19a842d12a890efc7121de187a1e29191a393fd4..ca74c3b9446e3a4465f80e90cae8ffd8c162616c 100644 (file)
--- a/src/plugins/archive/archiver_gtk.c
+++ b/src/plugins/archive/archiver_gtk.c
@@ -576,7 +576,7 @@ static gboolean archiver_save_files(struct ArchivePage* page) {
                        if (aval != G_ALERTALTERNATE)
                                return FALSE;
                } else {
-                       alertpanel_error(msg);
+                       alertpanel_error("%s", msg);
                        g_free(msg);
                        return FALSE;
                }