}
#ifndef GENERIC_UMPC
else if( cw->listCount == 2 ) {
- gtk_tree_model_iter_next(GTK_TREE_MODEL(store), &iter);
- /* Move off first row */
- gtk_tree_selection_select_iter(selection, &iter);
+ if (gtk_tree_model_iter_next(GTK_TREE_MODEL(store), &iter)) {
+ /* Move off first row */
+ gtk_tree_selection_select_iter(selection, &iter);
+ }
}
#endif
}
}
folder = addressbook_setup_subf( ds, _("New Contacts"), parentNode );
- pobj = gtk_cmctree_node_get_row_data(GTK_CMCTREE(addrbook.ctree), addrbook.treeSelected);
ds = addressbook_find_datasource( GTK_CMCTREE_NODE(addrbook.treeSelected) );
if (ds)
abf = ds->rawDataSource;
else
return (guint)-1;
+ if (fp == NULL)
+ return (guint)-1;
+
if ((r = gnutls_import_X509_list_fp(fp, GNUTLS_X509_FMT_PEM, &ca_list, &max_ca)) < 0) {
debug_print("CA import failed: %s\n", gnutls_strerror(r));
fclose(fp);
address = gtk_editable_get_chars(GTK_EDITABLE(basic_page.addr_entry), 0, -1);
- if (strchr(address, '@') < 0) {
+ if (strchr(address, '@') == NULL) {
g_free(address);
gtk_label_set_text(GTK_LABEL(basic_page.auto_configure_lbl),
_("Failed (wrong address)"));
pref_get_unescaped_pref(out, txt);
- gtk_text_buffer_set_text(buffer, out?out:"", -1);
+ gtk_text_buffer_set_text(buffer, out, -1);
g_free(out);
}
}
pref_get_unescaped_pref(out, txt);
- gtk_entry_set_text(entry, out?out:"");
+ gtk_entry_set_text(entry, out);
g_free(out);
}
}
gtk_entry_set_text(GTK_ENTRY(filtering.cond_entry), matcher_str);
action_str = filteringaction_list_to_string(prop->action_list);
- if (matcher_str == NULL) {
- return;
- }
- gtk_entry_set_text(GTK_ENTRY(filtering.action_entry), action_str);
+ if (action_str != NULL)
+ gtk_entry_set_text(GTK_ENTRY(filtering.action_entry), action_str);
g_free(action_str);
g_free(matcher_str);
if (line[len - 1] == '\n') line[len - 1] = '\0'; \
} \
else { \
- strcpy(line, _("Unknown")); \
+ g_strlcpy(line, _("Unknown"),sizeof(line)); \
}
static void prefs_themes_get_theme_info(ThemesData *tdata)
GdkEventButton *event,
ToolbarPage *prefs_toolbar )
{
- static guint id = -1;
- if (id >= 0) {
+ static guint id = 0;
+ if (id > 0) {
g_source_remove(id);
- id = -1;
+ id = 0;
}
id = g_timeout_add(100, ok_cb, prefs_toolbar);
return FALSE;
attr_color = (PangoAttrColor*) attr;
g_object_get(G_OBJECT(tag), "background-gdk",
&color, NULL);
- if (printing_is_pango_gdk_color_equal(&(attr_color->color),
+ if (color &&
+ printing_is_pango_gdk_color_equal(&(attr_color->color),
color)) {
attr->end_index = printing_text_iter_get_offset_bytes(print_data, &iter);
pango_attr_list_insert(attr_list, attr);
if (visible == NULL)
maxsize = 0;
}
-
- visible[stacksize - 1] = val;
+ if (visible != NULL)
+ visible[stacksize - 1] = val;
}
static void remove_visibility(void)
* because it's editable. */
fp_pos = ftell(fp);
+ if (fp_pos < 0) {
+ perror("ftell");
+ return -1;
+ }
tmp_msginfo = procheader_parse_stream(fp, flags, TRUE, FALSE);
fseek(fp, fp_pos, SEEK_SET);
END_TIMING();
return;
}
- fseek(fp, mimeinfo->offset, SEEK_SET);
+ if (fseek(fp, mimeinfo->offset, SEEK_SET) < 0) {
+ FILE_OP_ERROR(mimeinfo->data.filename, "fseek");
+ fclose(fp);
+ END_TIMING();
+ return;
+ }
headers = textview_scan_header(textview, fp);
if (headers) {
if (charcount > 0)
filename = procmime_get_tmp_file_name(mimeinfo);
if (procmime_get_part(filename, mimeinfo) == 0) {
tmpfp = g_fopen(filename, "rb");
- textview_show_ertf(textview, tmpfp, conv);
- fclose(tmpfp);
+ if (tmpfp) {
+ textview_show_ertf(textview, tmpfp, conv);
+ fclose(tmpfp);
+ }
claws_unlink(filename);
}
g_free(filename);
FILE_OP_ERROR(mimeinfo->data.filename, "fopen");
return;
}
- fseek(tmpfp, mimeinfo->offset, SEEK_SET);
+ if (fseek(tmpfp, mimeinfo->offset, SEEK_SET) < 0) {
+ FILE_OP_ERROR(mimeinfo->data.filename, "fseek");
+ fclose(tmpfp);
+ return;
+ }
debug_print("Viewing text content of type: %s (length: %d)\n", mimeinfo->subtype, mimeinfo->length);
while (((i = ftell(tmpfp)) < mimeinfo->offset + mimeinfo->length) &&
(fgets(buf, sizeof(buf), tmpfp) != NULL)
static gint textview_key_pressed(GtkWidget *widget, GdkEventKey *event,
TextView *textview)
{
- GdkWindow *window;
+ GdkWindow *window = NULL;
SummaryView *summaryview = NULL;
MessageView *messageview = textview->messageview;
summary_pass_key_press_event(summaryview, event);
break;
default:
- window = gtk_widget_get_window(messageview->mainwin->window);
- if (summaryview &&
- event->window != window) {
- GdkEventKey tmpev = *event;
-
- tmpev.window = window;
- KEY_PRESS_EVENT_STOP();
- gtk_widget_event(messageview->mainwin->window,
- (GdkEvent *)&tmpev);
+ if (messageview->mainwin) {
+ window = gtk_widget_get_window(messageview->mainwin->window);
+ if (summaryview &&
+ event->window != window) {
+ GdkEventKey tmpev = *event;
+
+ tmpev.window = window;
+ KEY_PRESS_EVENT_STOP();
+ gtk_widget_event(messageview->mainwin->window,
+ (GdkEvent *)&tmpev);
+ }
}
break;
}