Fix leak on error and error reporting
authorRicardo Mones <ricardo@mones.org>
Fri, 19 Feb 2016 18:23:00 +0000 (19:23 +0100)
committerRicardo Mones <ricardo@mones.org>
Fri, 19 Feb 2016 18:23:00 +0000 (19:23 +0100)
src/plugins/pgpcore/pgp_utils.c

index 7174ec425a071dadde079ce8fccb700c779a52e9..66f8e9ba3602a3b24cd92b260762fbdf9249b08a 100644 (file)
@@ -76,12 +76,14 @@ gchar *get_part_as_string(MimeInfo *mimeinfo)
        else {
                filename = procmime_get_tmp_file_name(mimeinfo);
                if (procmime_get_part(filename, mimeinfo) < 0) {
-                       printf("error dumping file\n");
+                       g_warning("error dumping temporary file '%s'", filename);
+                       g_free(filename);
                        return NULL;
                }
                fp = g_fopen(filename,"rb");
                if (!fp) {
-                       printf("error reading file\n");
+                       g_warning("error opening temporary file '%s'", filename);
+                       g_free(filename);
                        return NULL;
                }
                textdata = fp_read_noconv(fp);