Use memset to initialize struct etpan_thread_op

also remove duplicated zeroing.

diff --git a/src/etpan/etpan-thread-manager.c b/src/etpan/etpan-thread-manager.c
index f72e8c7597470044f6a2694be725b2b616510c71..f73dbfe302a76d3f5205cf13fca38247a149207e 100644 (file)
--- a/src/etpan/etpan-thread-manager.c
+++ b/src/etpan/etpan-thread-manager.c
@@ -187,19 +187,8 @@ struct etpan_thread_op * etpan_thread_op_new(void)
   op = malloc(sizeof(* op));
   if (op == NULL)
     goto err;
-  
-  op->thread = NULL;
-  op->run = NULL;
-  op->callback = NULL;
-  op->callback_data = NULL;
-  op->callback_called = 0;
-  op->cancellable = 0;
-  op->cancelled = 0;
-  op->param = NULL;
-  op->result = NULL;
-  op->finished = 0;
-  op->imap = NULL;
-  op->nntp = NULL;
+
+  memset(op, 0, sizeof(* op));
 
   r = pthread_mutex_init(&op->lock, NULL);
   if (r != 0)

diff --git a/src/etpan/imap-thread.c b/src/etpan/imap-thread.c
index 4998e33af9617fccf881f16fc605738bd54fdae7..5f79cdb00d789d9767b372f460d5f68ba321f2b1 100644 (file)
--- a/src/etpan/imap-thread.c
+++ b/src/etpan/imap-thread.c
@@ -416,14 +416,10 @@ static int threaded_run(Folder * folder, void * param, void * result,
        op->param = param;
        op->result = result;
        
-       op->cancellable = 0;
        op->run = func;
        op->callback = generic_cb;
        op->callback_data = op;
-       op->cleanup = NULL;
-       
-       op->finished = 0;
-       
+
        thread = get_thread(folder);
        etpan_thread_op_schedule(thread, op);
        

diff --git a/src/etpan/nntp-thread.c b/src/etpan/nntp-thread.c
index ac5d2100ec2ece0c1647d61768ea1cdc3b51ecac..c20802867cda87da09371defbd3b176a95f35756 100644 (file)
--- a/src/etpan/nntp-thread.c
+++ b/src/etpan/nntp-thread.c
@@ -277,14 +277,10 @@ static void threaded_run(Folder * folder, void * param, void * result,
        op->nntp = get_nntp(folder);
        op->param = param;
        op->result = result;
-       
-       op->cancellable = 0;
+
        op->run = func;
        op->callback = generic_cb;
        op->callback_data = op;
-       op->cleanup = NULL;
-       
-       op->finished = 0;
        
        previous_stream_logger = mailstream_logger;
        mailstream_logger = nntp_logger;