2006-08-16 [colin] 2.4.0cvs54
[claws.git] / src / toolbar.c
index 90c460450a07ac324ed5f961fe588b2f448d52ad..c078c8f34e8d6e75d65479f80a9bcb5355cbcd3d 100644 (file)
@@ -176,8 +176,7 @@ struct {
        { "A_GOTO_NEXT",        N_("Go to Next Unread Message")            },
        { "A_IGNORE_THREAD",    N_("Ignore thread")                        },
        { "A_PRINT",            N_("Print")                                },
-       { "A_LEARN_SPAM",       N_("Learn Spam")                           },
-       { "A_LEARN_HAM",        N_("Learn Ham")                            },
+       { "A_LEARN_SPAM",       N_("Learn Spam or Ham")                    },
 
        { "A_SEND",             N_("Send Message")                         },
        { "A_SENDL",            N_("Put into queue folder and send later") },
@@ -390,7 +389,8 @@ static void toolbar_set_default_main(void)
                { A_RECEIVE_ALL,   STOCK_PIXMAP_MAIL_RECEIVE_ALL,     _("Get Mail") },
                { A_SEPARATOR,     0,                                 ("")         }, 
                { A_SEND_QUEUED,   STOCK_PIXMAP_MAIL_SEND_QUEUE,      _("Send")    },
-               { A_COMPOSE_EMAIL, STOCK_PIXMAP_MAIL_COMPOSE,         _("Compose") },
+               { A_COMPOSE_EMAIL, STOCK_PIXMAP_MAIL_COMPOSE,
+                       (gchar*)Q_("Toolbar|Compose") },
                { A_SEPARATOR,     0,                                 ("")         },
                { A_REPLY_MESSAGE, STOCK_PIXMAP_MAIL_REPLY,           _("Reply")   }, 
                { A_REPLY_ALL,     STOCK_PIXMAP_MAIL_REPLY_TO_ALL,    _("All")     },
@@ -654,10 +654,8 @@ void toolbar_clear_list(ToolbarType source)
                toolbar_config[source].item_list = 
                        g_slist_remove(toolbar_config[source].item_list, item);
 
-               if (item->file)
-                       g_free(item->file);
-               if (item->text)
-                       g_free(item->text);
+               g_free(item->file);
+               g_free(item->text);
                g_free(item);   
        }
        g_slist_free(toolbar_config[source].item_list);
@@ -1129,7 +1127,15 @@ static void toolbar_prev_unread_cb(GtkWidget *widget, gpointer data)
                
        case TOOLBAR_MSGVIEW:
                msgview = (MessageView*)toolbar_item->parent;
+               msgview->updating = TRUE;
                summary_select_prev_unread(msgview->mainwin->summaryview);
+               msgview->updating = FALSE;
+
+               if (msgview->deferred_destroy) {
+                       debug_print("messageview got away!\n");
+                       messageview_destroy(msgview);
+                       return;
+               }
                
                /* Now we need to update the messageview window */
                if (msgview->mainwin->summaryview->selected) {
@@ -1168,8 +1174,16 @@ static void toolbar_next_unread_cb(GtkWidget *widget, gpointer data)
                
        case TOOLBAR_MSGVIEW:
                msgview = (MessageView*)toolbar_item->parent;
+               msgview->updating = TRUE;
                summary_select_next_unread(msgview->mainwin->summaryview);
-               
+               msgview->updating = FALSE;
+
+               if (msgview->deferred_destroy) {
+                       debug_print("messageview got away!\n");
+                       messageview_destroy(msgview);
+                       return;
+               }
+
                /* Now we need to update the messageview window */
                if (msgview->mainwin->summaryview->selected) {
                        GtkCTree *ctree = GTK_CTREE(msgview->mainwin->summaryview->ctree);
@@ -1367,7 +1381,6 @@ static void toolbar_buttons_cb(GtkWidget   *widget,
                { A_IGNORE_THREAD,      toolbar_ignore_thread_cb        },
                { A_PRINT,              toolbar_print_cb                },
                { A_LEARN_SPAM,         toolbar_learn_cb                },
-               { A_LEARN_HAM,          toolbar_learn_cb                },
 
                { A_SEND,               toolbar_send_cb                 },
                { A_SENDL,              toolbar_send_later_cb           },
@@ -1420,6 +1433,7 @@ Toolbar *toolbar_create(ToolbarType        type,
        ComboButton *replylist_combo;
        ComboButton *replysender_combo;
        ComboButton *fwd_combo;
+       ComboButton *compose_combo;
 
        GtkTooltips *toolbar_tips;
        ToolbarSylpheedActions *action_item;
@@ -1511,6 +1525,14 @@ Toolbar *toolbar_create(ToolbarType       type,
                        gtk_tooltips_set_tip(GTK_TOOLTIPS(toolbar_tips), 
                                             toolbar_data->compose_news_btn,
                                           _("Compose News"), NULL);
+                       compose_combo = gtkut_combo_button_create(toolbar_data->compose_mail_btn, NULL, 0,
+                                       "<Compose>", (gpointer)toolbar_item);
+                       gtk_button_set_relief(GTK_BUTTON(compose_combo->arrow),
+                                             GTK_RELIEF_NONE);
+                       gtk_toolbar_append_widget(GTK_TOOLBAR(toolbar),
+                                                 GTK_WIDGET_PTR(compose_combo),
+                                                 _("Compose with selected Account"), "Compose");
+                       toolbar_data->compose_combo = compose_combo;
                        break;
                case A_LEARN_SPAM:
                        icon_ham = stock_pixmap_widget(container, STOCK_PIXMAP_HAM_BTN);
@@ -1816,6 +1838,15 @@ void toolbar_update(ToolbarType type, gpointer data)
        }
 }
 
+#define GTK_BUTTON_SET_SENSITIVE(widget,sensitive) {           \
+       gboolean in_btn = FALSE;                                \
+       if (GTK_IS_BUTTON(widget))                              \
+               in_btn = GTK_BUTTON(widget)->in_button;         \
+       gtk_widget_set_sensitive(widget, sensitive);            \
+       if (GTK_IS_BUTTON(widget))                              \
+               GTK_BUTTON(widget)->in_button = in_btn;         \
+}
+
 void toolbar_main_set_sensitive(gpointer data)
 {
        SensitiveCond state;
@@ -1840,39 +1871,61 @@ void toolbar_main_set_sensitive(gpointer data)
        entry_list = g_slist_append(entry_list, e); \
 }
 
-       SET_WIDGET_COND(toolbar->get_btn, M_HAVE_ACCOUNT|M_UNLOCKED);
-       SET_WIDGET_COND(toolbar->getall_btn, M_HAVE_ACCOUNT|M_UNLOCKED);
-       if (toolbar->getall_btn)
+       
+       if (toolbar->get_btn)
+               SET_WIDGET_COND(toolbar->get_btn, 
+                       M_HAVE_ACCOUNT|M_UNLOCKED);
+
+       if (toolbar->getall_btn) {
+               SET_WIDGET_COND(toolbar->getall_btn, 
+                       M_HAVE_ACCOUNT|M_UNLOCKED);
                SET_WIDGET_COND(GTK_WIDGET_PTR(toolbar->getall_combo),
                        M_HAVE_ACCOUNT|M_UNLOCKED);
-       SET_WIDGET_COND(toolbar->compose_news_btn, M_HAVE_ACCOUNT);
-       SET_WIDGET_COND(toolbar->reply_btn,
-                       M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST);
-       if (toolbar->reply_btn)
+       }
+       if (toolbar->send_btn) {
+               SET_WIDGET_COND(toolbar->send_btn,
+                       M_HAVE_QUEUED_MAILS);
+       }
+       if (toolbar->compose_mail_btn) {
+               SET_WIDGET_COND(GTK_WIDGET_PTR(toolbar->compose_combo),
+                       M_HAVE_ACCOUNT);
+               SET_WIDGET_COND(toolbar->compose_news_btn, 
+                       M_HAVE_ACCOUNT);
+       }
+       if (toolbar->reply_btn) {
+               SET_WIDGET_COND(toolbar->reply_btn,
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
                SET_WIDGET_COND(GTK_WIDGET_PTR(toolbar->reply_combo),
-                       M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST);
-       SET_WIDGET_COND(toolbar->replyall_btn,
-                       M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST);
-       if (toolbar->replyall_btn)
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
+       }
+       if (toolbar->replyall_btn) {
+               SET_WIDGET_COND(toolbar->replyall_btn,
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
                SET_WIDGET_COND(GTK_WIDGET_PTR(toolbar->replyall_combo),
-                       M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST);
-       SET_WIDGET_COND(toolbar->replylist_btn,
-                       M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST);
-       if (toolbar->replylist_btn) 
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
+       }
+       if (toolbar->replylist_btn) {
+               SET_WIDGET_COND(toolbar->replylist_btn,
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
                SET_WIDGET_COND(GTK_WIDGET_PTR(toolbar->replylist_combo),
-                       M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST);
-       SET_WIDGET_COND(toolbar->replysender_btn,
-                       M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST);
-       if (toolbar->replysender_btn)
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
+       }
+       if (toolbar->replysender_btn) {
+               SET_WIDGET_COND(toolbar->replysender_btn,
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
                SET_WIDGET_COND(GTK_WIDGET_PTR(toolbar->replysender_combo),
-                       M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST);
-       SET_WIDGET_COND(toolbar->fwd_btn, M_HAVE_ACCOUNT|M_TARGET_EXIST);
-       if (toolbar->fwd_btn)
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
+       }
+       if (toolbar->fwd_btn) {
+               SET_WIDGET_COND(toolbar->fwd_btn, 
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST);
                SET_WIDGET_COND(GTK_WIDGET_PTR(toolbar->fwd_combo),
                        M_HAVE_ACCOUNT|M_TARGET_EXIST); 
+       }
        if (toolbar->fwd_combo) {
                GtkWidget *submenu = gtk_item_factory_get_widget(toolbar->fwd_combo->factory, "/Redirect");
-               SET_WIDGET_COND(submenu, M_HAVE_ACCOUNT|M_SINGLE_TARGET_EXIST); 
+               SET_WIDGET_COND(submenu, 
+                       M_HAVE_ACCOUNT|M_TARGET_EXIST); 
        }
 
        if (prefs_common.next_unread_msg_dialog == NEXTUNREADMSGDIALOG_ASSUME_NO) {
@@ -1884,16 +1937,22 @@ void toolbar_main_set_sensitive(gpointer data)
        if (toolbar->trash_btn)
                SET_WIDGET_COND(toolbar->trash_btn,
                        M_TARGET_EXIST|M_ALLOW_DELETE);
+
        if (toolbar->delete_btn)
                SET_WIDGET_COND(toolbar->delete_btn,
                        M_TARGET_EXIST|M_ALLOW_DELETE);
+
        if (toolbar->exec_btn)
-               SET_WIDGET_COND(toolbar->exec_btn, M_DELAY_EXEC);
+               SET_WIDGET_COND(toolbar->exec_btn, 
+                       M_DELAY_EXEC);
        
        if (toolbar->learn_ham_btn)
-               SET_WIDGET_COND(toolbar->learn_ham_btn, M_TARGET_EXIST|M_CAN_LEARN_SPAM);
+               SET_WIDGET_COND(toolbar->learn_ham_btn,
+                       M_TARGET_EXIST|M_CAN_LEARN_SPAM);
+
        if (toolbar->learn_spam_btn)
-               SET_WIDGET_COND(toolbar->learn_spam_btn, M_TARGET_EXIST|M_CAN_LEARN_SPAM);
+               SET_WIDGET_COND(toolbar->learn_spam_btn, 
+                       M_TARGET_EXIST|M_CAN_LEARN_SPAM);
 
        for (cur = toolbar->action_list; cur != NULL;  cur = cur->next) {
                ToolbarSylpheedActions *act = (ToolbarSylpheedActions*)cur->data;
@@ -1910,15 +1969,14 @@ void toolbar_main_set_sensitive(gpointer data)
 
                if (e->widget != NULL) {
                        sensitive = ((e->cond & state) == e->cond);
-                       gtk_widget_set_sensitive(e->widget, sensitive); 
+                       GTK_BUTTON_SET_SENSITIVE(e->widget, sensitive); 
                }
        }
        
        while (entry_list != NULL) {
                Entry *e = (Entry*) entry_list->data;
 
-               if (e)
-                       g_free(e);
+               g_free(e);
                entry_list = g_slist_remove(entry_list, e);
        }
 
@@ -1927,6 +1985,7 @@ void toolbar_main_set_sensitive(gpointer data)
        activate_compose_button(toolbar, 
                                prefs_common.toolbar_style,
                                toolbar->compose_btn_type);
+       
 }
 
 void toolbar_comp_set_sensitive(gpointer data, gboolean sensitive)
@@ -1935,32 +1994,32 @@ void toolbar_comp_set_sensitive(gpointer data, gboolean sensitive)
        GSList *items = compose->toolbar->action_list;
 
        if (compose->toolbar->send_btn)
-               gtk_widget_set_sensitive(compose->toolbar->send_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->send_btn, sensitive);
        if (compose->toolbar->sendl_btn)
-               gtk_widget_set_sensitive(compose->toolbar->sendl_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->sendl_btn, sensitive);
        if (compose->toolbar->draft_btn )
-               gtk_widget_set_sensitive(compose->toolbar->draft_btn , sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->draft_btn , sensitive);
        if (compose->toolbar->insert_btn )
-               gtk_widget_set_sensitive(compose->toolbar->insert_btn , sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->insert_btn , sensitive);
        if (compose->toolbar->attach_btn)
-               gtk_widget_set_sensitive(compose->toolbar->attach_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->attach_btn, sensitive);
        if (compose->toolbar->sig_btn)
-               gtk_widget_set_sensitive(compose->toolbar->sig_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->sig_btn, sensitive);
        if (compose->toolbar->exteditor_btn)
-               gtk_widget_set_sensitive(compose->toolbar->exteditor_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->exteditor_btn, sensitive);
        if (compose->toolbar->linewrap_current_btn)
-               gtk_widget_set_sensitive(compose->toolbar->linewrap_current_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->linewrap_current_btn, sensitive);
        if (compose->toolbar->linewrap_all_btn)
-               gtk_widget_set_sensitive(compose->toolbar->linewrap_all_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->linewrap_all_btn, sensitive);
        if (compose->toolbar->addrbook_btn)
-               gtk_widget_set_sensitive(compose->toolbar->addrbook_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->addrbook_btn, sensitive);
 #ifdef USE_ASPELL
        if (compose->toolbar->spellcheck_btn)
-               gtk_widget_set_sensitive(compose->toolbar->spellcheck_btn, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->spellcheck_btn, sensitive);
 #endif
        for (; items != NULL; items = g_slist_next(items)) {
                ToolbarSylpheedActions *item = (ToolbarSylpheedActions *)items->data;
-               gtk_widget_set_sensitive(item->widget, sensitive);
+               GTK_BUTTON_SET_SENSITIVE(item->widget, sensitive);
        }
 }
 
@@ -1976,6 +2035,7 @@ void toolbar_init(Toolbar * toolbar) {
        toolbar->send_btn               = NULL;
        toolbar->compose_mail_btn       = NULL;
        toolbar->compose_news_btn       = NULL;
+       toolbar->compose_combo          = NULL;
        toolbar->reply_btn              = NULL;
        toolbar->replysender_btn        = NULL;
        toolbar->replyall_btn           = NULL;
@@ -2059,6 +2119,8 @@ void send_queue_cb(gpointer data, guint action, GtkWidget *widget)
 {
        GList *list;
        gboolean found;
+       gboolean got_error = FALSE;
+       gchar *errstr = NULL;
 
        if (prefs_common.work_offline)
                if (alertpanel(_("Offline warning"), 
@@ -2094,9 +2156,21 @@ void send_queue_cb(gpointer data, guint action, GtkWidget *widget)
 
                if (folder->queue) {
                        if (procmsg_send_queue(folder->queue, 
-                                              prefs_common.savemsg) < 0)
-                               alertpanel_error(_("Some errors occurred while "
-                                                  "sending queued messages."));
+                                              prefs_common.savemsg,
+                                              &errstr) < 0)
+                               got_error = TRUE;
+               }
+       }
+       if (got_error) {
+               if (!errstr)
+                       alertpanel_error_log(_("Some errors occurred while "
+                                          "sending queued messages."));
+               else {
+                       gchar *tmp = g_strdup_printf(_("Some errors occurred "
+                                       "while sending queued messages:\n%s"), errstr);
+                       g_free(errstr);
+                       alertpanel_error_log(tmp);
+                       g_free(tmp);
                }
        }
 }