Fix possibly broken toolbar_compose.xml by migrating A_SENDL actions names
[claws.git] / src / toolbar.c
index eddf724e7a576c8e729beaafea74f6d626bb9eab..1f36f71782023d3c53465b6cb0503d286f94ff99 100644 (file)
@@ -60,7 +60,7 @@
 #include "imap.h"
 #include "account.h"
 #include "send_message.h"
-#ifndef USE_NEW_ADDRBOOK
+#ifndef USE_ALT_ADDRBOOK
        #include "addressbook.h"
 #else
        #include "addressbook-dbus.h"
@@ -79,7 +79,7 @@ static void toolbar_init(Toolbar * toolbar);
 static gboolean      toolbar_is_duplicate              (gint           action,
                                                 ToolbarType    source);
 static void   toolbar_parse_item               (XMLFile        *file,
-                                                ToolbarType    source);
+                                                ToolbarType    source, gboolean *rewrite);
 
 static gint   toolbar_ret_val_from_text                (const gchar    *text);
 static gchar *toolbar_ret_text_from_val                (gint           val);
@@ -139,6 +139,30 @@ static void toolbar_ignore_thread_cb               (GtkWidget      *widget,
 static void toolbar_watch_thread_cb            (GtkWidget      *widget,
                                                 gpointer        data);
 
+static void toolbar_mark_cb            (GtkWidget      *widget,
+                                                gpointer        data);
+
+static void toolbar_unmark_cb          (GtkWidget      *widget,
+                                                gpointer        data);
+
+static void toolbar_lock_cb            (GtkWidget      *widget,
+                                                gpointer        data);
+
+static void toolbar_ulock_cb           (GtkWidget      *widget,
+                                                gpointer        data);
+
+static void toolbar_all_read_cb                (GtkWidget      *widget,
+                                                gpointer        data);
+
+static void toolbar_all_unread_cb              (GtkWidget      *widget,
+                                                gpointer        data);
+
+static void toolbar_read_cb            (GtkWidget      *widget,
+                                                gpointer        data);
+
+static void toolbar_unread_cb          (GtkWidget      *widget,
+                                                gpointer        data);
+
 static void toolbar_print_cb                   (GtkWidget      *widget,
                                                 gpointer        data);
 
@@ -205,19 +229,30 @@ struct {
        { "A_EXECUTE",          N_("Execute")                              },
        { "A_GOTO_PREV",        N_("Go to Previous Unread Message")        },
        { "A_GOTO_NEXT",        N_("Go to Next Unread Message")            },
+
        { "A_IGNORE_THREAD",    N_("Ignore thread")                        },
        { "A_WATCH_THREAD",     N_("Watch thread")                         },
+       { "A_MARK",                     N_("Mark Message")                         },
+       { "A_UNMARK",                   N_("Unmark Message")                       },
+       { "A_LOCK",                     N_("Lock Message")                         },
+       { "A_UNLOCK",                   N_("Unlock Message")                       },
+       { "A_ALL_READ",                 N_("Mark all Messages as read")            },
+       { "A_ALL_UNREAD",               N_("Mark all Messages as unread")          },
+       { "A_READ",                     N_("Mark Message as read")                 },
+       { "A_UNREAD",                   N_("Mark Message as unread")               },
+
        { "A_PRINT",            N_("Print")                                },
        { "A_LEARN_SPAM",       N_("Learn Spam or Ham")                    },
        { "A_GO_FOLDERS",       N_("Open folder/Go to folder list")        },
        { "A_PREFERENCES",      N_("Preferences")                          },
 
        { "A_SEND",             N_("Send Message")                         },
-       { "A_SENDL",            N_("Put into queue folder and send later") },
+       { "A_SEND_LATER",       N_("Put into queue folder and send later") },
        { "A_DRAFT",            N_("Save to draft folder")                 },
        { "A_INSERT",           N_("Insert file")                          },   
        { "A_ATTACH",           N_("Attach file")                          },
        { "A_SIG",              N_("Insert signature")                     },
+       { "A_REP_SIG",          N_("Replace signature")                    },
        { "A_EXTEDITOR",        N_("Edit with external editor")            },
        { "A_LINEWRAP_CURRENT", N_("Wrap long lines of current paragraph") }, 
        { "A_LINEWRAP_ALL",     N_("Wrap all long lines")                  }, 
@@ -231,9 +266,22 @@ struct {
        { "A_CANCEL_ALL",       N_("Cancel receiving/sending")             },
        { "A_CLOSE",            N_("Close window")                         },
        { "A_SEPARATOR",        N_("Separator")                            },
-       { "A_CLAWS_PLUGINS",    N_("Claws Mail Plugins")                   },
+       { "A_CLAWS_PLUGINS",    N_("Claws Mail Plugins")                   }
 };
 
+/* migration table: support reading toolbar configuration files with
+   old action names and converting them to current action names,
+   see toolbar_parse_item(), which makes uses of this alias table.
+*/
+struct {
+       const gchar *old_name;
+       const gchar *current_name;
+} toolbar_migration [] = {
+       { "A_SYL_ACTIONS",   "A_CLAWS_ACTIONS" },
+       { "A_SENDL",         "A_SEND_LATER" },
+       { NULL,              NULL }
+};
+       
 /* struct holds configuration files and a list of
  * currently active toolbar items 
  * TOOLBAR_MAIN, TOOLBAR_COMPOSE and TOOLBAR_MSGVIEW
@@ -242,7 +290,7 @@ struct {
 struct {
        const gchar  *conf_file;
        GSList       *item_list;
-} toolbar_config[3] = {
+} toolbar_config[NUM_TOOLBARS] = {
        { "toolbar_main.xml",    NULL},
        { "toolbar_compose.xml", NULL}, 
        { "toolbar_msgview.xml", NULL}
@@ -312,11 +360,14 @@ GList *toolbar_get_action_items(ToolbarType source)
        gint i = 0;
        
        if (source == TOOLBAR_MAIN) {
-               gint main_items[] = { A_RECEIVE_ALL,   A_RECEIVE_CUR,   A_SEND_QUEUED,
-                                       A_COMPOSE_EMAIL, A_REPLY_MESSAGE, A_REPLY_SENDER, 
-                                       A_REPLY_ALL,     A_REPLY_ML,      A_OPEN_MAIL,     A_FORWARD, 
-                                       A_TRASH,         A_DELETE_REAL,   A_EXECUTE,       A_GOTO_PREV, 
-                                       A_GOTO_NEXT,     A_IGNORE_THREAD, A_WATCH_THREAD,  A_PRINT,
+               gint main_items[] = {
+                                       A_RECEIVE_ALL,   A_RECEIVE_CUR,   A_SEND_QUEUED,
+                                       A_COMPOSE_EMAIL, A_REPLY_MESSAGE, A_REPLY_SENDER,
+                                       A_REPLY_ALL,     A_REPLY_ML,      A_OPEN_MAIL,     A_FORWARD,
+                                       A_TRASH,         A_DELETE_REAL,   A_EXECUTE,       A_GOTO_PREV,
+                                       A_GOTO_NEXT,     A_IGNORE_THREAD, A_WATCH_THREAD,  A_MARK,
+                                       A_UNMARK,        A_LOCK,          A_UNLOCK,        A_ALL_READ,
+                                       A_ALL_UNREAD,    A_READ,          A_UNREAD,          A_PRINT,
                                        A_ADDRBOOK,      A_LEARN_SPAM,    A_GO_FOLDERS, 
                                        A_CANCEL_INC,    A_CANCEL_SEND,   A_CANCEL_ALL,    A_PREFERENCES };
 
@@ -325,23 +376,25 @@ GList *toolbar_get_action_items(ToolbarType source)
                }       
        }
        else if (source == TOOLBAR_COMPOSE) {
-               gint comp_items[] =   { A_SEND,          A_SENDL,        A_DRAFT,
+               gint comp_items[] =   {
+                                       A_SEND,          A_SEND_LATER,   A_DRAFT,
                                        A_INSERT,        A_ATTACH,       A_SIG,
-                                       A_EXTEDITOR,     A_LINEWRAP_CURRENT,     
+                                       A_REP_SIG,       A_EXTEDITOR,    A_LINEWRAP_CURRENT,
                                        A_LINEWRAP_ALL,  A_ADDRBOOK,
 #ifdef USE_ENCHANT
-                                       A_CHECK_SPELLING, 
+                                       A_CHECK_SPELLING,
 #endif
-                                       A_CLOSE };      
+                                       A_CLOSE };
 
                for (i = 0; i < sizeof comp_items / sizeof comp_items[0]; i++) 
                        items = g_list_append(items, gettext(toolbar_text[comp_items[i]].descr));
        }
        else if (source == TOOLBAR_MSGVIEW) {
-               gint msgv_items[] =   { A_COMPOSE_EMAIL, A_REPLY_MESSAGE, A_REPLY_SENDER,
-                                       A_REPLY_ALL,     A_REPLY_ML,      A_FORWARD,
-                                       A_TRASH, A_DELETE_REAL,       A_GOTO_PREV,        A_GOTO_NEXT,
-                                       A_ADDRBOOK,      A_LEARN_SPAM, A_CLOSE };       
+               gint msgv_items[] =   {
+                                       A_COMPOSE_EMAIL, A_REPLY_MESSAGE, A_REPLY_SENDER,
+                                       A_REPLY_ALL,     A_REPLY_ML,      A_FORWARD,
+                                       A_TRASH,         A_DELETE_REAL,   A_GOTO_PREV,      A_GOTO_NEXT,
+                                       A_ADDRBOOK,      A_LEARN_SPAM,    A_CLOSE };
 
                for (i = 0; i < sizeof msgv_items / sizeof msgv_items[0]; i++) 
                        items = g_list_append(items, gettext(toolbar_text[msgv_items[i]].descr));
@@ -350,12 +403,11 @@ GList *toolbar_get_action_items(ToolbarType source)
        return items;
 }
 
-static void toolbar_parse_item(XMLFile *file, ToolbarType source)
+static void toolbar_parse_item(XMLFile *file, ToolbarType source, gboolean *rewrite)
 {
        GList *attr;
        gchar *name, *value;
        ToolbarItem *item = NULL;
-       gboolean rewrite = FALSE;
 
        attr = xml_get_current_tag_attr(file);
        item = g_new0(ToolbarItem, 1);
@@ -369,119 +421,157 @@ static void toolbar_parse_item(XMLFile *file, ToolbarType source)
                        item->text = g_strdup (*value ? gettext(value):"");
                else if (g_utf8_collate(name, TOOLBAR_ICON_ACTION) == 0)
                        item->index = toolbar_ret_val_from_text(value);
-               if (item->index == -1 && !strcmp(value, "A_DELETE")) {
+
+               if ((item->index == -1) && !strcmp(value, "A_DELETE")) {
                        /* switch button */
                        item->index = A_TRASH;
                        g_free(item->file);
                        item->file = g_strdup("trash_btn");
                        g_free(item->text);
                        item->text = g_strdup(C_("Toolbar", "Trash"));
-                       rewrite = TRUE;
+                       *rewrite = TRUE;
                }
-               if (item->index == -1 && !strcmp(value, "A_SYL_ACTIONS")) {
-                       /* switch button */
-                       item->index = A_CLAWS_ACTIONS;
-                       rewrite = TRUE;
+               if (item->index == -1) {
+                       /* item not found in table: try migrating old action names to current ones */
+                       gint i;
+
+                       /* replace action name */
+                       for (i = 0; toolbar_migration[i].old_name != NULL; i++) {
+                               if (g_utf8_collate(value, toolbar_migration[i].old_name) == 0) {
+                                       item->index = toolbar_ret_val_from_text(toolbar_migration[i].current_name);
+                                       if (item->index != -1) {
+                                               *rewrite = TRUE;
+                                               debug_print("toolbar_parse_item: migrating action label from '%s' to '%s'\n",
+                                                       value, toolbar_migration[i].current_name);
+                                               break;
+                                       }
+                               }
+                       }
                }
+               if ((item->index == -1) && !rewrite)
+                       g_warning("toolbar_parse_item: unrecognized action name '%s'\n", value);
+
                attr = g_list_next(attr);
        }
        if (item->index != -1) {
-               
                if (!toolbar_is_duplicate(item->index, source)) 
                        toolbar_config[source].item_list = g_slist_append(toolbar_config[source].item_list,
                                                                         item);
        }
-       if (rewrite) {
-               toolbar_save_config_file(source);
-       }
 }
 
 const gchar *toolbar_get_short_text(int action) {
        switch(action) {
-       case A_GO_FOLDERS:      return _("Folders");
-       case A_OPEN_MAIL:       return _("Open");
        case A_RECEIVE_ALL:     return _("Get Mail");
        case A_RECEIVE_CUR:     return _("Get");
        case A_SEND_QUEUED:     return _("Send");
        case A_COMPOSE_EMAIL:   return C_("Toolbar", "Compose");
        case A_COMPOSE_NEWS:    return C_("Toolbar", "Compose");
        case A_REPLY_MESSAGE:   return _("Reply");
-       case A_REPLY_ALL:       return _("All");
        case A_REPLY_SENDER:    return C_("Toolbar", "Sender");
+       case A_REPLY_ALL:       return _("All");
        case A_REPLY_ML:        return _("List");
+       case A_OPEN_MAIL:       return _("Open");
        case A_FORWARD:         return _("Forward");
        case A_TRASH:           return C_("Toolbar", "Trash");
        case A_DELETE_REAL:     return _("Delete");
-       case A_LEARN_SPAM:      return _("Spam");
+       case A_EXECUTE:         return _("Execute");
        case A_GOTO_PREV:       return _("Prev");
        case A_GOTO_NEXT:       return _("Next");
+
        case A_IGNORE_THREAD:   return _("Ignore thread");
        case A_WATCH_THREAD:    return _("Watch thread");
+       case A_MARK:            return _("Mark");
+       case A_UNMARK:          return _("Unmark");
+       case A_LOCK:            return _("Lock");
+       case A_UNLOCK:          return _("Unlock");
+       case A_ALL_READ:        return _("All read");
+       case A_ALL_UNREAD:      return _("All unread");
+       case A_READ:            return _("Read");
+       case A_UNREAD:          return _("Unread");
+
        case A_PRINT:           return _("Print");
-       case A_CLOSE:           return _("Close");
+       case A_LEARN_SPAM:      return _("Spam");
+       case A_GO_FOLDERS:      return _("Folders");
        case A_PREFERENCES:     return _("Preferences");
+
        case A_SEND:            return _("Send");
-       case A_SENDL:           return _("Send later");
+       case A_SEND_LATER:      return _("Send later");
        case A_DRAFT:           return _("Draft");
        case A_INSERT:          return _("Insert");
        case A_ATTACH:          return _("Attach");
        case A_SIG:             return _("Insert sig.");
+       case A_REP_SIG:         return _("Replace sig.");
        case A_EXTEDITOR:       return _("Edit");
        case A_LINEWRAP_CURRENT:return _("Wrap para.");
        case A_LINEWRAP_ALL:    return _("Wrap all");
        case A_ADDRBOOK:        return _("Address");
-       case A_CANCEL_INC:      return _("Stop");
-       case A_CANCEL_SEND:     return _("Stop");
-       case A_CANCEL_ALL:      return _("Stop all");
-       case A_EXECUTE:         return _("Execute");
        #ifdef USE_ENCHANT
        case A_CHECK_SPELLING:  return _("Check spelling");
        #endif
+
+       case A_CANCEL_INC:      return _("Stop");
+       case A_CANCEL_SEND:     return _("Stop");
+       case A_CANCEL_ALL:      return _("Stop all");
+       case A_CLOSE:           return _("Close");
        default:                return "";
        }
 }
 
 gint toolbar_get_icon(int action) {
        switch(action) {
-       case A_GO_FOLDERS:      return STOCK_PIXMAP_GO_FOLDERS;
-       case A_OPEN_MAIL:       return STOCK_PIXMAP_OPEN_MAIL;
        case A_RECEIVE_ALL:     return STOCK_PIXMAP_MAIL_RECEIVE_ALL;
        case A_RECEIVE_CUR:     return STOCK_PIXMAP_MAIL_RECEIVE;
        case A_SEND_QUEUED:     return STOCK_PIXMAP_MAIL_SEND_QUEUE;
        case A_COMPOSE_EMAIL:   return STOCK_PIXMAP_MAIL_COMPOSE;
        case A_COMPOSE_NEWS:    return STOCK_PIXMAP_NEWS_COMPOSE;
        case A_REPLY_MESSAGE:   return STOCK_PIXMAP_MAIL_REPLY;
-       case A_REPLY_ALL:       return STOCK_PIXMAP_MAIL_REPLY_TO_ALL;
        case A_REPLY_SENDER:    return STOCK_PIXMAP_MAIL_REPLY_TO_AUTHOR;
+       case A_REPLY_ALL:       return STOCK_PIXMAP_MAIL_REPLY_TO_ALL;
        case A_REPLY_ML:        return STOCK_PIXMAP_MAIL_REPLY_TO_LIST;
+       case A_OPEN_MAIL:       return STOCK_PIXMAP_OPEN_MAIL;
        case A_FORWARD:         return STOCK_PIXMAP_MAIL_FORWARD;
        case A_TRASH:           return STOCK_PIXMAP_TRASH;
        case A_DELETE_REAL:     return STOCK_PIXMAP_DELETE;
-       case A_LEARN_SPAM:      return STOCK_PIXMAP_SPAM_BTN;
+       case A_EXECUTE:         return STOCK_PIXMAP_EXEC;
        case A_GOTO_PREV:       return STOCK_PIXMAP_UP_ARROW;
        case A_GOTO_NEXT:       return STOCK_PIXMAP_DOWN_ARROW;
-       case A_IGNORE_THREAD:   return STOCK_PIXMAP_IGNORETHREAD;
-       case A_WATCH_THREAD:    return STOCK_PIXMAP_WATCHTHREAD;
+
+       case A_IGNORE_THREAD:   return STOCK_PIXMAP_MARK_IGNORETHREAD;
+       case A_WATCH_THREAD:    return STOCK_PIXMAP_MARK_WATCHTHREAD;
+       case A_MARK:            return STOCK_PIXMAP_MARK_MARK;
+       case A_UNMARK:          return STOCK_PIXMAP_MARK_UNMARK;
+       case A_LOCK:            return STOCK_PIXMAP_MARK_LOCKED;
+       case A_UNLOCK:          return STOCK_PIXMAP_MARK_UNLOCKED;
+       case A_ALL_READ:        return STOCK_PIXMAP_MARK_ALLREAD;
+       case A_ALL_UNREAD:      return STOCK_PIXMAP_MARK_ALLUNREAD;
+       case A_READ:            return STOCK_PIXMAP_MARK_READ;
+       case A_UNREAD:          return STOCK_PIXMAP_MARK_UNREAD;
+
        case A_PRINT:           return STOCK_PIXMAP_PRINTER;
-       case A_CLOSE:           return STOCK_PIXMAP_CLOSE;
+       case A_LEARN_SPAM:      return STOCK_PIXMAP_SPAM_BTN;
+       case A_GO_FOLDERS:      return STOCK_PIXMAP_GO_FOLDERS;
        case A_PREFERENCES:     return STOCK_PIXMAP_PREFERENCES;
+
        case A_SEND:            return STOCK_PIXMAP_MAIL_SEND;
-       case A_SENDL:           return STOCK_PIXMAP_MAIL_SEND_QUEUE;
+       case A_SEND_LATER:      return STOCK_PIXMAP_MAIL_SEND_QUEUE;
        case A_DRAFT:           return STOCK_PIXMAP_MAIL;
        case A_INSERT:          return STOCK_PIXMAP_INSERT_FILE;
        case A_ATTACH:          return STOCK_PIXMAP_MAIL_ATTACH;
        case A_SIG:             return STOCK_PIXMAP_MAIL_SIGN;
+       case A_REP_SIG:         return STOCK_PIXMAP_MAIL_SIGN;
        case A_EXTEDITOR:       return STOCK_PIXMAP_EDIT_EXTERN;
        case A_LINEWRAP_CURRENT:return STOCK_PIXMAP_LINEWRAP_CURRENT;
        case A_LINEWRAP_ALL:    return STOCK_PIXMAP_LINEWRAP_ALL;
        case A_ADDRBOOK:        return STOCK_PIXMAP_ADDRESS_BOOK;
-       case A_CANCEL_INC:      return STOCK_PIXMAP_CANCEL;
-       case A_CANCEL_SEND:     return STOCK_PIXMAP_CANCEL;
-       case A_CANCEL_ALL:      return STOCK_PIXMAP_CANCEL;
-       case A_EXECUTE:         return STOCK_PIXMAP_EXEC;
        #ifdef USE_ENCHANT
        case A_CHECK_SPELLING:  return STOCK_PIXMAP_CHECK_SPELLING;
        #endif
+
+       case A_CANCEL_INC:      return STOCK_PIXMAP_CANCEL;
+       case A_CANCEL_SEND:     return STOCK_PIXMAP_CANCEL;
+       case A_CANCEL_ALL:      return STOCK_PIXMAP_CANCEL;
+       case A_CLOSE:           return STOCK_PIXMAP_CLOSE;
        default:                return -1;
        }
 }
@@ -556,7 +646,7 @@ static void toolbar_set_default_compose(void)
                { A_SEPARATOR}, 
 #endif
                { A_SEND},
-               { A_SENDL},
+               { A_SEND_LATER},
                { A_DRAFT},
                { A_SEPARATOR}, 
 #ifndef GENERIC_UMPC
@@ -701,7 +791,7 @@ void toolbar_save_config_file(ToolbarType source)
        
                g_free( fileSpec );
                if (prefs_file_close (pfile) < 0 ) 
-                       g_warning("failed to write toolbar configuration to file\n");
+                       g_warning("failed to write toolbar configuration to file");
                return;
                
 fail:
@@ -709,7 +799,7 @@ fail:
                g_free( fileSpec );
                prefs_file_close_revert (pfile);
        } else
-               g_warning("failed to open toolbar configuration file for writing\n");
+               g_warning("failed to open toolbar configuration file for writing");
 }
 
 void toolbar_read_config_file(ToolbarType source)
@@ -717,6 +807,7 @@ void toolbar_read_config_file(ToolbarType source)
        XMLFile *file   = NULL;
        gchar *fileSpec = NULL;
        jmp_buf    jumper;
+       gboolean rewrite = FALSE;
 
        debug_print("read Toolbar Configuration from %s\n", toolbar_config[source].conf_file);
 
@@ -744,7 +835,7 @@ void toolbar_read_config_file(ToolbarType source)
 
                        /* Get next tag (icon, icon_text or icon_action) */
                        if (xml_compare_tag(file, TOOLBAR_TAG_ITEM)) {
-                               toolbar_parse_item(file, source);
+                               toolbar_parse_item(file, source, &rewrite);
                        } else if (xml_compare_tag(file, TOOLBAR_TAG_SEPARATOR)) {
                                ToolbarItem *item = g_new0(ToolbarItem, 1);
                        
@@ -756,6 +847,10 @@ void toolbar_read_config_file(ToolbarType source)
 
                }
                xml_close_file(file);
+               if (rewrite) {
+                       debug_print("toolbar_read_config_file: rewriting toolbar\n");
+                       toolbar_save_config_file(source);
+               }
        }
 
        if ((!file) || (g_slist_length(toolbar_config[source].item_list) == 0)) {
@@ -767,7 +862,7 @@ void toolbar_read_config_file(ToolbarType source)
                else if (source == TOOLBAR_MSGVIEW) 
                        toolbar_set_default(TOOLBAR_MSGVIEW);
                else {          
-                       g_warning("failed to write Toolbar Configuration to %s\n", toolbar_config[source].conf_file);
+                       g_warning("refusing to write unknown Toolbar Configuration number %d", source);
                        return;
                }
 
@@ -871,35 +966,18 @@ gboolean toolbar_check_action_btns(ToolbarType type)
        return modified;
 }
 
-#if !(GTK_CHECK_VERSION(2,12,0))
-#define CLAWS_SET_TOOL_ITEM_TIP(widget,tip) { \
-       gtk_tool_item_set_tooltip(GTK_TOOL_ITEM(widget), GTK_TOOLTIPS(toolbar_tips),    \
-                       tip, NULL);                                                             \
-}
-#else
 #define CLAWS_SET_TOOL_ITEM_TIP(widget,tip) { \
        gtk_tool_item_set_tooltip_text(GTK_TOOL_ITEM(widget), tip);                             \
 }
-#endif 
 
-#if !(GTK_CHECK_VERSION(2,12,0))
-#define CLAWS_SET_ARROW_TIP(widget,tip) { \
-       gtk_menu_tool_button_set_arrow_tooltip(GTK_MENU_TOOL_BUTTON(widget), GTK_TOOLTIPS(toolbar_tips),        \
-                       tip, NULL);                                                             \
-}
-#else
 #define CLAWS_SET_ARROW_TIP(widget,tip) { \
        gtk_menu_tool_button_set_arrow_tooltip_text(GTK_MENU_TOOL_BUTTON(widget), tip);                         \
 }
-#endif 
 
 static void activate_compose_button (Toolbar           *toolbar,
                                     ToolbarStyle      style,
                                     ComposeButtonType type)
 {
-#if !(GTK_CHECK_VERSION(2,12,0))
-       GtkTooltips *toolbar_tips = toolbar->tooltips;
-#endif
        if ((!toolbar->compose_mail_btn))
                return;
 
@@ -936,9 +1014,6 @@ static void activate_learn_button (Toolbar           *toolbar,
                                     ToolbarStyle      style,
                                     LearnButtonType type)
 {
-#if !(GTK_CHECK_VERSION(2,12,0))
-       GtkTooltips *toolbar_tips = toolbar->tooltips;
-#endif
        if ((!toolbar->learn_spam_btn))
                return;
 
@@ -980,8 +1055,8 @@ void toolbar_set_learn_button(Toolbar            *toolbar,
 void toolbar_toggle(guint action, gpointer data)
 {
        MainWindow *mainwin = (MainWindow*)data;
-       GList *list;
-       GList *cur;
+       const GList *list;
+       const GList *cur;
 
        cm_return_if_fail(mainwin != NULL);
 
@@ -1328,7 +1403,7 @@ static void toolbar_addrbook_cb(GtkWidget *widget, gpointer data)
        default:
                return;
        }
-#ifndef USE_NEW_ADDRBOOK
+#ifndef USE_ALT_ADDRBOOK
        addressbook_open(compose);
 #else
        GError* error = NULL;
@@ -1488,6 +1563,182 @@ static void toolbar_watch_thread_cb(GtkWidget *widget, gpointer data)
        }
 }
 
+static void toolbar_mark_cb(GtkWidget *widget, gpointer data)
+{
+       ToolbarItem *toolbar_item = (ToolbarItem*)data;
+       MainWindow *mainwin;
+
+       cm_return_if_fail(toolbar_item != NULL);
+
+       switch (toolbar_item->type) {
+       case TOOLBAR_MAIN:
+               mainwin = (MainWindow *) toolbar_item->parent;
+               summary_mark(mainwin->summaryview);
+               break;
+       case TOOLBAR_MSGVIEW:
+               /* TODO: see toolbar_next_unread_cb() if you need
+                * this in the message view */
+               break;
+       default:
+               debug_print("toolbar event not supported\n");
+               break;
+       }
+}
+
+static void toolbar_unmark_cb(GtkWidget *widget, gpointer data)
+{
+       ToolbarItem *toolbar_item = (ToolbarItem*)data;
+       MainWindow *mainwin;
+
+       cm_return_if_fail(toolbar_item != NULL);
+
+       switch (toolbar_item->type) {
+       case TOOLBAR_MAIN:
+               mainwin = (MainWindow *) toolbar_item->parent;
+               summary_unmark(mainwin->summaryview);
+               break;
+       case TOOLBAR_MSGVIEW:
+               /* TODO: see toolbar_next_unread_cb() if you need
+                * this in the message view */
+               break;
+       default:
+               debug_print("toolbar event not supported\n");
+               break;
+       }
+}
+
+static void toolbar_lock_cb(GtkWidget *widget, gpointer data)
+{
+       ToolbarItem *toolbar_item = (ToolbarItem*)data;
+       MainWindow *mainwin;
+
+       cm_return_if_fail(toolbar_item != NULL);
+
+       switch (toolbar_item->type) {
+       case TOOLBAR_MAIN:
+               mainwin = (MainWindow *) toolbar_item->parent;
+               summary_msgs_lock(mainwin->summaryview);
+               break;
+       case TOOLBAR_MSGVIEW:
+               /* TODO: see toolbar_next_unread_cb() if you need
+                * this in the message view */
+               break;
+       default:
+               debug_print("toolbar event not supported\n");
+               break;
+       }
+}
+
+static void toolbar_unlock_cb(GtkWidget *widget, gpointer data)
+{
+       ToolbarItem *toolbar_item = (ToolbarItem*)data;
+       MainWindow *mainwin;
+
+       cm_return_if_fail(toolbar_item != NULL);
+
+       switch (toolbar_item->type) {
+       case TOOLBAR_MAIN:
+               mainwin = (MainWindow *) toolbar_item->parent;
+               summary_msgs_unlock(mainwin->summaryview);
+               break;
+       case TOOLBAR_MSGVIEW:
+               /* TODO: see toolbar_next_unread_cb() if you need
+                * this in the message view */
+               break;
+       default:
+               debug_print("toolbar event not supported\n");
+               break;
+       }
+}
+
+static void toolbar_all_read_cb(GtkWidget *widget, gpointer data)
+{
+       ToolbarItem *toolbar_item = (ToolbarItem*)data;
+       MainWindow *mainwin;
+
+       cm_return_if_fail(toolbar_item != NULL);
+
+       switch (toolbar_item->type) {
+       case TOOLBAR_MAIN:
+               mainwin = (MainWindow *) toolbar_item->parent;
+               summary_mark_all_read(mainwin->summaryview);
+               break;
+       case TOOLBAR_MSGVIEW:
+               /* TODO: see toolbar_next_unread_cb() if you need
+                * this in the message view */
+               break;
+       default:
+               debug_print("toolbar event not supported\n");
+               break;
+       }
+}
+
+static void toolbar_all_unread_cb(GtkWidget *widget, gpointer data)
+{
+       ToolbarItem *toolbar_item = (ToolbarItem*)data;
+       MainWindow *mainwin;
+
+       cm_return_if_fail(toolbar_item != NULL);
+
+       switch (toolbar_item->type) {
+       case TOOLBAR_MAIN:
+               mainwin = (MainWindow *) toolbar_item->parent;
+               summary_mark_all_unread(mainwin->summaryview);
+               break;
+       case TOOLBAR_MSGVIEW:
+               /* TODO: see toolbar_next_unread_cb() if you need
+                * this in the message view */
+               break;
+       default:
+               debug_print("toolbar event not supported\n");
+               break;
+       }
+}
+
+static void toolbar_read_cb(GtkWidget *widget, gpointer data)
+{
+       ToolbarItem *toolbar_item = (ToolbarItem*)data;
+       MainWindow *mainwin;
+
+       cm_return_if_fail(toolbar_item != NULL);
+
+       switch (toolbar_item->type) {
+       case TOOLBAR_MAIN:
+               mainwin = (MainWindow *) toolbar_item->parent;
+               summary_mark_as_read(mainwin->summaryview);
+               break;
+       case TOOLBAR_MSGVIEW:
+               /* TODO: see toolbar_next_unread_cb() if you need
+                * this in the message view */
+               break;
+       default:
+               debug_print("toolbar event not supported\n");
+               break;
+       }
+}
+
+static void toolbar_unread_cb(GtkWidget *widget, gpointer data)
+{
+       ToolbarItem *toolbar_item = (ToolbarItem*)data;
+       MainWindow *mainwin;
+
+       cm_return_if_fail(toolbar_item != NULL);
+
+       switch (toolbar_item->type) {
+       case TOOLBAR_MAIN:
+               mainwin = (MainWindow *) toolbar_item->parent;
+               summary_mark_as_unread(mainwin->summaryview);
+               break;
+       case TOOLBAR_MSGVIEW:
+               /* TODO: see toolbar_next_unread_cb() if you need
+                * this in the message view */
+               break;
+       default:
+               debug_print("toolbar event not supported\n");
+               break;
+       }
+}
+
 static void toolbar_cancel_inc_cb(GtkWidget *widget, gpointer data)
 {
        ToolbarItem *toolbar_item = (ToolbarItem*)data;
@@ -1540,7 +1791,7 @@ static void toolbar_send_cb(GtkWidget *widget, gpointer data)
 
 static void toolbar_send_later_cb(GtkWidget *widget, gpointer data)
 {
-       compose_toolbar_cb(A_SENDL, data);
+       compose_toolbar_cb(A_SEND_LATER, data);
 }
 
 static void toolbar_draft_cb(GtkWidget *widget, gpointer data)
@@ -1614,6 +1865,11 @@ static void toolbar_sig_cb(GtkWidget *widget, gpointer data)
        compose_toolbar_cb(A_SIG, data);
 }
 
+static void toolbar_replace_sig_cb(GtkWidget *widget, gpointer data)
+{
+       compose_toolbar_cb(A_REP_SIG, data);
+}
+
 static void toolbar_ext_editor_cb(GtkWidget *widget, gpointer data)
 {
        compose_toolbar_cb(A_EXTEDITOR, data);
@@ -1707,7 +1963,7 @@ static void toolbar_go_folders_cb(GtkWidget *widget, gpointer data)
                mainwin = (MainWindow*)toolbar_item->parent;
                break;
        default:
-               g_warning("wrong toolbar type\n");
+               g_warning("wrong toolbar type");
                return;
        }
 
@@ -1717,7 +1973,7 @@ static void toolbar_go_folders_cb(GtkWidget *widget, gpointer data)
                        folderview_select(mainwin->folderview, item);
                }
        } else {
-               gtk_widget_grab_focus(mainwin->folderview->ctree);
+               folderview_grab_focus(mainwin->folderview);
                mainwindow_exit_folder(mainwin);
        }
 }
@@ -1748,12 +2004,20 @@ static void toolbar_buttons_cb(GtkWidget   *widget,
                { A_GOTO_NEXT,          toolbar_next_unread_cb          },
                { A_IGNORE_THREAD,      toolbar_ignore_thread_cb        },
                { A_WATCH_THREAD,       toolbar_watch_thread_cb         },
-               { A_PRINT,              toolbar_print_cb                },
+               { A_MARK,                       toolbar_mark_cb                 },
+               { A_UNMARK,                     toolbar_unmark_cb               },
+               { A_LOCK,                       toolbar_lock_cb                 },
+               { A_UNLOCK,                     toolbar_unlock_cb               },
+               { A_ALL_READ,           toolbar_all_read_cb             },
+               { A_ALL_UNREAD,         toolbar_all_unread_cb   },
+               { A_READ,                       toolbar_read_cb },
+               { A_UNREAD,                     toolbar_unread_cb       },
+               { A_PRINT,                      toolbar_print_cb                },
                { A_LEARN_SPAM,         toolbar_learn_cb                },
                { A_GO_FOLDERS,         toolbar_go_folders_cb           },
 
                { A_SEND,               toolbar_send_cb                 },
-               { A_SENDL,              toolbar_send_later_cb           },
+               { A_SEND_LATER, toolbar_send_later_cb           },
                { A_DRAFT,              toolbar_draft_cb                },
                { A_OPEN_MAIL,          toolbar_open_mail_cb            },
                { A_CLOSE,              toolbar_close_cb                },
@@ -1761,6 +2025,7 @@ static void toolbar_buttons_cb(GtkWidget   *widget,
                { A_INSERT,             toolbar_insert_cb               },
                { A_ATTACH,             toolbar_attach_cb               },
                { A_SIG,                toolbar_sig_cb                  },
+               { A_REP_SIG,            toolbar_replace_sig_cb          },
                { A_EXTEDITOR,          toolbar_ext_editor_cb           },
                { A_LINEWRAP_CURRENT,   toolbar_linewrap_current_cb     },
                { A_LINEWRAP_ALL,       toolbar_linewrap_all_cb         },
@@ -1898,11 +2163,6 @@ Toolbar *toolbar_create(ToolbarType       type,
        GSList *toolbar_list;
        Toolbar *toolbar_data;
        GtkWidget *menu;
-#ifndef GENERIC_UMPC
-#if !(GTK_CHECK_VERSION(2,12,0))
-       GtkTooltips *toolbar_tips = gtk_tooltips_new();
-#endif
-#endif 
        toolbar_read_config_file(type);
        toolbar_list = toolbar_get_list(type);
 
@@ -1910,11 +2170,8 @@ Toolbar *toolbar_create(ToolbarType       type,
 
        toolbar = gtk_toolbar_new();
 
-#if (GTK_CHECK_VERSION(2,16,0))
        gtk_orientable_set_orientation(GTK_ORIENTABLE(toolbar), GTK_ORIENTATION_HORIZONTAL);
-#else
-       gtk_toolbar_set_orientation(GTK_TOOLBAR(toolbar), GTK_ORIENTATION_HORIZONTAL);
-#endif
+
        gtk_toolbar_set_style(GTK_TOOLBAR(toolbar), GTK_TOOLBAR_BOTH);
        gtk_toolbar_set_show_arrow(GTK_TOOLBAR(toolbar), TRUE);
        
@@ -1936,7 +2193,7 @@ Toolbar *toolbar_create(ToolbarType        type,
                toolbar_data->item_list = 
                        g_slist_append(toolbar_data->item_list, 
                                       toolbar_item);
-               icon_wid = stock_pixmap_widget(container, stock_pixmap_get_icon(toolbar_item->file));
+               icon_wid = stock_pixmap_widget(stock_pixmap_get_icon(toolbar_item->file));
                        
                switch (toolbar_item->index) {
 
@@ -1979,7 +2236,7 @@ Toolbar *toolbar_create(ToolbarType        type,
                        toolbar_data->compose_mail_icon = icon_wid; 
                        g_object_ref(toolbar_data->compose_mail_icon);
 
-                       icon_news = stock_pixmap_widget(container, STOCK_PIXMAP_NEWS_COMPOSE);
+                       icon_news = stock_pixmap_widget(STOCK_PIXMAP_NEWS_COMPOSE);
                        toolbar_data->compose_news_icon = icon_news; 
                        g_object_ref(toolbar_data->compose_news_icon);
 #else
@@ -1988,7 +2245,7 @@ Toolbar *toolbar_create(ToolbarType        type,
                        toolbar_data->compose_mail_btn = item; 
                        toolbar_data->compose_mail_icon = icon_wid; 
 
-                       icon_news = stock_pixmap_widget(container, STOCK_PIXMAP_NEWS_COMPOSE);
+                       icon_news = stock_pixmap_widget(STOCK_PIXMAP_NEWS_COMPOSE);
                        toolbar_data->compose_news_icon = icon_news; 
 #endif
                        break;
@@ -2000,7 +2257,7 @@ Toolbar *toolbar_create(ToolbarType        type,
                        toolbar_data->learn_spam_icon = icon_wid; 
                        g_object_ref(toolbar_data->learn_spam_icon);
 
-                       icon_ham = stock_pixmap_widget(container, STOCK_PIXMAP_HAM_BTN);
+                       icon_ham = stock_pixmap_widget(STOCK_PIXMAP_HAM_BTN);
                        toolbar_data->learn_ham_icon = icon_ham; 
                        g_object_ref(toolbar_data->learn_ham_icon);
 
@@ -2121,7 +2378,7 @@ Toolbar *toolbar_create(ToolbarType        type,
                        TOOLBAR_ITEM(item,icon_wid,toolbar_item->text,_("Send Message"));
                        toolbar_data->send_btn = item;
                        break;
-               case A_SENDL:
+               case A_SEND_LATER:
                        TOOLBAR_ITEM(item,icon_wid,toolbar_item->text,_("Put into queue folder and send later"));
                        toolbar_data->sendl_btn = item;
                        break;
@@ -2141,6 +2398,10 @@ Toolbar *toolbar_create(ToolbarType       type,
                        TOOLBAR_ITEM(item,icon_wid,toolbar_item->text,_("Insert signature"));
                        toolbar_data->sig_btn = item;
                        break;
+               case A_REP_SIG:
+                       TOOLBAR_ITEM(item,icon_wid,toolbar_item->text,_("Replace signature"));
+                       toolbar_data->repsig_btn = item;
+                       break;
                case A_EXTEDITOR:
                        TOOLBAR_ITEM(item,icon_wid,toolbar_item->text,_("Edit with external editor"));
                        toolbar_data->exteditor_btn = item;
@@ -2198,11 +2459,7 @@ Toolbar *toolbar_create(ToolbarType       type,
 
        }
        toolbar_data->toolbar = toolbar;
-#ifndef GENERIC_UMPC
-#if !(GTK_CHECK_VERSION(2,12,0))
-       toolbar_data->tooltips = toolbar_tips;
-#endif
-#endif
+
        gtk_widget_show_all(toolbar);
 
        if (type == TOOLBAR_MAIN) {
@@ -2224,18 +2481,9 @@ Toolbar *toolbar_create(ToolbarType       type,
                activate_learn_button(toolbar_data, prefs_common.toolbar_style,
                                LEARN_SPAM);
        
-#ifndef MAEMO
        gtk_container_add(GTK_CONTAINER(container), toolbar);
        gtk_container_set_border_width(GTK_CONTAINER(container), 0);
-#else
-       if ( GTK_IS_WINDOW(container) ) {
-               hildon_window_add_toolbar (HILDON_WINDOW(container), GTK_TOOLBAR(toolbar));
-               gtk_widget_show_all (container);
-       } else {
-               gtk_container_add(GTK_CONTAINER(container), toolbar);
-               gtk_container_set_border_width(GTK_CONTAINER(container), 2);
-       }
-#endif
+
        return toolbar_data; 
 }
 
@@ -2296,9 +2544,6 @@ void toolbar_update(ToolbarType type, gpointer data)
        default:
                return;
        }
-#ifdef MAEMO
-       hildon_window_remove_toolbar(HILDON_WINDOW(handlebox), GTK_TOOLBAR(toolbar_data->toolbar));
-#endif
        toolbar_init(toolbar_data);
        toolbar_data = toolbar_create(type, handlebox, data);
 #endif
@@ -2323,61 +2568,9 @@ void toolbar_update(ToolbarType type, gpointer data)
        }
 }
 
-#if !GTK_CHECK_VERSION(2,14,0)
-/* Work around http://bugzilla.gnome.org/show_bug.cgi?id=56070 */
-#define GTK_BUTTON_SET_SENSITIVE(widget,sensitive) {           \
-       gboolean in_btn1 = FALSE, in_btn2 = FALSE;              \
-       if (GTK_IS_BUTTON(widget))                              \
-               in_btn1 = GTK_BUTTON(widget)->in_button;        \
-       else if (GTK_IS_MENU_TOOL_BUTTON(widget)) {             \
-               GtkWidget *child = gtk_bin_get_child(           \
-                       GTK_BIN(widget));                       \
-               GList *gchild = gtk_container_get_children(     \
-                       GTK_CONTAINER(child));                  \
-               GtkWidget *btn = (GtkWidget *)gchild->data;     \
-               GtkWidget *arr = (GtkWidget *)                  \
-                       (gchild->next?gchild->next->data:NULL); \
-               g_list_free(gchild);                            \
-               if (GTK_IS_BUTTON(btn))                         \
-                       in_btn1 = GTK_BUTTON(btn)->in_button;   \
-               if (GTK_IS_BUTTON(arr))                         \
-                       in_btn2 = GTK_BUTTON(arr)->in_button;   \
-       }                                                       \
-       else if (GTK_IS_TOOL_ITEM(widget)) {                    \
-               GtkWidget *child = gtk_bin_get_child(           \
-                       GTK_BIN(widget));                       \
-               if (GTK_IS_BUTTON(child))                       \
-                       in_btn1 = GTK_BUTTON(child)->in_button; \
-       }                                                       \
-       gtk_widget_set_sensitive(widget, sensitive);            \
-       if (GTK_IS_BUTTON(widget))                              \
-               GTK_BUTTON(widget)->in_button = in_btn1;        \
-       else if (GTK_IS_MENU_TOOL_BUTTON(widget)) {             \
-               GtkWidget *child = gtk_bin_get_child(           \
-                       GTK_BIN(widget));                       \
-               GList *gchild = gtk_container_get_children(     \
-                       GTK_CONTAINER(child));                  \
-               GtkWidget *btn = (GtkWidget *)gchild->data;     \
-               GtkWidget *arr = (GtkWidget *)                  \
-                       (gchild->next?gchild->next->data:NULL); \
-               g_list_free(gchild);                            \
-               if (GTK_IS_BUTTON(btn))                         \
-                       GTK_BUTTON(btn)->in_button = in_btn1;   \
-               if (GTK_IS_BUTTON(arr))                         \
-                       GTK_BUTTON(arr)->in_button = in_btn2;   \
-       }                                                       \
-       else if (GTK_IS_TOOL_ITEM(widget)) {                    \
-               GtkWidget *child = gtk_bin_get_child(           \
-                       GTK_BIN(widget));                       \
-               if (GTK_IS_BUTTON(child))                       \
-                       GTK_BUTTON(child)->in_button = in_btn1; \
-       }                                                       \
-}
-#else
 #define GTK_BUTTON_SET_SENSITIVE(widget,sensitive) {           \
        gtk_widget_set_sensitive(widget, sensitive);            \
 }
-#endif
 
 void toolbar_main_set_sensitive(gpointer data)
 {
@@ -2552,6 +2745,8 @@ void toolbar_comp_set_sensitive(gpointer data, gboolean sensitive)
                GTK_BUTTON_SET_SENSITIVE(compose->toolbar->attach_btn, sensitive);
        if (compose->toolbar->sig_btn)
                GTK_BUTTON_SET_SENSITIVE(compose->toolbar->sig_btn, sensitive);
+       if (compose->toolbar->repsig_btn)
+               GTK_BUTTON_SET_SENSITIVE(compose->toolbar->repsig_btn, sensitive);
        if (compose->toolbar->exteditor_btn)
                GTK_BUTTON_SET_SENSITIVE(compose->toolbar->exteditor_btn, sensitive);
        if (compose->toolbar->linewrap_current_btn)
@@ -2608,6 +2803,7 @@ static void toolbar_init(Toolbar * toolbar)
        toolbar->insert_btn        = NULL;
        toolbar->attach_btn        = NULL;
        toolbar->sig_btn           = NULL; 
+       toolbar->repsig_btn        = NULL; 
        toolbar->exteditor_btn     = NULL; 
        toolbar->linewrap_current_btn = NULL;   
        toolbar->linewrap_all_btn  = NULL;      
@@ -2621,9 +2817,6 @@ static void toolbar_init(Toolbar * toolbar)
 #ifdef USE_ENCHANT
        toolbar->spellcheck_btn    = NULL;
 #endif
-#if !GTK_CHECK_VERSION(2,12,0)
-       toolbar->tooltips          = NULL;
-#endif
 
        toolbar_destroy(toolbar);
 }
@@ -2747,7 +2940,7 @@ void compose_mail_cb(gpointer data, guint action, GtkWidget *widget)
        
        if (item) {
                ac = account_find_from_item(item);
-               if (ac && ac->protocol != A_NNTP) {
+               if (ac && ac->protocol != A_NNTP && ac->protocol != A_IMAP4) {
                        compose_new_with_folderitem(ac, item, NULL);            /* CLAWS */
                        return;
                }