more fixes for Go To actions not obeying 'always_show_msg' option
[claws.git] / src / summaryview.c
index 4a519df1a11c1d7e26af8ccb461181fa93c40edc..e924a3a8ce90f69d922bfbee291ecbc3ba7e9c1f 100644 (file)
@@ -135,10 +135,12 @@ static void summary_set_hide_menu (SummaryView *summaryview,
 
 static GtkCMCTreeNode *summary_find_prev_msg
                                        (SummaryView            *summaryview,
-                                        GtkCMCTreeNode         *current_node);
+                                        GtkCMCTreeNode         *current_node,
+                                        gboolean                start_from_prev);
 static GtkCMCTreeNode *summary_find_next_msg
                                        (SummaryView            *summaryview,
-                                        GtkCMCTreeNode         *current_node);
+                                        GtkCMCTreeNode         *current_node,
+                                        gboolean                start_from_next);
 
 static GtkCMCTreeNode *summary_find_prev_flagged_msg
                                        (SummaryView    *summaryview,
@@ -921,7 +923,7 @@ static void summary_set_folder_pixmap(SummaryView *summaryview, StockPixmap icon
        if (summaryview->folder_pixmap)
                gtk_widget_destroy(summaryview->folder_pixmap);
 
-       pixmap = stock_pixmap_widget(summaryview->hbox_l, icon);
+       pixmap = stock_pixmap_widget(icon);
        gtk_container_add(GTK_CONTAINER(summaryview->folder_pixmap_eventbox), pixmap);
        gtk_widget_show(pixmap);
        summaryview->folder_pixmap = pixmap; 
@@ -932,56 +934,37 @@ void summary_init(SummaryView *summaryview)
        GtkWidget *pixmap;
 
        gtk_widget_realize(summaryview->ctree);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_MARK,
-                        &markxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_DELETED,
-                        &deletedxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_NEW,
-                        &newxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_UNREAD,
-                        &unreadxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_REPLIED,
-                        &repliedxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_FORWARDED,
-                        &forwardedxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_REPLIED_AND_FORWARDED,
-                        &repliedandforwardedxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_CLIP,
-                        &clipxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_LOCKED,
-                        &lockedxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_IGNORETHREAD,
-                        &ignorethreadxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_WATCHTHREAD,
-                        &watchthreadxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_CLIP_KEY,
-                        &clipkeyxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_KEY_SIGN,
-                        &keysignxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_KEY,
-                        &keyxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_GPG_SIGNED,
-                        &gpgsignedxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_CLIP_GPG_SIGNED,
-                        &clipgpgsignedxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_SPAM,
-                        &spamxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_MOVED,
-                        &movedxpm);
-       stock_pixbuf_gdk(summaryview->ctree, STOCK_PIXMAP_COPIED,
-                        &copiedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_MARK, &markxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_DELETED, &deletedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_NEW, &newxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_UNREAD, &unreadxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_REPLIED, &repliedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_FORWARDED, &forwardedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_REPLIED_AND_FORWARDED, &repliedandforwardedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CLIP, &clipxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_LOCKED, &lockedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_IGNORETHREAD, &ignorethreadxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_WATCHTHREAD, &watchthreadxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CLIP_KEY, &clipkeyxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_KEY_SIGN, &keysignxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_KEY, &keyxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_GPG_SIGNED, &gpgsignedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CLIP_GPG_SIGNED, &clipgpgsignedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_SPAM, &spamxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_MOVED, &movedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_COPIED, &copiedxpm);
 
        summary_set_fonts(summaryview);
 
        summary_set_folder_pixmap(summaryview, STOCK_PIXMAP_DIR_OPEN);
 
-       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_QUICKSEARCH);
+       pixmap = stock_pixmap_widget(STOCK_PIXMAP_QUICKSEARCH);
        gtk_container_add (GTK_CONTAINER(summaryview->toggle_search), pixmap);
        gtk_widget_show(pixmap);
        summaryview->quick_search_pixmap = pixmap;
        
 #ifdef GENERIC_UMPC
-       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_SELECTION);
+       pixmap = stock_pixmap_widget(STOCK_PIXMAP_SELECTION);
        gtk_container_add(GTK_CONTAINER(summaryview->multiple_sel_togbtn), pixmap);
        gtk_widget_show(pixmap);
        summaryview->multiple_sel_image = pixmap;
@@ -1487,7 +1470,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
                                                 item->sort_type == SORT_DESCENDING
                                                 ? 0 : GTK_CMCLIST(ctree)->rows - 1);
                                summary_unlock(summaryview);
-                               summary_select_node(summaryview, node, FALSE, TRUE);
+                               summary_select_node(summaryview, node, 0);
                                summary_lock(summaryview);
                        }
                } else {
@@ -1566,12 +1549,8 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
                }
 
                summary_unlock(summaryview);
-               if (node) {
-                       gboolean show = (prefs_common.always_show_msg == OPENMSG_ALWAYS) ||
-                               (prefs_common.always_show_msg == OPENMSG_WHEN_VIEW_VISIBLE &&
-                                               messageview_is_visible(summaryview->messageview));
-                       summary_select_node(summaryview, node, show, TRUE);
-               }
+               if (node)
+                       summary_select_node(summaryview, node, -1);
                summary_lock(summaryview);
        }
 
@@ -1819,6 +1798,27 @@ do { \
 #endif
        summary_unlock(summaryview);
 }
+void summary_select_prev(SummaryView *summaryview)
+{
+       GtkCMCTreeNode *node = summaryview->selected;
+       GtkCMCTree *ctree = GTK_CMCTREE(summaryview->ctree);
+
+       node = gtkut_ctree_node_prev(ctree, node);
+
+       if (node && node != summaryview->selected)
+               summary_select_node(summaryview, node, -1);
+}
+
+void summary_select_next(SummaryView *summaryview)
+{
+       GtkCMCTreeNode *node = summaryview->selected;
+       GtkCMCTree *ctree = GTK_CMCTREE(summaryview->ctree);
+
+       node = gtkut_ctree_node_next(ctree, node);
+
+       if (node && node != summaryview->selected)
+               summary_select_node(summaryview, node, -1);
+}
 
 void summary_select_prev_unread(SummaryView *summaryview)
 {
@@ -1862,7 +1862,7 @@ void summary_select_prev_unread(SummaryView *summaryview)
        if (!node)
                alertpanel_notice(_("No unread messages."));
        else
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
 }
 
 void summary_select_next_unread(SummaryView *summaryview)
@@ -1877,12 +1877,11 @@ void summary_select_next_unread(SummaryView *summaryview)
                skip_cur = TRUE;
        }
 
-
        node = summary_find_next_flagged_msg
                (summaryview, node, MSG_UNREAD, skip_cur);
        
        if (node)
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
        else {
                node = summary_find_next_flagged_msg
                        (summaryview, NULL, MSG_UNREAD, FALSE);
@@ -1908,9 +1907,9 @@ void summary_select_next_unread(SummaryView *summaryview)
                        }
 
                        if (val == G_ALERTALTERNATE)
-                               folderview_select_next_with_flag(summaryview->folderview, MSG_UNREAD, TRUE);
+                               folderview_select_next_with_flag(summaryview->folderview, MSG_UNREAD);
                } else {
-                       summary_select_node(summaryview, node, TRUE, FALSE);
+                       summary_select_node(summaryview, node, -1);
                }
        }
 }
@@ -1957,7 +1956,7 @@ void summary_select_prev_new(SummaryView *summaryview)
        if (!node)
                alertpanel_notice(_("No new messages."));
        else
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
 }
 
 void summary_select_next_new(SummaryView *summaryview)
@@ -1972,12 +1971,11 @@ void summary_select_next_new(SummaryView *summaryview)
                skip_cur = TRUE;
        }
 
-
        node = summary_find_next_flagged_msg
                (summaryview, node, MSG_NEW, skip_cur);
        
        if (node)
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
        else {
                node = summary_find_next_flagged_msg
                        (summaryview, NULL, MSG_NEW, FALSE);
@@ -2003,13 +2001,13 @@ void summary_select_next_new(SummaryView *summaryview)
                        }
 
                        if (val == G_ALERTALTERNATE) {
-                               folderview_select_next_with_flag(summaryview->folderview, MSG_NEW, TRUE);
+                               folderview_select_next_with_flag(summaryview->folderview, MSG_NEW);
                                return;
                        } 
                        else
                                return;
                } else
-                       summary_select_node(summaryview, node, TRUE, FALSE);
+                       summary_select_node(summaryview, node, -1);
 
        }
 }
@@ -2036,7 +2034,7 @@ void summary_select_prev_marked(SummaryView *summaryview)
        if (!node)
                alertpanel_notice(_("No marked messages."));
        else
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
 }
 
 void summary_select_next_marked(SummaryView *summaryview)
@@ -2051,12 +2049,11 @@ void summary_select_next_marked(SummaryView *summaryview)
                skip_cur = TRUE;
        }
 
-
        node = summary_find_next_flagged_msg
                (summaryview, node, MSG_MARKED, skip_cur);
        
        if (node)
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
        else {
                node = summary_find_next_flagged_msg
                        (summaryview, NULL, MSG_MARKED, FALSE);
@@ -2082,13 +2079,13 @@ void summary_select_next_marked(SummaryView *summaryview)
                        }
 
                        if (val == G_ALERTALTERNATE) {
-                               folderview_select_next_with_flag(summaryview->folderview, MSG_MARKED, TRUE);
+                               folderview_select_next_with_flag(summaryview->folderview, MSG_MARKED);
                                return;
                        } 
                        else
                                return;
                } else
-                       summary_select_node(summaryview, node, TRUE, FALSE);
+                       summary_select_node(summaryview, node, -1);
 
        }
 }
@@ -2115,7 +2112,7 @@ void summary_select_prev_labeled(SummaryView *summaryview)
        if (!node)
                alertpanel_notice(_("No labeled messages."));
        else
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
 }
 
 void summary_select_next_labeled(SummaryView *summaryview)
@@ -2140,7 +2137,7 @@ void summary_select_next_labeled(SummaryView *summaryview)
        if (!node)
                alertpanel_notice(_("No labeled messages."));
        else
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
 }
 
 void summary_select_parent(SummaryView *summaryview)
@@ -2150,7 +2147,7 @@ void summary_select_parent(SummaryView *summaryview)
        if (summaryview->selected)
                node = GTK_CMCTREE_ROW(summaryview->selected)->parent;
        if (node)
-               summary_select_node(summaryview, node, TRUE, FALSE);
+               summary_select_node(summaryview, node, -1);
 }
 
 void summary_select_by_msgnum(SummaryView *summaryview, guint msgnum)
@@ -2158,7 +2155,7 @@ void summary_select_by_msgnum(SummaryView *summaryview, guint msgnum)
        GtkCMCTreeNode *node;
 
        node = summary_find_msg_by_msgnum(summaryview, msgnum);
-       summary_select_node(summaryview, node, FALSE, TRUE);
+       summary_select_node(summaryview, node, 0);
 }
 
 void summary_display_by_msgnum(SummaryView *summaryview, guint msgnum)
@@ -2166,7 +2163,7 @@ void summary_display_by_msgnum(SummaryView *summaryview, guint msgnum)
        GtkCMCTreeNode *node;
 
        node = summary_find_msg_by_msgnum(summaryview, msgnum);
-       summary_select_node(summaryview, node, TRUE, FALSE);
+       summary_select_node(summaryview, node, 1);
 }
 
 void summary_select_by_msg_list(SummaryView    *summaryview, GSList *msginfos)
@@ -2198,7 +2195,6 @@ typedef struct _PostponedSelectData
        gint column;
        SummaryView *summaryview;
        gboolean display_msg;
-       gboolean do_refresh;
 } PostponedSelectData;
 
 static gboolean summary_select_retry(void *data)
@@ -2210,9 +2206,7 @@ static gboolean summary_select_retry(void *data)
                            psdata->column, psdata->summaryview);
        else if (psdata->node)
                summary_select_node(psdata->summaryview, psdata->node,
-                           psdata->display_msg, psdata->do_refresh);
-       else
-               summary_step(psdata->summaryview, psdata->type);
+                           psdata->display_msg);
        g_free(psdata);
        return FALSE;
 }
@@ -2221,19 +2215,24 @@ static gboolean summary_select_retry(void *data)
  * summary_select_node:
  * @summaryview: Summary view.
  * @node: Summary tree node.
- * @display_msg: TRUE to display the selected message.
- * @do_refresh: TRUE to refresh the widget.
+ * @force_display: -1 unset, 0 don't show the msg, 1 show the msg.
  *
  * Select @node (bringing it into view by scrolling and expanding its
- * thread, if necessary) and unselect all others.  If @display_msg is
- * TRUE, display the corresponding message in the message view.
- * If @do_refresh is TRUE, the widget is refreshed.
+ * thread, if necessary) and unselect all others.  If @force_display is
+ * 1, display the corresponding message in the message view, if
+ * @force_display is -1, obey prefs_common.always_show_msg.
  **/
 void summary_select_node(SummaryView *summaryview, GtkCMCTreeNode *node,
-                        gboolean display_msg, gboolean do_refresh)
+                        gint force_display)
 {
        GtkCMCTree *ctree = GTK_CMCTREE(summaryview->ctree);
+       gboolean display_msg;
        
+       display_msg = force_display > -1? force_display :
+               (prefs_common.always_show_msg == OPENMSG_ALWAYS) ||
+               ((prefs_common.always_show_msg == OPENMSG_WHEN_VIEW_VISIBLE &&
+                               messageview_is_visible(summaryview->messageview)));
+
        if (summary_is_locked(summaryview)
        && !GTK_SCTREE(ctree)->selecting_range
        && summaryview->messageview->mimeview
@@ -2247,7 +2246,6 @@ void summary_select_node(SummaryView *summaryview, GtkCMCTreeNode *node,
                data->node = node;
                data->summaryview = summaryview;
                data->display_msg = display_msg;
-               data->do_refresh = do_refresh;
                debug_print("postponing open of message till end of load\n");
                g_timeout_add(100, summary_select_retry, data);
                return;
@@ -2260,13 +2258,13 @@ void summary_select_node(SummaryView *summaryview, GtkCMCTreeNode *node,
        if (node) {
                summary_cancel_mark_read_timeout(summaryview);
                gtkut_ctree_expand_parent_all(ctree, node);
-               if (do_refresh) {
-                       summary_lock(summaryview);
-                       GTK_EVENTS_FLUSH();
-                       summary_unlock(summaryview);
-                       gtk_widget_grab_focus(GTK_WIDGET(ctree));
-                       gtk_cmctree_node_moveto(ctree, node, 0, 0.5, 0);
-               }
+
+               summary_lock(summaryview);
+               GTK_EVENTS_FLUSH();
+               summary_unlock(summaryview);
+               gtk_widget_grab_focus(GTK_WIDGET(ctree));
+               gtk_cmctree_node_moveto(ctree, node, 0, 0.5, 0);
+
                if (display_msg && summaryview->displayed == node)
                        summaryview->displayed = NULL;
                summaryview->display_msg = display_msg;
@@ -2294,18 +2292,22 @@ guint summary_get_msgnum(SummaryView *summaryview, GtkCMCTreeNode *node)
 }
 
 static GtkCMCTreeNode *summary_find_prev_msg(SummaryView *summaryview,
-                                          GtkCMCTreeNode *current_node)
+                                            GtkCMCTreeNode *current_node,
+                                            gboolean start_from_prev)
 {
        GtkCMCTree *ctree = GTK_CMCTREE(summaryview->ctree);
        GtkCMCTreeNode *node;
        MsgInfo *msginfo;
 
-       if (current_node)
-               node = current_node;
-       else
+       if (current_node) {
+               if (start_from_prev)
+                       node = gtkut_ctree_node_prev(ctree, current_node);
+               else
+                       node = current_node;
+       } else
                node = gtk_cmctree_node_nth(ctree, GTK_CMCLIST(ctree)->rows - 1);
 
-       for (; node != NULL; node = GTK_CMCTREE_NODE_PREV(node)) {
+       for (; node != NULL; node = gtkut_ctree_node_prev(ctree, node)) {
                msginfo = gtk_cmctree_node_get_row_data(ctree, node);
                if (msginfo && !MSG_IS_DELETED(msginfo->flags)) break;
        }
@@ -2314,15 +2316,19 @@ static GtkCMCTreeNode *summary_find_prev_msg(SummaryView *summaryview,
 }
 
 static GtkCMCTreeNode *summary_find_next_msg(SummaryView *summaryview,
-                                          GtkCMCTreeNode *current_node)
+                                           GtkCMCTreeNode *current_node,
+                                           gboolean start_from_next)
 {
        GtkCMCTree *ctree = GTK_CMCTREE(summaryview->ctree);
        GtkCMCTreeNode *node;
        MsgInfo *msginfo;
 
-       if (current_node)
-               node = current_node;
-       else
+       if (current_node) {
+               if (start_from_next)
+                       node = gtkut_ctree_node_next(ctree, current_node);
+               else
+                       node = current_node;
+       } else
                node = GTK_CMCTREE_NODE(GTK_CMCLIST(ctree)->row_list);
 
        for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
@@ -2345,13 +2351,13 @@ static GtkCMCTreeNode *summary_find_prev_flagged_msg(SummaryView *summaryview,
 
        if (current_node) {
                if (start_from_prev)
-                       node = GTK_CMCTREE_NODE_PREV(current_node);
+                       node = gtkut_ctree_node_prev(ctree, current_node);
                else
                        node = current_node;
        } else
                node = gtk_cmctree_node_nth(ctree, GTK_CMCLIST(ctree)->rows - 1);
 
-       for (; node != NULL; node = GTK_CMCTREE_NODE_PREV(node)) {
+       for (; node != NULL; node = gtkut_ctree_node_prev(ctree, node)) {
                msginfo = gtk_cmctree_node_get_row_data(ctree, node);
                if (msginfo && (msginfo->flags.perm_flags & flags) != 0) break;
        }
@@ -2441,7 +2447,7 @@ void summary_attract_by_subject(SummaryView *summaryview)
        MsgInfo *src_msginfo, *dst_msginfo;
        GHashTable *subject_table;
 
-       debug_print("Attracting messages by subject...");
+       debug_print("Attracting messages by subject...\n");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Attracting messages by subject..."));
 
@@ -2487,7 +2493,7 @@ void summary_attract_by_subject(SummaryView *summaryview)
 
        summary_thaw(summaryview);
 
-       debug_print("done.\n");
+       debug_print("Attracting messages by subject done.\n");
        STATUSBAR_POP(summaryview->mainwin);
 
        main_window_cursor_normal(summaryview->mainwin);
@@ -2900,12 +2906,25 @@ void summary_reflect_prefs(void)
        last_boldfont = g_strdup(BOLD_FONT);
        last_derive = prefs_common.derive_from_normal_font;
 
-       if (update_font) {      
-               bold_style = bold_marked_style = bold_deleted_style = 
-                       small_style = small_marked_style = small_deleted_style = NULL;
+#define STYLE_FREE(s)                  \
+       if (s != NULL) {                \
+               g_object_unref(s);      \
+               s = NULL;               \
+       }
+
+       if (update_font) {
+               STYLE_FREE(bold_style);
+               STYLE_FREE(bold_style);
+               STYLE_FREE(bold_marked_style);
+               STYLE_FREE(bold_deleted_style);
+               STYLE_FREE(small_style);
+               STYLE_FREE(small_marked_style);
+               STYLE_FREE(small_deleted_style);
                summary_set_fonts(summaryview);
        }
 
+#undef STYLE_FREE
+
        summary_set_column_titles(summaryview);
        summary_relayout(summaryview);
        
@@ -2987,7 +3006,7 @@ void summary_sort(SummaryView *summaryview,
                goto unlock;
 
        if (cmp_func != NULL) {
-               debug_print("Sorting summary...");
+               debug_print("Sorting summary...\n");
                STATUSBAR_PUSH(summaryview->mainwin, _("Sorting summary..."));
 
                main_window_cursor_wait(summaryview->mainwin);
@@ -3001,7 +3020,7 @@ void summary_sort(SummaryView *summaryview,
 
                main_window_cursor_normal(summaryview->mainwin);
 
-               debug_print("done.\n");
+               debug_print("Sorting summary done.\n");
                STATUSBAR_POP(summaryview->mainwin);
        }
 unlock:
@@ -3125,7 +3144,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
        
        if (!mlist) return;
 
-       debug_print("\tSetting summary from message data...\n");
+       debug_print("Setting summary from message data...\n");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Setting summary from message data..."));
        gdk_flush();
@@ -3213,7 +3232,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
        if (prefs_common.use_addr_book)
                end_address_completion();
 
-       debug_print("done.\n");
+       debug_print("Setting summary from message data done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        if (debug_get_mode()) {
                debug_print("\tmsgid hash table size = %d\n",
@@ -3724,56 +3743,6 @@ void summary_reedit(SummaryView *summaryview)
        compose_reedit(msginfo, FALSE);
 }
 
-gboolean summary_step(SummaryView *summaryview, GtkScrollType type)
-{
-       GtkCMCTree *ctree = GTK_CMCTREE(summaryview->ctree);
-       GtkCMCTreeNode *node;
-
-       if (summary_is_locked(summaryview)
-       && !GTK_SCTREE(ctree)->selecting_range
-       && summaryview->messageview->mimeview
-       && summaryview->messageview->mimeview->type == MIMEVIEW_TEXT
-       && summaryview->messageview->mimeview->textview->loading) {
-               PostponedSelectData *data = g_new0(PostponedSelectData, 1);
-               summaryview->messageview->mimeview->textview->stop_loading = TRUE;
-               
-               data->ctree = ctree;
-               data->row = NULL;
-               data->node = NULL;
-               data->type = type;
-               data->summaryview = summaryview;
-               debug_print("postponing open of message till end of load\n");
-               g_timeout_add(100, summary_select_retry, data);
-               return FALSE;
-       }
-       if (summary_is_locked(summaryview))
-               return FALSE;
-       if (type == GTK_SCROLL_STEP_FORWARD) {
-               node = gtkut_ctree_node_next(ctree, summaryview->selected);
-               if (node)
-                       gtkut_ctree_expand_parent_all(ctree, node);
-               else
-                       return FALSE;
-       } else {
-               if (summaryview->selected) {
-                       node = GTK_CMCTREE_NODE_PREV(summaryview->selected);
-                       if (!node) return FALSE;
-               }
-       }
-
-       if (messageview_is_visible(summaryview->messageview))
-               summaryview->display_msg = TRUE;
-
-       g_signal_emit_by_name(G_OBJECT(ctree), "scroll_vertical", type, 0.0);
-
-       if (GTK_CMCLIST(ctree)->selection)
-               gtk_sctree_set_anchor_row
-                       (GTK_SCTREE(ctree),
-                        GTK_CMCTREE_NODE(GTK_CMCLIST(ctree)->selection->data));
-
-       return TRUE;
-}
-
 gboolean summary_is_list(SummaryView *summaryview)
 {
        return (gtk_notebook_get_current_page(
@@ -4432,15 +4401,15 @@ void summary_delete(SummaryView *summaryview)
        END_LONG_OPERATION(summaryview);
 
        if (summaryview->sort_type == SORT_ASCENDING) {
-               node = summary_find_next_msg(summaryview, sel_last);
+               node = summary_find_next_msg(summaryview, sel_last, TRUE);
                if (!node || prefs_common.next_on_delete == FALSE)
-                       node = summary_find_prev_msg(summaryview, sel_last);
+                       node = summary_find_prev_msg(summaryview, sel_last,TRUE);
        } else {
-               node = summary_find_prev_msg(summaryview, sel_last);
+               node = summary_find_prev_msg(summaryview, sel_last,TRUE);
                if (!node || prefs_common.next_on_delete == FALSE)
-                       node = summary_find_next_msg(summaryview, sel_last);
+                       node = summary_find_next_msg(summaryview, sel_last,TRUE);
        }
-       summary_select_node(summaryview, node, prefs_common.always_show_msg, TRUE);
+       summary_select_node(summaryview, node, -1);
        
        if (prefs_common.immediate_exec || folder_has_parent_of_type(item, F_TRASH)) {
                summary_execute(summaryview);
@@ -4584,24 +4553,20 @@ void summary_move_selected_to(SummaryView *summaryview, FolderItem *to_folder)
        }
        END_LONG_OPERATION(summaryview);
 
-       summaryview->display_msg = (prefs_common.always_show_msg == OPENMSG_ALWAYS) ||
-               ((prefs_common.always_show_msg == OPENMSG_WHEN_VIEW_VISIBLE &&
-                               messageview_is_visible(summaryview->messageview)));
-       
        if (prefs_common.immediate_exec) {
                summary_execute(summaryview);
        } else {
                GtkCMCTreeNode *node = NULL;
                if (summaryview->sort_type == SORT_ASCENDING) {
-                       node = summary_find_next_msg(summaryview, sel_last);
+                       node = summary_find_next_msg(summaryview, sel_last,TRUE);
                        if (!node || prefs_common.next_on_delete == FALSE)
-                               node = summary_find_prev_msg(summaryview, sel_last);
+                               node = summary_find_prev_msg(summaryview, sel_last,TRUE);
                } else {
-                       node = summary_find_prev_msg(summaryview, sel_last);
+                       node = summary_find_prev_msg(summaryview, sel_last,TRUE);
                        if (!node || prefs_common.next_on_delete == FALSE)
-                               node = summary_find_next_msg(summaryview, sel_last);
+                               node = summary_find_next_msg(summaryview, sel_last,TRUE);
                }
-               summary_select_node(summaryview, node, summaryview->display_msg, TRUE);
+               summary_select_node(summaryview, node, -1);
                summary_status_show(summaryview);
        }
        
@@ -4609,7 +4574,7 @@ void summary_move_selected_to(SummaryView *summaryview, FolderItem *to_folder)
                GtkCMCTreeNode *node = gtk_cmctree_node_nth (GTK_CMCTREE(summaryview->ctree), 
                                                         GTK_CMCLIST(summaryview->ctree)->rows - 1);
                if (node)
-                       summary_select_node(summaryview, node, summaryview->display_msg, TRUE);
+                       summary_select_node(summaryview, node, -1);
        }
 
 }
@@ -4963,13 +4928,13 @@ gboolean summary_execute(SummaryView *summaryview)
                    gtkut_ctree_node_is_selected(ctree, node)) {
                        summary_unselect_all(summaryview);
                        if (summaryview->sort_type == SORT_ASCENDING) {
-                               new_selected = summary_find_next_msg(summaryview, node);
+                               new_selected = summary_find_next_msg(summaryview, node,TRUE);
                                if (!new_selected || prefs_common.next_on_delete == FALSE)
-                                       new_selected = summary_find_prev_msg(summaryview, node);
+                                       new_selected = summary_find_prev_msg(summaryview, node,TRUE);
                        } else {
-                               new_selected = summary_find_prev_msg(summaryview, node);
+                               new_selected = summary_find_prev_msg(summaryview, node,TRUE);
                                if (!new_selected || prefs_common.next_on_delete == FALSE)
-                                       new_selected = summary_find_next_msg(summaryview, node);
+                                       new_selected = summary_find_next_msg(summaryview, node,TRUE);
                        }
                }
 
@@ -4998,7 +4963,7 @@ gboolean summary_execute(SummaryView *summaryview)
        if (!GTK_CMCLIST(summaryview->ctree)->row_list) {
                menu_set_insensitive_all
                        (GTK_MENU_SHELL(summaryview->popupmenu));
-               gtk_widget_grab_focus(summaryview->folderview->ctree);
+               folderview_grab_focus(summaryview->folderview);
        } else {
                menu_set_sensitive_all(GTK_MENU_SHELL(summaryview->popupmenu), TRUE);
                gtk_widget_grab_focus(summaryview->ctree);
@@ -5068,10 +5033,10 @@ gboolean summary_expunge(SummaryView *summaryview)
                if (!new_selected &&
                    gtkut_ctree_node_is_selected(ctree, node)) {
                        summary_unselect_all(summaryview);
-                       new_selected = summary_find_next_msg(summaryview, node);
+                       new_selected = summary_find_next_msg(summaryview, node,TRUE);
                        if (!new_selected)
                                new_selected = summary_find_prev_msg
-                                       (summaryview, node);
+                                       (summaryview, node,TRUE);
                }
 
                gtk_sctree_remove_node((GtkSCTree *)ctree, node);
@@ -5099,7 +5064,7 @@ gboolean summary_expunge(SummaryView *summaryview)
        if (!GTK_CMCLIST(summaryview->ctree)->row_list) {
                menu_set_insensitive_all
                        (GTK_MENU_SHELL(summaryview->popupmenu));
-               gtk_widget_grab_focus(summaryview->folderview->ctree);
+               folderview_grab_focus(summaryview->folderview);
        } else {
                menu_set_sensitive_all(GTK_MENU_SHELL(summaryview->popupmenu), TRUE);
                gtk_widget_grab_focus(summaryview->ctree);
@@ -5336,7 +5301,7 @@ static void summary_thread_build(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print("Building threads...");
+       debug_print("Building threads...\n");
        STATUSBAR_PUSH(summaryview->mainwin, _("Building threads..."));
        main_window_cursor_wait(summaryview->mainwin);
 
@@ -5385,7 +5350,7 @@ static void summary_thread_build(SummaryView *summaryview)
        g_signal_handlers_unblock_by_func(G_OBJECT(ctree),
                                         G_CALLBACK(summary_tree_expanded), summaryview);
 
-       debug_print("done.\n");
+       debug_print("Building threads done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
@@ -5421,7 +5386,7 @@ static void summary_unthread_for_exec(SummaryView *summaryview)
        GtkCMCTree *ctree = GTK_CMCTREE(summaryview->ctree);
        gboolean froze = FALSE;
 
-       debug_print("Unthreading for execution...");
+       debug_print("Unthreading for execution...\n");
 
        START_LONG_OPERATION(summaryview, TRUE);
        for (node = GTK_CMCTREE_NODE(GTK_CMCLIST(ctree)->row_list);
@@ -5431,7 +5396,7 @@ static void summary_unthread_for_exec(SummaryView *summaryview)
 
        END_LONG_OPERATION(summaryview);
 
-       debug_print("done.\n");
+       debug_print("Unthreading for execution done.\n");
 }
 
 static void summary_unthread_for_exec_func(GtkCMCTree *ctree, GtkCMCTreeNode *node,
@@ -5650,7 +5615,7 @@ void summary_filter(SummaryView *summaryview, gboolean selected_only)
 
        folder_item_update_freeze();
        
-       debug_print("filtering...");
+       debug_print("filtering...\n");
        STATUSBAR_PUSH(summaryview->mainwin, _("Filtering..."));
        main_window_cursor_wait(summaryview->mainwin);
 
@@ -5686,7 +5651,7 @@ void summary_filter(SummaryView *summaryview, gboolean selected_only)
        summary_thaw(summaryview);
 
        folder_item_update_thaw();
-       debug_print("done.\n");
+       debug_print("filtering done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
@@ -6623,7 +6588,7 @@ static gint summary_folder_eventbox_pressed(GtkWidget *eventbox, GdkEventButton
                                            SummaryView *summaryview)
 {
        if (event) {
-               gtk_widget_grab_focus(summaryview->folderview->ctree);
+               folderview_grab_focus(summaryview->folderview);
                mainwindow_exit_folder(summaryview->mainwin);
        }
        return TRUE;
@@ -6769,7 +6734,7 @@ static gboolean summary_key_pressed(GtkWidget *widget, GdkEventKey *event,
                        break;
                /* FALLTHROUGH */       
        case GDK_KEY_Escape:
-               gtk_widget_grab_focus(summaryview->folderview->ctree);
+               folderview_grab_focus(summaryview->folderview);
                mainwindow_exit_folder(summaryview->mainwin);
                return TRUE;
        case GDK_KEY_Home: case GDK_KEY_KP_Home:
@@ -7867,32 +7832,31 @@ static void summary_set_hide_menu (SummaryView *summaryview,
 
 void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
 {
-       GtkWidget *ctree = summaryview->ctree;
        GtkWidget *pixmap; 
 
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_MARK, &markxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_DELETED, &deletedxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_NEW, &newxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_UNREAD, &unreadxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_REPLIED, &repliedxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_FORWARDED, &forwardedxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_REPLIED_AND_FORWARDED, &repliedandforwardedxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_CLIP, &clipxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_LOCKED, &lockedxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_IGNORETHREAD, &ignorethreadxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_WATCHTHREAD, &watchthreadxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_CLIP_KEY, &clipkeyxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_KEY, &keyxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_KEY_SIGN, &keysignxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_GPG_SIGNED, &gpgsignedxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_CLIP_GPG_SIGNED, &clipgpgsignedxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_SPAM, &spamxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_MOVED, &movedxpm);
-       stock_pixbuf_gdk(ctree, STOCK_PIXMAP_COPIED, &copiedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_MARK, &markxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_DELETED, &deletedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_NEW, &newxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_UNREAD, &unreadxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_REPLIED, &repliedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_FORWARDED, &forwardedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_REPLIED_AND_FORWARDED, &repliedandforwardedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CLIP, &clipxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_LOCKED, &lockedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_IGNORETHREAD, &ignorethreadxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_WATCHTHREAD, &watchthreadxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CLIP_KEY, &clipkeyxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_KEY, &keyxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_KEY_SIGN, &keysignxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_GPG_SIGNED, &gpgsignedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_CLIP_GPG_SIGNED, &clipgpgsignedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_SPAM, &spamxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_MOVED, &movedxpm);
+       stock_pixbuf_gdk(STOCK_PIXMAP_COPIED, &copiedxpm);
 
        summary_set_folder_pixmap(summaryview, STOCK_PIXMAP_DIR_OPEN);
 
-       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_QUICKSEARCH);
+       pixmap = stock_pixmap_widget(STOCK_PIXMAP_QUICKSEARCH);
        gtk_container_remove (GTK_CONTAINER(summaryview->toggle_search), 
                              summaryview->quick_search_pixmap);
        gtk_container_add(GTK_CONTAINER(summaryview->toggle_search), pixmap);
@@ -7900,7 +7864,7 @@ void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
        summaryview->quick_search_pixmap = pixmap;
 
 #ifdef GENERIC_UMPC
-       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_SELECTION);
+       pixmap = stock_pixmap_widget(STOCK_PIXMAP_SELECTION);
        gtk_container_remove (GTK_CONTAINER(summaryview->multiple_sel_togbtn), 
                              summaryview->multiple_sel_image);
        gtk_container_add(GTK_CONTAINER(summaryview->multiple_sel_togbtn), pixmap);
@@ -8149,7 +8113,7 @@ static void summary_find_answers (SummaryView *summaryview, MsgInfo *msg)
 
        node = gtk_cmctree_node_nth(GTK_CMCTREE(summaryview->ctree), 0);
        if (node)
-               summary_select_node(summaryview, node, TRUE, TRUE);
+               summary_select_node(summaryview, node, 1);
 }
 
 gint summaryview_export_mbox_list(SummaryView *summaryview)