remove unnecessary allocations for search bar fixing leaks reported by Martin Kluge...
[claws.git] / src / summaryview.c
index 937375c098e4504b861ce10ffcb0a0fa4cfcd7cb..9048d28be3d15301ad4c2ea21a28a9429725f671 100644 (file)
@@ -83,6 +83,7 @@
 #include "prefs_folder_item.h"
 #include "filtering.h"
 #include "string_match.h"
+#include "toolbar.h"
 
 #define SUMMARY_COL_MARK_WIDTH         10
 #define SUMMARY_COL_UNREAD_WIDTH       13
@@ -179,7 +180,6 @@ static void summary_display_msg_full        (SummaryView            *summaryview,
                                         gboolean                all_headers);
 static void summary_set_row_marks      (SummaryView            *summaryview,
                                         GtkCTreeNode           *row);
-static void summaryview_subject_filter_init (PrefsFolderItem    *prefs);
 
 /* message handling */
 static void summary_mark_row           (SummaryView            *summaryview,
@@ -261,6 +261,11 @@ static void summary_button_released        (GtkWidget              *ctree,
 static void summary_key_pressed                (GtkWidget              *ctree,
                                         GdkEventKey            *event,
                                         SummaryView            *summaryview);
+static void summary_searchbar_pressed  (GtkWidget              *ctree,
+                                        GdkEventKey            *event,
+                                        SummaryView            *summaryview);
+static void summary_searchtype_changed (GtkMenuItem            *widget, 
+                                        gpointer                data);
 static void summary_open_row           (GtkSCTree              *sctree,
                                         SummaryView            *summaryview);
 static void summary_tree_expanded      (GtkCTree               *ctree,
@@ -367,6 +372,10 @@ static gint summary_cmp_by_label   (GtkCList               *clist,
 
 static void news_flag_crosspost                (MsgInfo *msginfo);
 
+static void tog_searchbar_cb           (GtkWidget      *w,
+                                        gpointer        data);
+
+
 GtkTargetEntry summary_drag_types[1] =
 {
        {"text/plain", GTK_TARGET_SAME_APP, TARGET_DUMMY}
@@ -446,6 +455,7 @@ SummaryView *summary_create(void)
        GtkWidget *ctree;
        GtkWidget *hbox;
        GtkWidget *hbox_l;
+       GtkWidget *hbox_search;
        GtkWidget *statlabel_folder;
        GtkWidget *statlabel_select;
        GtkWidget *statlabel_msgs;
@@ -453,13 +463,55 @@ SummaryView *summary_create(void)
        GtkWidget *toggle_eventbox;
        GtkWidget *toggle_arrow;
        GtkWidget *popupmenu;
+       GtkWidget *search_type_opt;
+       GtkWidget *search_type;
+       GtkWidget *search_string;
+       GtkWidget *menuitem;
+       GtkWidget *toggle_search;
+       GtkTooltips *search_tip;
        GtkItemFactory *popupfactory;
        gint n_entries;
 
-       debug_print(_("Creating summary view...\n"));
+       debug_print("Creating summary view...\n");
        summaryview = g_new0(SummaryView, 1);
 
-       vbox = gtk_vbox_new(FALSE, 2);
+       vbox = gtk_vbox_new(FALSE, 3);
+       
+       /* create status label */
+       hbox = gtk_hbox_new(FALSE, 0);
+       
+       search_tip = gtk_tooltips_new();
+       toggle_search = gtk_toggle_button_new();
+
+       gtk_tooltips_set_tip(GTK_TOOLTIPS(search_tip),
+                            toggle_search,
+                            _("Toggle quick-search bar"), NULL);
+       
+       gtk_box_pack_start(GTK_BOX(hbox), toggle_search, FALSE, FALSE, 2);      
+
+       hbox_l = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_start(GTK_BOX(hbox), hbox_l, TRUE, TRUE, 0);
+       statlabel_folder = gtk_label_new("");
+       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_folder, FALSE, FALSE, 2);
+       statlabel_select = gtk_label_new("");
+       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_select, FALSE, FALSE, 12);
+       /* toggle view button */
+       toggle_eventbox = gtk_event_box_new();
+       gtk_box_pack_end(GTK_BOX(hbox), toggle_eventbox, FALSE, FALSE, 4);
+       toggle_arrow = gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
+       gtk_container_add(GTK_CONTAINER(toggle_eventbox), toggle_arrow);
+       gtk_signal_connect(GTK_OBJECT(toggle_eventbox), "button_press_event",
+                          GTK_SIGNAL_FUNC(summary_toggle_pressed),
+                          summaryview);
+       
+       
+       statlabel_msgs = gtk_label_new("");
+       gtk_box_pack_end(GTK_BOX(hbox), statlabel_msgs, FALSE, FALSE, 4);
+
+       hbox_spc = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_end(GTK_BOX(hbox), hbox_spc, FALSE, FALSE, 6);
 
        scrolledwin = gtk_scrolled_window_new(NULL, NULL);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolledwin),
@@ -478,32 +530,47 @@ SummaryView *summary_create(void)
                                            GTK_CLIST(ctree)->vadjustment);
        gtk_container_add(GTK_CONTAINER(scrolledwin), ctree);
 
-       /* create status label */
-       hbox = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_end(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
+       /* status label */
+       gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
 
-       hbox_l = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_start(GTK_BOX(hbox), hbox_l, TRUE, TRUE, 0);
+       /* quick search */
+       hbox_search = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_start(GTK_BOX(vbox), hbox_search, FALSE, FALSE, 0);
 
-       statlabel_folder = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_folder, FALSE, FALSE, 2);
-       statlabel_select = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_select, FALSE, FALSE, 12);
+       search_type_opt = gtk_option_menu_new();
+       gtk_widget_show(search_type_opt);
+       gtk_box_pack_start(GTK_BOX(hbox_search), search_type_opt, FALSE, FALSE, 0);
 
-       /* toggle view button */
-       toggle_eventbox = gtk_event_box_new();
-       gtk_box_pack_end(GTK_BOX(hbox), toggle_eventbox, FALSE, FALSE, 4);
-       toggle_arrow = gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
-       gtk_container_add(GTK_CONTAINER(toggle_eventbox), toggle_arrow);
-       gtk_signal_connect(GTK_OBJECT(toggle_eventbox), "button_press_event",
-                          GTK_SIGNAL_FUNC(summary_toggle_pressed),
+       search_type = gtk_menu_new();
+       MENUITEM_ADD (search_type, menuitem, _("Subject"), S_SEARCH_SUBJECT);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
+                          summaryview);
+       MENUITEM_ADD (search_type, menuitem, _("From"), S_SEARCH_FROM);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
+                          summaryview);
+       MENUITEM_ADD (search_type, menuitem, _("To"), S_SEARCH_TO);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
                           summaryview);
 
-       statlabel_msgs = gtk_label_new("");
-       gtk_box_pack_end(GTK_BOX(hbox), statlabel_msgs, FALSE, FALSE, 4);
+       gtk_option_menu_set_menu(GTK_OPTION_MENU(search_type_opt), search_type);
+       gtk_widget_show(search_type);
+       
+       search_string = gtk_entry_new();
+       
+       gtk_box_pack_start(GTK_BOX(hbox_search), search_string, FALSE, FALSE, 2);
+       
+       gtk_widget_show(search_string);
+       gtk_widget_show(hbox_search);
 
-       hbox_spc = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_end(GTK_BOX(hbox), hbox_spc, FALSE, FALSE, 6);
+       gtk_signal_connect(GTK_OBJECT(search_string), "key_press_event",
+                          GTK_SIGNAL_FUNC(summary_searchbar_pressed),
+                          summaryview);
+
+       gtk_signal_connect (GTK_OBJECT(toggle_search), "toggled",
+                        GTK_SIGNAL_FUNC(tog_searchbar_cb), hbox_search);
 
        /* create popup menu */
        n_entries = sizeof(summary_popup_entries) /
@@ -517,14 +584,19 @@ SummaryView *summary_create(void)
        summaryview->ctree = ctree;
        summaryview->hbox = hbox;
        summaryview->hbox_l = hbox_l;
+       summaryview->hbox_search = hbox_search;
        summaryview->statlabel_folder = statlabel_folder;
        summaryview->statlabel_select = statlabel_select;
        summaryview->statlabel_msgs = statlabel_msgs;
        summaryview->toggle_eventbox = toggle_eventbox;
        summaryview->toggle_arrow = toggle_arrow;
+       summaryview->toggle_search = toggle_search;
        summaryview->popupmenu = popupmenu;
        summaryview->popupfactory = popupfactory;
        summaryview->lock_count = 0;
+       summaryview->search_type_opt = search_type_opt;
+       summaryview->search_type = search_type;
+       summaryview->search_string = search_string;
 
        /* CLAWS: need this to get the SummaryView * from
         * the CList */
@@ -603,6 +675,17 @@ void summary_init(SummaryView *summaryview)
        gtk_widget_show(pixmap);
        summaryview->folder_pixmap = pixmap;
 
+       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_QUICKSEARCH);
+       gtk_container_add (GTK_CONTAINER(summaryview->toggle_search), pixmap);
+       gtk_widget_show(pixmap);
+       
+       /* Init summaryview prefs */
+       summaryview->sort_key = SORT_BY_NONE;
+       summaryview->sort_type = SORT_ASCENDING;
+
+       /* Init summaryview extra data */
+       summaryview->simplify_subject_preg = NULL;
+
        summary_clear_list(summaryview);
        summary_set_column_titles(summaryview);
        summary_colorlabel_menu_create(summaryview);
@@ -688,6 +771,11 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
        inc_lock();
        summary_lock(summaryview);
 
+       if (item != summaryview->folder_item) {
+               /* changing folder, reset search */
+               gtk_entry_set_text(GTK_ENTRY(summaryview->search_string), "");
+       }
+       
        STATUSBAR_POP(summaryview->mainwin);
 
        is_refresh = (!prefs_common.open_inbox_on_inc &&
@@ -734,7 +822,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
             ((buf = folder_item_get_path(item)) == NULL ||
              change_dir(buf) < 0))) {
                g_free(buf);
-               debug_print(_("empty folder\n\n"));
+               debug_print("empty folder\n\n");
                summary_set_hide_read_msgs_menu(summaryview, FALSE);
                if (is_refresh)
                        messageview_clear(summaryview->messageview);
@@ -803,6 +891,41 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
                summary_set_hide_read_msgs_menu(summaryview, FALSE);
        }
 
+       if (strlen(gtk_entry_get_text(GTK_ENTRY(summaryview->search_string))) > 0) {
+               GSList *not_killed;
+               gint search_type = GPOINTER_TO_INT(gtk_object_get_user_data(
+                                  GTK_OBJECT(GTK_MENU_ITEM(gtk_menu_get_active(
+                                  GTK_MENU(summaryview->search_type))))));
+               gchar *search_string = gtk_entry_get_text(GTK_ENTRY(summaryview->search_string));
+               gchar *searched_header = NULL;
+               
+               not_killed = NULL;
+               for (cur = mlist ; cur != NULL ; cur = g_slist_next(cur)) {
+                       MsgInfo * msginfo = (MsgInfo *) cur->data;
+
+                       switch (search_type) {
+                       case S_SEARCH_SUBJECT:
+                               searched_header = msginfo->subject;
+                               break;
+                       case S_SEARCH_FROM:
+                               searched_header = msginfo->from;
+                               break;
+                       case S_SEARCH_TO:
+                               searched_header = msginfo->to;
+                               break;
+                       default:
+                               debug_print("unknown search type (%d)\n", search_type);
+                               break;
+                       }
+                       if (searched_header && strcasestr(searched_header, search_string) != NULL)
+                               not_killed = g_slist_append(not_killed, msginfo);
+                       else
+                               procmsg_msginfo_free(msginfo);
+               }
+               g_slist_free(mlist);
+               mlist = not_killed;
+       }
+       
        if ((global_scoring || item->prefs->scoring)) {
                GSList *not_killed;
                gint kill_score;
@@ -831,11 +954,8 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
 
        g_slist_free(mlist);
 
-       folderview_update_msg_num(summaryview->folderview,
-                                 summaryview->folderview->opened);
-
-       if (item->sort_key != SORT_BY_NONE)
-               summary_sort(summaryview, item->sort_key, item->sort_type);
+       if (summaryview->sort_key != SORT_BY_NONE)
+               summary_sort(summaryview, summaryview->sort_key, summaryview->sort_type);
 
        gtk_signal_handler_unblock_by_data(GTK_OBJECT(ctree), summaryview);
 
@@ -862,7 +982,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
                }
        } else {
                /* select first unread message */
-               if (item->sort_key == SORT_BY_SCORE)
+               if (summaryview->sort_key == SORT_BY_SCORE)
                        node = summary_find_next_important_score(summaryview,
                                                                 NULL);
                else
@@ -884,7 +1004,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
 
        summary_status_show(summaryview);
        summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
+       toolbar_set_sensitive(summaryview->mainwin);
 
        debug_print("\n");
        STATUSBAR_PUSH(summaryview->mainwin, _("Done."));
@@ -949,7 +1069,7 @@ void summary_clear_all(SummaryView *summaryview)
 {
        summary_clear_list(summaryview);
        summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
+       toolbar_set_sensitive(summaryview->mainwin);
        summary_status_show(summaryview);
 }
 
@@ -1510,7 +1630,7 @@ void summary_attract_by_subject(SummaryView *summaryview)
        MsgInfo *src_msginfo, *dst_msginfo;
        GHashTable *subject_table;
 
-       debug_print(_("Attracting messages by subject..."));
+       debug_print("Attracting messages by subject...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Attracting messages by subject..."));
 
@@ -1556,7 +1676,7 @@ void summary_attract_by_subject(SummaryView *summaryview)
 
        gtk_clist_thaw(clist);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
 
        main_window_cursor_normal(summaryview->mainwin);
@@ -1735,7 +1855,6 @@ static void summary_set_column_titles(SummaryView *summaryview)
        SummaryColumnType type;
        gboolean single_char;
        GtkJustification justify;
-       FolderItem *item = summaryview->folder_item;
 
        static FolderSortKey sort_by[N_SUMMARY_COLS] = {
                SORT_BY_MARK,
@@ -1806,9 +1925,9 @@ static void summary_set_column_titles(SummaryView *summaryview)
                        gtk_box_pack_start(GTK_BOX(hbox), label,
                                           FALSE, FALSE, 0);
 
-               if (item && item->sort_key == sort_by[type]) {
+               if (summaryview->sort_key == sort_by[type]) {
                        arrow = gtk_arrow_new
-                               (item->sort_type == SORT_ASCENDING
+                               (summaryview->sort_type == SORT_ASCENDING
                                 ? GTK_ARROW_DOWN : GTK_ARROW_UP,
                                 GTK_SHADOW_IN);
                        if (justify == GTK_JUSTIFY_RIGHT)
@@ -1829,10 +1948,7 @@ void summary_sort(SummaryView *summaryview,
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCList *clist = GTK_CLIST(summaryview->ctree);
-       GtkCListCompareFunc cmp_func;
-       FolderItem *item = summaryview->folder_item;
-
-       if (!item || !item->path || !item->parent || item->no_select) return;
+       GtkCListCompareFunc cmp_func = NULL;
 
        switch (sort_key) {
        case SORT_BY_MARK:
@@ -1857,14 +1973,10 @@ void summary_sort(SummaryView *summaryview,
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_from;
                break;
        case SORT_BY_SUBJECT:
-               {
-                       PrefsFolderItem *prefs = summaryview->folder_item->prefs;
-
-                       if (prefs == NULL) 
-                               cmp_func = (GtkCListCompareFunc)summary_cmp_by_subject;
-                       else
-                               cmp_func = (GtkCListCompareFunc)summary_cmp_by_simplified_subject;
-               }                               
+               if (summaryview->simplify_subject_preg)
+                       cmp_func = (GtkCListCompareFunc)summary_cmp_by_simplified_subject;
+               else
+                       cmp_func = (GtkCListCompareFunc)summary_cmp_by_subject;
                break;
        case SORT_BY_SCORE:
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_score;
@@ -1876,37 +1988,36 @@ void summary_sort(SummaryView *summaryview,
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_label;
                break;
        case SORT_BY_NONE:
-               item->sort_key = sort_key;
-               item->sort_type = SORT_ASCENDING;
-               summary_set_column_titles(summaryview);
-               summary_set_menu_sensitive(summaryview);
+               cmp_func = NULL;
                return;
        default:
                return;
        }
 
-       debug_print(_("Sorting summary..."));
-       STATUSBAR_PUSH(summaryview->mainwin, _("Sorting summary..."));
+       summaryview->sort_key = sort_key;
+       summaryview->sort_type = sort_type;
 
-       main_window_cursor_wait(summaryview->mainwin);
+       summary_set_column_titles(summaryview);
+       summary_set_menu_sensitive(summaryview);
+       if(cmp_func != NULL) {
+               debug_print("Sorting summary...");
+               STATUSBAR_PUSH(summaryview->mainwin, _("Sorting summary..."));
 
-       gtk_clist_set_compare_func(clist, cmp_func);
+               main_window_cursor_wait(summaryview->mainwin);
 
-       gtk_clist_set_sort_type(clist, (GtkSortType)sort_type);
-       item->sort_key = sort_key;
-       item->sort_type = sort_type;
+               gtk_clist_set_compare_func(clist, cmp_func);
 
-       summary_set_column_titles(summaryview);
-       summary_set_menu_sensitive(summaryview);
+               gtk_clist_set_sort_type(clist, (GtkSortType)sort_type);
 
-       gtk_sctree_sort_recursive(ctree, NULL);
+               gtk_sctree_sort_recursive(ctree, NULL);
 
-       gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
+               gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
 
-       debug_print(_("done.\n"));
-       STATUSBAR_POP(summaryview->mainwin);
+               main_window_cursor_normal(summaryview->mainwin);
 
-       main_window_cursor_normal(summaryview->mainwin);
+               debug_print("done.\n");
+               STATUSBAR_POP(summaryview->mainwin);
+       }
 }
 
 gboolean summary_insert_gnode_func(GtkCTree *ctree, guint depth, GNode *gnode,
@@ -1958,7 +2069,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
        
        if (!mlist) return;
 
-       debug_print(_("\tSetting summary from message data..."));
+       debug_print("\tSetting summary from message data...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Setting summary from message data..."));
        gdk_flush();
@@ -1984,9 +2095,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
                                summaryview->folder_item->prefs->important_score;
        }
 
-       summaryview_subject_filter_init(summaryview->folder_item->prefs);
-       
-       if (summaryview->folder_item->threaded) {
+       if (summaryview->threaded) {
                GNode *root, *gnode;
 
                root = procmsg_get_thread_tree(mlist);
@@ -2041,7 +2150,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
        if (prefs_common.use_addr_book)
                end_address_completion();
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        if (debug_mode) {
                debug_print("\tmsgid hash table size = %d\n",
@@ -2078,9 +2187,9 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
 {
        static gchar date_modified[80];
        static gchar *to = NULL;
+       static gchar *from = NULL;
        static gchar col_score[11];
        static gchar buf[BUFFSIZE];
-       PrefsFolderItem *prefs = summaryview->folder_item->prefs;
        gint *col_pos = summaryview->col_pos;
 
        text[col_pos[S_COL_MARK]]   = NULL;
@@ -2132,24 +2241,16 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
         * the --> in sent boxes) was executed.
         */
        if (text[col_pos[S_COL_FROM]] != to && prefs_common.use_addr_book && msginfo->from) {
-               gchar *from;
+               g_free(from);
                from = summary_complete_address(msginfo->from);
-               if (from) {
-                       /*
-                        * FIXME: this text[col_pos[S_COL_FROM]] should be freed
-                        * but may have been assigned _("No From"). Should be
-                        * freed??? 
-                        */
+               if (from)
                        text[col_pos[S_COL_FROM]] = from;
-               }       
        }
 
-       if (prefs->enable_simplify_subject 
-           && prefs->simplify_subject_preg != NULL )
+       if (summaryview->simplify_subject_preg != NULL)
                text[col_pos[S_COL_SUBJECT]] = msginfo->subject ? 
                        string_remove_match(buf, BUFFSIZE, msginfo->subject, 
-                                       prefs->simplify_subject_preg) : 
-                       
+                                       summaryview->simplify_subject_preg) : 
                        _("(No Subject)");
        else 
                text[col_pos[S_COL_SUBJECT]] = msginfo->subject ? msginfo->subject :
@@ -2211,7 +2312,7 @@ static void summary_display_msg_full(SummaryView *summaryview,
        if (new_window) {
                MessageView *msgview;
 
-               msgview = messageview_create_with_new_window();
+               msgview = messageview_create_with_new_window(summaryview->mainwin);
                messageview_show(msgview, msginfo, all_headers);
        } else {
                MessageView *msgview;
@@ -2233,7 +2334,7 @@ static void summary_display_msg_full(SummaryView *summaryview,
        }
 
        summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
+       toolbar_set_sensitive(summaryview->mainwin);
 
        summary_unlock(summaryview);
 }
@@ -2525,7 +2626,7 @@ static void summary_mark_row(SummaryView *summaryview, GtkCTreeNode *row)
        procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, MSG_MOVE | MSG_COPY);
        procmsg_msginfo_set_flags(msginfo, MSG_MARKED, 0);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %s/%d is marked\n"), msginfo->folder->path, msginfo->msgnum);
+       debug_print("Message %s/%d is marked\n", msginfo->folder->path, msginfo->msgnum);
 }
 
 static void summary_lock_row(SummaryView *summaryview, GtkCTreeNode *row)
@@ -2555,7 +2656,7 @@ static void summary_lock_row(SummaryView *summaryview, GtkCTreeNode *row)
        procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, MSG_MOVE | MSG_COPY);
        procmsg_msginfo_set_flags(msginfo, MSG_LOCKED, 0);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is locked\n"), msginfo->msgnum);
+       debug_print("Message %d is locked\n", msginfo->msgnum);
 }
 
 void summary_mark(SummaryView *summaryview)
@@ -2578,6 +2679,9 @@ static void summary_mark_row_as_read(SummaryView *summaryview,
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
 
+       if(!MSG_IS_NEW(msginfo->flags) && !MSG_IS_UNREAD(msginfo->flags))
+               return;
+
        if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
@@ -2585,7 +2689,7 @@ static void summary_mark_row_as_read(SummaryView *summaryview,
 
        procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is marked as read\n"),
+       debug_print("Message %d is marked as read\n",
                msginfo->msgnum);
 }
 
@@ -2639,7 +2743,7 @@ static void summary_mark_row_as_unread(SummaryView *summaryview,
 
        procmsg_msginfo_unset_flags(msginfo, MSG_REPLIED | MSG_FORWARDED, 0);
        procmsg_msginfo_set_flags(msginfo, MSG_UNREAD, 0);
-       debug_print(_("Message %d is marked as unread\n"),
+       debug_print("Message %d is marked as unread\n",
                msginfo->msgnum);
 
        summary_set_row_marks(summaryview, row);
@@ -2743,7 +2847,7 @@ static void summary_delete_row(SummaryView *summaryview, GtkCTreeNode *row)
            summaryview->folder_item->stype != F_TRASH)
                summary_set_row_marks(summaryview, row);
 
-       debug_print(_("Message %s/%d is set to delete\n"),
+       debug_print("Message %s/%d is set to delete\n",
                    msginfo->folder->path, msginfo->msgnum);
 }
 
@@ -2808,7 +2912,7 @@ void summary_delete_duplicated(SummaryView *summaryview)
        if (summaryview->folder_item->stype == F_TRASH) return;
 
        main_window_cursor_wait(summaryview->mainwin);
-       debug_print(_("Deleting duplicated messages..."));
+       debug_print("Deleting duplicated messages...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Deleting duplicated messages..."));
 
@@ -2821,7 +2925,7 @@ void summary_delete_duplicated(SummaryView *summaryview)
        else
                summary_status_show(summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 }
@@ -2866,7 +2970,7 @@ static void summary_unmark_row(SummaryView *summaryview, GtkCTreeNode *row)
        procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_MOVE | MSG_COPY);
        summary_set_row_marks(summaryview, row);
 
-       debug_print(_("Message %s/%d is unmarked\n"),
+       debug_print("Message %s/%d is unmarked\n",
                    msginfo->folder->path, msginfo->msgnum);
 }
 
@@ -2923,7 +3027,7 @@ static void summary_move_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                }
        }
 
-       debug_print(_("Message %d is set to move to %s\n"),
+       debug_print("Message %d is set to move to %s\n",
                    msginfo->msgnum, to_folder->path);
 }
 
@@ -3012,7 +3116,7 @@ static void summary_copy_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                }
        }
 
-       debug_print(_("Message %d is set to copy to %s\n"),
+       debug_print("Message %d is set to copy to %s\n",
                    msginfo->msgnum, to_folder->path);
 }
 
@@ -3121,7 +3225,7 @@ void summary_save_as(SummaryView *summaryview)
        }
 
        src = procmsg_get_message_file(msginfo);
-       if (copy_file(src, dest) < 0) {
+       if (copy_file(src, dest, TRUE) < 0) {
                alertpanel_error(_("Can't save the file `%s'."),
                                 g_basename(dest));
        }
@@ -3174,7 +3278,7 @@ gboolean summary_execute(SummaryView *summaryview)
 
        gtk_clist_freeze(clist);
 
-       if (summaryview->folder_item->threaded)
+       if (summaryview->threaded)
                summary_unthread_for_exec(summaryview);
 
        summary_execute_move(summaryview);
@@ -3197,7 +3301,7 @@ gboolean summary_execute(SummaryView *summaryview)
                node = next;
        }
 
-       if (summaryview->folder_item->threaded)
+       if (summaryview->threaded)
                summary_thread_build(summaryview);
 
        summaryview->selected = clist->selection ?
@@ -3235,7 +3339,7 @@ static void summary_execute_move(SummaryView *summaryview)
        if (summaryview->mlist) {
                procmsg_move_messages(summaryview->mlist);
 
-               folderview_update_item_foreach(summaryview->folder_table);
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                for (cur = summaryview->mlist; cur != NULL; cur = cur->next)
                        procmsg_msginfo_free((MsgInfo *)cur->data);
@@ -3290,7 +3394,7 @@ static void summary_execute_copy(SummaryView *summaryview)
                procmsg_copy_messages(summaryview->mlist);
 
                /* folder_item_scan_foreach(summaryview->folder_table); */
-               folderview_update_item_foreach(summaryview->folder_table);
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                g_slist_free(summaryview->mlist);
                summaryview->mlist = NULL;
@@ -3392,7 +3496,7 @@ void summary_thread_build(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Building threads..."));
+       debug_print("Building threads...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Building threads..."));
        main_window_cursor_wait(summaryview->mainwin);
 
@@ -3446,10 +3550,12 @@ void summary_thread_build(SummaryView *summaryview)
        gtk_signal_handler_unblock_by_func(GTK_OBJECT(ctree),
                                           summary_tree_expanded, summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
+       summaryview->threaded = TRUE;
+
        summary_unlock(summaryview);
 }
 
@@ -3486,7 +3592,7 @@ void summary_unthread(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Unthreading..."));
+       debug_print("Unthreading...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Unthreading..."));
        main_window_cursor_wait(summaryview->mainwin);
        
@@ -3513,10 +3619,12 @@ void summary_unthread(SummaryView *summaryview)
        gtk_signal_handler_unblock_by_func(GTK_OBJECT(ctree),
                                           summary_tree_collapsed, summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
+       summaryview->threaded = FALSE;
+
        summary_unlock(summaryview);
 }
 
@@ -3527,7 +3635,7 @@ static void summary_unthread_for_exec(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Unthreading for execution..."));
+       debug_print("Unthreading for execution...");
 
        gtk_clist_freeze(GTK_CLIST(ctree));
 
@@ -3538,7 +3646,7 @@ static void summary_unthread_for_exec(SummaryView *summaryview)
 
        gtk_clist_thaw(GTK_CLIST(ctree));
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
 
        summary_unlock(summaryview);
 }
@@ -3620,7 +3728,7 @@ void summary_filter(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("filtering..."));
+       debug_print("filtering...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Filtering..."));
        main_window_cursor_wait(summaryview->mainwin);
 
@@ -3650,13 +3758,13 @@ void summary_filter(SummaryView *summaryview)
                gtk_clist_thaw(GTK_CLIST(summaryview->ctree));
 
                /* folder_item_scan_foreach(summaryview->folder_table); */
-               folderview_update_item_foreach(summaryview->folder_table);
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                g_hash_table_destroy(summaryview->folder_table);
                summaryview->folder_table = NULL;
        }
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
@@ -4367,6 +4475,31 @@ static void summary_key_pressed(GtkWidget *widget, GdkEventKey *event,
        }
 }
 
+static void summary_searchbar_pressed(GtkWidget *widget, GdkEventKey *event,
+                               SummaryView *summaryview)
+{
+       if (event != NULL && event->keyval == GDK_Return)
+               summary_show(summaryview, summaryview->folder_item);
+}
+
+static void summary_searchtype_changed(GtkMenuItem *widget, gpointer data)
+{
+       SummaryView *sw = (SummaryView *)data;
+       if (gtk_entry_get_text(GTK_ENTRY(sw->search_string)))
+               summary_show(sw, sw->folder_item);
+}
+
+static void tog_searchbar_cb(GtkWidget *w, gpointer data)
+{
+       if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(w))) {
+               prefs_common.show_searchbar = TRUE;
+               gtk_widget_show(GTK_WIDGET(data));
+       } else {
+               prefs_common.show_searchbar = FALSE;
+               gtk_widget_hide(GTK_WIDGET(data));
+       }
+}
+
 static void summary_open_row(GtkSCTree *sctree, SummaryView *summaryview)
 {
        if (summaryview->folder_item->stype == F_OUTBOX ||
@@ -4402,7 +4535,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
             GTK_CLIST(ctree)->selection->next) {
                summaryview->display_msg = FALSE;
                summary_set_menu_sensitive(summaryview);
-               main_window_set_toolbar_sensitive(summaryview->mainwin);
+               toolbar_set_sensitive(summaryview->mainwin);
                return;
        }
 
@@ -4447,7 +4580,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
                summaryview->display_msg = FALSE;
        } else {
                summary_set_menu_sensitive(summaryview);
-               main_window_set_toolbar_sensitive(summaryview->mainwin);
+               toolbar_set_sensitive(summaryview->mainwin);
        }
 }
 
@@ -4493,13 +4626,9 @@ static void summary_create_filter_cb(SummaryView *summaryview,
 static void summary_sort_by_column_click(SummaryView *summaryview,
                                         FolderSortKey sort_key)
 {
-       FolderItem *item = summaryview->folder_item;
-
-       if (!item) return;
-
-       if (item->sort_key == sort_key)
+       if (summaryview->sort_key == sort_key)
                summary_sort(summaryview, sort_key,
-                            item->sort_type == SORT_ASCENDING
+                            summaryview->sort_type == SORT_ASCENDING
                             ? SORT_DESCENDING : SORT_ASCENDING);
        else
                summary_sort(summaryview, sort_key, SORT_ASCENDING);
@@ -4719,7 +4848,7 @@ static gint summary_cmp_by_simplified_subject
        const SummaryView *sv = gtk_object_get_data(GTK_OBJECT(clist), "summaryview");
        
        g_return_val_if_fail(sv, -1);
-       g_return_val_if_fail(msginfo1 == NULL || msginfo2 == NULL, -1);
+       g_return_val_if_fail(msginfo1 != NULL && msginfo2 != NULL, -1);
        
        str1 = GTK_CELL_TEXT(r1->cell[sv->col_pos[S_COL_SUBJECT]])->text;
        str2 = GTK_CELL_TEXT(r2->cell[sv->col_pos[S_COL_SUBJECT]])->text;
@@ -4759,10 +4888,10 @@ static void news_flag_crosspost(MsgInfo *msginfo)
        if (mff->account->mark_crosspost_read && MSG_IS_NEWS(msginfo->flags)) {
                line = g_string_sized_new(128);
                g_string_sprintf(line, "%s:%d", msginfo->folder->path, msginfo->msgnum);
-               debug_print(_("nfcp: checking <%s>"), line->str);
+               debug_print("nfcp: checking <%s>", line->str);
                if (mff->newsart && 
                    g_hash_table_lookup_extended(mff->newsart, line->str, &key, &value)) {
-                       debug_print(_(" <%s>"), (gchar *)value);
+                       debug_print(" <%s>", (gchar *)value);
                        if (MSG_IS_NEW(msginfo->flags) || MSG_IS_UNREAD(msginfo->flags)) {
                                procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
                                procmsg_msginfo_set_flags(msginfo, mff->account->crosspost_col, 0);
@@ -4771,7 +4900,7 @@ static void news_flag_crosspost(MsgInfo *msginfo)
                        g_free(key);
                }
                g_string_free(line, TRUE);
-               debug_print(_("\n"));
+               debug_print("\n");
        }
 }
 
@@ -4806,7 +4935,7 @@ static void summary_select_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpoin
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
        gtk_ctree_select(GTK_CTREE(ctree), row);        
-       debug_print(_("Message %d selected\n"), msginfo->msgnum);
+       debug_print("Message %d selected\n", msginfo->msgnum);
 }
 
 /* select current thread */
@@ -4844,7 +4973,7 @@ static void summary_ignore_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpoin
        procmsg_msginfo_set_flags(msginfo, MSG_IGNORE_THREAD, 0);
 
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is marked as ignore thread\n"),
+       debug_print("Message %d is marked as ignore thread\n",
            msginfo->msgnum);
 }
 
@@ -4875,7 +5004,7 @@ static void summary_unignore_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpo
        procmsg_msginfo_unset_flags(msginfo, MSG_IGNORE_THREAD, 0);
 
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is marked as unignore thread\n"),
+       debug_print("Message %d is marked as unignore thread\n",
            msginfo->msgnum);
 }
 
@@ -4976,36 +5105,6 @@ static void summary_set_hide_read_msgs_menu (SummaryView *summaryview,
        gtk_object_set_data(GTK_OBJECT(widget), "dont_toggle",
                            GINT_TO_POINTER(0));
 }
-static void summaryview_subject_filter_init(PrefsFolderItem *prefs)
-{
-       int err;
-       gchar buf[BUFFSIZE];
-       if (prefs->enable_simplify_subject) {
-               if (prefs->simplify_subject_regexp && 
-                               *prefs->simplify_subject_regexp != 0x00) {
-
-                       if (!prefs->simplify_subject_preg) 
-                               prefs->simplify_subject_preg = g_new(regex_t, 1);
-                       else
-                               regfree(prefs->simplify_subject_preg);
-
-                       err = string_match_precompile(prefs->simplify_subject_regexp, 
-                                       prefs->simplify_subject_preg, REG_EXTENDED);
-                       if (err) {
-                               regerror(err, prefs->simplify_subject_preg, buf, BUFFSIZE);
-                               alertpanel_error(_("Regular expression (regexp) error:\n%s"), buf);
-                               g_free(prefs->simplify_subject_preg);
-                               prefs->simplify_subject_preg = NULL;
-                       }
-               } else {
-                       if (prefs->simplify_subject_preg) {
-                               regfree(prefs->simplify_subject_preg);
-                               g_free(prefs->simplify_subject_preg);
-                               prefs->simplify_subject_preg = NULL;
-                       }
-               }
-       }
-}
 
 void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
 {
@@ -5028,7 +5127,7 @@ void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
 
        pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_DIR_OPEN);
        gtk_box_pack_start(GTK_BOX(summaryview->hbox), pixmap, FALSE, FALSE, 4);
-       gtk_box_reorder_child(GTK_BOX(summaryview->hbox), pixmap, 0);
+       gtk_box_reorder_child(GTK_BOX(summaryview->hbox), pixmap, 1); /* search_toggle before */
        gtk_widget_show(pixmap);
        summaryview->folder_pixmap = pixmap; 
 
@@ -5039,7 +5138,8 @@ void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
 /*
  * Harvest addresses for selected messages in summary view.
  */
-void summary_harvest_address( SummaryView *summaryview ) {
+void summary_harvest_address(SummaryView *summaryview)
+{
        GtkCTree *ctree = GTK_CTREE( summaryview->ctree );
        GList *cur;
        GList *msgList;
@@ -5054,7 +5154,59 @@ void summary_harvest_address( SummaryView *summaryview ) {
        g_list_free( msgList );
 }
 
+static regex_t *summary_compile_simplify_regexp(gchar *simplify_subject_regexp)
+{
+       int err;
+       gchar buf[BUFFSIZE];
+       regex_t *preg = NULL;
+       
+       preg = g_new0(regex_t, 1);
+
+       err = string_match_precompile(simplify_subject_regexp, 
+                                     preg, REG_EXTENDED);
+       if (err) {
+               regerror(err, preg, buf, BUFFSIZE);
+               alertpanel_error(_("Regular expression (regexp) error:\n%s"), buf);
+               g_free(preg);
+               preg = NULL;
+       }
+       
+       return preg;
+}
+
+void summary_set_prefs_from_folderitem(SummaryView *summaryview, FolderItem *item)
+{
+       g_return_if_fail(summaryview != NULL);
+       g_return_if_fail(item != NULL);
+
+       /* Subject simplification */
+       if(summaryview->simplify_subject_preg) {
+               regfree(summaryview->simplify_subject_preg);
+               g_free(summaryview->simplify_subject_preg);
+               summaryview->simplify_subject_preg = NULL;
+       }
+       if(item->prefs && item->prefs->simplify_subject_regexp && 
+          item->prefs->simplify_subject_regexp[0] && item->prefs->enable_simplify_subject)
+               summaryview->simplify_subject_preg = summary_compile_simplify_regexp(item->prefs->simplify_subject_regexp);
+
+       /* Sorting */
+       summaryview->sort_key = item->sort_key;
+       summaryview->sort_type = item->sort_type;
+
+       /* Threading */
+       summaryview->threaded = item->threaded;
+}
+
+void summary_save_prefs_to_folderitem(SummaryView *summaryview, FolderItem *item)
+{
+       /* Sorting */
+       item->sort_key = summaryview->sort_key;
+       item->sort_type = summaryview->sort_type;
+
+       /* Threading */
+       item->threaded = summaryview->threaded;
+}
+
 /*
  * End of Source.
  */
-