remove unnecessary allocations for search bar fixing leaks reported by Martin Kluge...
[claws.git] / src / summaryview.c
index 27aee338077c83e3d1cb7af86dca9f2ef6fa8d5b..9048d28be3d15301ad4c2ea21a28a9429725f671 100644 (file)
@@ -261,6 +261,11 @@ static void summary_button_released        (GtkWidget              *ctree,
 static void summary_key_pressed                (GtkWidget              *ctree,
                                         GdkEventKey            *event,
                                         SummaryView            *summaryview);
+static void summary_searchbar_pressed  (GtkWidget              *ctree,
+                                        GdkEventKey            *event,
+                                        SummaryView            *summaryview);
+static void summary_searchtype_changed (GtkMenuItem            *widget, 
+                                        gpointer                data);
 static void summary_open_row           (GtkSCTree              *sctree,
                                         SummaryView            *summaryview);
 static void summary_tree_expanded      (GtkCTree               *ctree,
@@ -367,6 +372,10 @@ static gint summary_cmp_by_label   (GtkCList               *clist,
 
 static void news_flag_crosspost                (MsgInfo *msginfo);
 
+static void tog_searchbar_cb           (GtkWidget      *w,
+                                        gpointer        data);
+
+
 GtkTargetEntry summary_drag_types[1] =
 {
        {"text/plain", GTK_TARGET_SAME_APP, TARGET_DUMMY}
@@ -446,6 +455,7 @@ SummaryView *summary_create(void)
        GtkWidget *ctree;
        GtkWidget *hbox;
        GtkWidget *hbox_l;
+       GtkWidget *hbox_search;
        GtkWidget *statlabel_folder;
        GtkWidget *statlabel_select;
        GtkWidget *statlabel_msgs;
@@ -453,13 +463,55 @@ SummaryView *summary_create(void)
        GtkWidget *toggle_eventbox;
        GtkWidget *toggle_arrow;
        GtkWidget *popupmenu;
+       GtkWidget *search_type_opt;
+       GtkWidget *search_type;
+       GtkWidget *search_string;
+       GtkWidget *menuitem;
+       GtkWidget *toggle_search;
+       GtkTooltips *search_tip;
        GtkItemFactory *popupfactory;
        gint n_entries;
 
        debug_print("Creating summary view...\n");
        summaryview = g_new0(SummaryView, 1);
 
-       vbox = gtk_vbox_new(FALSE, 2);
+       vbox = gtk_vbox_new(FALSE, 3);
+       
+       /* create status label */
+       hbox = gtk_hbox_new(FALSE, 0);
+       
+       search_tip = gtk_tooltips_new();
+       toggle_search = gtk_toggle_button_new();
+
+       gtk_tooltips_set_tip(GTK_TOOLTIPS(search_tip),
+                            toggle_search,
+                            _("Toggle quick-search bar"), NULL);
+       
+       gtk_box_pack_start(GTK_BOX(hbox), toggle_search, FALSE, FALSE, 2);      
+
+       hbox_l = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_start(GTK_BOX(hbox), hbox_l, TRUE, TRUE, 0);
+       statlabel_folder = gtk_label_new("");
+       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_folder, FALSE, FALSE, 2);
+       statlabel_select = gtk_label_new("");
+       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_select, FALSE, FALSE, 12);
+       /* toggle view button */
+       toggle_eventbox = gtk_event_box_new();
+       gtk_box_pack_end(GTK_BOX(hbox), toggle_eventbox, FALSE, FALSE, 4);
+       toggle_arrow = gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
+       gtk_container_add(GTK_CONTAINER(toggle_eventbox), toggle_arrow);
+       gtk_signal_connect(GTK_OBJECT(toggle_eventbox), "button_press_event",
+                          GTK_SIGNAL_FUNC(summary_toggle_pressed),
+                          summaryview);
+       
+       
+       statlabel_msgs = gtk_label_new("");
+       gtk_box_pack_end(GTK_BOX(hbox), statlabel_msgs, FALSE, FALSE, 4);
+
+       hbox_spc = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_end(GTK_BOX(hbox), hbox_spc, FALSE, FALSE, 6);
 
        scrolledwin = gtk_scrolled_window_new(NULL, NULL);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolledwin),
@@ -478,32 +530,47 @@ SummaryView *summary_create(void)
                                            GTK_CLIST(ctree)->vadjustment);
        gtk_container_add(GTK_CONTAINER(scrolledwin), ctree);
 
-       /* create status label */
-       hbox = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_end(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
+       /* status label */
+       gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
 
-       hbox_l = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_start(GTK_BOX(hbox), hbox_l, TRUE, TRUE, 0);
+       /* quick search */
+       hbox_search = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_start(GTK_BOX(vbox), hbox_search, FALSE, FALSE, 0);
 
-       statlabel_folder = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_folder, FALSE, FALSE, 2);
-       statlabel_select = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_select, FALSE, FALSE, 12);
+       search_type_opt = gtk_option_menu_new();
+       gtk_widget_show(search_type_opt);
+       gtk_box_pack_start(GTK_BOX(hbox_search), search_type_opt, FALSE, FALSE, 0);
 
-       /* toggle view button */
-       toggle_eventbox = gtk_event_box_new();
-       gtk_box_pack_end(GTK_BOX(hbox), toggle_eventbox, FALSE, FALSE, 4);
-       toggle_arrow = gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
-       gtk_container_add(GTK_CONTAINER(toggle_eventbox), toggle_arrow);
-       gtk_signal_connect(GTK_OBJECT(toggle_eventbox), "button_press_event",
-                          GTK_SIGNAL_FUNC(summary_toggle_pressed),
+       search_type = gtk_menu_new();
+       MENUITEM_ADD (search_type, menuitem, _("Subject"), S_SEARCH_SUBJECT);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
+                          summaryview);
+       MENUITEM_ADD (search_type, menuitem, _("From"), S_SEARCH_FROM);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
+                          summaryview);
+       MENUITEM_ADD (search_type, menuitem, _("To"), S_SEARCH_TO);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
                           summaryview);
 
-       statlabel_msgs = gtk_label_new("");
-       gtk_box_pack_end(GTK_BOX(hbox), statlabel_msgs, FALSE, FALSE, 4);
+       gtk_option_menu_set_menu(GTK_OPTION_MENU(search_type_opt), search_type);
+       gtk_widget_show(search_type);
+       
+       search_string = gtk_entry_new();
+       
+       gtk_box_pack_start(GTK_BOX(hbox_search), search_string, FALSE, FALSE, 2);
+       
+       gtk_widget_show(search_string);
+       gtk_widget_show(hbox_search);
 
-       hbox_spc = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_end(GTK_BOX(hbox), hbox_spc, FALSE, FALSE, 6);
+       gtk_signal_connect(GTK_OBJECT(search_string), "key_press_event",
+                          GTK_SIGNAL_FUNC(summary_searchbar_pressed),
+                          summaryview);
+
+       gtk_signal_connect (GTK_OBJECT(toggle_search), "toggled",
+                        GTK_SIGNAL_FUNC(tog_searchbar_cb), hbox_search);
 
        /* create popup menu */
        n_entries = sizeof(summary_popup_entries) /
@@ -517,14 +584,19 @@ SummaryView *summary_create(void)
        summaryview->ctree = ctree;
        summaryview->hbox = hbox;
        summaryview->hbox_l = hbox_l;
+       summaryview->hbox_search = hbox_search;
        summaryview->statlabel_folder = statlabel_folder;
        summaryview->statlabel_select = statlabel_select;
        summaryview->statlabel_msgs = statlabel_msgs;
        summaryview->toggle_eventbox = toggle_eventbox;
        summaryview->toggle_arrow = toggle_arrow;
+       summaryview->toggle_search = toggle_search;
        summaryview->popupmenu = popupmenu;
        summaryview->popupfactory = popupfactory;
        summaryview->lock_count = 0;
+       summaryview->search_type_opt = search_type_opt;
+       summaryview->search_type = search_type;
+       summaryview->search_string = search_string;
 
        /* CLAWS: need this to get the SummaryView * from
         * the CList */
@@ -603,7 +675,15 @@ void summary_init(SummaryView *summaryview)
        gtk_widget_show(pixmap);
        summaryview->folder_pixmap = pixmap;
 
-       /* Init Summaryview prefs */
+       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_QUICKSEARCH);
+       gtk_container_add (GTK_CONTAINER(summaryview->toggle_search), pixmap);
+       gtk_widget_show(pixmap);
+       
+       /* Init summaryview prefs */
+       summaryview->sort_key = SORT_BY_NONE;
+       summaryview->sort_type = SORT_ASCENDING;
+
+       /* Init summaryview extra data */
        summaryview->simplify_subject_preg = NULL;
 
        summary_clear_list(summaryview);
@@ -691,6 +771,11 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
        inc_lock();
        summary_lock(summaryview);
 
+       if (item != summaryview->folder_item) {
+               /* changing folder, reset search */
+               gtk_entry_set_text(GTK_ENTRY(summaryview->search_string), "");
+       }
+       
        STATUSBAR_POP(summaryview->mainwin);
 
        is_refresh = (!prefs_common.open_inbox_on_inc &&
@@ -806,6 +891,41 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
                summary_set_hide_read_msgs_menu(summaryview, FALSE);
        }
 
+       if (strlen(gtk_entry_get_text(GTK_ENTRY(summaryview->search_string))) > 0) {
+               GSList *not_killed;
+               gint search_type = GPOINTER_TO_INT(gtk_object_get_user_data(
+                                  GTK_OBJECT(GTK_MENU_ITEM(gtk_menu_get_active(
+                                  GTK_MENU(summaryview->search_type))))));
+               gchar *search_string = gtk_entry_get_text(GTK_ENTRY(summaryview->search_string));
+               gchar *searched_header = NULL;
+               
+               not_killed = NULL;
+               for (cur = mlist ; cur != NULL ; cur = g_slist_next(cur)) {
+                       MsgInfo * msginfo = (MsgInfo *) cur->data;
+
+                       switch (search_type) {
+                       case S_SEARCH_SUBJECT:
+                               searched_header = msginfo->subject;
+                               break;
+                       case S_SEARCH_FROM:
+                               searched_header = msginfo->from;
+                               break;
+                       case S_SEARCH_TO:
+                               searched_header = msginfo->to;
+                               break;
+                       default:
+                               debug_print("unknown search type (%d)\n", search_type);
+                               break;
+                       }
+                       if (searched_header && strcasestr(searched_header, search_string) != NULL)
+                               not_killed = g_slist_append(not_killed, msginfo);
+                       else
+                               procmsg_msginfo_free(msginfo);
+               }
+               g_slist_free(mlist);
+               mlist = not_killed;
+       }
+       
        if ((global_scoring || item->prefs->scoring)) {
                GSList *not_killed;
                gint kill_score;
@@ -834,11 +954,8 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
 
        g_slist_free(mlist);
 
-       folderview_update_msg_num(summaryview->folderview,
-                                 summaryview->folderview->opened);
-
-       if (item->sort_key != SORT_BY_NONE)
-               summary_sort(summaryview, item->sort_key, item->sort_type);
+       if (summaryview->sort_key != SORT_BY_NONE)
+               summary_sort(summaryview, summaryview->sort_key, summaryview->sort_type);
 
        gtk_signal_handler_unblock_by_data(GTK_OBJECT(ctree), summaryview);
 
@@ -865,7 +982,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item)
                }
        } else {
                /* select first unread message */
-               if (item->sort_key == SORT_BY_SCORE)
+               if (summaryview->sort_key == SORT_BY_SCORE)
                        node = summary_find_next_important_score(summaryview,
                                                                 NULL);
                else
@@ -1738,7 +1855,6 @@ static void summary_set_column_titles(SummaryView *summaryview)
        SummaryColumnType type;
        gboolean single_char;
        GtkJustification justify;
-       FolderItem *item = summaryview->folder_item;
 
        static FolderSortKey sort_by[N_SUMMARY_COLS] = {
                SORT_BY_MARK,
@@ -1809,9 +1925,9 @@ static void summary_set_column_titles(SummaryView *summaryview)
                        gtk_box_pack_start(GTK_BOX(hbox), label,
                                           FALSE, FALSE, 0);
 
-               if (item && item->sort_key == sort_by[type]) {
+               if (summaryview->sort_key == sort_by[type]) {
                        arrow = gtk_arrow_new
-                               (item->sort_type == SORT_ASCENDING
+                               (summaryview->sort_type == SORT_ASCENDING
                                 ? GTK_ARROW_DOWN : GTK_ARROW_UP,
                                 GTK_SHADOW_IN);
                        if (justify == GTK_JUSTIFY_RIGHT)
@@ -1833,9 +1949,6 @@ void summary_sort(SummaryView *summaryview,
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCList *clist = GTK_CLIST(summaryview->ctree);
        GtkCListCompareFunc cmp_func = NULL;
-       FolderItem *item = summaryview->folder_item;
-
-       if (!item || !item->path || !item->parent || item->no_select) return;
 
        switch (sort_key) {
        case SORT_BY_MARK:
@@ -1881,8 +1994,8 @@ void summary_sort(SummaryView *summaryview,
                return;
        }
 
-       item->sort_key = sort_key;
-       item->sort_type = sort_type;
+       summaryview->sort_key = sort_key;
+       summaryview->sort_type = sort_type;
 
        summary_set_column_titles(summaryview);
        summary_set_menu_sensitive(summaryview);
@@ -1982,7 +2095,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
                                summaryview->folder_item->prefs->important_score;
        }
 
-       if (summaryview->folder_item->threaded) {
+       if (summaryview->threaded) {
                GNode *root, *gnode;
 
                root = procmsg_get_thread_tree(mlist);
@@ -2074,6 +2187,7 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
 {
        static gchar date_modified[80];
        static gchar *to = NULL;
+       static gchar *from = NULL;
        static gchar col_score[11];
        static gchar buf[BUFFSIZE];
        gint *col_pos = summaryview->col_pos;
@@ -2127,16 +2241,10 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
         * the --> in sent boxes) was executed.
         */
        if (text[col_pos[S_COL_FROM]] != to && prefs_common.use_addr_book && msginfo->from) {
-               gchar *from;
+               g_free(from);
                from = summary_complete_address(msginfo->from);
-               if (from) {
-                       /*
-                        * FIXME: this text[col_pos[S_COL_FROM]] should be freed
-                        * but may have been assigned _("No From"). Should be
-                        * freed??? 
-                        */
+               if (from)
                        text[col_pos[S_COL_FROM]] = from;
-               }       
        }
 
        if (summaryview->simplify_subject_preg != NULL)
@@ -2204,7 +2312,7 @@ static void summary_display_msg_full(SummaryView *summaryview,
        if (new_window) {
                MessageView *msgview;
 
-               msgview = messageview_create_with_new_window();
+               msgview = messageview_create_with_new_window(summaryview->mainwin);
                messageview_show(msgview, msginfo, all_headers);
        } else {
                MessageView *msgview;
@@ -3170,7 +3278,7 @@ gboolean summary_execute(SummaryView *summaryview)
 
        gtk_clist_freeze(clist);
 
-       if (summaryview->folder_item->threaded)
+       if (summaryview->threaded)
                summary_unthread_for_exec(summaryview);
 
        summary_execute_move(summaryview);
@@ -3193,7 +3301,7 @@ gboolean summary_execute(SummaryView *summaryview)
                node = next;
        }
 
-       if (summaryview->folder_item->threaded)
+       if (summaryview->threaded)
                summary_thread_build(summaryview);
 
        summaryview->selected = clist->selection ?
@@ -3446,6 +3554,8 @@ void summary_thread_build(SummaryView *summaryview)
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
+       summaryview->threaded = TRUE;
+
        summary_unlock(summaryview);
 }
 
@@ -3513,6 +3623,8 @@ void summary_unthread(SummaryView *summaryview)
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
+       summaryview->threaded = FALSE;
+
        summary_unlock(summaryview);
 }
 
@@ -4363,6 +4475,31 @@ static void summary_key_pressed(GtkWidget *widget, GdkEventKey *event,
        }
 }
 
+static void summary_searchbar_pressed(GtkWidget *widget, GdkEventKey *event,
+                               SummaryView *summaryview)
+{
+       if (event != NULL && event->keyval == GDK_Return)
+               summary_show(summaryview, summaryview->folder_item);
+}
+
+static void summary_searchtype_changed(GtkMenuItem *widget, gpointer data)
+{
+       SummaryView *sw = (SummaryView *)data;
+       if (gtk_entry_get_text(GTK_ENTRY(sw->search_string)))
+               summary_show(sw, sw->folder_item);
+}
+
+static void tog_searchbar_cb(GtkWidget *w, gpointer data)
+{
+       if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(w))) {
+               prefs_common.show_searchbar = TRUE;
+               gtk_widget_show(GTK_WIDGET(data));
+       } else {
+               prefs_common.show_searchbar = FALSE;
+               gtk_widget_hide(GTK_WIDGET(data));
+       }
+}
+
 static void summary_open_row(GtkSCTree *sctree, SummaryView *summaryview)
 {
        if (summaryview->folder_item->stype == F_OUTBOX ||
@@ -4489,13 +4626,9 @@ static void summary_create_filter_cb(SummaryView *summaryview,
 static void summary_sort_by_column_click(SummaryView *summaryview,
                                         FolderSortKey sort_key)
 {
-       FolderItem *item = summaryview->folder_item;
-
-       if (!item) return;
-
-       if (item->sort_key == sort_key)
+       if (summaryview->sort_key == sort_key)
                summary_sort(summaryview, sort_key,
-                            item->sort_type == SORT_ASCENDING
+                            summaryview->sort_type == SORT_ASCENDING
                             ? SORT_DESCENDING : SORT_ASCENDING);
        else
                summary_sort(summaryview, sort_key, SORT_ASCENDING);
@@ -4994,7 +5127,7 @@ void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
 
        pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_DIR_OPEN);
        gtk_box_pack_start(GTK_BOX(summaryview->hbox), pixmap, FALSE, FALSE, 4);
-       gtk_box_reorder_child(GTK_BOX(summaryview->hbox), pixmap, 0);
+       gtk_box_reorder_child(GTK_BOX(summaryview->hbox), pixmap, 1); /* search_toggle before */
        gtk_widget_show(pixmap);
        summaryview->folder_pixmap = pixmap; 
 
@@ -5055,6 +5188,23 @@ void summary_set_prefs_from_folderitem(SummaryView *summaryview, FolderItem *ite
        if(item->prefs && item->prefs->simplify_subject_regexp && 
           item->prefs->simplify_subject_regexp[0] && item->prefs->enable_simplify_subject)
                summaryview->simplify_subject_preg = summary_compile_simplify_regexp(item->prefs->simplify_subject_regexp);
+
+       /* Sorting */
+       summaryview->sort_key = item->sort_key;
+       summaryview->sort_type = item->sort_type;
+
+       /* Threading */
+       summaryview->threaded = item->threaded;
+}
+
+void summary_save_prefs_to_folderitem(SummaryView *summaryview, FolderItem *item)
+{
+       /* Sorting */
+       item->sort_key = summaryview->sort_key;
+       item->sort_type = summaryview->sort_type;
+
+       /* Threading */
+       item->threaded = summaryview->threaded;
 }
 
 /*