remove unnecessary allocations for search bar fixing leaks reported by Martin Kluge...
[claws.git] / src / summaryview.c
index 15ee1f17d616b62648bd144b2a97f95e58a1a13a..9048d28be3d15301ad4c2ea21a28a9429725f671 100644 (file)
@@ -62,6 +62,7 @@
 #include "prefs_common.h"
 #include "prefs_summary_column.h"
 #include "prefs_filter.h"
+#include "prefs_filtering.h"
 #include "account.h"
 #include "compose.h"
 #include "utils.h"
 #include "prefs_folder_item.h"
 #include "filtering.h"
 #include "string_match.h"
-
-#define STATUSBAR_PUSH(mainwin, str) \
-{ \
-       gtk_statusbar_push(GTK_STATUSBAR(mainwin->statusbar), \
-                          mainwin->summaryview_cid, str); \
-       gtkut_widget_wait_for_draw(mainwin->hbox_stat); \
-}
-
-#define STATUSBAR_POP(mainwin) \
-{ \
-       gtk_statusbar_pop(GTK_STATUSBAR(mainwin->statusbar), \
-                         mainwin->summaryview_cid); \
-}
+#include "toolbar.h"
 
 #define SUMMARY_COL_MARK_WIDTH         10
 #define SUMMARY_COL_UNREAD_WIDTH       13
@@ -142,9 +131,6 @@ static void summary_free_msginfo_func       (GtkCTree               *ctree,
 static void summary_set_marks_func     (GtkCTree               *ctree,
                                         GtkCTreeNode           *node,
                                         gpointer                data);
-static void summary_write_cache_func   (GtkCTree               *ctree,
-                                        GtkCTreeNode           *node,
-                                        gpointer                data);
 
 static void summary_set_menu_sensitive (SummaryView            *summaryview);
 
@@ -160,24 +146,18 @@ static GtkCTreeNode *summary_find_prev_msg
 static GtkCTreeNode *summary_find_next_msg
                                        (SummaryView            *summaryview,
                                         GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_unread_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_unread_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_marked_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_marked_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_labeled_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_labeled_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
+
+static GtkCTreeNode *summary_find_prev_flagged_msg
+                                       (SummaryView    *summaryview,
+                                        GtkCTreeNode   *current_node,
+                                        MsgPermFlags    flags,
+                                        gboolean        start_from_prev);
+static GtkCTreeNode *summary_find_next_flagged_msg
+                                       (SummaryView    *summaryview,
+                                        GtkCTreeNode   *current_node,
+                                        MsgPermFlags    flags,
+                                        gboolean        start_from_next);
+
 static GtkCTreeNode *summary_find_msg_by_msgnum
                                        (SummaryView            *summaryview,
                                         guint                   msgnum);
@@ -200,7 +180,6 @@ static void summary_display_msg_full        (SummaryView            *summaryview,
                                         gboolean                all_headers);
 static void summary_set_row_marks      (SummaryView            *summaryview,
                                         GtkCTreeNode           *row);
-static void summaryview_subject_filter_init (PrefsFolderItem    *prefs);
 
 /* message handling */
 static void summary_mark_row           (SummaryView            *summaryview,
@@ -252,7 +231,9 @@ static void summary_unthread_for_exec_func  (GtkCTree       *ctree,
 void summary_simplify_subject(SummaryView *summaryview, gchar * rexp,
                              GSList * mlist);
 
+#if 0
 void summary_processing(SummaryView *summaryview, GSList * mlist);
+#endif
 static void summary_filter_func                (GtkCTree               *ctree,
                                         GtkCTreeNode           *node,
                                         gpointer                data);
@@ -267,11 +248,10 @@ static void summary_colorlabel_menu_create(SummaryView    *summaryview);
 
 static GtkWidget *summary_ctree_create (SummaryView    *summaryview);
 
-static void summary_toggle_view(SummaryView *summarview);
-
 /* callback functions */
-static void summary_toggle_view_cb     (GtkWidget      *widget,
-                                        gpointer       data);                                   
+static void summary_toggle_pressed     (GtkWidget              *eventbox,
+                                        GdkEventButton         *event,
+                                        SummaryView            *summaryview);
 static void summary_button_pressed     (GtkWidget              *ctree,
                                         GdkEventButton         *event,
                                         SummaryView            *summaryview);
@@ -281,6 +261,11 @@ static void summary_button_released        (GtkWidget              *ctree,
 static void summary_key_pressed                (GtkWidget              *ctree,
                                         GdkEventKey            *event,
                                         SummaryView            *summaryview);
+static void summary_searchbar_pressed  (GtkWidget              *ctree,
+                                        GdkEventKey            *event,
+                                        SummaryView            *summaryview);
+static void summary_searchtype_changed (GtkMenuItem            *widget, 
+                                        gpointer                data);
 static void summary_open_row           (GtkSCTree              *sctree,
                                         SummaryView            *summaryview);
 static void summary_tree_expanded      (GtkCTree               *ctree,
@@ -374,6 +359,8 @@ static gint summary_cmp_by_from             (GtkCList               *clist,
 static gint summary_cmp_by_subject     (GtkCList               *clist,
                                         gconstpointer           ptr1,
                                         gconstpointer           ptr2);
+static gint summary_cmp_by_simplified_subject
+       (GtkCList *clist, gconstpointer ptr1, gconstpointer ptr2);
 static gint summary_cmp_by_score       (GtkCList               *clist,
                                         gconstpointer           ptr1,
                                         gconstpointer           ptr2);
@@ -383,9 +370,12 @@ static gint summary_cmp_by_label   (GtkCList               *clist,
                                         gconstpointer           ptr1,
                                         gconstpointer           ptr2);
 
-static void news_process_crossposted   (MsgInfo *msginfo);
 static void news_flag_crosspost                (MsgInfo *msginfo);
 
+static void tog_searchbar_cb           (GtkWidget      *w,
+                                        gpointer        data);
+
+
 GtkTargetEntry summary_drag_types[1] =
 {
        {"text/plain", GTK_TARGET_SAME_APP, TARGET_DUMMY}
@@ -398,7 +388,7 @@ static GtkItemFactoryEntry summary_popup_entries[] =
        {N_("/Follow-up and reply to"), NULL, summary_reply_cb, COMPOSE_FOLLOWUP_AND_REPLY_TO, NULL},
        {N_("/Reply to a_ll"),          NULL, summary_reply_cb, COMPOSE_REPLY_TO_ALL, NULL},
        {N_("/_Forward"),               NULL, summary_reply_cb, COMPOSE_FORWARD, NULL},
-       {N_("/Bounce"),                 NULL, summary_reply_cb, COMPOSE_BOUNCE, NULL},
+       {N_("/Redirect"),               NULL, summary_reply_cb, COMPOSE_REDIRECT, NULL},
        {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
        {N_("/Re-_edit"),               NULL, summary_reedit,   0, NULL},
        {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
@@ -465,20 +455,63 @@ SummaryView *summary_create(void)
        GtkWidget *ctree;
        GtkWidget *hbox;
        GtkWidget *hbox_l;
+       GtkWidget *hbox_search;
        GtkWidget *statlabel_folder;
        GtkWidget *statlabel_select;
        GtkWidget *statlabel_msgs;
        GtkWidget *hbox_spc;
-       GtkWidget *toggle_view_btn;
-       GtkWidget *toggle_view_arrow;
+       GtkWidget *toggle_eventbox;
+       GtkWidget *toggle_arrow;
        GtkWidget *popupmenu;
+       GtkWidget *search_type_opt;
+       GtkWidget *search_type;
+       GtkWidget *search_string;
+       GtkWidget *menuitem;
+       GtkWidget *toggle_search;
+       GtkTooltips *search_tip;
        GtkItemFactory *popupfactory;
        gint n_entries;
 
-       debug_print(_("Creating summary view...\n"));
+       debug_print("Creating summary view...\n");
        summaryview = g_new0(SummaryView, 1);
 
-       vbox = gtk_vbox_new(FALSE, 2);
+       vbox = gtk_vbox_new(FALSE, 3);
+       
+       /* create status label */
+       hbox = gtk_hbox_new(FALSE, 0);
+       
+       search_tip = gtk_tooltips_new();
+       toggle_search = gtk_toggle_button_new();
+
+       gtk_tooltips_set_tip(GTK_TOOLTIPS(search_tip),
+                            toggle_search,
+                            _("Toggle quick-search bar"), NULL);
+       
+       gtk_box_pack_start(GTK_BOX(hbox), toggle_search, FALSE, FALSE, 2);      
+
+       hbox_l = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_start(GTK_BOX(hbox), hbox_l, TRUE, TRUE, 0);
+       statlabel_folder = gtk_label_new("");
+       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_folder, FALSE, FALSE, 2);
+       statlabel_select = gtk_label_new("");
+       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_select, FALSE, FALSE, 12);
+       /* toggle view button */
+       toggle_eventbox = gtk_event_box_new();
+       gtk_box_pack_end(GTK_BOX(hbox), toggle_eventbox, FALSE, FALSE, 4);
+       toggle_arrow = gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
+       gtk_container_add(GTK_CONTAINER(toggle_eventbox), toggle_arrow);
+       gtk_signal_connect(GTK_OBJECT(toggle_eventbox), "button_press_event",
+                          GTK_SIGNAL_FUNC(summary_toggle_pressed),
+                          summaryview);
+       
+       
+       statlabel_msgs = gtk_label_new("");
+       gtk_box_pack_end(GTK_BOX(hbox), statlabel_msgs, FALSE, FALSE, 4);
+
+       hbox_spc = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_end(GTK_BOX(hbox), hbox_spc, FALSE, FALSE, 6);
 
        scrolledwin = gtk_scrolled_window_new(NULL, NULL);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolledwin),
@@ -497,32 +530,47 @@ SummaryView *summary_create(void)
                                            GTK_CLIST(ctree)->vadjustment);
        gtk_container_add(GTK_CONTAINER(scrolledwin), ctree);
 
-       /* create status label */
-       hbox = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_end(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
+       /* status label */
+       gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
 
-       hbox_l = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_start(GTK_BOX(hbox), hbox_l, TRUE, TRUE, 0);
+       /* quick search */
+       hbox_search = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_start(GTK_BOX(vbox), hbox_search, FALSE, FALSE, 0);
 
-       statlabel_folder = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_folder, FALSE, FALSE, 2);
-       statlabel_select = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_select, FALSE, FALSE, 12);
+       search_type_opt = gtk_option_menu_new();
+       gtk_widget_show(search_type_opt);
+       gtk_box_pack_start(GTK_BOX(hbox_search), search_type_opt, FALSE, FALSE, 0);
 
-       /* toggle view buttons */
-       toggle_view_btn = gtk_button_new();
-       gtk_box_pack_end(GTK_BOX(hbox), toggle_view_btn, FALSE, FALSE, 0);
-       gtk_button_set_relief(GTK_BUTTON(toggle_view_btn), GTK_RELIEF_NONE);
-       toggle_view_arrow=gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
-       gtk_container_add(GTK_CONTAINER(toggle_view_btn), toggle_view_arrow);
-       gtk_signal_connect(GTK_OBJECT(toggle_view_btn), "clicked",
-                               GTK_SIGNAL_FUNC(summary_toggle_view_cb), summaryview);
+       search_type = gtk_menu_new();
+       MENUITEM_ADD (search_type, menuitem, _("Subject"), S_SEARCH_SUBJECT);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
+                          summaryview);
+       MENUITEM_ADD (search_type, menuitem, _("From"), S_SEARCH_FROM);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
+                          summaryview);
+       MENUITEM_ADD (search_type, menuitem, _("To"), S_SEARCH_TO);
+       gtk_signal_connect(GTK_OBJECT(menuitem), "activate",
+                          GTK_SIGNAL_FUNC(summary_searchtype_changed),
+                          summaryview);
 
-       statlabel_msgs = gtk_label_new("");
-       gtk_box_pack_end(GTK_BOX(hbox), statlabel_msgs, FALSE, FALSE, 4);
+       gtk_option_menu_set_menu(GTK_OPTION_MENU(search_type_opt), search_type);
+       gtk_widget_show(search_type);
+       
+       search_string = gtk_entry_new();
+       
+       gtk_box_pack_start(GTK_BOX(hbox_search), search_string, FALSE, FALSE, 2);
+       
+       gtk_widget_show(search_string);
+       gtk_widget_show(hbox_search);
 
-       hbox_spc = gtk_hbox_new(FALSE, 0);
-       gtk_box_pack_end(GTK_BOX(hbox), hbox_spc, FALSE, FALSE, 6);
+       gtk_signal_connect(GTK_OBJECT(search_string), "key_press_event",
+                          GTK_SIGNAL_FUNC(summary_searchbar_pressed),
+                          summaryview);
+
+       gtk_signal_connect (GTK_OBJECT(toggle_search), "toggled",
+                        GTK_SIGNAL_FUNC(tog_searchbar_cb), hbox_search);
 
        /* create popup menu */
        n_entries = sizeof(summary_popup_entries) /
@@ -536,17 +584,23 @@ SummaryView *summary_create(void)
        summaryview->ctree = ctree;
        summaryview->hbox = hbox;
        summaryview->hbox_l = hbox_l;
+       summaryview->hbox_search = hbox_search;
        summaryview->statlabel_folder = statlabel_folder;
        summaryview->statlabel_select = statlabel_select;
        summaryview->statlabel_msgs = statlabel_msgs;
-       summaryview->toggle_view_btn = toggle_view_btn;
-       summaryview->toggle_view_arrow = toggle_view_arrow;
+       summaryview->toggle_eventbox = toggle_eventbox;
+       summaryview->toggle_arrow = toggle_arrow;
+       summaryview->toggle_search = toggle_search;
        summaryview->popupmenu = popupmenu;
        summaryview->popupfactory = popupfactory;
-       summaryview->msg_is_toggled_on = TRUE;
        summaryview->lock_count = 0;
-       summaryview->sort_mode = SORT_BY_NONE;
-       summaryview->sort_type = GTK_SORT_ASCENDING;
+       summaryview->search_type_opt = search_type_opt;
+       summaryview->search_type = search_type;
+       summaryview->search_string = search_string;
+
+       /* CLAWS: need this to get the SummaryView * from
+        * the CList */
+       gtk_object_set_data(GTK_OBJECT(ctree), "summaryview", (gpointer)summaryview); 
 
        gtk_widget_show_all(vbox);
 
@@ -621,6 +675,17 @@ void summary_init(SummaryView *summaryview)
        gtk_widget_show(pixmap);
        summaryview->folder_pixmap = pixmap;
 
+       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_QUICKSEARCH);
+       gtk_container_add (GTK_CONTAINER(summaryview->toggle_search), pixmap);
+       gtk_widget_show(pixmap);
+       
+       /* Init summaryview prefs */
+       summaryview->sort_key = SORT_BY_NONE;
+       summaryview->sort_type = SORT_ASCENDING;
+
+       /* Init summaryview extra data */
+       summaryview->simplify_subject_preg = NULL;
+
        summary_clear_list(summaryview);
        summary_set_column_titles(summaryview);
        summary_colorlabel_menu_create(summaryview);
@@ -690,8 +755,7 @@ GtkCTreeNode * summary_find_prev_important_score(SummaryView *summaryview,
                return best_node;
 }
 
-gboolean summary_show(SummaryView *summaryview, FolderItem *item,
-                     gboolean update_cache)
+gboolean summary_show(SummaryView *summaryview, FolderItem *item)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCTreeNode *node;
@@ -700,22 +764,22 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
        gboolean is_refresh;
        guint selected_msgnum = 0;
        guint displayed_msgnum = 0;
-       GtkCTreeNode *selected_node = summaryview->folderview->selected;
        GSList *cur;
-       gint sort_mode;
-       gint sort_type;
-        static gboolean locked = FALSE;
 
        if (summary_is_locked(summaryview)) return FALSE;
 
        inc_lock();
        summary_lock(summaryview);
 
+       if (item != summaryview->folder_item) {
+               /* changing folder, reset search */
+               gtk_entry_set_text(GTK_ENTRY(summaryview->search_string), "");
+       }
+       
        STATUSBAR_POP(summaryview->mainwin);
 
        is_refresh = (!prefs_common.open_inbox_on_inc &&
-                     item == summaryview->folder_item &&
-                     update_cache == FALSE) ? TRUE : FALSE;
+                     item == summaryview->folder_item) ? TRUE : FALSE;
        if (is_refresh) {
                selected_msgnum = summary_get_msgnum(summaryview,
                                                     summaryview->selected);
@@ -735,32 +799,16 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                        summary_unlock(summaryview);
                        summary_execute(summaryview);
                        summary_lock(summaryview);
-               } else if (G_ALERTALTERNATE == val)
-                       summary_write_cache(summaryview);
-               else {
+               } else if (G_ALERTALTERNATE == val) {
+                       /* DO NOTHING */
+               else {
                        summary_unlock(summaryview);
                        inc_unlock();
                        return FALSE;
                }
                folder_update_op_count();
-       } else {
-               /* 
-                * CLAWS: summary_show() is responsible for updating the caches. 
-                * after filtering inc.c::inc_finished() forces the update of
-                * the cache by indirectly calling summary_show() (by re-selecting
-                * the currently selected mail folder).  
-                * this collides with the new filtering system that may have set 
-                * any message flag before calling summary_show(). 
-                * we can prevent this cache-write by checking the opened member
-                * of the folderview. if this is NULL, the folderview forced
-                * an update of the summary view.
-                */
-               if (summaryview->folderview->opened) 
-                       summary_write_cache(summaryview);
-       }       
-        
-       summaryview->folderview->opened = selected_node;
-
+       }
+       
        gtk_clist_freeze(GTK_CLIST(ctree));
 
        summary_clear_list(summaryview);
@@ -774,7 +822,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
             ((buf = folder_item_get_path(item)) == NULL ||
              change_dir(buf) < 0))) {
                g_free(buf);
-               debug_print(_("empty folder\n\n"));
+               debug_print("empty folder\n\n");
                summary_set_hide_read_msgs_menu(summaryview, FALSE);
                if (is_refresh)
                        messageview_clear(summaryview->messageview);
@@ -799,10 +847,17 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
 
        main_window_cursor_wait(summaryview->mainwin);
 
+/*
        mlist = item->folder->get_msg_list(item->folder, item, !update_cache);
 
+       !!! NEW !!!
+       USE LIST FROM CACHE, WILL NOT DISPLAY ANY MESSAGES DROPED
+       BY OTHER PROGRAMS TO THE FOLDER
+*/
+       mlist = folder_item_get_msg_list(item);
+#if 0
        summary_processing(summaryview, mlist);
-
+#endif
        for(cur = mlist ; cur != NULL ; cur = g_slist_next(cur)) {
                MsgInfo * msginfo = (MsgInfo *) cur->data;
 
@@ -814,11 +869,8 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                }
        }
 
-       summaryview->killed_messages = NULL;
-
        if (summaryview->folder_item->hide_read_msgs) {
                GSList *not_killed;
-               gint kill_score;
                
                summary_set_hide_read_msgs_menu(summaryview, TRUE);
                not_killed = NULL;
@@ -831,8 +883,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                             && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                            not_killed = g_slist_append(not_killed, msginfo);
                        else
-                               summaryview->killed_messages = 
-                                       g_slist_append(summaryview->killed_messages, msginfo);
+                               procmsg_msginfo_free(msginfo);
                }
                g_slist_free(mlist);
                mlist = not_killed;
@@ -840,8 +891,42 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                summary_set_hide_read_msgs_menu(summaryview, FALSE);
        }
 
-       if ((global_scoring || item->prefs->scoring) &&
-           (item->folder->type == F_NEWS)) {
+       if (strlen(gtk_entry_get_text(GTK_ENTRY(summaryview->search_string))) > 0) {
+               GSList *not_killed;
+               gint search_type = GPOINTER_TO_INT(gtk_object_get_user_data(
+                                  GTK_OBJECT(GTK_MENU_ITEM(gtk_menu_get_active(
+                                  GTK_MENU(summaryview->search_type))))));
+               gchar *search_string = gtk_entry_get_text(GTK_ENTRY(summaryview->search_string));
+               gchar *searched_header = NULL;
+               
+               not_killed = NULL;
+               for (cur = mlist ; cur != NULL ; cur = g_slist_next(cur)) {
+                       MsgInfo * msginfo = (MsgInfo *) cur->data;
+
+                       switch (search_type) {
+                       case S_SEARCH_SUBJECT:
+                               searched_header = msginfo->subject;
+                               break;
+                       case S_SEARCH_FROM:
+                               searched_header = msginfo->from;
+                               break;
+                       case S_SEARCH_TO:
+                               searched_header = msginfo->to;
+                               break;
+                       default:
+                               debug_print("unknown search type (%d)\n", search_type);
+                               break;
+                       }
+                       if (searched_header && strcasestr(searched_header, search_string) != NULL)
+                               not_killed = g_slist_append(not_killed, msginfo);
+                       else
+                               procmsg_msginfo_free(msginfo);
+               }
+               g_slist_free(mlist);
+               mlist = not_killed;
+       }
+       
+       if ((global_scoring || item->prefs->scoring)) {
                GSList *not_killed;
                gint kill_score;
 
@@ -852,12 +937,10 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                for(cur = mlist ; cur != NULL ; cur = g_slist_next(cur)) {
                        MsgInfo * msginfo = (MsgInfo *) cur->data;
 
-                       if (MSG_IS_NEWS(msginfo->flags) &&
-                           (msginfo->score <= kill_score))
-                               summaryview->killed_messages = g_slist_append(summaryview->killed_messages, msginfo);
+                       if (msginfo->score > kill_score)
+                               not_killed = g_slist_append(not_killed, msginfo);
                        else
-                               not_killed = g_slist_append(not_killed,
-                                                           msginfo);
+                               procmsg_msginfo_free(msginfo);
                }
                g_slist_free(mlist);
                mlist = not_killed;
@@ -871,26 +954,13 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
 
        g_slist_free(mlist);
 
-       summary_write_cache(summaryview);
+       if (summaryview->sort_key != SORT_BY_NONE)
+               summary_sort(summaryview, summaryview->sort_key, summaryview->sort_type);
 
        gtk_signal_handler_unblock_by_data(GTK_OBJECT(ctree), summaryview);
 
        gtk_clist_thaw(GTK_CLIST(ctree));
 
-       /* sort before */
-       sort_mode = prefs_folder_item_get_sort_mode(item);
-       sort_type = prefs_folder_item_get_sort_type(item);
-
-       if (sort_mode != SORT_BY_NONE) {
-               summaryview->sort_mode = sort_mode;
-               if (sort_type == GTK_SORT_DESCENDING)
-                       summaryview->sort_type = GTK_SORT_ASCENDING;
-               else
-                       summaryview->sort_type = GTK_SORT_DESCENDING;
-
-               summary_sort(summaryview, sort_mode);
-       }
-
        if (is_refresh) {
                summaryview->displayed =
                        summary_find_msg_by_msgnum(summaryview,
@@ -901,29 +971,29 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                if (!summaryview->selected) {
                        /* no selected message - select first unread
                           message, but do not display it */
-                       node = summary_find_next_unread_msg(summaryview, NULL);
+                       node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                            MSG_UNREAD, FALSE);
                        if (node == NULL && GTK_CLIST(ctree)->row_list != NULL)
                                node = gtk_ctree_node_nth
-                                       (ctree, sort_type == 
-                                        GTK_SORT_DESCENDING ? 0 : 
-                                        GTK_CLIST(ctree)->rows - 1);
+                                       (ctree,
+                                        item->sort_type == SORT_DESCENDING
+                                        ? 0 : GTK_CLIST(ctree)->rows - 1);
                        summary_select_node(summaryview, node, FALSE, TRUE);
                }
        } else {
                /* select first unread message */
-               if (sort_mode == SORT_BY_SCORE)
+               if (summaryview->sort_key == SORT_BY_SCORE)
                        node = summary_find_next_important_score(summaryview,
                                                                 NULL);
                else
-                       node = summary_find_next_unread_msg(summaryview, NULL);
-
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_UNREAD, FALSE);
                if (node == NULL && GTK_CLIST(ctree)->row_list != NULL) {
-                       /* Get the last visible node on screen */
-                       /* FIXME: huh, what happens if node is null? that allowed?? */
-                       node = gtk_ctree_node_nth(ctree, sort_type == 
-                                                 GTK_SORT_DESCENDING ? 0 : 
-                                                 GTK_CLIST(ctree)->rows - 1);
-               }       
+                       node = gtk_ctree_node_nth
+                               (ctree,
+                                item->sort_type == SORT_DESCENDING
+                                ? 0 : GTK_CLIST(ctree)->rows - 1);
+               }
                if (prefs_common.open_unread_on_enter) {
                        summary_unlock(summaryview);
                        summary_select_node(summaryview, node, TRUE, TRUE);
@@ -934,7 +1004,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
 
        summary_status_show(summaryview);
        summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
+       toolbar_set_sensitive(summaryview->mainwin);
 
        debug_print("\n");
        STATUSBAR_PUSH(summaryview->mainwin, _("Done."));
@@ -950,19 +1020,9 @@ void summary_clear_list(SummaryView *summaryview)
 {
        GtkCList *clist = GTK_CLIST(summaryview->ctree);
        gint optimal_width;
-       GSList * cur;
 
        gtk_clist_freeze(clist);
 
-       for(cur = summaryview->killed_messages ; cur != NULL ; 
-           cur = g_slist_next(cur)) {
-               MsgInfo * msginfo = (MsgInfo *) cur->data;
-
-               procmsg_msginfo_free(msginfo);
-       }
-       g_slist_free(summaryview->killed_messages);
-       summaryview->killed_messages = NULL;
-
        gtk_ctree_pre_recursive(GTK_CTREE(summaryview->ctree),
                                NULL, summary_free_msginfo_func, NULL);
 
@@ -992,8 +1052,6 @@ void summary_clear_list(SummaryView *summaryview)
                g_hash_table_destroy(summaryview->folder_table);
                summaryview->folder_table = NULL;
        }
-       summaryview->sort_mode = SORT_BY_NONE;
-       summaryview->sort_type = GTK_SORT_ASCENDING;
 
        gtk_clist_clear(clist);
        if (summaryview->col_pos[S_COL_SUBJECT] == N_SUMMARY_COLS - 1) {
@@ -1011,7 +1069,7 @@ void summary_clear_all(SummaryView *summaryview)
 {
        summary_clear_list(summaryview);
        summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
+       toolbar_set_sensitive(summaryview->mainwin);
        summary_status_show(summaryview);
 }
 
@@ -1075,7 +1133,6 @@ static void summary_set_menu_sensitive(SummaryView *summaryview)
                menu_set_sensitive(ifactory, "/Move...", FALSE);
 
        menu_set_sensitive(ifactory, "/Delete", TRUE);
-       menu_set_sensitive(ifactory, "/Select thread", TRUE);
        menu_set_sensitive(ifactory, "/Select all", TRUE);
        menu_set_sensitive(ifactory, "/Copy...", TRUE);
        menu_set_sensitive(ifactory, "/Execute", TRUE);
@@ -1097,7 +1154,7 @@ static void summary_set_menu_sensitive(SummaryView *summaryview)
        menu_set_sensitive(ifactory, "/Reply to sender",          sens);
        menu_set_sensitive(ifactory, "/Reply to all",             sens);
        menu_set_sensitive(ifactory, "/Forward",                  TRUE);
-       menu_set_sensitive(ifactory, "/Bounce",                   TRUE);
+       menu_set_sensitive(ifactory, "/Redirect",                 sens);
 
        menu_set_sensitive(ifactory, "/Add sender to address book", sens);
        menu_set_sensitive(ifactory, "/Create filter rule",         sens);
@@ -1113,6 +1170,7 @@ static void summary_set_menu_sensitive(SummaryView *summaryview)
        else
                menu_set_sensitive(ifactory, "/Re-edit", FALSE);
 
+       menu_set_sensitive(ifactory, "/Select thread", sens);
        menu_set_sensitive(ifactory, "/Save as...", sens);
        menu_set_sensitive(ifactory, "/Print...",   TRUE);
 
@@ -1134,10 +1192,11 @@ void summary_select_prev_unread(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_prev_unread_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_UNREAD, FALSE);
 
        if (!node) {
-               AlertValue val;
+               AlertValue val = 0;
 
                switch (prefs_common.next_unread_msg_dialog) {
                        case NEXTUNREADMSGDIALOG_ALWAYS:
@@ -1157,7 +1216,8 @@ void summary_select_prev_unread(SummaryView *summaryview)
                                        _("Internal error: unexpected value for prefs_common.next_unread_msg_dialog\n"));
                }
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_unread_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_UNREAD, FALSE);
        }
 
        if (!node)
@@ -1171,27 +1231,90 @@ void summary_select_next_unread(SummaryView *summaryview)
        GtkCTreeNode *node = summaryview->selected;
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
-       while ((node = summary_find_next_unread_msg(summaryview, node)) == NULL) {
+       node = summary_find_next_flagged_msg
+               (summaryview, node, MSG_UNREAD, FALSE);
+       
+       if (node)
+               summary_select_node(summaryview, node, TRUE, FALSE);
+       else {
+               node = summary_find_next_flagged_msg
+                       (summaryview, NULL, MSG_UNREAD, FALSE);
+               if (node == NULL) {
+                       AlertValue val = 0;
+
+                       switch (prefs_common.next_unread_msg_dialog) {
+                               case NEXTUNREADMSGDIALOG_ALWAYS:
+                                       val = alertpanel(_("No more unread messages"),
+                                                        _("No unread message found. "
+                                                          "Go to next folder?"),
+                                                        _("Yes"), _("No"), NULL);
+                                       break;
+                               case NEXTUNREADMSGDIALOG_ASSUME_YES:
+                                       val = G_ALERTDEFAULT;
+                                       break;
+                               case NEXTUNREADMSGDIALOG_ASSUME_NO:
+                                       val = G_ALERTOTHER;
+                                       break;
+                               default:
+                                       debug_print(
+                                               _("Internal error: unexpected value for prefs_common.next_unread_msg_dialog\n"));
+                       }
+
+                       if (val == G_ALERTDEFAULT) {
+                               if (gtk_signal_n_emissions_by_name
+                                       (GTK_OBJECT(ctree), "key_press_event") > 0)
+                                               gtk_signal_emit_stop_by_name
+                                                       (GTK_OBJECT(ctree),
+                                                        "key_press_event");
+                               folderview_select_next_unread(summaryview->folderview);
+                               return;
+                       } 
+                       else
+                               return;
+               } else
+                       summary_select_node(summaryview, node, TRUE, FALSE);
+
+       }
+}
+
+void summary_select_prev_new(SummaryView *summaryview)
+{
+       GtkCTreeNode *node;
+
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_NEW, FALSE);
+
+       if (!node) {
                AlertValue val;
 
-               switch (prefs_common.next_unread_msg_dialog) {
-                       case NEXTUNREADMSGDIALOG_ALWAYS:
-                               val = alertpanel(_("No more unread messages"),
-                                                _("No unread message found. "
-                                                  "Go to next folder?"),
-                                                _("Yes"), _("Search again"), _("No"));
-                               break;
-                       case NEXTUNREADMSGDIALOG_ASSUME_YES:
-                               val = G_ALERTDEFAULT;
-                               break;
-                       case NEXTUNREADMSGDIALOG_ASSUME_NO:
-                               val = G_ALERTOTHER;
-                               break;
-                       default:
-                               debug_print(
-                                       _("Internal error: unexpected value for prefs_common.next_unread_msg_dialog\n"));
-               }
+               val = alertpanel(_("No more new messages"),
+                                _("No new message found. "
+                                  "Search from the end?"),
+                                _("Yes"), _("No"), NULL);
+               if (val != G_ALERTDEFAULT) return;
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_NEW, FALSE);
+       }
+
+       if (!node)
+               alertpanel_notice(_("No new messages."));
+       else
+               summary_select_node(summaryview, node, TRUE, FALSE);
+}
 
+void summary_select_next_new(SummaryView *summaryview)
+{
+       GtkCTreeNode *node = summaryview->selected;
+       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
+
+       while ((node = summary_find_next_flagged_msg
+               (summaryview, node, MSG_NEW, FALSE)) == NULL) {
+               AlertValue val;
+
+               val = alertpanel(_("No more new messages"),
+                                _("No new message found. "
+                                  "Go to next folder?"),
+                                _("Yes"), _("Search again"), _("No"));
                if (val == G_ALERTDEFAULT) {
                        if (gtk_signal_n_emissions_by_name
                                (GTK_OBJECT(ctree), "key_press_event") > 0)
@@ -1214,7 +1337,8 @@ void summary_select_prev_marked(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_prev_marked_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_MARKED, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1224,7 +1348,8 @@ void summary_select_prev_marked(SummaryView *summaryview)
                                   "Search from the end?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_marked_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_MARKED, TRUE);
        }
 
        if (!node)
@@ -1237,7 +1362,8 @@ void summary_select_next_marked(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_next_marked_msg(summaryview, summaryview->selected);
+       node = summary_find_next_flagged_msg
+               (summaryview, summaryview->selected, MSG_MARKED, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1247,7 +1373,8 @@ void summary_select_next_marked(SummaryView *summaryview)
                                   "Search from the beginning?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_next_marked_msg(summaryview, NULL);
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_MARKED, TRUE);
        }
 
        if (!node)
@@ -1260,7 +1387,8 @@ void summary_select_prev_labeled(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_prev_labeled_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_CLABEL_FLAG_MASK, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1270,7 +1398,8 @@ void summary_select_prev_labeled(SummaryView *summaryview)
                                   "Search from the end?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_labeled_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_CLABEL_FLAG_MASK, TRUE);
        }
 
        if (!node)
@@ -1283,7 +1412,8 @@ void summary_select_next_labeled(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_next_labeled_msg(summaryview, summaryview->selected);
+       node = summary_find_next_flagged_msg
+               (summaryview, summaryview->selected, MSG_CLABEL_FLAG_MASK, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1293,7 +1423,8 @@ void summary_select_next_labeled(SummaryView *summaryview)
                                   "Search from the beginning?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_next_labeled_msg(summaryview, NULL);
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_CLABEL_FLAG_MASK, TRUE);
        }
 
        if (!node)
@@ -1367,8 +1498,7 @@ static GtkCTreeNode *summary_find_prev_msg(SummaryView *summaryview,
 
        for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (!MSG_IS_DELETED(msginfo->flags))
-                       break;
+               if (!MSG_IS_DELETED(msginfo->flags)) break;
        }
 
        return node;
@@ -1388,128 +1518,61 @@ static GtkCTreeNode *summary_find_next_msg(SummaryView *summaryview,
 
        for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (!MSG_IS_DELETED(msginfo->flags))
-                       break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_prev_unread_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = current_node;
-       else
-               node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
-
-       for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_next_unread_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = current_node;
-       else
-               node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
-
-       for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) break;
+               if (!MSG_IS_DELETED(msginfo->flags)) break;
        }
 
        return node;
 }
 
-static GtkCTreeNode *summary_find_prev_marked_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
+static GtkCTreeNode *summary_find_prev_flagged_msg(SummaryView *summaryview,
+                                                  GtkCTreeNode *current_node,
+                                                  MsgPermFlags flags,
+                                                  gboolean start_from_prev)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCTreeNode *node;
        MsgInfo *msginfo;
 
-       if (current_node)
-               node = GTK_CTREE_NODE_PREV(current_node);
-       else
-               node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
-
-       for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_MARKED(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_next_marked_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = gtkut_ctree_node_next(ctree, current_node);
-       else
-               node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
-
-       for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_MARKED(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_prev_labeled_msg(SummaryView *summaryview,
-                                                  GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = GTK_CTREE_NODE_PREV(current_node);
-       else
+       if (current_node) {
+               if (start_from_prev)
+                       node = GTK_CTREE_NODE_PREV(current_node);
+               else
+                       node = current_node;
+       } else
                node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
 
        for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_GET_COLORLABEL_VALUE(msginfo->flags) > 0) break;
+               if ((msginfo->flags.perm_flags & flags) != 0) break;
        }
 
        return node;
 }
 
-static GtkCTreeNode *summary_find_next_labeled_msg(SummaryView *summaryview,
-                                                  GtkCTreeNode *current_node)
+static GtkCTreeNode *summary_find_next_flagged_msg(SummaryView *summaryview,
+                                                  GtkCTreeNode *current_node,
+                                                  MsgPermFlags flags,
+                                                  gboolean start_from_next)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCTreeNode *node;
        MsgInfo *msginfo;
 
-       if (current_node)
-               node = gtkut_ctree_node_next(ctree, current_node);
-       else
+       if (current_node) {
+               if (start_from_next)
+                       node = gtkut_ctree_node_next(ctree, current_node);
+               else
+                       node = current_node;
+       } else
                node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
 
        for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_GET_COLORLABEL_VALUE(msginfo->flags) > 0) break;
+               /* Find msg with matching flags but ignore messages with
+                  ignore flags, if searching for new or unread messages */
+               if (!(((flags & (MSG_NEW | MSG_UNREAD)) != 0) && MSG_IS_IGNORE_THREAD(msginfo->flags)) && 
+                       ((msginfo->flags.perm_flags & flags) != 0))
+                       break;
        }
 
        return node;
@@ -1567,7 +1630,7 @@ void summary_attract_by_subject(SummaryView *summaryview)
        MsgInfo *src_msginfo, *dst_msginfo;
        GHashTable *subject_table;
 
-       debug_print(_("Attracting messages by subject..."));
+       debug_print("Attracting messages by subject...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Attracting messages by subject..."));
 
@@ -1613,7 +1676,7 @@ void summary_attract_by_subject(SummaryView *summaryview)
 
        gtk_clist_thaw(clist);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
 
        main_window_cursor_normal(summaryview->mainwin);
@@ -1779,13 +1842,6 @@ static void summary_status_show(SummaryView *summaryview)
        }
        gtk_label_set(GTK_LABEL(summaryview->statlabel_msgs), str);
        g_free(str);
-
-       summaryview->folder_item->new    = summaryview->newmsgs;
-       summaryview->folder_item->unread = summaryview->unread;
-       summaryview->folder_item->total  = summaryview->messages;
-
-       folderview_update_msg_num(summaryview->folderview,
-                                 summaryview->folderview->opened);
 }
 
 static void summary_set_column_titles(SummaryView *summaryview)
@@ -1800,7 +1856,7 @@ static void summary_set_column_titles(SummaryView *summaryview)
        gboolean single_char;
        GtkJustification justify;
 
-       static SummarySortType sort_by[N_SUMMARY_COLS] = {
+       static FolderSortKey sort_by[N_SUMMARY_COLS] = {
                SORT_BY_MARK,
                SORT_BY_UNREAD,
                SORT_BY_MIME,
@@ -1869,9 +1925,9 @@ static void summary_set_column_titles(SummaryView *summaryview)
                        gtk_box_pack_start(GTK_BOX(hbox), label,
                                           FALSE, FALSE, 0);
 
-               if (summaryview->sort_mode == sort_by[type]) {
+               if (summaryview->sort_key == sort_by[type]) {
                        arrow = gtk_arrow_new
-                               (summaryview->sort_type == GTK_SORT_ASCENDING
+                               (summaryview->sort_type == SORT_ASCENDING
                                 ? GTK_ARROW_DOWN : GTK_ARROW_UP,
                                 GTK_SHADOW_IN);
                        if (justify == GTK_JUSTIFY_RIGHT)
@@ -1887,16 +1943,14 @@ static void summary_set_column_titles(SummaryView *summaryview)
        }
 }
 
-void summary_sort(SummaryView *summaryview, SummarySortType type)
+void summary_sort(SummaryView *summaryview,
+                 FolderSortKey sort_key, FolderSortType sort_type)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCList *clist = GTK_CLIST(summaryview->ctree);
-       GtkCListCompareFunc cmp_func;
+       GtkCListCompareFunc cmp_func = NULL;
 
-       if (!summaryview->folder_item)
-               return;
-
-       switch (type) {
+       switch (sort_key) {
        case SORT_BY_MARK:
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_mark;
                break;
@@ -1919,7 +1973,10 @@ void summary_sort(SummaryView *summaryview, SummarySortType type)
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_from;
                break;
        case SORT_BY_SUBJECT:
-               cmp_func = (GtkCListCompareFunc)summary_cmp_by_subject;
+               if (summaryview->simplify_subject_preg)
+                       cmp_func = (GtkCListCompareFunc)summary_cmp_by_simplified_subject;
+               else
+                       cmp_func = (GtkCListCompareFunc)summary_cmp_by_subject;
                break;
        case SORT_BY_SCORE:
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_score;
@@ -1930,41 +1987,37 @@ void summary_sort(SummaryView *summaryview, SummarySortType type)
        case SORT_BY_LABEL:
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_label;
                break;
+       case SORT_BY_NONE:
+               cmp_func = NULL;
+               return;
        default:
                return;
        }
 
-       debug_print(_("Sorting summary..."));
-       STATUSBAR_PUSH(summaryview->mainwin, _("Sorting summary..."));
+       summaryview->sort_key = sort_key;
+       summaryview->sort_type = sort_type;
 
-       main_window_cursor_wait(summaryview->mainwin);
+       summary_set_column_titles(summaryview);
+       summary_set_menu_sensitive(summaryview);
+       if(cmp_func != NULL) {
+               debug_print("Sorting summary...");
+               STATUSBAR_PUSH(summaryview->mainwin, _("Sorting summary..."));
 
-       gtk_clist_set_compare_func(clist, cmp_func);
+               main_window_cursor_wait(summaryview->mainwin);
 
-       /* toggle sort type if the same column is selected */
-       if (summaryview->sort_mode == type)
-               summaryview->sort_type =
-                       summaryview->sort_type == GTK_SORT_ASCENDING
-                       ? GTK_SORT_DESCENDING : GTK_SORT_ASCENDING;
-       else
-               summaryview->sort_type = GTK_SORT_ASCENDING;
-       gtk_clist_set_sort_type(clist, summaryview->sort_type);
-       summaryview->sort_mode = type;
+               gtk_clist_set_compare_func(clist, cmp_func);
 
-       summary_set_column_titles(summaryview);
+               gtk_clist_set_sort_type(clist, (GtkSortType)sort_type);
 
-       gtk_ctree_sort_recursive(ctree, NULL);
+               gtk_sctree_sort_recursive(ctree, NULL);
 
-       gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
-       prefs_folder_item_set_config(summaryview->folder_item,
-                                    summaryview->sort_type,
-                                    summaryview->sort_mode);
-       prefs_folder_item_save_config(summaryview->folder_item);
+               gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
 
-       debug_print(_("done.\n"));
-       STATUSBAR_POP(summaryview->mainwin);
+               main_window_cursor_normal(summaryview->mainwin);
 
-       main_window_cursor_normal(summaryview->mainwin);
+               debug_print("done.\n");
+               STATUSBAR_POP(summaryview->mainwin);
+       }
 }
 
 gboolean summary_insert_gnode_func(GtkCTree *ctree, guint depth, GNode *gnode,
@@ -2009,17 +2062,14 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        MsgInfo *msginfo;
-       MsgInfo *parentinfo;
-       MsgInfo *cur_msginfo;
-       GtkCTreeNode *node = NULL;
+               GtkCTreeNode *node = NULL;
        GHashTable *msgid_table;
        GHashTable *subject_table;
        GSList * cur;
-       GtkCTreeNode *cur_parent;
-
+       
        if (!mlist) return;
 
-       debug_print(_("\tSetting summary from message data..."));
+       debug_print("\tSetting summary from message data...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Setting summary from message data..."));
        gdk_flush();
@@ -2045,9 +2095,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
                                summaryview->folder_item->prefs->important_score;
        }
 
-       summaryview_subject_filter_init(summaryview->folder_item->prefs);
-       
-       if (summaryview->folder_item->threaded) {
+       if (summaryview->threaded) {
                GNode *root, *gnode;
 
                root = procmsg_get_thread_tree(mlist);
@@ -2102,7 +2150,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
        if (prefs_common.use_addr_book)
                end_address_completion();
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        if (debug_mode) {
                debug_print("\tmsgid hash table size = %d\n",
@@ -2112,114 +2160,6 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
        }
 }
 
-struct wcachefp
-{
-       FILE *cache_fp;
-       FILE *mark_fp;
-};
-
-gint summary_write_cache(SummaryView *summaryview)
-{
-       struct wcachefp fps;
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       gint ver = CACHE_VERSION;
-       gchar *buf;
-       gchar *cachefile, *markfile;
-       GSList *cur;
-       gint filemode = 0;
-       PrefsFolderItem *prefs;
-
-       if (!summaryview->folder_item || !summaryview->folder_item->path)
-               return -1;
-
-       if (summaryview->folder_item->folder->update_mark != NULL)
-               summaryview->folder_item->folder->update_mark(summaryview->folder_item->folder, summaryview->folder_item);
-
-       cachefile = folder_item_get_cache_file(summaryview->folder_item);
-       g_return_val_if_fail(cachefile != NULL, -1);
-       if ((fps.cache_fp = fopen(cachefile, "wb")) == NULL) {
-               FILE_OP_ERROR(cachefile, "fopen");
-               g_free(cachefile);
-               return -1;
-       }
-       if (change_file_mode_rw(fps.cache_fp, cachefile) < 0)
-               FILE_OP_ERROR(cachefile, "chmod");
-
-       prefs = summaryview->folder_item->prefs;
-        if (prefs && prefs->enable_folder_chmod && prefs->folder_chmod) {
-               /* for cache file */
-               filemode = prefs->folder_chmod;
-               if (filemode & S_IRGRP) filemode |= S_IWGRP;
-               if (filemode & S_IROTH) filemode |= S_IWOTH;
-#if HAVE_FCHMOD
-               fchmod(fileno(fps.cache_fp), filemode);
-#else
-               chmod(cachefile, filemode);
-#endif
-        }
-
-       g_free(cachefile);
-
-       markfile = folder_item_get_mark_file(summaryview->folder_item);
-       if ((fps.mark_fp = fopen(markfile, "wb")) == NULL) {
-               FILE_OP_ERROR(markfile, "fopen");
-               fclose(fps.cache_fp);
-               g_free(markfile);
-               return -1;
-       }
-       if (change_file_mode_rw(fps.mark_fp, markfile) < 0)
-               FILE_OP_ERROR(markfile, "chmod");
-        if (prefs && prefs->enable_folder_chmod && prefs->folder_chmod) {
-#if HAVE_FCHMOD
-               fchmod(fileno(fps.mark_fp), filemode);
-#else
-               chmod(markfile, filemode);
-#endif
-        }
-
-       g_free(markfile);
-
-       buf = g_strdup_printf(_("Writing summary cache (%s)..."),
-                             summaryview->folder_item->path);
-       debug_print(buf);
-       STATUSBAR_PUSH(summaryview->mainwin, buf);
-       g_free(buf);
-
-       WRITE_CACHE_DATA_INT(ver, fps.cache_fp);
-       ver = MARK_VERSION;
-       WRITE_CACHE_DATA_INT(ver, fps.mark_fp);
-
-       gtk_ctree_pre_recursive(ctree, NULL, summary_write_cache_func, &fps);
-
-       for (cur = summaryview->killed_messages; cur != NULL; cur = cur->next) {
-               MsgInfo *msginfo = (MsgInfo *)cur->data;
-               procmsg_write_cache(msginfo, fps.cache_fp);
-               procmsg_write_flags(msginfo, fps.mark_fp);
-       }
-
-       procmsg_flush_mark_queue(summaryview->folder_item, fps.mark_fp);
-
-       fclose(fps.cache_fp);
-       fclose(fps.mark_fp);
-
-       debug_print(_("done.\n"));
-       STATUSBAR_POP(summaryview->mainwin);
-
-       return 0;
-}
-
-static void summary_write_cache_func(GtkCTree *ctree, GtkCTreeNode *node,
-                                    gpointer data)
-{
-       struct wcachefp *fps = data;
-       MsgInfo *msginfo = gtk_ctree_node_get_row_data(ctree, node);
-
-       if (msginfo == NULL) return;
-
-       procmsg_write_cache(msginfo, fps->cache_fp);
-       procmsg_write_flags(msginfo, fps->mark_fp);
-}
-
 static gchar *summary_complete_address(const gchar *addr)
 {
        gint count;
@@ -2247,11 +2187,9 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
 {
        static gchar date_modified[80];
        static gchar *to = NULL;
-       static gchar *from_name = NULL;
-       static gchar col_number[11];
+       static gchar *from = NULL;
        static gchar col_score[11];
        static gchar buf[BUFFSIZE];
-       PrefsFolderItem *prefs = summaryview->folder_item->prefs;
        gint *col_pos = summaryview->col_pos;
 
        text[col_pos[S_COL_MARK]]   = NULL;
@@ -2260,12 +2198,7 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
        text[col_pos[S_COL_LOCKED]] = NULL;
        text[col_pos[S_COL_NUMBER]] = itos(msginfo->msgnum);
        text[col_pos[S_COL_SIZE]]   = to_human_readable(msginfo->size);
-
-#if 0
-       text[col_pos[S_COL_SCORE]]  = itos_buf(col_score, msginfo->threadscore);
-#else
        text[col_pos[S_COL_SCORE]]  = itos_buf(col_score, msginfo->score);
-#endif 
 
        if (msginfo->date_t) {
                procheader_date_get_localtime(date_modified,
@@ -2283,15 +2216,21 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
            !MSG_IS_NEWS(msginfo->flags)) {
                gchar *addr = NULL;
 
+               Xstrdup_a(addr, msginfo->from, return);
+               extract_address(addr);
+
                if (prefs_common.use_addr_book) {
-                       Xstrdup_a(addr, msginfo->from, return);
-                       extract_address(addr);
-
-               if (account_find_from_address(addr)) {
-                       addr = summary_complete_address(msginfo->to);
-                       g_free(to);
-                       to   = g_strconcat("-->", addr == NULL ? msginfo->to : addr, NULL);
-                       text[col_pos[S_COL_FROM]] = to;
+                       if (account_find_from_address(addr)) {
+                               addr = summary_complete_address(msginfo->to);
+                               g_free(to);
+                               to   = g_strconcat("-->", addr == NULL ? msginfo->to : addr, NULL);
+                               text[col_pos[S_COL_FROM]] = to;
+                       }
+               } else {
+                       if (cur_account && cur_account->address && !strcmp( addr, cur_account->address)) {
+                               g_free(to);
+                               to = g_strconcat("-->", msginfo->to, NULL);
+                               text[col_pos[S_COL_FROM]] = to;
                        }
                }
        }
@@ -2302,24 +2241,16 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
         * the --> in sent boxes) was executed.
         */
        if (text[col_pos[S_COL_FROM]] != to && prefs_common.use_addr_book && msginfo->from) {
-               gchar *from;
+               g_free(from);
                from = summary_complete_address(msginfo->from);
-               if (from) {
-                       /*
-                        * FIXME: this text[col_pos[S_COL_FROM]] should be freed
-                        * but may have been assigned _("No From"). Should be
-                        * freed??? 
-                        */
+               if (from)
                        text[col_pos[S_COL_FROM]] = from;
-               }       
        }
 
-       if (prefs->enable_simplify_subject 
-           && prefs->simplify_subject_preg != NULL )
+       if (summaryview->simplify_subject_preg != NULL)
                text[col_pos[S_COL_SUBJECT]] = msginfo->subject ? 
                        string_remove_match(buf, BUFFSIZE, msginfo->subject, 
-                                       prefs->simplify_subject_preg) : 
-                       
+                                       summaryview->simplify_subject_preg) : 
                        _("(No Subject)");
        else 
                text[col_pos[S_COL_SUBJECT]] = msginfo->subject ? msginfo->subject :
@@ -2370,22 +2301,18 @@ static void summary_display_msg_full(SummaryView *summaryview,
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread--;
-       if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags) || 
-           MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_unset_perm_flags(msginfo, MSG_NEW | MSG_UNREAD);
-               summary_set_row_marks(summaryview, row);
-               gtk_clist_thaw(GTK_CLIST(ctree));
-               summary_status_show(summaryview);
-       }
+
+       procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
+       summary_set_row_marks(summaryview, row);
+       gtk_clist_thaw(GTK_CLIST(ctree));
+       summary_status_show(summaryview);
 
        flags = msginfo->flags;
 
        if (new_window) {
                MessageView *msgview;
 
-               msgview = messageview_create_with_new_window();
+               msgview = messageview_create_with_new_window(summaryview->mainwin);
                messageview_show(msgview, msginfo, all_headers);
        } else {
                MessageView *msgview;
@@ -2393,8 +2320,8 @@ static void summary_display_msg_full(SummaryView *summaryview,
                msgview = summaryview->messageview;
 
                summaryview->displayed = row;
-               if (!summaryview->msg_is_toggled_on)
-                       summary_toggle_view(summaryview);
+               if (!messageview_is_visible(msgview))
+                       main_window_toggle_message_view(summaryview->mainwin);
                messageview_show(msgview, msginfo, all_headers);
                if (msgview->type == MVIEW_TEXT ||
                    (msgview->type == MVIEW_MIME &&
@@ -2406,16 +2333,8 @@ static void summary_display_msg_full(SummaryView *summaryview,
                gtkut_ctree_node_move_if_on_the_edge(ctree, row);
        }
 
-       if (MSG_IS_NEW(msginfo->flags) || MSG_IS_UNREAD(msginfo->flags) ||
-           (MSG_IS_MIME(msginfo->flags) - MSG_IS_MIME(flags) != 0)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               CHANGE_FLAGS(msginfo);
-               summary_set_row_marks(summaryview, row);
-               gtk_clist_thaw(GTK_CLIST(ctree));
-               summary_status_show(summaryview);
-       }
        summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
+       toolbar_set_sensitive(summaryview->mainwin);
 
        summary_unlock(summaryview);
 }
@@ -2499,93 +2418,21 @@ void summary_step(SummaryView *summaryview, GtkScrollType type)
                }
        }
 
-       if (summaryview->msg_is_toggled_on)
+       if (messageview_is_visible(summaryview->messageview))
                summaryview->display_msg = TRUE;
 
        gtk_signal_emit_by_name(GTK_OBJECT(ctree), "scroll_vertical",
                                type, 0.0);
 }
 
-static void summary_toggle_view(SummaryView *summaryview)
-{
-       MainWindow *mainwin = summaryview->mainwin;
-       GtkItemFactory *ifactory;
-       
-       if (!mainwin) return;
-       
-       ifactory = gtk_item_factory_from_widget(mainwin->menubar);
-       menu_toggle_toggle(ifactory, "/View/Expand Summary View");
-}
-
-void summary_toggle_view_real(SummaryView *summaryview)
+void summary_toggle_view(SummaryView *summaryview)
 {
-       MainWindow *mainwin = summaryview->mainwin;
-       union CompositeWin *cwin = &mainwin->win;
-       GtkWidget *vpaned = NULL;
-       GtkWidget *container = NULL;
-       GtkWidget *toggle_view_btn;
-       GtkWidget *toggle_view_arrow;
-       GtkItemFactory *ifactory = gtk_item_factory_from_widget(mainwin->menubar);
-       
-       switch (mainwin->type) {
-       case SEPARATE_NONE:
-               vpaned = cwin->sep_none.vpaned;
-               container = cwin->sep_none.hpaned;
-               break;
-       case SEPARATE_FOLDER:
-               vpaned = cwin->sep_folder.vpaned;
-               container = mainwin->vbox_body;
-               break;
-       case SEPARATE_MESSAGE:
-       case SEPARATE_BOTH:
-               return;
-       }
-
-       if (vpaned->parent != NULL) {
-               summaryview->msg_is_toggled_on = FALSE;
-               summaryview->displayed = NULL;
-               gtk_widget_ref(vpaned);
-               gtkut_container_remove(GTK_CONTAINER(container), vpaned);
-               gtk_widget_reparent(GTK_WIDGET_PTR(summaryview), container);
-               
-               gtk_widget_destroy(summaryview->toggle_view_arrow);
-               gtk_widget_destroy(summaryview->toggle_view_btn);
-               
-               toggle_view_btn = gtk_button_new();
-               gtk_box_pack_end(GTK_BOX(summaryview->hbox), toggle_view_btn, FALSE, FALSE, 0);
-               gtk_box_reorder_child(GTK_BOX(summaryview->hbox), toggle_view_btn, 0);
-               gtk_button_set_relief(GTK_BUTTON(toggle_view_btn), GTK_RELIEF_NONE);
-               toggle_view_arrow=gtk_arrow_new(GTK_ARROW_UP, GTK_SHADOW_OUT);
-               gtk_container_add(GTK_CONTAINER(toggle_view_btn), toggle_view_arrow);
-               gtk_signal_connect(GTK_OBJECT(toggle_view_btn), "clicked",
-                                       GTK_SIGNAL_FUNC(summary_toggle_view_cb), summaryview);
-               gtk_widget_show_all(toggle_view_btn);
-               menu_set_sensitive(ifactory, "/View/Expand Message View", FALSE);
-       } else {
-               summaryview->msg_is_toggled_on = TRUE;
-               gtk_widget_reparent(GTK_WIDGET_PTR(summaryview), vpaned);
-               gtk_container_add(GTK_CONTAINER(container), vpaned);
-               gtk_widget_unref(vpaned);
-               
-               gtk_widget_destroy(summaryview->toggle_view_arrow);
-               gtk_widget_destroy(summaryview->toggle_view_btn);
-               
-               toggle_view_btn = gtk_button_new();
-               gtk_box_pack_end(GTK_BOX(summaryview->hbox), toggle_view_btn, FALSE, FALSE, 0);
-               gtk_box_reorder_child(GTK_BOX(summaryview->hbox), toggle_view_btn, 0);
-               gtk_button_set_relief(GTK_BUTTON(toggle_view_btn), GTK_RELIEF_NONE);
-               toggle_view_arrow=gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
-               gtk_container_add(GTK_CONTAINER(toggle_view_btn), toggle_view_arrow);
-               gtk_signal_connect(GTK_OBJECT(toggle_view_btn), "clicked",
-                                       GTK_SIGNAL_FUNC(summary_toggle_view_cb), summaryview);
-               gtk_widget_show_all(toggle_view_btn);
-               menu_set_sensitive(ifactory, "/View/Expand Message View", TRUE);
-       }
-
-       gtk_widget_grab_focus(summaryview->ctree);
-       
-       summaryview->toggle_view_btn = toggle_view_btn;
-       summaryview->toggle_view_arrow = toggle_view_arrow;
+       if (!messageview_is_visible(summaryview->messageview) &&
+           summaryview->selected)
+               summary_display_msg(summaryview,
+                                   summaryview->selected);
+       else
+               main_window_toggle_message_view(summaryview->mainwin);
 }
 
 static gboolean summary_search_unread_recursive(GtkCTree *ctree,
@@ -2776,14 +2623,10 @@ static void summary_mark_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_set_perm_flags(msginfo, MSG_MARKED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_MARKED, 0);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %s/%d is marked\n"), msginfo->folder->path, msginfo->msgnum);
+       debug_print("Message %s/%d is marked\n", msginfo->folder->path, msginfo->msgnum);
 }
 
 static void summary_lock_row(SummaryView *summaryview, GtkCTreeNode *row)
@@ -2810,14 +2653,10 @@ static void summary_lock_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_LOCKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_set_perm_flags(msginfo, MSG_LOCKED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_LOCKED, 0);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is locked\n"), msginfo->msgnum);
+       debug_print("Message %d is locked\n", msginfo->msgnum);
 }
 
 void summary_mark(SummaryView *summaryview)
@@ -2839,20 +2678,19 @@ static void summary_mark_row_as_read(SummaryView *summaryview,
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+
+       if(!MSG_IS_NEW(msginfo->flags) && !MSG_IS_UNREAD(msginfo->flags))
+               return;
+
        if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread--;
-       if (MSG_IS_NEW(msginfo->flags) ||
-           MSG_IS_UNREAD(msginfo->flags)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_unset_perm_flags(msginfo, MSG_NEW | MSG_UNREAD);
-               CHANGE_FLAGS(msginfo);
-               summary_set_row_marks(summaryview, row);
-               debug_print(_("Message %d is marked as read\n"),
-                           msginfo->msgnum);
-       }
+
+       procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
+       summary_set_row_marks(summaryview, row);
+       debug_print("Message %d is marked as read\n",
+               msginfo->msgnum);
 }
 
 void summary_mark_as_read(SummaryView *summaryview)
@@ -2896,22 +2734,17 @@ static void summary_mark_row_as_unread(SummaryView *summaryview,
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
        if (MSG_IS_DELETED(msginfo->flags)) {
                msginfo->to_folder = NULL;
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
+               procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, 0);
                summaryview->deleted--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_REPLIED | MSG_FORWARDED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_REPLIED);
-       if (!MSG_IS_UNREAD(msginfo->flags)) {
-               MSG_SET_PERM_FLAGS(msginfo->flags, MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_set_perm_flags(msginfo, MSG_UNREAD);
+
+       if (!MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread++;
-               debug_print(_("Message %d is marked as unread\n"),
-                           msginfo->msgnum);
-       }
 
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_REPLIED | MSG_FORWARDED, 0);
+       procmsg_msginfo_set_flags(msginfo, MSG_UNREAD, 0);
+       debug_print("Message %d is marked as unread\n",
+               msginfo->msgnum);
 
        summary_set_row_marks(summaryview, row);
 }
@@ -3006,19 +2839,15 @@ static void summary_delete_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_DELETED, 0);
        summaryview->deleted++;
 
        if (!prefs_common.immediate_exec && 
            summaryview->folder_item->stype != F_TRASH)
                summary_set_row_marks(summaryview, row);
 
-       debug_print(_("Message %s/%d is set to delete\n"),
+       debug_print("Message %s/%d is set to delete\n",
                    msginfo->folder->path, msginfo->msgnum);
 }
 
@@ -3064,9 +2893,10 @@ void summary_delete(SummaryView *summaryview)
                else if (sel_last && node == GTK_CTREE_NODE_PREV(sel_last))
                        summary_step(summaryview, GTK_SCROLL_STEP_BACKWARD);
                else
-                       summary_select_node(summaryview, node,
-                                           summaryview->msg_is_toggled_on,
-                                           FALSE);
+                       summary_select_node
+                               (summaryview, node,
+                                messageview_is_visible(summaryview->messageview),
+                                FALSE);
        }
 
        if (prefs_common.immediate_exec || item->stype == F_TRASH)
@@ -3082,7 +2912,7 @@ void summary_delete_duplicated(SummaryView *summaryview)
        if (summaryview->folder_item->stype == F_TRASH) return;
 
        main_window_cursor_wait(summaryview->mainwin);
-       debug_print(_("Deleting duplicated messages..."));
+       debug_print("Deleting duplicated messages...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Deleting duplicated messages..."));
 
@@ -3095,7 +2925,7 @@ void summary_delete_duplicated(SummaryView *summaryview)
        else
                summary_status_show(summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 }
@@ -3137,13 +2967,10 @@ static void summary_unmark_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_MOVE | MSG_COPY);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %s/%d is unmarked\n"),
+
+       debug_print("Message %s/%d is unmarked\n",
                    msginfo->folder->path, msginfo->msgnum);
 }
 
@@ -3185,12 +3012,9 @@ static void summary_move_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                if (!prefs_common.immediate_exec)
                        msginfo->to_folder->op_count--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_COPY);
        if (!MSG_IS_MOVE(msginfo->flags)) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_MOVE);
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_MOVE);
                summaryview->moved++;
                changed = TRUE;
        }
@@ -3203,7 +3027,7 @@ static void summary_move_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                }
        }
 
-       debug_print(_("Message %d is set to move to %s\n"),
+       debug_print("Message %d is set to move to %s\n",
                    msginfo->msgnum, to_folder->path);
 }
 
@@ -3277,12 +3101,9 @@ static void summary_copy_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                if (!prefs_common.immediate_exec)
                        msginfo->to_folder->op_count--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_MOVE);
        if (!MSG_IS_COPY(msginfo->flags)) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_COPY);
                summaryview->copied++;
                changed = TRUE;
        }
@@ -3295,7 +3116,7 @@ static void summary_copy_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                }
        }
 
-       debug_print(_("Message %d is set to copy to %s\n"),
+       debug_print("Message %d is set to copy to %s\n",
                    msginfo->msgnum, to_folder->path);
 }
 
@@ -3404,7 +3225,7 @@ void summary_save_as(SummaryView *summaryview)
        }
 
        src = procmsg_get_message_file(msginfo);
-       if (copy_file(src, dest) < 0) {
+       if (copy_file(src, dest, TRUE) < 0) {
                alertpanel_error(_("Can't save the file `%s'."),
                                 g_basename(dest));
        }
@@ -3457,7 +3278,7 @@ gboolean summary_execute(SummaryView *summaryview)
 
        gtk_clist_freeze(clist);
 
-       if (summaryview->folder_item->threaded)
+       if (summaryview->threaded)
                summary_unthread_for_exec(summaryview);
 
        summary_execute_move(summaryview);
@@ -3480,7 +3301,7 @@ gboolean summary_execute(SummaryView *summaryview)
                node = next;
        }
 
-       if (summaryview->folder_item->threaded)
+       if (summaryview->threaded)
                summary_thread_build(summaryview);
 
        summaryview->selected = clist->selection ?
@@ -3496,8 +3317,6 @@ gboolean summary_execute(SummaryView *summaryview)
        summary_update_status(summaryview);
        summary_status_show(summaryview);
 
-       summary_write_cache(summaryview);
-
        gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
 
        gtk_clist_thaw(clist);
@@ -3520,8 +3339,7 @@ static void summary_execute_move(SummaryView *summaryview)
        if (summaryview->mlist) {
                procmsg_move_messages(summaryview->mlist);
 
-               folder_item_scan_foreach(summaryview->folder_table);
-               folderview_update_item_foreach(summaryview->folder_table);
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                for (cur = summaryview->mlist; cur != NULL; cur = cur->next)
                        procmsg_msginfo_free((MsgInfo *)cur->data);
@@ -3529,6 +3347,7 @@ static void summary_execute_move(SummaryView *summaryview)
                summaryview->mlist = NULL;
        }
 
+       folderview_update_item(summaryview->folder_item, FALSE);
        g_hash_table_destroy(summaryview->folder_table);
        summaryview->folder_table = NULL;
 }
@@ -3574,8 +3393,8 @@ static void summary_execute_copy(SummaryView *summaryview)
        if (summaryview->mlist) {
                procmsg_copy_messages(summaryview->mlist);
 
-               folder_item_scan_foreach(summaryview->folder_table);
-               folderview_update_item_foreach(summaryview->folder_table);
+               /* folder_item_scan_foreach(summaryview->folder_table); */
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                g_slist_free(summaryview->mlist);
                summaryview->mlist = NULL;
@@ -3604,7 +3423,7 @@ static void summary_execute_copy_func(GtkCTree *ctree, GtkCTreeNode *node,
                summaryview->mlist =
                        g_slist_append(summaryview->mlist, msginfo);
 
-               MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+               procmsg_msginfo_unset_flags(msginfo, 0, MSG_COPY);
                summary_set_row_marks(summaryview, node);
        }
 }
@@ -3616,7 +3435,6 @@ static void summary_execute_delete(SummaryView *summaryview)
        GSList *cur;
 
        trash = summaryview->folder_item->folder->trash;
-
        if (summaryview->folder_item->folder->type == F_MH) {
                g_return_if_fail(trash != NULL);
        }
@@ -3640,9 +3458,9 @@ static void summary_execute_delete(SummaryView *summaryview)
        summaryview->mlist = NULL;
 
        if ((summaryview->folder_item != trash) && (trash != NULL)) {
-               folder_item_scan(trash);
                folderview_update_item(trash, FALSE);
        }
+       folderview_update_item(summaryview->folder_item, FALSE);
 }
 
 static void summary_execute_delete_func(GtkCTree *ctree, GtkCTreeNode *node,
@@ -3678,7 +3496,7 @@ void summary_thread_build(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Building threads..."));
+       debug_print("Building threads...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Building threads..."));
        main_window_cursor_wait(summaryview->mainwin);
 
@@ -3732,10 +3550,12 @@ void summary_thread_build(SummaryView *summaryview)
        gtk_signal_handler_unblock_by_func(GTK_OBJECT(ctree),
                                           summary_tree_expanded, summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
+       summaryview->threaded = TRUE;
+
        summary_unlock(summaryview);
 }
 
@@ -3772,10 +3592,10 @@ void summary_unthread(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Unthreading..."));
+       debug_print("Unthreading...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Unthreading..."));
        main_window_cursor_wait(summaryview->mainwin);
-
+       
        gtk_signal_handler_block_by_func(GTK_OBJECT(ctree),
                                         summary_tree_collapsed, summaryview);
        gtk_clist_freeze(GTK_CLIST(ctree));
@@ -3792,14 +3612,19 @@ void summary_unthread(SummaryView *summaryview)
                }
        }
 
+       /* CLAWS: and sort it */
+       gtk_sctree_sort_recursive(ctree, NULL); 
+
        gtk_clist_thaw(GTK_CLIST(ctree));
        gtk_signal_handler_unblock_by_func(GTK_OBJECT(ctree),
                                           summary_tree_collapsed, summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
+       summaryview->threaded = FALSE;
+
        summary_unlock(summaryview);
 }
 
@@ -3810,7 +3635,7 @@ static void summary_unthread_for_exec(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Unthreading for execution..."));
+       debug_print("Unthreading for execution...");
 
        gtk_clist_freeze(GTK_CLIST(ctree));
 
@@ -3821,7 +3646,7 @@ static void summary_unthread_for_exec(SummaryView *summaryview)
 
        gtk_clist_thaw(GTK_CLIST(ctree));
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
 
        summary_unlock(summaryview);
 }
@@ -3858,62 +3683,6 @@ static void summary_unthread_for_exec_func(GtkCTree *ctree, GtkCTreeNode *node,
        }
 }
 
-void summary_processing(SummaryView *summaryview, GSList * mlist)
-{
-       GSList * processing_list;
-       FolderItem * folder_item;
-       GSList * cur;
-       gchar * id;
-       gchar * buf;
-
-       folder_item = summaryview->folder_item;
-       if (folder_item == NULL)
-               return;
-
-       processing_list = folder_item->prefs->processing;
-
-       if (processing_list == NULL)
-               return;
-
-       summary_lock(summaryview);
-       
-       buf = g_strdup_printf(_("Processing (%s)..."), folder_item->path);
-       debug_print(buf);
-       STATUSBAR_PUSH(summaryview->mainwin, buf);
-       g_free(buf);
-
-       main_window_cursor_wait(summaryview->mainwin);
-
-       summaryview->folder_table = g_hash_table_new(NULL, NULL);
-
-       for(cur = mlist ; cur != NULL ; cur = cur->next) {
-               MsgInfo * msginfo;
-
-               msginfo = (MsgInfo *) cur->data;
-               filter_message_by_msginfo(processing_list, msginfo,
-                                         summaryview->folder_table);
-       }
-       
-       folder_item_scan_foreach(summaryview->folder_table);
-       folderview_update_item_foreach(summaryview->folder_table);
-       
-       g_hash_table_destroy(summaryview->folder_table);
-       summaryview->folder_table = NULL;
-       
-       if (prefs_common.immediate_exec) {
-               summary_unlock(summaryview);
-               summary_execute(summaryview);
-               summary_lock(summaryview);
-       } else
-               summary_status_show(summaryview);
-
-       debug_print(_("done.\n"));
-       STATUSBAR_POP(summaryview->mainwin);
-       main_window_cursor_normal(summaryview->mainwin);
-
-       summary_unlock(summaryview);
-}
-
 void summary_expand_threads(SummaryView *summaryview)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
@@ -3959,7 +3728,7 @@ void summary_filter(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("filtering..."));
+       debug_print("filtering...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Filtering..."));
        main_window_cursor_wait(summaryview->mainwin);
 
@@ -3988,14 +3757,14 @@ void summary_filter(SummaryView *summaryview)
 
                gtk_clist_thaw(GTK_CLIST(summaryview->ctree));
 
-               folder_item_scan_foreach(summaryview->folder_table);
-               folderview_update_item_foreach(summaryview->folder_table);
+               /* folder_item_scan_foreach(summaryview->folder_table); */
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                g_hash_table_destroy(summaryview->folder_table);
                summaryview->folder_table = NULL;
        }
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
@@ -4006,7 +3775,7 @@ void summary_filter(SummaryView *summaryview)
         * we want the lock to be context aware...  
         */
        if (global_processing) {
-               summary_show(summaryview, summaryview->folder_item, TRUE);              
+               summary_show(summaryview, summaryview->folder_item);
        }               
 }
 
@@ -4155,7 +3924,6 @@ void summary_filter_open(SummaryView *summaryview, PrefsFilterType type)
 
 void summary_reply(SummaryView *summaryview, ComposeMode mode)
 {
-       GtkWidget *widget;
        GList *sel = GTK_CLIST(summaryview->ctree)->selection;
        MsgInfo *msginfo;
        gchar *text;
@@ -4167,6 +3935,14 @@ void summary_reply(SummaryView *summaryview, ComposeMode mode)
        text = gtkut_editable_get_selection
                (GTK_EDITABLE(summaryview->messageview->textview->text));
 
+       if (!text && summaryview->messageview->type == MVIEW_MIME
+           && summaryview->messageview->mimeview->type == MIMEVIEW_TEXT
+           && summaryview->messageview->mimeview->textview
+           && !summaryview->messageview->mimeview->textview->default_text) {
+               text = gtkut_editable_get_selection (GTK_EDITABLE 
+                        (summaryview->messageview->mimeview->textview->text));   
+       }
+       
        switch (mode) {
        case COMPOSE_REPLY:
                compose_reply(msginfo, prefs_common.reply_with_quote,
@@ -4205,10 +3981,10 @@ void summary_reply(SummaryView *summaryview, ComposeMode mode)
                break;
        case COMPOSE_FORWARD:
                if (prefs_common.forward_as_attachment) {
-                       summary_reply_cb(summaryview, COMPOSE_FORWARD_AS_ATTACH, widget);
+                       summary_reply_cb(summaryview, COMPOSE_FORWARD_AS_ATTACH, NULL);
                        return;
                } else {
-                       summary_reply_cb(summaryview, COMPOSE_FORWARD_INLINE, widget);
+                       summary_reply_cb(summaryview, COMPOSE_FORWARD_INLINE, NULL);
                        return;
                }
                break;
@@ -4229,8 +4005,8 @@ void summary_reply(SummaryView *summaryview, ComposeMode mode)
                        g_slist_free(msginfo_list);
                }                       
                break;
-       case COMPOSE_BOUNCE:
-               compose_bounce(NULL, msginfo);
+       case COMPOSE_REDIRECT:
+               compose_redirect(NULL, msginfo);
                break;
        default:
                g_warning("summary_reply_cb(): invalid action: %d\n", mode);
@@ -4272,8 +4048,8 @@ void summary_set_colorlabel_color(GtkCTree *ctree, GtkCTreeNode *node,
        gint color_index;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, node);
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_CLABEL_FLAG_MASK);
-       MSG_SET_COLORLABEL_VALUE(msginfo->flags, labelcolor);
+       procmsg_msginfo_unset_flags(msginfo, MSG_CLABEL_FLAG_MASK, 0);
+       procmsg_msginfo_set_flags(msginfo, MSG_COLORLABEL_TO_FLAGS(labelcolor), 0);
 
        color_index = labelcolor == 0 ? -1 : (gint)labelcolor - 1;
        ctree_style = gtk_widget_get_style(GTK_WIDGET(ctree));
@@ -4562,13 +4338,8 @@ void summary_set_column_order(SummaryView *summaryview)
        guint selected_msgnum = summary_get_msgnum(summaryview, summaryview->selected);
        guint displayed_msgnum = summary_get_msgnum(summaryview, summaryview->displayed);
 
-       
        item = summaryview->folder_item;
 
-       summary_lock(summaryview);
-       summary_write_cache(summaryview);
-       summary_unlock(summaryview);
-       
        summary_clear_all(summaryview);
        gtk_widget_destroy(summaryview->ctree);
 
@@ -4584,7 +4355,7 @@ void summary_set_column_order(SummaryView *summaryview)
        gtk_container_add(GTK_CONTAINER(scrolledwin), ctree);
        gtk_widget_show(ctree);
 
-       summary_show(summaryview, item, FALSE);
+       summary_show(summaryview, item);
 
        summary_select_by_msgnum(summaryview, selected_msgnum);
        summaryview->displayed = summary_find_msg_by_msgnum(summaryview, displayed_msgnum);
@@ -4595,18 +4366,14 @@ void summary_set_column_order(SummaryView *summaryview)
 }
 
 
-
 /* callback functions */
 
-static void summary_toggle_view_cb(GtkWidget *button,
-                                  gpointer data)
+static void summary_toggle_pressed(GtkWidget *eventbox, GdkEventButton *event,
+                                  SummaryView *summaryview)
 {
-       SummaryView *summaryview = (SummaryView *) data;
-       
-       if (!summaryview->msg_is_toggled_on && summaryview->selected)
-               summary_display_msg(summaryview, summaryview->selected);
-       else
-               summary_toggle_view(summaryview);
+       if (!event) return;
+
+       summary_toggle_view(summaryview);
 }
 
 static void summary_button_pressed(GtkWidget *ctree, GdkEventButton *event,
@@ -4622,7 +4389,7 @@ static void summary_button_pressed(GtkWidget *ctree, GdkEventButton *event,
                summaryview->display_msg = TRUE;
        } else if (event->button == 1) {
                if (!prefs_common.emulate_emacs &&
-                   summaryview->msg_is_toggled_on)
+                   messageview_is_visible(summaryview->messageview))
                        summaryview->display_msg = TRUE;
        }
 }
@@ -4692,6 +4459,12 @@ static void summary_key_pressed(GtkWidget *widget, GdkEventKey *event,
                textview_scroll_one_line(summaryview->messageview->textview,
                                         (event->state & GDK_MOD1_MASK) != 0);
                break;
+       case GDK_asterisk:      /* Mark */
+               summary_mark(summaryview);
+               break;
+       case GDK_exclam:        /* Mark as unread */
+               summary_mark_as_unread(summaryview);
+               break;
        case GDK_Delete:
                RETURN_IF_LOCKED();
                BREAK_ON_MODIFIER_KEY();
@@ -4702,6 +4475,31 @@ static void summary_key_pressed(GtkWidget *widget, GdkEventKey *event,
        }
 }
 
+static void summary_searchbar_pressed(GtkWidget *widget, GdkEventKey *event,
+                               SummaryView *summaryview)
+{
+       if (event != NULL && event->keyval == GDK_Return)
+               summary_show(summaryview, summaryview->folder_item);
+}
+
+static void summary_searchtype_changed(GtkMenuItem *widget, gpointer data)
+{
+       SummaryView *sw = (SummaryView *)data;
+       if (gtk_entry_get_text(GTK_ENTRY(sw->search_string)))
+               summary_show(sw, sw->folder_item);
+}
+
+static void tog_searchbar_cb(GtkWidget *w, gpointer data)
+{
+       if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(w))) {
+               prefs_common.show_searchbar = TRUE;
+               gtk_widget_show(GTK_WIDGET(data));
+       } else {
+               prefs_common.show_searchbar = FALSE;
+               gtk_widget_hide(GTK_WIDGET(data));
+       }
+}
+
 static void summary_open_row(GtkSCTree *sctree, SummaryView *summaryview)
 {
        if (summaryview->folder_item->stype == F_OUTBOX ||
@@ -4737,7 +4535,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
             GTK_CLIST(ctree)->selection->next) {
                summaryview->display_msg = FALSE;
                summary_set_menu_sensitive(summaryview);
-               main_window_set_toolbar_sensitive(summaryview->mainwin);
+               toolbar_set_sensitive(summaryview->mainwin);
                return;
        }
 
@@ -4748,10 +4546,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
        switch (column < 0 ? column : summaryview->col_state[column].type) {
        case S_COL_MARK:
                if (MSG_IS_MARKED(msginfo->flags)) {
-                       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-                       if (MSG_IS_IMAP(msginfo->flags))
-                               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-                       CHANGE_FLAGS(msginfo);
+                       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED, 0);
                        summary_set_row_marks(summaryview, row);
                } else
                        summary_mark_row(summaryview, row);
@@ -4768,8 +4563,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
                break;
        case S_COL_LOCKED:
                if (MSG_IS_LOCKED(msginfo->flags)) {
-                       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_LOCKED);
-                       CHANGE_FLAGS(msginfo);
+                       procmsg_msginfo_unset_flags(msginfo, MSG_LOCKED, 0);
                        summary_set_row_marks(summaryview, row);
                }
                else
@@ -4779,12 +4573,14 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
                break;
        }
 
-       if (summaryview->display_msg) {
+       if (summaryview->display_msg ||
+           (prefs_common.show_msg_with_cursor_key &&
+            messageview_is_visible(summaryview->messageview))) {
                summary_display_msg(summaryview, row);
                summaryview->display_msg = FALSE;
        } else {
                summary_set_menu_sensitive(summaryview);
-               main_window_set_toolbar_sensitive(summaryview->mainwin);
+               toolbar_set_sensitive(summaryview->mainwin);
        }
 }
 
@@ -4827,57 +4623,68 @@ static void summary_create_filter_cb(SummaryView *summaryview,
        summary_filter_open(summaryview, (PrefsFilterType)action);
 }
 
+static void summary_sort_by_column_click(SummaryView *summaryview,
+                                        FolderSortKey sort_key)
+{
+       if (summaryview->sort_key == sort_key)
+               summary_sort(summaryview, sort_key,
+                            summaryview->sort_type == SORT_ASCENDING
+                            ? SORT_DESCENDING : SORT_ASCENDING);
+       else
+               summary_sort(summaryview, sort_key, SORT_ASCENDING);
+}
+
 static void summary_mark_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_MARK);
+       summary_sort_by_column_click(summaryview, SORT_BY_MARK);
 }
 
 static void summary_unread_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_UNREAD);
+       summary_sort_by_column_click(summaryview, SORT_BY_UNREAD);
 }
 
 static void summary_mime_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_MIME);
+       summary_sort_by_column_click(summaryview, SORT_BY_MIME);
 }
 
 static void summary_num_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_NUMBER);
+       summary_sort_by_column_click(summaryview, SORT_BY_NUMBER);
 }
 
-static void summary_score_clicked(GtkWidget *button,
-                                 SummaryView *summaryview)
+static void summary_size_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_SCORE);
+       summary_sort_by_column_click(summaryview, SORT_BY_SIZE);
 }
 
-static void summary_locked_clicked(GtkWidget *button,
-                                 SummaryView *summaryview)
+static void summary_date_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_LOCKED);
+       summary_sort_by_column_click(summaryview, SORT_BY_DATE);
 }
 
-static void summary_size_clicked(GtkWidget *button, SummaryView *summaryview)
+static void summary_from_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_SIZE);
+       summary_sort_by_column_click(summaryview, SORT_BY_FROM);
 }
 
-static void summary_date_clicked(GtkWidget *button, SummaryView *summaryview)
+static void summary_subject_clicked(GtkWidget *button,
+                                   SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_DATE);
+       summary_sort_by_column_click(summaryview, SORT_BY_SUBJECT);
 }
 
-static void summary_from_clicked(GtkWidget *button, SummaryView *summaryview)
+static void summary_score_clicked(GtkWidget *button,
+                                 SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_FROM);
+       summary_sort_by_column_click(summaryview, SORT_BY_SCORE);
 }
 
-static void summary_subject_clicked(GtkWidget *button,
-                                   SummaryView *summaryview)
+static void summary_locked_clicked(GtkWidget *button,
+                                  SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_SUBJECT);
+       summary_sort_by_column_click(summaryview, SORT_BY_LOCKED);
 }
 
 static void summary_start_drag(GtkWidget *widget, gint button, GdkEvent *event,
@@ -5029,6 +4836,38 @@ static gint summary_cmp_by_subject(GtkCList *clist,
        return strcasecmp(msginfo1->subject, msginfo2->subject);
 }
 
+static gint summary_cmp_by_simplified_subject
+       (GtkCList *clist, gconstpointer ptr1, gconstpointer ptr2)
+{
+       const PrefsFolderItem *prefs;
+       const gchar *str1, *str2;
+       const GtkCListRow *r1 = (const GtkCListRow *) ptr1;
+       const GtkCListRow *r2 = (const GtkCListRow *) ptr2;
+       const MsgInfo *msginfo1 = r1->data;
+       const MsgInfo *msginfo2 = r2->data;
+       const SummaryView *sv = gtk_object_get_data(GTK_OBJECT(clist), "summaryview");
+       
+       g_return_val_if_fail(sv, -1);
+       g_return_val_if_fail(msginfo1 != NULL && msginfo2 != NULL, -1);
+       
+       str1 = GTK_CELL_TEXT(r1->cell[sv->col_pos[S_COL_SUBJECT]])->text;
+       str2 = GTK_CELL_TEXT(r2->cell[sv->col_pos[S_COL_SUBJECT]])->text;
+
+       if (!str1)
+               return str2 != NULL;
+
+       if (!str2)
+               return -1;
+
+       prefs = msginfo1->folder->prefs;
+       if (!prefs)
+               prefs = msginfo2->folder->prefs;
+       if (!prefs)
+               return -1;
+       
+       return strcasecmp(str1, str2);
+}
+
 static gint summary_cmp_by_label(GtkCList *clist,
                                 gconstpointer ptr1, gconstpointer ptr2)
 {
@@ -5044,60 +4883,24 @@ static void news_flag_crosspost(MsgInfo *msginfo)
        GString *line;
        gpointer key;
        gpointer value;
-       MsgPermFlags flags;
        Folder *mff = msginfo->folder->folder;
 
        if (mff->account->mark_crosspost_read && MSG_IS_NEWS(msginfo->flags)) {
                line = g_string_sized_new(128);
                g_string_sprintf(line, "%s:%d", msginfo->folder->path, msginfo->msgnum);
-               debug_print(_("nfcp: checking <%s>"), line->str);
+               debug_print("nfcp: checking <%s>", line->str);
                if (mff->newsart && 
                    g_hash_table_lookup_extended(mff->newsart, line->str, &key, &value)) {
-                       debug_print(_(" <%s>"), value);
+                       debug_print(" <%s>", (gchar *)value);
                        if (MSG_IS_NEW(msginfo->flags) || MSG_IS_UNREAD(msginfo->flags)) {
-                               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-                               MSG_SET_COLORLABEL_VALUE(msginfo->flags, mff->account->crosspost_col);
+                               procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
+                               procmsg_msginfo_set_flags(msginfo, mff->account->crosspost_col, 0);
                        }
                        g_hash_table_remove(mff->newsart, key);
                        g_free(key);
                }
                g_string_free(line, TRUE);
-               debug_print(_("\n"));
-       }
-}
-
-static void news_process_crossposted(MsgInfo *msginfo)
-{
-       gchar **crossref;
-       gchar **crp;
-       gchar *cp;
-       gint cnt;
-       static char *read = "read";
-       Folder *mff = msginfo->folder->folder;
-
-       /* Get the Xref: line */
-       if (msginfo->xref) {
-               /* Retrieve the cross-posted groups and message ids */
-               /* Format of Xref is Xref: server message:id message:id ... */
-               crossref = g_strsplit(msginfo->xref, " ", 1024);
-               for (crp = crossref+2, cnt = 0; *crp; crp++, cnt++) {
-                       if ((cp = strchr(*crp, ':'))) {
-                               *cp = '\0';
-                               if (!strcmp(*crp, msginfo->folder->path)) continue;
-                               *cp = ':';
-
-                               /* On first pass, create a GHashTable to hold the list of
-                                * article numbers per newsgroup that have been read. */
-                               if (!mff->newsart) {
-                                       mff->newsart = g_hash_table_new(g_str_hash, g_str_equal);
-                               }
-                               /* When a summary is selected, the articles for that
-                                * newsgroup are marked based on this entry */
-                               g_hash_table_insert(mff->newsart, g_strdup(*crp), read);
-                               debug_print(_("Cross-reference %d: Hash <%s>\n"), cnt, *crp);
-                       }
-               }
-               g_strfreev(crossref);
+               debug_print("\n");
        }
 }
 
@@ -5128,13 +4931,11 @@ static gint summary_cmp_by_locked(GtkCList *clist,
 
 static void summary_select_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpointer data)
 {
-       SummaryView *summaryview = (SummaryView *) data;
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
        gtk_ctree_select(GTK_CTREE(ctree), row);        
-       debug_print(_("Message %d selected\n"),
-           msginfo->msgnum);
+       debug_print("Message %d selected\n", msginfo->msgnum);
 }
 
 /* select current thread */
@@ -5163,20 +4964,19 @@ static void summary_ignore_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpoin
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+
        if (MSG_IS_NEW(msginfo->flags))
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags))
                summaryview->unread--;
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_IGNORE_THREAD);
 
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_set_flags(msginfo, MSG_IGNORE_THREAD, 0);
 
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is marked as ignore thread\n"),
+       debug_print("Message %d is marked as ignore thread\n",
            msginfo->msgnum);
 }
 
-
 static void summary_ignore_thread(SummaryView *summaryview)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
@@ -5195,16 +4995,16 @@ static void summary_unignore_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpo
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+
        if (MSG_IS_NEW(msginfo->flags))
                summaryview->newmsgs++;
        if (MSG_IS_UNREAD(msginfo->flags))
                summaryview->unread++;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_IGNORE_THREAD);
 
-       CHANGE_FLAGS(msginfo);
-               
+       procmsg_msginfo_unset_flags(msginfo, MSG_IGNORE_THREAD, 0);
+
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is marked as unignore thread\n"),
+       debug_print("Message %d is marked as unignore thread\n",
            msginfo->msgnum);
 }
 
@@ -5220,6 +5020,7 @@ static void summary_unignore_thread(SummaryView *summaryview)
        summary_status_show(summaryview);
 }
 
+#if 0 /* OLD PROCESSING */
 static gboolean processing_apply_func(GNode *node, gpointer data)
 {
        FolderItem *item;
@@ -5235,6 +5036,7 @@ static gboolean processing_apply_func(GNode *node, gpointer data)
                return FALSE;
        processing = item->prefs->processing;
 
+
        if (processing != NULL) {
                gchar * buf;
                GSList * mlist;
@@ -5245,9 +5047,11 @@ static gboolean processing_apply_func(GNode *node, gpointer data)
                STATUSBAR_PUSH(summaryview->mainwin, buf);
                g_free(buf);
 
+/*
                mlist = item->folder->get_msg_list(item->folder, item,
                                                   TRUE);
-               
+*/             
+               mlist = folder_item_get_msg_list(item);
                for(cur = mlist ; cur != NULL ; cur = cur->next) {
                        MsgInfo * msginfo;
                        
@@ -5277,6 +5081,7 @@ void processing_apply(SummaryView * summaryview)
                                processing_apply_func, summaryview);
        }
 }
+#endif
 
 void summary_toggle_show_read_messages(SummaryView *summaryview)
 {
@@ -5284,7 +5089,7 @@ void summary_toggle_show_read_messages(SummaryView *summaryview)
                summaryview->folder_item->hide_read_msgs = 0;
        else
                summaryview->folder_item->hide_read_msgs = 1;
-       summary_show(summaryview, summaryview->folder_item, FALSE);
+       summary_show(summaryview, summaryview->folder_item);
 }
  
 static void summary_set_hide_read_msgs_menu (SummaryView *summaryview,
@@ -5300,66 +5105,32 @@ static void summary_set_hide_read_msgs_menu (SummaryView *summaryview,
        gtk_object_set_data(GTK_OBJECT(widget), "dont_toggle",
                            GINT_TO_POINTER(0));
 }
-static void summaryview_subject_filter_init(PrefsFolderItem *prefs)
-{
-       int err;
-       gchar buf[BUFFSIZE];
-       if (prefs->enable_simplify_subject) {
-               if (prefs->simplify_subject_regexp && 
-                               *prefs->simplify_subject_regexp != 0x00) {
-
-                       if (!prefs->simplify_subject_preg) 
-                               prefs->simplify_subject_preg = g_new(regex_t, 1);
-                       else
-                               regfree(prefs->simplify_subject_preg);
-
-                       err = string_match_precompile(prefs->simplify_subject_regexp, 
-                                       prefs->simplify_subject_preg, REG_EXTENDED);
-                       if (err) {
-                               regerror(err, prefs->simplify_subject_preg, buf, BUFFSIZE);
-                               alertpanel_error(_("Regular expression (regexp) error:\n%s"), buf);
-                               g_free(prefs->simplify_subject_preg);
-                               prefs->simplify_subject_preg = NULL;
-                       }
-               } else {
-                       if (prefs->simplify_subject_preg) {
-                               regfree(prefs->simplify_subject_preg);
-                               g_free(prefs->simplify_subject_preg);
-                               prefs->simplify_subject_preg = NULL;
-                       }
-               }
-       }
-}
 
 void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
 {
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCList *clist = GTK_CLIST(summaryview->ctree);
-       GtkCTreeNode *node;
+       GtkWidget *ctree = summaryview->ctree;
        GtkWidget *pixmap; 
 
        gtk_widget_destroy(summaryview->folder_pixmap);
 
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_MARK, &markxpm, &markxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_DELETED, &deletedxpm, &deletedxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_NEW, &newxpm, &newxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_UNREAD, &unreadxpm, &unreadxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_REPLIED, &repliedxpm, &repliedxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_FORWARDED, &forwardedxpm, &forwardedxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_CLIP, &clipxpm, &clipxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_LOCKED, &lockedxpm, &lockedxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_IGNORETHREAD, &ignorethreadxpm, &ignorethreadxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_CLIP_KEY, &clipkeyxpm, &clipkeyxpmmask);
-       stock_pixmap_gdk(summaryview->ctree, STOCK_PIXMAP_KEY, &keyxpm, &keyxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_MARK, &markxpm, &markxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_DELETED, &deletedxpm, &deletedxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_NEW, &newxpm, &newxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_UNREAD, &unreadxpm, &unreadxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_REPLIED, &repliedxpm, &repliedxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_FORWARDED, &forwardedxpm, &forwardedxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_CLIP, &clipxpm, &clipxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_LOCKED, &lockedxpm, &lockedxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_IGNORETHREAD, &ignorethreadxpm, &ignorethreadxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_CLIP_KEY, &clipkeyxpm, &clipkeyxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_KEY, &keyxpm, &keyxpmmask);
 
        pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_DIR_OPEN);
        gtk_box_pack_start(GTK_BOX(summaryview->hbox), pixmap, FALSE, FALSE, 4);
-       gtk_box_reorder_child(GTK_BOX(summaryview->hbox), pixmap, 0);
+       gtk_box_reorder_child(GTK_BOX(summaryview->hbox), pixmap, 1); /* search_toggle before */
        gtk_widget_show(pixmap);
        summaryview->folder_pixmap = pixmap; 
 
-       summary_write_cache(summaryview);
-
        folderview_unselect(summaryview->folderview);
        folderview_select(summaryview->folderview, summaryview->folder_item);
 }
@@ -5367,7 +5138,8 @@ void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
 /*
  * Harvest addresses for selected messages in summary view.
  */
-void summary_harvest_address( SummaryView *summaryview ) {
+void summary_harvest_address(SummaryView *summaryview)
+{
        GtkCTree *ctree = GTK_CTREE( summaryview->ctree );
        GList *cur;
        GList *msgList;
@@ -5382,7 +5154,59 @@ void summary_harvest_address( SummaryView *summaryview ) {
        g_list_free( msgList );
 }
 
+static regex_t *summary_compile_simplify_regexp(gchar *simplify_subject_regexp)
+{
+       int err;
+       gchar buf[BUFFSIZE];
+       regex_t *preg = NULL;
+       
+       preg = g_new0(regex_t, 1);
+
+       err = string_match_precompile(simplify_subject_regexp, 
+                                     preg, REG_EXTENDED);
+       if (err) {
+               regerror(err, preg, buf, BUFFSIZE);
+               alertpanel_error(_("Regular expression (regexp) error:\n%s"), buf);
+               g_free(preg);
+               preg = NULL;
+       }
+       
+       return preg;
+}
+
+void summary_set_prefs_from_folderitem(SummaryView *summaryview, FolderItem *item)
+{
+       g_return_if_fail(summaryview != NULL);
+       g_return_if_fail(item != NULL);
+
+       /* Subject simplification */
+       if(summaryview->simplify_subject_preg) {
+               regfree(summaryview->simplify_subject_preg);
+               g_free(summaryview->simplify_subject_preg);
+               summaryview->simplify_subject_preg = NULL;
+       }
+       if(item->prefs && item->prefs->simplify_subject_regexp && 
+          item->prefs->simplify_subject_regexp[0] && item->prefs->enable_simplify_subject)
+               summaryview->simplify_subject_preg = summary_compile_simplify_regexp(item->prefs->simplify_subject_regexp);
+
+       /* Sorting */
+       summaryview->sort_key = item->sort_key;
+       summaryview->sort_type = item->sort_type;
+
+       /* Threading */
+       summaryview->threaded = item->threaded;
+}
+
+void summary_save_prefs_to_folderitem(SummaryView *summaryview, FolderItem *item)
+{
+       /* Sorting */
+       item->sort_key = summaryview->sort_key;
+       item->sort_type = summaryview->sort_type;
+
+       /* Threading */
+       item->threaded = summaryview->threaded;
+}
+
 /*
  * End of Source.
  */
-