message, but do not display it */
node = summary_find_next_unread_msg(summaryview, NULL);
if (node == NULL && GTK_CLIST(ctree)->row_list != NULL)
- node = GTK_CTREE_NODE
- (GTK_CLIST(ctree)->row_list_end);
+ node = gtk_ctree_node_nth
+ (ctree, GTK_CLIST(ctree)->rows - 1);
summary_select_node(summaryview, node, FALSE);
}
} else {
else
node = summary_find_next_unread_msg(summaryview, NULL);
- if (node == NULL && GTK_CLIST(ctree)->row_list != NULL)
- node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list_end);
- summary_select_node(summaryview, node,
- prefs_common.open_unread_on_enter);
+ if (node == NULL && GTK_CLIST(ctree)->row_list != NULL) {
+ /* Get the last visible node on screen */
+ /* FIXME: huh, what happens if node is null? that allowed?? */
+ node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
+ }
+ if (prefs_common.open_unread_on_enter) {
+ summary_unlock(summaryview);
+ summary_select_node(summaryview, node, TRUE);
+ summary_lock(summaryview);
+ } else
+ summary_select_node(summaryview, node, FALSE);
}
summary_status_show(summaryview);
if (summaryview->folder_item->folder->type != F_NEWS) {
menu_set_sensitive(ifactory, "/Move...", TRUE);
menu_set_sensitive(ifactory, "/Copy...", TRUE);
- if (summaryview->folder_item->stype != F_TRASH)
- menu_set_sensitive(ifactory, "/Delete", TRUE);
+ menu_set_sensitive(ifactory, "/Delete", TRUE);
}
menu_set_sensitive(ifactory, "/Execute", TRUE);
if (current_node)
node = current_node;
else
- node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list_end);
+ node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
msginfo = gtk_ctree_node_get_row_data(ctree, node);
if (current_node)
node = GTK_CTREE_NODE_PREV(current_node);
else
- node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list_end);
+ node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
msginfo = gtk_ctree_node_get_row_data(ctree, node);
if (current_node)
node = GTK_CTREE_NODE_PREV(current_node);
else
- node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list_end);
+ node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
msginfo = gtk_ctree_node_get_row_data(ctree, node);
gtk_signal_emit_by_name(GTK_OBJECT(ctree), "scroll_vertical",
type, 0.0);
-
+
if (summaryview->msg_is_toggled_on)
summary_display_msg(summaryview, summaryview->selected, FALSE);
}
CHANGE_FLAGS(msginfo);
summaryview->deleted++;
- if (!prefs_common.immediate_exec)
+ if (!prefs_common.immediate_exec &&
+ summaryview->folder_item->stype != F_TRASH)
summary_set_row_marks(summaryview, row);
debug_print(_("Message %s/%d is set to delete\n"),
void summary_delete(SummaryView *summaryview)
{
GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
+ FolderItem *item = summaryview->folder_item;
GList *cur;
+ GtkCTreeNode *dsp_last, *sel_last;
- if (!summaryview->folder_item ||
- summaryview->folder_item->folder->type == F_NEWS) return;
+ if (!item || item->folder->type == F_NEWS) return;
if (summary_is_locked(summaryview)) return;
- /* if current folder is trash, don't delete */
- if (summaryview->folder_item->stype == F_TRASH) {
- alertpanel_notice(_("Current folder is Trash."));
- return;
+ /* if current folder is trash, ask for confirmation */
+ if (item->stype == F_TRASH) {
+ AlertValue aval;
+
+ aval = alertpanel(_("Delete message(s)"),
+ _("Do you really want to delete message(s) from the trash?"),
+ _("Yes"), _("No"), NULL);
+ if (aval != G_ALERTDEFAULT) return;
}
- for (cur = GTK_CLIST(ctree)->selection; cur != NULL; cur = cur->next)
- summary_delete_row(summaryview, GTK_CTREE_NODE(cur->data));
+ /* next code sets current row focus right. if the last selection
+ * is also the last displayed row, we need to scroll backwards.
+ * exception: if the last displayed row is an uncollapsed node,
+ * we don't scroll back. */
+ dsp_last = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
+ sel_last = NULL;
+ for (cur = GTK_CLIST(ctree)->selection; cur != NULL; cur = cur->next) {
+ sel_last = GTK_CTREE_NODE(cur->data);
+ summary_delete_row(summaryview, GTK_CTREE_NODE(sel_last));
+ }
- summary_step(summaryview, GTK_SCROLL_STEP_FORWARD);
+ if (dsp_last == sel_last && GTK_CTREE_ROW(sel_last)->expanded)
+ summary_step(summaryview, GTK_SCROLL_STEP_BACKWARD);
+ else
+ summary_step(summaryview, GTK_SCROLL_STEP_FORWARD);
- if (prefs_common.immediate_exec)
+ if (prefs_common.immediate_exec || item->stype == F_TRASH)
summary_execute(summaryview);
else
summary_status_show(summaryview);
if (summaryview->folder_item->folder->type == F_MH) {
g_return_if_fail(trash != NULL);
}
- if (summaryview->folder_item == trash) return;
/* search deleting messages and execute */
gtk_ctree_pre_recursive
if (!summaryview->mlist) return;
- for(cur = summaryview->mlist ; cur != NULL ; cur = cur->next) {
- MsgInfo * msginfo = cur->data;
- MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
- }
-
- folder_item_move_msgs_with_dest(trash, summaryview->mlist);
+ if (summaryview->folder_item != trash)
+ folder_item_move_msgs_with_dest(trash, summaryview->mlist);
+ else
+ folder_item_remove_msgs(trash, summaryview->mlist);
for (cur = summaryview->mlist; cur != NULL; cur = cur->next)
procmsg_msginfo_free((MsgInfo *)cur->data);
g_slist_free(summaryview->mlist);
summaryview->mlist = NULL;
- folder_item_scan(trash);
- folderview_update_item(trash, FALSE);
+ if (summaryview->folder_item != trash) {
+ folder_item_scan(trash);
+ folderview_update_item(trash, FALSE);
+ }
}
static void summary_execute_delete_func(GtkCTree *ctree, GtkCTreeNode *node,
break;
case COMPOSE_REPLY_TO_ALL:
compose_reply(msginfo, prefs_common.reply_with_quote,
- TRUE, FALSE);
+ TRUE, TRUE);
break;
case COMPOSE_REPLY_TO_ALL_WITH_QUOTE:
compose_reply(msginfo, TRUE, TRUE, FALSE);
projects / claws.git / blobdiff