* src/folderview.c
[claws.git] / src / summaryview.c
index e54fc331c0384cfee77bd21e2eb6bf913e5c7d93..27aee338077c83e3d1cb7af86dca9f2ef6fa8d5b 100644 (file)
 #include "foldersel.h"
 #include "procmsg.h"
 #include "procheader.h"
-#include "headerwindow.h"
 #include "sourcewindow.h"
 #include "prefs_common.h"
 #include "prefs_summary_column.h"
 #include "prefs_filter.h"
+#include "prefs_filtering.h"
 #include "account.h"
 #include "compose.h"
 #include "utils.h"
 #include "gtkutils.h"
 #include "stock_pixmap.h"
 #include "filesel.h"
-#include "manage_window.h"
 #include "alertpanel.h"
 #include "inputdialog.h"
 #include "statusbar.h"
 #include "prefs_folder_item.h"
 #include "filtering.h"
 #include "string_match.h"
-
-#define STATUSBAR_PUSH(mainwin, str) \
-{ \
-       gtk_statusbar_push(GTK_STATUSBAR(mainwin->statusbar), \
-                          mainwin->summaryview_cid, str); \
-       gtkut_widget_wait_for_draw(mainwin->hbox_stat); \
-}
-
-#define STATUSBAR_POP(mainwin) \
-{ \
-       gtk_statusbar_pop(GTK_STATUSBAR(mainwin->statusbar), \
-                         mainwin->summaryview_cid); \
-}
+#include "toolbar.h"
 
 #define SUMMARY_COL_MARK_WIDTH         10
 #define SUMMARY_COL_UNREAD_WIDTH       13
@@ -144,9 +131,6 @@ static void summary_free_msginfo_func       (GtkCTree               *ctree,
 static void summary_set_marks_func     (GtkCTree               *ctree,
                                         GtkCTreeNode           *node,
                                         gpointer                data);
-static void summary_write_cache_func   (GtkCTree               *ctree,
-                                        GtkCTreeNode           *node,
-                                        gpointer                data);
 
 static void summary_set_menu_sensitive (SummaryView            *summaryview);
 
@@ -162,24 +146,18 @@ static GtkCTreeNode *summary_find_prev_msg
 static GtkCTreeNode *summary_find_next_msg
                                        (SummaryView            *summaryview,
                                         GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_unread_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_unread_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_marked_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_marked_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_labeled_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_labeled_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
+
+static GtkCTreeNode *summary_find_prev_flagged_msg
+                                       (SummaryView    *summaryview,
+                                        GtkCTreeNode   *current_node,
+                                        MsgPermFlags    flags,
+                                        gboolean        start_from_prev);
+static GtkCTreeNode *summary_find_next_flagged_msg
+                                       (SummaryView    *summaryview,
+                                        GtkCTreeNode   *current_node,
+                                        MsgPermFlags    flags,
+                                        gboolean        start_from_next);
+
 static GtkCTreeNode *summary_find_msg_by_msgnum
                                        (SummaryView            *summaryview,
                                         guint                   msgnum);
@@ -202,7 +180,6 @@ static void summary_display_msg_full        (SummaryView            *summaryview,
                                         gboolean                all_headers);
 static void summary_set_row_marks      (SummaryView            *summaryview,
                                         GtkCTreeNode           *row);
-static void summaryview_subject_filter_init (PrefsFolderItem    *prefs);
 
 /* message handling */
 static void summary_mark_row           (SummaryView            *summaryview,
@@ -254,7 +231,9 @@ static void summary_unthread_for_exec_func  (GtkCTree       *ctree,
 void summary_simplify_subject(SummaryView *summaryview, gchar * rexp,
                              GSList * mlist);
 
+#if 0
 void summary_processing(SummaryView *summaryview, GSList * mlist);
+#endif
 static void summary_filter_func                (GtkCTree               *ctree,
                                         GtkCTreeNode           *node,
                                         gpointer                data);
@@ -269,11 +248,10 @@ static void summary_colorlabel_menu_create(SummaryView    *summaryview);
 
 static GtkWidget *summary_ctree_create (SummaryView    *summaryview);
 
-static void summary_toggle_view(SummaryView *summarview);
-
 /* callback functions */
-static void summary_toggle_view_cb     (GtkWidget      *widget,
-                                        gpointer       data);                                   
+static void summary_toggle_pressed     (GtkWidget              *eventbox,
+                                        GdkEventButton         *event,
+                                        SummaryView            *summaryview);
 static void summary_button_pressed     (GtkWidget              *ctree,
                                         GdkEventButton         *event,
                                         SummaryView            *summaryview);
@@ -312,6 +290,9 @@ static void summary_show_all_header_cb      (SummaryView            *summaryview,
 static void summary_add_address_cb     (SummaryView            *summaryview,
                                         guint                   action,
                                         GtkWidget              *widget);
+static void summary_create_filter_cb   (SummaryView            *summaryview,
+                                        guint                   action,
+                                        GtkWidget              *widget);
 
 static void summary_mark_clicked       (GtkWidget              *button,
                                         SummaryView            *summaryview);
@@ -373,6 +354,8 @@ static gint summary_cmp_by_from             (GtkCList               *clist,
 static gint summary_cmp_by_subject     (GtkCList               *clist,
                                         gconstpointer           ptr1,
                                         gconstpointer           ptr2);
+static gint summary_cmp_by_simplified_subject
+       (GtkCList *clist, gconstpointer ptr1, gconstpointer ptr2);
 static gint summary_cmp_by_score       (GtkCList               *clist,
                                         gconstpointer           ptr1,
                                         gconstpointer           ptr2);
@@ -382,6 +365,8 @@ static gint summary_cmp_by_label    (GtkCList               *clist,
                                         gconstpointer           ptr1,
                                         gconstpointer           ptr2);
 
+static void news_flag_crosspost                (MsgInfo *msginfo);
+
 GtkTargetEntry summary_drag_types[1] =
 {
        {"text/plain", GTK_TARGET_SAME_APP, TARGET_DUMMY}
@@ -394,10 +379,13 @@ static GtkItemFactoryEntry summary_popup_entries[] =
        {N_("/Follow-up and reply to"), NULL, summary_reply_cb, COMPOSE_FOLLOWUP_AND_REPLY_TO, NULL},
        {N_("/Reply to a_ll"),          NULL, summary_reply_cb, COMPOSE_REPLY_TO_ALL, NULL},
        {N_("/_Forward"),               NULL, summary_reply_cb, COMPOSE_FORWARD, NULL},
-       {N_("/Bounce"),                 NULL, summary_reply_cb, COMPOSE_BOUNCE, NULL},
+       {N_("/Redirect"),               NULL, summary_reply_cb, COMPOSE_REDIRECT, NULL},
        {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
        {N_("/Re-_edit"),               NULL, summary_reedit,   0, NULL},
        {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
+       {N_("/Select _thread"),         NULL, summary_select_thread, 0, NULL},
+       {N_("/Select _all"),            NULL, summary_select_all, 0, NULL},
+       {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
        {N_("/M_ove..."),               NULL, summary_move_to,  0, NULL},
        {N_("/_Copy..."),               NULL, summary_copy_to,  0, NULL},
        {N_("/_Delete"),                NULL, summary_delete,   0, NULL},
@@ -417,17 +405,24 @@ static GtkItemFactoryEntry summary_popup_entries[] =
        {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
        {N_("/Add sender to address boo_k"),
                                        NULL, summary_add_address_cb, 0, NULL},
+       {N_("/Create f_ilter rule"),    NULL, NULL,             0, "<Branch>"},
+       {N_("/Create f_ilter rule/_Automatically"),
+                                       NULL, summary_create_filter_cb, FILTER_BY_AUTO, NULL},
+       {N_("/Create f_ilter rule/by _From"),
+                                       NULL, summary_create_filter_cb, FILTER_BY_FROM, NULL},
+       {N_("/Create f_ilter rule/by _To"),
+                                       NULL, summary_create_filter_cb, FILTER_BY_TO, NULL},
+       {N_("/Create f_ilter rule/by _Subject"),
+                                       NULL, summary_create_filter_cb, FILTER_BY_SUBJECT, NULL},
        {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
        {N_("/_View"),                  NULL, NULL,             0, "<Branch>"},
        {N_("/_View/Open in new _window"),
                                        NULL, summary_open_msg, 0, NULL},
        {N_("/_View/_Source"),          NULL, summary_view_source, 0, NULL},
-       {N_("/_View/All _header"),      NULL, summary_show_all_header_cb, 0, NULL},
+       {N_("/_View/All _header"),      NULL, summary_show_all_header_cb, 0, "<ToggleItem>"},
        {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
        {N_("/_Save as..."),            NULL, summary_save_as,  0, NULL},
        {N_("/_Print..."),              NULL, summary_print,    0, NULL},
-       {N_("/---"),                    NULL, NULL,             0, "<Separator>"},
-       {N_("/Select _all"),            NULL, summary_select_all, 0, NULL}
 };
 
 static const gchar *const col_label[N_SUMMARY_COLS] = {
@@ -450,16 +445,18 @@ SummaryView *summary_create(void)
        GtkWidget *scrolledwin;
        GtkWidget *ctree;
        GtkWidget *hbox;
+       GtkWidget *hbox_l;
        GtkWidget *statlabel_folder;
        GtkWidget *statlabel_select;
        GtkWidget *statlabel_msgs;
-       GtkWidget *toggle_view_btn;
-       GtkWidget *toggle_view_arrow;
+       GtkWidget *hbox_spc;
+       GtkWidget *toggle_eventbox;
+       GtkWidget *toggle_arrow;
        GtkWidget *popupmenu;
        GtkItemFactory *popupfactory;
        gint n_entries;
 
-       debug_print(_("Creating summary view...\n"));
+       debug_print("Creating summary view...\n");
        summaryview = g_new0(SummaryView, 1);
 
        vbox = gtk_vbox_new(FALSE, 2);
@@ -485,23 +482,29 @@ SummaryView *summary_create(void)
        hbox = gtk_hbox_new(FALSE, 0);
        gtk_box_pack_end(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
 
+       hbox_l = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_start(GTK_BOX(hbox), hbox_l, TRUE, TRUE, 0);
+
        statlabel_folder = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(hbox), statlabel_folder, FALSE, FALSE, 2);
+       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_folder, FALSE, FALSE, 2);
        statlabel_select = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(hbox), statlabel_select, FALSE, FALSE, 16);
-
-       /* toggle view buttons */
-       toggle_view_btn = gtk_button_new();
-       gtk_box_pack_end(GTK_BOX(hbox), toggle_view_btn, FALSE, FALSE, 0);
-       gtk_button_set_relief(GTK_BUTTON(toggle_view_btn), GTK_RELIEF_NONE);
-       toggle_view_arrow=gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
-       gtk_container_add(GTK_CONTAINER(toggle_view_btn), toggle_view_arrow);
-       gtk_signal_connect(GTK_OBJECT(toggle_view_btn), "clicked",
-                               GTK_SIGNAL_FUNC(summary_toggle_view_cb), summaryview);
+       gtk_box_pack_start(GTK_BOX(hbox_l), statlabel_select, FALSE, FALSE, 12);
+
+       /* toggle view button */
+       toggle_eventbox = gtk_event_box_new();
+       gtk_box_pack_end(GTK_BOX(hbox), toggle_eventbox, FALSE, FALSE, 4);
+       toggle_arrow = gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
+       gtk_container_add(GTK_CONTAINER(toggle_eventbox), toggle_arrow);
+       gtk_signal_connect(GTK_OBJECT(toggle_eventbox), "button_press_event",
+                          GTK_SIGNAL_FUNC(summary_toggle_pressed),
+                          summaryview);
 
        statlabel_msgs = gtk_label_new("");
        gtk_box_pack_end(GTK_BOX(hbox), statlabel_msgs, FALSE, FALSE, 4);
 
+       hbox_spc = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_end(GTK_BOX(hbox), hbox_spc, FALSE, FALSE, 6);
+
        /* create popup menu */
        n_entries = sizeof(summary_popup_entries) /
                sizeof(summary_popup_entries[0]);
@@ -513,17 +516,19 @@ SummaryView *summary_create(void)
        summaryview->scrolledwin = scrolledwin;
        summaryview->ctree = ctree;
        summaryview->hbox = hbox;
+       summaryview->hbox_l = hbox_l;
        summaryview->statlabel_folder = statlabel_folder;
        summaryview->statlabel_select = statlabel_select;
        summaryview->statlabel_msgs = statlabel_msgs;
-       summaryview->toggle_view_btn = toggle_view_btn;
-       summaryview->toggle_view_arrow = toggle_view_arrow;
+       summaryview->toggle_eventbox = toggle_eventbox;
+       summaryview->toggle_arrow = toggle_arrow;
        summaryview->popupmenu = popupmenu;
        summaryview->popupfactory = popupfactory;
-       summaryview->msg_is_toggled_on = TRUE;
        summaryview->lock_count = 0;
-       summaryview->sort_mode = SORT_BY_NONE;
-       summaryview->sort_type = GTK_SORT_ASCENDING;
+
+       /* CLAWS: need this to get the SummaryView * from
+        * the CList */
+       gtk_object_set_data(GTK_OBJECT(ctree), "summaryview", (gpointer)summaryview); 
 
        gtk_widget_show_all(vbox);
 
@@ -592,10 +597,14 @@ void summary_init(SummaryView *summaryview)
        gtk_widget_set_style(summaryview->statlabel_select, style);
        gtk_widget_set_style(summaryview->statlabel_msgs, style);
 
-       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_DIR_OPEN);
-       gtk_box_pack_start(GTK_BOX(summaryview->hbox), pixmap, FALSE, FALSE, 4);
-       gtk_box_reorder_child(GTK_BOX(summaryview->hbox), pixmap, 0);
+       pixmap = stock_pixmap_widget(summaryview->hbox_l, STOCK_PIXMAP_DIR_OPEN);
+       gtk_box_pack_start(GTK_BOX(summaryview->hbox_l), pixmap, FALSE, FALSE, 4);
+       gtk_box_reorder_child(GTK_BOX(summaryview->hbox_l), pixmap, 0);
        gtk_widget_show(pixmap);
+       summaryview->folder_pixmap = pixmap;
+
+       /* Init Summaryview prefs */
+       summaryview->simplify_subject_preg = NULL;
 
        summary_clear_list(summaryview);
        summary_set_column_titles(summaryview);
@@ -666,8 +675,7 @@ GtkCTreeNode * summary_find_prev_important_score(SummaryView *summaryview,
                return best_node;
 }
 
-gboolean summary_show(SummaryView *summaryview, FolderItem *item,
-                     gboolean update_cache)
+gboolean summary_show(SummaryView *summaryview, FolderItem *item)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCTreeNode *node;
@@ -676,11 +684,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
        gboolean is_refresh;
        guint selected_msgnum = 0;
        guint displayed_msgnum = 0;
-       GtkCTreeNode *selected_node = summaryview->folderview->selected;
        GSList *cur;
-       gint sort_mode;
-       gint sort_type;
-        static gboolean locked = FALSE;
 
        if (summary_is_locked(summaryview)) return FALSE;
 
@@ -690,8 +694,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
        STATUSBAR_POP(summaryview->mainwin);
 
        is_refresh = (!prefs_common.open_inbox_on_inc &&
-                     item == summaryview->folder_item &&
-                     update_cache == FALSE) ? TRUE : FALSE;
+                     item == summaryview->folder_item) ? TRUE : FALSE;
        if (is_refresh) {
                selected_msgnum = summary_get_msgnum(summaryview,
                                                     summaryview->selected);
@@ -707,39 +710,24 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                val = alertpanel(_("Process mark"),
                                 _("Some marks are left. Process it?"),
                                 _("Yes"), _("No"), _("Cancel"));
-               if (G_ALERTDEFAULT == val)
+               if (G_ALERTDEFAULT == val) {
+                       summary_unlock(summaryview);
                        summary_execute(summaryview);
-               else if (G_ALERTALTERNATE == val)
-                       summary_write_cache(summaryview);
-               else {
+                       summary_lock(summaryview);
+               } else if (G_ALERTALTERNATE == val) {
+                       /* DO NOTHING */
+               } else {
                        summary_unlock(summaryview);
                        inc_unlock();
                        return FALSE;
                }
                folder_update_op_count();
-       } else {
-               /* 
-                * CLAWS: summary_show() is responsible for updating the caches. 
-                * after filtering inc.c::inc_finished() forces the update of
-                * the cache by indirectly calling summary_show() (by re-selecting
-                * the currently selected mail folder).  
-                * this collides with the new filtering system that may have set 
-                * any message flag before calling summary_show(). 
-                * we can prevent this cache-write by checking the opened member
-                * of the folderview. if this is NULL, the folderview forced
-                * an update of the summary view.
-                */
-               if (summaryview->folderview->opened) 
-                       summary_write_cache(summaryview);
-       }       
-        
-       summaryview->folderview->opened = selected_node;
-
+       }
+       
        gtk_clist_freeze(GTK_CLIST(ctree));
 
        summary_clear_list(summaryview);
        summary_set_column_titles(summaryview);
-       summary_set_menu_sensitive(summaryview);
        if (!is_refresh)
                messageview_clear(summaryview->messageview);
 
@@ -749,7 +737,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
             ((buf = folder_item_get_path(item)) == NULL ||
              change_dir(buf) < 0))) {
                g_free(buf);
-               debug_print(_("empty folder\n\n"));
+               debug_print("empty folder\n\n");
                summary_set_hide_read_msgs_menu(summaryview, FALSE);
                if (is_refresh)
                        messageview_clear(summaryview->messageview);
@@ -763,6 +751,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
        g_free(buf);
 
        summaryview->folder_item = item;
+       item->opened = TRUE;
 
        gtk_signal_handler_block_by_data(GTK_OBJECT(ctree), summaryview);
 
@@ -773,10 +762,17 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
 
        main_window_cursor_wait(summaryview->mainwin);
 
+/*
        mlist = item->folder->get_msg_list(item->folder, item, !update_cache);
 
+       !!! NEW !!!
+       USE LIST FROM CACHE, WILL NOT DISPLAY ANY MESSAGES DROPED
+       BY OTHER PROGRAMS TO THE FOLDER
+*/
+       mlist = folder_item_get_msg_list(item);
+#if 0
        summary_processing(summaryview, mlist);
-
+#endif
        for(cur = mlist ; cur != NULL ; cur = g_slist_next(cur)) {
                MsgInfo * msginfo = (MsgInfo *) cur->data;
 
@@ -788,11 +784,8 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                }
        }
 
-       summaryview->killed_messages = NULL;
-
        if (summaryview->folder_item->hide_read_msgs) {
                GSList *not_killed;
-               gint kill_score;
                
                summary_set_hide_read_msgs_menu(summaryview, TRUE);
                not_killed = NULL;
@@ -805,8 +798,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                             && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                            not_killed = g_slist_append(not_killed, msginfo);
                        else
-                               summaryview->killed_messages = 
-                                       g_slist_append(summaryview->killed_messages, msginfo);
+                               procmsg_msginfo_free(msginfo);
                }
                g_slist_free(mlist);
                mlist = not_killed;
@@ -814,8 +806,7 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                summary_set_hide_read_msgs_menu(summaryview, FALSE);
        }
 
-       if ((global_scoring || item->prefs->scoring) &&
-           (item->folder->type == F_NEWS)) {
+       if ((global_scoring || item->prefs->scoring)) {
                GSList *not_killed;
                gint kill_score;
 
@@ -826,12 +817,10 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                for(cur = mlist ; cur != NULL ; cur = g_slist_next(cur)) {
                        MsgInfo * msginfo = (MsgInfo *) cur->data;
 
-                       if (MSG_IS_NEWS(msginfo->flags) &&
-                           (msginfo->score <= kill_score))
-                               summaryview->killed_messages = g_slist_append(summaryview->killed_messages, msginfo);
+                       if (msginfo->score > kill_score)
+                               not_killed = g_slist_append(not_killed, msginfo);
                        else
-                               not_killed = g_slist_append(not_killed,
-                                                           msginfo);
+                               procmsg_msginfo_free(msginfo);
                }
                g_slist_free(mlist);
                mlist = not_killed;
@@ -845,26 +834,16 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
 
        g_slist_free(mlist);
 
-       summary_write_cache(summaryview);
+       folderview_update_msg_num(summaryview->folderview,
+                                 summaryview->folderview->opened);
+
+       if (item->sort_key != SORT_BY_NONE)
+               summary_sort(summaryview, item->sort_key, item->sort_type);
 
        gtk_signal_handler_unblock_by_data(GTK_OBJECT(ctree), summaryview);
 
        gtk_clist_thaw(GTK_CLIST(ctree));
 
-       /* sort before */
-       sort_mode = prefs_folder_item_get_sort_mode(item);
-       sort_type = prefs_folder_item_get_sort_type(item);
-
-       if (sort_mode != SORT_BY_NONE) {
-               summaryview->sort_mode = sort_mode;
-               if (sort_type == GTK_SORT_DESCENDING)
-                       summaryview->sort_type = GTK_SORT_ASCENDING;
-               else
-                       summaryview->sort_type = GTK_SORT_DESCENDING;
-
-               summary_sort(summaryview, sort_mode);
-       }
-
        if (is_refresh) {
                summaryview->displayed =
                        summary_find_msg_by_msgnum(summaryview,
@@ -875,36 +854,40 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                if (!summaryview->selected) {
                        /* no selected message - select first unread
                           message, but do not display it */
-                       node = summary_find_next_unread_msg(summaryview, NULL);
+                       node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                            MSG_UNREAD, FALSE);
                        if (node == NULL && GTK_CLIST(ctree)->row_list != NULL)
                                node = gtk_ctree_node_nth
-                                       (ctree, GTK_CLIST(ctree)->rows - 1);
-                       summary_select_node(summaryview, node, FALSE);
+                                       (ctree,
+                                        item->sort_type == SORT_DESCENDING
+                                        ? 0 : GTK_CLIST(ctree)->rows - 1);
+                       summary_select_node(summaryview, node, FALSE, TRUE);
                }
        } else {
                /* select first unread message */
-               if (sort_mode == SORT_BY_SCORE)
+               if (item->sort_key == SORT_BY_SCORE)
                        node = summary_find_next_important_score(summaryview,
                                                                 NULL);
                else
-                       node = summary_find_next_unread_msg(summaryview, NULL);
-
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_UNREAD, FALSE);
                if (node == NULL && GTK_CLIST(ctree)->row_list != NULL) {
-                       /* Get the last visible node on screen */
-                       /* FIXME: huh, what happens if node is null? that allowed?? */
-                       node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
-               }       
+                       node = gtk_ctree_node_nth
+                               (ctree,
+                                item->sort_type == SORT_DESCENDING
+                                ? 0 : GTK_CLIST(ctree)->rows - 1);
+               }
                if (prefs_common.open_unread_on_enter) {
                        summary_unlock(summaryview);
-                       summary_select_node(summaryview, node, TRUE);
+                       summary_select_node(summaryview, node, TRUE, TRUE);
                        summary_lock(summaryview);
                } else
-                       summary_select_node(summaryview, node, FALSE);
+                       summary_select_node(summaryview, node, FALSE, TRUE);
        }
 
        summary_status_show(summaryview);
        summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
+       toolbar_set_sensitive(summaryview->mainwin);
 
        debug_print("\n");
        STATUSBAR_PUSH(summaryview->mainwin, _("Done."));
@@ -920,23 +903,16 @@ void summary_clear_list(SummaryView *summaryview)
 {
        GtkCList *clist = GTK_CLIST(summaryview->ctree);
        gint optimal_width;
-       GSList * cur;
 
        gtk_clist_freeze(clist);
 
-       for(cur = summaryview->killed_messages ; cur != NULL ; 
-           cur = g_slist_next(cur)) {
-               MsgInfo * msginfo = (MsgInfo *) cur->data;
-
-               procmsg_msginfo_free(msginfo);
-       }
-       g_slist_free(summaryview->killed_messages);
-       summaryview->killed_messages = NULL;
-
        gtk_ctree_pre_recursive(GTK_CTREE(summaryview->ctree),
                                NULL, summary_free_msginfo_func, NULL);
 
-       summaryview->folder_item = NULL;
+       if (summaryview->folder_item) {
+               summaryview->folder_item->opened = FALSE;
+               summaryview->folder_item = NULL;
+       }
 
        summaryview->display_msg = FALSE;
 
@@ -959,8 +935,6 @@ void summary_clear_list(SummaryView *summaryview)
                g_hash_table_destroy(summaryview->folder_table);
                summaryview->folder_table = NULL;
        }
-       summaryview->sort_mode = SORT_BY_NONE;
-       summaryview->sort_type = GTK_SORT_ASCENDING;
 
        gtk_clist_clear(clist);
        if (summaryview->col_pos[S_COL_SUBJECT] == N_SUMMARY_COLS - 1) {
@@ -978,7 +952,7 @@ void summary_clear_all(SummaryView *summaryview)
 {
        summary_clear_list(summaryview);
        summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
+       toolbar_set_sensitive(summaryview->mainwin);
        summary_status_show(summaryview);
 }
 
@@ -1019,6 +993,7 @@ static void summary_set_menu_sensitive(SummaryView *summaryview)
 {
        GtkItemFactory *ifactory = summaryview->popupfactory;
        SummarySelection selection;
+       GtkWidget *menuitem;
        gboolean sens;
 
        selection = summary_get_selection_type(summaryview);
@@ -1035,15 +1010,17 @@ static void summary_set_menu_sensitive(SummaryView *summaryview)
                return;
        }
 
-       if (summaryview->folder_item->folder->type != F_NEWS) {
+       if (summaryview->folder_item->folder->type != F_NEWS)
                menu_set_sensitive(ifactory, "/Move...", TRUE);
-               menu_set_sensitive(ifactory, "/Delete", TRUE);
-       }
+       else
+               menu_set_sensitive(ifactory, "/Move...", FALSE);
 
+       menu_set_sensitive(ifactory, "/Delete", TRUE);
+       menu_set_sensitive(ifactory, "/Select all", TRUE);
        menu_set_sensitive(ifactory, "/Copy...", TRUE);
        menu_set_sensitive(ifactory, "/Execute", TRUE);
 
-        menu_set_sensitive(ifactory, "/Mark", TRUE);
+       menu_set_sensitive(ifactory, "/Mark", TRUE);
        menu_set_sensitive(ifactory, "/Mark/Mark",   TRUE);
        menu_set_sensitive(ifactory, "/Mark/Unmark", TRUE);
 
@@ -1060,9 +1037,10 @@ static void summary_set_menu_sensitive(SummaryView *summaryview)
        menu_set_sensitive(ifactory, "/Reply to sender",          sens);
        menu_set_sensitive(ifactory, "/Reply to all",             sens);
        menu_set_sensitive(ifactory, "/Forward",                  TRUE);
-       menu_set_sensitive(ifactory, "/Bounce",                   TRUE);
+       menu_set_sensitive(ifactory, "/Redirect",                 sens);
 
        menu_set_sensitive(ifactory, "/Add sender to address book", sens);
+       menu_set_sensitive(ifactory, "/Create filter rule",         sens);
 
        menu_set_sensitive(ifactory, "/View", sens);
        menu_set_sensitive(ifactory, "/View/Open in new window", sens);
@@ -1072,29 +1050,36 @@ static void summary_set_menu_sensitive(SummaryView *summaryview)
            summaryview->folder_item->stype == F_DRAFT  ||
            summaryview->folder_item->stype == F_QUEUE)
                menu_set_sensitive(ifactory, "/Re-edit", sens);
+       else
+               menu_set_sensitive(ifactory, "/Re-edit", FALSE);
 
+       menu_set_sensitive(ifactory, "/Select thread", sens);
        menu_set_sensitive(ifactory, "/Save as...", sens);
        menu_set_sensitive(ifactory, "/Print...",   TRUE);
 
-       menu_set_sensitive(ifactory, "/Select all", TRUE);
-
        if (summaryview->folder_item->folder->account)
                sens = summaryview->folder_item->folder->account->protocol
                        == A_NNTP;
        else
                sens = FALSE;
        menu_set_sensitive(ifactory, "/Follow-up and reply to", sens);
+       summary_lock(summaryview);
+       menuitem = gtk_item_factory_get_widget(ifactory, "/View/All header");
+       gtk_check_menu_item_set_active
+               (GTK_CHECK_MENU_ITEM(menuitem),
+                summaryview->messageview->textview->show_all_headers);
+       summary_unlock(summaryview);
 }
 
 void summary_select_prev_unread(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
-       node = summary_find_prev_unread_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_UNREAD, FALSE);
 
        if (!node) {
-               AlertValue val;
+               AlertValue val = 0;
 
                switch (prefs_common.next_unread_msg_dialog) {
                        case NEXTUNREADMSGDIALOG_ALWAYS:
@@ -1114,19 +1099,14 @@ void summary_select_prev_unread(SummaryView *summaryview)
                                        _("Internal error: unexpected value for prefs_common.next_unread_msg_dialog\n"));
                }
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_unread_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_UNREAD, FALSE);
        }
 
-       if (!node) {
+       if (!node)
                alertpanel_notice(_("No unread messages."));
-       } else {
-               gtkut_ctree_expand_parent_all(ctree, node);
-               gtk_sctree_unselect_all(GTK_SCTREE(ctree));
-               gtk_sctree_select(GTK_SCTREE(ctree), node);
-               if (summaryview->displayed == node)
-                       summaryview->displayed = NULL;
-               summary_display_msg(summaryview, node);
-       }
+       else
+               summary_select_node(summaryview, node, TRUE, FALSE);
 }
 
 void summary_select_next_unread(SummaryView *summaryview)
@@ -1134,27 +1114,90 @@ void summary_select_next_unread(SummaryView *summaryview)
        GtkCTreeNode *node = summaryview->selected;
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
-       while ((node = summary_find_next_unread_msg(summaryview, node)) == NULL) {
+       node = summary_find_next_flagged_msg
+               (summaryview, node, MSG_UNREAD, FALSE);
+       
+       if (node)
+               summary_select_node(summaryview, node, TRUE, FALSE);
+       else {
+               node = summary_find_next_flagged_msg
+                       (summaryview, NULL, MSG_UNREAD, FALSE);
+               if (node == NULL) {
+                       AlertValue val = 0;
+
+                       switch (prefs_common.next_unread_msg_dialog) {
+                               case NEXTUNREADMSGDIALOG_ALWAYS:
+                                       val = alertpanel(_("No more unread messages"),
+                                                        _("No unread message found. "
+                                                          "Go to next folder?"),
+                                                        _("Yes"), _("No"), NULL);
+                                       break;
+                               case NEXTUNREADMSGDIALOG_ASSUME_YES:
+                                       val = G_ALERTDEFAULT;
+                                       break;
+                               case NEXTUNREADMSGDIALOG_ASSUME_NO:
+                                       val = G_ALERTOTHER;
+                                       break;
+                               default:
+                                       debug_print(
+                                               _("Internal error: unexpected value for prefs_common.next_unread_msg_dialog\n"));
+                       }
+
+                       if (val == G_ALERTDEFAULT) {
+                               if (gtk_signal_n_emissions_by_name
+                                       (GTK_OBJECT(ctree), "key_press_event") > 0)
+                                               gtk_signal_emit_stop_by_name
+                                                       (GTK_OBJECT(ctree),
+                                                        "key_press_event");
+                               folderview_select_next_unread(summaryview->folderview);
+                               return;
+                       } 
+                       else
+                               return;
+               } else
+                       summary_select_node(summaryview, node, TRUE, FALSE);
+
+       }
+}
+
+void summary_select_prev_new(SummaryView *summaryview)
+{
+       GtkCTreeNode *node;
+
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_NEW, FALSE);
+
+       if (!node) {
                AlertValue val;
 
-               switch (prefs_common.next_unread_msg_dialog) {
-                       case NEXTUNREADMSGDIALOG_ALWAYS:
-                               val = alertpanel(_("No more unread messages"),
-                                                _("No unread message found. "
-                                                  "Go to next folder?"),
-                                                _("Yes"), _("Search again"), _("No"));
-                               break;
-                       case NEXTUNREADMSGDIALOG_ASSUME_YES:
-                               val = G_ALERTDEFAULT;
-                               break;
-                       case NEXTUNREADMSGDIALOG_ASSUME_NO:
-                               val = !G_ALERTDEFAULT;
-                               break;
-                       default:
-                               debug_print(
-                                       _("Internal error: unexpected value for prefs_common.next_unread_msg_dialog\n"));
-               }
+               val = alertpanel(_("No more new messages"),
+                                _("No new message found. "
+                                  "Search from the end?"),
+                                _("Yes"), _("No"), NULL);
+               if (val != G_ALERTDEFAULT) return;
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_NEW, FALSE);
+       }
 
+       if (!node)
+               alertpanel_notice(_("No new messages."));
+       else
+               summary_select_node(summaryview, node, TRUE, FALSE);
+}
+
+void summary_select_next_new(SummaryView *summaryview)
+{
+       GtkCTreeNode *node = summaryview->selected;
+       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
+
+       while ((node = summary_find_next_flagged_msg
+               (summaryview, node, MSG_NEW, FALSE)) == NULL) {
+               AlertValue val;
+
+               val = alertpanel(_("No more new messages"),
+                                _("No new message found. "
+                                  "Go to next folder?"),
+                                _("Yes"), _("Search again"), _("No"));
                if (val == G_ALERTDEFAULT) {
                        if (gtk_signal_n_emissions_by_name
                                (GTK_OBJECT(ctree), "key_press_event") > 0)
@@ -1169,22 +1212,16 @@ void summary_select_next_unread(SummaryView *summaryview)
                        return;
        }
 
-       if (node) {
-               gtkut_ctree_expand_parent_all(ctree, node);
-               gtk_sctree_unselect_all(GTK_SCTREE(ctree));
-               gtk_sctree_select(GTK_SCTREE(ctree), node);
-               if (summaryview->displayed == node)
-                       summaryview->displayed = NULL;
-               summary_display_msg(summaryview, node);
-       }
+       if (node)
+               summary_select_node(summaryview, node, TRUE, FALSE);
 }
 
 void summary_select_prev_marked(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
-       node = summary_find_prev_marked_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_MARKED, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1194,27 +1231,22 @@ void summary_select_prev_marked(SummaryView *summaryview)
                                   "Search from the end?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_marked_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_MARKED, TRUE);
        }
 
-       if (!node) {
+       if (!node)
                alertpanel_notice(_("No marked messages."));
-       } else {
-               gtkut_ctree_expand_parent_all(ctree, node);
-               gtk_sctree_unselect_all(GTK_SCTREE(ctree));
-               gtk_sctree_select(GTK_SCTREE(ctree), node);
-               if (summaryview->displayed == node)
-                       summaryview->displayed = NULL;
-               summary_display_msg(summaryview, node);
-       }
+       else
+               summary_select_node(summaryview, node, TRUE, FALSE);
 }
 
 void summary_select_next_marked(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
-       node = summary_find_next_marked_msg(summaryview, summaryview->selected);
+       node = summary_find_next_flagged_msg
+               (summaryview, summaryview->selected, MSG_MARKED, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1224,27 +1256,22 @@ void summary_select_next_marked(SummaryView *summaryview)
                                   "Search from the beginning?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_next_marked_msg(summaryview, NULL);
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_MARKED, TRUE);
        }
 
-       if (!node) {
+       if (!node)
                alertpanel_notice(_("No marked messages."));
-       } else {
-               gtkut_ctree_expand_parent_all(ctree, node);
-               gtk_sctree_unselect_all(GTK_SCTREE(ctree));
-               gtk_sctree_select(GTK_SCTREE(ctree), node);
-               if (summaryview->displayed == node)
-                       summaryview->displayed = NULL;
-               summary_display_msg(summaryview, node);
-       }
+       else
+               summary_select_node(summaryview, node, TRUE, FALSE);
 }
 
 void summary_select_prev_labeled(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
-       node = summary_find_prev_labeled_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_CLABEL_FLAG_MASK, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1254,27 +1281,22 @@ void summary_select_prev_labeled(SummaryView *summaryview)
                                   "Search from the end?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_labeled_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_CLABEL_FLAG_MASK, TRUE);
        }
 
-       if (!node) {
+       if (!node)
                alertpanel_notice(_("No labeled messages."));
-       } else {
-               gtkut_ctree_expand_parent_all(ctree, node);
-               gtk_sctree_unselect_all(GTK_SCTREE(ctree));
-               gtk_sctree_select(GTK_SCTREE(ctree), node);
-               if (summaryview->displayed == node)
-                       summaryview->displayed = NULL;
-               summary_display_msg(summaryview, node);
-       }
+       else
+               summary_select_node(summaryview, node, TRUE, FALSE);
 }
 
 void summary_select_next_labeled(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
-       node = summary_find_next_labeled_msg(summaryview, summaryview->selected);
+       node = summary_find_next_flagged_msg
+               (summaryview, summaryview->selected, MSG_CLABEL_FLAG_MASK, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1284,19 +1306,14 @@ void summary_select_next_labeled(SummaryView *summaryview)
                                   "Search from the beginning?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_next_labeled_msg(summaryview, NULL);
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_CLABEL_FLAG_MASK, TRUE);
        }
 
-       if (!node) {
+       if (!node)
                alertpanel_notice(_("No labeled messages."));
-       } else {
-               gtkut_ctree_expand_parent_all(ctree, node);
-               gtk_sctree_unselect_all(GTK_SCTREE(ctree));
-               gtk_sctree_select(GTK_SCTREE(ctree), node);
-               if (summaryview->displayed == node)
-                       summaryview->displayed = NULL;
-               summary_display_msg(summaryview, node);
-       }
+       else
+               summary_select_node(summaryview, node, TRUE, FALSE);
 }
 
 void summary_select_by_msgnum(SummaryView *summaryview, guint msgnum)
@@ -1304,7 +1321,7 @@ void summary_select_by_msgnum(SummaryView *summaryview, guint msgnum)
        GtkCTreeNode *node;
 
        node = summary_find_msg_by_msgnum(summaryview, msgnum);
-       summary_select_node(summaryview, node, FALSE);
+       summary_select_node(summaryview, node, FALSE, TRUE);
 }
 
 /**
@@ -1312,22 +1329,28 @@ void summary_select_by_msgnum(SummaryView *summaryview, guint msgnum)
  * @summaryview: Summary view.
  * @node: Summary tree node.
  * @display_msg: TRUE to display the selected message.
+ * @do_refresh: TRUE to refresh the widget.
  *
  * Select @node (bringing it into view by scrolling and expanding its
  * thread, if necessary) and unselect all others.  If @display_msg is
  * TRUE, display the corresponding message in the message view.
+ * If @do_refresh is TRUE, the widget is refreshed.
  **/
 void summary_select_node(SummaryView *summaryview, GtkCTreeNode *node,
-                        gboolean display_msg)
+                        gboolean display_msg, gboolean do_refresh)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
        if (node) {
-               GTK_EVENTS_FLUSH();
                gtkut_ctree_expand_parent_all(ctree, node);
-               gtk_ctree_node_moveto(ctree, node, -1, 0.5, 0);
-               gtk_widget_grab_focus(GTK_WIDGET(ctree));
+               if (do_refresh) {
+                       GTK_EVENTS_FLUSH();
+                       gtk_widget_grab_focus(GTK_WIDGET(ctree));
+                       gtk_ctree_node_moveto(ctree, node, -1, 0.5, 0);
+               }
                gtk_sctree_unselect_all(GTK_SCTREE(ctree));
+               if (display_msg && summaryview->displayed == node)
+                       summaryview->displayed = NULL;
                summaryview->display_msg = display_msg;
                gtk_sctree_select(GTK_SCTREE(ctree), node);
        }
@@ -1358,8 +1381,7 @@ static GtkCTreeNode *summary_find_prev_msg(SummaryView *summaryview,
 
        for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (!MSG_IS_DELETED(msginfo->flags))
-                       break;
+               if (!MSG_IS_DELETED(msginfo->flags)) break;
        }
 
        return node;
@@ -1379,128 +1401,61 @@ static GtkCTreeNode *summary_find_next_msg(SummaryView *summaryview,
 
        for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (!MSG_IS_DELETED(msginfo->flags))
-                       break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_prev_unread_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = current_node;
-       else
-               node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
-
-       for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) break;
+               if (!MSG_IS_DELETED(msginfo->flags)) break;
        }
 
        return node;
 }
 
-static GtkCTreeNode *summary_find_next_unread_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
+static GtkCTreeNode *summary_find_prev_flagged_msg(SummaryView *summaryview,
+                                                  GtkCTreeNode *current_node,
+                                                  MsgPermFlags flags,
+                                                  gboolean start_from_prev)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCTreeNode *node;
        MsgInfo *msginfo;
 
-       if (current_node)
-               node = current_node;
-       else
-               node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
-
-       for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_prev_marked_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = GTK_CTREE_NODE_PREV(current_node);
-       else
-               node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
-
-       for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_MARKED(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_next_marked_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = gtkut_ctree_node_next(ctree, current_node);
-       else
-               node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
-
-       for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_MARKED(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_prev_labeled_msg(SummaryView *summaryview,
-                                                  GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = GTK_CTREE_NODE_PREV(current_node);
-       else
+       if (current_node) {
+               if (start_from_prev)
+                       node = GTK_CTREE_NODE_PREV(current_node);
+               else
+                       node = current_node;
+       } else
                node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
 
        for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_GET_COLORLABEL_VALUE(msginfo->flags) > 0) break;
+               if ((msginfo->flags.perm_flags & flags) != 0) break;
        }
 
        return node;
 }
 
-static GtkCTreeNode *summary_find_next_labeled_msg(SummaryView *summaryview,
-                                                  GtkCTreeNode *current_node)
+static GtkCTreeNode *summary_find_next_flagged_msg(SummaryView *summaryview,
+                                                  GtkCTreeNode *current_node,
+                                                  MsgPermFlags flags,
+                                                  gboolean start_from_next)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCTreeNode *node;
        MsgInfo *msginfo;
 
-       if (current_node)
-               node = gtkut_ctree_node_next(ctree, current_node);
-       else
+       if (current_node) {
+               if (start_from_next)
+                       node = gtkut_ctree_node_next(ctree, current_node);
+               else
+                       node = current_node;
+       } else
                node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
 
        for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_GET_COLORLABEL_VALUE(msginfo->flags) > 0) break;
+               /* Find msg with matching flags but ignore messages with
+                  ignore flags, if searching for new or unread messages */
+               if (!(((flags & (MSG_NEW | MSG_UNREAD)) != 0) && MSG_IS_IGNORE_THREAD(msginfo->flags)) && 
+                       ((msginfo->flags.perm_flags & flags) != 0))
+                       break;
        }
 
        return node;
@@ -1558,7 +1513,7 @@ void summary_attract_by_subject(SummaryView *summaryview)
        MsgInfo *src_msginfo, *dst_msginfo;
        GHashTable *subject_table;
 
-       debug_print(_("Attracting messages by subject..."));
+       debug_print("Attracting messages by subject...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Attracting messages by subject..."));
 
@@ -1604,7 +1559,7 @@ void summary_attract_by_subject(SummaryView *summaryview)
 
        gtk_clist_thaw(clist);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
 
        main_window_cursor_normal(summaryview->mainwin);
@@ -1627,6 +1582,9 @@ static void summary_set_marks_func(GtkCTree *ctree, GtkCTreeNode *node,
 
        msginfo = gtk_ctree_node_get_row_data(ctree, node);
 
+       if (MSG_IS_NEWS(msginfo->flags))
+               news_flag_crosspost(msginfo);
+
        if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->newmsgs++;
        if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
@@ -1697,11 +1655,17 @@ static void summary_status_show(SummaryView *summaryview)
                n_selected++;
        }
 
-       gtk_label_set(GTK_LABEL(summaryview->statlabel_folder),
-                     summaryview->folder_item &&
-                     summaryview->folder_item->folder->type == F_NEWS
-                     ? g_basename(summaryview->folder_item->path)
-                     : summaryview->folder_item->path);
+       if (summaryview->folder_item->folder->type == F_NEWS &&
+           prefs_common.ng_abbrev_len < strlen(summaryview->folder_item->path)) {
+               gchar *group;
+               group = get_abbrev_newsgroup_name
+                       (g_basename(summaryview->folder_item->path));
+               gtk_label_set(GTK_LABEL(summaryview->statlabel_folder), group);
+               g_free(group);
+       } else {
+               gtk_label_set(GTK_LABEL(summaryview->statlabel_folder),
+                             summaryview->folder_item->path);
+       }
 
        if (summaryview->deleted)
                del = g_strdup_printf(_("%d deleted"), summaryview->deleted);
@@ -1747,8 +1711,7 @@ static void summary_status_show(SummaryView *summaryview)
        g_free(cp);
        g_free(itstr);
 
-       if (summaryview->folder_item &&
-           FOLDER_IS_LOCAL(summaryview->folder_item->folder)) {
+       if (FOLDER_IS_LOCAL(summaryview->folder_item->folder)) {
                str = g_strdup_printf(_("%d new, %d unread, %d total (%s)"),
                                      summaryview->newmsgs,
                                      summaryview->unread,
@@ -1762,12 +1725,6 @@ static void summary_status_show(SummaryView *summaryview)
        }
        gtk_label_set(GTK_LABEL(summaryview->statlabel_msgs), str);
        g_free(str);
-
-       folderview_update_msg_num(summaryview->folderview,
-                                 summaryview->folderview->opened,
-                                 summaryview->newmsgs,
-                                 summaryview->unread,
-                                 summaryview->messages);
 }
 
 static void summary_set_column_titles(SummaryView *summaryview)
@@ -1781,8 +1738,9 @@ static void summary_set_column_titles(SummaryView *summaryview)
        SummaryColumnType type;
        gboolean single_char;
        GtkJustification justify;
+       FolderItem *item = summaryview->folder_item;
 
-       static SummarySortType sort_by[N_SUMMARY_COLS] = {
+       static FolderSortKey sort_by[N_SUMMARY_COLS] = {
                SORT_BY_MARK,
                SORT_BY_UNREAD,
                SORT_BY_MIME,
@@ -1851,9 +1809,9 @@ static void summary_set_column_titles(SummaryView *summaryview)
                        gtk_box_pack_start(GTK_BOX(hbox), label,
                                           FALSE, FALSE, 0);
 
-               if (summaryview->sort_mode == sort_by[type]) {
+               if (item && item->sort_key == sort_by[type]) {
                        arrow = gtk_arrow_new
-                               (summaryview->sort_type == GTK_SORT_ASCENDING
+                               (item->sort_type == SORT_ASCENDING
                                 ? GTK_ARROW_DOWN : GTK_ARROW_UP,
                                 GTK_SHADOW_IN);
                        if (justify == GTK_JUSTIFY_RIGHT)
@@ -1869,16 +1827,17 @@ static void summary_set_column_titles(SummaryView *summaryview)
        }
 }
 
-void summary_sort(SummaryView *summaryview, SummarySortType type)
+void summary_sort(SummaryView *summaryview,
+                 FolderSortKey sort_key, FolderSortType sort_type)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCList *clist = GTK_CLIST(summaryview->ctree);
-       GtkCListCompareFunc cmp_func;
+       GtkCListCompareFunc cmp_func = NULL;
+       FolderItem *item = summaryview->folder_item;
 
-       if (!summaryview->folder_item)
-               return;
+       if (!item || !item->path || !item->parent || item->no_select) return;
 
-       switch (type) {
+       switch (sort_key) {
        case SORT_BY_MARK:
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_mark;
                break;
@@ -1901,7 +1860,10 @@ void summary_sort(SummaryView *summaryview, SummarySortType type)
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_from;
                break;
        case SORT_BY_SUBJECT:
-               cmp_func = (GtkCListCompareFunc)summary_cmp_by_subject;
+               if (summaryview->simplify_subject_preg)
+                       cmp_func = (GtkCListCompareFunc)summary_cmp_by_simplified_subject;
+               else
+                       cmp_func = (GtkCListCompareFunc)summary_cmp_by_subject;
                break;
        case SORT_BY_SCORE:
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_score;
@@ -1912,41 +1874,37 @@ void summary_sort(SummaryView *summaryview, SummarySortType type)
        case SORT_BY_LABEL:
                cmp_func = (GtkCListCompareFunc)summary_cmp_by_label;
                break;
+       case SORT_BY_NONE:
+               cmp_func = NULL;
+               return;
        default:
                return;
        }
 
-       debug_print(_("Sorting summary..."));
-       STATUSBAR_PUSH(summaryview->mainwin, _("Sorting summary..."));
+       item->sort_key = sort_key;
+       item->sort_type = sort_type;
 
-       main_window_cursor_wait(summaryview->mainwin);
+       summary_set_column_titles(summaryview);
+       summary_set_menu_sensitive(summaryview);
+       if(cmp_func != NULL) {
+               debug_print("Sorting summary...");
+               STATUSBAR_PUSH(summaryview->mainwin, _("Sorting summary..."));
 
-       gtk_clist_set_compare_func(clist, cmp_func);
+               main_window_cursor_wait(summaryview->mainwin);
 
-       /* toggle sort type if the same column is selected */
-       if (summaryview->sort_mode == type)
-               summaryview->sort_type =
-                       summaryview->sort_type == GTK_SORT_ASCENDING
-                       ? GTK_SORT_DESCENDING : GTK_SORT_ASCENDING;
-       else
-               summaryview->sort_type = GTK_SORT_ASCENDING;
-       gtk_clist_set_sort_type(clist, summaryview->sort_type);
-       summaryview->sort_mode = type;
+               gtk_clist_set_compare_func(clist, cmp_func);
 
-       summary_set_column_titles(summaryview);
+               gtk_clist_set_sort_type(clist, (GtkSortType)sort_type);
 
-       gtk_ctree_sort_recursive(ctree, NULL);
+               gtk_sctree_sort_recursive(ctree, NULL);
 
-       gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
-       prefs_folder_item_set_config(summaryview->folder_item,
-                                    summaryview->sort_type,
-                                    summaryview->sort_mode);
-       prefs_folder_item_save_config(summaryview->folder_item);
+               gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
 
-       debug_print(_("done.\n"));
-       STATUSBAR_POP(summaryview->mainwin);
+               main_window_cursor_normal(summaryview->mainwin);
 
-       main_window_cursor_normal(summaryview->mainwin);
+               debug_print("done.\n");
+               STATUSBAR_POP(summaryview->mainwin);
+       }
 }
 
 gboolean summary_insert_gnode_func(GtkCTree *ctree, guint depth, GNode *gnode,
@@ -1980,7 +1938,7 @@ gboolean summary_insert_gnode_func(GtkCTree *ctree, guint depth, GNode *gnode,
        GTKUT_CTREE_NODE_SET_ROW_DATA(cnode, msginfo);
        summary_set_marks_func(ctree, cnode, summaryview);
 
-       if (msgid)
+       if (msgid && msgid[0] != '\0')
                g_hash_table_insert(msgid_table, (gchar *)msgid, cnode);
 
        return TRUE;
@@ -1991,17 +1949,14 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        MsgInfo *msginfo;
-       MsgInfo *parentinfo;
-       MsgInfo *cur_msginfo;
-       GtkCTreeNode *node = NULL;
+               GtkCTreeNode *node = NULL;
        GHashTable *msgid_table;
        GHashTable *subject_table;
        GSList * cur;
-       GtkCTreeNode *cur_parent;
-
+       
        if (!mlist) return;
 
-       debug_print(_("\tSetting summary from message data..."));
+       debug_print("\tSetting summary from message data...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Setting summary from message data..."));
        gdk_flush();
@@ -2027,8 +1982,6 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
                                summaryview->folder_item->prefs->important_score;
        }
 
-       summaryview_subject_filter_init(summaryview->folder_item->prefs);
-       
        if (summaryview->folder_item->threaded) {
                GNode *root, *gnode;
 
@@ -2059,7 +2012,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
                        GTKUT_CTREE_NODE_SET_ROW_DATA(node, msginfo);
                        summary_set_marks_func(ctree, node, summaryview);
 
-                       if (msginfo->msgid)
+                       if (msginfo->msgid && msginfo->msgid[0] != '\0')
                                g_hash_table_insert(msgid_table,
                                                    msginfo->msgid, node);
 
@@ -2084,7 +2037,7 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
        if (prefs_common.use_addr_book)
                end_address_completion();
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        if (debug_mode) {
                debug_print("\tmsgid hash table size = %d\n",
@@ -2094,112 +2047,26 @@ static void summary_set_ctree_from_list(SummaryView *summaryview,
        }
 }
 
-struct wcachefp
+static gchar *summary_complete_address(const gchar *addr)
 {
-       FILE *cache_fp;
-       FILE *mark_fp;
-};
-
-gint summary_write_cache(SummaryView *summaryview)
-{
-       struct wcachefp fps;
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       gint ver = CACHE_VERSION;
-       gchar *buf;
-       gchar *cachefile, *markfile;
-       GSList * cur;
-       gint filemode = 0;
-       PrefsFolderItem *prefs;
+       gint count;
+       gchar *res, *tmp, *email_addr;
 
-       if (!summaryview->folder_item || !summaryview->folder_item->path)
-               return -1;
-
-       if (summaryview->folder_item->folder->update_mark != NULL)
-               summaryview->folder_item->folder->update_mark(summaryview->folder_item->folder, summaryview->folder_item);
-
-       cachefile = folder_item_get_cache_file(summaryview->folder_item);
-       g_return_val_if_fail(cachefile != NULL, -1);
-       if ((fps.cache_fp = fopen(cachefile, "w")) == NULL) {
-               FILE_OP_ERROR(cachefile, "fopen");
-               g_free(cachefile);
-               return -1;
-       }
-       if (change_file_mode_rw(fps.cache_fp, cachefile) < 0)
-               FILE_OP_ERROR(cachefile, "chmod");
-
-       prefs = summaryview->folder_item->prefs;
-        if (prefs && prefs->enable_folder_chmod && prefs->folder_chmod) {
-               /* for cache file */
-               filemode = prefs->folder_chmod;
-               if (filemode & S_IRGRP) filemode |= S_IWGRP;
-               if (filemode & S_IROTH) filemode |= S_IWOTH;
-#if HAVE_FCHMOD
-               fchmod(fileno(fps.cache_fp), filemode);
-#else
-               chmod(cachefile, filemode);
-#endif
-        }
-
-       g_free(cachefile);
-
-       markfile = folder_item_get_mark_file(summaryview->folder_item);
-       if ((fps.mark_fp = fopen(markfile, "w")) == NULL) {
-               FILE_OP_ERROR(markfile, "fopen");
-               fclose(fps.cache_fp);
-               g_free(markfile);
-               return -1;
-       }
-       if (change_file_mode_rw(fps.mark_fp, markfile) < 0)
-               FILE_OP_ERROR(markfile, "chmod");
-        if (prefs && prefs->enable_folder_chmod && prefs->folder_chmod) {
-#if HAVE_FCHMOD
-               fchmod(fileno(fps.mark_fp), filemode);
-#else
-               chmod(markfile, filemode);
-#endif
-        }
-
-       g_free(markfile);
+       Xstrdup_a(email_addr, addr, return NULL);
+       extract_address(email_addr);
+       g_return_val_if_fail(*email_addr, NULL);
 
-       buf = g_strdup_printf(_("Writing summary cache (%s)..."),
-                             summaryview->folder_item->path);
-       debug_print(buf);
-       STATUSBAR_PUSH(summaryview->mainwin, buf);
-       g_free(buf);
-
-       WRITE_CACHE_DATA_INT(ver, fps.cache_fp);
-       ver = MARK_VERSION;
-       WRITE_CACHE_DATA_INT(ver, fps.mark_fp);
-
-       gtk_ctree_pre_recursive(ctree, NULL, summary_write_cache_func, &fps);
-
-       for(cur = summaryview->killed_messages ; cur != NULL ;
-           cur = g_slist_next(cur)) {
-               MsgInfo *msginfo = (MsgInfo *) cur->data;
-
-               procmsg_write_cache(msginfo, fps.cache_fp);
-               procmsg_write_flags(msginfo, fps.mark_fp);
+       /*
+        * completion stuff must be already initialized
+        */
+       res = NULL;
+       if (1 < (count = complete_address(email_addr))) {
+               tmp = get_complete_address(1);
+               res = procheader_get_fromname(tmp);
+               g_free(tmp);    
        }
-
-       fclose(fps.cache_fp);
-       fclose(fps.mark_fp);
-
-       debug_print(_("done.\n"));
-       STATUSBAR_POP(summaryview->mainwin);
-
-       return 0;
-}
-
-static void summary_write_cache_func(GtkCTree *ctree, GtkCTreeNode *node,
-                                    gpointer data)
-{
-       struct wcachefp *fps = data;
-       MsgInfo *msginfo = gtk_ctree_node_get_row_data(ctree, node);
-
-       if (msginfo == NULL) return;
-
-       procmsg_write_cache(msginfo, fps->cache_fp);
-       procmsg_write_flags(msginfo, fps->mark_fp);
+       
+       return res;
 }
 
 static void summary_set_header(SummaryView *summaryview, gchar *text[],
@@ -2207,11 +2074,8 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
 {
        static gchar date_modified[80];
        static gchar *to = NULL;
-       static gchar *from_name = NULL;
-       static gchar col_number[11];
        static gchar col_score[11];
        static gchar buf[BUFFSIZE];
-       PrefsFolderItem *prefs = summaryview->folder_item->prefs;
        gint *col_pos = summaryview->col_pos;
 
        text[col_pos[S_COL_MARK]]   = NULL;
@@ -2220,12 +2084,7 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
        text[col_pos[S_COL_LOCKED]] = NULL;
        text[col_pos[S_COL_NUMBER]] = itos(msginfo->msgnum);
        text[col_pos[S_COL_SIZE]]   = to_human_readable(msginfo->size);
-
-#if 0
-       text[col_pos[S_COL_SCORE]]  = itos_buf(col_score, msginfo->threadscore);
-#else
        text[col_pos[S_COL_SCORE]]  = itos_buf(col_score, msginfo->score);
-#endif 
 
        if (msginfo->date_t) {
                procheader_date_get_localtime(date_modified,
@@ -2241,42 +2100,49 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
                _("(No From)");
        if (prefs_common.swap_from && msginfo->from && msginfo->to &&
            !MSG_IS_NEWS(msginfo->flags)) {
-               gchar *from;
+               gchar *addr = NULL;
+
+               Xstrdup_a(addr, msginfo->from, return);
+               extract_address(addr);
 
-               Xstrdup_a(from, msginfo->from, return);
-               extract_address(from);
-               if (account_find_from_address(from)) {
-                       g_free(to);
-                       to = g_strconcat("-->", msginfo->to, NULL);
-                       text[col_pos[S_COL_FROM]] = to;
+               if (prefs_common.use_addr_book) {
+                       if (account_find_from_address(addr)) {
+                               addr = summary_complete_address(msginfo->to);
+                               g_free(to);
+                               to   = g_strconcat("-->", addr == NULL ? msginfo->to : addr, NULL);
+                               text[col_pos[S_COL_FROM]] = to;
+                       }
+               } else {
+                       if (cur_account && cur_account->address && !strcmp( addr, cur_account->address)) {
+                               g_free(to);
+                               to = g_strconcat("-->", msginfo->to, NULL);
+                               text[col_pos[S_COL_FROM]] = to;
+                       }
                }
        }
 
-       if ((text[col_pos[S_COL_FROM]] != to) && prefs_common.use_addr_book &&
-           msginfo->from) {
-               gint count;
+       /*
+        * CLAWS: note that the "text[col_pos[S_COL_FROM]] != to" is really a hack, 
+        * checking whether the above block (which handles the special case of
+        * the --> in sent boxes) was executed.
+        */
+       if (text[col_pos[S_COL_FROM]] != to && prefs_common.use_addr_book && msginfo->from) {
                gchar *from;
-  
-               Xstrdup_a(from, msginfo->from, return);
-               extract_address(from);
-               if (*from) {
-                       count = complete_address(from);
-                       if (count > 1) {
-                               g_free(from_name);
-                               from = get_complete_address(1);
-                               from_name = procheader_get_fromname(from);
-                               g_free(from);
-                               text[col_pos[S_COL_FROM]] = from_name;
-                       }
-               }
+               from = summary_complete_address(msginfo->from);
+               if (from) {
+                       /*
+                        * FIXME: this text[col_pos[S_COL_FROM]] should be freed
+                        * but may have been assigned _("No From"). Should be
+                        * freed??? 
+                        */
+                       text[col_pos[S_COL_FROM]] = from;
+               }       
        }
 
-       if (prefs->enable_simplify_subject 
-           && prefs->simplify_subject_preg != NULL )
+       if (summaryview->simplify_subject_preg != NULL)
                text[col_pos[S_COL_SUBJECT]] = msginfo->subject ? 
                        string_remove_match(buf, BUFFSIZE, msginfo->subject, 
-                                       prefs->simplify_subject_preg) : 
-                       
+                                       summaryview->simplify_subject_preg) : 
                        _("(No Subject)");
        else 
                text[col_pos[S_COL_SUBJECT]] = msginfo->subject ? msginfo->subject :
@@ -2327,15 +2193,11 @@ static void summary_display_msg_full(SummaryView *summaryview,
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread--;
-       if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags) || 
-           MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_unset_perm_flags(msginfo, MSG_NEW | MSG_UNREAD);
-               summary_set_row_marks(summaryview, row);
-               gtk_clist_thaw(GTK_CLIST(ctree));
-               summary_status_show(summaryview);
-       }
+
+       procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
+       summary_set_row_marks(summaryview, row);
+       gtk_clist_thaw(GTK_CLIST(ctree));
+       summary_status_show(summaryview);
 
        flags = msginfo->flags;
 
@@ -2350,30 +2212,21 @@ static void summary_display_msg_full(SummaryView *summaryview,
                msgview = summaryview->messageview;
 
                summaryview->displayed = row;
-               if (!summaryview->msg_is_toggled_on)
-                       summary_toggle_view(summaryview);
+               if (!messageview_is_visible(msgview))
+                       main_window_toggle_message_view(summaryview->mainwin);
                messageview_show(msgview, msginfo, all_headers);
                if (msgview->type == MVIEW_TEXT ||
                    (msgview->type == MVIEW_MIME &&
-                    GTK_CLIST(msgview->mimeview->ctree)->row_list == NULL))
+                    (GTK_CLIST(msgview->mimeview->ctree)->row_list == NULL ||
+                     gtk_notebook_get_current_page
+                       (GTK_NOTEBOOK(msgview->mimeview->notebook)) == 0)))
                        gtk_widget_grab_focus(summaryview->ctree);
                GTK_EVENTS_FLUSH();
                gtkut_ctree_node_move_if_on_the_edge(ctree, row);
        }
 
-       if (MSG_IS_NEW(msginfo->flags) || MSG_IS_UNREAD(msginfo->flags) ||
-           (MSG_IS_MIME(msginfo->flags) - MSG_IS_MIME(flags) != 0)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               CHANGE_FLAGS(msginfo);
-               summary_set_row_marks(summaryview, row);
-               gtk_clist_thaw(GTK_CLIST(ctree));
-               summary_status_show(summaryview);
-       }
-
-#if 0
-       if (GTK_WIDGET_VISIBLE(summaryview->headerwin->window))
-               header_window_show(summaryview->headerwin, msginfo);
-#endif
+       summary_set_menu_sensitive(summaryview);
+       toolbar_set_sensitive(summaryview->mainwin);
 
        summary_unlock(summaryview);
 }
@@ -2381,6 +2234,7 @@ static void summary_display_msg_full(SummaryView *summaryview,
 void summary_display_msg_selected(SummaryView *summaryview,
                                  gboolean all_headers)
 {
+       if (summary_is_locked(summaryview)) return;
        summaryview->displayed = NULL;
        summary_display_msg_full(summaryview, summaryview->selected, FALSE,
                                 all_headers);
@@ -2439,101 +2293,38 @@ void summary_reedit(SummaryView *summaryview)
 void summary_step(SummaryView *summaryview, GtkScrollType type)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
+       GtkCTreeNode *node;
+
+       if (summary_is_locked(summaryview)) return;
 
        if (type == GTK_SCROLL_STEP_FORWARD) {
-               GtkCTreeNode *node;
                node = gtkut_ctree_node_next(ctree, summaryview->selected);
                if (node)
                        gtkut_ctree_expand_parent_all(ctree, node);
+               else
+                       return;
+       } else {
+               if (summaryview->selected) {
+                       node = GTK_CTREE_NODE_PREV(summaryview->selected);
+                       if (!node) return;
+               }
        }
 
+       if (messageview_is_visible(summaryview->messageview))
+               summaryview->display_msg = TRUE;
+
        gtk_signal_emit_by_name(GTK_OBJECT(ctree), "scroll_vertical",
                                type, 0.0);
-
-       if (summaryview->msg_is_toggled_on)
-               summary_display_msg(summaryview, summaryview->selected);
-}
-
-static void summary_toggle_view(SummaryView *summaryview)
-{
-       MainWindow *mainwin = summaryview->mainwin;
-       GtkItemFactory *ifactory;
-       
-       if (!mainwin) return;
-       
-       ifactory = gtk_item_factory_from_widget(mainwin->menubar);
-       menu_toggle_toggle(ifactory, "/View/Expand Summary View");
 }
 
-void summary_toggle_view_real(SummaryView *summaryview)
+void summary_toggle_view(SummaryView *summaryview)
 {
-       MainWindow *mainwin = summaryview->mainwin;
-       union CompositeWin *cwin = &mainwin->win;
-       GtkWidget *vpaned = NULL;
-       GtkWidget *container = NULL;
-       GtkWidget *toggle_view_btn;
-       GtkWidget *toggle_view_arrow;
-       GtkItemFactory *ifactory = gtk_item_factory_from_widget(mainwin->menubar);
-       
-       switch (mainwin->type) {
-       case SEPARATE_NONE:
-               vpaned = cwin->sep_none.vpaned;
-               container = cwin->sep_none.hpaned;
-               break;
-       case SEPARATE_FOLDER:
-               vpaned = cwin->sep_folder.vpaned;
-               container = mainwin->vbox_body;
-               break;
-       case SEPARATE_MESSAGE:
-       case SEPARATE_BOTH:
-               return;
-       }
-
-       if (vpaned->parent != NULL) {
-               summaryview->msg_is_toggled_on = FALSE;
-               summaryview->displayed = NULL;
-               gtk_widget_ref(vpaned);
-               gtkut_container_remove(GTK_CONTAINER(container), vpaned);
-               gtk_widget_reparent(GTK_WIDGET_PTR(summaryview), container);
-               
-               gtk_widget_destroy(summaryview->toggle_view_arrow);
-               gtk_widget_destroy(summaryview->toggle_view_btn);
-               
-               toggle_view_btn = gtk_button_new();
-               gtk_box_pack_end(GTK_BOX(summaryview->hbox), toggle_view_btn, FALSE, FALSE, 0);
-               gtk_box_reorder_child(GTK_BOX(summaryview->hbox), toggle_view_btn, 0);
-               gtk_button_set_relief(GTK_BUTTON(toggle_view_btn), GTK_RELIEF_NONE);
-               toggle_view_arrow=gtk_arrow_new(GTK_ARROW_UP, GTK_SHADOW_OUT);
-               gtk_container_add(GTK_CONTAINER(toggle_view_btn), toggle_view_arrow);
-               gtk_signal_connect(GTK_OBJECT(toggle_view_btn), "clicked",
-                                       GTK_SIGNAL_FUNC(summary_toggle_view_cb), summaryview);
-               gtk_widget_show_all(toggle_view_btn);
-               menu_set_sensitive(ifactory, "/View/Expand Message View", FALSE);
-       } else {
-               summaryview->msg_is_toggled_on = TRUE;
-               gtk_widget_reparent(GTK_WIDGET_PTR(summaryview), vpaned);
-               gtk_container_add(GTK_CONTAINER(container), vpaned);
-               gtk_widget_unref(vpaned);
-               
-               gtk_widget_destroy(summaryview->toggle_view_arrow);
-               gtk_widget_destroy(summaryview->toggle_view_btn);
-               
-               toggle_view_btn = gtk_button_new();
-               gtk_box_pack_end(GTK_BOX(summaryview->hbox), toggle_view_btn, FALSE, FALSE, 0);
-               gtk_box_reorder_child(GTK_BOX(summaryview->hbox), toggle_view_btn, 0);
-               gtk_button_set_relief(GTK_BUTTON(toggle_view_btn), GTK_RELIEF_NONE);
-               toggle_view_arrow=gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_OUT);
-               gtk_container_add(GTK_CONTAINER(toggle_view_btn), toggle_view_arrow);
-               gtk_signal_connect(GTK_OBJECT(toggle_view_btn), "clicked",
-                                       GTK_SIGNAL_FUNC(summary_toggle_view_cb), summaryview);
-               gtk_widget_show_all(toggle_view_btn);
-               menu_set_sensitive(ifactory, "/View/Expand Message View", TRUE);
-       }
-
-       gtk_widget_grab_focus(summaryview->ctree);
-       
-       summaryview->toggle_view_btn = toggle_view_btn;
-       summaryview->toggle_view_arrow = toggle_view_arrow;
+       if (!messageview_is_visible(summaryview->messageview) &&
+           summaryview->selected)
+               summary_display_msg(summaryview,
+                                   summaryview->selected);
+       else
+               main_window_toggle_message_view(summaryview->mainwin);
 }
 
 static gboolean summary_search_unread_recursive(GtkCTree *ctree,
@@ -2688,9 +2479,8 @@ static void summary_set_row_marks(SummaryView *summaryview, GtkCTreeNode *row)
 
        gtk_ctree_node_set_row_style(ctree, row, style);
 
-        if (MSG_GET_COLORLABEL(flags))
-               summary_set_colorlabel_color(ctree, row,
-                                            MSG_GET_COLORLABEL_VALUE(flags));
+       if (MSG_GET_COLORLABEL(flags))
+               summary_set_colorlabel_color(ctree, row, MSG_GET_COLORLABEL_VALUE(flags));
 }
 
 void summary_set_marks_selected(SummaryView *summaryview)
@@ -2725,14 +2515,10 @@ static void summary_mark_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_set_perm_flags(msginfo, MSG_MARKED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_MARKED, 0);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %s/%d is marked\n"), msginfo->folder->path, msginfo->msgnum);
+       debug_print("Message %s/%d is marked\n", msginfo->folder->path, msginfo->msgnum);
 }
 
 static void summary_lock_row(SummaryView *summaryview, GtkCTreeNode *row)
@@ -2759,14 +2545,10 @@ static void summary_lock_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_LOCKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_set_perm_flags(msginfo, MSG_LOCKED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_LOCKED, 0);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is locked\n"), msginfo->msgnum);
+       debug_print("Message %d is locked\n", msginfo->msgnum);
 }
 
 void summary_mark(SummaryView *summaryview)
@@ -2788,20 +2570,19 @@ static void summary_mark_row_as_read(SummaryView *summaryview,
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+
+       if(!MSG_IS_NEW(msginfo->flags) && !MSG_IS_UNREAD(msginfo->flags))
+               return;
+
        if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread--;
-       if (MSG_IS_NEW(msginfo->flags) ||
-           MSG_IS_UNREAD(msginfo->flags)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_unset_perm_flags(msginfo, MSG_NEW | MSG_UNREAD);
-               CHANGE_FLAGS(msginfo);
-               summary_set_row_marks(summaryview, row);
-               debug_print(_("Message %d is marked as read\n"),
-                           msginfo->msgnum);
-       }
+
+       procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
+       summary_set_row_marks(summaryview, row);
+       debug_print("Message %d is marked as read\n",
+               msginfo->msgnum);
 }
 
 void summary_mark_as_read(SummaryView *summaryview)
@@ -2845,22 +2626,17 @@ static void summary_mark_row_as_unread(SummaryView *summaryview,
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
        if (MSG_IS_DELETED(msginfo->flags)) {
                msginfo->to_folder = NULL;
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
+               procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, 0);
                summaryview->deleted--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_REPLIED | MSG_FORWARDED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_REPLIED);
-       if (!MSG_IS_UNREAD(msginfo->flags)) {
-               MSG_SET_PERM_FLAGS(msginfo->flags, MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_set_perm_flags(msginfo, MSG_UNREAD);
+
+       if (!MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread++;
-               debug_print(_("Message %d is marked as unread\n"),
-                           msginfo->msgnum);
-       }
 
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_REPLIED | MSG_FORWARDED, 0);
+       procmsg_msginfo_set_flags(msginfo, MSG_UNREAD, 0);
+       debug_print("Message %d is marked as unread\n",
+               msginfo->msgnum);
 
        summary_set_row_marks(summaryview, row);
 }
@@ -2877,6 +2653,55 @@ void summary_mark_as_unread(SummaryView *summaryview)
        summary_status_show(summaryview);
 }
 
+static gboolean check_permission(SummaryView *summaryview, MsgInfo * msginfo)
+{
+       GList * cur;
+       gboolean found;
+
+       switch (summaryview->folder_item->folder->type) {
+
+       case F_NEWS:
+
+               /*
+                 security : checks if one the accounts correspond to
+                 the author of the post
+               */
+
+               found = FALSE;
+               for(cur = account_get_list() ; cur != NULL ; cur = cur->next) {
+                       PrefsAccount * account;
+                       gchar * from_name;
+                       
+                       account = cur->data;
+                       if (account->name && *account->name)
+                               from_name =
+                                       g_strdup_printf("%s <%s>",
+                                                       account->name,
+                                                       account->address);
+                       else
+                               from_name =
+                                       g_strdup_printf("%s",
+                                                       account->address);
+                       
+                       if (g_strcasecmp(from_name, msginfo->from) == 0) {
+                               g_free(from_name);
+                               found = TRUE;
+                               break;
+                       }
+                       g_free(from_name);
+               }
+
+               if (!found) {
+                       alertpanel_error(_("You're not the author of the article\n"));
+               }
+               
+               return found;
+
+       default:
+               return TRUE;
+       }
+}
+
 static void summary_delete_row(SummaryView *summaryview, GtkCTreeNode *row)
 {
        gboolean changed = FALSE;
@@ -2885,6 +2710,9 @@ static void summary_delete_row(SummaryView *summaryview, GtkCTreeNode *row)
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
 
+       if (!check_permission(summaryview, msginfo))
+               return;
+
        if (MSG_IS_LOCKED(msginfo->flags)) return;
 
        if (MSG_IS_DELETED(msginfo->flags)) return;
@@ -2903,19 +2731,15 @@ static void summary_delete_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_DELETED, 0);
        summaryview->deleted++;
 
        if (!prefs_common.immediate_exec && 
            summaryview->folder_item->stype != F_TRASH)
                summary_set_row_marks(summaryview, row);
 
-       debug_print(_("Message %s/%d is set to delete\n"),
+       debug_print("Message %s/%d is set to delete\n",
                    msginfo->folder->path, msginfo->msgnum);
 }
 
@@ -2927,7 +2751,10 @@ void summary_delete(SummaryView *summaryview)
        GtkCTreeNode *sel_last = NULL;
        GtkCTreeNode *node;
 
+       if (!item) return;
+#if 0
        if (!item || item->folder->type == F_NEWS) return;
+#endif
 
        if (summary_is_locked(summaryview)) return;
 
@@ -2958,8 +2785,10 @@ void summary_delete(SummaryView *summaryview)
                else if (sel_last && node == GTK_CTREE_NODE_PREV(sel_last))
                        summary_step(summaryview, GTK_SCROLL_STEP_BACKWARD);
                else
-                       summary_select_node(summaryview, node,
-                                           summaryview->msg_is_toggled_on);
+                       summary_select_node
+                               (summaryview, node,
+                                messageview_is_visible(summaryview->messageview),
+                                FALSE);
        }
 
        if (prefs_common.immediate_exec || item->stype == F_TRASH)
@@ -2975,7 +2804,7 @@ void summary_delete_duplicated(SummaryView *summaryview)
        if (summaryview->folder_item->stype == F_TRASH) return;
 
        main_window_cursor_wait(summaryview->mainwin);
-       debug_print(_("Deleting duplicated messages..."));
+       debug_print("Deleting duplicated messages...");
        STATUSBAR_PUSH(summaryview->mainwin,
                       _("Deleting duplicated messages..."));
 
@@ -2988,7 +2817,7 @@ void summary_delete_duplicated(SummaryView *summaryview)
        else
                summary_status_show(summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 }
@@ -3030,13 +2859,10 @@ static void summary_unmark_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_MOVE | MSG_COPY);
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %s/%d is unmarked\n"),
+
+       debug_print("Message %s/%d is unmarked\n",
                    msginfo->folder->path, msginfo->msgnum);
 }
 
@@ -3078,12 +2904,9 @@ static void summary_move_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                if (!prefs_common.immediate_exec)
                        msginfo->to_folder->op_count--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_COPY);
        if (!MSG_IS_MOVE(msginfo->flags)) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_MOVE);
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_MOVE);
                summaryview->moved++;
                changed = TRUE;
        }
@@ -3096,7 +2919,7 @@ static void summary_move_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                }
        }
 
-       debug_print(_("Message %d is set to move to %s\n"),
+       debug_print("Message %d is set to move to %s\n",
                    msginfo->msgnum, to_folder->path);
 }
 
@@ -3170,12 +2993,9 @@ static void summary_copy_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                if (!prefs_common.immediate_exec)
                        msginfo->to_folder->op_count--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_MOVE);
        if (!MSG_IS_COPY(msginfo->flags)) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_COPY);
                summaryview->copied++;
                changed = TRUE;
        }
@@ -3188,7 +3008,7 @@ static void summary_copy_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                }
        }
 
-       debug_print(_("Message %d is set to copy to %s\n"),
+       debug_print("Message %d is set to copy to %s\n",
                    msginfo->msgnum, to_folder->path);
 }
 
@@ -3297,7 +3117,10 @@ void summary_save_as(SummaryView *summaryview)
        }
 
        src = procmsg_get_message_file(msginfo);
-       copy_file(src, dest);
+       if (copy_file(src, dest, TRUE) < 0) {
+               alertpanel_error(_("Can't save the file `%s'."),
+                                g_basename(dest));
+       }
        g_free(src);
 }
 
@@ -3386,8 +3209,6 @@ gboolean summary_execute(SummaryView *summaryview)
        summary_update_status(summaryview);
        summary_status_show(summaryview);
 
-       summary_write_cache(summaryview);
-
        gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
 
        gtk_clist_thaw(clist);
@@ -3410,8 +3231,7 @@ static void summary_execute_move(SummaryView *summaryview)
        if (summaryview->mlist) {
                procmsg_move_messages(summaryview->mlist);
 
-               folder_item_scan_foreach(summaryview->folder_table);
-               folderview_update_item_foreach(summaryview->folder_table);
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                for (cur = summaryview->mlist; cur != NULL; cur = cur->next)
                        procmsg_msginfo_free((MsgInfo *)cur->data);
@@ -3419,6 +3239,7 @@ static void summary_execute_move(SummaryView *summaryview)
                summaryview->mlist = NULL;
        }
 
+       folderview_update_item(summaryview->folder_item, FALSE);
        g_hash_table_destroy(summaryview->folder_table);
        summaryview->folder_table = NULL;
 }
@@ -3432,6 +3253,10 @@ static void summary_execute_move_func(GtkCTree *ctree, GtkCTreeNode *node,
        msginfo = GTKUT_CTREE_NODE_GET_ROW_DATA(node);
 
        if (msginfo && MSG_IS_MOVE(msginfo->flags) && msginfo->to_folder) {
+               if (!prefs_common.immediate_exec &&
+                   msginfo->to_folder->op_count > 0)
+                       msginfo->to_folder->op_count--;
+
                g_hash_table_insert(summaryview->folder_table,
                                    msginfo->to_folder, GINT_TO_POINTER(1));
 
@@ -3460,8 +3285,8 @@ static void summary_execute_copy(SummaryView *summaryview)
        if (summaryview->mlist) {
                procmsg_copy_messages(summaryview->mlist);
 
-               folder_item_scan_foreach(summaryview->folder_table);
-               folderview_update_item_foreach(summaryview->folder_table);
+               /* folder_item_scan_foreach(summaryview->folder_table); */
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                g_slist_free(summaryview->mlist);
                summaryview->mlist = NULL;
@@ -3480,13 +3305,17 @@ static void summary_execute_copy_func(GtkCTree *ctree, GtkCTreeNode *node,
        msginfo = GTKUT_CTREE_NODE_GET_ROW_DATA(node);
 
        if (msginfo && MSG_IS_COPY(msginfo->flags) && msginfo->to_folder) {
+               if (!prefs_common.immediate_exec &&
+                   msginfo->to_folder->op_count > 0)
+                       msginfo->to_folder->op_count--;
+
                g_hash_table_insert(summaryview->folder_table,
                                    msginfo->to_folder, GINT_TO_POINTER(1));
 
                summaryview->mlist =
                        g_slist_append(summaryview->mlist, msginfo);
 
-               MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+               procmsg_msginfo_unset_flags(msginfo, 0, MSG_COPY);
                summary_set_row_marks(summaryview, node);
        }
 }
@@ -3508,10 +3337,11 @@ static void summary_execute_delete(SummaryView *summaryview)
 
        if (!summaryview->mlist) return;
 
-       if (summaryview->folder_item != trash)
-               folder_item_move_msgs_with_dest(trash, summaryview->mlist);
+       if (trash == NULL || summaryview->folder_item == trash)
+               folder_item_remove_msgs(summaryview->folder_item,
+                                       summaryview->mlist);
        else
-               folder_item_remove_msgs(trash, summaryview->mlist);
+               folder_item_move_msgs_with_dest(trash, summaryview->mlist);
 
        for (cur = summaryview->mlist; cur != NULL; cur = cur->next)
                procmsg_msginfo_free((MsgInfo *)cur->data);
@@ -3519,10 +3349,10 @@ static void summary_execute_delete(SummaryView *summaryview)
        g_slist_free(summaryview->mlist);
        summaryview->mlist = NULL;
 
-       if (summaryview->folder_item != trash) {
-               folder_item_scan(trash);
+       if ((summaryview->folder_item != trash) && (trash != NULL)) {
                folderview_update_item(trash, FALSE);
        }
+       folderview_update_item(summaryview->folder_item, FALSE);
 }
 
 static void summary_execute_delete_func(GtkCTree *ctree, GtkCTreeNode *node,
@@ -3558,7 +3388,7 @@ void summary_thread_build(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Building threads..."));
+       debug_print("Building threads...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Building threads..."));
        main_window_cursor_wait(summaryview->mainwin);
 
@@ -3612,7 +3442,7 @@ void summary_thread_build(SummaryView *summaryview)
        gtk_signal_handler_unblock_by_func(GTK_OBJECT(ctree),
                                           summary_tree_expanded, summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
@@ -3652,10 +3482,10 @@ void summary_unthread(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Unthreading..."));
+       debug_print("Unthreading...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Unthreading..."));
        main_window_cursor_wait(summaryview->mainwin);
-
+       
        gtk_signal_handler_block_by_func(GTK_OBJECT(ctree),
                                         summary_tree_collapsed, summaryview);
        gtk_clist_freeze(GTK_CLIST(ctree));
@@ -3672,11 +3502,14 @@ void summary_unthread(SummaryView *summaryview)
                }
        }
 
+       /* CLAWS: and sort it */
+       gtk_sctree_sort_recursive(ctree, NULL); 
+
        gtk_clist_thaw(GTK_CLIST(ctree));
        gtk_signal_handler_unblock_by_func(GTK_OBJECT(ctree),
                                           summary_tree_collapsed, summaryview);
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
@@ -3690,7 +3523,7 @@ static void summary_unthread_for_exec(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("Unthreading for execution..."));
+       debug_print("Unthreading for execution...");
 
        gtk_clist_freeze(GTK_CLIST(ctree));
 
@@ -3701,7 +3534,7 @@ static void summary_unthread_for_exec(SummaryView *summaryview)
 
        gtk_clist_thaw(GTK_CLIST(ctree));
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
 
        summary_unlock(summaryview);
 }
@@ -3738,60 +3571,40 @@ static void summary_unthread_for_exec_func(GtkCTree *ctree, GtkCTreeNode *node,
        }
 }
 
-void summary_processing(SummaryView *summaryview, GSList * mlist)
+void summary_expand_threads(SummaryView *summaryview)
 {
-       GSList * processing_list;
-       FolderItem * folder_item;
-       GSList * cur;
-       gchar * id;
-       gchar * buf;
-
-       folder_item = summaryview->folder_item;
-       if (folder_item == NULL)
-               return;
+       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
+       GtkCTreeNode *node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
 
-       processing_list = folder_item->prefs->processing;
+       gtk_clist_freeze(GTK_CLIST(ctree));
 
-       if (processing_list == NULL)
-               return;
+       while (node) {
+               if (GTK_CTREE_ROW(node)->children)
+                       gtk_ctree_expand(ctree, node);
+               node = GTK_CTREE_NODE_NEXT(node);
+       }
 
-       summary_lock(summaryview);
-       
-       buf = g_strdup_printf(_("Processing (%s)..."), folder_item->path);
-       debug_print(buf);
-       STATUSBAR_PUSH(summaryview->mainwin, buf);
-       g_free(buf);
+       gtk_clist_thaw(GTK_CLIST(ctree));
 
-       main_window_cursor_wait(summaryview->mainwin);
+       gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
+}
 
-       summaryview->folder_table = g_hash_table_new(NULL, NULL);
+void summary_collapse_threads(SummaryView *summaryview)
+{
+       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
+       GtkCTreeNode *node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
 
-       for(cur = mlist ; cur != NULL ; cur = cur->next) {
-               MsgInfo * msginfo;
+       gtk_clist_freeze(GTK_CLIST(ctree));
 
-               msginfo = (MsgInfo *) cur->data;
-               filter_msginfo_move_or_delete(processing_list, msginfo,
-                                             summaryview->folder_table);
+       while (node) {
+               if (GTK_CTREE_ROW(node)->children)
+                       gtk_ctree_collapse(ctree, node);
+               node = GTK_CTREE_ROW(node)->sibling;
        }
-       
-       folder_item_scan_foreach(summaryview->folder_table);
-       folderview_update_item_foreach(summaryview->folder_table);
-       
-       g_hash_table_destroy(summaryview->folder_table);
-       summaryview->folder_table = NULL;
-       
-       if (prefs_common.immediate_exec) {
-               summary_unlock(summaryview);
-               summary_execute(summaryview);
-               summary_lock(summaryview);
-       } else
-               summary_status_show(summaryview);
 
-       debug_print(_("done.\n"));
-       STATUSBAR_POP(summaryview->mainwin);
-       main_window_cursor_normal(summaryview->mainwin);
+       gtk_clist_thaw(GTK_CLIST(ctree));
 
-       summary_unlock(summaryview);
+       gtk_ctree_node_moveto(ctree, summaryview->selected, -1, 0.5, 0);
 }
 
 void summary_filter(SummaryView *summaryview)
@@ -3803,7 +3616,7 @@ void summary_filter(SummaryView *summaryview)
 
        summary_lock(summaryview);
 
-       debug_print(_("filtering..."));
+       debug_print("filtering...");
        STATUSBAR_PUSH(summaryview->mainwin, _("Filtering..."));
        main_window_cursor_wait(summaryview->mainwin);
 
@@ -3832,14 +3645,14 @@ void summary_filter(SummaryView *summaryview)
 
                gtk_clist_thaw(GTK_CLIST(summaryview->ctree));
 
-               folder_item_scan_foreach(summaryview->folder_table);
-               folderview_update_item_foreach(summaryview->folder_table);
+               /* folder_item_scan_foreach(summaryview->folder_table); */
+               folderview_update_item_foreach(summaryview->folder_table, FALSE);
 
                g_hash_table_destroy(summaryview->folder_table);
                summaryview->folder_table = NULL;
        }
 
-       debug_print(_("done.\n"));
+       debug_print("done.\n");
        STATUSBAR_POP(summaryview->mainwin);
        main_window_cursor_normal(summaryview->mainwin);
 
@@ -3850,13 +3663,7 @@ void summary_filter(SummaryView *summaryview)
         * we want the lock to be context aware...  
         */
        if (global_processing) {
-               /*
-                * CLAWS: to prevent summary_show to write the cache,
-                * we force an update of the summaryview in a special way,
-                * like inc.c::inc_finished().
-                */
-               folderview_unselect(summaryview->folderview);
-               folderview_select(summaryview->folderview, summaryview->folder_item);
+               summary_show(summaryview, summaryview->folder_item);
        }               
 }
 
@@ -3877,31 +3684,48 @@ static void summary_filter_func(GtkCTree *ctree, GtkCTreeNode *node,
                if (dest && strcmp2(dest->path, FILTER_NOT_RECEIVE) != 0 &&
                    summaryview->folder_item != dest)
                        summary_move_row_to(summaryview, node, dest);
-       }
-       else 
-               filter_msginfo_move_or_delete(global_processing, msginfo,
-                                             summaryview->folder_table);
+       } else 
+               filter_message_by_msginfo(global_processing, msginfo, summaryview->folder_table);
 }
 
 void summary_filter_open(SummaryView *summaryview, PrefsFilterType type)
 {
-       static HeaderEntry hentry[] = {{"List-Id:",        NULL, FALSE},
+       static HeaderEntry hentry[] = {{"X-BeenThere:",    NULL, FALSE},
                                       {"X-ML-Name:",      NULL, FALSE},
                                       {"X-List:",         NULL, FALSE},
                                       {"X-Mailing-list:", NULL, FALSE},
+                                      {"List-Id:",        NULL, FALSE},
                                       {NULL,              NULL, FALSE}};
+
+       static gchar *header_strs[] = {"From", "from", "To", "to", "Subject", "subject"};
+
+       static gchar *hentry_strs[]   = {"X-BeenThere", "X-ML-Name", "X-List",
+                                        "X-Mailing-List", "List-Id",
+                                        "header \"X-BeenThere\"", "header \"X-ML-Name\"",
+                                        "header \"X-List\"", "header \"X-Mailing-List\"",
+                                        "header \"List-Id\""};
        enum
        {
-               H_LIST_ID        = 0,
+               H_X_BEENTHERE    = 0,
                H_X_ML_NAME      = 1,
                H_X_LIST         = 2,
-               H_X_MAILING_LIST = 3
+               H_X_MAILING_LIST = 3,
+               H_LIST_ID        = 4
+       };
+
+       enum
+       {
+               H_FROM    = 0,
+               H_TO      = 2,
+               H_SUBJECT = 4
        };
 
        MsgInfo *msginfo;
        gchar *header = NULL;
        gchar *key = NULL;
        FILE *fp;
+       int header_offset;
+       int hentry_offset;
 
        if (!summaryview->selected) return;
 
@@ -3909,6 +3733,15 @@ void summary_filter_open(SummaryView *summaryview, PrefsFilterType type)
                                              summaryview->selected);
        if (!msginfo) return;
 
+       if (global_processing) {
+               header_offset = 1;
+               hentry_offset = 5;
+       }
+       else {
+               header_offset = 0;
+               hentry_offset = 0;
+       }
+
        switch (type) {
        case FILTER_BY_NONE:
                break;
@@ -3917,117 +3750,135 @@ void summary_filter_open(SummaryView *summaryview, PrefsFilterType type)
                procheader_get_header_fields(fp, hentry);
                fclose(fp);
 
-               if (hentry[H_LIST_ID].body != NULL) {
-                       header = "List-Id";
-                       Xstrdup_a(key, hentry[H_LIST_ID].body, );
+               if (hentry[H_X_BEENTHERE].body != NULL) {
+                       header = hentry_strs[H_X_BEENTHERE + hentry_offset];
+                       Xstrdup_a(key, hentry[H_X_BEENTHERE].body, );
                } else if (hentry[H_X_ML_NAME].body != NULL) {
-                       header = "X-ML-Name";
+                       header = hentry_strs[H_X_ML_NAME + hentry_offset];
                        Xstrdup_a(key, hentry[H_X_ML_NAME].body, );
                } else if (hentry[H_X_LIST].body != NULL) {
-                       header = "X-List";
+                       header = hentry_strs[H_X_LIST + hentry_offset];
                        Xstrdup_a(key, hentry[H_X_LIST].body, );
                } else if (hentry[H_X_MAILING_LIST].body != NULL) {
-                       header = "X-Mailing-list";
+                       header = hentry_strs[H_X_MAILING_LIST + hentry_offset];
                        Xstrdup_a(key, hentry[H_X_MAILING_LIST].body, );
+               } else if (hentry[H_LIST_ID].body != NULL) {
+                       header = hentry_strs[H_LIST_ID + hentry_offset];
+                       Xstrdup_a(key, hentry[H_LIST_ID].body, );
                } else if (msginfo->subject) {
-                       header = "Subject";
+                       header = header_strs[H_SUBJECT + header_offset];
                        key = msginfo->subject;
                }
 
-               g_free(hentry[H_LIST_ID].body);
-               hentry[H_LIST_ID].body = NULL;
+               g_free(hentry[H_X_BEENTHERE].body);
+               hentry[H_X_BEENTHERE].body = NULL;
                g_free(hentry[H_X_ML_NAME].body);
                hentry[H_X_ML_NAME].body = NULL;
                g_free(hentry[H_X_LIST].body);
                hentry[H_X_LIST].body = NULL;
                g_free(hentry[H_X_MAILING_LIST].body);
                hentry[H_X_MAILING_LIST].body = NULL;
+               g_free(hentry[H_LIST_ID].body);
+               hentry[H_LIST_ID].body = NULL;
 
                break;
        case FILTER_BY_FROM:
-               header = "From";
+               header = header_strs[H_FROM + header_offset];
                key = msginfo->from;
                break;
        case FILTER_BY_TO:
-               header = "To";
+               header = header_strs[H_TO + header_offset];
                key = msginfo->to;
                break;
        case FILTER_BY_SUBJECT:
-               header = "Subject";
+               header = header_strs[H_SUBJECT + header_offset];
                key = msginfo->subject;
                break;
        default:
                break;
        }
 
-       prefs_filter_open(header, key);
+       /*
+        * NOTE: key may be allocated on the stack, so 
+        * prefs_filter[ing]_open() should have completed 
+        * and have set entries. Otherwise we're hosed.  
+        */
+
+       if (global_processing)
+               prefs_filtering_open(NULL, header, key);
+       else
+               prefs_filter_open(header, key);
 }
 
 void summary_reply(SummaryView *summaryview, ComposeMode mode)
 {
-       GtkWidget *widget;
+       GList *sel = GTK_CLIST(summaryview->ctree)->selection;
        MsgInfo *msginfo;
-       GList  *sel = GTK_CLIST(summaryview->ctree)->selection;
-       gchar *seltext = NULL;
+       gchar *text;
 
        msginfo = gtk_ctree_node_get_row_data(GTK_CTREE(summaryview->ctree),
                                              summaryview->selected);
        if (!msginfo) return;
 
-       if (summaryview && summaryview->messageview  &&
-           summaryview->messageview->textview       &&
-           summaryview->messageview->textview->text)
-               seltext = gtkut_get_selection(
-                               summaryview->messageview->textview->text);
+       text = gtkut_editable_get_selection
+               (GTK_EDITABLE(summaryview->messageview->textview->text));
 
+       if (!text && summaryview->messageview->type == MVIEW_MIME
+           && summaryview->messageview->mimeview->type == MIMEVIEW_TEXT
+           && summaryview->messageview->mimeview->textview
+           && !summaryview->messageview->mimeview->textview->default_text) {
+               text = gtkut_editable_get_selection (GTK_EDITABLE 
+                        (summaryview->messageview->mimeview->textview->text));   
+       }
+       
        switch (mode) {
        case COMPOSE_REPLY:
                compose_reply(msginfo, prefs_common.reply_with_quote,
-                             FALSE, FALSE, seltext);
+                             FALSE, FALSE, text);
                break;
        case COMPOSE_REPLY_WITH_QUOTE:
-               compose_reply(msginfo, TRUE, FALSE, FALSE, seltext);
+               compose_reply(msginfo, TRUE, FALSE, FALSE, text);
                break;
        case COMPOSE_REPLY_WITHOUT_QUOTE:
-               compose_reply(msginfo, FALSE, FALSE, FALSE, seltext);
+               compose_reply(msginfo, FALSE, FALSE, FALSE, NULL);
                break;
        case COMPOSE_REPLY_TO_SENDER:
                compose_reply(msginfo, prefs_common.reply_with_quote,
-                             FALSE, TRUE, seltext);
+                             FALSE, TRUE, text);
                break;
        case COMPOSE_FOLLOWUP_AND_REPLY_TO:
                compose_followup_and_reply_to(msginfo,
                                              prefs_common.reply_with_quote,
-                                             FALSE, TRUE, seltext);
+                                             FALSE, TRUE, text);
                break;
        case COMPOSE_REPLY_TO_SENDER_WITH_QUOTE:
-               compose_reply(msginfo, TRUE, FALSE, TRUE, seltext);
+               compose_reply(msginfo, TRUE, FALSE, TRUE, text);
                break;
        case COMPOSE_REPLY_TO_SENDER_WITHOUT_QUOTE:
-               compose_reply(msginfo, FALSE, FALSE, TRUE, seltext);
+               compose_reply(msginfo, FALSE, FALSE, TRUE, NULL);
                break;
        case COMPOSE_REPLY_TO_ALL:
                compose_reply(msginfo, prefs_common.reply_with_quote,
-                             TRUE, TRUE, seltext);
+                             TRUE, FALSE, text);
                break;
        case COMPOSE_REPLY_TO_ALL_WITH_QUOTE:
-               compose_reply(msginfo, TRUE, TRUE, TRUE, seltext);
+               compose_reply(msginfo, TRUE, TRUE, FALSE, text);
                break;
        case COMPOSE_REPLY_TO_ALL_WITHOUT_QUOTE:
-               compose_reply(msginfo, FALSE, TRUE, TRUE, seltext);
+               compose_reply(msginfo, FALSE, TRUE, FALSE, NULL);
                break;
        case COMPOSE_FORWARD:
                if (prefs_common.forward_as_attachment) {
-                       summary_reply_cb(summaryview, COMPOSE_FORWARD_AS_ATTACH, widget);
+                       summary_reply_cb(summaryview, COMPOSE_FORWARD_AS_ATTACH, NULL);
                        return;
                } else {
-                       summary_reply_cb(summaryview, COMPOSE_FORWARD_INLINE, widget);
+                       summary_reply_cb(summaryview, COMPOSE_FORWARD_INLINE, NULL);
                        return;
                }
                break;
        case COMPOSE_FORWARD_INLINE:
                if (!sel->next) {
-                       compose_forward(NULL, msginfo, FALSE, seltext);
+                       compose_forward(NULL, msginfo, FALSE, text);
                        break;
                }
                /* if (sel->next) FALL THROUGH */
@@ -4042,17 +3893,15 @@ void summary_reply(SummaryView *summaryview, ComposeMode mode)
                        g_slist_free(msginfo_list);
                }                       
                break;
-       case COMPOSE_BOUNCE:
-               compose_bounce(NULL, msginfo);
+       case COMPOSE_REDIRECT:
+               compose_redirect(NULL, msginfo);
                break;
        default:
                g_warning("summary_reply_cb(): invalid action: %d\n", mode);
        }
 
        summary_set_marks_selected(summaryview);
-
-       if (seltext)
-               g_free((gchar *) seltext);
+       g_free(text);
 }
 
 /* color label */
@@ -4087,8 +3936,8 @@ void summary_set_colorlabel_color(GtkCTree *ctree, GtkCTreeNode *node,
        gint color_index;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, node);
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_CLABEL_FLAG_MASK);
-       MSG_SET_COLORLABEL_VALUE(msginfo->flags, labelcolor);
+       procmsg_msginfo_unset_flags(msginfo, MSG_CLABEL_FLAG_MASK, 0);
+       procmsg_msginfo_set_flags(msginfo, MSG_COLORLABEL_TO_FLAGS(labelcolor), 0);
 
        color_index = labelcolor == 0 ? -1 : (gint)labelcolor - 1;
        ctree_style = gtk_widget_get_style(GTK_WIDGET(ctree));
@@ -4377,13 +4226,8 @@ void summary_set_column_order(SummaryView *summaryview)
        guint selected_msgnum = summary_get_msgnum(summaryview, summaryview->selected);
        guint displayed_msgnum = summary_get_msgnum(summaryview, summaryview->displayed);
 
-       
        item = summaryview->folder_item;
 
-       summary_lock(summaryview);
-       summary_write_cache(summaryview);
-       summary_unlock(summaryview);
-       
        summary_clear_all(summaryview);
        gtk_widget_destroy(summaryview->ctree);
 
@@ -4399,7 +4243,7 @@ void summary_set_column_order(SummaryView *summaryview)
        gtk_container_add(GTK_CONTAINER(scrolledwin), ctree);
        gtk_widget_show(ctree);
 
-       summary_show(summaryview, item, FALSE);
+       summary_show(summaryview, item);
 
        summary_select_by_msgnum(summaryview, selected_msgnum);
        summaryview->displayed = summary_find_msg_by_msgnum(summaryview, displayed_msgnum);
@@ -4412,15 +4256,12 @@ void summary_set_column_order(SummaryView *summaryview)
 
 /* callback functions */
 
-static void summary_toggle_view_cb(GtkWidget *button,
-                                  gpointer data)
+static void summary_toggle_pressed(GtkWidget *eventbox, GdkEventButton *event,
+                                  SummaryView *summaryview)
 {
-       SummaryView *summaryview = (SummaryView *) data;
-       
-       if (!summaryview->msg_is_toggled_on && summaryview->selected)
-               summary_display_msg(summaryview, summaryview->selected);
-       else
-               summary_toggle_view(summaryview);
+       if (!event) return;
+
+       summary_toggle_view(summaryview);
 }
 
 static void summary_button_pressed(GtkWidget *ctree, GdkEventButton *event,
@@ -4436,7 +4277,7 @@ static void summary_button_pressed(GtkWidget *ctree, GdkEventButton *event,
                summaryview->display_msg = TRUE;
        } else if (event->button == 1) {
                if (!prefs_common.emulate_emacs &&
-                   summaryview->msg_is_toggled_on)
+                   messageview_is_visible(summaryview->messageview))
                        summaryview->display_msg = TRUE;
        }
 }
@@ -4506,6 +4347,12 @@ static void summary_key_pressed(GtkWidget *widget, GdkEventKey *event,
                textview_scroll_one_line(summaryview->messageview->textview,
                                         (event->state & GDK_MOD1_MASK) != 0);
                break;
+       case GDK_asterisk:      /* Mark */
+               summary_mark(summaryview);
+               break;
+       case GDK_exclam:        /* Mark as unread */
+               summary_mark_as_unread(summaryview);
+               break;
        case GDK_Delete:
                RETURN_IF_LOCKED();
                BREAK_ON_MODIFIER_KEY();
@@ -4546,12 +4393,12 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
        MsgInfo *msginfo;
 
        summary_status_show(summaryview);
-       summary_set_menu_sensitive(summaryview);
-       main_window_set_toolbar_sensitive(summaryview->mainwin);
 
        if (GTK_CLIST(ctree)->selection &&
             GTK_CLIST(ctree)->selection->next) {
                summaryview->display_msg = FALSE;
+               summary_set_menu_sensitive(summaryview);
+               toolbar_set_sensitive(summaryview->mainwin);
                return;
        }
 
@@ -4562,10 +4409,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
        switch (column < 0 ? column : summaryview->col_state[column].type) {
        case S_COL_MARK:
                if (MSG_IS_MARKED(msginfo->flags)) {
-                       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-                       if (MSG_IS_IMAP(msginfo->flags))
-                               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-                       CHANGE_FLAGS(msginfo);
+                       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED, 0);
                        summary_set_row_marks(summaryview, row);
                } else
                        summary_mark_row(summaryview, row);
@@ -4582,8 +4426,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
                break;
        case S_COL_LOCKED:
                if (MSG_IS_LOCKED(msginfo->flags)) {
-                       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_LOCKED);
-                       CHANGE_FLAGS(msginfo);
+                       procmsg_msginfo_unset_flags(msginfo, MSG_LOCKED, 0);
                        summary_set_row_marks(summaryview, row);
                }
                else
@@ -4593,10 +4436,15 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
                break;
        }
 
-       if (summaryview->display_msg)
+       if (summaryview->display_msg ||
+           (prefs_common.show_msg_with_cursor_key &&
+            messageview_is_visible(summaryview->messageview))) {
                summary_display_msg(summaryview, row);
-
-       summaryview->display_msg = FALSE;
+               summaryview->display_msg = FALSE;
+       } else {
+               summary_set_menu_sensitive(summaryview);
+               toolbar_set_sensitive(summaryview->mainwin);
+       }
 }
 
 static void summary_col_resized(GtkCList *clist, gint column, gint width,
@@ -4622,7 +4470,8 @@ static void summary_execute_cb(SummaryView *summaryview, guint action,
 static void summary_show_all_header_cb(SummaryView *summaryview,
                                       guint action, GtkWidget *widget)
 {
-       summary_display_msg_selected(summaryview, TRUE);
+       summary_display_msg_selected(summaryview,
+                                    GTK_CHECK_MENU_ITEM(widget)->active);
 }
 
 static void summary_add_address_cb(SummaryView *summaryview,
@@ -4631,57 +4480,78 @@ static void summary_add_address_cb(SummaryView *summaryview,
        summary_add_address(summaryview);
 }
 
-static void summary_mark_clicked(GtkWidget *button, SummaryView *summaryview)
+static void summary_create_filter_cb(SummaryView *summaryview,
+                                    guint action, GtkWidget *widget)
 {
-       summary_sort(summaryview, SORT_BY_MARK);
+       summary_filter_open(summaryview, (PrefsFilterType)action);
 }
 
-static void summary_unread_clicked(GtkWidget *button, SummaryView *summaryview)
+static void summary_sort_by_column_click(SummaryView *summaryview,
+                                        FolderSortKey sort_key)
 {
-       summary_sort(summaryview, SORT_BY_UNREAD);
+       FolderItem *item = summaryview->folder_item;
+
+       if (!item) return;
+
+       if (item->sort_key == sort_key)
+               summary_sort(summaryview, sort_key,
+                            item->sort_type == SORT_ASCENDING
+                            ? SORT_DESCENDING : SORT_ASCENDING);
+       else
+               summary_sort(summaryview, sort_key, SORT_ASCENDING);
 }
 
-static void summary_mime_clicked(GtkWidget *button, SummaryView *summaryview)
+static void summary_mark_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_MIME);
+       summary_sort_by_column_click(summaryview, SORT_BY_MARK);
 }
 
-static void summary_num_clicked(GtkWidget *button, SummaryView *summaryview)
+static void summary_unread_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_NUMBER);
+       summary_sort_by_column_click(summaryview, SORT_BY_UNREAD);
 }
 
-static void summary_score_clicked(GtkWidget *button,
-                                 SummaryView *summaryview)
+static void summary_mime_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_SCORE);
+       summary_sort_by_column_click(summaryview, SORT_BY_MIME);
 }
 
-static void summary_locked_clicked(GtkWidget *button,
-                                 SummaryView *summaryview)
+static void summary_num_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_LOCKED);
+       summary_sort_by_column_click(summaryview, SORT_BY_NUMBER);
 }
 
 static void summary_size_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_SIZE);
+       summary_sort_by_column_click(summaryview, SORT_BY_SIZE);
 }
 
 static void summary_date_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_DATE);
+       summary_sort_by_column_click(summaryview, SORT_BY_DATE);
 }
 
 static void summary_from_clicked(GtkWidget *button, SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_FROM);
+       summary_sort_by_column_click(summaryview, SORT_BY_FROM);
 }
 
 static void summary_subject_clicked(GtkWidget *button,
                                    SummaryView *summaryview)
 {
-       summary_sort(summaryview, SORT_BY_SUBJECT);
+       summary_sort_by_column_click(summaryview, SORT_BY_SUBJECT);
+}
+
+static void summary_score_clicked(GtkWidget *button,
+                                 SummaryView *summaryview)
+{
+       summary_sort_by_column_click(summaryview, SORT_BY_SCORE);
+}
+
+static void summary_locked_clicked(GtkWidget *button,
+                                  SummaryView *summaryview)
+{
+       summary_sort_by_column_click(summaryview, SORT_BY_LOCKED);
 }
 
 static void summary_start_drag(GtkWidget *widget, gint button, GdkEvent *event,
@@ -4833,6 +4703,38 @@ static gint summary_cmp_by_subject(GtkCList *clist,
        return strcasecmp(msginfo1->subject, msginfo2->subject);
 }
 
+static gint summary_cmp_by_simplified_subject
+       (GtkCList *clist, gconstpointer ptr1, gconstpointer ptr2)
+{
+       const PrefsFolderItem *prefs;
+       const gchar *str1, *str2;
+       const GtkCListRow *r1 = (const GtkCListRow *) ptr1;
+       const GtkCListRow *r2 = (const GtkCListRow *) ptr2;
+       const MsgInfo *msginfo1 = r1->data;
+       const MsgInfo *msginfo2 = r2->data;
+       const SummaryView *sv = gtk_object_get_data(GTK_OBJECT(clist), "summaryview");
+       
+       g_return_val_if_fail(sv, -1);
+       g_return_val_if_fail(msginfo1 != NULL && msginfo2 != NULL, -1);
+       
+       str1 = GTK_CELL_TEXT(r1->cell[sv->col_pos[S_COL_SUBJECT]])->text;
+       str2 = GTK_CELL_TEXT(r2->cell[sv->col_pos[S_COL_SUBJECT]])->text;
+
+       if (!str1)
+               return str2 != NULL;
+
+       if (!str2)
+               return -1;
+
+       prefs = msginfo1->folder->prefs;
+       if (!prefs)
+               prefs = msginfo2->folder->prefs;
+       if (!prefs)
+               return -1;
+       
+       return strcasecmp(str1, str2);
+}
+
 static gint summary_cmp_by_label(GtkCList *clist,
                                 gconstpointer ptr1, gconstpointer ptr2)
 {
@@ -4842,6 +4744,33 @@ static gint summary_cmp_by_label(GtkCList *clist,
        return MSG_GET_COLORLABEL(msginfo1->flags) -
                MSG_GET_COLORLABEL(msginfo2->flags);
 }
+
+static void news_flag_crosspost(MsgInfo *msginfo)
+{
+       GString *line;
+       gpointer key;
+       gpointer value;
+       Folder *mff = msginfo->folder->folder;
+
+       if (mff->account->mark_crosspost_read && MSG_IS_NEWS(msginfo->flags)) {
+               line = g_string_sized_new(128);
+               g_string_sprintf(line, "%s:%d", msginfo->folder->path, msginfo->msgnum);
+               debug_print("nfcp: checking <%s>", line->str);
+               if (mff->newsart && 
+                   g_hash_table_lookup_extended(mff->newsart, line->str, &key, &value)) {
+                       debug_print(" <%s>", (gchar *)value);
+                       if (MSG_IS_NEW(msginfo->flags) || MSG_IS_UNREAD(msginfo->flags)) {
+                               procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
+                               procmsg_msginfo_set_flags(msginfo, mff->account->crosspost_col, 0);
+                       }
+                       g_hash_table_remove(mff->newsart, key);
+                       g_free(key);
+               }
+               g_string_free(line, TRUE);
+               debug_print("\n");
+       }
+}
+
 static gint summary_cmp_by_score(GtkCList *clist,
                                 gconstpointer ptr1, gconstpointer ptr2)
 {
@@ -4867,22 +4796,51 @@ static gint summary_cmp_by_locked(GtkCList *clist,
        return MSG_IS_LOCKED(msginfo1->flags) - MSG_IS_LOCKED(msginfo2->flags);
 }
 
+static void summary_select_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpointer data)
+{
+       MsgInfo *msginfo;
+
+       msginfo = gtk_ctree_node_get_row_data(ctree, row);
+       gtk_ctree_select(GTK_CTREE(ctree), row);        
+       debug_print("Message %d selected\n", msginfo->msgnum);
+}
+
+/* select current thread */
+void summary_select_thread(SummaryView *summaryview)
+{
+       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
+       GtkCTreeNode *node = summaryview->selected;
+       GList *cur;
+
+       while (GTK_CTREE_ROW(node)->parent != NULL)
+               node = GTK_CTREE_ROW(node)->parent;
+
+       if (node && node != summaryview->selected)
+               summary_select_node(summaryview, node, TRUE, FALSE);
+
+       for (cur = GTK_CLIST(ctree)->selection; cur != NULL; cur = cur->next) {
+               gtk_ctree_pre_recursive(ctree, GTK_CTREE_NODE(cur->data), GTK_CTREE_FUNC(summary_select_thread_func), summaryview);
+       }
+       
+       summary_status_show(summaryview);
+}
+
 static void summary_ignore_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpointer data)
 {
        SummaryView *summaryview = (SummaryView *) data;
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+
        if (MSG_IS_NEW(msginfo->flags))
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags))
                summaryview->unread--;
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_IGNORE_THREAD);
 
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_set_flags(msginfo, MSG_IGNORE_THREAD, 0);
 
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is marked as ignore thread\n"),
+       debug_print("Message %d is marked as ignore thread\n",
            msginfo->msgnum);
 }
 
@@ -4904,16 +4862,16 @@ static void summary_unignore_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpo
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+
        if (MSG_IS_NEW(msginfo->flags))
                summaryview->newmsgs++;
        if (MSG_IS_UNREAD(msginfo->flags))
                summaryview->unread++;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_IGNORE_THREAD);
 
-       CHANGE_FLAGS(msginfo);
-               
+       procmsg_msginfo_unset_flags(msginfo, MSG_IGNORE_THREAD, 0);
+
        summary_set_row_marks(summaryview, row);
-       debug_print(_("Message %d is marked as unignore thread\n"),
+       debug_print("Message %d is marked as unignore thread\n",
            msginfo->msgnum);
 }
 
@@ -4929,7 +4887,7 @@ static void summary_unignore_thread(SummaryView *summaryview)
        summary_status_show(summaryview);
 }
 
-
+#if 0 /* OLD PROCESSING */
 static gboolean processing_apply_func(GNode *node, gpointer data)
 {
        FolderItem *item;
@@ -4945,6 +4903,7 @@ static gboolean processing_apply_func(GNode *node, gpointer data)
                return FALSE;
        processing = item->prefs->processing;
 
+
        if (processing != NULL) {
                gchar * buf;
                GSList * mlist;
@@ -4955,15 +4914,16 @@ static gboolean processing_apply_func(GNode *node, gpointer data)
                STATUSBAR_PUSH(summaryview->mainwin, buf);
                g_free(buf);
 
+/*
                mlist = item->folder->get_msg_list(item->folder, item,
                                                   TRUE);
-               
+*/             
+               mlist = folder_item_get_msg_list(item);
                for(cur = mlist ; cur != NULL ; cur = cur->next) {
                        MsgInfo * msginfo;
                        
                        msginfo = (MsgInfo *) cur->data;
-                       filter_msginfo_move_or_delete(processing, msginfo,
-                                                     NULL);
+                       filter_message_by_msginfo(processing, msginfo, NULL);
                        procmsg_msginfo_free(msginfo);
                }
 
@@ -4988,6 +4948,7 @@ void processing_apply(SummaryView * summaryview)
                                processing_apply_func, summaryview);
        }
 }
+#endif
 
 void summary_toggle_show_read_messages(SummaryView *summaryview)
 {
@@ -4995,7 +4956,7 @@ void summary_toggle_show_read_messages(SummaryView *summaryview)
                summaryview->folder_item->hide_read_msgs = 0;
        else
                summaryview->folder_item->hide_read_msgs = 1;
-       summary_show(summaryview, summaryview->folder_item, FALSE);
+       summary_show(summaryview, summaryview->folder_item);
 }
  
 static void summary_set_hide_read_msgs_menu (SummaryView *summaryview,
@@ -5011,39 +4972,91 @@ static void summary_set_hide_read_msgs_menu (SummaryView *summaryview,
        gtk_object_set_data(GTK_OBJECT(widget), "dont_toggle",
                            GINT_TO_POINTER(0));
 }
-static void summaryview_subject_filter_init(PrefsFolderItem *prefs)
+
+void summary_reflect_prefs_pixmap_theme(SummaryView *summaryview)
+{
+       GtkWidget *ctree = summaryview->ctree;
+       GtkWidget *pixmap; 
+
+       gtk_widget_destroy(summaryview->folder_pixmap);
+
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_MARK, &markxpm, &markxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_DELETED, &deletedxpm, &deletedxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_NEW, &newxpm, &newxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_UNREAD, &unreadxpm, &unreadxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_REPLIED, &repliedxpm, &repliedxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_FORWARDED, &forwardedxpm, &forwardedxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_CLIP, &clipxpm, &clipxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_LOCKED, &lockedxpm, &lockedxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_IGNORETHREAD, &ignorethreadxpm, &ignorethreadxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_CLIP_KEY, &clipkeyxpm, &clipkeyxpmmask);
+       stock_pixmap_gdk(ctree, STOCK_PIXMAP_KEY, &keyxpm, &keyxpmmask);
+
+       pixmap = stock_pixmap_widget(summaryview->hbox, STOCK_PIXMAP_DIR_OPEN);
+       gtk_box_pack_start(GTK_BOX(summaryview->hbox), pixmap, FALSE, FALSE, 4);
+       gtk_box_reorder_child(GTK_BOX(summaryview->hbox), pixmap, 0);
+       gtk_widget_show(pixmap);
+       summaryview->folder_pixmap = pixmap; 
+
+       folderview_unselect(summaryview->folderview);
+       folderview_select(summaryview->folderview, summaryview->folder_item);
+}
+
+/*
+ * Harvest addresses for selected messages in summary view.
+ */
+void summary_harvest_address(SummaryView *summaryview)
+{
+       GtkCTree *ctree = GTK_CTREE( summaryview->ctree );
+       GList *cur;
+       GList *msgList;
+       MsgInfo *msginfo;
+
+       msgList = NULL;
+       for( cur = GTK_CLIST(ctree)->selection; cur != NULL; cur = cur->next ) {
+               msginfo = gtk_ctree_node_get_row_data( ctree, GTK_CTREE_NODE(cur->data) );
+               msgList = g_list_append( msgList, GUINT_TO_POINTER( msginfo->msgnum ) );
+       }
+       addressbook_harvest( summaryview->folder_item, TRUE, msgList );
+       g_list_free( msgList );
+}
+
+static regex_t *summary_compile_simplify_regexp(gchar *simplify_subject_regexp)
 {
        int err;
        gchar buf[BUFFSIZE];
-       if (prefs->enable_simplify_subject) {
-               if (prefs->simplify_subject_regexp && 
-                               *prefs->simplify_subject_regexp != 0x00) {
+       regex_t *preg = NULL;
+       
+       preg = g_new0(regex_t, 1);
 
-                       if (!prefs->simplify_subject_preg) 
-                               prefs->simplify_subject_preg = g_new(regex_t, 1);
-                       else
-                               regfree(prefs->simplify_subject_preg);
-
-                       err = string_match_precompile(prefs->simplify_subject_regexp, 
-                                       prefs->simplify_subject_preg, REG_EXTENDED);
-                       if (err) {
-                               regerror(err, prefs->simplify_subject_preg, buf, BUFFSIZE);
-                               alertpanel_error(_("Regular expression (regexp) error:\n%s"), buf);
-                               g_free(prefs->simplify_subject_preg);
-                               prefs->simplify_subject_preg = NULL;
-                       }
-               } else {
-                       if (prefs->simplify_subject_preg) {
-                               regfree(prefs->simplify_subject_preg);
-                               g_free(prefs->simplify_subject_preg);
-                               prefs->simplify_subject_preg = NULL;
-                       }
-               }
+       err = string_match_precompile(simplify_subject_regexp, 
+                                     preg, REG_EXTENDED);
+       if (err) {
+               regerror(err, preg, buf, BUFFSIZE);
+               alertpanel_error(_("Regular expression (regexp) error:\n%s"), buf);
+               g_free(preg);
+               preg = NULL;
        }
+       
+       return preg;
 }
 
+void summary_set_prefs_from_folderitem(SummaryView *summaryview, FolderItem *item)
+{
+       g_return_if_fail(summaryview != NULL);
+       g_return_if_fail(item != NULL);
+
+       /* Subject simplification */
+       if(summaryview->simplify_subject_preg) {
+               regfree(summaryview->simplify_subject_preg);
+               g_free(summaryview->simplify_subject_preg);
+               summaryview->simplify_subject_preg = NULL;
+       }
+       if(item->prefs && item->prefs->simplify_subject_regexp && 
+          item->prefs->simplify_subject_regexp[0] && item->prefs->enable_simplify_subject)
+               summaryview->simplify_subject_preg = summary_compile_simplify_regexp(item->prefs->simplify_subject_regexp);
+}
 
 /*
  * End of Source.
  */
-