* src/summaryview.c
[claws.git] / src / summaryview.c
index bff0597fa96c128adeaf8f3fa49aae2f2a007e42..0043ce81499b597830af69594613f814e6274034 100644 (file)
@@ -160,24 +160,18 @@ static GtkCTreeNode *summary_find_prev_msg
 static GtkCTreeNode *summary_find_next_msg
                                        (SummaryView            *summaryview,
                                         GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_unread_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_unread_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_marked_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_marked_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_prev_labeled_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
-static GtkCTreeNode *summary_find_next_labeled_msg
-                                       (SummaryView            *summaryview,
-                                        GtkCTreeNode           *current_node);
+
+static GtkCTreeNode *summary_find_prev_flagged_msg
+                                       (SummaryView    *summaryview,
+                                        GtkCTreeNode   *current_node,
+                                        MsgPermFlags    flags,
+                                        gboolean        start_from_prev);
+static GtkCTreeNode *summary_find_next_flagged_msg
+                                       (SummaryView    *summaryview,
+                                        GtkCTreeNode   *current_node,
+                                        MsgPermFlags    flags,
+                                        gboolean        start_from_next);
+
 static GtkCTreeNode *summary_find_msg_by_msgnum
                                        (SummaryView            *summaryview,
                                         guint                   msgnum);
@@ -795,8 +789,15 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
 
        main_window_cursor_wait(summaryview->mainwin);
 
+/*
        mlist = item->folder->get_msg_list(item->folder, item, !update_cache);
 
+       !!! NEW !!!
+       USE LIST FROM CACHE, WILL NOT DISPLAY ANY MESSAGES DROPED
+       BY OTHER PROGRAMS TO THE FOLDER
+*/
+       mlist = folder_item_get_msg_list(item);
+
        summary_processing(summaryview, mlist);
 
        for(cur = mlist ; cur != NULL ; cur = g_slist_next(cur)) {
@@ -867,6 +868,12 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
 
        g_slist_free(mlist);
 
+       summaryview->folder_item->new    = summaryview->newmsgs;
+       summaryview->folder_item->unread = summaryview->unread;
+       summaryview->folder_item->total  = summaryview->messages;
+       folderview_update_msg_num(summaryview->folderview,
+                                 summaryview->folderview->opened);
+
        if (item->sort_key != SORT_BY_NONE)
                summary_sort(summaryview, item->sort_key, item->sort_type);
 
@@ -886,7 +893,8 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                if (!summaryview->selected) {
                        /* no selected message - select first unread
                           message, but do not display it */
-                       node = summary_find_next_unread_msg(summaryview, NULL);
+                       node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                            MSG_UNREAD, FALSE);
                        if (node == NULL && GTK_CLIST(ctree)->row_list != NULL)
                                node = gtk_ctree_node_nth
                                        (ctree,
@@ -900,8 +908,8 @@ gboolean summary_show(SummaryView *summaryview, FolderItem *item,
                        node = summary_find_next_important_score(summaryview,
                                                                 NULL);
                else
-                       node = summary_find_next_unread_msg(summaryview, NULL);
-
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_UNREAD, FALSE);
                if (node == NULL && GTK_CLIST(ctree)->row_list != NULL) {
                        node = gtk_ctree_node_nth
                                (ctree,
@@ -1079,7 +1087,7 @@ static void summary_set_menu_sensitive(SummaryView *summaryview)
        menu_set_sensitive(ifactory, "/Reply to sender",          sens);
        menu_set_sensitive(ifactory, "/Reply to all",             sens);
        menu_set_sensitive(ifactory, "/Forward",                  TRUE);
-       menu_set_sensitive(ifactory, "/Redirect",                 TRUE);
+       menu_set_sensitive(ifactory, "/Redirect",                 sens);
 
        menu_set_sensitive(ifactory, "/Add sender to address book", sens);
        menu_set_sensitive(ifactory, "/Create filter rule",         sens);
@@ -1116,7 +1124,8 @@ void summary_select_prev_unread(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_prev_unread_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_UNREAD, FALSE);
 
        if (!node) {
                AlertValue val;
@@ -1139,7 +1148,8 @@ void summary_select_prev_unread(SummaryView *summaryview)
                                        _("Internal error: unexpected value for prefs_common.next_unread_msg_dialog\n"));
                }
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_unread_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_UNREAD, FALSE);
        }
 
        if (!node)
@@ -1153,12 +1163,14 @@ void summary_select_next_unread(SummaryView *summaryview)
        GtkCTreeNode *node = summaryview->selected;
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
 
-       node = summary_find_next_unread_msg(summaryview, node);
+       node = summary_find_next_flagged_msg
+               (summaryview, node, MSG_UNREAD, FALSE);
        
        if (node)
                summary_select_node(summaryview, node, TRUE, FALSE);
        else {
-               node = summary_find_next_unread_msg(summaryview, NULL);
+               node = summary_find_next_flagged_msg
+                       (summaryview, NULL, MSG_UNREAD, FALSE);
                if (node == NULL) {
                        AlertValue val;
 
@@ -1197,11 +1209,68 @@ void summary_select_next_unread(SummaryView *summaryview)
        }
 }
 
+void summary_select_prev_new(SummaryView *summaryview)
+{
+       GtkCTreeNode *node;
+
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_NEW, FALSE);
+
+       if (!node) {
+               AlertValue val;
+
+               val = alertpanel(_("No more new messages"),
+                                _("No new message found. "
+                                  "Search from the end?"),
+                                _("Yes"), _("No"), NULL);
+               if (val != G_ALERTDEFAULT) return;
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_NEW, FALSE);
+       }
+
+       if (!node)
+               alertpanel_notice(_("No new messages."));
+       else
+               summary_select_node(summaryview, node, TRUE, FALSE);
+}
+
+void summary_select_next_new(SummaryView *summaryview)
+{
+       GtkCTreeNode *node = summaryview->selected;
+       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
+
+       while ((node = summary_find_next_flagged_msg
+               (summaryview, node, MSG_NEW, FALSE)) == NULL) {
+               AlertValue val;
+
+               val = alertpanel(_("No more new messages"),
+                                _("No new message found. "
+                                  "Go to next folder?"),
+                                _("Yes"), _("Search again"), _("No"));
+               if (val == G_ALERTDEFAULT) {
+                       if (gtk_signal_n_emissions_by_name
+                               (GTK_OBJECT(ctree), "key_press_event") > 0)
+                                       gtk_signal_emit_stop_by_name
+                                               (GTK_OBJECT(ctree),
+                                                "key_press_event");
+                       folderview_select_next_unread(summaryview->folderview);
+                       return;
+               } else if (val == G_ALERTALTERNATE)
+                       node = NULL;
+               else
+                       return;
+       }
+
+       if (node)
+               summary_select_node(summaryview, node, TRUE, FALSE);
+}
+
 void summary_select_prev_marked(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_prev_marked_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_MARKED, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1211,7 +1280,8 @@ void summary_select_prev_marked(SummaryView *summaryview)
                                   "Search from the end?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_marked_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_MARKED, TRUE);
        }
 
        if (!node)
@@ -1224,7 +1294,8 @@ void summary_select_next_marked(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_next_marked_msg(summaryview, summaryview->selected);
+       node = summary_find_next_flagged_msg
+               (summaryview, summaryview->selected, MSG_MARKED, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1234,7 +1305,8 @@ void summary_select_next_marked(SummaryView *summaryview)
                                   "Search from the beginning?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_next_marked_msg(summaryview, NULL);
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_MARKED, TRUE);
        }
 
        if (!node)
@@ -1247,7 +1319,8 @@ void summary_select_prev_labeled(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_prev_labeled_msg(summaryview, summaryview->selected);
+       node = summary_find_prev_flagged_msg
+               (summaryview, summaryview->selected, MSG_CLABEL_FLAG_MASK, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1257,7 +1330,8 @@ void summary_select_prev_labeled(SummaryView *summaryview)
                                   "Search from the end?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_prev_labeled_msg(summaryview, NULL);
+               node = summary_find_prev_flagged_msg(summaryview, NULL,
+                                                    MSG_CLABEL_FLAG_MASK, TRUE);
        }
 
        if (!node)
@@ -1270,7 +1344,8 @@ void summary_select_next_labeled(SummaryView *summaryview)
 {
        GtkCTreeNode *node;
 
-       node = summary_find_next_labeled_msg(summaryview, summaryview->selected);
+       node = summary_find_next_flagged_msg
+               (summaryview, summaryview->selected, MSG_CLABEL_FLAG_MASK, TRUE);
 
        if (!node) {
                AlertValue val;
@@ -1280,7 +1355,8 @@ void summary_select_next_labeled(SummaryView *summaryview)
                                   "Search from the beginning?"),
                                 _("Yes"), _("No"), NULL);
                if (val != G_ALERTDEFAULT) return;
-               node = summary_find_next_labeled_msg(summaryview, NULL);
+               node = summary_find_next_flagged_msg(summaryview, NULL,
+                                                    MSG_CLABEL_FLAG_MASK, TRUE);
        }
 
        if (!node)
@@ -1380,121 +1456,55 @@ static GtkCTreeNode *summary_find_next_msg(SummaryView *summaryview,
        return node;
 }
 
-static GtkCTreeNode *summary_find_prev_unread_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
+static GtkCTreeNode *summary_find_prev_flagged_msg(SummaryView *summaryview,
+                                                  GtkCTreeNode *current_node,
+                                                  MsgPermFlags flags,
+                                                  gboolean start_from_prev)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCTreeNode *node;
        MsgInfo *msginfo;
 
-       if (current_node)
-               node = current_node;
-       else
-               node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
-
-       for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_next_unread_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = current_node;
-       else
-               node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
-
-       for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_prev_marked_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = GTK_CTREE_NODE_PREV(current_node);
-       else
-               node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
-
-       for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_MARKED(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_next_marked_msg(SummaryView *summaryview,
-                                                 GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = gtkut_ctree_node_next(ctree, current_node);
-       else
-               node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
-
-       for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
-               msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_IS_MARKED(msginfo->flags)) break;
-       }
-
-       return node;
-}
-
-static GtkCTreeNode *summary_find_prev_labeled_msg(SummaryView *summaryview,
-                                                  GtkCTreeNode *current_node)
-{
-       GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
-       GtkCTreeNode *node;
-       MsgInfo *msginfo;
-
-       if (current_node)
-               node = GTK_CTREE_NODE_PREV(current_node);
-       else
+       if (current_node) {
+               if (start_from_prev)
+                       node = GTK_CTREE_NODE_PREV(current_node);
+               else
+                       node = current_node;
+       } else
                node = gtk_ctree_node_nth(ctree, GTK_CLIST(ctree)->rows - 1);
 
        for (; node != NULL; node = GTK_CTREE_NODE_PREV(node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_GET_COLORLABEL_VALUE(msginfo->flags) > 0) break;
+               if ((msginfo->flags.perm_flags & flags) != 0) break;
        }
 
        return node;
 }
 
-static GtkCTreeNode *summary_find_next_labeled_msg(SummaryView *summaryview,
-                                                  GtkCTreeNode *current_node)
+static GtkCTreeNode *summary_find_next_flagged_msg(SummaryView *summaryview,
+                                                  GtkCTreeNode *current_node,
+                                                  MsgPermFlags flags,
+                                                  gboolean start_from_next)
 {
        GtkCTree *ctree = GTK_CTREE(summaryview->ctree);
        GtkCTreeNode *node;
        MsgInfo *msginfo;
 
-       if (current_node)
-               node = gtkut_ctree_node_next(ctree, current_node);
-       else
+       if (current_node) {
+               if (start_from_next)
+                       node = gtkut_ctree_node_next(ctree, current_node);
+               else
+                       node = current_node;
+       } else
                node = GTK_CTREE_NODE(GTK_CLIST(ctree)->row_list);
 
        for (; node != NULL; node = gtkut_ctree_node_next(ctree, node)) {
                msginfo = gtk_ctree_node_get_row_data(ctree, node);
-               if (MSG_GET_COLORLABEL_VALUE(msginfo->flags) > 0) break;
+               /* Find msg with matching flags but ignore messages with
+                  ignore flags, if searching for new or unread messages */
+               if (!(((flags & (MSG_NEW | MSG_UNREAD)) != 0) && MSG_IS_IGNORE_THREAD(msginfo->flags)) && 
+                       ((msginfo->flags.perm_flags & flags) != 0))
+                       break;
        }
 
        return node;
@@ -1685,6 +1695,10 @@ static void summary_status_show(SummaryView *summaryview)
                return;
        }
 
+       summaryview->newmsgs    = summaryview->folder_item->new;
+       summaryview->unread     = summaryview->folder_item->unread;
+       summaryview->messages   = summaryview->folder_item->total;
+
        rowlist = GTK_CLIST(summaryview->ctree)->selection;
        for (cur = rowlist; cur != NULL; cur = cur->next) {
                msginfo = gtk_ctree_node_get_row_data
@@ -1764,13 +1778,6 @@ static void summary_status_show(SummaryView *summaryview)
        }
        gtk_label_set(GTK_LABEL(summaryview->statlabel_msgs), str);
        g_free(str);
-
-       summaryview->folder_item->new    = summaryview->newmsgs;
-       summaryview->folder_item->unread = summaryview->unread;
-       summaryview->folder_item->total  = summaryview->messages;
-
-       folderview_update_msg_num(summaryview->folderview,
-                                 summaryview->folderview->opened);
 }
 
 static void summary_set_column_titles(SummaryView *summaryview)
@@ -1881,7 +1888,7 @@ void summary_sort(SummaryView *summaryview,
        GtkCListCompareFunc cmp_func;
        FolderItem *item = summaryview->folder_item;
 
-       if (!item) return;
+       if (!item || !item->path || !item->parent || item->no_select) return;
 
        switch (sort_key) {
        case SORT_BY_MARK:
@@ -2115,6 +2122,12 @@ gint summary_write_cache(SummaryView *summaryview)
 
        if (!summaryview->folder_item || !summaryview->folder_item->path)
                return -1;
+               
+       if (!summaryview->folder_item->cache)
+               return -1;
+       
+       folder_item_write_cache(summaryview->folder_item);
+       return 0;
 
        if (summaryview->folder_item->folder->update_mark != NULL)
                summaryview->folder_item->folder->update_mark(summaryview->folder_item->folder, summaryview->folder_item);
@@ -2244,6 +2257,7 @@ static void summary_set_header(SummaryView *summaryview, gchar *text[],
        text[col_pos[S_COL_LOCKED]] = NULL;
        text[col_pos[S_COL_NUMBER]] = itos(msginfo->msgnum);
        text[col_pos[S_COL_SIZE]]   = to_human_readable(msginfo->size);
+       text[col_pos[S_COL_SCORE]]  = itos_buf(col_score, msginfo->score);
 
        if (msginfo->date_t) {
                procheader_date_get_localtime(date_modified,
@@ -2344,19 +2358,16 @@ static void summary_display_msg_full(SummaryView *summaryview,
        }
        g_free(filename);
 
+/* NOT NEEDED ANYMORE
        if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread--;
-       if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags) || 
-           MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_unset_perm_flags(msginfo, MSG_NEW | MSG_UNREAD);
-               summary_set_row_marks(summaryview, row);
-               gtk_clist_thaw(GTK_CLIST(ctree));
-               summary_status_show(summaryview);
-       }
+*/
+       procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
+       summary_set_row_marks(summaryview, row);
+       gtk_clist_thaw(GTK_CLIST(ctree));
+       summary_status_show(summaryview);
 
        flags = msginfo->flags;
 
@@ -2384,14 +2395,6 @@ static void summary_display_msg_full(SummaryView *summaryview,
                gtkut_ctree_node_move_if_on_the_edge(ctree, row);
        }
 
-       if (MSG_IS_NEW(msginfo->flags) || MSG_IS_UNREAD(msginfo->flags) ||
-           (MSG_IS_MIME(msginfo->flags) - MSG_IS_MIME(flags) != 0)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               CHANGE_FLAGS(msginfo);
-               summary_set_row_marks(summaryview, row);
-               gtk_clist_thaw(GTK_CLIST(ctree));
-               summary_status_show(summaryview);
-       }
        summary_set_menu_sensitive(summaryview);
        main_window_set_toolbar_sensitive(summaryview->mainwin);
 
@@ -2682,12 +2685,8 @@ static void summary_mark_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_set_perm_flags(msginfo, MSG_MARKED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_MARKED, 0);
        summary_set_row_marks(summaryview, row);
        debug_print(_("Message %s/%d is marked\n"), msginfo->folder->path, msginfo->msgnum);
 }
@@ -2716,12 +2715,8 @@ static void summary_lock_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_LOCKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_set_perm_flags(msginfo, MSG_LOCKED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_LOCKED, 0);
        summary_set_row_marks(summaryview, row);
        debug_print(_("Message %d is locked\n"), msginfo->msgnum);
 }
@@ -2745,20 +2740,16 @@ static void summary_mark_row_as_read(SummaryView *summaryview,
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+/* NOT NEEDED ANYMORE
        if (MSG_IS_NEW(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread--;
-       if (MSG_IS_NEW(msginfo->flags) ||
-           MSG_IS_UNREAD(msginfo->flags)) {
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_NEW | MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_unset_perm_flags(msginfo, MSG_NEW | MSG_UNREAD);
-               CHANGE_FLAGS(msginfo);
-               summary_set_row_marks(summaryview, row);
-               debug_print(_("Message %d is marked as read\n"),
-                           msginfo->msgnum);
-       }
+*/
+       procmsg_msginfo_unset_flags(msginfo, MSG_NEW | MSG_UNREAD, 0);
+       summary_set_row_marks(summaryview, row);
+       debug_print(_("Message %d is marked as read\n"),
+               msginfo->msgnum);
 }
 
 void summary_mark_as_read(SummaryView *summaryview)
@@ -2802,22 +2793,18 @@ static void summary_mark_row_as_unread(SummaryView *summaryview,
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
        if (MSG_IS_DELETED(msginfo->flags)) {
                msginfo->to_folder = NULL;
-               MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
+               procmsg_msginfo_unset_flags(msginfo, MSG_DELETED, 0);
                summaryview->deleted--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_REPLIED | MSG_FORWARDED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_REPLIED);
-       if (!MSG_IS_UNREAD(msginfo->flags)) {
-               MSG_SET_PERM_FLAGS(msginfo->flags, MSG_UNREAD);
-               if (MSG_IS_IMAP(msginfo->flags))
-                       imap_msg_set_perm_flags(msginfo, MSG_UNREAD);
+/* NOT NEEDED ANYMORE
+       if (!MSG_IS_UNREAD(msginfo->flags) && !MSG_IS_IGNORE_THREAD(msginfo->flags))
                summaryview->unread++;
-               debug_print(_("Message %d is marked as unread\n"),
-                           msginfo->msgnum);
-       }
+*/
 
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_REPLIED | MSG_FORWARDED, 0);
+       procmsg_msginfo_set_flags(msginfo, MSG_UNREAD, 0);
+       debug_print(_("Message %d is marked as unread\n"),
+               msginfo->msgnum);
 
        summary_set_row_marks(summaryview, row);
 }
@@ -2912,12 +2899,8 @@ static void summary_delete_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_DELETED);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED, MSG_MOVE | MSG_COPY);
+       procmsg_msginfo_set_flags(msginfo, MSG_DELETED, 0);
        summaryview->deleted++;
 
        if (!prefs_common.immediate_exec && 
@@ -3044,11 +3027,7 @@ static void summary_unmark_row(SummaryView *summaryview, GtkCTreeNode *row)
                        folderview_update_item(msginfo->to_folder, 0);
        }
        msginfo->to_folder = NULL;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE | MSG_COPY);
-       CHANGE_FLAGS(msginfo);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_MOVE | MSG_COPY);
        summary_set_row_marks(summaryview, row);
 
        debug_print(_("Message %s/%d is unmarked\n"),
@@ -3093,12 +3072,9 @@ static void summary_move_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                if (!prefs_common.immediate_exec)
                        msginfo->to_folder->op_count--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_COPY);
        if (!MSG_IS_MOVE(msginfo->flags)) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_MOVE);
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_MOVE);
                summaryview->moved++;
                changed = TRUE;
        }
@@ -3185,12 +3161,9 @@ static void summary_copy_row_to(SummaryView *summaryview, GtkCTreeNode *row,
                if (!prefs_common.immediate_exec)
                        msginfo->to_folder->op_count--;
        }
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED | MSG_DELETED);
-       if (MSG_IS_IMAP(msginfo->flags))
-               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-       MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_MOVE);
+       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED | MSG_DELETED, MSG_MOVE);
        if (!MSG_IS_COPY(msginfo->flags)) {
-               MSG_SET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+               procmsg_msginfo_set_flags(msginfo, 0, MSG_COPY);
                summaryview->copied++;
                changed = TRUE;
        }
@@ -3428,7 +3401,6 @@ static void summary_execute_move(SummaryView *summaryview)
        if (summaryview->mlist) {
                procmsg_move_messages(summaryview->mlist);
 
-               folder_item_scan_foreach(summaryview->folder_table);
                folderview_update_item_foreach(summaryview->folder_table);
 
                for (cur = summaryview->mlist; cur != NULL; cur = cur->next)
@@ -3437,6 +3409,7 @@ static void summary_execute_move(SummaryView *summaryview)
                summaryview->mlist = NULL;
        }
 
+       folderview_update_item(summaryview->folder_item, FALSE);
        g_hash_table_destroy(summaryview->folder_table);
        summaryview->folder_table = NULL;
 }
@@ -3482,7 +3455,7 @@ static void summary_execute_copy(SummaryView *summaryview)
        if (summaryview->mlist) {
                procmsg_copy_messages(summaryview->mlist);
 
-               folder_item_scan_foreach(summaryview->folder_table);
+               /* folder_item_scan_foreach(summaryview->folder_table); */
                folderview_update_item_foreach(summaryview->folder_table);
 
                g_slist_free(summaryview->mlist);
@@ -3512,7 +3485,7 @@ static void summary_execute_copy_func(GtkCTree *ctree, GtkCTreeNode *node,
                summaryview->mlist =
                        g_slist_append(summaryview->mlist, msginfo);
 
-               MSG_UNSET_TMP_FLAGS(msginfo->flags, MSG_COPY);
+               procmsg_msginfo_unset_flags(msginfo, 0, MSG_COPY);
                summary_set_row_marks(summaryview, node);
        }
 }
@@ -3547,9 +3520,9 @@ static void summary_execute_delete(SummaryView *summaryview)
        summaryview->mlist = NULL;
 
        if ((summaryview->folder_item != trash) && (trash != NULL)) {
-               folder_item_scan(trash);
                folderview_update_item(trash, FALSE);
        }
+       folderview_update_item(summaryview->folder_item, FALSE);
 }
 
 static void summary_execute_delete_func(GtkCTree *ctree, GtkCTreeNode *node,
@@ -3801,7 +3774,7 @@ void summary_processing(SummaryView *summaryview, GSList * mlist)
                                          summaryview->folder_table);
        }
        
-       folder_item_scan_foreach(summaryview->folder_table);
+       /* folder_item_scan_foreach(summaryview->folder_table); */
        folderview_update_item_foreach(summaryview->folder_table);
        
        g_hash_table_destroy(summaryview->folder_table);
@@ -3895,7 +3868,7 @@ void summary_filter(SummaryView *summaryview)
 
                gtk_clist_thaw(GTK_CLIST(summaryview->ctree));
 
-               folder_item_scan_foreach(summaryview->folder_table);
+               /* folder_item_scan_foreach(summaryview->folder_table); */
                folderview_update_item_foreach(summaryview->folder_table);
 
                g_hash_table_destroy(summaryview->folder_table);
@@ -4179,8 +4152,8 @@ void summary_set_colorlabel_color(GtkCTree *ctree, GtkCTreeNode *node,
        gint color_index;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, node);
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_CLABEL_FLAG_MASK);
-       MSG_SET_COLORLABEL_VALUE(msginfo->flags, labelcolor);
+       procmsg_msginfo_unset_flags(msginfo, MSG_CLABEL_FLAG_MASK, 0);
+       procmsg_msginfo_set_flags(msginfo, MSG_COLORLABEL_TO_FLAGS(labelcolor), 0);
 
        color_index = labelcolor == 0 ? -1 : (gint)labelcolor - 1;
        ctree_style = gtk_widget_get_style(GTK_WIDGET(ctree));
@@ -4594,6 +4567,12 @@ static void summary_key_pressed(GtkWidget *widget, GdkEventKey *event,
                textview_scroll_one_line(summaryview->messageview->textview,
                                         (event->state & GDK_MOD1_MASK) != 0);
                break;
+       case GDK_asterisk:      /* Mark */
+               summary_mark(summaryview);
+               break;
+       case GDK_exclam:        /* Mark as unread */
+               summary_mark_as_unread(summaryview);
+               break;
        case GDK_Delete:
                RETURN_IF_LOCKED();
                BREAK_ON_MODIFIER_KEY();
@@ -4650,10 +4629,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
        switch (column < 0 ? column : summaryview->col_state[column].type) {
        case S_COL_MARK:
                if (MSG_IS_MARKED(msginfo->flags)) {
-                       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_MARKED);
-                       if (MSG_IS_IMAP(msginfo->flags))
-                               imap_msg_unset_perm_flags(msginfo, MSG_MARKED);
-                       CHANGE_FLAGS(msginfo);
+                       procmsg_msginfo_unset_flags(msginfo, MSG_MARKED, 0);
                        summary_set_row_marks(summaryview, row);
                } else
                        summary_mark_row(summaryview, row);
@@ -4670,8 +4646,7 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
                break;
        case S_COL_LOCKED:
                if (MSG_IS_LOCKED(msginfo->flags)) {
-                       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_LOCKED);
-                       CHANGE_FLAGS(msginfo);
+                       procmsg_msginfo_unset_flags(msginfo, MSG_LOCKED, 0);
                        summary_set_row_marks(summaryview, row);
                }
                else
@@ -4681,7 +4656,9 @@ static void summary_selected(GtkCTree *ctree, GtkCTreeNode *row,
                break;
        }
 
-       if (summaryview->display_msg) {
+       if (summaryview->display_msg ||
+           (prefs_common.show_msg_with_cursor_key &&
+            messageview_is_visible(summaryview->messageview))) {
                summary_display_msg(summaryview, row);
                summaryview->display_msg = FALSE;
        } else {
@@ -5080,13 +5057,13 @@ static void summary_ignore_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpoin
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+/* NOT NEEDED ANYMORE
        if (MSG_IS_NEW(msginfo->flags))
                summaryview->newmsgs--;
        if (MSG_IS_UNREAD(msginfo->flags))
                summaryview->unread--;
-       MSG_SET_PERM_FLAGS(msginfo->flags, MSG_IGNORE_THREAD);
-
-       CHANGE_FLAGS(msginfo);
+*/
+       procmsg_msginfo_set_flags(msginfo, MSG_IGNORE_THREAD, 0);
 
        summary_set_row_marks(summaryview, row);
        debug_print(_("Message %d is marked as ignore thread\n"),
@@ -5112,14 +5089,14 @@ static void summary_unignore_thread_func(GtkCTree *ctree, GtkCTreeNode *row, gpo
        MsgInfo *msginfo;
 
        msginfo = gtk_ctree_node_get_row_data(ctree, row);
+/* NOT NEEDED ANYMORE
        if (MSG_IS_NEW(msginfo->flags))
                summaryview->newmsgs++;
        if (MSG_IS_UNREAD(msginfo->flags))
                summaryview->unread++;
-       MSG_UNSET_PERM_FLAGS(msginfo->flags, MSG_IGNORE_THREAD);
+*/
+       procmsg_msginfo_unset_flags(msginfo, MSG_IGNORE_THREAD, 0);
 
-       CHANGE_FLAGS(msginfo);
-               
        summary_set_row_marks(summaryview, row);
        debug_print(_("Message %d is marked as unignore thread\n"),
            msginfo->msgnum);
@@ -5152,6 +5129,7 @@ static gboolean processing_apply_func(GNode *node, gpointer data)
                return FALSE;
        processing = item->prefs->processing;
 
+
        if (processing != NULL) {
                gchar * buf;
                GSList * mlist;
@@ -5162,9 +5140,11 @@ static gboolean processing_apply_func(GNode *node, gpointer data)
                STATUSBAR_PUSH(summaryview->mainwin, buf);
                g_free(buf);
 
+/*
                mlist = item->folder->get_msg_list(item->folder, item,
                                                   TRUE);
-               
+*/             
+               mlist = folder_item_get_msg_list(item);
                for(cur = mlist ; cur != NULL ; cur = cur->next) {
                        MsgInfo * msginfo;