2009-04-08 [colin] 3.7.1cvs42
[claws.git] / src / procmime.c
index 951fdd8ea134ad8630fb0c03b36c39fc81cc94db..8307a9fbb58585be04577928031df035a1a17a98 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto & The Claws Mail Team
+ * Copyright (C) 1999-2009 Hiroyuki Yamamoto & The Claws Mail Team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -156,8 +156,8 @@ void procmime_mimeinfo_free_all(MimeInfo *mimeinfo)
 
 MimeInfo *procmime_mimeinfo_parent(MimeInfo *mimeinfo)
 {
-       g_return_val_if_fail(mimeinfo != NULL, NULL);
-       g_return_val_if_fail(mimeinfo->node != NULL, NULL);
+       cm_return_val_if_fail(mimeinfo != NULL, NULL);
+       cm_return_val_if_fail(mimeinfo->node != NULL, NULL);
 
        if (mimeinfo->node->parent == NULL)
                return NULL;
@@ -166,8 +166,8 @@ MimeInfo *procmime_mimeinfo_parent(MimeInfo *mimeinfo)
 
 MimeInfo *procmime_mimeinfo_next(MimeInfo *mimeinfo)
 {
-       g_return_val_if_fail(mimeinfo != NULL, NULL);
-       g_return_val_if_fail(mimeinfo->node != NULL, NULL);
+       cm_return_val_if_fail(mimeinfo != NULL, NULL);
+       cm_return_val_if_fail(mimeinfo->node != NULL, NULL);
 
        if (mimeinfo->node->children)
                return (MimeInfo *) mimeinfo->node->children->data;
@@ -242,8 +242,8 @@ const gchar *procmime_mimeinfo_get_parameter(MimeInfo *mimeinfo, const gchar *na
 {
        const gchar *value;
 
-       g_return_val_if_fail(mimeinfo != NULL, NULL);
-       g_return_val_if_fail(name != NULL, NULL);
+       cm_return_val_if_fail(mimeinfo != NULL, NULL);
+       cm_return_val_if_fail(name != NULL, NULL);
 
        value = g_hash_table_lookup(mimeinfo->dispositionparameters, name);
        if (value == NULL)
@@ -291,7 +291,7 @@ gboolean procmime_decode_content(MimeInfo *mimeinfo)
        gchar lastline[BUFFSIZE];
        memset(lastline, 0, BUFFSIZE);
                   
-       g_return_val_if_fail(mimeinfo != NULL, FALSE);
+       cm_return_val_if_fail(mimeinfo != NULL, FALSE);
 
        if (prefs_common.respect_flowed_format &&
            mimeinfo->type == MIMETYPE_TEXT && 
@@ -350,6 +350,7 @@ gboolean procmime_decode_content(MimeInfo *mimeinfo)
                gboolean got_error = FALSE;
                gboolean uncanonicalize = FALSE;
                FILE *tmpfp = outfp;
+               gboolean null_bytes = FALSE;
 
                if (mimeinfo->type == MIMETYPE_TEXT ||
                    mimeinfo->type == MIMETYPE_MESSAGE) {
@@ -366,6 +367,10 @@ gboolean procmime_decode_content(MimeInfo *mimeinfo)
                decoder = base64_decoder_new();
                while ((ftell(infp) < readend) && (fgets(buf, sizeof(buf), infp) != NULL)) {
                        len = base64_decoder_decode(decoder, buf, outbuf);
+                       if (uncanonicalize == TRUE && strlen(outbuf) < len) {
+                               uncanonicalize = FALSE;
+                               null_bytes = TRUE;
+                       }
                        if (len < 0 && !got_error) {
                                g_warning("Bad BASE64 content.\n");
                                if (fwrite(_("[Error decoding BASE64]\n"),
@@ -378,8 +383,14 @@ gboolean procmime_decode_content(MimeInfo *mimeinfo)
                        } else if (len >= 0) {
                                /* print out the error message only once 
                                 * per block */
-                               if (fwrite(outbuf, sizeof(gchar), len, tmpfp) < len)
-                                       err = TRUE;
+                               if (null_bytes) {
+                                       /* we won't uncanonicalize, output to outfp directly */
+                                       if (fwrite(outbuf, sizeof(gchar), len, outfp) < len)
+                                               err = TRUE;
+                               } else {
+                                       if (fwrite(outbuf, sizeof(gchar), len, tmpfp) < len)
+                                               err = TRUE;
+                               }
                                got_error = FALSE;
                        }
                }
@@ -476,15 +487,18 @@ gboolean procmime_encode_content(MimeInfo *mimeinfo, EncodingType encoding)
                return FALSE;
        }
 
-       if (mimeinfo->content == MIMECONTENT_FILE) {
+       if (mimeinfo->content == MIMECONTENT_FILE && mimeinfo->data.filename) {
                if ((infp = g_fopen(mimeinfo->data.filename, "rb")) == NULL) {
                        g_warning("Can't open file %s\n", mimeinfo->data.filename);
+                       fclose(outfp);
                        return FALSE;
                }
        } else if (mimeinfo->content == MIMECONTENT_MEM) {
                infp = str_open_as_stream(mimeinfo->data.mem);
-               if (infp == NULL)
+               if (infp == NULL) {
+                       fclose(outfp);
                        return FALSE;
+               }
        }
 
        if (encoding == ENC_BASE64) {
@@ -499,6 +513,7 @@ gboolean procmime_encode_content(MimeInfo *mimeinfo, EncodingType encoding)
                                if (canonicalize_file(mimeinfo->data.filename, tmp_file) < 0) {
                                        g_free(tmp_file);
                                        fclose(infp);
+                                       fclose(outfp);
                                        return FALSE;
                                }
                                if ((tmp_fp = g_fopen(tmp_file, "rb")) == NULL) {
@@ -506,6 +521,7 @@ gboolean procmime_encode_content(MimeInfo *mimeinfo, EncodingType encoding)
                                        claws_unlink(tmp_file);
                                        g_free(tmp_file);
                                        fclose(infp);
+                                       fclose(outfp);
                                        return FALSE;
                                }
                        } else {
@@ -514,8 +530,10 @@ gboolean procmime_encode_content(MimeInfo *mimeinfo, EncodingType encoding)
                                infp = str_open_as_stream(out);
                                tmp_fp = infp;
                                g_free(out);
-                               if (infp == NULL)
+                               if (infp == NULL) {
+                                       fclose(outfp);
                                        return FALSE;
+                               }
                        }
                }
 
@@ -604,8 +622,8 @@ gint procmime_get_part(const gchar *outfile, MimeInfo *mimeinfo)
        gint restlength, readlength;
        gint saved_errno = 0;
 
-       g_return_val_if_fail(outfile != NULL, -1);
-       g_return_val_if_fail(mimeinfo != NULL, -1);
+       cm_return_val_if_fail(outfile != NULL, -1);
+       cm_return_val_if_fail(mimeinfo != NULL, -1);
 
        if (mimeinfo->encoding_type != ENC_BINARY && !procmime_decode_content(mimeinfo))
                return -EINVAL;
@@ -660,7 +678,7 @@ static FILE *procmime_get_text_content(MimeInfo *mimeinfo)
        gchar *tmpfile;
        gboolean err = FALSE;
 
-       g_return_val_if_fail(mimeinfo != NULL, NULL);
+       cm_return_val_if_fail(mimeinfo != NULL, NULL);
 
        if (!procmime_decode_content(mimeinfo))
                return NULL;
@@ -757,7 +775,7 @@ FILE *procmime_get_first_text_content(MsgInfo *msginfo)
        MimeInfo *mimeinfo, *partinfo;
        gboolean empty_ok = FALSE, short_scan = TRUE;
        START_TIMING("");
-       g_return_val_if_fail(msginfo != NULL, NULL);
+       cm_return_val_if_fail(msginfo != NULL, NULL);
 
        /* first we try to short-scan (for speed), refusing empty parts */
 scan_again:
@@ -825,7 +843,7 @@ FILE *procmime_get_first_encrypted_text_content(MsgInfo *msginfo)
        FILE *outfp = NULL;
        MimeInfo *mimeinfo, *partinfo, *encinfo;
 
-       g_return_val_if_fail(msginfo != NULL, NULL);
+       cm_return_val_if_fail(msginfo != NULL, NULL);
 
        mimeinfo = procmime_scan_message(msginfo);
        if (!mimeinfo) {
@@ -861,7 +879,7 @@ gboolean procmime_msginfo_is_encrypted(MsgInfo *msginfo)
        MimeInfo *mimeinfo, *partinfo;
        gboolean result = FALSE;
 
-       g_return_val_if_fail(msginfo != NULL, FALSE);
+       cm_return_val_if_fail(msginfo != NULL, FALSE);
 
        mimeinfo = procmime_scan_message(msginfo);
        if (!mimeinfo) {
@@ -881,10 +899,10 @@ static gboolean procmime_find_string_part(MimeInfo *mimeinfo, const gchar *filen
        FILE *outfp;
        gchar buf[BUFFSIZE];
 
-       g_return_val_if_fail(mimeinfo != NULL, FALSE);
-       g_return_val_if_fail(mimeinfo->type == MIMETYPE_TEXT, FALSE);
-       g_return_val_if_fail(str != NULL, FALSE);
-       g_return_val_if_fail(find_func != NULL, FALSE);
+       cm_return_val_if_fail(mimeinfo != NULL, FALSE);
+       cm_return_val_if_fail(mimeinfo->type == MIMETYPE_TEXT, FALSE);
+       cm_return_val_if_fail(str != NULL, FALSE);
+       cm_return_val_if_fail(find_func != NULL, FALSE);
 
        outfp = procmime_get_text_content(mimeinfo);
 
@@ -912,9 +930,9 @@ gboolean procmime_find_string(MsgInfo *msginfo, const gchar *str,
        gchar *filename;
        gboolean found = FALSE;
 
-       g_return_val_if_fail(msginfo != NULL, FALSE);
-       g_return_val_if_fail(str != NULL, FALSE);
-       g_return_val_if_fail(find_func != NULL, FALSE);
+       cm_return_val_if_fail(msginfo != NULL, FALSE);
+       cm_return_val_if_fail(str != NULL, FALSE);
+       cm_return_val_if_fail(find_func != NULL, FALSE);
 
        filename = procmsg_get_message_file(msginfo);
        if (!filename) return FALSE;
@@ -944,7 +962,7 @@ gchar *procmime_get_tmp_file_name(MimeInfo *mimeinfo)
        gchar *filename;
        gchar f_prefix[10];
 
-       g_return_val_if_fail(mimeinfo != NULL, NULL);
+       cm_return_val_if_fail(mimeinfo != NULL, NULL);
 
        g_snprintf(f_prefix, sizeof(f_prefix), "%08x.", id++);
 
@@ -1536,6 +1554,8 @@ static void procmime_parse_multipart(MimeInfo *mimeinfo, gboolean short_scan)
        FILE *fp;
        int result = 0;
        gboolean done = FALSE;
+       gboolean start_found = FALSE;
+       gboolean end_found = FALSE;
 
        boundary = g_hash_table_lookup(mimeinfo->typeparameters, "boundary");
        if (!boundary)
@@ -1549,12 +1569,15 @@ static void procmime_parse_multipart(MimeInfo *mimeinfo, gboolean short_scan)
                FILE_OP_ERROR(mimeinfo->data.filename, "fopen");
                return;
        }
+
        fseek(fp, mimeinfo->offset, SEEK_SET);
        while ((p = fgets(buf, sizeof(buf), fp)) != NULL && result == 0) {
                if (ftell(fp) - 1 > (mimeinfo->offset + mimeinfo->length))
                        break;
 
                if (IS_BOUNDARY(buf, boundary, boundary_len)) {
+                       start_found = TRUE;
+
                        if (lastoffset != -1) {
                                gint len = (ftell(fp) - strlen(buf)) - lastoffset - 1;
                                if (len < 0)
@@ -1574,6 +1597,7 @@ static void procmime_parse_multipart(MimeInfo *mimeinfo, gboolean short_scan)
                        
                        if (buf[2 + boundary_len]     == '-' &&
                            buf[2 + boundary_len + 1] == '-') {
+                               end_found = TRUE;
                                break;
                        }
                        for (i = 0; i < (sizeof hentry / sizeof hentry[0]) ; i++) {
@@ -1584,6 +1608,22 @@ static void procmime_parse_multipart(MimeInfo *mimeinfo, gboolean short_scan)
                        lastoffset = ftell(fp);
                }
        }
+       
+       if (start_found && !end_found && lastoffset != -1) {
+               gint len = (ftell(fp) - strlen(buf)) - lastoffset - 1;
+
+               if (len >= 0) {
+                       result = procmime_parse_mimepart(mimeinfo,
+                                       hentry[0].body, hentry[1].body,
+                                       hentry[2].body, hentry[3].body, 
+                                       hentry[4].body, hentry[5].body,
+                                       hentry[6].body, hentry[7].body,
+                                       mimeinfo->data.filename, lastoffset,
+                                       len, short_scan);
+               }
+               mimeinfo->broken = TRUE;
+       }
+       
        for (i = 0; i < (sizeof hentry / sizeof hentry[0]); i++) {
                g_free(hentry[i].body);
                hentry[i].body = NULL;
@@ -1625,8 +1665,8 @@ static void parse_parameters(const gchar *parameters, GHashTable *table)
                down_attr = g_utf8_strdown(attribute, -1);
                orig_down_attr = down_attr;
        
-               len = strlen(down_attr);
-               if (down_attr[len - 1] == '*') {
+               len = down_attr ? strlen(down_attr):0;
+               if (len > 0 && down_attr[len - 1] == '*') {
                        gchar *srcpos, *dstpos, *endpos;
 
                        convert = TRUE;
@@ -1670,7 +1710,7 @@ static void parse_parameters(const gchar *parameters, GHashTable *table)
                        while (value[strlen(value)-1] == ' ') 
                                value[strlen(value)-1] = '\0';
                }               
-               if (strrchr(down_attr, '*') != NULL) {
+               if (down_attr && strrchr(down_attr, '*') != NULL) {
                        gchar *tmpattr;
 
                        tmpattr = g_strdup(down_attr);
@@ -1707,6 +1747,7 @@ static void parse_parameters(const gchar *parameters, GHashTable *table)
                while ((partvalue = g_hash_table_lookup(table, attrwnum)) != NULL) {
                        g_string_append(value, partvalue);
 
+                       g_hash_table_remove(table, attrwnum);
                        g_free(attrwnum);
                        n++;
                        attrwnum = g_strdup_printf("%s*%d", attribute, n);
@@ -1756,8 +1797,8 @@ static void parse_parameters(const gchar *parameters, GHashTable *table)
 
 static void procmime_parse_content_type(const gchar *content_type, MimeInfo *mimeinfo)
 {
-       g_return_if_fail(content_type != NULL);
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(content_type != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
 
        /* RFC 2045, page 13 says that the mime subtype is MANDATORY;
         * if it's not available we use the default Content-Type */
@@ -1797,8 +1838,8 @@ static void procmime_parse_content_disposition(const gchar *content_disposition,
 {
        gchar *tmp, *params;
 
-       g_return_if_fail(content_disposition != NULL);
-       g_return_if_fail(mimeinfo != NULL);
+       cm_return_if_fail(content_disposition != NULL);
+       cm_return_if_fail(mimeinfo != NULL);
 
        tmp = g_strdup(content_disposition);
        if ((params = strchr(tmp, ';')) != NULL) {
@@ -1862,7 +1903,7 @@ void procmime_mimeparser_unregister(MimeParser *parser)
 
 static gboolean procmime_mimeparser_parse(MimeParser *parser, MimeInfo *mimeinfo)
 {
-       g_return_val_if_fail(parser->parse != NULL, FALSE);
+       cm_return_val_if_fail(parser->parse != NULL, FALSE);
        return parser->parse(parser, mimeinfo); 
 }
 
@@ -1888,6 +1929,7 @@ static int procmime_parse_mimepart(MimeInfo *parent,
        /* Create MimeInfo */
        mimeinfo = procmime_mimeinfo_new();
        mimeinfo->content = MIMECONTENT_FILE;
+
        if (parent != NULL) {
                if (g_node_depth(parent->node) > 32) {
                        /* 32 is an arbitrary value
@@ -2041,7 +2083,7 @@ static MimeInfo *procmime_scan_file_full(const gchar *filename, gboolean short_s
 {
        MimeInfo *mimeinfo;
 
-       g_return_val_if_fail(filename != NULL, NULL);
+       cm_return_val_if_fail(filename != NULL, NULL);
 
        mimeinfo = procmime_scan_file_with_offset(filename, 0, short_scan);
 
@@ -2065,7 +2107,7 @@ static MimeInfo *procmime_scan_queue_file_full(const gchar *filename, gboolean s
        gchar buf[BUFFSIZE];
        gint offset = 0;
 
-       g_return_val_if_fail(filename != NULL, NULL);
+       cm_return_val_if_fail(filename != NULL, NULL);
 
        /* Open file */
        if ((fp = g_fopen(filename, "rb")) == NULL)
@@ -2174,6 +2216,7 @@ static void write_parameters(gpointer key, gpointer value, gpointer user_data)
                g_string_append_printf(buf, "%s=\"%s\"", param, val);
                break;
 
+#if 0 /* we don't use that for now */
        case ENC_AS_EXTENDED:
                if (!g_utf8_validate(val, -1, NULL))
                        g_string_append_printf(buf, "%s*=%s''", param,
@@ -2191,7 +2234,7 @@ static void write_parameters(gpointer key, gpointer value, gpointer user_data)
                        }
                }
                break;          
-
+#endif
        case ENC_AS_ENCWORD:
                len = MAX(strlen(val)*6, 512);
                tmp = g_malloc(len+1);