Fix memory leaks from results of gtk_tree_model_get().
[claws.git] / src / prefs_toolbar.c
index 1d42c21621c62041e5748546304e9ac64779e14f..cc56483fd8c7bc87e569c6ace3355a1520add68b 100644 (file)
@@ -1,6 +1,6 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 2002-2007 Hiroyuki Yamamoto & the Claws Mail team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 2002-2017 Hiroyuki Yamamoto & the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -14,7 +14,6 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 /*
@@ -23,6 +22,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
 #include <glib.h>
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>
-#include <gtk/gtkoptionmenu.h>
 #include <gdk/gdkkeysyms.h>
 #include <stdio.h>
 #include <stdlib.h>
 
 #include "stock_pixmap.h"
 #include "manage_window.h"
+#include "combobox.h"
 #include "gtkutils.h"
 #include "mainwindow.h"
 #include "alertpanel.h"
 #include "prefs_common.h"
+#include "prefs_actions.h"
 
 #include "utils.h"
 
@@ -48,6 +49,8 @@
 #include "prefs_toolbar.h"
 #include "prefswindow.h"
 #include "prefs_gtk.h"
+#include "plugin.h"
+#include "messageview.h"
 
 enum
 {
@@ -55,7 +58,7 @@ enum
        SET_FILENAME      = 1,
        SET_TEXT          = 2,
        SET_EVENT         = 3,
-       SET_ICON_TEXT     = 4,          /*!< "icon" text (separator) */ 
+       SET_ICON_TEXT     = 4,          /*!< "icon" text (separator) */
        SET_ICON_IS_TEXT  = 5,          /*!< icon is text representation */
        N_SET_COLUMNS
 };
@@ -64,7 +67,8 @@ enum
 {
        ITEM_FUNCTION     = 0,
        ITEM_USER_ACTION  = 1,
-       ITEM_SEPARATOR    = 2
+       ITEM_PLUGIN       = 2,
+       ITEM_SEPARATOR    = 3,
 };
 
 static const gint ToolbarIcons[] =
@@ -87,7 +91,7 @@ static const gint ToolbarIcons[] =
        STOCK_PIXMAP_LDAP,
        STOCK_PIXMAP_LINEWRAP_CURRENT,
        STOCK_PIXMAP_LINEWRAP_ALL,
-       STOCK_PIXMAP_MAIL,
+       STOCK_PIXMAP_MAIL_DRAFT,
        STOCK_PIXMAP_MAIL_ATTACH,
        STOCK_PIXMAP_MAIL_COMPOSE,
        STOCK_PIXMAP_MAIL_FORWARD,
@@ -96,6 +100,7 @@ static const gint ToolbarIcons[] =
        STOCK_PIXMAP_MAIL_REPLY,
        STOCK_PIXMAP_MAIL_REPLY_TO_ALL,
        STOCK_PIXMAP_MAIL_REPLY_TO_AUTHOR,
+       STOCK_PIXMAP_MAIL_REPLY_TO_LIST,
        STOCK_PIXMAP_MAIL_SEND,
        STOCK_PIXMAP_MAIL_SEND_QUEUE,
        STOCK_PIXMAP_MAIL_SIGN,
@@ -113,6 +118,7 @@ static const gint ToolbarIcons[] =
        STOCK_PIXMAP_GO_FOLDERS,
        STOCK_PIXMAP_MIME_TEXT_PLAIN,
        STOCK_PIXMAP_MIME_TEXT_HTML,
+       STOCK_PIXMAP_MIME_TEXT_PATCH,
        STOCK_PIXMAP_MIME_APPLICATION,
        STOCK_PIXMAP_MIME_IMAGE,
        STOCK_PIXMAP_MIME_AUDIO,
@@ -122,7 +128,7 @@ static const gint ToolbarIcons[] =
        STOCK_PIXMAP_MIME_PS,
        STOCK_PIXMAP_MIME_TEXT_CALENDAR,
        STOCK_PIXMAP_MIME_PGP_SIG,
-       STOCK_PIXMAP_PRINTER,
+       STOCK_PIXMAP_PRINTER_BTN,
        STOCK_PIXMAP_PRIVACY_SIGNED,
        STOCK_PIXMAP_PRIVACY_PASSED,
        STOCK_PIXMAP_PRIVACY_FAILED,
@@ -136,6 +142,20 @@ static const gint ToolbarIcons[] =
        STOCK_PIXMAP_MIME_MESSAGE,
        STOCK_PIXMAP_SPAM_BTN,
        STOCK_PIXMAP_HAM_BTN,
+       STOCK_PIXMAP_TRASH,
+       STOCK_PIXMAP_DELETE,
+       STOCK_PIXMAP_DELETE_DUP,
+       STOCK_PIXMAP_CANCEL,
+       STOCK_PIXMAP_MARK_IGNORETHREAD,
+       STOCK_PIXMAP_MARK_WATCHTHREAD,
+       STOCK_PIXMAP_MARK_MARK,
+       STOCK_PIXMAP_MARK_UNMARK,
+       STOCK_PIXMAP_MARK_LOCKED,
+       STOCK_PIXMAP_MARK_UNLOCKED,
+       STOCK_PIXMAP_MARK_ALLREAD,
+       STOCK_PIXMAP_MARK_ALLUNREAD,
+       STOCK_PIXMAP_MARK_READ,
+       STOCK_PIXMAP_MARK_UNREAD,
        STOCK_PIXMAP_EMPTY,              /* last entry */
 };
 
@@ -153,11 +173,12 @@ typedef struct _ToolbarPage
        GtkWidget *item_type_combo;     /* item type selection widget    */
        GtkWidget *item_func_combo;     /* item internal function widget */
        GtkWidget *item_action_combo;   /* item user action widget       */
+       GtkWidget *item_plugin_combo;   /* items registered by plugins */
        GtkWidget *icon_button;         /* item icon chooser widget      */
-       
+
        GtkWidget *icon_chooser_win;
-       GtkWidget *icon_chooser_list;
-       
+       GtkWidget *icon_chooser_view;
+
        gchar *item_icon_file;          /* item icon file                */
 
 } ToolbarPage;
@@ -166,11 +187,24 @@ typedef struct _ToolbarPage
 #define ERROR_MSG_NO_ICON _("Item has no icon defined.")
 #define ERROR_MSG_NO_TEXT _("Item has no text defined.")
 
+typedef struct _ToolbarPluginItem ToolbarPluginItem;
+struct _ToolbarPluginItem {
+       gchar *plugin;
+       gchar *item_name;
+       ToolbarPluginCallback cb;
+       gpointer cb_data;
+};
+
+/* items registered by plugins */
+static GHashTable *plugin_items_mainwin = NULL;
+static GHashTable *plugin_items_compose = NULL;
+static GHashTable *plugin_items_msgview = NULL;
+
 static void prefs_toolbar_populate               (ToolbarPage *prefs_toolbar);
 
-static void get_action_name                     (const gchar *entry, 
+static void get_action_name                     (const gchar *entry,
                                                  gchar **menu);
-                                                 
+
 static gboolean is_duplicate                     (ToolbarPage *prefs_toolbar,
                                                  gchar            *chosen_action);
 static void prefs_toolbar_save                   (PrefsPage       *_page);
@@ -190,6 +224,8 @@ static void prefs_toolbar_down                   (GtkButton        *button,
 
 static void action_selection_changed            (GtkComboBox *action_combo,
                                                  ToolbarPage *prefs_toolbar);
+static void plugin_selection_changed            (GtkComboBox *action_combo,
+                                                 ToolbarPage *prefs_toolbar);
 
 static void func_selection_changed              (GtkComboBox *action_combo,
                                                  ToolbarPage *prefs_toolbar);
@@ -199,7 +235,7 @@ static void prefs_toolbar_create                 (ToolbarPage *prefs_toolbar);
 static GtkWidget *create_set_list_view          (ToolbarPage *prefs_toolbar);
 
 static gboolean set_list_selected               (GtkTreeSelection *selector,
-                                                 GtkTreeModel *model, 
+                                                 GtkTreeModel *model,
                                                  GtkTreePath *path,
                                                  gboolean currently_selected,
                                                  ToolbarPage *prefs_toolbar);
@@ -207,13 +243,22 @@ static gboolean set_list_selected          (GtkTreeSelection *selector,
 static void icon_chooser_create                         (GtkButton *button,
                                                  ToolbarPage *prefs_toolbar);
 
+
+static GHashTable** get_plugin_hash_from_toolbar_type(ToolbarType toolbar_type)
+{
+       if (toolbar_type == TOOLBAR_MAIN)
+               return &plugin_items_mainwin;
+       else if (toolbar_type == TOOLBAR_COMPOSE)
+               return &plugin_items_compose;
+       else if (toolbar_type == TOOLBAR_MSGVIEW)
+               return &plugin_items_msgview;
+       else
+               return NULL;
+}
+
 static void prefs_toolbar_create_widget(PrefsPage *_page, GtkWindow *window, gpointer data)
 {
        ToolbarPage *prefs_toolbar = (ToolbarPage *) _page;
-       gchar *win_titles[3];
-       win_titles[TOOLBAR_MAIN]    = _("Main toolbar configuration");
-       win_titles[TOOLBAR_COMPOSE] = _("Compose toolbar configuration");  
-       win_titles[TOOLBAR_MSGVIEW] = _("Message view toolbar configuration");  
 
        prefs_toolbar->window = GTK_WIDGET(window);
 
@@ -229,7 +274,7 @@ static void prefs_toolbar_save(PrefsPage *_page)
        GtkTreeView *list_view = GTK_TREE_VIEW(prefs_toolbar->list_view_set);
        GtkTreeModel *model = gtk_tree_view_get_model(list_view);
        GtkTreeIter iter;
-       
+
        toolbar_clear_list(prefs_toolbar->source);
 
        if (!gtk_tree_model_iter_n_children(model, NULL)
@@ -238,8 +283,8 @@ static void prefs_toolbar_save(PrefsPage *_page)
        else {
                do {
                        ToolbarItem *item;
-                       gchar *fname, *text, *event; 
-                       
+                       gchar *fname, *text, *event;
+
                        item = g_new0(ToolbarItem, 1);
 
                        gtk_tree_model_get(model, &iter,
@@ -255,7 +300,6 @@ static void prefs_toolbar_save(PrefsPage *_page)
                        item->index = toolbar_ret_val_from_descr(event);
                        g_free(event);
 
-                       /* TODO: save A_SYL_ACTIONS only if they are still active */
                        toolbar_set_list_item(item, prefs_toolbar->source);
 
                        g_free(item->file);
@@ -266,8 +310,8 @@ static void prefs_toolbar_save(PrefsPage *_page)
 
        toolbar_save_config_file(prefs_toolbar->source);
 
-       if (prefs_toolbar->source == TOOLBAR_MAIN) 
-               main_window_reflect_prefs_all_real(TRUE);
+       if (prefs_toolbar->source == TOOLBAR_MAIN)
+               toolbar_update(TOOLBAR_MAIN, mainwindow_get_mainwindow());
        else if (prefs_toolbar->source == TOOLBAR_COMPOSE)
                compose_reflect_prefs_pixmap_theme();
        else if (prefs_toolbar->source == TOOLBAR_MSGVIEW)
@@ -298,26 +342,26 @@ static void prefs_toolbar_set_displayed(ToolbarPage *prefs_toolbar)
                ToolbarItem *item = (ToolbarItem*) cur->data;
 
                gtk_list_store_append(store, &iter);
-       
+
                if (item->index != A_SEPARATOR) {
                        GdkPixbuf *pix;
                        StockPixmap icon = stock_pixmap_get_icon(item->file);
-                       
-                       stock_pixbuf_gdk(prefs_toolbar->window, icon, &pix);
 
-                       gtk_list_store_set(store, &iter, 
+                       stock_pixbuf_gdk(icon, &pix);
+
+                       gtk_list_store_set(store, &iter,
                                           SET_ICON, pix,
                                           SET_FILENAME, item->file,
                                           SET_TEXT, item->text,
                                           SET_EVENT, toolbar_ret_descr_from_val(item->index),
-                                          SET_ICON_TEXT, NULL, 
+                                          SET_ICON_TEXT, NULL,
                                           SET_ICON_IS_TEXT, FALSE,
                                           -1);
                } else {
                        gtk_list_store_set(store, &iter,
                                           SET_ICON, NULL,
                                           SET_FILENAME, toolbar_ret_descr_from_val(A_SEPARATOR),
-                                          SET_TEXT, (const gchar *) "", 
+                                          SET_TEXT, (const gchar *) "",
                                           SET_EVENT, toolbar_ret_descr_from_val(A_SEPARATOR),
                                           SET_ICON_TEXT, (const gchar *) SEPARATOR_PIXMAP,
                                           SET_ICON_IS_TEXT, TRUE,
@@ -329,48 +373,54 @@ static void prefs_toolbar_set_displayed(ToolbarPage *prefs_toolbar)
        gtk_tree_model_get_iter_first(GTK_TREE_MODEL(store), &iter);
        gtk_tree_selection_select_iter(gtk_tree_view_get_selection
                                                (list_view_set),
-                                      &iter);  
+                                      &iter);
+}
+
+static void add_item_to_plugin_combo(gpointer key, gpointer data, gpointer combo_box)
+{
+       gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(combo_box), (const gchar*)key);
 }
 
 static void prefs_toolbar_populate(ToolbarPage *prefs_toolbar)
 {
-       GList *cur;
-       GSList *cur2;
+       GSList *cur;
        gchar *act, *act_name;
+       GHashTable **hash;
 
-       gtk_combo_box_append_text(GTK_COMBO_BOX(prefs_toolbar->item_type_combo),
-                                 _("Internal Function"));      
-       gtk_combo_box_append_text(GTK_COMBO_BOX(prefs_toolbar->item_type_combo),
-                                 _("User Action"));
-       gtk_combo_box_append_text(GTK_COMBO_BOX(prefs_toolbar->item_type_combo),
-                                 _("Separator"));
-       
        prefs_toolbar->combo_action_list = toolbar_get_action_items(prefs_toolbar->source);
-       for(cur = prefs_toolbar->combo_action_list; cur != NULL; cur = cur->next) {
-               act = (gchar *)cur->data;
-               gtk_combo_box_append_text(GTK_COMBO_BOX(prefs_toolbar->item_func_combo),
-                                         act);
-       }
+       combobox_set_popdown_strings(GTK_COMBO_BOX_TEXT(prefs_toolbar->item_func_combo),
+                                    prefs_toolbar->combo_action_list);
 
        /* get currently defined sylpheed actions */
        if (prefs_common.actions_list != NULL) {
-               for (cur2 = prefs_common.actions_list; cur2 != NULL; cur2 = cur2->next) {
-                       act = (gchar *)cur2->data;
+               for (cur = prefs_common.actions_list; cur != NULL; cur = cur->next) {
+                       act = (gchar *)cur->data;
                        get_action_name(act, &act_name);
-                       
-                       gtk_combo_box_append_text(
-                               GTK_COMBO_BOX(prefs_toolbar->item_action_combo),
+
+                       gtk_combo_box_text_append_text(
+                               GTK_COMBO_BOX_TEXT(prefs_toolbar->item_action_combo),
                                act_name);
 
                        g_free(act_name);
-               } 
+               }
+
+       } else
+               combobox_set_sensitive(GTK_COMBO_BOX(prefs_toolbar->item_type_combo),
+                                       ITEM_USER_ACTION, FALSE);
+
+       /* items registered by plugins */
+       hash = get_plugin_hash_from_toolbar_type(prefs_toolbar->source);
+       if (hash && *hash)
+               g_hash_table_foreach(*hash, add_item_to_plugin_combo,
+                               prefs_toolbar->item_plugin_combo);
+       else
+               combobox_set_sensitive(GTK_COMBO_BOX(prefs_toolbar->item_type_combo),
+                                       ITEM_PLUGIN, FALSE);
 
-       }
-       
-       gtk_combo_box_set_active(GTK_COMBO_BOX(prefs_toolbar->item_type_combo), 0);
        gtk_combo_box_set_active(GTK_COMBO_BOX(prefs_toolbar->item_func_combo), 0);
        gtk_combo_box_set_active(GTK_COMBO_BOX(prefs_toolbar->item_action_combo), 0);
-       
+       gtk_combo_box_set_active(GTK_COMBO_BOX(prefs_toolbar->item_plugin_combo), 0);
+
        prefs_toolbar_set_displayed(prefs_toolbar);
 
        toolbar_clear_list(prefs_toolbar->source);
@@ -380,27 +430,27 @@ static gboolean is_duplicate(ToolbarPage *prefs_toolbar, gchar *chosen_action)
 {
        GtkTreeView *list_view_set = GTK_TREE_VIEW
                                        (prefs_toolbar->list_view_set);
-       GtkTreeModel *model_set = gtk_tree_view_get_model(list_view_set);                                       
+       GtkTreeModel *model_set = gtk_tree_view_get_model(list_view_set);
        gchar *entry;
        GtkTreeIter iter;
        gboolean result;
 
-       g_return_val_if_fail(chosen_action != NULL, TRUE);
+       cm_return_val_if_fail(chosen_action != NULL, TRUE);
 
        if (!gtk_tree_model_iter_n_children(model_set, NULL))
                return FALSE;
-       
+
        if (!gtk_tree_model_get_iter_first(model_set, &iter))
                return FALSE;
 
        result = FALSE;
        do {
                gtk_tree_model_get(model_set, &iter,
-                                  SET_EVENT, &entry, 
+                                  SET_EVENT, &entry,
                                   -1);
-               if (g_utf8_collate(chosen_action, entry) == 0) 
+               if (g_utf8_collate(chosen_action, entry) == 0)
                        result = TRUE;
-               g_free(entry);                  
+               g_free(entry);
        } while (!result && gtk_tree_model_iter_next(model_set, &iter));
 
        return result;
@@ -419,11 +469,11 @@ static void prefs_toolbar_default(GtkButton *button, ToolbarPage *prefs_toolbar)
 static void get_action_name(const gchar *entry, gchar **menu)
 {
        gchar *act, *act_p;
-       
+
        *menu = NULL;
 
        if (prefs_common.actions_list != NULL) {
-               
+
                act = g_strdup(entry);
                act_p = strstr(act, ": ");
                if (act_p != NULL)
@@ -461,26 +511,28 @@ static void prefs_toolbar_register(GtkButton *button, ToolbarPage *prefs_toolbar
                        alertpanel_error(ERROR_MSG_NO_ICON);
                        return;
                }
-               stock_pixbuf_gdk(prefs_toolbar->window, 
-                                stock_pixmap_get_icon(prefs_toolbar->item_icon_file),
-                                &pixbuf);
+               stock_pixbuf_gdk(
+                               stock_pixmap_get_icon(prefs_toolbar->item_icon_file),
+                               &pixbuf);
                if(pixbuf == NULL) {
                        alertpanel_error(ERROR_MSG_NO_ICON);
                        return;
                }
-                               
+
                if (item_type == ITEM_FUNCTION) {
-                       event = gtk_combo_box_get_active_text(GTK_COMBO_BOX(
+                       event = gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(
                                                prefs_toolbar->item_func_combo));
-                                               
+
                        if (is_duplicate(prefs_toolbar, event)) {
                                alertpanel_error(ERROR_MSG);
                                g_free(event);
                                return;
                        }
-               } else
-                       event = toolbar_ret_descr_from_val(A_SYL_ACTIONS);
-               
+               } else if(item_type == ITEM_PLUGIN)
+                 event = toolbar_ret_descr_from_val(A_CLAWS_PLUGINS);
+               else
+                       event = toolbar_ret_descr_from_val(A_CLAWS_ACTIONS);
+
                text = gtk_editable_get_chars(
                        GTK_EDITABLE(prefs_toolbar->item_text_entry), 0 , -1);
 
@@ -498,12 +550,12 @@ static void prefs_toolbar_register(GtkButton *button, ToolbarPage *prefs_toolbar
                        alertpanel_error(ERROR_MSG_NO_TEXT);
                        return;
                }
-               
+
                g_free(text);
-               if(item_type != ITEM_USER_ACTION)
+               if((item_type != ITEM_USER_ACTION) && (item_type != ITEM_PLUGIN))
                        g_free(event);
        }
-       
+
        gtk_tree_selection_select_iter(gtk_tree_view_get_selection
                                                (list_view_set),
                                       &iter);
@@ -519,13 +571,13 @@ static void prefs_toolbar_substitute(GtkButton *button, ToolbarPage *prefs_toolb
 
        if (!gtk_tree_model_iter_n_children(GTK_TREE_MODEL(store_set), NULL))
                return;
-               
-       sel_set = gtk_tree_view_get_selection(list_view_set);           
+
+       sel_set = gtk_tree_view_get_selection(list_view_set);
        if (!gtk_tree_selection_get_selected(sel_set, NULL, &iter_set))
                return;
 
        if (item_type == ITEM_SEPARATOR) {
-               gtk_list_store_set(store_set, &iter_set, 
+               gtk_list_store_set(store_set, &iter_set,
                                   SET_ICON, NULL,
                                   SET_TEXT, NULL,
                                   SET_EVENT, toolbar_ret_descr_from_val(A_SEPARATOR),
@@ -541,7 +593,7 @@ static void prefs_toolbar_substitute(GtkButton *button, ToolbarPage *prefs_toolb
                        alertpanel_error(ERROR_MSG_NO_ICON);
                        return;
                }
-               stock_pixbuf_gdk(prefs_toolbar->window, 
+               stock_pixbuf_gdk(
                                 stock_pixmap_get_icon(prefs_toolbar->item_icon_file),
                                 &pixbuf);
                if(pixbuf == NULL) {
@@ -549,14 +601,14 @@ static void prefs_toolbar_substitute(GtkButton *button, ToolbarPage *prefs_toolb
                        return;
                }
 
-               gtk_tree_model_get(GTK_TREE_MODEL(store_set), &iter_set, 
+               gtk_tree_model_get(GTK_TREE_MODEL(store_set), &iter_set,
                                                  SET_EVENT, &set_event,
                                                  -1);
-               
+
                if (item_type == ITEM_FUNCTION) {
-                       icon_event = gtk_combo_box_get_active_text(GTK_COMBO_BOX(
+                       icon_event = gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(
                                                prefs_toolbar->item_func_combo));
-                                               
+
                        if (is_duplicate(prefs_toolbar, icon_event)
                        && g_utf8_collate(icon_event, set_event) != 0){
                                alertpanel_error(ERROR_MSG);
@@ -564,9 +616,11 @@ static void prefs_toolbar_substitute(GtkButton *button, ToolbarPage *prefs_toolb
                                g_free(set_event);
                                return;
                        }
-               } else
-                       icon_event = toolbar_ret_descr_from_val(A_SYL_ACTIONS);
-               
+               } else if(item_type == ITEM_PLUGIN)
+                       icon_event = toolbar_ret_descr_from_val(A_CLAWS_PLUGINS);
+               else
+                       icon_event = toolbar_ret_descr_from_val(A_CLAWS_ACTIONS);
+
                text = gtk_editable_get_chars(
                        GTK_EDITABLE(prefs_toolbar->item_text_entry), 0 , -1);
 
@@ -580,13 +634,13 @@ static void prefs_toolbar_substitute(GtkButton *button, ToolbarPage *prefs_toolb
                                           SET_ICON_TEXT, NULL,
                                           SET_ICON_IS_TEXT, FALSE,
                                           -1);
-               } else 
+               } else
                        alertpanel_error(ERROR_MSG_NO_TEXT);
-                               
+
                g_free(text);
                g_free(set_event);
-               if(item_type != ITEM_USER_ACTION)
-                       g_free(icon_event);             
+               if((item_type != ITEM_USER_ACTION) && (item_type != ITEM_PLUGIN))
+                       g_free(icon_event);
        }
 }
 
@@ -595,21 +649,21 @@ static void prefs_toolbar_delete(GtkButton *button, ToolbarPage *prefs_toolbar)
        GtkTreeView *list_view_set = GTK_TREE_VIEW(prefs_toolbar->list_view_set);
        GtkTreeModel *store_set = gtk_tree_view_get_model(list_view_set);
        GtkTreeIter iter_set;
-       GtkTreePath *path;                                                      
+       GtkTreePath *path;
 
        if (!gtk_tree_model_iter_n_children(GTK_TREE_MODEL(store_set), NULL))
                return;
-       
+
        if (!gtk_tree_selection_get_selected(gtk_tree_view_get_selection
                                                        (list_view_set),
                                             NULL,
                                             &iter_set))
-               return;                                      
+               return;
 
        /* select prev list item, if deleted was first select next */
        path = gtk_tree_model_get_path(store_set, &iter_set);
        gtk_tree_path_prev(path);
-       
+
        gtk_list_store_remove(GTK_LIST_STORE(store_set), &iter_set);
 
        gtk_tree_selection_select_path(
@@ -626,11 +680,11 @@ static void prefs_toolbar_up(GtkButton *button, ToolbarPage *prefs_toolbar)
        GtkListStore *store = NULL;
        GtkTreeModel *model = NULL;
        GtkTreeIter iprev;
-       
+
        if (!gtk_tree_selection_get_selected
                (gtk_tree_view_get_selection
                        (GTK_TREE_VIEW(prefs_toolbar->list_view_set)),
-                &model,        
+                &model,
                 &isel))
                return;
        store = (GtkListStore *)model;
@@ -638,7 +692,7 @@ static void prefs_toolbar_up(GtkButton *button, ToolbarPage *prefs_toolbar)
        sel = gtk_tree_model_get_path(GTK_TREE_MODEL(store), &isel);
        if (!sel)
                return;
-       
+
        /* no move if we're at row 0... */
        prev = gtk_tree_path_copy(sel);
        if (!gtk_tree_path_prev(prev)) {
@@ -660,7 +714,7 @@ static void prefs_toolbar_down(GtkButton *button, ToolbarPage *prefs_toolbar)
        GtkListStore *store = NULL;
        GtkTreeModel *model = NULL;
        GtkTreeIter next, sel;
-       
+
        if (!gtk_tree_selection_get_selected
                (gtk_tree_view_get_selection
                        (GTK_TREE_VIEW(prefs_toolbar->list_view_set)),
@@ -670,7 +724,7 @@ static void prefs_toolbar_down(GtkButton *button, ToolbarPage *prefs_toolbar)
 
        store = (GtkListStore *)model;
        next = sel;
-       if (!gtk_tree_model_iter_next(GTK_TREE_MODEL(store), &next)) 
+       if (!gtk_tree_model_iter_next(GTK_TREE_MODEL(store), &next))
                return;
 
        gtk_list_store_swap(store, &next, &sel);
@@ -685,6 +739,7 @@ static void item_type_changed(GtkComboBox *item_type_combo,
        case ITEM_FUNCTION:
                gtk_widget_show(prefs_toolbar->item_func_combo);
                gtk_widget_hide(prefs_toolbar->item_action_combo);
+               gtk_widget_hide(prefs_toolbar->item_plugin_combo);
                gtk_combo_box_set_active(
                        GTK_COMBO_BOX(prefs_toolbar->item_func_combo), 0);
                gtk_button_set_label(GTK_BUTTON(prefs_toolbar->icon_button), "");
@@ -698,15 +753,16 @@ static void item_type_changed(GtkComboBox *item_type_combo,
        case ITEM_USER_ACTION:
                gtk_widget_show(prefs_toolbar->item_action_combo);
                gtk_widget_hide(prefs_toolbar->item_func_combo);
+               gtk_widget_hide(prefs_toolbar->item_plugin_combo);
                gtk_combo_box_set_active(
                        GTK_COMBO_BOX(prefs_toolbar->item_action_combo), 0);
                gtk_button_set_label(GTK_BUTTON(prefs_toolbar->icon_button), "");
                gtk_widget_set_sensitive(prefs_toolbar->item_text_entry, FALSE);
                gtk_widget_set_sensitive(prefs_toolbar->item_action_combo, TRUE);
                gtk_widget_set_sensitive(prefs_toolbar->icon_button, TRUE);
-               
+
                action_selection_changed(GTK_COMBO_BOX(prefs_toolbar->item_action_combo),
-                                       prefs_toolbar);         
+                                       prefs_toolbar);
                break;
        case ITEM_SEPARATOR:
                gtk_button_set_label(GTK_BUTTON(prefs_toolbar->icon_button), _("None"));
@@ -717,12 +773,26 @@ static void item_type_changed(GtkComboBox *item_type_combo,
                        GTK_COMBO_BOX(prefs_toolbar->item_func_combo), -1);
                gtk_combo_box_set_active(
                        GTK_COMBO_BOX(prefs_toolbar->item_action_combo), -1);
+               gtk_combo_box_set_active(
+                       GTK_COMBO_BOX(prefs_toolbar->item_plugin_combo), -1);
                gtk_entry_set_text(GTK_ENTRY(prefs_toolbar->item_text_entry), "");
                gtk_widget_set_sensitive(prefs_toolbar->item_action_combo, FALSE);
                gtk_widget_set_sensitive(prefs_toolbar->item_text_entry, FALSE);
+               gtk_widget_set_sensitive(prefs_toolbar->item_plugin_combo, FALSE);
                gtk_widget_set_sensitive(prefs_toolbar->item_func_combo, FALSE);
                gtk_widget_set_sensitive(prefs_toolbar->icon_button, FALSE);
                break;
+         case ITEM_PLUGIN:
+               gtk_widget_show(prefs_toolbar->item_plugin_combo);
+               gtk_widget_hide(prefs_toolbar->item_func_combo);
+               gtk_widget_hide(prefs_toolbar->item_action_combo);
+               gtk_combo_box_set_active(GTK_COMBO_BOX(prefs_toolbar->item_plugin_combo), 0);
+               gtk_button_set_label(GTK_BUTTON(prefs_toolbar->icon_button), "");
+               gtk_widget_set_sensitive(prefs_toolbar->item_text_entry, FALSE);
+               gtk_widget_set_sensitive(prefs_toolbar->item_plugin_combo, TRUE);
+               gtk_widget_set_sensitive(prefs_toolbar->icon_button, TRUE);
+               plugin_selection_changed(GTK_COMBO_BOX(prefs_toolbar->item_plugin_combo), prefs_toolbar);
+               break;
        }
 
 }
@@ -730,39 +800,53 @@ static void item_type_changed(GtkComboBox *item_type_combo,
 static void action_selection_changed(GtkComboBox *action_combo,
                                ToolbarPage *prefs_toolbar)
 {
-       gchar *text = gtk_combo_box_get_active_text(GTK_COMBO_BOX(
+       gchar *text = gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(
                           prefs_toolbar->item_action_combo));
 
        if(text != NULL) { /* action */
                gtk_entry_set_text(GTK_ENTRY(prefs_toolbar->item_text_entry), text);
                g_free(text);
-       } 
+       }
+}
+
+static void plugin_selection_changed(GtkComboBox *action_combo,
+                ToolbarPage *prefs_toolbar)
+{
+       gchar *text = gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(prefs_toolbar->item_plugin_combo));
+
+       if (text != NULL) { /* action */
+               gtk_entry_set_text(GTK_ENTRY(prefs_toolbar->item_text_entry), text);
+               g_free(text);
+       }
 }
 
 static void func_selection_changed(GtkComboBox *action_combo,
                                ToolbarPage *prefs_toolbar)
 {
-       gchar *text = gtk_combo_box_get_active_text(GTK_COMBO_BOX(
+       gchar *text = gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(
                           prefs_toolbar->item_func_combo));
 
        if(text != NULL) { /* action */
-               int action = -1;
+               int action;
+
                action = toolbar_ret_val_from_descr(text);
-               if (action >= 0)
-                       gtk_entry_set_text(GTK_ENTRY(prefs_toolbar->item_text_entry), 
-                                       toolbar_get_short_text(action));
                g_free(text);
-               if (action >= 0) {
-                       StockPixmap stockp = toolbar_get_icon(action);
-                       if (stockp >= 0)  {
+               if (action > -1) {
+                       gint icon;
+
+                       gtk_entry_set_text(GTK_ENTRY(prefs_toolbar->item_text_entry),
+                                       toolbar_get_short_text(action));
+                       icon = toolbar_get_icon(action);
+                       if (icon > -1)  {
+                               StockPixmap stockp = (StockPixmap)icon;
                                g_free(prefs_toolbar->item_icon_file);
                                prefs_toolbar->item_icon_file = g_strdup(stock_pixmap_get_name(stockp));
 
                                gtk_button_set_image(GTK_BUTTON(prefs_toolbar->icon_button),
-                                    stock_pixmap_widget(prefs_toolbar->window, stockp));
+                                    stock_pixmap_widget(stockp));
                        }
                }
-       } 
+       }
 }
 
 static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
@@ -774,12 +858,15 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
        GtkWidget *icon_button;
        GtkWidget *icon_hbox;
        GtkWidget *item_type_combo;
+       GtkListStore *item_type_model;
+       GtkTreeIter iter;
        GtkWidget *item_action_combo;
+       GtkWidget *item_plugin_combo;
        GtkWidget *item_func_combo;
        GtkWidget *reg_hbox;
        GtkWidget *arrow;
        GtkWidget *btn_hbox;
-#ifdef MAEMO
+#ifdef GENERIC_UMPC
        GtkWidget *hbox;
 #endif
        GtkWidget *reg_btn;
@@ -805,14 +892,14 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
        main_vbox = gtk_vbox_new(FALSE, 0);
        gtk_widget_show(main_vbox);
 
-       vbox_frame = gtk_frame_new(_("Toolbar item"));
+       PACK_FRAME (main_vbox, vbox_frame, _("Toolbar item"))
+       gtk_container_set_border_width(GTK_CONTAINER(vbox_frame), 8);
        gtk_widget_show(vbox_frame);
-       gtk_box_pack_start(GTK_BOX(main_vbox), vbox_frame, FALSE, TRUE, 0);
 
        toolbar_item_hbox = gtk_hbox_new (FALSE, 4);
        gtk_widget_show(toolbar_item_hbox);
        gtk_container_add(GTK_CONTAINER (vbox_frame), toolbar_item_hbox);
-       
+
        table = gtk_table_new (3, 3, FALSE);
        gtk_box_pack_start(GTK_BOX(toolbar_item_hbox), table,
                           TRUE, TRUE, 0);
@@ -826,9 +913,15 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
        gtk_widget_show(label);
        gtk_table_attach(GTK_TABLE(table), label, 0, 1, 0, 1,
                         (GtkAttachOptions) (GTK_FILL),
-                        (GtkAttachOptions) (0), 0, 0); 
-       
-       item_type_combo = gtk_combo_box_new_text();
+                        (GtkAttachOptions) (0), 0, 0);
+
+       item_type_combo = gtkut_sc_combobox_create(NULL, TRUE);
+       item_type_model = GTK_LIST_STORE(gtk_combo_box_get_model(
+                                        GTK_COMBO_BOX(item_type_combo)));
+       COMBOBOX_ADD(item_type_model, _("Internal Function"), ITEM_FUNCTION);
+       COMBOBOX_ADD(item_type_model, _("User Action"), ITEM_USER_ACTION);
+       COMBOBOX_ADD(item_type_model, _("Plugins"), ITEM_PLUGIN);
+       COMBOBOX_ADD(item_type_model, _("Separator"), ITEM_SEPARATOR);
        gtk_widget_set_size_request(item_type_combo, 200, -1);
        gtk_table_attach(GTK_TABLE(table), item_type_combo, 1, 3, 0, 1,
                         (GtkAttachOptions) (GTK_EXPAND | GTK_FILL),
@@ -841,19 +934,26 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
                          (GtkAttachOptions) (GTK_FILL),
                          (GtkAttachOptions) (0), 0, 0);
 
-       item_action_combo = gtk_combo_box_new_text();
+       item_action_combo = gtk_combo_box_text_new();
        gtk_widget_set_size_request(item_action_combo, 200, -1);
        gtk_table_attach (GTK_TABLE (table), item_action_combo, 1, 3, 1, 2,
                          (GtkAttachOptions) (GTK_FILL),
                          (GtkAttachOptions) (0), 0, 0);
-                         
+
        /* available internal functions */
-       item_func_combo = gtk_combo_box_new_text();
+       item_func_combo = gtk_combo_box_text_new();
        gtk_widget_set_size_request(item_func_combo, 200, -1);
        gtk_table_attach (GTK_TABLE (table), item_func_combo, 1, 3, 1, 2,
                          (GtkAttachOptions) (GTK_EXPAND | GTK_FILL),
                          (GtkAttachOptions) (0), 0, 0);
-       
+
+       /* plugin-registered items */
+       item_plugin_combo = gtk_combo_box_text_new();
+       gtk_widget_set_size_request(item_plugin_combo, 200, -1);
+       gtk_table_attach(GTK_TABLE(table), item_plugin_combo, 1, 3, 1, 2,
+                        (GtkAttachOptions) (GTK_FILL),
+                        (GtkAttachOptions) (0), 0, 0);
+
        /* toolbar item description */
        label_icon_text = gtk_label_new(_("Toolbar text"));
        gtk_misc_set_alignment(GTK_MISC(label_icon_text), 0, 0.5);
@@ -869,17 +969,17 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
 
        icon_vbox = gtk_vbox_new(FALSE, VBOX_BORDER);
        gtk_widget_show(icon_vbox);
-       
+
        icon_label = gtk_label_new(_("Icon"));
        gtk_widget_set_size_request(icon_label, 100, -1);
        gtk_box_pack_start(GTK_BOX(icon_vbox), icon_label, FALSE, FALSE, 0);
-       
+
        icon_hbox = gtk_hbox_new(FALSE, 0);
        gtk_widget_show(icon_hbox);
-       
+
        label = gtk_label_new("");
        gtk_box_pack_start(GTK_BOX(icon_hbox), label, TRUE, TRUE, 0);
-       
+
        icon_button = gtk_button_new();
        gtk_widget_show(icon_button);
        gtk_widget_set_size_request(icon_button, 50, 50);
@@ -888,12 +988,12 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
        gtk_box_pack_start(GTK_BOX(icon_hbox), icon_button, FALSE, FALSE, 8);
 
        label = gtk_label_new("");
-       gtk_box_pack_start(GTK_BOX(icon_hbox), label, TRUE, TRUE, 0);   
-       
+       gtk_box_pack_start(GTK_BOX(icon_hbox), label, TRUE, TRUE, 0);
+
        gtk_box_pack_start(GTK_BOX(icon_vbox), icon_hbox, FALSE, FALSE, 0);
-       
+
        gtk_box_pack_start(GTK_BOX(toolbar_item_hbox), icon_vbox, FALSE, FALSE, 0);
-               
+
        /* register / substitute / delete */
        reg_hbox = gtk_hbox_new(FALSE, 4);
        gtk_box_pack_start(GTK_BOX(main_vbox), reg_hbox, FALSE, FALSE, 0);
@@ -906,26 +1006,30 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
        btn_hbox = gtk_hbox_new(TRUE, 4);
        gtk_box_pack_start(GTK_BOX(reg_hbox), btn_hbox, FALSE, FALSE, 0);
 
-       reg_btn = gtk_button_new_from_stock(GTK_STOCK_ADD);
+       reg_btn = gtk_button_new_with_mnemonic (_("A_dd"));
+       gtk_button_set_image(GTK_BUTTON(reg_btn),
+                       gtk_image_new_from_stock(GTK_STOCK_ADD,GTK_ICON_SIZE_BUTTON));
        gtk_box_pack_start(GTK_BOX(btn_hbox), reg_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(reg_btn), "clicked",
-                        G_CALLBACK(prefs_toolbar_register), 
+                        G_CALLBACK(prefs_toolbar_register),
                         prefs_toolbar);
 
-       subst_btn = gtkut_get_replace_btn(_("Replace"));
+       subst_btn = gtkut_get_replace_btn(_("_Replace"));
        gtk_box_pack_start(GTK_BOX(btn_hbox), subst_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(subst_btn), "clicked",
                         G_CALLBACK(prefs_toolbar_substitute),
                         prefs_toolbar);
 
-       del_btn = gtk_button_new_from_stock(GTK_STOCK_DELETE);
+       del_btn = gtk_button_new_with_mnemonic (_("D_elete"));
+       gtk_button_set_image(GTK_BUTTON(del_btn),
+                       gtk_image_new_from_stock(GTK_STOCK_REMOVE,GTK_ICON_SIZE_BUTTON));
        gtk_box_pack_start(GTK_BOX(btn_hbox), del_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(del_btn), "clicked",
-                        G_CALLBACK(prefs_toolbar_delete), 
+                        G_CALLBACK(prefs_toolbar_delete),
                          prefs_toolbar);
 
        default_btn = gtk_button_new_with_label(_(" Use default "));
-#ifndef MAEMO
+#ifndef GENERIC_UMPC
        gtk_box_pack_end(GTK_BOX(reg_hbox), default_btn, FALSE, TRUE, 0);
 #else
        hbox = gtk_hbox_new(FALSE, 0);
@@ -933,52 +1037,55 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
        gtk_box_pack_start(GTK_BOX(hbox), default_btn, FALSE, FALSE, 0);
 #endif
        g_signal_connect(G_OBJECT(default_btn), "clicked",
-                        G_CALLBACK(prefs_toolbar_default), 
+                        G_CALLBACK(prefs_toolbar_default),
                         prefs_toolbar);
 
        /* currently active toolbar items */
        vbox_toolbar_items = gtk_vbox_new(FALSE, VBOX_BORDER);
        gtk_box_pack_start(GTK_BOX(main_vbox), vbox_toolbar_items, TRUE, TRUE, 0);
-       
+
        hbox_bottom = gtk_hbox_new(FALSE, 0);
        gtk_container_add(GTK_CONTAINER(vbox_toolbar_items), hbox_bottom);
-       
+
        scrolledwindow_list_view_set = gtk_scrolled_window_new(NULL, NULL);
        gtk_box_pack_start(GTK_BOX(hbox_bottom), scrolledwindow_list_view_set, TRUE, TRUE, 0);
-       gtk_container_set_border_width(GTK_CONTAINER(scrolledwindow_list_view_set), 1);
-       gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolledwindow_list_view_set), 
+    gtk_container_set_border_width(GTK_CONTAINER(scrolledwindow_list_view_set), 8);
+       gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolledwindow_list_view_set),
                                        GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
        gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(scrolledwindow_list_view_set),
                                            GTK_SHADOW_IN);
 
-       list_view_set = create_set_list_view(prefs_toolbar); 
+       list_view_set = create_set_list_view(prefs_toolbar);
        gtk_widget_show(list_view_set);
        gtk_container_add(GTK_CONTAINER(scrolledwindow_list_view_set), list_view_set);
        gtk_widget_set_size_request(list_view_set, 225, 120);
 
-       btn_vbox = gtk_vbox_new(FALSE, 8);
+       btn_vbox = gtk_vbox_new(FALSE, 0);
        gtk_widget_show(btn_vbox);
-       gtk_box_pack_start(GTK_BOX(hbox_bottom), btn_vbox, FALSE, FALSE, 5);
+       gtk_box_pack_start(GTK_BOX(hbox_bottom), btn_vbox, FALSE, FALSE, 0);
 
        up_btn = gtk_button_new_from_stock(GTK_STOCK_GO_UP);
        gtk_widget_show(up_btn);
-       gtk_box_pack_start(GTK_BOX(btn_vbox), up_btn, FALSE, FALSE, 2);
+       gtk_box_pack_start(GTK_BOX(btn_vbox), up_btn, FALSE, FALSE, 4);
 
        down_btn = gtk_button_new_from_stock(GTK_STOCK_GO_DOWN);
        gtk_widget_show(down_btn);
        gtk_box_pack_start(GTK_BOX(btn_vbox), down_btn, FALSE, FALSE, 0);
+       gtk_container_set_border_width(GTK_CONTAINER(btn_vbox), 8);
 
        g_signal_connect(G_OBJECT(item_type_combo), "changed",
                         G_CALLBACK(item_type_changed), prefs_toolbar);
        g_signal_connect(G_OBJECT(item_action_combo), "changed",
                         G_CALLBACK(action_selection_changed), prefs_toolbar);
+       g_signal_connect(G_OBJECT(item_plugin_combo), "changed",
+                        G_CALLBACK(plugin_selection_changed), prefs_toolbar);
        g_signal_connect(G_OBJECT(item_func_combo), "changed",
                         G_CALLBACK(func_selection_changed), prefs_toolbar);
        g_signal_connect(G_OBJECT(up_btn), "clicked",
                         G_CALLBACK(prefs_toolbar_up), prefs_toolbar);
        g_signal_connect(G_OBJECT(down_btn), "clicked",
                         G_CALLBACK(prefs_toolbar_down), prefs_toolbar);
-       
+
        gtk_widget_show_all(main_vbox);
 
        prefs_toolbar->list_view_set    = list_view_set;
@@ -986,9 +1093,10 @@ static void prefs_toolbar_create(ToolbarPage *prefs_toolbar)
        prefs_toolbar->item_type_combo  = item_type_combo;
        prefs_toolbar->item_func_combo  = item_func_combo;
        prefs_toolbar->item_action_combo= item_action_combo;
+       prefs_toolbar->item_plugin_combo= item_plugin_combo;
        prefs_toolbar->icon_button      = icon_button;
        prefs_toolbar->item_icon_file   = NULL;
-       
+
        prefs_toolbar->page.widget = main_vbox;
 }
 
@@ -996,12 +1104,129 @@ ToolbarPage *prefs_toolbar_mainwindow;
 ToolbarPage *prefs_toolbar_composewindow;
 ToolbarPage *prefs_toolbar_messageview;
 
+static void toolbar_unregister_plugin_item_real(GHashTable *hash,
+                                       const gchar *plugin_name,
+                                       const gchar *item_name)
+{
+       gchar *key;
+
+       if (!hash)
+               return;
+
+       key = g_strdup_printf(plugin_name, "/", item_name, NULL);
+       g_hash_table_remove(hash, key);
+       g_free(key);
+}
+
+void prefs_toolbar_unregister_plugin_item(ToolbarType toolbar_type,
+                                       const gchar *plugin_name,
+                                       const gchar *item_name)
+{
+       GHashTable **hash;
+       hash = get_plugin_hash_from_toolbar_type(toolbar_type);
+       if (hash)
+               toolbar_unregister_plugin_item_real(*hash, plugin_name, item_name);
+}
+
+static void prefs_toolbar_execute_plugin_item_real(gpointer parent,
+                               GHashTable *hash, const gchar *id)
+{
+       ToolbarPluginItem *value;
+       GSList *walk;
+       gboolean found;
+
+       if (!hash) {
+               debug_print("No plugin registered toolbar items yet\n");
+               return;
+       }
+
+       value = g_hash_table_lookup(hash, id);
+       if (!value) {
+               debug_print("Could not find plugin toolbar item with id %s\n", id);
+               return;
+       }
+
+       /* check if corresponding plugin is currently loaded */
+       found = FALSE;
+       for (walk = plugin_get_list(); walk; walk = walk->next) {
+               const gchar *plugin_name;
+               Plugin *plugin = walk->data;
+               plugin_name = plugin_get_name(plugin);
+               if (!strcmp(plugin_name, value->plugin)) {
+                       found = TRUE;
+                       break;
+               }
+       }
+       if (!found) {
+               debug_print("Plugin '%s' is currently not loaded, cannot execute toolbar action\n", value->plugin);
+               return;
+       }
+
+       value->cb(parent, value->item_name, value->cb_data);
+}
+
+void prefs_toolbar_execute_plugin_item(gpointer parent,
+                       ToolbarType toolbar_type, const gchar *id)
+{
+       GHashTable **hash;
+       hash = get_plugin_hash_from_toolbar_type(toolbar_type);
+       if (hash)
+               prefs_toolbar_execute_plugin_item_real(parent, *hash, id);
+}
+
+static void destroy_plugin_item_hash_value(ToolbarPluginItem *item)
+{
+       g_free(item->plugin);
+       g_free(item->item_name);
+       g_free(item);
+}
+
+static void prefs_toolbar_register_plugin_item_real(GHashTable **hash,
+                                       const gchar *plugin_name,
+                                       const gchar *item_name,
+                                       ToolbarPluginCallback cb,
+                                       gpointer cb_data)
+{
+       gchar *key;
+       ToolbarPluginItem *value;
+
+       cm_return_if_fail(plugin_name && item_name);
+
+       if (!*hash) {
+               *hash = g_hash_table_new_full(g_str_hash, g_str_equal, g_free,
+                               (GDestroyNotify) destroy_plugin_item_hash_value);
+               if (!*hash)
+                       return;
+       }
+
+       key = g_strconcat(plugin_name, "/", item_name, NULL);
+       value = g_new0(ToolbarPluginItem, 1);
+       value->plugin = g_strdup(plugin_name);
+       value->item_name = g_strdup(item_name);
+       value->cb = cb;
+       value->cb_data = cb_data;
+       g_hash_table_insert(*hash, key, value);
+}
+
+void prefs_toolbar_register_plugin_item(ToolbarType toolbar_type,
+                                       const gchar *plugin_name,
+                                       const gchar *item_name,
+                                       ToolbarPluginCallback cb,
+                                       gpointer cb_data)
+{
+       GHashTable **hash;
+       hash = get_plugin_hash_from_toolbar_type(toolbar_type);
+       if(hash)
+               prefs_toolbar_register_plugin_item_real(hash, plugin_name,
+                                               item_name, cb, cb_data);
+}
+
 void prefs_toolbar_init(void)
 {
        ToolbarPage *page;
        static gchar *mainpath[3], *messagepath[3], *composepath[3];
 
-       mainpath[0] = _("Customize Toolbars");
+       mainpath[0] = _("Toolbars");
        mainpath[1] = _("Main Window");
        mainpath[2] = NULL;
 
@@ -1015,7 +1240,7 @@ void prefs_toolbar_init(void)
        prefs_gtk_register_page((PrefsPage *) page);
        prefs_toolbar_mainwindow = page;
 
-       messagepath[0] = _("Customize Toolbars");
+       messagepath[0] = _("Toolbars");
        messagepath[1] = _("Message Window");
        messagepath[2] = NULL;
 
@@ -1029,7 +1254,7 @@ void prefs_toolbar_init(void)
        prefs_gtk_register_page((PrefsPage *) page);
        prefs_toolbar_messageview = page;
 
-       composepath[0] = _("Customize Toolbars");
+       composepath[0] = _("Toolbars");
        composepath[1] = _("Compose Window");
        composepath[2] = NULL;
 
@@ -1057,6 +1282,24 @@ void prefs_toolbar_done(void)
        g_free(prefs_toolbar_messageview);
 }
 
+void prefs_toolbar_update_action_btns(void)
+{
+       if (toolbar_check_action_btns(TOOLBAR_MAIN)) {
+               toolbar_save_config_file(TOOLBAR_MAIN);
+               toolbar_update(TOOLBAR_MAIN, mainwindow_get_mainwindow());
+       }
+
+       if (toolbar_check_action_btns(TOOLBAR_COMPOSE)) {
+               toolbar_save_config_file(TOOLBAR_COMPOSE);
+               compose_reflect_prefs_pixmap_theme();
+       }
+
+       if (toolbar_check_action_btns(TOOLBAR_MSGVIEW)) {
+               toolbar_save_config_file(TOOLBAR_MSGVIEW);
+               messageview_reflect_prefs_pixmap_theme();
+       }
+}
+
 static void set_visible_if_not_text(GtkTreeViewColumn *col,
                                    GtkCellRenderer   *renderer,
                                    GtkTreeModel      *model,
@@ -1068,16 +1311,17 @@ static void set_visible_if_not_text(GtkTreeViewColumn *col,
 
        gtk_tree_model_get(model, iter, SET_ICON_IS_TEXT, &is_text, -1);
        if (is_text) {
-               g_object_set(renderer, "visible", FALSE, NULL); 
+               g_object_set(renderer, "visible", FALSE, NULL);
        } else {
                pixbuf = NULL;
-               gtk_tree_model_get(model, iter, 
+               gtk_tree_model_get(model, iter,
                                   SET_ICON, &pixbuf,
                                   -1);
                /* note getting a pixbuf from a tree model increases
                 * its refcount ... */
-               g_object_unref(pixbuf);
-               
+               if (pixbuf != NULL)
+                       g_object_unref(pixbuf);
+
                g_object_set(renderer, "visible", TRUE, NULL);
                g_object_set(renderer, "pixbuf",  pixbuf, NULL);
        }
@@ -1091,7 +1335,7 @@ static GtkWidget *create_set_list_view(ToolbarPage *prefs_toolbar)
        GtkTreeViewColumn *column;
        GtkTreeSelection *selector;
 
-       store = gtk_list_store_new(N_SET_COLUMNS, 
+       store = gtk_list_store_new(N_SET_COLUMNS,
                                   GDK_TYPE_PIXBUF,
                                   G_TYPE_STRING,
                                   G_TYPE_STRING,
@@ -1106,16 +1350,16 @@ static GtkWidget *create_set_list_view(ToolbarPage *prefs_toolbar)
        gtk_tree_view_column_set_title(column, _("Icon"));
        renderer = gtk_cell_renderer_pixbuf_new();
        gtk_tree_view_column_pack_start(column, renderer, FALSE);
-       
-       /* tell pixbuf renderer it is only visible if 
+       gtk_tree_view_set_reorderable(list_view, TRUE);
+       /* tell pixbuf renderer it is only visible if
         * the icon is not represented by text */
        gtk_tree_view_column_set_cell_data_func(column, renderer,
                                                set_visible_if_not_text,
                                                NULL, NULL);
-       
+
        renderer = gtk_cell_renderer_text_new();
        gtk_tree_view_column_pack_start(column, renderer, FALSE);
-       
+
        /* tell the text renderer it is only visible if the icon
         * is represented by an image */
        gtk_tree_view_column_set_attributes(column, renderer,
@@ -1145,19 +1389,19 @@ static GtkWidget *create_set_list_view(ToolbarPage *prefs_toolbar)
 
        /* various other tree view attributes */
        gtk_tree_view_set_rules_hint(list_view, prefs_common.use_stripes_everywhere);
-       
+
        selector = gtk_tree_view_get_selection(list_view);
        gtk_tree_selection_set_mode(selector, GTK_SELECTION_BROWSE);
        gtk_tree_selection_set_select_function
                (selector, (GtkTreeSelectionFunc) set_list_selected,
                 prefs_toolbar, NULL);
 
-       return GTK_WIDGET(list_view);   
+       return GTK_WIDGET(list_view);
 
 }
 
 static gboolean set_list_selected(GtkTreeSelection *selector,
-                                 GtkTreeModel *model, 
+                                 GtkTreeModel *model,
                                  GtkTreePath *path,
                                  gboolean currently_selected,
                                  ToolbarPage *prefs_toolbar)
@@ -1169,22 +1413,22 @@ static gboolean set_list_selected(GtkTreeSelection *selector,
        GSList *cur2;
        gint item_num;
        GdkPixbuf *pix;
-       
+
        if (currently_selected || !gtk_tree_model_get_iter(model, &iter, path))
                return TRUE;
-       
+
        gtk_tree_model_get(model, &iter,
                           SET_ICON, &pix,
                           SET_TEXT, &icon_text,
                           SET_EVENT, &descr,
                           SET_FILENAME, &icon_file,
                           -1);
-       
+
        g_free(prefs_toolbar->item_icon_file);
        prefs_toolbar->item_icon_file = icon_file;
        gtk_button_set_image(GTK_BUTTON(prefs_toolbar->icon_button),
                             gtk_image_new_from_pixbuf(pix));
-       
+
        if (g_utf8_collate(toolbar_ret_descr_from_val(A_SEPARATOR), descr) == 0) {
                gtk_button_set_label(GTK_BUTTON(prefs_toolbar->icon_button),
                                    _("None"));
@@ -1194,15 +1438,17 @@ static gboolean set_list_selected(GtkTreeSelection *selector,
                                        ITEM_SEPARATOR);
                g_free(icon_text);
                g_free(descr);
+               if (pix != NULL)
+                       g_object_unref(pix);
 
                return TRUE;
        }
-       
+
        gtk_button_set_label(GTK_BUTTON(prefs_toolbar->icon_button), "");
-       gtk_entry_set_text(GTK_ENTRY(prefs_toolbar->item_text_entry), 
+       gtk_entry_set_text(GTK_ENTRY(prefs_toolbar->item_text_entry),
                           icon_text);
 
-       if (g_utf8_collate(toolbar_ret_descr_from_val(A_SYL_ACTIONS), descr) == 0) {
+       if (g_utf8_collate(toolbar_ret_descr_from_val(A_CLAWS_ACTIONS), descr) == 0) {
                gtk_combo_box_set_active(GTK_COMBO_BOX(
                        prefs_toolbar->item_type_combo), ITEM_USER_ACTION);
 
@@ -1210,7 +1456,7 @@ static gboolean set_list_selected(GtkTreeSelection *selector,
                    cur2 = cur2->next) {
                        gchar *item_string;
                        get_action_name((gchar *)cur2->data, &item_string);
-                       
+
                        if(g_utf8_collate(item_string, icon_text) == 0) {
                                gtk_combo_box_set_active(
                                        GTK_COMBO_BOX(prefs_toolbar->item_action_combo),
@@ -1223,22 +1469,44 @@ static gboolean set_list_selected(GtkTreeSelection *selector,
                                g_free(item_string);
                        }
                }
-               
+
+               gtk_widget_show(prefs_toolbar->item_action_combo);
+               gtk_widget_hide(prefs_toolbar->item_func_combo);
+               gtk_widget_hide(prefs_toolbar->item_plugin_combo);
+
                g_free(icon_text);
                g_free(descr);
+               if (pix != NULL)
+                       g_object_unref(pix);
+
+               return TRUE;
+       }
+
+       if (g_utf8_collate(toolbar_ret_descr_from_val(A_CLAWS_PLUGINS), descr) == 0) {
+               gtk_combo_box_set_active(GTK_COMBO_BOX(prefs_toolbar->item_type_combo), ITEM_PLUGIN);
+
+               gtk_combo_box_set_active(GTK_COMBO_BOX(prefs_toolbar->item_plugin_combo), 0);
+
+               gtk_widget_show(prefs_toolbar->item_plugin_combo);
+               gtk_widget_hide(prefs_toolbar->item_func_combo);
+               gtk_widget_hide(prefs_toolbar->item_action_combo);
 
+               g_free(descr);
+               g_free(icon_text);
+               if (pix != NULL)
+                       g_object_unref(pix);
                return TRUE;
        }
-       
+
        /* scan combo list for selected description an set combo item accordingly */
-       for (cur = prefs_toolbar->combo_action_list, item_num = 0; cur != NULL; 
+       for (cur = prefs_toolbar->combo_action_list, item_num = 0; cur != NULL;
             cur = cur->next) {
                gchar *item_str = (gchar*)cur->data;
                if (g_utf8_collate(item_str, descr) == 0) {
                        gtk_combo_box_set_active(
                                GTK_COMBO_BOX(prefs_toolbar->item_func_combo),
                                item_num);
-                       
+
                        break;
                }
                else
@@ -1247,9 +1515,13 @@ static gboolean set_list_selected(GtkTreeSelection *selector,
 
        gtk_combo_box_set_active(GTK_COMBO_BOX(
                        prefs_toolbar->item_type_combo),ITEM_FUNCTION);
+       gtk_widget_hide(prefs_toolbar->item_action_combo);
+       gtk_widget_show(prefs_toolbar->item_func_combo);
 
        g_free(icon_text);
        g_free(descr);
+       if (pix != NULL)
+               g_object_unref(pix);
 
        return TRUE;
 }
@@ -1259,16 +1531,23 @@ static void icon_chooser_ok_clicked(GtkButton *button,
 {
        GtkTreeModel *model;
        GtkTreeIter iter;
+       GList *list;
        GdkPixbuf *pix;
        gchar *icon_file;
-       
-       g_return_if_fail(prefs_toolbar != NULL);
-       
-       if (!gtk_tree_selection_get_selected(gtk_tree_view_get_selection
-                       (GTK_TREE_VIEW(prefs_toolbar->icon_chooser_list)),
-                       &model, &iter))
+
+       cm_return_if_fail(prefs_toolbar != NULL);
+
+       model = gtk_icon_view_get_model(GTK_ICON_VIEW(prefs_toolbar->icon_chooser_view));
+       list = gtk_icon_view_get_selected_items(GTK_ICON_VIEW(prefs_toolbar->icon_chooser_view));
+       if(list == NULL)
+               return;
+
+       if(!gtk_tree_model_get_iter(model, &iter, (GtkTreePath *)list->data)) {
+               gtk_tree_path_free(list->data);
+               g_list_free(list);
                return;
-       
+       }
+
        gtk_tree_model_get(model, &iter,
                           SET_ICON, &pix,
                           SET_FILENAME, &icon_file,
@@ -1276,29 +1555,33 @@ static void icon_chooser_ok_clicked(GtkButton *button,
 
        g_free(prefs_toolbar->item_icon_file);
        prefs_toolbar->item_icon_file = icon_file;
-
        gtk_button_set_image(GTK_BUTTON(prefs_toolbar->icon_button),
                             gtk_image_new_from_pixbuf(pix));
-       
+       if (pix != NULL)
+               g_object_unref(pix);
+
        gtk_widget_destroy(prefs_toolbar->icon_chooser_win);
        prefs_toolbar->icon_chooser_win = NULL;
-       prefs_toolbar->icon_chooser_list = NULL;
+       prefs_toolbar->icon_chooser_view = NULL;
+
+       gtk_tree_path_free(list->data);
+       g_list_free(list);
 }
 
 static void icon_chooser_cancel_clicked(GtkButton *button,
                                        ToolbarPage *prefs_toolbar)
 {
-       g_return_if_fail(prefs_toolbar != NULL);
+       cm_return_if_fail(prefs_toolbar != NULL);
 
        gtk_widget_destroy(prefs_toolbar->icon_chooser_win);
        prefs_toolbar->icon_chooser_win = NULL;
-       prefs_toolbar->icon_chooser_list = NULL;
+       prefs_toolbar->icon_chooser_view = NULL;
 }
 
 static gboolean icon_chooser_key_pressed(GtkWidget *widget, GdkEventKey *event,
                        ToolbarPage *prefs_toolbar)
 {
-       if (event && event->keyval == GDK_Escape) {
+       if (event && event->keyval == GDK_KEY_Escape) {
                icon_chooser_cancel_clicked(NULL, prefs_toolbar);
                return TRUE;
        }
@@ -1306,121 +1589,150 @@ static gboolean icon_chooser_key_pressed(GtkWidget *widget, GdkEventKey *event,
        return FALSE;
 }
 
-static void icon_chooser_tree_activated(GtkTreeView *treeview, GtkTreePath *path,
-                                    GtkTreeViewColumn *column, ToolbarPage *prefs_toolbar)
+static gboolean icon_list_key_pressed(GtkWidget *widget, GdkEventKey *event,
+                       ToolbarPage *prefs_toolbar)
+{
+       if (event) {
+               if (event->keyval == GDK_KEY_KP_Enter ||
+                   event->keyval == GDK_KEY_Return ||
+                   event->keyval == GDK_KEY_space) {
+                       icon_chooser_ok_clicked(NULL, prefs_toolbar);
+                       return TRUE;
+               }
+       }
+       return FALSE;
+}
+
+static gboolean ok_cb(gpointer data)
+{
+       ToolbarPage *prefs_toolbar = (ToolbarPage *)data;
+       icon_chooser_ok_clicked(NULL, prefs_toolbar);
+       return FALSE;
+}
+
+static gboolean icon_list_button_release(GtkWidget *widget,
+                                              GdkEventButton *event,
+                                              ToolbarPage *prefs_toolbar )
+{
+       static guint id = 0;
+       if (id > 0) {
+               g_source_remove(id);
+               id = 0;
+       }
+       id = g_timeout_add(100, ok_cb, prefs_toolbar);
+       return FALSE;
+}
+
+static gboolean icon_window_button_press(GtkWidget *widget,
+                                              GdkEventButton *event,
+                                              ToolbarPage *prefs_toolbar )
+{
+       GtkWidget *event_widget;
+       gboolean restore = TRUE;
+
+       /* Test where mouse was clicked */
+       event_widget = gtk_get_event_widget((GdkEvent *)event);
+       if (event_widget != widget) {
+               while (event_widget) {
+                       if (event_widget == widget)
+                               return FALSE;
+                       else if (event_widget == prefs_toolbar->icon_chooser_win) {
+                               restore = FALSE;
+                               break;
+                       }
+                       event_widget = gtk_widget_get_parent(event_widget);
+               }
+       }
+
+       if (restore) {
+               icon_chooser_cancel_clicked(NULL, prefs_toolbar);
+               return TRUE;
+       }
+       return FALSE;
+}
+
+static void icon_chooser_activated(GtkTreeView *treeview, GtkTreePath *path,
+                               ToolbarPage *prefs_toolbar)
 {
        icon_chooser_ok_clicked(NULL, prefs_toolbar);
 }
 
 static void icon_chooser_create(GtkButton *button, ToolbarPage *prefs_toolbar)
 {
-       static GtkWidget *icon_chooser_win;
-       GtkWidget *label;
+       GtkAllocation allocation;
+       GtkWidget *icon_chooser_win;
        GtkWidget *scrollwin;
-       GtkWidget *vbox;
-       GtkWidget *confirm_area;
-       GtkWidget *ok_btn;
-       GtkWidget *cancel_btn;
-       GtkTreeView *list_view;
+       GtkWidget *icon_view;
        GtkListStore *store;
-       GtkTreeSelection *selector;
-       GtkTreeViewColumn *column;
-       GtkCellRenderer *renderer;
        GtkTreeIter iter;
-       gint i;
-       
-       store = gtk_list_store_new(2, 
+       gint i, x, y;
+
+       store = gtk_list_store_new(2,
                                   GDK_TYPE_PIXBUF,
                                   G_TYPE_STRING,
                                   -1);
-                                  
+
        gtk_list_store_clear(store);
 
        for (i = 0; ToolbarIcons[i] != STOCK_PIXMAP_EMPTY; i++) {
                GdkPixbuf *pixbuf;
-               stock_pixbuf_gdk(prefs_toolbar->window, ToolbarIcons[i], &pixbuf);
-               
+               stock_pixbuf_gdk(ToolbarIcons[i], &pixbuf);
+
                gtk_list_store_append(store, &iter);
                gtk_list_store_set(store, &iter,
                                   SET_ICON, pixbuf,
                                   SET_FILENAME, stock_pixmap_get_name((StockPixmap) ToolbarIcons[i]),
                                   -1);
        }
-       
+
        icon_chooser_win = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "prefs_toolbar");
        gtk_window_set_title(GTK_WINDOW(icon_chooser_win), _("Toolbar item icon"));
-       gtk_window_set_position(GTK_WINDOW(icon_chooser_win), GTK_WIN_POS_CENTER);
+       gtk_window_set_decorated(GTK_WINDOW(icon_chooser_win), FALSE);
+       gdk_window_get_origin(gtk_widget_get_window(
+                       GTK_WIDGET(prefs_toolbar->icon_button)),
+                       &x, &y);
+       gtk_widget_get_allocation(GTK_WIDGET(prefs_toolbar->icon_button), &allocation);
+       x += allocation.x;
+       y += allocation.y;
+       y += 50;
+       x -= 300-50;
+       gtk_window_move(GTK_WINDOW(icon_chooser_win), x, y);
        gtk_window_set_resizable(GTK_WINDOW(icon_chooser_win), FALSE);
-       gtk_widget_set_size_request(icon_chooser_win, 300, 250);
-       
-       vbox = gtk_vbox_new(FALSE, 5);
-       gtk_widget_show(vbox);
-       gtk_container_set_border_width(GTK_CONTAINER(vbox), VBOX_BORDER);
-       gtk_container_add(GTK_CONTAINER(icon_chooser_win), vbox);
-       
-       label = gtk_label_new(_("Choose icon:"));
-       gtk_widget_show(label);
-       gtk_misc_set_alignment(GTK_MISC(label), 0, -1);
-       gtk_box_pack_start(GTK_BOX(vbox), label, FALSE, FALSE, 0);
-       
+       gtk_widget_set_size_request(icon_chooser_win, 300, 320);
+
        scrollwin = gtk_scrolled_window_new(NULL, NULL);
+       gtk_container_add(GTK_CONTAINER(icon_chooser_win), scrollwin);
        gtk_widget_show(scrollwin);
-       gtk_box_pack_start(GTK_BOX(vbox), scrollwin, TRUE, TRUE, 0);
        gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrollwin),
-                               GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
-       
-       list_view = GTK_TREE_VIEW(gtk_tree_view_new_with_model(GTK_TREE_MODEL(store)));
-       gtk_widget_show(GTK_WIDGET(list_view));
-       
-       column = gtk_tree_view_column_new();
-
-       renderer = gtk_cell_renderer_pixbuf_new();
-       gtk_tree_view_column_pack_start(column, renderer, FALSE);
-       gtk_tree_view_column_set_attributes(column, renderer,
-                                           "pixbuf", SET_ICON, 
-                                           NULL);
+                               GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
+       gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(scrollwin),
+                               GTK_SHADOW_OUT);
 
-       gtk_tree_view_append_column(list_view, column);
+       icon_view = gtk_icon_view_new_with_model(GTK_TREE_MODEL(store));
+       gtk_icon_view_set_selection_mode(GTK_ICON_VIEW(icon_view), GTK_SELECTION_SINGLE);
+       gtk_icon_view_set_pixbuf_column(GTK_ICON_VIEW(icon_view), SET_ICON);
+       gtk_container_add(GTK_CONTAINER(scrollwin), GTK_WIDGET(icon_view));
 
-       column = gtk_tree_view_column_new();
-       renderer = gtk_cell_renderer_text_new();
-       gtk_tree_view_column_pack_start(column, renderer, TRUE);
-       gtk_tree_view_column_set_attributes(column, renderer,
-                                           "text", SET_FILENAME,
-                                           NULL);
-       
-       gtk_tree_view_append_column(list_view, column);
-
-       gtk_tree_view_set_rules_hint(list_view, prefs_common.use_stripes_everywhere);
-       gtk_tree_view_set_headers_visible(list_view, FALSE);
-       
-       selector = gtk_tree_view_get_selection(list_view);
-       gtk_tree_selection_set_mode(selector, GTK_SELECTION_SINGLE);
-
-       gtk_tree_model_get_iter_first(GTK_TREE_MODEL(store), &iter);
-       gtk_tree_selection_select_iter(gtk_tree_view_get_selection
-                                               (list_view), &iter);
-       gtk_container_add(GTK_CONTAINER(scrollwin), GTK_WIDGET(list_view));
-
-       gtkut_stock_button_set_create(&confirm_area, &cancel_btn, GTK_STOCK_CANCEL,
-                                     &ok_btn, GTK_STOCK_OK, NULL, NULL);
-
-       gtk_box_pack_start(GTK_BOX(vbox), confirm_area, FALSE, FALSE, 0);
-       gtk_widget_show(confirm_area);
-       gtk_widget_grab_default(ok_btn);
-
-       g_signal_connect(G_OBJECT(ok_btn), "clicked",
-                        G_CALLBACK(icon_chooser_ok_clicked), prefs_toolbar);
-       g_signal_connect(G_OBJECT(cancel_btn), "clicked",
-                        G_CALLBACK(icon_chooser_cancel_clicked), prefs_toolbar);
        g_signal_connect(G_OBJECT(icon_chooser_win), "key_press_event",
                         G_CALLBACK(icon_chooser_key_pressed), prefs_toolbar);
-       g_signal_connect(G_OBJECT(list_view), "row-activated",
-                        G_CALLBACK(icon_chooser_tree_activated), prefs_toolbar);
+       g_signal_connect(G_OBJECT(icon_view), "item-activated",
+                        G_CALLBACK(icon_chooser_activated), prefs_toolbar);
+       g_signal_connect(G_OBJECT(icon_chooser_win),
+                        "button-press-event",
+                        G_CALLBACK(icon_window_button_press),
+                        prefs_toolbar );
+       g_signal_connect(G_OBJECT(icon_view),
+                        "button-release-event",
+                        G_CALLBACK(icon_list_button_release),
+                        prefs_toolbar );
+       g_signal_connect(G_OBJECT(icon_view), "key_press_event",
+                        G_CALLBACK(icon_list_key_pressed), prefs_toolbar);
 
        gtk_widget_show_all(icon_chooser_win);
+       gtk_widget_grab_focus(GTK_WIDGET(icon_view));
+       manage_window_set_transient(GTK_WINDOW(icon_chooser_win));
        gtk_window_set_modal(GTK_WINDOW(icon_chooser_win), TRUE);
-       
+
        prefs_toolbar->icon_chooser_win         = icon_chooser_win;
-       prefs_toolbar->icon_chooser_list        = GTK_WIDGET(list_view);
+       prefs_toolbar->icon_chooser_view        = icon_view;
 }