Remove unnecessary “Use this” for changing theme
[claws.git] / src / prefs_themes.c
index ddce4add7f4883467f0086eb8b1824a02628adeb..3b6a44c6b1d0f84227cb7bb7f1efea20653ab5bb 100644 (file)
@@ -1,10 +1,10 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 2003-2007 Hiroyuki Yamamoto & the Claws Mail team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 2003-2015 Hiroyuki Yamamoto & the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
@@ -13,8 +13,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifdef HAVE_CONFIG_H
@@ -45,6 +44,7 @@
 #include "mainwindow.h"
 #include "compose.h"
 #include "alertpanel.h"
+#include "addr_compl.h"
 
 #define IS_CURRENT_THEME(path)  (strcmp(prefs_common.pixmap_theme_path, path) == 0)
 #define IS_INTERNAL_THEME(path) (strcmp(DEFAULT_PIXMAP_THEME, path) == 0)
@@ -67,16 +67,12 @@ typedef struct _ThemesPage
        GtkWidget *author;
        GtkWidget *url;
        GtkWidget *status;
-       
+
        GtkWidget *icons[PREVIEW_ICONS];
-       
-       GtkWidget *btn_use;
-       GtkWidget *btn_remove;
 
-       GdkPixmap *pixmaps[PREVIEW_ICONS];
-       GdkBitmap *masks[PREVIEW_ICONS];
+       GtkWidget *btn_remove;
 
-       /* gchar     *theme_path; */
+       GdkPixbuf *pixbufs[PREVIEW_ICONS];
 } ThemesPage;
 
 typedef struct _ThemeInfo
@@ -128,7 +124,6 @@ StockPixmap prefs_themes_icons[PREVIEW_ICONS] = {
 
 
 
-static void prefs_themes_btn_use_clicked_cb    (GtkWidget *widget, gpointer data);
 static void prefs_themes_btn_remove_clicked_cb (GtkWidget *widget, gpointer data);
 static void prefs_themes_btn_install_clicked_cb        (GtkWidget *widget, gpointer data);
 static void prefs_themes_menu_item_activated_cb        (GtkWidget *widget, gpointer data);
@@ -141,7 +136,7 @@ static void prefs_themes_get_themes_and_names       (ThemesData *tdata);
 static int prefs_themes_cmp_name(gconstpointer a, gconstpointer b);
 static void prefs_themes_free_names            (ThemesData *tdata);
 
-static void prefs_themes_set_themes_menu       (GtkOptionMenu *opmenu, const ThemesData *tdata);
+static void prefs_themes_set_themes_menu       (GtkComboBox *combo, const ThemesData *tdata);
 
 static gchar *prefs_themes_get_theme_stats     (const gchar *dirname);
 static gboolean prefs_themes_is_system_theme   (const gchar *dirname);
@@ -159,17 +154,19 @@ static void prefs_themes_file_install             (const gchar *filename, gpointer data);
 
 static void prefs_themes_file_stats(const gchar *filename, gpointer data)
 {
-       struct stat s;
-       DirInfo    *di = (DirInfo *)data;
-       gint        len;
-       
-       if (0 == stat(filename, &s) && 0 != S_ISREG(s.st_mode)) {
+       GStatBuf s;
+       DirInfo *di = (DirInfo *)data;
+       gint len;
+
+       if (0 == g_stat(filename, &s) && 0 != S_ISREG(s.st_mode)) {
                di->bytes += s.st_size;
                di->files++;
                len = strlen(filename);
                if (len > 4) {
-                       if (filename[len - 1] == 'm' && filename[len - 2] == 'p' &&
-                           filename[len - 3] == 'x' && filename[len - 4] == '.')
+                       const gchar *extension = filename+(len-4);
+                       if (!strcmp(extension, ".xpm"))
+                               di->pixms++;
+                       else if (!strcmp(extension, ".png"))
                                di->pixms++;
                }
        }
@@ -179,17 +176,17 @@ static void prefs_themes_file_remove(const gchar *filename, gpointer data)
 {
        gchar **status = (gchar **)data;
        gchar *base;
-       
+
        if ((*status) != NULL)
                return;
-       
+
        base = g_path_get_basename(filename);
        if (TRUE == is_dir_exist(filename)) {
                if (strcmp(base, ".") != 0 && strcmp(base, "..") != 0)
                        g_warning("prefs_themes_file_remove(): subdir in theme dir skipped: '%s'.\n",
                                                base);
        }
-       else if (0 != g_unlink(filename)) {
+       else if (0 != claws_unlink(filename)) {
                (*status) = g_strdup(filename);
        }
        g_free(base);
@@ -199,10 +196,10 @@ static void prefs_themes_file_install(const gchar *filename, gpointer data)
 {
        CopyInfo *ci = (CopyInfo *)data;
        gchar *base;
-       
+
        if (ci->status != NULL)
                return;
-       
+
        base = g_path_get_basename(filename);
        if (TRUE == is_dir_exist(filename)) {
                if (strcmp(base, ".") != 0 && strcmp(base, "..") !=0 )
@@ -211,9 +208,9 @@ static void prefs_themes_file_install(const gchar *filename, gpointer data)
        }
        else {
                gchar *fulldest;
-               
+
                fulldest = g_strconcat(ci->dest, G_DIR_SEPARATOR_S, base, NULL);
-               
+
                if (0 != copy_file(filename, fulldest, FALSE)) {
                        ci->status = g_strdup(filename);
                }
@@ -227,11 +224,11 @@ static void prefs_themes_foreach_file(const gchar *dirname, const FileFunc func,
        struct dirent *d;
        DIR           *dp;
 
-       g_return_if_fail(dirname != NULL);
-       g_return_if_fail(func != NULL);
-       
+       cm_return_if_fail(dirname != NULL);
+       cm_return_if_fail(func != NULL);
+
        if ((dp = opendir(dirname)) == NULL) {
-               debug_print("directory %s not found", dirname);
+               debug_print("directory %s not found\n", dirname);
                return;
        }
 
@@ -243,61 +240,64 @@ static void prefs_themes_foreach_file(const gchar *dirname, const FileFunc func,
                fullentry = g_strconcat(dirname, G_DIR_SEPARATOR_S, entry, NULL);
 
                (*func)(fullentry, data);
-               
+
                g_free(fullentry);
-       }       
+       }
+       closedir(dp);
 }
 
 static gboolean prefs_themes_is_system_theme(const gchar *dirname)
 {
        gint len;
-       
-       g_return_val_if_fail(dirname != NULL, FALSE);
+       gchar *system_theme_dir;
+       gboolean is_sys = FALSE;
 
-       len = strlen(PACKAGE_DATA_DIR);
-       if (strlen(dirname) > len && 0 == strncmp(dirname, PACKAGE_DATA_DIR, len))
-               return TRUE;
-       
-       return FALSE;
+       cm_return_val_if_fail(dirname != NULL, FALSE);
+
+       system_theme_dir = stock_pixmap_get_system_theme_dir_for_theme(NULL);
+       len = strlen(system_theme_dir);
+       if (strlen(dirname) > len && 0 == strncmp(dirname, system_theme_dir, len))
+               is_sys = TRUE;
+
+       g_free(system_theme_dir);
+
+       return is_sys;
 }
 
-static void prefs_themes_set_themes_menu(GtkOptionMenu *opmenu, const ThemesData *tdata)
+static void prefs_themes_set_themes_menu(GtkComboBox *combo, const ThemesData *tdata)
 {
+       GtkListStore *store;
+       GtkTreeIter iter;
        GList     *themes = tdata->names;
-       GtkWidget *menu;
-       GtkWidget *item;
        gint       i = 0, active = 0;
        GList     *sorted_list = NULL;
 
-       g_return_if_fail(opmenu != NULL);
-
-       gtk_option_menu_remove_menu(opmenu);
+       cm_return_if_fail(combo != NULL);
 
        /* sort theme data list by data name */
-       menu = gtk_menu_new ();
        while (themes != NULL) {
                ThemeName *tname = (ThemeName *)(themes->data);
 
                sorted_list = g_list_insert_sorted(sorted_list, (gpointer)(tname),
-                                                                               (GCompareFunc)prefs_themes_cmp_name);
+                                                  (GCompareFunc)prefs_themes_cmp_name);
 
                themes = g_list_next(themes);
        }
 
+       store = gtk_list_store_new(2, G_TYPE_STRING, G_TYPE_POINTER);
+
        /* feed gtk_menu w/ sorted themes names */
        themes = sorted_list;
        while (themes != NULL) {
                ThemeName *tname = (ThemeName *)(themes->data);
                gchar     *tpath = (gchar *)(tname->item->data);
 
-               item = gtk_menu_item_new_with_label(tname->name);
-               gtk_widget_show(item);
-               g_signal_connect(G_OBJECT(item), "activate",
-                                G_CALLBACK(prefs_themes_menu_item_activated_cb),
-                                tname->item->data);
-               gtk_menu_append(GTK_MENU(menu), item);
+               gtk_list_store_append(store, &iter);
+               gtk_list_store_set(store, &iter,
+                                  0, tname->name,
+                                  1, tname->item->data, -1);
 
-               if (tdata->displayed != NULL && tdata->displayed == tpath)
+               if (tdata->displayed != NULL && !strcmp2(tdata->displayed,tpath))
                        active = i;
                ++i;
 
@@ -306,8 +306,12 @@ static void prefs_themes_set_themes_menu(GtkOptionMenu *opmenu, const ThemesData
 
        g_list_free(sorted_list);
 
-       gtk_menu_set_active(GTK_MENU(menu), active);
-       gtk_option_menu_set_menu (opmenu, menu);
+       g_signal_connect(G_OBJECT(combo), "changed",
+                        G_CALLBACK(prefs_themes_menu_item_activated_cb),
+                        NULL);
+
+       gtk_combo_box_set_model(combo, GTK_TREE_MODEL(store));
+       gtk_combo_box_set_active(combo, active);
 }
 
 static int prefs_themes_cmp_name(gconstpointer a_p, gconstpointer b_p)
@@ -320,27 +324,27 @@ static int prefs_themes_cmp_name(gconstpointer a_p, gconstpointer b_p)
 static void prefs_themes_get_themes_and_names(ThemesData *tdata)
 {
        GList *tpaths;
-       
-       g_return_if_fail(tdata != NULL);
-       
+
+       cm_return_if_fail(tdata != NULL);
+
        if (tdata->themes != NULL)
                stock_pixmap_themes_list_free(tdata->themes);
        if (tdata->names != NULL)
                prefs_themes_free_names(tdata);
-       
+
        tdata->themes = stock_pixmap_themes_list_new();
-       
+
        tpaths = tdata->themes;
        while (tpaths != NULL) {
                ThemeName *name = g_new0(ThemeName, 1);
                gchar *sname = g_path_get_basename((const gchar *)(tpaths->data));
-               
+
                if (IS_INTERNAL_THEME(sname))
                        name->name = g_strdup(_("Default internal theme"));
                else
                        name->name = g_strdup(sname);
                name->item = tpaths;
-                       
+
                tdata->names = g_list_append(tdata->names, name);
                if (!strcmp2(tpaths->data, prefs_common.pixmap_theme_path)) {
                        tdata->displayed = (gchar *)tpaths->data;
@@ -362,14 +366,14 @@ void prefs_themes_init(void)
        path[2] = NULL;
 
        debug_print("Creating preferences for themes...\n");
-       
+
        tdata = g_new0(ThemesData, 1);
        prefs_themes_data = tdata;
 
        prefs_themes_get_themes_and_names(tdata);
-       
+
        page = g_new0(ThemesPage, 1);
-       
+
        page->page.path = path;
        page->page.create_widget = prefs_themes_create_widget;
        page->page.destroy_widget = prefs_themes_destroy_widget;
@@ -387,18 +391,18 @@ void prefs_themes_init(void)
 static void prefs_themes_free_names(ThemesData *tdata)
 {
        GList *names;
-       
+
        names = tdata->names;
        while (names != NULL) {
                ThemeName *tn = (ThemeName *)(names->data);
-               
+
                tn->item = NULL;
                g_free(tn->name);
                g_free(tn);
-               
+
                names = g_list_next(names);
        }
-       g_list_free(names);
+       g_list_free(tdata->names);
        tdata->names = NULL;
 }
 
@@ -407,30 +411,13 @@ void prefs_themes_done(void)
        ThemesData *tdata = prefs_themes_data;
 
        debug_print("Finished preferences for themes.\n");
-       
+
        stock_pixmap_themes_list_free(tdata->themes);
-       prefs_themes_free_names(tdata); 
+       prefs_themes_free_names(tdata); 
        g_free(tdata->page);
        g_free(tdata);
 }
 
-static void prefs_themes_btn_use_clicked_cb(GtkWidget *widget, gpointer data)
-{
-       ThemesData *tdata = prefs_themes_data;
-       gchar      *theme_str;
-
-       theme_str = tdata->displayed;
-       
-               g_free(prefs_common.pixmap_theme_path);
-       
-        prefs_common.pixmap_theme_path = g_strdup(theme_str);
-       
-        main_window_reflect_prefs_all_real(TRUE);
-        compose_reflect_prefs_pixmap_theme();
-       
-       prefs_themes_update_buttons(tdata);
-}
-
 static void prefs_themes_btn_remove_clicked_cb(GtkWidget *widget, gpointer data)
 {
        ThemesData *tdata = prefs_themes_data;
@@ -440,11 +427,11 @@ static void prefs_themes_btn_remove_clicked_cb(GtkWidget *widget, gpointer data)
        gchar      *tmp = NULL;
 
        theme_str = tdata->displayed;
-       
+
        tmp = g_path_get_basename(theme_str);
 
        if (IS_SYSTEM_THEME(theme_str)) {
-               if (getuid() != 0) {
+               if (!superuser_p()) {
                        alertpanel_error(_("Only root can remove system themes"));
                        return;
                }
@@ -463,7 +450,7 @@ static void prefs_themes_btn_remove_clicked_cb(GtkWidget *widget, gpointer data)
 
        if (G_ALERTALTERNATE == val) {
                gchar *status = NULL;
-               
+
                prefs_themes_foreach_file(theme_str, prefs_themes_file_remove, &status); 
                if (0 != rmdir(theme_str)) {
                        if (status != NULL) {
@@ -474,10 +461,10 @@ static void prefs_themes_btn_remove_clicked_cb(GtkWidget *widget, gpointer data)
                                alertpanel_error(_("Removing theme directory failed."));
                }
                else {  
-                       alertpanel_notice(_("Theme removed succesfully"));
+                       alertpanel_notice(_("Theme removed successfully"));
                        /* update interface back to first theme */
                        prefs_themes_get_themes_and_names(tdata);
-                       prefs_themes_set_themes_menu(GTK_OPTION_MENU(tdata->page->op_menu), tdata);
+                       prefs_themes_set_themes_menu(GTK_COMBO_BOX(tdata->page->op_menu), tdata);
                        prefs_themes_display_global_stats(tdata);
                        tdata->displayed = (gchar *)((g_list_first(tdata->themes))->data);
                        prefs_themes_get_theme_info(tdata);
@@ -493,11 +480,11 @@ static void prefs_themes_btn_install_clicked_cb(GtkWidget *widget, gpointer data
        CopyInfo   *cinfo;
        AlertValue  val = 0;
        ThemesData *tdata = prefs_themes_data;
-       
+
        filename = filesel_select_file_open_folder(_("Select theme folder"), NULL);
        if (filename == NULL) 
                return;
-       
+
        if (filename[strlen(filename) - 1] != G_DIR_SEPARATOR)
                filename = g_strconcat(filename, G_DIR_SEPARATOR_S, NULL);
        else
@@ -517,15 +504,14 @@ static void prefs_themes_btn_install_clicked_cb(GtkWidget *widget, gpointer data
                if (G_ALERTALTERNATE != val)
                        goto end_inst;
        }
-       if (getuid() == 0) {
+       if (superuser_p ()) {
                val = alertpanel(alert_title,
                                 _("Do you want to install theme for all users?"),
                                 GTK_STOCK_NO, GTK_STOCK_YES, NULL);
                switch (val) {
                case G_ALERTALTERNATE:
-                       cinfo->dest = g_strconcat(PACKAGE_DATA_DIR, G_DIR_SEPARATOR_S,
-                                                 PIXMAP_THEME_DIR, G_DIR_SEPARATOR_S, 
-                                                 themename, NULL);
+                       cinfo->dest = stock_pixmap_get_system_theme_dir_for_theme(
+                                               themename);
                        break;
                case G_ALERTDEFAULT:
                        break;
@@ -535,16 +521,27 @@ static void prefs_themes_btn_install_clicked_cb(GtkWidget *widget, gpointer data
        }
        g_free(alert_title);
        if (cinfo->dest == NULL) {
-               cinfo->dest = g_strconcat(get_home_dir(), G_DIR_SEPARATOR_S, RC_DIR,
-                                         G_DIR_SEPARATOR_S, PIXMAP_THEME_DIR, G_DIR_SEPARATOR_S,
+               cinfo->dest = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S,
+                                         PIXMAP_THEME_DIR, G_DIR_SEPARATOR_S,
                                          themename, NULL);
        }
        if (TRUE == is_dir_exist(cinfo->dest)) {
-               alertpanel_error(_("A theme with the same name is\nalready installed in this location"));
-               goto end_inst;
+               AlertValue val = alertpanel_full(_("Theme exists"),
+                               _("A theme with the same name is\nalready installed in this location.\n\n"
+                                 "Do you want to replace it?"),
+                               GTK_STOCK_CANCEL, _("Overwrite"), NULL, FALSE,
+                               NULL, ALERT_WARNING, G_ALERTDEFAULT);
+               if (val == G_ALERTALTERNATE) {
+                       if (remove_dir_recursive(cinfo->dest) < 0) {
+                               alertpanel_error(_("Couldn't delete the old theme in %s."), cinfo->dest);
+                               goto end_inst;
+                       }
+               } else {
+                       goto end_inst;
+               }
        }
        if (0 != make_dir_hier(cinfo->dest)) {
-               alertpanel_error(_("Couldn't create destination directory"));
+               alertpanel_error(_("Couldn't create destination directory %s."), cinfo->dest);
                goto end_inst;
        }
        prefs_themes_foreach_file(source, prefs_themes_file_install, cinfo);
@@ -557,9 +554,9 @@ static void prefs_themes_btn_install_clicked_cb(GtkWidget *widget, gpointer data
                                            (gpointer)(cinfo->dest), 
                                            (GCompareFunc)strcmp2);
                if (NULL != insted) {
-                       alertpanel_notice(_("Theme installed succesfully"));
+                       alertpanel_notice(_("Theme installed successfully."));
                        tdata->displayed = (gchar *)(insted->data);
-                       prefs_themes_set_themes_menu(GTK_OPTION_MENU(tdata->page->op_menu), tdata);
+                       prefs_themes_set_themes_menu(GTK_COMBO_BOX(tdata->page->op_menu), tdata);
                        prefs_themes_display_global_stats(tdata);
                        prefs_themes_get_theme_info(tdata);
                }
@@ -580,10 +577,15 @@ end_inst:
 static void prefs_themes_menu_item_activated_cb(GtkWidget *widget, gpointer data)
 {
        ThemesData *tdata = prefs_themes_data;
-       gchar      *path = (gchar *)data;
-       
-       g_return_if_fail(path != NULL);
-       
+       gchar      *path;
+       GtkTreeModel *model;
+       GtkTreeIter iter;
+
+       cm_return_if_fail(gtk_combo_box_get_active_iter(GTK_COMBO_BOX(widget), &iter));
+
+       model = gtk_combo_box_get_model(GTK_COMBO_BOX(widget));
+       gtk_tree_model_get(model, &iter, 1, &path, -1);
+
        tdata->displayed = path;
        prefs_themes_get_theme_info(tdata);
 }
@@ -595,9 +597,7 @@ static void prefs_themes_update_buttons(const ThemesData *tdata)
 
        can_use = !IS_CURRENT_THEME(tdata->displayed);
        can_rem = can_use && !IS_INTERNAL_THEME(tdata->displayed);
-       
-       if (theme->btn_use != NULL)
-               gtk_widget_set_sensitive(theme->btn_use, can_use);
+
        if (theme->btn_remove != NULL)
                gtk_widget_set_sensitive(theme->btn_remove, can_rem);
 }
@@ -631,10 +631,10 @@ static void prefs_themes_display_theme_info(ThemesData *tdata, const ThemeInfo *
        save_prefs_path = prefs_common.pixmap_theme_path;
        prefs_common.pixmap_theme_path = tdata->displayed;
        for (i = 0; i < PREVIEW_ICONS; ++i) {
-               stock_pixmap_gdk(theme->window, prefs_themes_icons[i], 
-                               &(theme->pixmaps[i]), &(theme->masks[i]));
-               gtk_image_set_from_pixmap(GTK_IMAGE(theme->icons[i]),
-                               theme->pixmaps[i], theme->masks[i]);
+               stock_pixbuf_gdk(theme->window, prefs_themes_icons[i], 
+                               &(theme->pixbufs[i]));
+               gtk_image_set_from_pixbuf(GTK_IMAGE(theme->icons[i]),
+                               theme->pixbufs[i]);
        }
        prefs_common.pixmap_theme_path = save_prefs_path;
 
@@ -675,12 +675,11 @@ static void prefs_themes_display_global_stats(const ThemesData *tdata)
 
 #define FGETS_INFOFILE_LINE() \
        line[0] = '\0'; \
-       fgets(line, INFOFILE_LINE_LEN, finfo); \
-       if ((len = strlen(line)) > 0) { \
+       if (fgets(line, INFOFILE_LINE_LEN, finfo) != NULL && (len = strlen(line)) > 0) { \
                if (line[len - 1] == '\n') line[len - 1] = '\0'; \
        } \
        else { \
-               strcpy(line, _("Unknown")); \
+               g_strlcpy(line, _("Unknown"),sizeof(line)); \
        }
 
 static void prefs_themes_get_theme_info(ThemesData *tdata)
@@ -693,14 +692,14 @@ static void prefs_themes_get_theme_info(ThemesData *tdata)
        ThemeInfo *info;
        ThemesPage *theme = tdata->page;
 
-       g_return_if_fail(theme != NULL);
+       cm_return_if_fail(theme != NULL);
        path = tdata->displayed;
-       g_return_if_fail(path != NULL);
+       cm_return_if_fail(path != NULL);
 
        debug_print("Getting theme info for %s\n", path);
-       
+
        info = g_new0(ThemeInfo, 1);
-       
+
        if (IS_INTERNAL_THEME(path)) {
                info->name = g_strdup(_("Default internal theme"));
                info->author = g_strdup(_("The Claws Mail Team"));
@@ -739,7 +738,7 @@ static void prefs_themes_get_theme_info(ThemesData *tdata)
        g_free(info->author);
        g_free(info->url);
        g_free(info->status);
-       
+
        g_free(info);
 }
 
@@ -754,46 +753,12 @@ static gchar *prefs_themes_get_theme_stats(const gchar *dirname)
        
        prefs_themes_foreach_file(dirname, prefs_themes_file_stats, dinfo);
        stats = g_strdup_printf(_("%d files (%d icons), size: %s"), 
-                               dinfo->files, dinfo->pixms, to_human_readable(dinfo->bytes));
+                               dinfo->files, dinfo->pixms, to_human_readable((goffset)dinfo->bytes));
        
        g_free(dinfo);
        return stats;
 }
 
-/* BEGIN GLADE CODE */
-/* This is a dummy pixmap we use when a pixmap can't be found. */
-static char *dummy_pixmap_xpm[] = {
-       /* columns rows colors chars-per-pixel */
-       "1 1 1 1",
-       "  c None",
-       /* pixels */
-       " "
-};
-
-/* This is an internally used function to create pixmaps. */
-static GtkWidget* create_dummy_pixmap(GtkWidget *widget)
-{
-       GdkColormap *colormap;
-       GdkPixmap *gdkpixmap;
-       GdkBitmap *mask;
-       GtkWidget *pixmap;
-
-       colormap = gtk_widget_get_colormap (widget);
-       gdkpixmap = gdk_pixmap_colormap_create_from_xpm_d (NULL, colormap, &mask,
-                       NULL, dummy_pixmap_xpm);
-       if (gdkpixmap == NULL)
-               g_error ("Couldn't create replacement pixmap.");
-       pixmap = gtk_image_new_from_pixmap(gdkpixmap, mask);
-       g_object_unref (gdkpixmap);
-       g_object_unref (mask);
-       return pixmap;
-}
-/* END GLADE CODE */
-
-/* glade generates some calls to a create_pixmap support function 
- * we don't really need. */
-#define create_pixmap(widget,filename) create_dummy_pixmap(widget)
-
 static void prefs_themes_create_widget(PrefsPage *page, GtkWindow *window, gpointer data)
 {
        ThemesPage *prefs_themes = (ThemesPage *)page;
@@ -804,8 +769,6 @@ static void prefs_themes_create_widget(PrefsPage *page, GtkWindow *window, gpoin
        GtkWidget *vbox2;
        GtkWidget *hbox3;
        GtkWidget *menu_themes;
-       GtkWidget *menu_themes_menu;
-       GtkWidget *glade_menuitem;
        GtkWidget *btn_install;
        GtkWidget *btn_more;
        GtkWidget *label_global_status;
@@ -830,38 +793,28 @@ static void prefs_themes_create_widget(PrefsPage *page, GtkWindow *window, gpoin
        GtkWidget *icon_7;
        GtkWidget *frame_buttons;
        GtkWidget *hbuttonbox1;
-       GtkWidget *btn_use;
        GtkWidget *btn_remove;
+       GtkCellRenderer *renderer;
 
        vbox1 = gtk_vbox_new (FALSE, VSPACING);
        gtk_container_set_border_width (GTK_CONTAINER (vbox1), VBOX_BORDER);
        gtk_widget_show (vbox1);
 
-       PACK_FRAME (vbox1, frame1, _("Selector"));
-
-       vbox2 = gtk_vbox_new (FALSE, VSPACING);
-       gtk_container_set_border_width (GTK_CONTAINER (vbox2), VBOX_BORDER);
-       gtk_widget_show (vbox2);
-       gtk_container_add (GTK_CONTAINER (frame1), vbox2);
+       vbox2 = gtkut_get_options_frame(vbox1, &frame1, _("Selector"));
 
        hbox3 = gtk_hbox_new (FALSE, 5);
        gtk_widget_show (hbox3);
        gtk_box_pack_start (GTK_BOX (vbox2), hbox3, FALSE, FALSE, 0);
        gtk_container_set_border_width (GTK_CONTAINER (hbox3), 5);
 
-       menu_themes = gtk_option_menu_new ();
+       menu_themes = gtk_combo_box_new();
        gtk_widget_show (menu_themes);
        gtk_box_pack_start (GTK_BOX (hbox3), menu_themes, FALSE, FALSE, 0);
-       menu_themes_menu = gtk_menu_new ();
-       glade_menuitem = gtk_menu_item_new_with_label ("");
-       gtk_widget_show (glade_menuitem);
-       gtk_menu_append (GTK_MENU (menu_themes_menu), glade_menuitem);
-       gtk_option_menu_set_menu (GTK_OPTION_MENU (menu_themes), menu_themes_menu);
 
        btn_install = gtk_button_new_with_label (_("Install new..."));
        gtk_widget_show (btn_install);
        gtk_box_pack_start (GTK_BOX (hbox3), btn_install, FALSE, FALSE, 0);
-       GTK_WIDGET_SET_FLAGS (btn_install, GTK_CAN_DEFAULT);
+       gtkut_widget_set_can_default (btn_install, TRUE);
 
        btn_more = gtkut_get_link_btn((GtkWidget *)window, THEMES_URI, _("Get more..."));
        gtk_widget_show (btn_more);
@@ -944,37 +897,37 @@ static void prefs_themes_create_widget(PrefsPage *page, GtkWindow *window, gpoin
        gtk_widget_show (hbox1);
        gtk_container_add (GTK_CONTAINER (frame_preview), hbox1);
 
-       icon_1 = create_pixmap (vbox1, NULL);
+       icon_1 = gtk_image_new();
        gtk_widget_show (icon_1);
        gtk_box_pack_start (GTK_BOX (hbox1), icon_1, TRUE, TRUE, 2);
        gtk_misc_set_padding (GTK_MISC (icon_1), 0, 5);
 
-       icon_2 = create_pixmap (vbox1, NULL);
+       icon_2 = gtk_image_new();
        gtk_widget_show (icon_2);
        gtk_box_pack_start (GTK_BOX (hbox1), icon_2, TRUE, TRUE, 2);
        gtk_misc_set_padding (GTK_MISC (icon_2), 0, 5);
 
-       icon_3 = create_pixmap (vbox1, NULL);
+       icon_3 = gtk_image_new();
        gtk_widget_show (icon_3);
        gtk_box_pack_start (GTK_BOX (hbox1), icon_3, TRUE, TRUE, 2);
        gtk_misc_set_padding (GTK_MISC (icon_3), 0, 5);
 
-       icon_4 = create_pixmap (vbox1, NULL);
+       icon_4 = gtk_image_new();
        gtk_widget_show (icon_4);
        gtk_box_pack_start (GTK_BOX (hbox1), icon_4, TRUE, TRUE, 2);
        gtk_misc_set_padding (GTK_MISC (icon_4), 0, 5);
 
-       icon_5 = create_pixmap (vbox1, NULL);
+       icon_5 = gtk_image_new();
        gtk_widget_show (icon_5);
        gtk_box_pack_start (GTK_BOX (hbox1), icon_5, TRUE, TRUE, 2);
        gtk_misc_set_padding (GTK_MISC (icon_5), 0, 5);
 
-       icon_6 = create_pixmap (vbox1, NULL);
+       icon_6 = gtk_image_new();
        gtk_widget_show (icon_6);
        gtk_box_pack_start (GTK_BOX (hbox1), icon_6, TRUE, TRUE, 0);
        gtk_misc_set_padding (GTK_MISC (icon_6), 0, 5);
 
-       icon_7 = create_pixmap (vbox1, NULL);
+       icon_7 = gtk_image_new();
        gtk_widget_show (icon_7);
        gtk_box_pack_start (GTK_BOX (hbox1), icon_7, TRUE, TRUE, 0);
        gtk_misc_set_padding (GTK_MISC (icon_7), 0, 5);
@@ -988,19 +941,11 @@ static void prefs_themes_create_widget(PrefsPage *page, GtkWindow *window, gpoin
        gtk_button_box_set_layout (GTK_BUTTON_BOX (hbuttonbox1), GTK_BUTTONBOX_START);
        gtk_box_set_spacing (GTK_BOX (hbuttonbox1), 5);
 
-       btn_use = gtk_button_new_with_label (_("Use this"));
-       gtk_widget_show (btn_use);
-       gtk_container_add (GTK_CONTAINER (hbuttonbox1), btn_use);
-       GTK_WIDGET_SET_FLAGS (btn_use, GTK_CAN_DEFAULT);
-
        btn_remove = gtk_button_new_with_label (_("Remove"));
        gtk_widget_show (btn_remove);
        gtk_container_add (GTK_CONTAINER (hbuttonbox1), btn_remove);
-       GTK_WIDGET_SET_FLAGS (btn_remove, GTK_CAN_DEFAULT);
+       gtkut_widget_set_can_default (btn_remove, TRUE);
 
-       g_signal_connect(G_OBJECT(btn_use), "clicked",
-                        G_CALLBACK(prefs_themes_btn_use_clicked_cb),
-                        NULL);
        g_signal_connect(G_OBJECT(btn_remove), "clicked",
                         G_CALLBACK(prefs_themes_btn_remove_clicked_cb),
                         NULL);
@@ -1009,7 +954,7 @@ static void prefs_themes_create_widget(PrefsPage *page, GtkWindow *window, gpoin
                         NULL);
 
        prefs_themes->window = GTK_WIDGET(window);
-       
+
        prefs_themes->name   = label_name;
        prefs_themes->author = label_author;
        prefs_themes->url    = label_url;
@@ -1023,8 +968,7 @@ static void prefs_themes_create_widget(PrefsPage *page, GtkWindow *window, gpoin
        prefs_themes->icons[4] = icon_5;
        prefs_themes->icons[5] = icon_6;
        prefs_themes->icons[6] = icon_7;
-       
-       prefs_themes->btn_use     = btn_use;
+
        prefs_themes->btn_remove  = btn_remove;
        prefs_themes->btn_install = btn_install;
        prefs_themes->btn_more    = btn_more;
@@ -1032,9 +976,13 @@ static void prefs_themes_create_widget(PrefsPage *page, GtkWindow *window, gpoin
        prefs_themes->op_menu     = menu_themes;
 
        prefs_themes->page.widget = vbox1;
-
-       prefs_themes_set_themes_menu(GTK_OPTION_MENU(prefs_themes->op_menu), tdata);
        
+       prefs_themes_set_themes_menu(GTK_COMBO_BOX(menu_themes), tdata);
+       renderer = gtk_cell_renderer_text_new();
+       gtk_cell_layout_pack_start(GTK_CELL_LAYOUT(menu_themes), renderer, TRUE);
+       gtk_cell_layout_set_attributes(GTK_CELL_LAYOUT(menu_themes), renderer,
+                                       "text", 0, NULL);
+
        prefs_themes_get_theme_info(tdata);
        prefs_themes_display_global_stats(tdata);
 }
@@ -1046,6 +994,21 @@ static void prefs_themes_destroy_widget(PrefsPage *page)
 
 static void prefs_themes_save(PrefsPage *page)
 {
-       /* ThemesPage *theme = (ThemesPage *)page; */
+       ThemesPage *prefs_themes = (ThemesPage *)page;
+       ThemesData *tdata = prefs_themes_data;
+       gchar      *theme_str = tdata->displayed;
+
+       if (!IS_CURRENT_THEME(theme_str)) {
+               debug_print("Changing theme to %s\n", theme_str);
+               g_free(prefs_common.pixmap_theme_path);
+
+               prefs_common.pixmap_theme_path = g_strdup(theme_str);
+
+               main_window_reflect_prefs_all_real(TRUE);
+               compose_reflect_prefs_pixmap_theme();
+               addrcompl_reflect_prefs_pixmap_theme();
+
+               prefs_themes_update_buttons(tdata);
+       }
 }