Use Delete button instead of Remove (tooltips and other places already
[claws.git] / src / prefs_matcher.c
index 62b49bd96315d5977bc12ceacb48ca6222165b6d..9c2d1807cae5d5993ad100577dfbdf68a2cada19 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2012 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2014 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,6 +19,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
 #include "matcher_parser.h"
 #include "colorlabel.h"
 #include "tags.h"
+#ifndef USE_ALT_ADDRBOOK
+       #include "addressbook.h"
+#endif
 
-#ifndef USE_NEW_ADDRBOOK
+#ifndef USE_ALT_ADDRBOOK
 static void prefs_matcher_addressbook_select(void);
 #endif
 static void prefs_matcher_test_info(GtkWidget *widget, GtkWidget *parent);
@@ -94,9 +98,7 @@ static struct Matcher {
        GtkWidget *numeric_label;
        GtkWidget *addressbook_folder_combo;
        GtkWidget *case_checkbtn;
-#ifndef G_OS_WIN32
        GtkWidget *regexp_checkbtn;
-#endif
 #if !GTK_CHECK_VERSION(3, 0, 0)
        GtkWidget *color_optmenu;
 #endif
@@ -179,7 +181,13 @@ enum {
        CRITERIA_TAGGED = 36,
 
        CRITERIA_HAS_ATTACHMENT = 37,
-       CRITERIA_SIGNED = 38
+       CRITERIA_SIGNED = 38,
+
+       CRITERIA_AGE_GREATER_HOURS = 39,
+       CRITERIA_AGE_LOWER_HOURS = 40,
+
+       CRITERIA_MESSAGEID = 41,
+       CRITERIA_HEADERS_CONT = 42
 };
 
 enum {
@@ -199,8 +207,9 @@ enum {
 };
 
 enum {
-       AGE_DAYS  = 0,
-       AGE_WEEKS = 1
+       AGE_HOURS = 0,
+       AGE_DAYS  = 1,
+       AGE_WEEKS = 2
 };
 
 enum {
@@ -301,6 +310,8 @@ static int header_name_to_crit(const gchar *header)
                return CRITERIA_CC;
        if (!strcasecmp(header, "To or Cc"))
                return CRITERIA_TO_OR_CC;
+       if (!strcasecmp(header, "Message-ID"))
+               return CRITERIA_MESSAGEID;
        if (!strcasecmp(header, "In-Reply-To"))
                return CRITERIA_INREPLYTO;
        if (!strcasecmp(header, "Newsgroups"))
@@ -322,6 +333,7 @@ static void prefs_matcher_models_create(void)
        matcher.model_age = GTK_TREE_MODEL(store);
 
        store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
+       COMBOBOX_ADD(store, _("hours"), AGE_HOURS);
        COMBOBOX_ADD(store, _("days"), AGE_DAYS);
        COMBOBOX_ADD(store, _("weeks"), AGE_WEEKS);
        matcher.model_age_units = GTK_TREE_MODEL(store);
@@ -355,6 +367,7 @@ static void prefs_matcher_models_create(void)
        COMBOBOX_ADD(store, "To", CRITERIA_TO);
        COMBOBOX_ADD(store, "Cc", CRITERIA_CC);
        COMBOBOX_ADD(store, "To or Cc", CRITERIA_TO_OR_CC);
+       COMBOBOX_ADD(store, "Message-ID", CRITERIA_MESSAGEID);
        COMBOBOX_ADD(store, "In-Reply-To", CRITERIA_INREPLYTO);
        COMBOBOX_ADD(store, "Newsgroups", CRITERIA_NEWSGROUPS);
        COMBOBOX_ADD(store, "References", CRITERIA_REFERENCES);
@@ -370,6 +383,7 @@ static void prefs_matcher_models_create(void)
        
        store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
        COMBOBOX_ADD(store, _("headers part"), CRITERIA_HEADERS_PART);
+       COMBOBOX_ADD(store, _("headers values"), CRITERIA_HEADERS_CONT);
        COMBOBOX_ADD(store, _("body part"), CRITERIA_BODY_PART);
        COMBOBOX_ADD(store, _("whole message"), CRITERIA_MESSAGE);
        matcher.model_phrase = GTK_TREE_MODEL(store);
@@ -508,9 +522,7 @@ static void prefs_matcher_create(void)
        GtkWidget *numeric_entry;
        GtkWidget *numeric_label;
        
-#ifndef G_OS_WIN32
        GtkWidget *regexp_checkbtn;
-#endif
        GtkWidget *case_checkbtn;
 
        GtkWidget *reg_hbox;
@@ -530,7 +542,9 @@ static void prefs_matcher_create(void)
 
        GtkWidget *test_btn;
        GtkWidget *addressbook_select_btn;
+#if !GTK_CHECK_VERSION(3, 0, 0)
        GtkWidget *color_optmenu;
+#endif
 
        static GdkGeometry geometry;
        GtkSizeGroup *size_group;
@@ -575,7 +589,7 @@ static void prefs_matcher_create(void)
        
        table = gtk_table_new(3, 3, FALSE);
        gtk_container_add(GTK_CONTAINER(frame), table);
-       gtk_widget_set_size_request(frame, -1, 105);
+       gtk_widget_set_size_request(frame, -1, -1);
        
        upper_hbox = gtk_hbox_new(FALSE, HSPACING_NARROW);
        hbox = gtk_hbox_new(FALSE, 0);
@@ -598,7 +612,7 @@ static void prefs_matcher_create(void)
        /* criteria combo box */
        criteria_label = gtk_label_new(_("Match criteria:"));
        gtk_misc_set_alignment(GTK_MISC(criteria_label), 1, 0.5);
-       gtk_widget_set_size_request(criteria_label, 100, -1);
+       gtk_widget_set_size_request(criteria_label, -1, -1);
        gtk_table_attach(GTK_TABLE(table), criteria_label, 0, 1, 0, 1, 
                         GTK_FILL, GTK_SHRINK, 2, 2);
 
@@ -637,7 +651,15 @@ static void prefs_matcher_create(void)
        gtk_box_pack_start(GTK_BOX(upper_hbox), criteria_label2, FALSE, FALSE, 0);
 
        /* headers combo box entry */
+#if !GTK_CHECK_VERSION(2, 24, 0)
        headers_combo = gtk_combo_box_entry_new_with_model(matcher.model_headers, 0);
+#else
+       headers_combo = gtk_combo_box_new_with_model_and_entry(matcher.model_headers);
+       GtkCellRenderer *cell = gtk_cell_renderer_text_new();
+       gtk_cell_renderer_set_alignment(cell, 0.0, 0.5);
+       gtk_cell_layout_pack_start(GTK_CELL_LAYOUT(headers_combo), cell, TRUE);
+       gtk_combo_box_set_entry_text_column(GTK_COMBO_BOX(headers_combo), 0);
+#endif
        gtk_widget_set_size_request(headers_combo, 100, -1);
        gtk_box_pack_start(GTK_BOX(upper_hbox), headers_combo, TRUE, TRUE, 0);
        header_entry = gtk_bin_get_child(GTK_BIN((headers_combo)));
@@ -654,9 +676,9 @@ static void prefs_matcher_create(void)
        gtk_widget_set_size_request(addressbook_folder_combo, 150, -1);
        gtk_box_pack_start(GTK_BOX(upper_hbox), addressbook_folder_combo, TRUE, TRUE, 0);                        
 
-       addressbook_select_btn = gtk_button_new_with_label(_("Select ..."));
+       addressbook_select_btn = gtk_button_new_with_label(_("Select..."));
        gtk_box_pack_start(GTK_BOX(upper_hbox), addressbook_select_btn, FALSE, FALSE, 0);
-#ifndef USE_NEW_ADDRBOOK
+#ifndef USE_ALT_ADDRBOOK
        g_signal_connect(G_OBJECT (addressbook_select_btn), "clicked",
                         G_CALLBACK(prefs_matcher_addressbook_select),
                         NULL);
@@ -685,7 +707,7 @@ static void prefs_matcher_create(void)
        
        /* address header name */
        header_addr_combo = combobox_text_new(TRUE,
-                             Q_("Filtering Matcher Menu|All"), _("Any"),
+                             C_("Filtering Matcher Menu", "All"), _("Any"),
                              "From", "To", "Cc", "Reply-To", "Sender", NULL);
        gtk_box_pack_start(GTK_BOX(match_hbox), header_addr_combo, FALSE, FALSE, 0);
        header_addr_entry = gtk_bin_get_child(GTK_BIN((header_addr_combo)));
@@ -715,10 +737,12 @@ static void prefs_matcher_create(void)
 
        hbox = gtk_hbox_new(FALSE, HSPACING_NARROW);
        gtk_size_group_add_widget(size_group, hbox);
-       PACK_CHECK_BUTTON(hbox, case_checkbtn, _("Case sensitive"));
-#ifndef G_OS_WIN32
-       PACK_CHECK_BUTTON(hbox, regexp_checkbtn, _("Use regexp"));
-#endif
+
+       vbox = gtk_vbox_new(FALSE, VSPACING_NARROW);
+       PACK_CHECK_BUTTON(vbox, case_checkbtn, _("Case sensitive"));
+       PACK_CHECK_BUTTON(vbox, regexp_checkbtn, _("Use regexp"));
+       gtk_box_pack_start(GTK_BOX(hbox), vbox, TRUE, TRUE, 0);
+
        gtk_box_pack_end(GTK_BOX(hbox), gtk_label_new(""), TRUE, TRUE, 0);
        gtk_table_attach(GTK_TABLE(table), hbox, 2, 3, 2, 3,
                         GTK_FILL, GTK_SHRINK, 4, 0);
@@ -746,13 +770,15 @@ static void prefs_matcher_create(void)
        g_signal_connect(G_OBJECT(reg_btn), "clicked",
                         G_CALLBACK(prefs_matcher_register_cb), NULL);
 
-       subst_btn = gtkut_get_replace_btn(_("Replace"));
+       subst_btn = gtkut_get_replace_btn(_("_Replace"));
        gtk_box_pack_start(GTK_BOX(btn_hbox), subst_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(subst_btn), "clicked",
                         G_CALLBACK(prefs_matcher_substitute_cb),
                         NULL);
 
-       del_btn = gtk_button_new_from_stock(GTK_STOCK_DELETE);
+       del_btn = gtk_button_new_with_mnemonic (_("D_elete"));
+       gtk_button_set_image(GTK_BUTTON(del_btn),
+                       gtk_image_new_from_stock(GTK_STOCK_REMOVE,GTK_ICON_SIZE_BUTTON));
        gtk_box_pack_start(GTK_BOX(btn_hbox), del_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(del_btn), "clicked",
                         G_CALLBACK(prefs_matcher_delete_cb), NULL);
@@ -830,15 +856,15 @@ static void prefs_matcher_create(void)
        matcher.addressbook_folder_combo = addressbook_folder_combo;
        matcher.match_combo = match_combo;
        matcher.case_checkbtn = case_checkbtn;
-#ifndef G_OS_WIN32
        matcher.regexp_checkbtn = regexp_checkbtn;
-#endif
        matcher.bool_op_combo = bool_op_combo;
        matcher.test_btn = test_btn;
-#ifndef USE_NEW_ADDRBOOK
+#ifndef USE_ALT_ADDRBOOK
        matcher.addressbook_select_btn = addressbook_select_btn;
 #endif
+#if !GTK_CHECK_VERSION(3, 0, 0)
        matcher.color_optmenu = color_optmenu;
+#endif
        matcher.match_label = match_label;
        matcher.criteria_label2 = criteria_label2;
        matcher.headers_combo = headers_combo;
@@ -936,9 +962,7 @@ static void prefs_matcher_reset_condition(void)
        gtk_entry_set_text(GTK_ENTRY(matcher.header_addr_entry), "");
        gtk_entry_set_text(GTK_ENTRY(matcher.string_entry), "");
        gtk_entry_set_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((matcher.addressbook_folder_combo)))), "");
-#ifndef G_OS_WIN32
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn), FALSE);
-#endif
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), FALSE);
 }
 
@@ -1097,6 +1121,9 @@ static gint prefs_matcher_get_criteria_from_matching(gint matching_id)
        case MATCHCRITERIA_NOT_NEWSGROUPS:
        case MATCHCRITERIA_NEWSGROUPS:
                return CRITERIA_NEWSGROUPS;
+       case MATCHCRITERIA_NOT_MESSAGEID:
+       case MATCHCRITERIA_MESSAGEID:
+               return CRITERIA_MESSAGEID;
        case MATCHCRITERIA_NOT_INREPLYTO:
        case MATCHCRITERIA_INREPLYTO:
                return CRITERIA_INREPLYTO;
@@ -1121,9 +1148,16 @@ static gint prefs_matcher_get_criteria_from_matching(gint matching_id)
        case MATCHCRITERIA_NOT_HEADERS_PART:
        case MATCHCRITERIA_HEADERS_PART:
                return CRITERIA_HEADERS_PART;
+       case MATCHCRITERIA_NOT_HEADERS_CONT:
+       case MATCHCRITERIA_HEADERS_CONT:
+               return CRITERIA_HEADERS_CONT;
        case MATCHCRITERIA_NOT_HEADER:
        case MATCHCRITERIA_HEADER:
                return CRITERIA_HEADER;
+       case MATCHCRITERIA_AGE_GREATER_HOURS:
+               return CRITERIA_AGE_GREATER_HOURS;
+       case MATCHCRITERIA_AGE_LOWER_HOURS:
+               return CRITERIA_AGE_LOWER_HOURS;
        case MATCHCRITERIA_AGE_GREATER:
                return CRITERIA_AGE_GREATER;
        case MATCHCRITERIA_AGE_LOWER:
@@ -1210,6 +1244,8 @@ static gint prefs_matcher_get_matching_from_criteria(gint criteria_id)
                return MATCHCRITERIA_TAGGED;
        case CRITERIA_NEWSGROUPS:
                return MATCHCRITERIA_NEWSGROUPS;
+       case CRITERIA_MESSAGEID:
+               return MATCHCRITERIA_MESSAGEID;
        case CRITERIA_INREPLYTO:
                return MATCHCRITERIA_INREPLYTO;
        case CRITERIA_REFERENCES:
@@ -1218,6 +1254,10 @@ static gint prefs_matcher_get_matching_from_criteria(gint criteria_id)
                return MATCHCRITERIA_AGE_GREATER;
        case CRITERIA_AGE_LOWER:
                return MATCHCRITERIA_AGE_LOWER;
+       case CRITERIA_AGE_GREATER_HOURS:
+               return MATCHCRITERIA_AGE_GREATER_HOURS;
+       case CRITERIA_AGE_LOWER_HOURS:
+               return MATCHCRITERIA_AGE_LOWER_HOURS;
        case CRITERIA_SCORE_GREATER:
                return MATCHCRITERIA_SCORE_GREATER;
        case CRITERIA_SCORE_LOWER:
@@ -1228,6 +1268,8 @@ static gint prefs_matcher_get_matching_from_criteria(gint criteria_id)
                return MATCHCRITERIA_HEADER;
        case CRITERIA_HEADERS_PART:
                return MATCHCRITERIA_HEADERS_PART;
+       case CRITERIA_HEADERS_CONT:
+               return MATCHCRITERIA_HEADERS_CONT;
        case CRITERIA_BODY_PART:
                return MATCHCRITERIA_BODY_PART;
        case CRITERIA_MESSAGE:
@@ -1304,6 +1346,8 @@ static gint prefs_matcher_not_criteria(gint matcher_criteria)
                return MATCHCRITERIA_NOT_TAGGED;
        case MATCHCRITERIA_NEWSGROUPS:
                return MATCHCRITERIA_NOT_NEWSGROUPS;
+       case MATCHCRITERIA_MESSAGEID:
+               return MATCHCRITERIA_NOT_MESSAGEID;
        case MATCHCRITERIA_INREPLYTO:
                return MATCHCRITERIA_NOT_INREPLYTO;
        case MATCHCRITERIA_REFERENCES:
@@ -1312,6 +1356,8 @@ static gint prefs_matcher_not_criteria(gint matcher_criteria)
                return MATCHCRITERIA_NOT_HEADER;
        case MATCHCRITERIA_HEADERS_PART:
                return MATCHCRITERIA_NOT_HEADERS_PART;
+       case MATCHCRITERIA_HEADERS_CONT:
+               return MATCHCRITERIA_NOT_HEADERS_CONT;
        case MATCHCRITERIA_MESSAGE:
                return MATCHCRITERIA_NOT_MESSAGE;
        case MATCHCRITERIA_TEST:
@@ -1372,10 +1418,12 @@ static gint prefs_matcher_get_pred(const gint criteria)
        case CRITERIA_CC:
        case CRITERIA_TO_OR_CC:
        case CRITERIA_NEWSGROUPS:
+       case CRITERIA_MESSAGEID:
        case CRITERIA_INREPLYTO:
        case CRITERIA_REFERENCES:
        case CRITERIA_HEADER:
        case CRITERIA_HEADERS_PART:
+       case CRITERIA_HEADERS_CONT:
        case CRITERIA_BODY_PART:
        case CRITERIA_MESSAGE:
        case CRITERIA_TAG:
@@ -1427,17 +1475,7 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
        if (value_criteria == -1)
                return NULL;
 
-       criteria = prefs_matcher_get_matching_from_criteria(value_criteria);
-
-       value_pred = prefs_matcher_get_pred(value_criteria);
-       if(value_pred)
-               criteria = prefs_matcher_not_criteria(criteria);
-
-#ifndef G_OS_WIN32
        use_regexp = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn));
-#else
-       use_regexp = FALSE;
-#endif
        case_sensitive = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn));
 
        if (use_regexp) {
@@ -1482,9 +1520,11 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
        case CRITERIA_TO_OR_CC:
        case CRITERIA_TAG:
        case CRITERIA_NEWSGROUPS:
+       case CRITERIA_MESSAGEID:
        case CRITERIA_INREPLYTO:
        case CRITERIA_REFERENCES:
        case CRITERIA_HEADERS_PART:
+       case CRITERIA_HEADERS_CONT:
        case CRITERIA_BODY_PART:
        case CRITERIA_MESSAGE:
                expr = gtk_entry_get_text(GTK_ENTRY(matcher.string_entry));
@@ -1511,6 +1551,12 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
                sel = gtk_combo_box_get_active(GTK_COMBO_BOX(matcher.match_combo2));
                if(sel == AGE_WEEKS)
                        value *= 7;
+               else if (sel == AGE_HOURS) {
+                       if (value_criteria == CRITERIA_AGE_GREATER)
+                               value_criteria = CRITERIA_AGE_GREATER_HOURS;
+                       else 
+                               value_criteria = CRITERIA_AGE_LOWER_HOURS;
+               }
                break;
                        
        case CRITERIA_SCORE_GREATER:
@@ -1566,7 +1612,7 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
                if (*expr == '\0') {
                        gchar *tmp;
 
-                       if (g_utf8_collate(header, Q_("Filtering Matcher Menu|All")) == 0)
+                       if (g_utf8_collate(header, C_("Filtering Matcher Menu", "All")) == 0)
                                tmp = g_strdup(_("all addresses in all headers"));
                        else
                        if (g_utf8_collate(header, _("Any")) == 0)
@@ -1581,7 +1627,7 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
                    return NULL;
                }
                /* store UNtranslated "Any"/"All" in matcher expressions */
-               if (g_utf8_collate(header, Q_("Filtering Matcher Menu|All")) == 0)
+               if (g_utf8_collate(header, C_("Filtering Matcher Menu", "All")) == 0)
                        header = "All";
                else
                        if (g_utf8_collate(header, _("Any")) == 0)
@@ -1591,7 +1637,13 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
                break;
        }
 
-       matcherprop = matcherprop_new_create(criteria, header, matchtype,
+       criteria = prefs_matcher_get_matching_from_criteria(value_criteria);
+
+       value_pred = prefs_matcher_get_pred(value_criteria);
+       if(value_pred)
+               criteria = prefs_matcher_not_criteria(criteria);
+
+       matcherprop = matcherprop_new(criteria, header, matchtype,
                                      expr, value);
 
        return matcherprop;
@@ -1788,6 +1840,10 @@ static void prefs_matcher_second_criteria_sel(GtkWidget *widget,
                        gtk_label_set_text(GTK_LABEL(matcher.match_label),
                                        _("Headers part"));
                        break;
+               case CRITERIA_HEADERS_CONT:
+                       gtk_label_set_text(GTK_LABEL(matcher.match_label),
+                                       _("Headers values"));
+                       break;
                case CRITERIA_BODY_PART:
                        gtk_label_set_text(GTK_LABEL(matcher.match_label),
                                        _("Body part"));
@@ -1805,19 +1861,15 @@ static void prefs_matcher_second_criteria_sel(GtkWidget *widget,
                        prefs_matcher_enable_widget(matcher.match_label2, TRUE);
                        prefs_matcher_enable_widget(matcher.string_entry, FALSE);
                        prefs_matcher_enable_widget(matcher.case_checkbtn, FALSE);
-#ifndef G_OS_WIN32
                        prefs_matcher_enable_widget(matcher.regexp_checkbtn, FALSE);
-#endif
                } else {
                        prefs_matcher_enable_widget(matcher.upper_filler, TRUE);
                        prefs_matcher_enable_widget(matcher.match_label2, FALSE);
                        prefs_matcher_enable_widget(matcher.string_entry, TRUE);
                        prefs_matcher_enable_widget(matcher.case_checkbtn, TRUE);
-#ifndef G_OS_WIN32
                        prefs_matcher_enable_widget(matcher.regexp_checkbtn, TRUE);
                        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(
                                                matcher.regexp_checkbtn), FALSE);
-#endif
                        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(
                                                matcher.case_checkbtn), FALSE);
                }
@@ -1888,10 +1940,8 @@ static void prefs_matcher_criteria_select(GtkWidget *widget,
                                    MATCH_COMBO_IS_ENABLED(value));
        prefs_matcher_enable_widget(matcher.case_checkbtn,
                                    MATCH_CASE_REGEXP(value));
-#ifndef G_OS_WIN32
        prefs_matcher_enable_widget(matcher.regexp_checkbtn,
                                    MATCH_CASE_REGEXP(value));
-#endif
        prefs_matcher_enable_widget(matcher.test_btn,
                                    (value == MATCH_TEST));
        prefs_matcher_enable_widget(matcher.addressbook_select_btn,
@@ -1921,8 +1971,9 @@ static void prefs_matcher_criteria_select(GtkWidget *widget,
                prefs_matcher_set_model(matcher.match_combo, matcher.model_age);
                prefs_matcher_set_model(matcher.match_combo2, matcher.model_age_units);
                gtk_spin_button_set_range(GTK_SPIN_BUTTON(
-                                 matcher.numeric_entry), 0, 1000);
+                                 matcher.numeric_entry), 0, 10000);
                gtk_spin_button_set_value(GTK_SPIN_BUTTON(matcher.numeric_entry), 0);
+               gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo2), AGE_DAYS);
                gtk_label_set_text(GTK_LABEL(matcher.match_label), _("Age is"));
                break;
        case MATCH_FLAG:
@@ -1936,9 +1987,7 @@ static void prefs_matcher_criteria_select(GtkWidget *widget,
                prefs_matcher_set_model(matcher.match_combo, matcher.model_contain);
                gtk_label_set_text(GTK_LABEL(matcher.criteria_label2), _("Name:"));
                gtk_label_set_text(GTK_LABEL(matcher.match_label), _("Header"));
-#ifndef G_OS_WIN32
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn), FALSE);
-#endif
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), FALSE);
                break;
 #if !GTK_CHECK_VERSION(3, 0, 0)
@@ -1957,9 +2006,7 @@ static void prefs_matcher_criteria_select(GtkWidget *widget,
                prefs_matcher_set_model(matcher.criteria_combo2, matcher.model_phrase);
                prefs_matcher_set_model(matcher.match_combo, matcher.model_contain);
                gtk_label_set_text(GTK_LABEL(matcher.criteria_label2), _("in"));
-#ifndef G_OS_WIN32
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn), FALSE);
-#endif
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), FALSE);
                prefs_matcher_second_criteria_sel(NULL, NULL);
                break;  
@@ -2066,7 +2113,9 @@ static void prefs_matcher_ok(void)
                                if (!matcher_str || strcmp(matcher_str, str) != 0) {
                                        val = alertpanel(_("Entry not saved"),
                                                         _("The entry was not saved.\nClose anyway?"),
-                                                        GTK_STOCK_CLOSE, _("+_Continue editing"), NULL);
+                                                        GTK_STOCK_CLOSE,
+                                                g_strconcat("+", _("_Continue editing"), NULL),
+                                                NULL);
                                        if (G_ALERTDEFAULT != val) {
                                                g_free(matcher_str);                                             
                                                g_free(str);
@@ -2127,6 +2176,7 @@ static gchar *test_desc_strings[] = {
 static DescriptionWindow test_desc_win = { 
        NULL,
         NULL, 
+       TRUE,
         2,
         N_("Match Type: 'Test'"),
        N_("'Test' allows you to test a message or message element "
@@ -2147,7 +2197,7 @@ static void prefs_matcher_test_info(GtkWidget *widget, GtkWidget *parent)
        description_window_create(&test_desc_win);
 }
 
-#ifndef USE_NEW_ADDRBOOK
+#ifndef USE_ALT_ADDRBOOK
 static void prefs_matcher_addressbook_select(void)
 {
        const gchar *folderpath = NULL;
@@ -2248,6 +2298,8 @@ static void prefs_matcher_set_criteria(const gint criteria)
                break;
        case CRITERIA_AGE_GREATER:
        case CRITERIA_AGE_LOWER:
+       case CRITERIA_AGE_GREATER_HOURS:
+       case CRITERIA_AGE_LOWER_HOURS:
                match_criteria = MATCH_AGE;
                break;
        case CRITERIA_SCORE_GREATER:
@@ -2266,12 +2318,14 @@ static void prefs_matcher_set_criteria(const gint criteria)
        case CRITERIA_CC:
        case CRITERIA_TO_OR_CC:
        case CRITERIA_NEWSGROUPS:
+       case CRITERIA_MESSAGEID:
        case CRITERIA_INREPLYTO:
        case CRITERIA_REFERENCES:
        case CRITERIA_HEADER:
                match_criteria = MATCH_HEADER;
                break;
        case CRITERIA_HEADERS_PART:
+       case CRITERIA_HEADERS_CONT:
        case CRITERIA_BODY_PART:
        case CRITERIA_MESSAGE:
                match_criteria = MATCH_PHRASE;
@@ -2399,10 +2453,12 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case MATCHCRITERIA_NOT_TAG:
        case MATCHCRITERIA_NOT_TAGGED:
        case MATCHCRITERIA_NOT_NEWSGROUPS:
+       case MATCHCRITERIA_NOT_MESSAGEID:
        case MATCHCRITERIA_NOT_INREPLYTO:
        case MATCHCRITERIA_NOT_REFERENCES:
        case MATCHCRITERIA_NOT_HEADER:
        case MATCHCRITERIA_NOT_HEADERS_PART:
+       case MATCHCRITERIA_NOT_HEADERS_CONT:
        case MATCHCRITERIA_NOT_MESSAGE:
        case MATCHCRITERIA_NOT_BODY_PART:
        case MATCHCRITERIA_NOT_TEST:
@@ -2422,9 +2478,11 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case MATCHCRITERIA_NOT_TO_AND_NOT_CC:
        case MATCHCRITERIA_NOT_TAG:
        case MATCHCRITERIA_NOT_NEWSGROUPS:
+       case MATCHCRITERIA_NOT_MESSAGEID:
        case MATCHCRITERIA_NOT_INREPLYTO:
        case MATCHCRITERIA_NOT_REFERENCES:
        case MATCHCRITERIA_NOT_HEADERS_PART:
+       case MATCHCRITERIA_NOT_HEADERS_CONT:
        case MATCHCRITERIA_NOT_BODY_PART:
        case MATCHCRITERIA_NOT_MESSAGE:
        case MATCHCRITERIA_NOT_TEST:
@@ -2435,9 +2493,11 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case MATCHCRITERIA_TO_OR_CC:
        case MATCHCRITERIA_TAG:
        case MATCHCRITERIA_NEWSGROUPS:
+       case MATCHCRITERIA_MESSAGEID:
        case MATCHCRITERIA_INREPLYTO:
        case MATCHCRITERIA_REFERENCES:
        case MATCHCRITERIA_HEADERS_PART:
+       case MATCHCRITERIA_HEADERS_CONT:
        case MATCHCRITERIA_BODY_PART:
        case MATCHCRITERIA_MESSAGE:
        case MATCHCRITERIA_TEST:
@@ -2453,7 +2513,7 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
                /* matcher expressions contain UNtranslated "Any"/"All",
                  select the relevant translated combo item */
                if (strcasecmp(prop->header, "All") == 0)
-                       header = (gchar*)Q_("Filtering Matcher Menu|All");
+                       header = (gchar*)C_("Filtering Matcher Menu", "All");
                else
                        if (strcasecmp(prop->header, "Any") == 0)
                                header = _("Any");
@@ -2484,6 +2544,14 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
                }
                break;
                
+       case MATCHCRITERIA_AGE_GREATER_HOURS:
+       case MATCHCRITERIA_AGE_LOWER_HOURS:
+               gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo2),
+                                        AGE_HOURS);
+               gtk_spin_button_set_value(GTK_SPIN_BUTTON(
+                               matcher.numeric_entry), prop->value);
+               break;
+               
        case MATCHCRITERIA_SCORE_GREATER:
        case MATCHCRITERIA_SCORE_LOWER:
        case MATCHCRITERIA_SCORE_EQUAL:
@@ -2536,10 +2604,12 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case CRITERIA_CC:
        case CRITERIA_TO_OR_CC:
        case CRITERIA_NEWSGROUPS:
+       case CRITERIA_MESSAGEID:
        case CRITERIA_INREPLYTO:
        case CRITERIA_REFERENCES:
        case CRITERIA_HEADER:
        case CRITERIA_HEADERS_PART:
+       case CRITERIA_HEADERS_CONT:
        case CRITERIA_BODY_PART:
        case CRITERIA_MESSAGE:
        case CRITERIA_TAG:
@@ -2584,30 +2654,22 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
 
        switch(prop->matchtype) {
        case MATCHTYPE_MATCH:
-#ifndef G_OS_WIN32
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn), FALSE);
-#endif
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), TRUE);
                break;
 
        case MATCHTYPE_MATCHCASE:
-#ifndef G_OS_WIN32
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn), FALSE);
-#endif
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), FALSE);
                break;
 
        case MATCHTYPE_REGEXP:
-#ifndef G_OS_WIN32
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn), TRUE);
-#endif
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), TRUE);
                break;
 
        case MATCHTYPE_REGEXPCASE:
-#ifndef G_OS_WIN32
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn), TRUE);
-#endif
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), FALSE);
                break;
        }