fix bug 4239, 'Preferences: Text Options Header Display modal is not modal' (sic)
[claws.git] / src / prefs_matcher.c
index 10d499c02ef29db3af173484b87988d47e91e5a0..830df350cca93a657f101d96c5c95a4645cf1511 100644 (file)
@@ -1,6 +1,6 @@
 /*
- * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto and the Claws Mail team
+ * Claws Mail -- a GTK+ based, lightweight, and fast e-mail client
+ * Copyright (C) 1999-2018 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  *
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
- * 
  */
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
 #include <string.h>
 #include <errno.h>
 
+#include "gtkcmoptionmenu.h"
 #include "main.h"
 #include "prefs_gtk.h"
 #include "prefs_matcher.h"
 #include "prefs_common.h"
+#include "procheader.h"
 #include "mainwindow.h"
 #include "foldersel.h"
 #include "manage_window.h"
 
 #include "matcher_parser.h"
 #include "colorlabel.h"
+#include "tags.h"
+#ifndef USE_ALT_ADDRBOOK
+       #include "addressbook.h"
+#endif
 
+#ifndef USE_ALT_ADDRBOOK
 static void prefs_matcher_addressbook_select(void);
-static void prefs_matcher_test_info(void);
+#endif
+static void prefs_matcher_test_info(GtkWidget *widget, GtkWidget *parent);
 
 enum {
        PREFS_MATCHER_COND,
@@ -90,11 +98,15 @@ static struct Matcher {
        GtkWidget *case_checkbtn;
        GtkWidget *regexp_checkbtn;
        GtkWidget *color_optmenu;
+       GtkWidget *calendar;
+       GtkWidget *time_label;
+       GtkWidget *time_entry;
 
        GtkWidget *test_btn;
        GtkWidget *addressbook_select_btn;
 
        GtkTreeModel *model_age;
+       GtkTreeModel *model_date;
        GtkTreeModel *model_age_units;
        GtkTreeModel *model_contain;
        GtkTreeModel *model_found;
@@ -166,7 +178,19 @@ enum {
        CRITERIA_FOUND_IN_ADDRESSBOOK = 34,
        
        CRITERIA_TAG = 35,
-       CRITERIA_TAGGED = 36
+       CRITERIA_TAGGED = 36,
+
+       CRITERIA_HAS_ATTACHMENT = 37,
+       CRITERIA_SIGNED = 38,
+
+       CRITERIA_AGE_GREATER_HOURS = 39,
+       CRITERIA_AGE_LOWER_HOURS = 40,
+
+       CRITERIA_MESSAGEID = 41,
+       CRITERIA_HEADERS_CONT = 42,
+
+       CRITERIA_DATE_AFTER = 43,
+       CRITERIA_DATE_BEFORE = 44
 };
 
 enum {
@@ -182,12 +206,14 @@ enum {
        MATCH_PARTIAL   = 9,
        MATCH_ABOOK     = 10,
        MATCH_TAGS      = 11,
-       MATCH_TEST      = 12
+       MATCH_TEST      = 12,
+       MATCH_DATE      = 13
 };
 
 enum {
-       AGE_DAYS  = 0,
-       AGE_WEEKS = 1
+       AGE_HOURS = 0,
+       AGE_DAYS  = 1,
+       AGE_WEEKS = 2
 };
 
 enum {
@@ -288,6 +314,8 @@ static int header_name_to_crit(const gchar *header)
                return CRITERIA_CC;
        if (!strcasecmp(header, "To or Cc"))
                return CRITERIA_TO_OR_CC;
+       if (!strcasecmp(header, "Message-ID"))
+               return CRITERIA_MESSAGEID;
        if (!strcasecmp(header, "In-Reply-To"))
                return CRITERIA_INREPLYTO;
        if (!strcasecmp(header, "Newsgroups"))
@@ -309,10 +337,16 @@ static void prefs_matcher_models_create(void)
        matcher.model_age = GTK_TREE_MODEL(store);
 
        store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
+       COMBOBOX_ADD(store, _("hours"), AGE_HOURS);
        COMBOBOX_ADD(store, _("days"), AGE_DAYS);
        COMBOBOX_ADD(store, _("weeks"), AGE_WEEKS);
        matcher.model_age_units = GTK_TREE_MODEL(store);
 
+       store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
+       COMBOBOX_ADD(store, _("after"), CRITERIA_DATE_AFTER);
+       COMBOBOX_ADD(store, _("before"), CRITERIA_DATE_BEFORE);
+       matcher.model_date = GTK_TREE_MODEL(store);
+
        store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
        COMBOBOX_ADD(store, _("higher than"), CRITERIA_SCORE_GREATER);
        COMBOBOX_ADD(store, _("lower than"), CRITERIA_SCORE_LOWER);
@@ -337,14 +371,15 @@ static void prefs_matcher_models_create(void)
        matcher.model_contain = GTK_TREE_MODEL(store);
        
        store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
-       COMBOBOX_ADD(store, "Subject", CRITERIA_HEADER);
-       COMBOBOX_ADD(store, "From", CRITERIA_HEADER);
-       COMBOBOX_ADD(store, "To", CRITERIA_HEADER);
-       COMBOBOX_ADD(store, "Cc", CRITERIA_HEADER);
-       COMBOBOX_ADD(store, "To or Cc", CRITERIA_HEADER);
-       COMBOBOX_ADD(store, "In-Reply-To", CRITERIA_HEADER);
-       COMBOBOX_ADD(store, "Newsgroups", CRITERIA_HEADER);
-       COMBOBOX_ADD(store, "References", CRITERIA_HEADER);
+       COMBOBOX_ADD(store, "Subject", CRITERIA_SUBJECT);
+       COMBOBOX_ADD(store, "From", CRITERIA_FROM);
+       COMBOBOX_ADD(store, "To", CRITERIA_TO);
+       COMBOBOX_ADD(store, "Cc", CRITERIA_CC);
+       COMBOBOX_ADD(store, "To or Cc", CRITERIA_TO_OR_CC);
+       COMBOBOX_ADD(store, "Message-ID", CRITERIA_MESSAGEID);
+       COMBOBOX_ADD(store, "In-Reply-To", CRITERIA_INREPLYTO);
+       COMBOBOX_ADD(store, "Newsgroups", CRITERIA_NEWSGROUPS);
+       COMBOBOX_ADD(store, "References", CRITERIA_REFERENCES);
        COMBOBOX_ADD(store, "Sender", CRITERIA_HEADER);
        COMBOBOX_ADD(store, "X-ML-Name", CRITERIA_HEADER);
        COMBOBOX_ADD(store, "X-List", CRITERIA_HEADER);
@@ -352,12 +387,14 @@ static void prefs_matcher_models_create(void)
        COMBOBOX_ADD(store, "X-Mailer", CRITERIA_HEADER);
        COMBOBOX_ADD(store, "X-BeenThere", CRITERIA_HEADER);
        COMBOBOX_ADD(store, "List-Post", CRITERIA_HEADER);
+       COMBOBOX_ADD(store, "List-Id", CRITERIA_HEADER);
        matcher.model_headers = GTK_TREE_MODEL(store);
        
        store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
-       COMBOBOX_ADD(store, "headers part", CRITERIA_HEADERS_PART);
-       COMBOBOX_ADD(store, "body part", CRITERIA_BODY_PART);
-       COMBOBOX_ADD(store, "whole message", CRITERIA_MESSAGE);
+       COMBOBOX_ADD(store, _("headers part"), CRITERIA_HEADERS_PART);
+       COMBOBOX_ADD(store, _("headers values"), CRITERIA_HEADERS_CONT);
+       COMBOBOX_ADD(store, _("body part"), CRITERIA_BODY_PART);
+       COMBOBOX_ADD(store, _("whole message"), CRITERIA_MESSAGE);
        matcher.model_phrase = GTK_TREE_MODEL(store);
        
        store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
@@ -369,6 +406,8 @@ static void prefs_matcher_models_create(void)
        COMBOBOX_ADD(store, _("Forwarded"), CRITERIA_FORWARDED);
        COMBOBOX_ADD(store, _("Locked"), CRITERIA_LOCKED);
        COMBOBOX_ADD(store, _("Spam"), CRITERIA_SPAM);
+       COMBOBOX_ADD(store, _("Has attachment"), CRITERIA_HAS_ATTACHMENT);
+       COMBOBOX_ADD(store, _("Signed"), CRITERIA_SIGNED);
        matcher.model_flags = GTK_TREE_MODEL(store);
        
        store = gtk_list_store_new(3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_BOOLEAN);
@@ -420,7 +459,7 @@ void prefs_matcher_open(MatcherList *matchers, PrefsMatcherSignal *cb)
                prefs_matcher_create();
        } else {
                /* update color label menu */
-               gtk_option_menu_set_menu(GTK_OPTION_MENU(matcher.color_optmenu),
+               gtk_cmoption_menu_set_menu(GTK_CMOPTION_MENU(matcher.color_optmenu),
                                colorlabel_create_color_menu());
        }
 
@@ -432,6 +471,7 @@ void prefs_matcher_open(MatcherList *matchers, PrefsMatcherSignal *cb)
        prefs_matcher_set_dialog(matchers);
 
        gtk_widget_show(matcher.window);
+       gtk_window_set_modal(GTK_WINDOW(matcher.window), TRUE);
 }
 
 /*!
@@ -440,7 +480,7 @@ void prefs_matcher_open(MatcherList *matchers, PrefsMatcherSignal *cb)
 static void prefs_matcher_size_allocate_cb(GtkWidget *widget,
                                         GtkAllocation *allocation)
 {
-       g_return_if_fail(allocation != NULL);
+       cm_return_if_fail(allocation != NULL);
 
        prefs_common.matcherwin_width = allocation->width;
        prefs_common.matcherwin_height = allocation->height;
@@ -509,18 +549,24 @@ static void prefs_matcher_create(void)
 
        GtkWidget *test_btn;
        GtkWidget *addressbook_select_btn;
-
        GtkWidget *color_optmenu;
+       GtkWidget *calendar;
+       GtkWidget *time_label;
+       GtkWidget *time_entry;
+       GtkWidget *date_hbox;
+       GtkWidget *date_vbox;
 
        static GdkGeometry geometry;
        GtkSizeGroup *size_group;
+       GtkListStore *store;
+       GtkTreeIter iter;
 
        debug_print("Creating matcher configuration window...\n");
 
        window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "prefs_matcher");
        gtk_container_set_border_width(GTK_CONTAINER(window), 4);
        gtk_window_set_position(GTK_WINDOW(window), GTK_WIN_POS_CENTER);
-       gtk_window_set_modal(GTK_WINDOW(window), TRUE);
+       gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
 
        vbox = gtk_vbox_new(FALSE, 6);
        gtk_container_add(GTK_CONTAINER(window), vbox);
@@ -554,7 +600,7 @@ static void prefs_matcher_create(void)
        
        table = gtk_table_new(3, 3, FALSE);
        gtk_container_add(GTK_CONTAINER(frame), table);
-       gtk_widget_set_size_request(frame, -1, 105);
+       gtk_widget_set_size_request(frame, -1, -1);
        
        upper_hbox = gtk_hbox_new(FALSE, HSPACING_NARROW);
        hbox = gtk_hbox_new(FALSE, 0);
@@ -567,7 +613,7 @@ static void prefs_matcher_create(void)
        hbox = gtk_hbox_new(FALSE, 0);
        gtk_box_pack_start(GTK_BOX(hbox), lower_hbox, FALSE, FALSE, 0);
        gtk_box_pack_start(GTK_BOX(hbox), gtk_label_new(""), TRUE, TRUE, 0);
-       gtk_table_attach(GTK_TABLE(table), hbox,2, 3, 1, 2, 
+       gtk_table_attach(GTK_TABLE(table), hbox, 2, 3, 1, 2, 
                         GTK_FILL, GTK_SHRINK, 2, 2);
        
        size_group = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL);
@@ -575,20 +621,30 @@ static void prefs_matcher_create(void)
        gtk_size_group_add_widget(size_group, lower_hbox);
        
        /* criteria combo box */
-       criteria_label = gtk_label_new(_("Match criteria:"));
+       criteria_label = gtk_label_new(_("Match criteria"));
        gtk_misc_set_alignment(GTK_MISC(criteria_label), 1, 0.5);
-       gtk_widget_set_size_request(criteria_label, 100, -1);
+       gtk_widget_set_size_request(criteria_label, -1, -1);
        gtk_table_attach(GTK_TABLE(table), criteria_label, 0, 1, 0, 1, 
                         GTK_FILL, GTK_SHRINK, 2, 2);
 
-       criteria_combo = combobox_text_new(FALSE, _("All messages"), _("Header"),
-                                          _("Age"), _("Phrase"), _("Flags"),
-                                          _("Color labels"), _("Thread"), 
-                                          _("Score"), _("Size"),
-                                          _("Partially downloaded"),
-                                          _("Address book"), _("Tags"),
-                                          _("External program test"),
-                                          NULL);
+       criteria_combo = gtkut_sc_combobox_create(NULL, FALSE);
+       store = GTK_LIST_STORE(gtk_combo_box_get_model(
+                               GTK_COMBO_BOX(criteria_combo)));
+       COMBOBOX_ADD(store, _("All messages"), MATCH_ALL);
+       COMBOBOX_ADD(store, _("Header"), MATCH_HEADER);
+       COMBOBOX_ADD(store, _("Age"), MATCH_AGE);
+       COMBOBOX_ADD(store, _("Phrase"), MATCH_PHRASE);
+       COMBOBOX_ADD(store, _("Flags"), MATCH_FLAG);
+       COMBOBOX_ADD(store, _("Color labels"), MATCH_LABEL);
+       COMBOBOX_ADD(store, _("Thread"), MATCH_THREAD);
+       COMBOBOX_ADD(store, _("Score"), MATCH_SCORE);
+       COMBOBOX_ADD(store, _("Size"), MATCH_SIZE);
+       COMBOBOX_ADD(store, _("Partially downloaded"), MATCH_PARTIAL);
+       COMBOBOX_ADD(store, _("Address book"), MATCH_ABOOK);
+       COMBOBOX_ADD(store, _("Tags"), MATCH_TAGS);
+       COMBOBOX_ADD(store, _("External program test"), MATCH_TEST);
+       COMBOBOX_ADD(store, _("Date"), MATCH_DATE);
+
        gtk_widget_set_size_request(criteria_combo, 150, -1);
        gtk_combo_box_set_active(GTK_COMBO_BOX(criteria_combo), MATCH_ALL);
        gtk_table_attach(GTK_TABLE(table), criteria_combo, 1, 2, 0, 1,
@@ -607,10 +663,14 @@ static void prefs_matcher_create(void)
        gtk_box_pack_start(GTK_BOX(upper_hbox), criteria_label2, FALSE, FALSE, 0);
 
        /* headers combo box entry */
-       headers_combo = gtk_combo_box_entry_new_with_model(matcher.model_headers, 0);
+       headers_combo = gtk_combo_box_new_with_model_and_entry(matcher.model_headers);
+       GtkCellRenderer *cell = gtk_cell_renderer_text_new();
+       gtk_cell_renderer_set_alignment(cell, 0.0, 0.5);
+       gtk_cell_layout_pack_start(GTK_CELL_LAYOUT(headers_combo), cell, TRUE);
+       gtk_combo_box_set_entry_text_column(GTK_COMBO_BOX(headers_combo), 0);
        gtk_widget_set_size_request(headers_combo, 100, -1);
        gtk_box_pack_start(GTK_BOX(upper_hbox), headers_combo, TRUE, TRUE, 0);
-       header_entry = GTK_BIN (headers_combo)->child;
+       header_entry = gtk_bin_get_child(GTK_BIN((headers_combo)));
        
        criteria_combo2 = gtkut_sc_combobox_create(NULL, TRUE);
        prefs_matcher_set_model(criteria_combo2, matcher.model_phrase);
@@ -621,15 +681,18 @@ static void prefs_matcher_create(void)
 
        /* book/folder value */
        addressbook_folder_combo = combobox_text_new(TRUE, _("Any"), NULL);
-       gtk_widget_set_size_request(addressbook_folder_combo, 150, -1);
+       gtk_widget_set_size_request(addressbook_folder_combo, 250, -1);
        gtk_box_pack_start(GTK_BOX(upper_hbox), addressbook_folder_combo, TRUE, TRUE, 0);                        
 
-       addressbook_select_btn = gtk_button_new_with_label(_("Select ..."));
+       addressbook_select_btn = gtk_button_new_with_label(_("Select..."));
        gtk_box_pack_start(GTK_BOX(upper_hbox), addressbook_select_btn, FALSE, FALSE, 0);
+#ifndef USE_ALT_ADDRBOOK
        g_signal_connect(G_OBJECT (addressbook_select_btn), "clicked",
                         G_CALLBACK(prefs_matcher_addressbook_select),
                         NULL);
-
+#else
+       gtk_widget_set_sensitive(GTK_WIDGET(addressbook_select_btn), FALSE);
+#endif
        match_label = gtk_label_new("");
        gtk_misc_set_alignment(GTK_MISC(match_label), 1, 0.5);
        gtk_table_attach(GTK_TABLE(table), match_label, 0, 1, 1, 2,
@@ -643,17 +706,17 @@ static void prefs_matcher_create(void)
        gtk_box_pack_start(GTK_BOX(match_hbox), match_combo, TRUE, TRUE, 0);
        
        /* color labels combo */
-       color_optmenu = gtk_option_menu_new();
-       gtk_option_menu_set_menu(GTK_OPTION_MENU(color_optmenu),
+       color_optmenu = gtk_cmoption_menu_new();
+       gtk_cmoption_menu_set_menu(GTK_CMOPTION_MENU(color_optmenu),
                                 colorlabel_create_color_menu());
        gtk_box_pack_start(GTK_BOX(match_hbox), color_optmenu, FALSE, FALSE, 0);
        
        /* address header name */
        header_addr_combo = combobox_text_new(TRUE,
-                             Q_("Filtering Matcher Menu|All"), _("Any"),
-                             "From", "To", "Cc", "Reply-To", "Sender", NULL);
+                             C_("Filtering Matcher Menu", "All"), _("Any"),
+                             "From", "To", "Cc", "Reply-To", "Sender", "Resent-From", "Resent-To", NULL);
        gtk_box_pack_start(GTK_BOX(match_hbox), header_addr_combo, FALSE, FALSE, 0);
-       header_addr_entry = GTK_BIN(header_addr_combo)->child;
+       header_addr_entry = gtk_bin_get_child(GTK_BIN((header_addr_combo)));
        gtk_widget_set_size_request(header_addr_combo, 150, -1);
        
        match_label2 = gtk_label_new("");
@@ -677,25 +740,41 @@ static void prefs_matcher_create(void)
        /* string value */
        string_entry = gtk_entry_new();
        gtk_box_pack_start(GTK_BOX(lower_hbox), string_entry, TRUE, TRUE, 0);
+       gtk_widget_set_size_request(string_entry, 300, -1);
 
        hbox = gtk_hbox_new(FALSE, HSPACING_NARROW);
        gtk_size_group_add_widget(size_group, hbox);
-       PACK_CHECK_BUTTON(hbox, case_checkbtn, _("Case sensitive"));
-       PACK_CHECK_BUTTON(hbox, regexp_checkbtn, _("Use regexp"));
+
+       vbox = gtk_vbox_new(FALSE, VSPACING_NARROW);
+       PACK_CHECK_BUTTON(vbox, case_checkbtn, _("Case sensitive"));
+       PACK_CHECK_BUTTON(vbox, regexp_checkbtn, _("Use regexp"));
+       gtk_box_pack_start(GTK_BOX(hbox), vbox, TRUE, TRUE, 0);
+
        gtk_box_pack_end(GTK_BOX(hbox), gtk_label_new(""), TRUE, TRUE, 0);
        gtk_table_attach(GTK_TABLE(table), hbox, 2, 3, 2, 3,
                         GTK_FILL, GTK_SHRINK, 4, 0);
 
+       /* Date widgets */
+       date_vbox = gtk_vbox_new(FALSE, VSPACING_NARROW);
+       calendar = gtk_calendar_new();
+       gtk_box_pack_start(GTK_BOX(hbox), calendar, TRUE, TRUE, 0);
+       gtk_box_pack_start(GTK_BOX(lower_hbox), date_vbox, FALSE, FALSE, 0);
+
+       date_hbox = gtk_hbox_new(FALSE, HSPACING_NARROW);
+       gtk_box_pack_start(GTK_BOX(date_vbox), date_hbox, FALSE, FALSE, 0);
+
+       time_entry = gtkut_time_select_combo_new();
+       gtk_box_pack_start(GTK_BOX(date_hbox), time_entry, FALSE, FALSE, 0);
+       time_label = gtk_label_new(_("on:"));
+       gtk_misc_set_alignment(GTK_MISC(time_label), 0, 0.5);
+       gtk_box_pack_start(GTK_BOX(date_hbox), time_label, FALSE, FALSE, 0);
+       
        /* test info button */
-#if GTK_CHECK_VERSION(2, 8, 0)
        test_btn = gtk_button_new_from_stock(GTK_STOCK_INFO);
-#else
-       test_btn = gtk_button_new_with_label(_("Info..."));
-#endif
        gtk_box_pack_start(GTK_BOX(lower_hbox), test_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT (test_btn), "clicked",
                         G_CALLBACK(prefs_matcher_test_info),
-                        NULL);
+                        window);
 
        /* register / substitute / delete */
        reg_hbox = gtk_hbox_new(FALSE, HSPACING_NARROW);
@@ -713,13 +792,15 @@ static void prefs_matcher_create(void)
        g_signal_connect(G_OBJECT(reg_btn), "clicked",
                         G_CALLBACK(prefs_matcher_register_cb), NULL);
 
-       subst_btn = gtkut_get_replace_btn(_("Replace"));
+       subst_btn = gtkut_get_replace_btn(_("_Replace"));
        gtk_box_pack_start(GTK_BOX(btn_hbox), subst_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(subst_btn), "clicked",
                         G_CALLBACK(prefs_matcher_substitute_cb),
                         NULL);
 
-       del_btn = gtk_button_new_from_stock(GTK_STOCK_DELETE);
+       del_btn = gtk_button_new_with_mnemonic (_("D_elete"));
+       gtk_button_set_image(GTK_BUTTON(del_btn),
+                       gtk_image_new_from_stock(GTK_STOCK_REMOVE,GTK_ICON_SIZE_BUTTON));
        gtk_box_pack_start(GTK_BOX(btn_hbox), del_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT(del_btn), "clicked",
                         G_CALLBACK(prefs_matcher_delete_cb), NULL);
@@ -771,7 +852,7 @@ static void prefs_matcher_create(void)
                           TRUE, TRUE, 0);
        
        if (!geometry.min_height) {
-               geometry.min_width = 550;
+               geometry.min_width = 630;
                geometry.min_height = 368;
        }
 
@@ -800,7 +881,12 @@ static void prefs_matcher_create(void)
        matcher.regexp_checkbtn = regexp_checkbtn;
        matcher.bool_op_combo = bool_op_combo;
        matcher.test_btn = test_btn;
+       matcher.calendar = calendar;
+       matcher.time_label = time_label;
+       matcher.time_entry = time_entry;
+#ifndef USE_ALT_ADDRBOOK
        matcher.addressbook_select_btn = addressbook_select_btn;
+#endif
        matcher.color_optmenu = color_optmenu;
        matcher.match_label = match_label;
        matcher.criteria_label2 = criteria_label2;
@@ -846,6 +932,40 @@ static void prefs_matcher_list_view_set_row(GtkTreeIter *row, MatcherProp *prop)
        g_free(matcher_str);
 }
 
+static gboolean match_combo2_model_set(void)
+{
+       GtkTreeModel *model = gtk_combo_box_get_model(GTK_COMBO_BOX(matcher.match_combo2));
+       if (model == matcher.model_age_units ||
+           model == matcher.model_found ||
+           model == matcher.model_partial ||
+           model == matcher.model_phrase ||
+           model == matcher.model_set ||
+           model == matcher.model_size_units ||
+           model == matcher.model_tags ||
+           model == matcher.model_thread)
+               return TRUE;
+       else
+               debug_print("match_combo2 model unset.\n");
+
+       return FALSE;
+}
+
+static gboolean match_combo_model_set(void)
+{
+       GtkTreeModel *model = gtk_combo_box_get_model(GTK_COMBO_BOX(matcher.match_combo));
+       if (model == matcher.model_age ||
+           model == matcher.model_contain ||
+           model == matcher.model_flags ||
+           model == matcher.model_score ||
+           model == matcher.model_size ||
+           model == matcher.model_test)
+               return TRUE;
+       else
+               debug_print("match_combo model unset.\n");
+
+       return FALSE;
+}
+
 /*!
  *\brief       Clears a condition in the list widget
  */
@@ -853,16 +973,21 @@ static void prefs_matcher_reset_condition(void)
 {
        gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.criteria_combo), MATCH_ALL);
        gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.criteria_combo2), 0);
-       gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo), 0);
-       gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo2), 0);
-       gtk_option_menu_set_history(GTK_OPTION_MENU(matcher.color_optmenu), 0);
+       if (match_combo_model_set())
+               gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo), 0);
+       if (match_combo2_model_set())
+               gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo2), 0);
+       gtk_cmoption_menu_set_history(GTK_CMOPTION_MENU(matcher.color_optmenu), 0);
        gtk_spin_button_set_value(GTK_SPIN_BUTTON(matcher.numeric_entry), 0);
        gtk_entry_set_text(GTK_ENTRY(matcher.header_entry), "");
        gtk_entry_set_text(GTK_ENTRY(matcher.header_addr_entry), "");
        gtk_entry_set_text(GTK_ENTRY(matcher.string_entry), "");
-       gtk_entry_set_text(GTK_ENTRY(GTK_BIN(matcher.addressbook_folder_combo)->child), "");
+       gtk_entry_set_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((matcher.addressbook_folder_combo)))), "");
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn), FALSE);
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), FALSE);
+
+       gtk_calendar_select_today(GTK_CALENDAR(matcher.calendar));
+       gtkut_time_select_select_by_time(GTK_COMBO_BOX(matcher.time_entry), 0, 0);
 }
 
 /*!
@@ -894,6 +1019,9 @@ static void prefs_matcher_set_dialog(MatcherList *matchers)
        gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.bool_op_combo), bool_op);
 
        prefs_matcher_reset_condition();
+       
+       combobox_set_sensitive(GTK_COMBO_BOX(matcher.criteria_combo), MATCH_TAGS,
+                       (tags_get_size() > 0) ? TRUE : FALSE);
 }
 
 /*!
@@ -929,12 +1057,14 @@ static MatcherList *prefs_matcher_get_list(void)
                if (is_valid) {
                        /* tmp = matcher_str; */
                        prop = matcher_parser_get_prop(matcher_str);
-                       g_free(matcher_str);
-                       if (prop == NULL)
+                       if (prop == NULL) {
+                               g_free(matcher_str);
                                break;
+                       }
                        
                        matcher_list = g_slist_append(matcher_list, prop);
                }
+               g_free(matcher_str);
        } while (gtk_tree_model_iter_next(model, &iter));
 
        bool_and = gtk_combo_box_get_active(GTK_COMBO_BOX(matcher.bool_op_combo));
@@ -982,6 +1112,12 @@ static gint prefs_matcher_get_criteria_from_matching(gint matching_id)
        case MATCHCRITERIA_NOT_SPAM:
        case MATCHCRITERIA_SPAM:
                return CRITERIA_SPAM;
+       case MATCHCRITERIA_HAS_ATTACHMENT:
+       case MATCHCRITERIA_HAS_NO_ATTACHMENT:
+               return CRITERIA_HAS_ATTACHMENT;
+       case MATCHCRITERIA_SIGNED:
+       case MATCHCRITERIA_NOT_SIGNED:
+               return CRITERIA_SIGNED;
        case MATCHCRITERIA_PARTIAL:
        case MATCHCRITERIA_NOT_PARTIAL:
                return CRITERIA_PARTIAL;
@@ -1009,6 +1145,9 @@ static gint prefs_matcher_get_criteria_from_matching(gint matching_id)
        case MATCHCRITERIA_NOT_NEWSGROUPS:
        case MATCHCRITERIA_NEWSGROUPS:
                return CRITERIA_NEWSGROUPS;
+       case MATCHCRITERIA_NOT_MESSAGEID:
+       case MATCHCRITERIA_MESSAGEID:
+               return CRITERIA_MESSAGEID;
        case MATCHCRITERIA_NOT_INREPLYTO:
        case MATCHCRITERIA_INREPLYTO:
                return CRITERIA_INREPLYTO;
@@ -1033,13 +1172,24 @@ static gint prefs_matcher_get_criteria_from_matching(gint matching_id)
        case MATCHCRITERIA_NOT_HEADERS_PART:
        case MATCHCRITERIA_HEADERS_PART:
                return CRITERIA_HEADERS_PART;
+       case MATCHCRITERIA_NOT_HEADERS_CONT:
+       case MATCHCRITERIA_HEADERS_CONT:
+               return CRITERIA_HEADERS_CONT;
        case MATCHCRITERIA_NOT_HEADER:
        case MATCHCRITERIA_HEADER:
                return CRITERIA_HEADER;
+       case MATCHCRITERIA_AGE_GREATER_HOURS:
+               return CRITERIA_AGE_GREATER_HOURS;
+       case MATCHCRITERIA_AGE_LOWER_HOURS:
+               return CRITERIA_AGE_LOWER_HOURS;
        case MATCHCRITERIA_AGE_GREATER:
                return CRITERIA_AGE_GREATER;
        case MATCHCRITERIA_AGE_LOWER:
                return CRITERIA_AGE_LOWER;
+       case MATCHCRITERIA_DATE_AFTER:
+               return CRITERIA_DATE_AFTER;
+       case MATCHCRITERIA_DATE_BEFORE:
+               return CRITERIA_DATE_BEFORE;
        case MATCHCRITERIA_SCORE_GREATER:
                return CRITERIA_SCORE_GREATER;
        case MATCHCRITERIA_SCORE_LOWER:
@@ -1092,6 +1242,10 @@ static gint prefs_matcher_get_matching_from_criteria(gint criteria_id)
                return MATCHCRITERIA_LOCKED;
        case CRITERIA_SPAM:
                return MATCHCRITERIA_SPAM;
+       case CRITERIA_HAS_ATTACHMENT:
+               return MATCHCRITERIA_HAS_ATTACHMENT;
+       case CRITERIA_SIGNED:
+               return MATCHCRITERIA_SIGNED;
        case CRITERIA_PARTIAL:
                return MATCHCRITERIA_PARTIAL;
        case CRITERIA_COLORLABEL:
@@ -1116,6 +1270,8 @@ static gint prefs_matcher_get_matching_from_criteria(gint criteria_id)
                return MATCHCRITERIA_TAGGED;
        case CRITERIA_NEWSGROUPS:
                return MATCHCRITERIA_NEWSGROUPS;
+       case CRITERIA_MESSAGEID:
+               return MATCHCRITERIA_MESSAGEID;
        case CRITERIA_INREPLYTO:
                return MATCHCRITERIA_INREPLYTO;
        case CRITERIA_REFERENCES:
@@ -1124,6 +1280,14 @@ static gint prefs_matcher_get_matching_from_criteria(gint criteria_id)
                return MATCHCRITERIA_AGE_GREATER;
        case CRITERIA_AGE_LOWER:
                return MATCHCRITERIA_AGE_LOWER;
+       case CRITERIA_AGE_GREATER_HOURS:
+               return MATCHCRITERIA_AGE_GREATER_HOURS;
+       case CRITERIA_AGE_LOWER_HOURS:
+               return MATCHCRITERIA_AGE_LOWER_HOURS;
+       case CRITERIA_DATE_AFTER:
+               return MATCHCRITERIA_DATE_AFTER;
+       case CRITERIA_DATE_BEFORE:
+               return MATCHCRITERIA_DATE_BEFORE;
        case CRITERIA_SCORE_GREATER:
                return MATCHCRITERIA_SCORE_GREATER;
        case CRITERIA_SCORE_LOWER:
@@ -1134,6 +1298,8 @@ static gint prefs_matcher_get_matching_from_criteria(gint criteria_id)
                return MATCHCRITERIA_HEADER;
        case CRITERIA_HEADERS_PART:
                return MATCHCRITERIA_HEADERS_PART;
+       case CRITERIA_HEADERS_CONT:
+               return MATCHCRITERIA_HEADERS_CONT;
        case CRITERIA_BODY_PART:
                return MATCHCRITERIA_BODY_PART;
        case CRITERIA_MESSAGE:
@@ -1180,6 +1346,10 @@ static gint prefs_matcher_not_criteria(gint matcher_criteria)
                return MATCHCRITERIA_NOT_LOCKED;
        case MATCHCRITERIA_SPAM:
                return MATCHCRITERIA_NOT_SPAM;
+       case MATCHCRITERIA_HAS_ATTACHMENT:
+               return MATCHCRITERIA_HAS_NO_ATTACHMENT;
+       case MATCHCRITERIA_SIGNED:
+               return MATCHCRITERIA_NOT_SIGNED;
        case MATCHCRITERIA_PARTIAL:
                return MATCHCRITERIA_NOT_PARTIAL;
        case MATCHCRITERIA_COLORLABEL:
@@ -1204,6 +1374,8 @@ static gint prefs_matcher_not_criteria(gint matcher_criteria)
                return MATCHCRITERIA_NOT_TAGGED;
        case MATCHCRITERIA_NEWSGROUPS:
                return MATCHCRITERIA_NOT_NEWSGROUPS;
+       case MATCHCRITERIA_MESSAGEID:
+               return MATCHCRITERIA_NOT_MESSAGEID;
        case MATCHCRITERIA_INREPLYTO:
                return MATCHCRITERIA_NOT_INREPLYTO;
        case MATCHCRITERIA_REFERENCES:
@@ -1212,6 +1384,8 @@ static gint prefs_matcher_not_criteria(gint matcher_criteria)
                return MATCHCRITERIA_NOT_HEADER;
        case MATCHCRITERIA_HEADERS_PART:
                return MATCHCRITERIA_NOT_HEADERS_PART;
+       case MATCHCRITERIA_HEADERS_CONT:
+               return MATCHCRITERIA_NOT_HEADERS_CONT;
        case MATCHCRITERIA_MESSAGE:
                return MATCHCRITERIA_NOT_MESSAGE;
        case MATCHCRITERIA_TEST:
@@ -1237,6 +1411,7 @@ static gint prefs_matcher_get_criteria(void)
        case MATCH_ALL:
                return CRITERIA_ALL;
        case MATCH_AGE:
+       case MATCH_DATE:
        case MATCH_SCORE:
        case MATCH_SIZE:
        case MATCH_FLAG:
@@ -1270,10 +1445,12 @@ static gint prefs_matcher_get_pred(const gint criteria)
        case CRITERIA_CC:
        case CRITERIA_TO_OR_CC:
        case CRITERIA_NEWSGROUPS:
+       case CRITERIA_MESSAGEID:
        case CRITERIA_INREPLYTO:
        case CRITERIA_REFERENCES:
        case CRITERIA_HEADER:
        case CRITERIA_HEADERS_PART:
+       case CRITERIA_HEADERS_CONT:
        case CRITERIA_BODY_PART:
        case CRITERIA_MESSAGE:
        case CRITERIA_TAG:
@@ -1289,6 +1466,8 @@ static gint prefs_matcher_get_pred(const gint criteria)
        case CRITERIA_FORWARDED:
        case CRITERIA_LOCKED:
        case CRITERIA_SPAM:
+       case CRITERIA_HAS_ATTACHMENT:
+       case CRITERIA_SIGNED:
        case CRITERIA_COLORLABEL:
                return gtk_combo_box_get_active(GTK_COMBO_BOX(matcher.match_combo2));
        case CRITERIA_WATCH_THREAD:
@@ -1319,15 +1498,10 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
        const gchar *header;
        const gchar *expr;
        gint value, sel;
+       gint year, month, day, hour, minute;
 
        if (value_criteria == -1)
-               return -1;
-
-       criteria = prefs_matcher_get_matching_from_criteria(value_criteria);
-
-       value_pred = prefs_matcher_get_pred(value_criteria);
-       if(value_pred)
-               criteria = prefs_matcher_not_criteria(criteria);
+               return NULL;
 
        use_regexp = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(matcher.regexp_checkbtn));
        case_sensitive = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn));
@@ -1359,6 +1533,8 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
        case CRITERIA_FORWARDED:
        case CRITERIA_LOCKED:
        case CRITERIA_SPAM:
+       case CRITERIA_HAS_ATTACHMENT:
+       case CRITERIA_SIGNED:
        case CRITERIA_PARTIAL:
        case CRITERIA_IGNORE_THREAD:
        case CRITERIA_WATCH_THREAD:
@@ -1372,9 +1548,11 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
        case CRITERIA_TO_OR_CC:
        case CRITERIA_TAG:
        case CRITERIA_NEWSGROUPS:
+       case CRITERIA_MESSAGEID:
        case CRITERIA_INREPLYTO:
        case CRITERIA_REFERENCES:
        case CRITERIA_HEADERS_PART:
+       case CRITERIA_HEADERS_CONT:
        case CRITERIA_BODY_PART:
        case CRITERIA_MESSAGE:
                expr = gtk_entry_get_text(GTK_ENTRY(matcher.string_entry));
@@ -1385,6 +1563,20 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
                }
                break;
 
+       case CRITERIA_DATE_AFTER:
+       case CRITERIA_DATE_BEFORE:
+               expr = NULL;
+               gtk_calendar_get_date(GTK_CALENDAR(matcher.calendar), &year, &month, &day);
+               if (gtkut_time_select_get_time(GTK_COMBO_BOX(matcher.time_entry), &hour, &minute))
+                       expr = g_strdup_printf("%4d-%02d-%02d %02d:%02d:00",
+                               year, month + 1, day, hour, minute);
+
+               if (expr == NULL) {
+                       alertpanel_error(_("Invalid hour."));
+                       return NULL;
+               }
+               break;
+
        case CRITERIA_TEST:
                expr = gtk_entry_get_text(GTK_ENTRY(matcher.string_entry));
                
@@ -1401,6 +1593,12 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
                sel = gtk_combo_box_get_active(GTK_COMBO_BOX(matcher.match_combo2));
                if(sel == AGE_WEEKS)
                        value *= 7;
+               else if (sel == AGE_HOURS) {
+                       if (value_criteria == CRITERIA_AGE_GREATER)
+                               value_criteria = CRITERIA_AGE_GREATER_HOURS;
+                       else 
+                               value_criteria = CRITERIA_AGE_LOWER_HOURS;
+               }
                break;
                        
        case CRITERIA_SCORE_GREATER:
@@ -1424,7 +1622,7 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
                
        case CRITERIA_COLORLABEL:
                value = colorlabel_get_color_menu_active_item
-                       (gtk_option_menu_get_menu(GTK_OPTION_MENU
+                       (gtk_cmoption_menu_get_menu(GTK_CMOPTION_MENU
                                (matcher.color_optmenu))); 
                break;
 
@@ -1445,7 +1643,7 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
 
        case CRITERIA_FOUND_IN_ADDRESSBOOK:
                header = gtk_entry_get_text(GTK_ENTRY(matcher.header_addr_entry));
-               expr = gtk_entry_get_text(GTK_ENTRY(GTK_BIN(matcher.addressbook_folder_combo)->child));
+               expr = gtk_entry_get_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((matcher.addressbook_folder_combo)))));
 
                if (*header == '\0') {
                    alertpanel_error(_("Header name is not set."));
@@ -1454,32 +1652,38 @@ static MatcherProp *prefs_matcher_dialog_to_matcher(void)
                if (*expr == '\0') {
                        gchar *tmp;
 
-                       if (strcasecmp(header, Q_("Filtering Matcher Menu|All")) == 0)
+                       if (g_utf8_collate(header, C_("Filtering Matcher Menu", "All")) == 0)
                                tmp = g_strdup(_("all addresses in all headers"));
                        else
-                       if (strcasecmp(header, _("Any")) == 0)
+                       if (g_utf8_collate(header, _("Any")) == 0)
                                tmp = g_strdup(_("any address in any header"));
                        else
                                tmp = g_strdup_printf(_("the address(es) in header '%s'"), header);
                        alertpanel_error(_("Book/folder path is not set.\n\n"
                                                "If you want to match %s against the whole address book, "
-                                               "you have to select 'Any' from the book/folder drop-down list."),
-                                               tmp);
+                                               "you have to select '%s' from the book/folder drop-down list."),
+                                               tmp, _("Any"));
                        g_free(tmp);
                    return NULL;
                }
-               /* don't store translated "Any"/"All" in matcher expressions */
-               if (strcasecmp(header, Q_("Filtering Matcher Menu|All")) == 0)
+               /* store UNtranslated "Any"/"All" in matcher expressions */
+               if (g_utf8_collate(header, C_("Filtering Matcher Menu", "All")) == 0)
                        header = "All";
                else
-                       if (strcasecmp(header, _("Any")) == 0)
+                       if (g_utf8_collate(header, _("Any")) == 0)
                                header = "Any";
-               if (strcasecmp(expr, _("Any")) == 0)
+               if (g_utf8_collate(expr, _("Any")) == 0)
                        expr = "Any";
                break;
        }
 
-       matcherprop = matcherprop_new_create(criteria, header, matchtype,
+       criteria = prefs_matcher_get_matching_from_criteria(value_criteria);
+
+       value_pred = prefs_matcher_get_pred(value_criteria);
+       if(value_pred)
+               criteria = prefs_matcher_not_criteria(criteria);
+
+       matcherprop = matcherprop_new(criteria, header, matchtype,
                                      expr, value);
 
        return matcherprop;
@@ -1640,7 +1844,7 @@ static void prefs_matcher_down(void)
 
 static void prefs_matcher_enable_widget(GtkWidget* widget, const gboolean enable)
 {
-       g_return_if_fail(widget != NULL);
+       cm_return_if_fail(widget != NULL);
 
        if(enable == TRUE) {
                gtk_widget_set_sensitive(widget, TRUE);
@@ -1653,8 +1857,8 @@ static void prefs_matcher_enable_widget(GtkWidget* widget, const gboolean enable
 
 static void prefs_matcher_set_model(GtkWidget *widget, GtkTreeModel *model)
 {
-       g_return_if_fail(widget != NULL);
-       g_return_if_fail(model != NULL);
+       cm_return_if_fail(widget != NULL);
+       cm_return_if_fail(model != NULL);
        
        gtk_combo_box_set_model(GTK_COMBO_BOX(widget), model);
        gtk_combo_box_set_active(GTK_COMBO_BOX(widget), 0);
@@ -1676,6 +1880,10 @@ static void prefs_matcher_second_criteria_sel(GtkWidget *widget,
                        gtk_label_set_text(GTK_LABEL(matcher.match_label),
                                        _("Headers part"));
                        break;
+               case CRITERIA_HEADERS_CONT:
+                       gtk_label_set_text(GTK_LABEL(matcher.match_label),
+                                       _("Headers values"));
+                       break;
                case CRITERIA_BODY_PART:
                        gtk_label_set_text(GTK_LABEL(matcher.match_label),
                                        _("Body part"));
@@ -1762,6 +1970,12 @@ static void prefs_matcher_criteria_select(GtkWidget *widget,
        prefs_matcher_enable_widget(matcher.string_entry,
                                    (MATCH_CASE_REGEXP(value) ||
                                     value == MATCH_TEST));
+       prefs_matcher_enable_widget(matcher.calendar,
+                                   (value == MATCH_DATE));
+       prefs_matcher_enable_widget(matcher.time_label,
+                                   (value == MATCH_DATE));
+       prefs_matcher_enable_widget(matcher.time_entry,
+                                   (value == MATCH_DATE));
        prefs_matcher_enable_widget(matcher.numeric_entry,
                                    MATCH_NUMERIC(value));
        prefs_matcher_enable_widget(matcher.numeric_label,
@@ -1797,12 +2011,19 @@ static void prefs_matcher_criteria_select(GtkWidget *widget,
                gtk_label_set_text(GTK_LABEL(matcher.match_label), _("Header"));
                gtk_label_set_text(GTK_LABEL(matcher.match_label2), _("content is"));
                break;
+       case MATCH_DATE:
+               prefs_matcher_set_model(matcher.match_combo, matcher.model_date);
+               gtk_label_set_text(GTK_LABEL(matcher.match_label), _("Date is"));
+               gtk_calendar_select_today(GTK_CALENDAR(matcher.calendar));
+               gtkut_time_select_select_by_time(GTK_COMBO_BOX(matcher.time_entry), 0, 0);
+               break;
        case MATCH_AGE:
                prefs_matcher_set_model(matcher.match_combo, matcher.model_age);
                prefs_matcher_set_model(matcher.match_combo2, matcher.model_age_units);
                gtk_spin_button_set_range(GTK_SPIN_BUTTON(
-                                 matcher.numeric_entry), 0, 1000);
+                                 matcher.numeric_entry), 0, 10000);
                gtk_spin_button_set_value(GTK_SPIN_BUTTON(matcher.numeric_entry), 0);
+               gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo2), AGE_DAYS);
                gtk_label_set_text(GTK_LABEL(matcher.match_label), _("Age is"));
                break;
        case MATCH_FLAG:
@@ -1820,7 +2041,7 @@ static void prefs_matcher_criteria_select(GtkWidget *widget,
                gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(matcher.case_checkbtn), FALSE);
                break;
        case MATCH_LABEL:
-               gtk_option_menu_set_history(GTK_OPTION_MENU(matcher.color_optmenu), 0);
+               gtk_cmoption_menu_set_history(GTK_CMOPTION_MENU(matcher.color_optmenu), 0);
                prefs_matcher_set_model(matcher.match_combo2, matcher.model_set);
                gtk_label_set_text(GTK_LABEL(matcher.match_label), _("Label"));
                gtk_label_set_text(GTK_LABEL(matcher.match_label2), _("is"));
@@ -1884,7 +2105,7 @@ static void prefs_matcher_criteria_select(GtkWidget *widget,
 static gboolean prefs_matcher_key_pressed(GtkWidget *widget, GdkEventKey *event,
                                     gpointer data)
 {
-       if (event && event->keyval == GDK_Escape) {
+       if (event && event->keyval == GDK_KEY_Escape) {
                prefs_matcher_cancel();
                return TRUE;            
        }
@@ -1897,6 +2118,7 @@ static gboolean prefs_matcher_key_pressed(GtkWidget *widget, GdkEventKey *event,
 static void prefs_matcher_cancel(void)
 {
        gtk_widget_hide(matcher.window);
+       gtk_window_set_modal(GTK_WINDOW(matcher.window), FALSE);
        inc_unlock();
 }
 
@@ -1939,7 +2161,10 @@ static void prefs_matcher_ok(void)
                                if (!matcher_str || strcmp(matcher_str, str) != 0) {
                                        val = alertpanel(_("Entry not saved"),
                                                         _("The entry was not saved.\nClose anyway?"),
-                                                        GTK_STOCK_CLOSE, _("+_Continue editing"), NULL);
+                                                        GTK_STOCK_CLOSE,
+                                                _("_Continue editing"),
+                                                NULL,
+                                                ALERTFOCUS_SECOND);
                                        if (G_ALERTDEFAULT != val) {
                                                g_free(matcher_str);                                             
                                                g_free(str);
@@ -1951,11 +2176,12 @@ static void prefs_matcher_ok(void)
                }
                 g_free(str);
                gtk_widget_hide(matcher.window);
-               inc_unlock();
+               gtk_window_set_modal(GTK_WINDOW(matcher.window), FALSE);
                if (matchers_callback != NULL)
                        matchers_callback(matchers);
                matcherlist_free(matchers);
        }
+       inc_unlock();
 }
 
 /*!
@@ -1999,6 +2225,7 @@ static gchar *test_desc_strings[] = {
 static DescriptionWindow test_desc_win = { 
        NULL,
         NULL, 
+       TRUE,
         2,
         N_("Match Type: 'Test'"),
        N_("'Test' allows you to test a message or message element "
@@ -2013,22 +2240,26 @@ static DescriptionWindow test_desc_win = {
 /*!
  *\brief       Show Test action's info
  */
-static void prefs_matcher_test_info(void)
+static void prefs_matcher_test_info(GtkWidget *widget, GtkWidget *parent)
 {
+       test_desc_win.parent = parent;
        description_window_create(&test_desc_win);
 }
 
+#ifndef USE_ALT_ADDRBOOK
 static void prefs_matcher_addressbook_select(void)
 {
-       gchar *folderpath = NULL;
-       gboolean ret = FALSE;
-
-       folderpath = (gchar *) gtk_entry_get_text(GTK_ENTRY(GTK_BIN(matcher.addressbook_folder_combo)->child));
-       ret = addressbook_folder_selection(&folderpath);
-       if ( ret != FALSE && folderpath != NULL)
-               gtk_entry_set_text(GTK_ENTRY(GTK_BIN(matcher.addressbook_folder_combo)->child), folderpath);
+       const gchar *folderpath = NULL;
+       gchar *new_path = NULL;
+
+       folderpath = gtk_entry_get_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((matcher.addressbook_folder_combo)))));
+       new_path = addressbook_folder_selection(folderpath);
+       if (new_path) {
+               gtk_entry_set_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((matcher.addressbook_folder_combo)))), new_path);
+               g_free(new_path);
+       } 
 }
-
+#endif
 
 /*
  * list view
@@ -2076,6 +2307,7 @@ static GtkWidget *prefs_matcher_list_view_create(void)
        g_object_unref(model);  
        
        gtk_tree_view_set_rules_hint(list_view, prefs_common.use_stripes_everywhere);
+       gtk_tree_view_set_reorderable(list_view, TRUE);
        
        selector = gtk_tree_view_get_selection(list_view);
        gtk_tree_selection_set_mode(selector, GTK_SELECTION_BROWSE);
@@ -2115,8 +2347,14 @@ static void prefs_matcher_set_criteria(const gint criteria)
                break;
        case CRITERIA_AGE_GREATER:
        case CRITERIA_AGE_LOWER:
+       case CRITERIA_AGE_GREATER_HOURS:
+       case CRITERIA_AGE_LOWER_HOURS:
                match_criteria = MATCH_AGE;
                break;
+       case CRITERIA_DATE_AFTER:
+       case CRITERIA_DATE_BEFORE:
+               match_criteria = MATCH_DATE;
+               break;
        case CRITERIA_SCORE_GREATER:
        case CRITERIA_SCORE_LOWER:
        case CRITERIA_SCORE_EQUAL:
@@ -2133,12 +2371,14 @@ static void prefs_matcher_set_criteria(const gint criteria)
        case CRITERIA_CC:
        case CRITERIA_TO_OR_CC:
        case CRITERIA_NEWSGROUPS:
+       case CRITERIA_MESSAGEID:
        case CRITERIA_INREPLYTO:
        case CRITERIA_REFERENCES:
        case CRITERIA_HEADER:
                match_criteria = MATCH_HEADER;
                break;
        case CRITERIA_HEADERS_PART:
+       case CRITERIA_HEADERS_CONT:
        case CRITERIA_BODY_PART:
        case CRITERIA_MESSAGE:
                match_criteria = MATCH_PHRASE;
@@ -2161,6 +2401,8 @@ static void prefs_matcher_set_criteria(const gint criteria)
        case CRITERIA_FORWARDED:
        case CRITERIA_LOCKED:
        case CRITERIA_SPAM:
+       case CRITERIA_HAS_ATTACHMENT:
+       case CRITERIA_SIGNED:
                match_criteria = MATCH_FLAG;
                break;
        case CRITERIA_PARTIAL:
@@ -2183,6 +2425,7 @@ static void prefs_matcher_set_criteria(const gint criteria)
                                                criteria);
                break;
        case MATCH_AGE:
+       case MATCH_DATE:
        case MATCH_SCORE:
        case MATCH_SIZE:
        case MATCH_FLAG:
@@ -2210,6 +2453,8 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        GtkWidget *menu;
        GtkTreeIter iter;
        gboolean is_valid;
+       struct tm lt;
+       char  zone[6];
 
        if (currently_selected)
                return TRUE;
@@ -2248,6 +2493,8 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case MATCHCRITERIA_NOT_FORWARDED:
        case MATCHCRITERIA_NOT_LOCKED:
        case MATCHCRITERIA_NOT_SPAM:
+       case MATCHCRITERIA_HAS_NO_ATTACHMENT:
+       case MATCHCRITERIA_NOT_SIGNED:
        case MATCHCRITERIA_NOT_PARTIAL:
        case MATCHCRITERIA_NOT_COLORLABEL:
        case MATCHCRITERIA_NOT_IGNORE_THREAD:
@@ -2260,10 +2507,12 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case MATCHCRITERIA_NOT_TAG:
        case MATCHCRITERIA_NOT_TAGGED:
        case MATCHCRITERIA_NOT_NEWSGROUPS:
+       case MATCHCRITERIA_NOT_MESSAGEID:
        case MATCHCRITERIA_NOT_INREPLYTO:
        case MATCHCRITERIA_NOT_REFERENCES:
        case MATCHCRITERIA_NOT_HEADER:
        case MATCHCRITERIA_NOT_HEADERS_PART:
+       case MATCHCRITERIA_NOT_HEADERS_CONT:
        case MATCHCRITERIA_NOT_MESSAGE:
        case MATCHCRITERIA_NOT_BODY_PART:
        case MATCHCRITERIA_NOT_TEST:
@@ -2283,9 +2532,11 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case MATCHCRITERIA_NOT_TO_AND_NOT_CC:
        case MATCHCRITERIA_NOT_TAG:
        case MATCHCRITERIA_NOT_NEWSGROUPS:
+       case MATCHCRITERIA_NOT_MESSAGEID:
        case MATCHCRITERIA_NOT_INREPLYTO:
        case MATCHCRITERIA_NOT_REFERENCES:
        case MATCHCRITERIA_NOT_HEADERS_PART:
+       case MATCHCRITERIA_NOT_HEADERS_CONT:
        case MATCHCRITERIA_NOT_BODY_PART:
        case MATCHCRITERIA_NOT_MESSAGE:
        case MATCHCRITERIA_NOT_TEST:
@@ -2296,15 +2547,27 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case MATCHCRITERIA_TO_OR_CC:
        case MATCHCRITERIA_TAG:
        case MATCHCRITERIA_NEWSGROUPS:
+       case MATCHCRITERIA_MESSAGEID:
        case MATCHCRITERIA_INREPLYTO:
        case MATCHCRITERIA_REFERENCES:
        case MATCHCRITERIA_HEADERS_PART:
+       case MATCHCRITERIA_HEADERS_CONT:
        case MATCHCRITERIA_BODY_PART:
        case MATCHCRITERIA_MESSAGE:
        case MATCHCRITERIA_TEST:
                gtk_entry_set_text(GTK_ENTRY(matcher.string_entry), prop->expr);
                break;
 
+       case MATCHCRITERIA_DATE_AFTER:
+       case MATCHCRITERIA_DATE_BEFORE:
+               zone[0] = '\0';
+               procheader_date_parse_to_tm(prop->expr, &lt, zone);
+               gtk_calendar_select_day(GTK_CALENDAR(matcher.calendar), lt.tm_mday);
+               gtk_calendar_select_month(GTK_CALENDAR(matcher.calendar), lt.tm_mon, lt.tm_year + 1900);
+               gtkut_time_select_select_by_time(GTK_COMBO_BOX(matcher.time_entry), lt.tm_hour, lt.tm_min);
+
+               break;
+
        case MATCHCRITERIA_FOUND_IN_ADDRESSBOOK:
        case MATCHCRITERIA_NOT_FOUND_IN_ADDRESSBOOK:
        {
@@ -2314,7 +2577,7 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
                /* matcher expressions contain UNtranslated "Any"/"All",
                  select the relevant translated combo item */
                if (strcasecmp(prop->header, "All") == 0)
-                       header = (gchar*)Q_("Filtering Matcher Menu|All");
+                       header = (gchar*)C_("Filtering Matcher Menu", "All");
                else
                        if (strcasecmp(prop->header, "Any") == 0)
                                header = _("Any");
@@ -2326,7 +2589,7 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
                        expr = prop->expr;
 
                gtk_entry_set_text(GTK_ENTRY(matcher.header_addr_entry), header);
-               gtk_entry_set_text(GTK_ENTRY(GTK_BIN(matcher.addressbook_folder_combo)->child), expr);
+               gtk_entry_set_text(GTK_ENTRY(gtk_bin_get_child(GTK_BIN((matcher.addressbook_folder_combo)))), expr);
                break;
        }
 
@@ -2345,6 +2608,14 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
                }
                break;
                
+       case MATCHCRITERIA_AGE_GREATER_HOURS:
+       case MATCHCRITERIA_AGE_LOWER_HOURS:
+               gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo2),
+                                        AGE_HOURS);
+               gtk_spin_button_set_value(GTK_SPIN_BUTTON(
+                               matcher.numeric_entry), prop->value);
+               break;
+               
        case MATCHCRITERIA_SCORE_GREATER:
        case MATCHCRITERIA_SCORE_LOWER:
        case MATCHCRITERIA_SCORE_EQUAL:
@@ -2375,9 +2646,9 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
 
        case MATCHCRITERIA_NOT_COLORLABEL:
        case MATCHCRITERIA_COLORLABEL:
-               gtk_option_menu_set_history(GTK_OPTION_MENU(matcher.color_optmenu),
-                                           prop->value);
-               menu = gtk_option_menu_get_menu(GTK_OPTION_MENU(matcher.color_optmenu));
+               gtk_cmoption_menu_set_history(GTK_CMOPTION_MENU(matcher.color_optmenu),
+                                           prop->value + 1);
+               menu = gtk_cmoption_menu_get_menu(GTK_CMOPTION_MENU(matcher.color_optmenu));
                g_signal_emit_by_name(G_OBJECT(menu), "selection-done", menu);
                break;
 
@@ -2395,10 +2666,12 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case CRITERIA_CC:
        case CRITERIA_TO_OR_CC:
        case CRITERIA_NEWSGROUPS:
+       case CRITERIA_MESSAGEID:
        case CRITERIA_INREPLYTO:
        case CRITERIA_REFERENCES:
        case CRITERIA_HEADER:
        case CRITERIA_HEADERS_PART:
+       case CRITERIA_HEADERS_CONT:
        case CRITERIA_BODY_PART:
        case CRITERIA_MESSAGE:
        case CRITERIA_TAG:
@@ -2417,6 +2690,8 @@ static gboolean prefs_matcher_selected(GtkTreeSelection *selector,
        case CRITERIA_FORWARDED:
        case CRITERIA_LOCKED:
        case CRITERIA_SPAM:
+       case CRITERIA_HAS_ATTACHMENT:
+       case CRITERIA_SIGNED:
        case CRITERIA_COLORLABEL:
                gtk_combo_box_set_active(GTK_COMBO_BOX(matcher.match_combo2),
                                         negative_cond ? PREDICATE_FLAG_DISABLED :