fix a couple of memory leaks
[claws.git] / src / prefs_gtk.c
index 2127455dac237ce04f4ecaf59c722fcba12c9773..dc7e5cf10f6c98d4464fe199e01d8cdcacbf89d5 100644 (file)
@@ -1,10 +1,10 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2012 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * 
  */
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #define _GNU_SOURCE
@@ -40,7 +41,6 @@
 #include "utils.h"
 #include "gtkutils.h"
 #include "passcrypt.h"
-#include "base64.h"
 #include "codeconv.h"
 
 #define CL(x)  (((gulong) (x) >> (gulong) 8) & 0xFFUL)
@@ -65,6 +65,9 @@ static GHashTable *whole_cache = NULL;
 static gboolean prefs_read_config_from_cache(PrefParam *param, const gchar *label,
                               const gchar *rcfile);
 
+static void prefs_config_parse_one_line(PrefParam      *param,
+                                        const gchar    *buf);
+
 void prefs_read_config(PrefParam *param, const gchar *label,
                       const gchar *rcfile, const gchar *encoding)
 {
@@ -72,9 +75,9 @@ void prefs_read_config(PrefParam *param, const gchar *label,
        gchar buf[PREFSBUFSIZE];
        gchar *block_label;
 
-       g_return_if_fail(param != NULL);
-       g_return_if_fail(label != NULL);
-       g_return_if_fail(rcfile != NULL);
+       cm_return_if_fail(param != NULL);
+       cm_return_if_fail(label != NULL);
+       cm_return_if_fail(rcfile != NULL);
 
        if (encoding != NULL)
                g_warning("Encoding is ignored\n");
@@ -148,7 +151,7 @@ void prefs_read_config(PrefParam *param, const gchar *label,
        fclose(fp);
 }
 
-void prefs_config_parse_one_line(PrefParam *param, const gchar *buf)
+static void prefs_config_parse_one_line(PrefParam *param, const gchar *buf)
 {
        gint i;
        gint name_len;
@@ -206,8 +209,9 @@ void prefs_config_parse_one_line(PrefParam *param, const gchar *buf)
                                (gushort)atoi(value);
                        break;
                case P_COLOR:
-                       if (gdk_color_parse(value, &color)) 
+                       if (gdk_color_parse(value, &color)) {
                                *((gulong *)param[i].data) = RGB_FROM_GDK_COLOR(color); 
+                       }
                        else 
                                /* be compatible and accept ints */
                                *((gulong *)param[i].data) = strtoul(value, 0, 10); 
@@ -215,14 +219,16 @@ void prefs_config_parse_one_line(PrefParam *param, const gchar *buf)
                case P_PASSWORD:
                        g_free(*((gchar **)param[i].data));
                        if (value[0] == '!') {
-                               gchar tmp[1024];
-                               gint len;
-
-                               len = base64_decode(tmp, &value[1], strlen(value) - 1);
-                               passcrypt_decrypt(tmp, len);
-                               tmp[len] = '\0';
+                               gchar *tmp, buf[1024];
+                               gsize len;
+
+                               tmp = g_base64_decode(&value[1], &len);
+                               g_strlcat(buf, tmp, 1024);
+                               g_free(tmp);
+                               buf[len] = '\0';
+                               passcrypt_decrypt(buf, len);
                                *((gchar **)param[i].data) =
-                                       *tmp ? g_strdup(tmp) : NULL;
+                                       *buf ? g_strdup(buf) : NULL;
                        } else {
                                *((gchar **)param[i].data) =
                                        *value ? g_strdup(value) : NULL;
@@ -255,9 +261,9 @@ void prefs_write_config(PrefParam *param, const gchar *label,
        gchar *block_label = NULL;
        gboolean block_matched = FALSE;
 
-       g_return_if_fail(param != NULL);
-       g_return_if_fail(label != NULL);
-       g_return_if_fail(rcfile != NULL);
+       cm_return_if_fail(param != NULL);
+       cm_return_if_fail(label != NULL);
+       cm_return_if_fail(rcfile != NULL);
 
        rcpath = g_strconcat(get_rc_dir(), G_DIR_SEPARATOR_S, rcfile, NULL);
        if ((orig_fp = g_fopen(rcpath, "rb")) == NULL) {
@@ -378,7 +384,7 @@ gint prefs_write_param(PrefParam *param, FILE *fp)
                        break;
                case P_PASSWORD:
                        {
-                               gchar *tmp = NULL, tmp2[1024] = {0};
+                               gchar *tmp = NULL, *tmp2 = NULL;
 
                                tmp = *((gchar **)param[i].data);
                                if (tmp) {
@@ -387,13 +393,14 @@ gint prefs_write_param(PrefParam *param, FILE *fp)
                                        tmp = g_strdup(tmp);
                                        len = strlen(tmp);
                                        passcrypt_encrypt(tmp, len);
-                                       base64_encode(tmp2, tmp, len);
+                                       tmp2 = g_base64_encode(tmp, len);
                                        g_free(tmp);
                                        tmp = tmp2;
                                }
                                g_snprintf(buf, sizeof(buf), "%s=!%s\n", param[i].name,
                                           tmp ?
                                           tmp : "");
+                               g_free(tmp);
                        }
                        break;
                default:
@@ -418,14 +425,13 @@ void prefs_set_default(PrefParam *param)
        gint i;
        GdkColor color;
 
-       g_return_if_fail(param != NULL);
+       cm_return_if_fail(param != NULL);
 
        for (i = 0; param[i].name != NULL; i++) {
                if (!param[i].data) continue;
 
                switch (param[i].type) {
                case P_STRING:
-               case P_PASSWORD:
                        g_free(*((gchar **)param[i].data));
                        if (param[i].defval != NULL) {
                                if (!strncasecmp(param[i].defval, "ENV_", 4)) {
@@ -448,7 +454,16 @@ void prefs_set_default(PrefParam *param)
                                                g_strconcat(get_home_dir(),
                                                            param[i].defval + 1,
                                                            NULL);
-                               else if (param[i].defval[0] != '\0')
+                               else 
+                                       *((gchar **)param[i].data) =
+                                               g_strdup(param[i].defval);
+                       } else
+                               *((gchar **)param[i].data) = NULL;
+                       break;
+               case P_PASSWORD:
+                       g_free(*((gchar **)param[i].data));
+                       if (param[i].defval != NULL) {
+                               if (param[i].defval[0] != '\0')
                                        *((gchar **)param[i].data) =
                                                g_strdup(param[i].defval);
                                else
@@ -507,7 +522,7 @@ void prefs_free(PrefParam *param)
 {
        gint i;
 
-       g_return_if_fail(param != NULL);
+       cm_return_if_fail(param != NULL);
 
        for (i = 0; param[i].name != NULL; i++) {
                if (!param[i].data) continue;
@@ -523,63 +538,6 @@ void prefs_free(PrefParam *param)
        }
 }
 
-void prefs_dialog_create(PrefsDialog *dialog)
-{
-       GtkWidget *window;
-       GtkWidget *vbox;
-       GtkWidget *notebook;
-
-       GtkWidget *confirm_area;
-       GtkWidget *ok_btn;
-       GtkWidget *cancel_btn;
-       GtkWidget *apply_btn;
-
-       g_return_if_fail(dialog != NULL);
-
-       window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "prefs_gtk");
-       gtk_container_set_border_width (GTK_CONTAINER (window), 8);
-       gtk_window_set_position (GTK_WINDOW(window), GTK_WIN_POS_CENTER);
-       gtk_window_set_modal (GTK_WINDOW (window), TRUE);
-       gtk_window_set_resizable(GTK_WINDOW(window), TRUE);
-
-       vbox = gtk_vbox_new (FALSE, 6);
-       gtk_widget_show(vbox);
-       gtk_container_add (GTK_CONTAINER (window), vbox);
-
-       notebook = gtk_notebook_new ();
-       gtk_widget_show(notebook);
-       gtk_box_pack_start (GTK_BOX (vbox), notebook, TRUE, TRUE, 0);
-       gtk_container_set_border_width (GTK_CONTAINER (notebook), 2);
-       /* GTK_WIDGET_UNSET_FLAGS (notebook, GTK_CAN_FOCUS); */
-       gtk_notebook_set_scrollable (GTK_NOTEBOOK (notebook), TRUE);
-       
-       gtk_notebook_popup_enable (GTK_NOTEBOOK (notebook));
-
-       gtkut_stock_button_set_create(&confirm_area,
-                                     &ok_btn, GTK_STOCK_OK,
-                                     &cancel_btn, GTK_STOCK_CANCEL,
-                                     &apply_btn, GTK_STOCK_APPLY);
-       gtk_widget_show(confirm_area);
-       gtk_box_pack_end (GTK_BOX(vbox), confirm_area, FALSE, FALSE, 0);
-       gtk_widget_grab_default(ok_btn);
-
-       dialog->window     = window;
-       dialog->notebook   = notebook;
-       dialog->ok_btn     = ok_btn;
-       dialog->cancel_btn = cancel_btn;
-       dialog->apply_btn  = apply_btn;
-}
-
-void prefs_dialog_destroy(PrefsDialog *dialog)
-{
-       gtk_widget_destroy(dialog->window);
-       dialog->window     = NULL;
-       dialog->notebook   = NULL;
-       dialog->ok_btn     = NULL;
-       dialog->cancel_btn = NULL;
-       dialog->apply_btn  = NULL;
-}
-
 void prefs_button_toggled(GtkToggleButton *toggle_btn, GtkWidget *widget)
 {
        gboolean is_active;
@@ -633,7 +591,6 @@ void prefs_set_dialog_to_default(PrefParam *param)
 
                switch (tmpparam.type) {
                case P_STRING:
-               case P_PASSWORD:
                        if (tmpparam.defval) {
                                if (!g_ascii_strncasecmp(tmpparam.defval, "ENV_", 4)) {
                                        str_data = g_strdup(g_getenv(param[i].defval + 4));
@@ -650,6 +607,9 @@ void prefs_set_dialog_to_default(PrefParam *param)
                        }
                        tmpparam.data = &tmpparam.defval;
                        break;
+               case P_PASSWORD:
+                       tmpparam.data = &tmpparam.defval;
+                       break;
                case P_INT:
                        if (tmpparam.defval)
                                int_data = atoi(tmpparam.defval);
@@ -697,7 +657,7 @@ void prefs_set_data_from_entry(PrefParam *pparam)
        gchar **str;
        const gchar *entry_str;
 
-       g_return_if_fail(*pparam->widget != NULL);
+       cm_return_if_fail(*pparam->widget != NULL);
 
        entry_str = gtk_entry_get_text(GTK_ENTRY(*pparam->widget));
 
@@ -720,11 +680,29 @@ void prefs_set_data_from_entry(PrefParam *pparam)
        }
 }
 
+void prefs_set_escaped_data_from_entry(PrefParam *pparam)
+{
+       gchar **str;
+
+       cm_return_if_fail(*pparam->widget != NULL);
+
+       switch (pparam->type) {
+       case P_STRING:
+               str = (gchar **)pparam->data;
+               g_free(*str);
+               *str = pref_get_pref_from_entry(GTK_ENTRY(*pparam->widget));
+               break;
+       default:
+               g_warning("Invalid escaped PrefType for GtkEntry widget: %d\n",
+                         pparam->type);
+       }
+}
+
 void prefs_set_entry(PrefParam *pparam)
 {
        gchar **str;
 
-       g_return_if_fail(*pparam->widget != NULL);
+       cm_return_if_fail(*pparam->widget != NULL);
 
        switch (pparam->type) {
        case P_STRING:
@@ -747,13 +725,31 @@ void prefs_set_entry(PrefParam *pparam)
        }
 }
 
+void prefs_set_entry_from_escaped(PrefParam *pparam)
+{
+       gchar **str;
+
+       cm_return_if_fail(*pparam->widget != NULL);
+
+       switch (pparam->type) {
+       case P_STRING:
+               str = (gchar **)pparam->data;
+               pref_set_entry_from_pref(GTK_ENTRY(*pparam->widget),
+                                  *str ? *str : "");
+               break;
+       default:
+               g_warning("Invalid escaped PrefType for GtkEntry widget: %d\n",
+                         pparam->type);
+       }
+}
+
 void prefs_set_data_from_text(PrefParam *pparam)
 {
        gchar **str;
        gchar *text = NULL, *tp = NULL;
        gchar *tmp, *tmpp;
 
-       g_return_if_fail(*pparam->widget != NULL);
+       cm_return_if_fail(*pparam->widget != NULL);
 
        switch (pparam->type) {
        case P_STRING:
@@ -772,7 +768,7 @@ void prefs_set_data_from_text(PrefParam *pparam)
                        tp = text = gtk_text_buffer_get_text(buffer, &start, &end, FALSE);
                }
 
-               g_return_if_fail (tp && text);
+               cm_return_if_fail (tp && text);
 
                if (text[0] == '\0') {
                        *str = NULL;
@@ -800,6 +796,24 @@ void prefs_set_data_from_text(PrefParam *pparam)
        }
 }
 
+void prefs_set_escaped_data_from_text(PrefParam *pparam)
+{
+       gchar **str;
+
+       cm_return_if_fail(*pparam->widget != NULL);
+
+       switch (pparam->type) {
+       case P_STRING:
+               str = (gchar **)pparam->data;
+               g_free(*str);
+               *str = pref_get_pref_from_textview(GTK_TEXT_VIEW(*pparam->widget));
+               break;
+       default:
+               g_warning("Invalid escaped PrefType for GtkText widget: %d\n",
+                         pparam->type);
+       }
+}
+
 void prefs_set_text(PrefParam *pparam)
 {
        gchar *buf, *sp, *bufp;
@@ -808,7 +822,7 @@ void prefs_set_text(PrefParam *pparam)
        GtkTextBuffer *buffer;
        GtkTextIter iter;
 
-       g_return_if_fail(*pparam->widget != NULL);
+       cm_return_if_fail(*pparam->widget != NULL);
 
        switch (pparam->type) {
        case P_STRING:
@@ -843,10 +857,28 @@ void prefs_set_text(PrefParam *pparam)
        }
 }
 
+void prefs_set_text_from_escaped(PrefParam *pparam)
+{
+       gchar **str;
+
+       cm_return_if_fail(*pparam->widget != NULL);
+
+       switch (pparam->type) {
+       case P_STRING:
+               str = (gchar **)pparam->data;
+               pref_set_textview_from_pref(GTK_TEXT_VIEW(*pparam->widget),
+                                *str ? *str : "");
+               break;
+       default:
+               g_warning("Invalid escaped PrefType for GtkTextView widget: %d\n",
+                         pparam->type);
+       }
+}
+
 void prefs_set_data_from_toggle(PrefParam *pparam)
 {
-       g_return_if_fail(pparam->type == P_BOOL);
-       g_return_if_fail(*pparam->widget != NULL);
+       cm_return_if_fail(pparam->type == P_BOOL);
+       cm_return_if_fail(*pparam->widget != NULL);
        
        *((gboolean *)pparam->data) =
                gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(*pparam->widget));
@@ -854,8 +886,8 @@ void prefs_set_data_from_toggle(PrefParam *pparam)
 
 void prefs_set_toggle(PrefParam *pparam)
 {
-       g_return_if_fail(pparam->type == P_BOOL);
-       g_return_if_fail(*pparam->widget != NULL);
+       cm_return_if_fail(pparam->type == P_BOOL);
+       cm_return_if_fail(*pparam->widget != NULL);
 
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(*pparam->widget),
                                     *((gboolean *)pparam->data));
@@ -863,7 +895,7 @@ void prefs_set_toggle(PrefParam *pparam)
 
 void prefs_set_data_from_spinbtn(PrefParam *pparam)
 {
-       g_return_if_fail(*pparam->widget != NULL);
+       cm_return_if_fail(*pparam->widget != NULL);
 
        switch (pparam->type) {
        case P_INT:
@@ -884,7 +916,7 @@ void prefs_set_data_from_spinbtn(PrefParam *pparam)
 
 void prefs_set_spinbtn(PrefParam *pparam)
 {
-       g_return_if_fail(*pparam->widget != NULL);
+       cm_return_if_fail(*pparam->widget != NULL);
 
        switch (pparam->type) {
        case P_INT:
@@ -906,7 +938,8 @@ static GSList *prefs_pages = NULL;
 void prefs_gtk_open(void)
 {
        prefswindow_open(_("Preferences"), prefs_pages, NULL,
-                       &prefs_common.prefswin_width, &prefs_common.prefswin_height);
+                       &prefs_common.prefswin_width, &prefs_common.prefswin_height,
+                       NULL, NULL);
 }
 
 void prefs_gtk_register_page(PrefsPage *page)
@@ -933,12 +966,14 @@ static void prefs_destroy_file_cache(gpointer to_free)
 
 static int prefs_cache_sections(GHashTable *file_cache, const gchar *rcfile)
 {
-       FILE *fp = g_fopen(rcfile, "rb");
+       FILE *fp = NULL;
        gchar buf[PREFSBUFSIZE];
        GHashTable *section_cache = NULL;
 
+       if (rcfile)
+               fp = g_fopen(rcfile, "rb");
        if (!fp) {
-               debug_print("cache: %s: %s", rcfile, strerror(errno));
+               debug_print("cache: %s: %s\n", rcfile?rcfile:"(null)", strerror(errno));
                return -1;
        }
        
@@ -1000,7 +1035,7 @@ static int prefs_cache(const gchar *rcfile)
        GHashTable *file_cache = g_hash_table_new_full(g_str_hash, g_str_equal, 
                                        g_free, prefs_destroy_file_cache);
        
-       debug_print("new file '%s'\n", rcfile);
+       debug_print("new file '%s'\n", rcfile?rcfile:"(null)");
        g_hash_table_insert(whole_cache, g_strdup(rcfile), file_cache);
        
        return prefs_cache_sections(file_cache, rcfile);
@@ -1061,13 +1096,13 @@ static gboolean prefs_read_config_from_cache(PrefParam *param, const gchar *labe
        sections_table = g_hash_table_lookup(whole_cache, rcfile);
        
        if (sections_table == NULL) {
-               g_warning("Can't find %s in the whole cache\n", rcfile);
+               g_warning("Can't find %s in the whole cache\n", rcfile?rcfile:"(null)");
                return FALSE;
        }
        values_table = g_hash_table_lookup(sections_table, label);
        
        if (values_table == NULL) {
-               debug_print("no '%s' section in '%s' cache\n", label, rcfile);
+               debug_print("no '%s' section in '%s' cache\n", label?label:"(null)", rcfile?rcfile:"(null)");
                return TRUE;
        }
        g_hash_table_foreach(values_table, prefs_parse_cache, param);