Use Delete button instead of Remove (tooltips and other places already
[claws.git] / src / prefs_filtering.c
index de0a0b86738d823ad000e53ddc71a3882ca825aa..ea2d195a160f1ce0cce232e7db8c68db75d59913 100644 (file)
@@ -1,6 +1,6 @@
 /*
  * Sylpheed -- a GTK+ based, lightweight, and fast e-mail client
- * Copyright (C) 1999-2007 Hiroyuki Yamamoto and the Claws Mail team
+ * Copyright (C) 1999-2013 Hiroyuki Yamamoto and the Claws Mail team
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,6 +19,7 @@
 
 #ifdef HAVE_CONFIG_H
 #  include "config.h"
+#include "claws-features.h"
 #endif
 
 #include "defs.h"
@@ -26,7 +27,6 @@
 #include <glib.h>
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>
-#include <gtk/gtkoptionmenu.h>
 #include <gdk/gdkkeysyms.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include "gtkutils.h"
 #include "alertpanel.h"
 #include "folder.h"
+#include "folder_item_prefs.h"
 #include "filtering.h"
 #include "addr_compl.h"
 #include "manual.h"
 #include "combobox.h"
 #include "menu.h"
+#include "account.h"
 
 #include "matcher_parser.h"
 #include "matcher.h"
@@ -97,29 +99,34 @@ static void prefs_filtering_set_dialog      (const gchar *header,
 static void prefs_filtering_set_list   (void);
 
 /* callback functions */
-static void prefs_filtering_register_cb        (void);
-static void prefs_filtering_substitute_cb      (void);
-static void prefs_filtering_delete_cb  (void);
-static void prefs_filtering_delete_all_cb(void);
-static void prefs_filtering_clear_cb(void);
-static void prefs_filtering_duplicate_cb(void);
-static void prefs_filtering_top                (void);
-static void prefs_filtering_page_up(void);
-static void prefs_filtering_up         (void);
-static void prefs_filtering_down       (void);
-static void prefs_filtering_page_down(void);
-static void prefs_filtering_bottom     (void);
+static gboolean prefs_filtering_search_func_cb (GtkTreeModel *model, gint column, 
+                                               const gchar *key, GtkTreeIter *iter, 
+                                               gpointer search_data);
+static void prefs_filtering_register_cb        (gpointer action, gpointer data);
+static void prefs_filtering_substitute_cb      (gpointer action, gpointer data);
+static void prefs_filtering_delete_cb  (gpointer action, gpointer data);
+static void prefs_filtering_delete_all_cb(gpointer action, gpointer data);
+static void prefs_filtering_clear_cb(gpointer action, gpointer data);
+static void prefs_filtering_duplicate_cb(gpointer action, gpointer data);
+static void prefs_filtering_top                (gpointer action, gpointer data);
+static void prefs_filtering_page_up    (gpointer action, gpointer data);
+static void prefs_filtering_up         (gpointer action, gpointer data);
+static void prefs_filtering_down       (gpointer action, gpointer data);
+static void prefs_filtering_page_down  (gpointer action, gpointer data);
+static void prefs_filtering_bottom     (gpointer action, gpointer data);
 static gint prefs_filtering_deleted    (GtkWidget      *widget,
                                         GdkEventAny    *event,
                                         gpointer        data);
+static void prefs_filtering_row_selected(GtkTreeSelection *selection,
+                                        GtkTreeView *list_view);
 static gboolean prefs_filtering_key_pressed(GtkWidget  *widget,
                                         GdkEventKey    *event,
                                         gpointer        data);
-static void prefs_filtering_cancel     (void);
-static void prefs_filtering_ok         (void);
+static void prefs_filtering_cancel     (gpointer action, gpointer data);
+static void prefs_filtering_ok         (gpointer action, gpointer data);
 
-static void prefs_filtering_condition_define   (void);
-static void prefs_filtering_action_define(void);
+static void prefs_filtering_condition_define   (gpointer action, gpointer data);
+static void prefs_filtering_action_define      (gpointer action, gpointer data);
 static gint prefs_filtering_list_view_set_row  (gint row, FilteringProp * prop);
                                          
 static void prefs_filtering_reset_dialog       (void);
@@ -150,7 +157,7 @@ static void prefs_filtering_list_view_get_rule_info (GtkWidget *list,
 static GtkWidget *prefs_filtering_list_view_create     (void);
 static void prefs_filtering_create_list_view_columns   (GtkWidget *list_view);
 
-void prefs_filtering_select_row(GtkTreeView *list_view, GtkTreePath *path);
+static void prefs_filtering_select_row(GtkTreeView *list_view, GtkTreePath *path);
 
 static void prefs_filtering_account_option_menu_populate(void);
 
@@ -218,6 +225,7 @@ void prefs_filtering_open(GSList ** p_processing,
        }
 
        gtk_widget_show(filtering.window);
+       gtk_window_set_modal(GTK_WINDOW(filtering.window), TRUE);
 
        start_address_completion(NULL);
 }
@@ -225,7 +233,7 @@ void prefs_filtering_open(GSList ** p_processing,
 static void prefs_filtering_size_allocate_cb(GtkWidget *widget,
                                         GtkAllocation *allocation)
 {
-       g_return_if_fail(allocation != NULL);
+       cm_return_if_fail(allocation != NULL);
 
        prefs_common.filteringwin_width = allocation->width;
        prefs_common.filteringwin_height = allocation->height;
@@ -242,6 +250,7 @@ static void prefs_filtering_close(void)
                                (filtering.cond_list_view)));
        gtk_list_store_clear(store);
        gtk_widget_hide(filtering.window);
+       gtk_window_set_modal(GTK_WINDOW(filtering.window), FALSE);
        inc_unlock();
 }
 
@@ -252,9 +261,10 @@ static void prefs_filtering_account_option_menu_populate(void)
 
        accounts = account_get_list();
 
-       g_return_if_fail(accounts != NULL);
+       cm_return_if_fail(accounts != NULL);
 
-       COMBOBOX_ADD(filtering.account_combobox_list, Q_("Filtering Account Menu|All"), 0);
+       COMBOBOX_ADD(filtering.account_combobox_list, C_("Filtering Account Menu", "All"), 0);
+       COMBOBOX_ADD(filtering.account_combobox_list, NULL, 0);
        for (; accounts != NULL; accounts = accounts->next) {
                PrefsAccount *ac = (PrefsAccount *)accounts->data;
 
@@ -316,10 +326,12 @@ static void prefs_filtering_create(void)
 
        GtkWidget *btn_vbox;
        GtkWidget *top_btn;
-       GtkWidget *page_up_btn;
        GtkWidget *up_btn;
        GtkWidget *down_btn;
+#ifndef GENERIC_UMPC
+       GtkWidget *page_up_btn;
        GtkWidget *page_down_btn;
+#endif
        GtkWidget *bottom_btn;
        GtkWidget *table;
        static GdkGeometry geometry;
@@ -329,7 +341,6 @@ static void prefs_filtering_create(void)
        window = gtkut_window_new(GTK_WINDOW_TOPLEVEL, "prefs_filtering");
        gtk_container_set_border_width (GTK_CONTAINER (window), 8);
        gtk_window_set_position (GTK_WINDOW (window), GTK_WIN_POS_CENTER);
-       gtk_window_set_modal (GTK_WINDOW (window), TRUE);
        gtk_window_set_resizable(GTK_WINDOW (window), TRUE);
 
        vbox = gtk_vbox_new (FALSE, 6);
@@ -410,7 +421,7 @@ static void prefs_filtering_create(void)
                          (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
                          (GtkAttachOptions) (0), 0, 0);
 
-       cond_btn = gtk_button_new_with_label (_(" Define... "));
+       cond_btn =  gtk_button_new_with_mnemonic (_(" Def_ine... "));
        gtk_widget_show (cond_btn);
        gtk_table_attach (GTK_TABLE (table), cond_btn, 2, 3, 2, 3,
                          (GtkAttachOptions) (GTK_FILL),
@@ -432,7 +443,7 @@ static void prefs_filtering_create(void)
                          (GtkAttachOptions) (GTK_FILL|GTK_EXPAND),
                          (GtkAttachOptions) (0), 0, 0);
 
-       action_btn = gtk_button_new_with_label (_(" Define... "));
+       action_btn =  gtk_button_new_with_mnemonic (_(" De_fine... "));
        gtk_widget_show (action_btn);
        gtk_table_attach (GTK_TABLE (table), action_btn, 2, 3, 3, 4,
                          (GtkAttachOptions) (GTK_FILL),
@@ -460,25 +471,36 @@ static void prefs_filtering_create(void)
        gtk_box_pack_start (GTK_BOX (btn_hbox), reg_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT (reg_btn), "clicked",
                         G_CALLBACK(prefs_filtering_register_cb), NULL);
+       CLAWS_SET_TIP(reg_btn,
+                       _("Append the new rule above to the list"));
 
-       subst_btn = gtkut_get_replace_btn (_("Replace"));
+       subst_btn = gtkut_get_replace_btn (_("_Replace"));
        gtk_widget_show (subst_btn);
        gtk_box_pack_start (GTK_BOX (btn_hbox), subst_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT (subst_btn), "clicked",
                         G_CALLBACK(prefs_filtering_substitute_cb),
                         NULL);
+       CLAWS_SET_TIP(subst_btn,
+                       _("Replace the selected rule in list with the rule above"));
 
-       del_btn = gtk_button_new_from_stock (GTK_STOCK_DELETE);
-       gtk_widget_show (del_btn);
+       del_btn = gtk_button_new_with_mnemonic (_("D_elete"));
+       gtk_button_set_image(GTK_BUTTON(del_btn),
+                       gtk_image_new_from_stock(GTK_STOCK_REMOVE,GTK_ICON_SIZE_BUTTON));
        gtk_box_pack_start (GTK_BOX (btn_hbox), del_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT (del_btn), "clicked",
                        G_CALLBACK(prefs_filtering_delete_cb), NULL);
+       CLAWS_SET_TIP(del_btn,
+                       _("Delete the selected rule from the list"));
 
-       clear_btn = gtk_button_new_from_stock (GTK_STOCK_CLEAR);
+       clear_btn = gtk_button_new_with_mnemonic (_("C_lear"));
+       gtk_button_set_image(GTK_BUTTON(clear_btn),
+                       gtk_image_new_from_stock(GTK_STOCK_CLEAR,GTK_ICON_SIZE_BUTTON));
        gtk_widget_show (clear_btn);
        gtk_box_pack_start (GTK_BOX (btn_hbox), clear_btn, FALSE, TRUE, 0);
        g_signal_connect(G_OBJECT (clear_btn), "clicked",
                        G_CALLBACK(prefs_filtering_clear_cb), NULL);
+       CLAWS_SET_TIP(clear_btn,
+                       _("Clear all the input fields in the dialog"));
 
        cond_hbox = gtk_hbox_new (FALSE, 8);
        gtk_widget_show (cond_hbox);
@@ -506,40 +528,56 @@ static void prefs_filtering_create(void)
        gtk_box_pack_start (GTK_BOX (btn_vbox), top_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT (top_btn), "clicked",
                         G_CALLBACK(prefs_filtering_top), NULL);
+       CLAWS_SET_TIP(top_btn,
+                       _("Move the selected rule to the top"));
 
-       page_up_btn = gtk_button_new_with_mnemonic (_("Page up"));
+#ifndef GENERIC_UMPC
+       page_up_btn = gtk_button_new_with_mnemonic (_("Page u_p"));
        gtk_button_set_image(GTK_BUTTON(page_up_btn),
                        gtk_image_new_from_stock(GTK_STOCK_GO_UP,GTK_ICON_SIZE_BUTTON));
        gtk_widget_show (page_up_btn);
        gtk_box_pack_start (GTK_BOX (btn_vbox), page_up_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT (page_up_btn), "clicked",
                         G_CALLBACK(prefs_filtering_page_up), NULL);
+       CLAWS_SET_TIP(page_up_btn,
+                       _("Move the selected rule one page up"));
+#endif
 
        up_btn = gtk_button_new_from_stock (GTK_STOCK_GO_UP);
        gtk_widget_show (up_btn);
        gtk_box_pack_start (GTK_BOX (btn_vbox), up_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT (up_btn), "clicked",
                         G_CALLBACK(prefs_filtering_up), NULL);
+       CLAWS_SET_TIP(up_btn,
+                       _("Move the selected rule up"));
 
        down_btn = gtk_button_new_from_stock (GTK_STOCK_GO_DOWN);
        gtk_widget_show (down_btn);
        gtk_box_pack_start (GTK_BOX (btn_vbox), down_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT (down_btn), "clicked",
                         G_CALLBACK(prefs_filtering_down), NULL);
+       CLAWS_SET_TIP(down_btn,
+                       _("Move the selected rule down"));
 
-       page_down_btn = gtk_button_new_with_mnemonic (_("Page down"));
+#ifndef GENERIC_UMPC
+       page_down_btn = gtk_button_new_with_mnemonic (_("Page dow_n"));
        gtk_button_set_image(GTK_BUTTON(page_down_btn),
                        gtk_image_new_from_stock(GTK_STOCK_GO_DOWN,GTK_ICON_SIZE_BUTTON));
        gtk_widget_show (page_down_btn);
        gtk_box_pack_start (GTK_BOX (btn_vbox), page_down_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT (page_down_btn), "clicked",
                         G_CALLBACK(prefs_filtering_page_down), NULL);
+       CLAWS_SET_TIP(page_down_btn,
+                       _("Move the selected rule one page down"));
+#endif
 
        bottom_btn = gtk_button_new_from_stock (GTK_STOCK_GOTO_BOTTOM);
        gtk_widget_show (bottom_btn);
        gtk_box_pack_start (GTK_BOX (btn_vbox), bottom_btn, FALSE, FALSE, 0);
        g_signal_connect(G_OBJECT (bottom_btn), "clicked",
                         G_CALLBACK(prefs_filtering_bottom), NULL);
+       CLAWS_SET_TIP(bottom_btn,
+                       _("Move the selected rule to the bottom"));
 
        if (!geometry.min_height) {
                geometry.min_width = 500;
@@ -614,81 +652,12 @@ void prefs_filtering_rename_path(const gchar *old_path, const gchar *new_path)
 static void rename_path(GSList * filters,
                        const gchar * old_path, const gchar * new_path)
 {
-       gchar *base;
-       gchar *prefix;
-       gchar *suffix;
-       gchar *dest_path;
-       gchar *old_path_with_sep;
-       gint destlen;
-       gint prefixlen;
-       gint oldpathlen;
-        GSList * action_cur;
         GSList * cur;
 
-       oldpathlen = strlen(old_path);
-       old_path_with_sep = g_strconcat(old_path,G_DIR_SEPARATOR_S,NULL);
-
        for (cur = filters; cur != NULL; cur = cur->next) {
                FilteringProp   *filtering = (FilteringProp *)cur->data;
-                
-                for(action_cur = filtering->action_list ; action_cur != NULL ;
-                    action_cur = action_cur->next) {
-
-                        FilteringAction *action = action_cur->data;
-                        
-                        if (action->type == MATCHACTION_SET_TAG ||
-                           action->type == MATCHACTION_UNSET_TAG)
-                               continue;
-                        if (!action->destination) 
-                               continue;
-                        
-                        destlen = strlen(action->destination);
-                        
-                        if (destlen > oldpathlen) {
-                                prefixlen = destlen - oldpathlen;
-                                suffix = action->destination + prefixlen;
-                                
-                                if (!strncmp(old_path, suffix, oldpathlen)) {
-                                        prefix = g_malloc0(prefixlen + 1);
-                                        strncpy2(prefix, action->destination, prefixlen);
-                                        
-                                        base = suffix + oldpathlen;
-                                        while (*base == G_DIR_SEPARATOR) base++;
-                                        if (*base == '\0')
-                                                dest_path = g_strconcat(prefix,
-                                                    G_DIR_SEPARATOR_S,
-                                                    new_path, NULL);
-                                        else
-                                                dest_path = g_strconcat(prefix,
-                                                    G_DIR_SEPARATOR_S,
-                                                    new_path,
-                                                    G_DIR_SEPARATOR_S,
-                                                    base, NULL);
-                                        
-                                        g_free(prefix);
-                                        g_free(action->destination);
-                                        action->destination = dest_path;
-                                } else { /* for non-leaf folders */
-                                        /* compare with trailing slash */
-                                        if (!strncmp(old_path_with_sep, action->destination, oldpathlen+1)) {
-                                                
-                                                suffix = action->destination + oldpathlen + 1;
-                                                dest_path = g_strconcat(new_path,
-                                                    G_DIR_SEPARATOR_S,
-                                                    suffix, NULL);
-                                                g_free(action->destination);
-                                                action->destination = dest_path;
-                                        }
-                                }
-                        } else {
-                                /* folder-moving a leaf */
-                                if (!strcmp(old_path, action->destination)) {
-                                        dest_path = g_strdup(new_path);
-                                        g_free(action->destination);
-                                        action->destination = dest_path;
-                                }
-                        }
-                }
+               filtering_action_list_rename_path(filtering->action_list,
+                                                 old_path, new_path);
         }
 }
 
@@ -704,9 +673,9 @@ static gboolean prefs_filtering_rename_path_func(GNode *node, gpointer data)
        old_path = paths[0];
        new_path = paths[1];
 
-       g_return_val_if_fail(old_path != NULL, FALSE);
-       g_return_val_if_fail(new_path != NULL, FALSE);
-       g_return_val_if_fail(node != NULL, FALSE);
+       cm_return_val_if_fail(old_path != NULL, FALSE);
+       cm_return_val_if_fail(new_path != NULL, FALSE);
+       cm_return_val_if_fail(node != NULL, FALSE);
 
         item = node->data;
         if (!item || !item->prefs)
@@ -757,9 +726,9 @@ static gboolean prefs_filtering_rename_tag_func(GNode *node, gpointer data)
        old_tag = tags[0];
        new_tag = tags[1];
 
-       g_return_val_if_fail(old_tag != NULL, FALSE);
-       g_return_val_if_fail(new_tag != NULL, FALSE);
-       g_return_val_if_fail(node != NULL, FALSE);
+       cm_return_val_if_fail(old_tag != NULL, FALSE);
+       cm_return_val_if_fail(new_tag != NULL, FALSE);
+       cm_return_val_if_fail(node != NULL, FALSE);
 
         item = node->data;
         if (!item || !item->prefs)
@@ -844,8 +813,8 @@ static gboolean prefs_filtering_delete_path_func(GNode *node, gpointer data)
        FolderItem *item;
         GSList ** p_filters;
        
-       g_return_val_if_fail(path != NULL, FALSE);
-       g_return_val_if_fail(node != NULL, FALSE);
+       cm_return_val_if_fail(path != NULL, FALSE);
+       cm_return_val_if_fail(node != NULL, FALSE);
 
         item = node->data;
         if (!item || !item->prefs)
@@ -895,7 +864,7 @@ static void prefs_filtering_set_dialog(const gchar *header, const gchar *key)
                                account_name = ac_prefs->account_name;
                }
                if (account_name == NULL)
-                       account_name = (gchar *)Q_("Filtering Account Menu|All");
+                       account_name = (gchar *)C_("Filtering Account Menu", "All");
 
                cond_str = filteringprop_to_string(prop);
                subst_char(cond_str, '\t', ':');
@@ -935,6 +904,29 @@ static void prefs_filtering_reset_dialog(void)
        gtk_entry_set_text(GTK_ENTRY(filtering.action_entry), "");
 }
 
+static gboolean prefs_filtering_search_func_cb (GtkTreeModel *model, gint column, const gchar *key, 
+                                               GtkTreeIter *iter, gpointer search_data) 
+{
+       gchar *store_string;
+       gboolean retval;
+       GtkTreePath *path;
+
+       gtk_tree_model_get (model, iter, column, &store_string, -1);
+
+       if (!store_string || !key) return FALSE;
+
+
+       retval = (g_ascii_strncasecmp (key, store_string, strlen(key)) != 0);
+
+       g_free(store_string);
+       debug_print("selecting row\n");
+       path = gtk_tree_model_get_path(model, iter);
+       prefs_filtering_select_row(GTK_TREE_VIEW(filtering.cond_list_view), path);
+       gtk_tree_path_free(path);
+
+       return retval;
+}
+
 static void prefs_filtering_set_list(void)
 {
        gint row = 1;
@@ -982,14 +974,15 @@ static void prefs_filtering_set_list(void)
 static gint prefs_filtering_list_view_set_row(gint row, FilteringProp * prop)
 {
        GtkTreeView *list_view = GTK_TREE_VIEW(filtering.cond_list_view);
-       gchar *str;
+       gchar *str = NULL;
        GtkListStore *list_store;
        gchar *name = NULL;
        gint account_id = 0;
-       gchar *account_name = (gchar *)Q_("Filtering Account Menu|All");
+       gchar *account_name = (gchar *)C_("Filtering Account Menu", "All");
        gboolean enabled = TRUE;
 
-       str = filteringprop_to_string(prop);
+       if (prop)
+               str = filteringprop_to_string(prop);
        if (str == NULL)
                return -1;
 
@@ -1032,7 +1025,7 @@ static void prefs_filtering_condition_define_done(MatcherList * matchers)
        }
 }
 
-static void prefs_filtering_condition_define(void)
+static void prefs_filtering_condition_define(gpointer action, gpointer data)
 {
        gchar * cond_str;
        MatcherList * matchers = NULL;
@@ -1068,7 +1061,7 @@ static void prefs_filtering_action_define_done(GSList * action_list)
        }
 }
 
-static void prefs_filtering_action_define(void)
+static void prefs_filtering_action_define(gpointer action, gpointer data)
 {
        gchar * action_str;
        GSList * action_list = NULL;
@@ -1149,7 +1142,7 @@ fail:
        return prop;
 }
 
-static void prefs_filtering_register_cb(void)
+static void prefs_filtering_register_cb(gpointer action, gpointer data)
 {
        FilteringProp *prop;
        
@@ -1164,7 +1157,7 @@ static void prefs_filtering_register_cb(void)
        modified = TRUE;
 }
 
-static void prefs_filtering_substitute_cb(void)
+static void prefs_filtering_substitute_cb(gpointer action, gpointer data)
 {
        gint selected_row = gtkut_list_view_get_selected_row
                (filtering.cond_list_view);
@@ -1192,11 +1185,13 @@ static void prefs_filtering_substitute_cb(void)
 
        filteringprop_free(prop);
 
-       prefs_filtering_reset_dialog();
+       prefs_filtering_row_selected(gtk_tree_view_get_selection(
+                               GTK_TREE_VIEW(filtering.cond_list_view)),
+                               GTK_TREE_VIEW(filtering.cond_list_view));
        modified = TRUE;
 }
 
-static void prefs_filtering_delete_cb(void)
+static void prefs_filtering_delete_cb(gpointer action, gpointer data)
 {
        GtkTreeView *list_view = GTK_TREE_VIEW(filtering.cond_list_view);
        GtkTreeModel *model;
@@ -1222,12 +1217,12 @@ static void prefs_filtering_delete_cb(void)
        modified = TRUE;
 }
 
-static void prefs_filtering_delete_all_cb(void)
+static void prefs_filtering_delete_all_cb(gpointer action, gpointer data)
 {
        GtkListStore *list_store;
        
        if (alertpanel(_("Delete all rules"),
-                      _("Do you really want to delete all rules?"),
+                      _("Do you really want to delete all the rules?"),
                       GTK_STOCK_CANCEL, "+"GTK_STOCK_DELETE, NULL) == G_ALERTDEFAULT)
                return;
 
@@ -1238,12 +1233,12 @@ static void prefs_filtering_delete_all_cb(void)
        modified = TRUE;
 }
 
-static void prefs_filtering_clear_cb(void)
+static void prefs_filtering_clear_cb(gpointer action, gpointer data)
 {
        prefs_filtering_reset_dialog();
 }
 
-static void prefs_filtering_duplicate_cb(void)
+static void prefs_filtering_duplicate_cb(gpointer action, gpointer data)
 {
        gint selected_row = gtkut_list_view_get_selected_row
                (filtering.cond_list_view);     
@@ -1274,7 +1269,7 @@ static void prefs_filtering_duplicate_cb(void)
        modified = TRUE;
 }
 
-static void prefs_filtering_top(void)
+static void prefs_filtering_top(gpointer action, gpointer data)
 {
        gint row;
        GtkTreeIter top, sel;
@@ -1295,16 +1290,15 @@ static void prefs_filtering_top(void)
        modified = TRUE;
 }
 
-static void prefs_filtering_page_up(void)
+static void prefs_filtering_page_up(gpointer action, gpointer data)
 {
-       gint row, target_row, n_rows;
+       gint row, target_row;
        GtkTreeIter selected, target;
        GtkTreeModel *model;
        GtkTreePath *path;
        GdkRectangle cell_rect, view_rect;
 
        model = gtk_tree_view_get_model(GTK_TREE_VIEW(filtering.cond_list_view));       
-       n_rows = gtk_tree_model_iter_n_children(model, NULL);
        row = gtkut_list_view_get_selected_row(filtering.cond_list_view);
        if (row <= 1)
                return;
@@ -1327,7 +1321,7 @@ static void prefs_filtering_page_up(void)
        gtkut_list_view_select_row(filtering.cond_list_view, target_row);
        modified = TRUE;
 }
-static void prefs_filtering_up(void)
+static void prefs_filtering_up(gpointer action, gpointer data)
 {
        gint row;
        GtkTreeIter top, sel;
@@ -1348,7 +1342,7 @@ static void prefs_filtering_up(void)
        modified = TRUE;
 }
 
-static void prefs_filtering_down(void)
+static void prefs_filtering_down(gpointer action, gpointer data)
 {
        gint row, n_rows;
        GtkTreeIter top, sel;
@@ -1369,7 +1363,7 @@ static void prefs_filtering_down(void)
        modified = TRUE;
 }
 
-static void prefs_filtering_page_down(void)
+static void prefs_filtering_page_down(gpointer action, gpointer data)
 {
        gint row, target_row, n_rows;
        GtkTreeIter selected, target;
@@ -1402,7 +1396,7 @@ static void prefs_filtering_page_down(void)
        modified = TRUE;
 }
 
-static void prefs_filtering_bottom(void)
+static void prefs_filtering_bottom(gpointer action, gpointer data)
 {
        gint row, n_rows;
        GtkTreeIter top, sel;
@@ -1443,10 +1437,8 @@ static void prefs_filtering_select_set(FilteringProp *prop)
        gtk_entry_set_text(GTK_ENTRY(filtering.cond_entry), matcher_str);
 
         action_str = filteringaction_list_to_string(prop->action_list);
-       if (matcher_str == NULL) {
-               return;
-       }
-       gtk_entry_set_text(GTK_ENTRY(filtering.action_entry), action_str);
+       if (action_str != NULL)
+               gtk_entry_set_text(GTK_ENTRY(filtering.action_entry), action_str);
 
        g_free(action_str);
        g_free(matcher_str);
@@ -1455,15 +1447,15 @@ static void prefs_filtering_select_set(FilteringProp *prop)
 static gint prefs_filtering_deleted(GtkWidget *widget, GdkEventAny *event,
                                 gpointer data)
 {
-       prefs_filtering_cancel();
+       prefs_filtering_cancel(NULL, NULL);
        return TRUE;
 }
 
 static gboolean prefs_filtering_key_pressed(GtkWidget *widget, GdkEventKey *event,
                                     gpointer data)
 {
-       if (event && event->keyval == GDK_Escape) {
-               prefs_filtering_cancel();
+       if (event && event->keyval == GDK_KEY_Escape) {
+               prefs_filtering_cancel(NULL, NULL);
                return TRUE;                    
        }
        return FALSE;
@@ -1482,7 +1474,7 @@ static gboolean prefs_filtering_check_mod(gboolean check_changed_list)
        if (check_changed_list) {
                if (modified && alertpanel(_("Filtering rules not saved"),
                                         _("The list of filtering rules have been modified. Close anyway?"),
-                                        GTK_STOCK_CLOSE, _("+_Continue editing"), 
+                                        GTK_STOCK_CLOSE, g_strconcat("+", _("_Continue editing"), NULL),
                                         NULL) != G_ALERTDEFAULT) {
                        return TRUE;
                }
@@ -1504,7 +1496,7 @@ static gboolean prefs_filtering_check_mod(gboolean check_changed_list)
                if (!filtering_str) {
                        val = alertpanel(_("Entry not saved"),
                                 _("The entry was not saved. Close anyway?"),
-                                GTK_STOCK_CLOSE, _("+_Continue editing"), NULL);
+                                GTK_STOCK_CLOSE, g_strconcat("+", _("_Continue editing"),NULL), NULL);
                        if (G_ALERTDEFAULT != val) {
                                g_free(filtering_str);
                                g_free(str); /* fixed two leaks: huzzah! */
@@ -1526,7 +1518,7 @@ static gboolean prefs_filtering_check_mod(gboolean check_changed_list)
                    strlen(action)) {
                        val = alertpanel(_("Entry not saved"),
                                 _("The entry was not saved. Close anyway?"),
-                                GTK_STOCK_CLOSE, _("+_Continue editing"), NULL);
+                                GTK_STOCK_CLOSE, g_strconcat("+", _("_Continue editing"), NULL), NULL);
                        if (G_ALERTDEFAULT != val) {
                                g_free(name);
                                g_free(condition);
@@ -1541,7 +1533,7 @@ static gboolean prefs_filtering_check_mod(gboolean check_changed_list)
        return FALSE;
 }
 
-static void prefs_filtering_ok(void)
+static void prefs_filtering_ok(gpointer action, gpointer data)
 {
        if (prefs_filtering_check_mod(FALSE))
                return;
@@ -1551,7 +1543,7 @@ static void prefs_filtering_ok(void)
        prefs_filtering_close();
 }
 
-static void prefs_filtering_cancel(void)
+static void prefs_filtering_cancel(gpointer action, gpointer data)
 {
        if (prefs_filtering_check_mod(TRUE))
                return;
@@ -1692,16 +1684,37 @@ static void prefs_filtering_list_view_get_rule_info(GtkWidget *list, gint row,
        }
 }
 
-static GtkItemFactory *prefs_filtering_popup_factory = NULL;
+static GtkActionGroup *prefs_filtering_popup_action = NULL;
 static GtkWidget *prefs_filtering_popup_menu = NULL;
 
-static GtkItemFactoryEntry prefs_filtering_popup_entries[] =
+static GtkActionEntry prefs_filtering_popup_entries[] =
 {
-       {N_("/_Delete"),                NULL, prefs_filtering_delete_cb, 0, NULL, NULL},
-       {N_("/Delete _all"),            NULL, prefs_filtering_delete_all_cb, 0, NULL, NULL},
-       {N_("/D_uplicate"),             NULL, prefs_filtering_duplicate_cb, 0, NULL, NULL},
+       {"PrefsFilteringPopup",                 NULL, "PrefsFilteringPopup" },
+       {"PrefsFilteringPopup/Delete",          NULL, N_("_Delete"), NULL, NULL, G_CALLBACK(prefs_filtering_delete_cb) },
+       {"PrefsFilteringPopup/DeleteAll",       NULL, N_("Delete _all"), NULL, NULL, G_CALLBACK(prefs_filtering_delete_all_cb) },
+       {"PrefsFilteringPopup/Duplicate",       NULL, N_("D_uplicate"), NULL, NULL, G_CALLBACK(prefs_filtering_duplicate_cb) },
+#ifdef GENERIC_UMPC
+       {"PrefsFilteringPopup/---",             NULL, "---", NULL, NULL, NULL },
+       {"PrefsFilteringPopup/PageUp",          NULL, N_("Move one page up"), NULL, NULL, G_CALLBACK(prefs_filtering_page_up) },
+       {"PrefsFilteringPopup/PageDown",        NULL, N_("Move one page down"), NULL, NULL, G_CALLBACK(prefs_filtering_page_down) },
+#endif
 };
 
+static void prefs_filtering_row_selected(GtkTreeSelection *selection,
+                                        GtkTreeView *list_view)
+{
+       GtkTreePath *path;
+       GtkTreeIter iter;
+       GtkTreeModel *model;
+       
+       if (!gtk_tree_selection_get_selected(selection, &model, &iter))
+               return;
+       
+       path = gtk_tree_model_get_path(model, &iter);
+       prefs_filtering_select_row(list_view, path);
+       gtk_tree_path_free(path);
+}
+
 static gint prefs_filtering_list_btn_pressed(GtkWidget *widget, GdkEventButton *event,
                                    GtkTreeView *list_view)
 {
@@ -1726,24 +1739,32 @@ static gint prefs_filtering_list_btn_pressed(GtkWidget *widget, GdkEventButton *
                        gint row;
 
                        if (!prefs_filtering_popup_menu) {
-                               gint n_entries = sizeof(prefs_filtering_popup_entries) /
-                                               sizeof(prefs_filtering_popup_entries[0]);
-                               prefs_filtering_popup_menu = menu_create_items(prefs_filtering_popup_entries,
-                                                                 n_entries, "<PrefsFilteringPopupMenu>",
-                                                                 &prefs_filtering_popup_factory, list_view);
+                               prefs_filtering_popup_action = cm_menu_create_action_group("PrefsFilteringPopup", prefs_filtering_popup_entries,
+                                       G_N_ELEMENTS(prefs_filtering_popup_entries), (gpointer)list_view);
+                               MENUITEM_ADDUI("/Menus", "PrefsFilteringPopup", "PrefsFilteringPopup", GTK_UI_MANAGER_MENU)
+                               MENUITEM_ADDUI("/Menus/PrefsFilteringPopup", "Delete", "PrefsFilteringPopup/Delete", GTK_UI_MANAGER_MENUITEM)
+                               MENUITEM_ADDUI("/Menus/PrefsFilteringPopup", "DeleteAll", "PrefsFilteringPopup/DeleteAll", GTK_UI_MANAGER_MENUITEM)
+                               MENUITEM_ADDUI("/Menus/PrefsFilteringPopup", "Duplicate", "PrefsFilteringPopup/Duplicate", GTK_UI_MANAGER_MENUITEM)
+#ifdef GENERIC_UMPC
+                               MENUITEM_ADDUI("/Menus/PrefsFilteringPopup", "Separator1", "PrefsFilteringPopup/---", GTK_UI_MANAGER_SEPARATOR)
+                               MENUITEM_ADDUI("/Menus/PrefsFilteringPopup", "PageUp", "PrefsFilteringPopup/PageUp", GTK_UI_MANAGER_MENUITEM)
+                               MENUITEM_ADDUI("/Menus/PrefsFilteringPopup", "PageDown", "PrefsFilteringPopup/PageDown", GTK_UI_MANAGER_MENUITEM)
+#endif
+                               prefs_filtering_popup_menu = gtk_menu_item_get_submenu(GTK_MENU_ITEM(
+                                       gtk_ui_manager_get_widget(gtkut_ui_manager(), "/Menus/PrefsFilteringPopup")) );
                        }
 
                        /* grey out some popup menu items if there is no selected row */
                        row = gtkut_list_view_get_selected_row(GTK_WIDGET(list_view));
-                       menu_set_sensitive(prefs_filtering_popup_factory, "/Delete", (row > 0));
-                       menu_set_sensitive(prefs_filtering_popup_factory, "/Duplicate", (row > 0));
+                       cm_menu_set_sensitive("PrefsFilteringPopup/Delete", (row > 0));
+                       cm_menu_set_sensitive("PrefsFilteringPopup/Duplicate", (row > 0));
 
                        /* grey out seom popup menu items if there is no row
                           (not counting the (New) one at row 0) */
                        non_empty = gtk_tree_model_get_iter_first(model, &iter);
                        if (non_empty)
                                non_empty = gtk_tree_model_iter_next(model, &iter);
-                       menu_set_sensitive(prefs_filtering_popup_factory, "/Delete all", non_empty);
+                       cm_menu_set_sensitive("PrefsFilteringPopup/DeleteAll", non_empty);
 
                        gtk_menu_popup(GTK_MENU(prefs_filtering_popup_menu), 
                                   NULL, NULL, NULL, NULL, 
@@ -1776,19 +1797,12 @@ static GtkWidget *prefs_filtering_list_view_create(void)
 
        list_view = GTK_TREE_VIEW(gtk_tree_view_new_with_model(GTK_TREE_MODEL
                (prefs_filtering_create_data_store())));
-#ifdef MAEMO
+#ifdef GENERIC_UMPC
        g_object_set(list_view, "allow-checkbox-mode", FALSE, NULL);
 #endif
 
-#ifndef MAEMO
        g_signal_connect(G_OBJECT(list_view), "popup-menu",
                         G_CALLBACK(prefs_filtering_list_popup_menu), list_view);
-#else
-       gtk_widget_tap_and_hold_setup(GTK_WIDGET(list_view), NULL, NULL,
-                       GTK_TAP_AND_HOLD_NONE | GTK_TAP_AND_HOLD_NO_INTERNALS);
-       g_signal_connect(G_OBJECT(list_view), "tap-and-hold",
-                        G_CALLBACK(prefs_filtering_list_popup_menu), list_view);
-#endif
        g_signal_connect(G_OBJECT(list_view), "button-press-event",
                        G_CALLBACK(prefs_filtering_list_btn_pressed), list_view);
        
@@ -1797,6 +1811,8 @@ static GtkWidget *prefs_filtering_list_view_create(void)
        
        selector = gtk_tree_view_get_selection(list_view);
        gtk_tree_selection_set_mode(selector, GTK_SELECTION_BROWSE);
+       g_signal_connect(G_OBJECT(selector), "changed",
+                        G_CALLBACK(prefs_filtering_row_selected), list_view);
 
        /* create the columns */
        prefs_filtering_create_list_view_columns(GTK_WIDGET(list_view));
@@ -1871,13 +1887,17 @@ static void prefs_filtering_create_list_view_columns(GtkWidget *list_view)
                 renderer,
                 "text", PREFS_FILTERING_RULE,
                 NULL);
+
+       gtk_tree_view_set_search_column(GTK_TREE_VIEW(list_view), PREFS_FILTERING_NAME);
+       gtk_tree_view_set_search_equal_func(GTK_TREE_VIEW(list_view), prefs_filtering_search_func_cb , NULL, NULL);
+       
        gtk_tree_view_append_column(GTK_TREE_VIEW(list_view), column);          
 }
 
 /*!
  *\brief       Triggered when a row has to be selected
  */
-void prefs_filtering_select_row(GtkTreeView *list_view, GtkTreePath *path)
+static void prefs_filtering_select_row(GtkTreeView *list_view, GtkTreePath *path)
 {
        GtkTreeModel *model = gtk_tree_view_get_model(list_view);